1 # Copyright 1999-2019 Free Software Foundation, Inc.
3 # This program is free software; you can redistribute it and/or modify
4 # it under the terms of the GNU General Public License as published by
5 # the Free Software Foundation; either version 3 of the License, or
6 # (at your option) any later version.
8 # This program is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details.
13 # You should have received a copy of the GNU General Public License
14 # along with this program. If not, see <http://www.gnu.org/licenses/>.
16 # Test essential Machine interface (MI) operations
18 # Verify that, using the MI, we can create, update, delete variables.
22 load_lib mi-support.exp
30 standard_testfile var-cmd.c
32 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
33 untested "failed to compile"
38 mi_gdb_reinitialize_dir $srcdir/$subdir
39 mi_gdb_load ${binfile}
41 set line_dct_end [gdb_get_line_number "{int a = 0;}"]
43 mi_create_breakpoint "$srcfile:$line_dct_end" \
44 "break-insert operation" \
45 -number 1 -func do_children_tests -file ".*var-cmd.c" \
49 mi_expect_stop "breakpoint-hit" "do_children_tests" "" ".*var-cmd.c" \
50 $line_dct_end { "" "disp=\"keep\"" } "run to main"
52 # Prevent symbol on the address being printed.
53 mi_gdb_test "-gdb-set print symbol off"
61 # Test: c_variable-6.1
62 # Desc: create variable bar
63 mi_create_varobj bar bar "create local variable bar"
65 # Test: c_variable-6.2
66 # Desc: type of variable bar
67 mi_gdb_test "-var-info-type bar" \
68 "\\^done,type=\"int\"" \
69 "info type variable bar"
71 # Test: c_variable-6.3
72 # Desc: format of variable bar
73 mi_gdb_test "-var-show-format bar" \
74 "\\^done,format=\"natural\"" \
75 "show format variable bar"
77 # Test: c_variable-6.4
78 # Desc: value of variable bar
79 mi_gdb_test "-var-evaluate-expression bar" \
80 "\\^done,value=\"2121\"" \
83 # Test: c_variable-6.5
84 # Desc: change format of bar to zero-padded hexadecimal
85 mi_gdb_test "-var-set-format bar zero-hexadecimal" \
86 "\\^done,format=\"zero-hexadecimal\",value=\"0x0.*849\"" \
87 "set format variable bar in zero-padded hexadecimal"
89 # Desc: change format of bar to hex
90 mi_gdb_test "-var-set-format bar hexadecimal" \
91 "\\^done,format=\"hexadecimal\",value=\"0x849\"" \
92 "set format variable bar in hex"
94 # Test: c_variable-6.6
95 # Desc: value of bar with new format
96 mi_gdb_test "-var-evaluate-expression bar" \
97 "\\^done,value=\"0x849\"" \
98 "eval variable bar with new format"
100 # Test: c_variable-6.7
101 # Desc: change value of bar
102 mi_gdb_test "-var-assign bar 3" \
103 "\\^done,value=\"0x3\"" \
104 "assing to variable bar"
106 mi_gdb_test "-var-set-format bar decimal" \
107 "\\^done,format=\"decimal\",value=\"3\"" \
108 "set format variable bar in decimal"
110 mi_gdb_test "-var-evaluate-expression bar" \
111 "\\^done,value=\"3\"" \
112 "eval variable bar with new value"
114 mi_gdb_test "-var-delete bar" \
115 "\\^done,ndeleted=\"1\"" \
118 # Test: c_variable-6.11
119 # Desc: create variable foo
120 mi_create_varobj foo foo "create local variable foo"
122 # Test: c_variable-6.12
123 # Desc: type of variable foo
124 mi_gdb_test "-var-info-type foo" \
125 "\\^done,type=\"int \\*\"" \
126 "info type variable foo"
128 # Test: c_variable-6.13
129 # Desc: format of variable foo
130 mi_gdb_test "-var-show-format foo" \
131 "\\^done,format=\"natural\"" \
132 "show format variable foo in natural"
134 # Test: c_variable-6.14
135 # Desc: value of variable foo
136 mi_gdb_test "-var-evaluate-expression foo" \
137 "\\^done,value=\"$hex\"" \
138 "eval variable foo in natural"
140 # Test: c_variable-6.15
141 # Desc: change format of var to octal
142 mi_gdb_test "-var-set-format foo octal" \
143 "\\^done,format=\"octal\",value=\"$octal\"" \
144 "set format variable foo in octal"
146 mi_gdb_test "-var-show-format foo" \
147 "\\^done,format=\"octal\"" \
148 "show format variable foo in octal"
150 # Test: c_variable-6.16
151 # Desc: value of foo with new format
152 mi_gdb_test "-var-evaluate-expression foo" \
153 "\\^done,value=\"\[0-7\]+\"" \
154 "eval variable foo in octal"
156 # Test: c_variable-6.17
157 # Desc: change value of foo
158 mi_gdb_test "-var-assign foo 3" \
159 "\\^done,value=\"03\"" \
160 "assing to variable foo"
162 mi_gdb_test "-var-set-format foo decimal" \
163 "\\^done,format=\"decimal\",value=\"3\"" \
164 "set format variable foo decimal"
166 # Test: c_variable-6.18
167 # Desc: check new value of foo
168 mi_gdb_test "-var-evaluate-expression foo" \
169 "\\^done,value=\"3\"" \
170 "eval variable foo in decimal"
173 # Test: c_variable-6.19
174 # Desc: check optional format parameter of var-evaluate-expression
175 # and check that current format is not changed
176 mi_gdb_test "-var-evaluate-expression -f hex foo" \
177 "\\^done,value=\"0x3\"" \
178 "eval variable foo in hex"
180 mi_gdb_test "-var-show-format foo" \
181 "\\^done,format=\"decimal\"" \
182 "show format variable foo after eval in hex"
184 mi_gdb_test "-var-evaluate-expression -f octal foo" \
185 "\\^done,value=\"03\"" \
186 "eval variable -f octal foo"
188 mi_gdb_test "-var-show-format foo" \
189 "\\^done,format=\"decimal\"" \
190 "show format variable foo after eval in octal"
192 mi_gdb_test "-var-evaluate-expression -f decimal foo" \
193 "\\^done,value=\"3\"" \
194 "eval variable -f decimal foo"
196 mi_gdb_test "-var-show-format foo" \
197 "\\^done,format=\"decimal\"" \
198 "show format variable foo after eval in decimal"
200 mi_gdb_test "-var-evaluate-expression -f nat foo" \
201 "\\^done,value=\"0x3\"" \
202 "eval variable -f nat foo"
204 mi_gdb_test "-var-show-format foo" \
205 "\\^done,format=\"decimal\"" \
206 "show format variable foo after eval in natural"
208 mi_gdb_test "-var-evaluate-expression -f bin foo" \
209 "\\^done,value=\"11\"" \
210 "eval variable foo in binary"
212 mi_gdb_test "-var-show-format foo" \
213 "\\^done,format=\"decimal\"" \
214 "show format variable foo after eval in binary"
216 mi_gdb_test "-var-delete foo" \
217 "\\^done,ndeleted=\"1\"" \
220 # Test: c_variable-6.21
221 # Desc: create variable weird and children
222 mi_create_varobj weird weird "create local variable weird"
224 mi_list_varobj_children weird {
225 {weird.integer integer 0 int}
226 {weird.character character 0 char}
227 {weird.char_ptr char_ptr 1 "char \\*"}
228 {weird.long_int long_int 0 "long"}
229 {weird.int_ptr_ptr int_ptr_ptr 1 "int \\*\\*"}
230 {weird.long_array long_array 10 "long \\[10\\]"}
231 {weird.func_ptr func_ptr 0 "void \\(\\*\\)\\((void)?\\)"}
232 {weird.func_ptr_struct func_ptr_struct 0 \
233 "struct _struct_decl \\(\\*\\)(\\(int, char \\*, long\\))?"}
234 {weird.func_ptr_ptr func_ptr_ptr 0 \
235 "struct _struct_decl \\*\\(\\*\\)\\((int, char \\*, long)?\\)"}
236 {weird.u1 u1 4 "union \\{\\.\\.\\.\\}"}
237 {weird.s2 s2 4 "struct \\{\\.\\.\\.\\}"}
238 } "get children local variable weird"
241 # Test: c_variable-6.23
242 # Desc: change format of weird.func_ptr and weird.func_ptr_ptr
243 mi_gdb_test "-var-set-format weird.func_ptr hexadecimal" \
244 "\\^done,format=\"hexadecimal\",value=\"$hex\"" \
245 "set format variable weird.func_ptr in hex (1)"
247 mi_gdb_test "-var-show-format weird.func_ptr" \
248 "\\^done,format=\"hexadecimal\"" \
249 "show format variable weird.func_ptr (hex)"
251 mi_gdb_test "-var-set-format weird.func_ptr_ptr hexadecimal" \
252 "\\^done,format=\"hexadecimal\",value=\"$hex\"" \
253 "set format variable weird.func_ptr_ptr in hex"
255 mi_gdb_test "-var-show-format weird.func_ptr_ptr" \
256 "\\^done,format=\"hexadecimal\"" \
257 "show format variable weird.func_ptr_ptr (hex)"
259 mi_gdb_test "-var-set-format weird.func_ptr zero-hexadecimal" \
260 "\\^done,format=\"zero-hexadecimal\",value=\"$hex\"" \
261 "set format variable weird.func_ptr in zero-padded hex"
263 mi_gdb_test "-var-show-format weird.func_ptr" \
264 "\\^done,format=\"zero-hexadecimal\"" \
265 "show format variable weird.func_ptr (zhex)"
267 mi_gdb_test "-var-set-format weird.func_ptr_ptr zero-hexadecimal" \
268 "\\^done,format=\"zero-hexadecimal\",value=\"$hex\"" \
269 "set format variable weird.func_ptr_ptr in zero-padded hex"
271 mi_gdb_test "-var-show-format weird.func_ptr_ptr" \
272 "\\^done,format=\"zero-hexadecimal\"" \
273 "show format variable weird.func_ptr_ptr (zhex)"
275 # Test: c_variable-6.24
276 # Desc: format of weird and children
277 mi_gdb_test "-var-set-format weird natural" \
278 "\\^done,format=\"natural\",value=\"$hex\"" \
279 "set format variable weird"
281 mi_gdb_test "-var-set-format weird.integer natural" \
282 "\\^done,format=\"natural\",value=\"123\"" \
283 "set format variable weird.integer"
285 mi_gdb_test "-var-set-format weird.character natural" \
286 "\\^done,format=\"natural\",value=\"0 '\\\\\\\\000'\"" \
287 "set format variable weird.character"
289 mi_gdb_test "-var-set-format weird.char_ptr natural" \
290 "\\^done,format=\"natural\",value=\"$hex \\\\\"hello\\\\\"\"" \
291 "set format variable weird.char_ptr"
293 mi_gdb_test "-var-set-format weird.long_int natural" \
294 "\\^done,format=\"natural\",value=\"0\"" \
295 "set format variable weird.long_int"
297 mi_gdb_test "-var-set-format weird.int_ptr_ptr natural" \
298 "\\^done,format=\"natural\",value=\"$hex\"" \
299 "set format variable weird.int_ptr_ptr"
301 mi_gdb_test "-var-set-format weird.long_array natural" \
302 "\\^done,format=\"natural\",value=\"\\\[10\\\]\"" \
303 "set format variable weird.long_array"
305 mi_gdb_test "-var-set-format weird.func_ptr hexadecimal" \
306 "\\^done,format=\"hexadecimal\",value=\"$hex\"" \
307 "set format variable weird.func_ptr in hex (2)"
309 mi_gdb_test "-var-set-format weird.func_ptr_struct hexadecimal" \
310 "\\^done,format=\"hexadecimal\",value=\"$hex\"" \
311 "set format variable weird.func_ptr_struct"
313 mi_gdb_test "-var-set-format weird.func_ptr_ptr natural" \
314 "\\^done,format=\"natural\",value=\"$hex <nothing2>\"" \
315 "set format variable weird.func_ptr_ptr in natural"
317 mi_gdb_test "-var-set-format weird.u1 natural" \
318 "\\^done,format=\"natural\",value=\"\{...\}\"" \
319 "set format variable weird.u1"
321 mi_gdb_test "-var-set-format weird.s2 natural" \
322 "\\^done,format=\"natural\",value=\"\{...\}\"" \
323 "set format variable weird.s2"
325 # Test: c_variable-6.25
326 # Desc: value of weird and children
327 #gdbtk_test c_variable-6.25 {value of weird and children} {
329 # foreach v [lsort [array names var]] f [list x "" "" x x x x d d d d d] {
330 # lappend values [value $v $f]
334 #} {ok ok ok ok ok ok ok ok weird.long_array ok weird.s2 weird.u1}
336 # Test: c_variable-6.26
337 # Desc: change format of weird and children to octal
338 #gdbtk_test c_variable-6.26 {change format of weird and children to octal} {
340 # foreach v [lsort [array names var]] {
341 # $var($v) format octal
342 # lappend formats [$var($v) format]
346 #} {octal octal octal octal octal octal octal octal octal octal octal octal}
348 # Test: c_variable-6.27
349 # Desc: value of weird and children with new format
350 #gdbtk_test c_variable-6.27 {value of foo with new format} {
352 # foreach v [lsort [array names var]] {
353 # lappend values [value $v o]
357 #} {ok ok ok ok ok ok ok ok weird.long_array ok weird.s2 weird.u1}
359 # Test: c_variable-6.30
360 # Desc: create more children of weird
361 #gdbtk_test c_variable-6.30 {create more children of weird} {
362 # foreach v [array names var] {
366 # # Do it twice to get more children
367 # foreach v [array names var] {
371 # lsort [array names var]
372 #} {weird weird.char_ptr weird.character weird.func_ptr weird.func_ptr_ptr weird.func_ptr_struct weird.int_ptr_ptr weird.int_ptr_ptr.*int_ptr_ptr weird.int_ptr_ptr.*int_ptr_ptr.**int_ptr_ptr weird.integer weird.long_array weird.long_array.0 weird.long_array.1 weird.long_array.2 weird.long_array.3 weird.long_array.4 weird.long_array.5 weird.long_array.6 weird.long_array.7 weird.long_array.8 weird.long_array.9 weird.long_int weird.s2 weird.s2.g weird.s2.h weird.s2.i weird.s2.i.0 weird.s2.i.1 weird.s2.i.2 weird.s2.i.3 weird.s2.i.4 weird.s2.i.5 weird.s2.i.6 weird.s2.i.7 weird.s2.i.8 weird.s2.i.9 weird.s2.u2 weird.s2.u2.f weird.s2.u2.u1s1 weird.s2.u2.u1s2 weird.u1 weird.u1.a weird.u1.b weird.u1.c weird.u1.d}
374 # Test: c_variable-6.31
375 # Desc: check that all children of weird change
376 # Ok, obviously things like weird.s2 and weird.u1 will not change!
377 #gdbtk_test *c_variable-6.31 {check that all children of weird change (ops, we are now reporting array names as changed in this case - seems harmless though)} {
378 # $var(weird) value 0x2121
380 #} {{weird.integer weird.character weird.char_ptr weird.long_int weird.int_ptr_ptr weird.int_ptr_ptr.*int_ptr_ptr weird.int_ptr_ptr.*int_ptr_ptr.**int_ptr_ptr weird.long_array.0 weird.long_array.1 weird.long_array.2 weird.long_array.3 weird.long_array.4 weird.long_array.5 weird.long_array.6 weird.long_array.7 weird.long_array.8 weird.long_array.9 weird.func_ptr weird.func_ptr_struct weird.func_ptr_ptr weird.u1.a weird.u1.b weird.u1.c weird.u1.d weird.s2.u2.f weird.s2.g weird.s2.h weird.s2.i.0 weird.s2.i.1 weird.s2.i.2 weird.s2.i.3 weird.s2.i.4 weird.s2.i.5 weird.s2.i.6 weird.s2.i.7 weird.s2.i.8 weird.s2.i.9} {weird.s2.i weird.s2.u2 weird weird.s2.u2.u1s1 weird.s2.u2.u1s2 weird.s2 weird.long_array weird.u1} {}}
382 mi_gdb_test "-var-delete weird" \
383 "\\^done,ndeleted=\"12\"" \
389 # Special Display Tests #
393 # Stop at the end of "do_special_tests"
395 set line_dst_incr_a_2 [gdb_get_line_number "incr_a(2);"]
397 mi_create_breakpoint "$line_dst_incr_a_2" \
398 "break-insert operation 2" \
399 -number 2 -func do_special_tests -file ".*var-cmd.c" \
400 -line $line_dst_incr_a_2
402 mi_execute_to "exec-continue" "breakpoint-hit" "do_special_tests" "" \
403 ".*var-cmd.c" $line_dst_incr_a_2 { "" "disp=\"keep\"" } \
404 "continue to do_special_tests"
406 # Test: c_variable-7.10
407 # Desc: create union u
408 mi_create_varobj u u "create local variable u"
410 # Test: c_variable-7.11
412 mi_gdb_test "-var-evaluate-expression u" \
413 "\\^done,value=\"\{\\.\\.\\.\}\"" \
416 # Test: c_variable-7.12
418 mi_gdb_test "-var-info-type u" \
419 "\\^done,type=\"union named_union\"" \
420 "info type variable u"
422 # Test: c_variable-7.13
423 # Desc: is u editable
424 mi_gdb_test "-var-show-attributes u" \
425 "\\^done,attr=\"noneditable\"" \
428 # Test: c_variable-7.14
429 # Desc: number of children of u
430 mi_gdb_test "-var-info-num-children u" \
431 "\\^done,numchild=\"2\"" \
432 "get number of children of u"
434 # Test: c_variable-7.15
435 # Desc: children of u
436 mi_list_varobj_children u {
437 {u.integer integer 0 int}
438 {u.char_ptr char_ptr 1 {char \*}}
439 } "get children of u"
441 # Test: c_variable-7.20
443 mi_create_varobj anonu anonu "create local variable anonu"
445 # Test: c_variable-7.21
446 # Desc: value of anonu
447 mi_gdb_test "-var-evaluate-expression anonu" \
448 "\\^done,value=\"\{\\.\\.\\.\}\"" \
449 "eval variable anonu"
451 # Test: c_variable-7.22
452 # Desc: type of anonu
453 mi_gdb_test "-var-info-type anonu" \
454 "\\^done,type=\"union \{\\.\\.\\.\}\"" \
455 "info type variable anonu"
457 # Test: c_variable-7.23
458 # Desc: is anonu editable
459 mi_gdb_test "-var-show-attributes anonu" \
460 "\\^done,attr=\"noneditable\"" \
463 # Test: c_variable-7.24
464 # Desc: number of children of anonu
465 mi_gdb_test "-var-info-num-children anonu" \
466 "\\^done,numchild=\"3\"" \
467 "get number of children of anonu"
469 # Test: c_variable-7.25
470 # Desc: children of anonu
471 mi_list_varobj_children "anonu" {
475 } "get children of anonu"
477 # Test: c_variable-7.30
478 # Desc: create struct s
479 mi_create_varobj s s "create local variable s"
482 # Test: c_variable-7.31
484 mi_gdb_test "-var-evaluate-expression s" \
485 "\\^done,value=\"\{\\.\\.\\.\}\"" \
488 # Test: c_variable-7.32
490 mi_gdb_test "-var-info-type s" \
491 "\\^done,type=\"struct _simple_struct\"" \
492 "info type variable s"
494 # Test: c_variable-7.33
495 # Desc: is s editable
496 mi_gdb_test "-var-show-attributes s" \
497 "\\^done,attr=\"noneditable\"" \
500 # Test: c_variable-7.34
501 # Desc: number of children of s
502 mi_gdb_test "-var-info-num-children s" \
503 "\\^done,numchild=\"6\"" \
504 "get number of children of s"
506 # Test: c_variable-7.35
507 # Desc: children of s
508 mi_list_varobj_children s {
509 {s.integer integer 0 int}
510 {s.unsigned_integer unsigned_integer 0 "unsigned int"}
511 {s.character character 0 char}
512 {s.signed_character signed_character 0 "signed char"}
513 {s.char_ptr char_ptr 1 {char \*}}
514 {s.array_of_10 array_of_10 10 {int \[10\]}}
515 } "get children of s"
516 #} {integer unsigned_integer character signed_character char_ptr array_of_10}
518 # Test: c_variable-7.40
520 mi_create_varobj anons anons "create local variable anons"
522 # Test: c_variable-7.41
523 # Desc: value of anons
524 mi_gdb_test "-var-evaluate-expression anons" \
525 "\\^done,value=\"\{\\.\\.\\.\}\"" \
526 "eval variable anons"
528 # Test: c_variable-7.42
529 # Desc: type of anons
530 mi_gdb_test "-var-info-type anons" \
531 "\\^done,type=\"struct \{\\.\\.\\.\}\"" \
532 "info type variable anons"
534 # Test: c_variable-7.43
535 # Desc: is anons editable
536 mi_gdb_test "-var-show-attributes anons" \
537 "\\^done,attr=\"noneditable\"" \
540 # Test: c_variable-7.44
541 # Desc: number of children of anons
542 mi_gdb_test "-var-info-num-children anons" \
543 "\\^done,numchild=\"3\"" \
544 "get number of children of anons"
546 # Test: c_variable-7.45
547 # Desc: children of anons
548 mi_list_varobj_children anons {
552 } "get children of anons"
554 # Test: c_variable-7.50
555 # Desc: create enum e
556 mi_create_varobj e e "create local variable e"
558 # Test: c_variable-7.51
560 mi_gdb_test "-var-evaluate-expression e" \
561 "\\^done,value=\"bar\"" \
564 # Test: c_variable-7.52
566 mi_gdb_test "-var-info-type e" \
567 "\\^done,type=\"enum foo\"" \
568 "info type variable e"
570 # Test: c_variable-7.53
571 # Desc: is e editable
572 mi_gdb_test "-var-show-attributes e" \
573 "\\^done,attr=\"editable\"" \
576 # Test: c_variable-7.54
577 # Desc: number of children of e
578 mi_gdb_test "-var-info-num-children e" \
579 "\\^done,numchild=\"0\"" \
580 "get number of children of e"
582 # Test: c_variable-7.55
583 # Desc: children of e
584 mi_gdb_test "-var-list-children e" \
585 "\\^done,numchild=\"0\",has_more=\"0\"" \
588 # Test: c_variable-7.60
590 mi_create_varobj anone anone "create local variable anone"
592 # Test: c_variable-7.61
593 # Desc: value of anone
594 mi_gdb_test "-var-evaluate-expression anone" \
595 "\\^done,value=\"A\"" \
596 "eval variable anone"
598 # Test: c_variable-7.70
600 mi_gdb_test "-var-create anone * anone" \
601 "\\^error,msg=\"Duplicate variable object name\"" \
602 "create duplicate local variable anone"
605 # Test: c_variable-7.72
606 # Desc: type of anone
607 mi_gdb_test "-var-info-type anone" \
608 "\\^done,type=\"enum \{\\.\\.\\.\}\"" \
609 "info type variable anone"
612 # Test: c_variable-7.73
613 # Desc: is anone editable
614 mi_gdb_test "-var-show-attributes anone" \
615 "\\^done,attr=\"editable\"" \
618 # Test: c_variable-7.74
619 # Desc: number of children of anone
620 mi_gdb_test "-var-info-num-children anone" \
621 "\\^done,numchild=\"0\"" \
622 "get number of children of anone"
624 # Test: c_variable-7.75
625 # Desc: children of anone
626 mi_gdb_test "-var-list-children anone" \
627 "\\^done,numchild=\"0\",has_more=\"0\"" \
628 "get children of anone"
632 if ![mi_gdb_test "p/x \$fp" ".*($hex).*\\^done" "print FP register"] {
633 set fp $expect_out(3,string)
636 mi_continue_to "incr_a"
638 # Test: c_variable-7.81
639 # Desc: Create variables in different scopes
640 mi_gdb_test "-var-create a1 * a" \
641 "\\^done,name=\"a1\",numchild=\"0\",value=\".*\",type=\"char\".*" \
642 "create local variable a1"
644 if { [info exists fp] } {
645 mi_gdb_test "-var-create a2 $fp a" \
646 "\\^done,name=\"a2\",numchild=\"0\",value=\".*\",type=\"int\".*" \
647 "create variable a2 in different scope"
649 untested "create variable a2 in different scope"
652 #gdbtk_test c_variable-7.81 {create variables in different scopes} {
653 # set a1 [gdb_variable create -expr a]
654 # set a2 [gdb_variable create -expr a -frame $fp]
657 # lappend vals [$a1 value]
658 # lappend vals [$a2 value]