1 /* BFD back-end for Intel 386 COFF files.
2 Copyright (C) 1990-2020 Free Software Foundation, Inc.
3 Written by Cygnus Support.
5 This file is part of BFD, the Binary File Descriptor library.
7 This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 3 of the License, or
10 (at your option) any later version.
12 This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software
19 Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
20 MA 02110-1301, USA. */
26 #include "coff/i386.h"
28 #include "coff/internal.h"
34 #ifndef bfd_pe_print_pdata
35 #define bfd_pe_print_pdata NULL
40 /* All users of this file have bfd_octets_per_byte (abfd, sec) == 1. */
41 #define OCTETS_PER_BYTE(ABFD, SEC) 1
43 static reloc_howto_type
*coff_i386_rtype_to_howto
44 (bfd
*, asection
*, struct internal_reloc
*,
45 struct coff_link_hash_entry
*, struct internal_syment
*,
47 static reloc_howto_type
*coff_i386_reloc_type_lookup
48 (bfd
*, bfd_reloc_code_real_type
);
50 #define COFF_DEFAULT_SECTION_ALIGNMENT_POWER (2)
51 /* The page size is a guess based on ELF. */
53 #define COFF_PAGE_SIZE 0x1000
55 /* For some reason when using i386 COFF the value stored in the .text
56 section for a reference to a common symbol is the value itself plus
57 any desired offset. Ian Taylor, Cygnus Support. */
59 /* If we are producing relocatable output, we need to do some
60 adjustments to the object file that are not done by the
61 bfd_perform_relocation function. This function is called by every
62 reloc type to make any required adjustments. */
64 static bfd_reloc_status_type
65 coff_i386_reloc (bfd
*abfd
,
69 asection
*input_section
,
71 char **error_message ATTRIBUTE_UNUSED
)
76 if (output_bfd
== (bfd
*) NULL
)
77 return bfd_reloc_continue
;
80 if (bfd_is_com_section (symbol
->section
))
83 /* We are relocating a common symbol. The current value in the
84 object file is ORIG + OFFSET, where ORIG is the value of the
85 common symbol as seen by the object file when it was compiled
86 (this may be zero if the symbol was undefined) and OFFSET is
87 the offset into the common symbol (normally zero, but may be
88 non-zero when referring to a field in a common structure).
89 ORIG is the negative of reloc_entry->addend, which is set by
90 the CALC_ADDEND macro below. We want to replace the value in
91 the object file with NEW + OFFSET, where NEW is the value of
92 the common symbol which we are going to put in the final
93 object file. NEW is symbol->value. */
94 diff
= symbol
->value
+ reloc_entry
->addend
;
96 /* In PE mode, we do not offset the common symbol. */
97 diff
= reloc_entry
->addend
;
102 /* For some reason bfd_perform_relocation always effectively
103 ignores the addend for a COFF target when producing
104 relocatable output. This seems to be always wrong for 386
105 COFF, so we handle the addend here instead. */
107 if (output_bfd
== (bfd
*) NULL
)
109 reloc_howto_type
*howto
= reloc_entry
->howto
;
111 /* Although PC relative relocations are very similar between
112 PE and non-PE formats, but they are off by 1 << howto->size
113 bytes. For the external relocation, PE is very different
114 from others. See md_apply_fix3 () in gas/config/tc-i386.c.
115 When we link PE and non-PE object files together to
116 generate a non-PE executable, we have to compensate it
118 if (howto
->pc_relative
&& howto
->pcrel_offset
)
119 diff
= -(1 << howto
->size
);
120 else if (symbol
->flags
& BSF_WEAK
)
121 diff
= reloc_entry
->addend
- symbol
->value
;
123 diff
= -reloc_entry
->addend
;
127 diff
= reloc_entry
->addend
;
131 /* FIXME: How should this case be handled? */
132 if (reloc_entry
->howto
->type
== R_IMAGEBASE
133 && output_bfd
!= NULL
134 && bfd_get_flavour(output_bfd
) == bfd_target_coff_flavour
)
135 diff
-= pe_data (output_bfd
)->pe_opthdr
.ImageBase
;
139 x = ((x & ~howto->dst_mask) | (((x & howto->src_mask) + diff) & howto->dst_mask))
143 reloc_howto_type
*howto
= reloc_entry
->howto
;
144 bfd_size_type octets
= (reloc_entry
->address
145 * OCTETS_PER_BYTE (abfd
, input_section
));
146 unsigned char *addr
= (unsigned char *) data
+ octets
;
148 if (!bfd_reloc_offset_in_range (howto
, abfd
, input_section
, octets
))
149 return bfd_reloc_outofrange
;
155 char x
= bfd_get_8 (abfd
, addr
);
157 bfd_put_8 (abfd
, x
, addr
);
163 short x
= bfd_get_16 (abfd
, addr
);
165 bfd_put_16 (abfd
, (bfd_vma
) x
, addr
);
171 long x
= bfd_get_32 (abfd
, addr
);
173 bfd_put_32 (abfd
, (bfd_vma
) x
, addr
);
182 /* Now let bfd_perform_relocation finish everything up. */
183 return bfd_reloc_continue
;
187 /* Return TRUE if this relocation should appear in the output .reloc
190 static bfd_boolean
in_reloc_p (bfd
* abfd ATTRIBUTE_UNUSED
,
191 reloc_howto_type
*howto
)
193 return ! howto
->pc_relative
&& howto
->type
!= R_IMAGEBASE
194 && howto
->type
!= R_SECREL32
;
196 #endif /* COFF_WITH_PE */
199 #define PCRELOFFSET FALSE
202 static reloc_howto_type howto_table
[] =
210 HOWTO (R_DIR32
, /* type */
212 2, /* size (0 = byte, 1 = short, 2 = long) */
214 FALSE
, /* pc_relative */
216 complain_overflow_bitfield
, /* complain_on_overflow */
217 coff_i386_reloc
, /* special_function */
219 TRUE
, /* partial_inplace */
220 0xffffffff, /* src_mask */
221 0xffffffff, /* dst_mask */
222 TRUE
), /* pcrel_offset */
223 /* PE IMAGE_REL_I386_DIR32NB relocation (7). */
224 HOWTO (R_IMAGEBASE
, /* type */
226 2, /* size (0 = byte, 1 = short, 2 = long) */
228 FALSE
, /* pc_relative */
230 complain_overflow_bitfield
, /* complain_on_overflow */
231 coff_i386_reloc
, /* special_function */
233 TRUE
, /* partial_inplace */
234 0xffffffff, /* src_mask */
235 0xffffffff, /* dst_mask */
236 FALSE
), /* pcrel_offset */
241 /* 32-bit longword section relative relocation (013). */
242 HOWTO (R_SECREL32
, /* type */
244 2, /* size (0 = byte, 1 = short, 2 = long) */
246 FALSE
, /* pc_relative */
248 complain_overflow_bitfield
, /* complain_on_overflow */
249 coff_i386_reloc
, /* special_function */
250 "secrel32", /* name */
251 TRUE
, /* partial_inplace */
252 0xffffffff, /* src_mask */
253 0xffffffff, /* dst_mask */
254 TRUE
), /* pcrel_offset */
261 /* Byte relocation (017). */
262 HOWTO (R_RELBYTE
, /* type */
264 0, /* size (0 = byte, 1 = short, 2 = long) */
266 FALSE
, /* pc_relative */
268 complain_overflow_bitfield
, /* complain_on_overflow */
269 coff_i386_reloc
, /* special_function */
271 TRUE
, /* partial_inplace */
272 0x000000ff, /* src_mask */
273 0x000000ff, /* dst_mask */
274 PCRELOFFSET
), /* pcrel_offset */
275 /* 16-bit word relocation (020). */
276 HOWTO (R_RELWORD
, /* type */
278 1, /* size (0 = byte, 1 = short, 2 = long) */
280 FALSE
, /* pc_relative */
282 complain_overflow_bitfield
, /* complain_on_overflow */
283 coff_i386_reloc
, /* special_function */
285 TRUE
, /* partial_inplace */
286 0x0000ffff, /* src_mask */
287 0x0000ffff, /* dst_mask */
288 PCRELOFFSET
), /* pcrel_offset */
289 /* 32-bit longword relocation (021). */
290 HOWTO (R_RELLONG
, /* type */
292 2, /* size (0 = byte, 1 = short, 2 = long) */
294 FALSE
, /* pc_relative */
296 complain_overflow_bitfield
, /* complain_on_overflow */
297 coff_i386_reloc
, /* special_function */
299 TRUE
, /* partial_inplace */
300 0xffffffff, /* src_mask */
301 0xffffffff, /* dst_mask */
302 PCRELOFFSET
), /* pcrel_offset */
303 /* Byte PC relative relocation (022). */
304 HOWTO (R_PCRBYTE
, /* type */
306 0, /* size (0 = byte, 1 = short, 2 = long) */
308 TRUE
, /* pc_relative */
310 complain_overflow_signed
, /* complain_on_overflow */
311 coff_i386_reloc
, /* special_function */
313 TRUE
, /* partial_inplace */
314 0x000000ff, /* src_mask */
315 0x000000ff, /* dst_mask */
316 PCRELOFFSET
), /* pcrel_offset */
317 /* 16-bit word PC relative relocation (023). */
318 HOWTO (R_PCRWORD
, /* type */
320 1, /* size (0 = byte, 1 = short, 2 = long) */
322 TRUE
, /* pc_relative */
324 complain_overflow_signed
, /* complain_on_overflow */
325 coff_i386_reloc
, /* special_function */
327 TRUE
, /* partial_inplace */
328 0x0000ffff, /* src_mask */
329 0x0000ffff, /* dst_mask */
330 PCRELOFFSET
), /* pcrel_offset */
331 /* 32-bit longword PC relative relocation (024). */
332 HOWTO (R_PCRLONG
, /* type */
334 2, /* size (0 = byte, 1 = short, 2 = long) */
336 TRUE
, /* pc_relative */
338 complain_overflow_signed
, /* complain_on_overflow */
339 coff_i386_reloc
, /* special_function */
341 TRUE
, /* partial_inplace */
342 0xffffffff, /* src_mask */
343 0xffffffff, /* dst_mask */
344 PCRELOFFSET
) /* pcrel_offset */
347 #define NUM_HOWTOS (sizeof (howto_table) / sizeof (howto_table[0]))
349 /* Turn a howto into a reloc nunmber */
351 #define SELECT_RELOC(x,howto) { x.r_type = howto->type; }
352 #define BADMAG(x) I386BADMAG(x)
353 #define I386 1 /* Customize coffcode.h */
355 #define RTYPE2HOWTO(cache_ptr, dst) \
356 ((cache_ptr)->howto = \
357 ((dst)->r_type < NUM_HOWTOS \
358 ? howto_table + (dst)->r_type \
361 /* For 386 COFF a STYP_NOLOAD | STYP_BSS section is part of a shared
362 library. On some other COFF targets STYP_BSS is normally
364 #define BSS_NOLOAD_IS_SHARED_LIBRARY
366 /* Compute the addend of a reloc. If the reloc is to a common symbol,
367 the object file contains the value of the common symbol. By the
368 time this is called, the linker may be using a different symbol
369 from a different object file with a different value. Therefore, we
370 hack wildly to locate the original symbol from this file so that we
371 can make the correct adjustment. This macro sets coffsym to the
372 symbol from the original file, and uses it to set the addend value
373 correctly. If this is not a common symbol, the usual addend
374 calculation is done, except that an additional tweak is needed for
376 FIXME: This macro refers to symbols and asect; these are from the
377 calling function, not the macro arguments. */
379 #define CALC_ADDEND(abfd, ptr, reloc, cache_ptr) \
381 coff_symbol_type *coffsym = (coff_symbol_type *) NULL; \
382 if (ptr && bfd_asymbol_bfd (ptr) != abfd) \
383 coffsym = (obj_symbols (abfd) \
384 + (cache_ptr->sym_ptr_ptr - symbols)); \
386 coffsym = coff_symbol_from (ptr); \
387 if (coffsym != (coff_symbol_type *) NULL \
388 && coffsym->native->u.syment.n_scnum == 0) \
389 cache_ptr->addend = - coffsym->native->u.syment.n_value; \
390 else if (ptr && bfd_asymbol_bfd (ptr) == abfd \
391 && ptr->section != (asection *) NULL) \
392 cache_ptr->addend = - (ptr->section->vma + ptr->value); \
394 cache_ptr->addend = 0; \
395 if (ptr && reloc.r_type < NUM_HOWTOS \
396 && howto_table[reloc.r_type].pc_relative) \
397 cache_ptr->addend += asect->vma; \
400 /* We use the special COFF backend linker. For normal i386 COFF, we
401 can use the generic relocate_section routine. For PE, we need our
406 #define coff_relocate_section _bfd_coff_generic_relocate_section
408 #else /* COFF_WITH_PE */
410 /* The PE relocate section routine. The only difference between this
411 and the regular routine is that we don't want to do anything for a
415 coff_pe_i386_relocate_section (bfd
*output_bfd
,
416 struct bfd_link_info
*info
,
418 asection
*input_section
,
420 struct internal_reloc
*relocs
,
421 struct internal_syment
*syms
,
424 if (bfd_link_relocatable (info
))
427 return _bfd_coff_generic_relocate_section (output_bfd
, info
, input_bfd
,
428 input_section
, contents
,
429 relocs
, syms
, sections
);
432 #define coff_relocate_section coff_pe_i386_relocate_section
434 #endif /* COFF_WITH_PE */
436 /* Convert an rtype to howto for the COFF backend linker. */
438 static reloc_howto_type
*
439 coff_i386_rtype_to_howto (bfd
*abfd ATTRIBUTE_UNUSED
,
441 struct internal_reloc
*rel
,
442 struct coff_link_hash_entry
*h
,
443 struct internal_syment
*sym
,
446 reloc_howto_type
*howto
;
448 if (rel
->r_type
>= NUM_HOWTOS
)
450 bfd_set_error (bfd_error_bad_value
);
454 howto
= howto_table
+ rel
->r_type
;
457 /* Cancel out code in _bfd_coff_generic_relocate_section. */
461 if (howto
->pc_relative
)
462 *addendp
+= sec
->vma
;
464 if (sym
!= NULL
&& sym
->n_scnum
== 0 && sym
->n_value
!= 0)
466 /* This is a common symbol. The section contents include the
467 size (sym->n_value) as an addend. The relocate_section
468 function will be adding in the final value of the symbol. We
469 need to subtract out the current size in order to get the
472 BFD_ASSERT (h
!= NULL
);
475 /* I think we *do* want to bypass this. If we don't, I have
476 seen some data parameters get the wrong relocation address.
477 If I link two versions with and without this section bypassed
478 and then do a binary comparison, the addresses which are
479 different can be looked up in the map. The case in which
480 this section has been bypassed has addresses which correspond
481 to values I can find in the map. */
482 *addendp
-= sym
->n_value
;
487 /* If the output symbol is common (in which case this must be a
488 relocatable link), we need to add in the final size of the
490 if (h
!= NULL
&& h
->root
.type
== bfd_link_hash_common
)
491 *addendp
+= h
->root
.u
.c
.size
;
495 if (howto
->pc_relative
)
499 /* If the symbol is defined, then the generic code is going to
500 add back the symbol value in order to cancel out an
501 adjustment it made to the addend. However, we set the addend
502 to 0 at the start of this function. We need to adjust here,
503 to avoid the adjustment the generic code will make. FIXME:
504 This is getting a bit hackish. */
505 if (sym
!= NULL
&& sym
->n_scnum
!= 0)
506 *addendp
-= sym
->n_value
;
509 if (rel
->r_type
== R_IMAGEBASE
510 && (bfd_get_flavour(sec
->output_section
->owner
)
511 == bfd_target_coff_flavour
))
513 *addendp
-= pe_data(sec
->output_section
->owner
)->pe_opthdr
.ImageBase
;
516 /* PR 17099 - Absolute R_PCRLONG relocations do not need a symbol. */
517 if (rel
->r_type
== R_PCRLONG
&& sym
== NULL
)
518 *addendp
-= rel
->r_vaddr
;
520 BFD_ASSERT (sym
!= NULL
);
522 if (rel
->r_type
== R_SECREL32
&& sym
!= NULL
)
526 if (h
&& (h
->root
.type
== bfd_link_hash_defined
527 || h
->root
.type
== bfd_link_hash_defweak
))
528 osect_vma
= h
->root
.u
.def
.section
->output_section
->vma
;
534 /* Sigh, the only way to get the section to offset against
535 is to find it the hard way. */
537 for (s
= abfd
->sections
, i
= 1; i
< sym
->n_scnum
; i
++)
540 osect_vma
= s
->output_section
->vma
;
543 *addendp
-= osect_vma
;
550 #define coff_bfd_reloc_type_lookup coff_i386_reloc_type_lookup
551 #define coff_bfd_reloc_name_lookup coff_i386_reloc_name_lookup
553 static reloc_howto_type
*
554 coff_i386_reloc_type_lookup (bfd
*abfd ATTRIBUTE_UNUSED
,
555 bfd_reloc_code_real_type code
)
560 return howto_table
+ R_IMAGEBASE
;
562 return howto_table
+ R_DIR32
;
563 case BFD_RELOC_32_PCREL
:
564 return howto_table
+ R_PCRLONG
;
566 return howto_table
+ R_RELWORD
;
567 case BFD_RELOC_16_PCREL
:
568 return howto_table
+ R_PCRWORD
;
570 return howto_table
+ R_RELBYTE
;
571 case BFD_RELOC_8_PCREL
:
572 return howto_table
+ R_PCRBYTE
;
574 case BFD_RELOC_32_SECREL
:
575 return howto_table
+ R_SECREL32
;
583 static reloc_howto_type
*
584 coff_i386_reloc_name_lookup (bfd
*abfd ATTRIBUTE_UNUSED
,
589 for (i
= 0; i
< NUM_HOWTOS
; i
++)
590 if (howto_table
[i
].name
!= NULL
591 && strcasecmp (howto_table
[i
].name
, r_name
) == 0)
592 return &howto_table
[i
];
597 #define coff_rtype_to_howto coff_i386_rtype_to_howto
599 #ifdef TARGET_UNDERSCORE
601 /* If i386 gcc uses underscores for symbol names, then it does not use
602 a leading dot for local labels, so if TARGET_UNDERSCORE is defined
603 we treat all symbols starting with L as local. */
606 coff_i386_is_local_label_name (bfd
*abfd
, const char *name
)
611 return _bfd_coff_is_local_label_name (abfd
, name
);
614 #define coff_bfd_is_local_label_name coff_i386_is_local_label_name
616 #endif /* TARGET_UNDERSCORE */
618 #include "coffcode.h"
630 "coff-i386", /* name */
632 bfd_target_coff_flavour
,
633 BFD_ENDIAN_LITTLE
, /* data byte order is little */
634 BFD_ENDIAN_LITTLE
, /* header byte order is little */
636 (HAS_RELOC
| EXEC_P
| /* object flags */
637 HAS_LINENO
| HAS_DEBUG
|
638 HAS_SYMS
| HAS_LOCALS
| WP_TEXT
| D_PAGED
| BFD_COMPRESS
| BFD_DECOMPRESS
),
640 (SEC_HAS_CONTENTS
| SEC_ALLOC
| SEC_LOAD
| SEC_RELOC
/* section flags */
642 | SEC_LINK_ONCE
| SEC_LINK_DUPLICATES
| SEC_READONLY
| SEC_DEBUGGING
644 | SEC_CODE
| SEC_DATA
| SEC_EXCLUDE
),
646 #ifdef TARGET_UNDERSCORE
647 TARGET_UNDERSCORE
, /* leading underscore */
649 0, /* leading underscore */
651 '/', /* ar_pad_char */
652 15, /* ar_max_namelen */
653 0, /* match priority. */
655 bfd_getl64
, bfd_getl_signed_64
, bfd_putl64
,
656 bfd_getl32
, bfd_getl_signed_32
, bfd_putl32
,
657 bfd_getl16
, bfd_getl_signed_16
, bfd_putl16
, /* data */
658 bfd_getl64
, bfd_getl_signed_64
, bfd_putl64
,
659 bfd_getl32
, bfd_getl_signed_32
, bfd_putl32
,
660 bfd_getl16
, bfd_getl_signed_16
, bfd_putl16
, /* hdrs */
662 #ifndef COFF_CHECK_FORMAT
663 #define COFF_CHECK_FORMAT coff_object_p
665 #ifndef COFF_WRITE_CONTENTS
666 #define COFF_WRITE_CONTENTS coff_write_object_contents
669 /* Note that we allow an object file to be treated as a core file as well. */
671 { /* bfd_check_format */
674 bfd_generic_archive_p
,
677 { /* bfd_set_format */
678 _bfd_bool_bfd_false_error
,
680 _bfd_generic_mkarchive
,
681 _bfd_bool_bfd_false_error
683 { /* bfd_write_contents */
684 _bfd_bool_bfd_false_error
,
686 _bfd_write_archive_contents
,
687 _bfd_bool_bfd_false_error
690 BFD_JUMP_TABLE_GENERIC (coff
),
691 BFD_JUMP_TABLE_COPY (coff
),
692 BFD_JUMP_TABLE_CORE (_bfd_nocore
),
693 BFD_JUMP_TABLE_ARCHIVE (_bfd_archive_coff
),
694 BFD_JUMP_TABLE_SYMBOLS (coff
),
695 BFD_JUMP_TABLE_RELOCS (coff
),
696 BFD_JUMP_TABLE_WRITE (coff
),
697 BFD_JUMP_TABLE_LINK (coff
),
698 BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic
),
705 #ifdef COFF_WITH_PE_BIGOBJ
710 bfd_target_coff_flavour
,
711 BFD_ENDIAN_LITTLE
, /* data byte order is little */
712 BFD_ENDIAN_LITTLE
, /* header byte order is little */
714 (HAS_RELOC
| EXEC_P
| /* object flags */
715 HAS_LINENO
| HAS_DEBUG
|
716 HAS_SYMS
| HAS_LOCALS
| WP_TEXT
| D_PAGED
| BFD_COMPRESS
| BFD_DECOMPRESS
),
718 (SEC_HAS_CONTENTS
| SEC_ALLOC
| SEC_LOAD
| SEC_RELOC
/* section flags */
720 | SEC_LINK_ONCE
| SEC_LINK_DUPLICATES
| SEC_READONLY
| SEC_DEBUGGING
722 | SEC_CODE
| SEC_DATA
| SEC_EXCLUDE
),
724 #ifdef TARGET_UNDERSCORE
725 TARGET_UNDERSCORE
, /* leading underscore */
727 0, /* leading underscore */
729 '/', /* ar_pad_char */
730 15, /* ar_max_namelen */
731 0, /* match priority. */
733 bfd_getl64
, bfd_getl_signed_64
, bfd_putl64
,
734 bfd_getl32
, bfd_getl_signed_32
, bfd_putl32
,
735 bfd_getl16
, bfd_getl_signed_16
, bfd_putl16
, /* data */
736 bfd_getl64
, bfd_getl_signed_64
, bfd_putl64
,
737 bfd_getl32
, bfd_getl_signed_32
, bfd_putl32
,
738 bfd_getl16
, bfd_getl_signed_16
, bfd_putl16
, /* hdrs */
740 /* Note that we allow an object file to be treated as a core file as well. */
742 { /* bfd_check_format */
745 bfd_generic_archive_p
,
748 { /* bfd_set_format */
749 _bfd_bool_bfd_false_error
,
751 _bfd_generic_mkarchive
,
752 _bfd_bool_bfd_false_error
754 { /* bfd_write_contents */
755 _bfd_bool_bfd_false_error
,
757 _bfd_write_archive_contents
,
758 _bfd_bool_bfd_false_error
761 BFD_JUMP_TABLE_GENERIC (coff
),
762 BFD_JUMP_TABLE_COPY (coff
),
763 BFD_JUMP_TABLE_CORE (_bfd_nocore
),
764 BFD_JUMP_TABLE_ARCHIVE (_bfd_archive_coff
),
765 BFD_JUMP_TABLE_SYMBOLS (coff
),
766 BFD_JUMP_TABLE_RELOCS (coff
),
767 BFD_JUMP_TABLE_WRITE (coff
),
768 BFD_JUMP_TABLE_LINK (coff
),
769 BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic
),