libctf/ChangeLog

   1 2020-10-21  Tom Tromey  <tromey@adacore.com>
   2
   3         * mkerrors.sed: Remove.
   4         * ctf-error.c (_CTF_FIRST): New define.
   5         (_CTF_ITEM): Define this, not _CTF_STR.
   6         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
   7         (ERRSTRFIELD): Rewrite.
   8         (ERRSTRFIELD1): Remove.
   9         * Makefile.in: Rebuild.
  10         * Makefile.am (BUILT_SOURCES): Remove.
  11         (ctf-error.h): Remove.
  12
  13 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
  14
  15         * ctf-subr.c (open_errors): New list.
  16         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
  17         parameter, and use it to decorate the debug stream with errmsgs.
  18         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
  19         open_errors.
  20         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
  21         New err param to report iteration errors (including end-of-iteration)
  22         when fp is NULL.
  23         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
  24         parameter: gettextize.
  25         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
  26         (LCTF_VBYTES): Adjust.
  27         (ctf_err_warn_to_open): New.
  28         (ctf_err_warn): Adjust.
  29         (ctf_bundle): Used in only one place: move...
  30         * ctf-create.c: ... here.
  31         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
  32         down as needed.  Don't emit the errmsg.  Gettextize.
  33         (membcmp): Likewise.
  34         (ctf_add_type_internal): Likewise.
  35         (ctf_write_mem): Likewise.
  36         (ctf_compress_write): Likewise.  Report errors writing the header or
  37         body.
  38         (ctf_write): Likewise.
  39         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
  40         ctf_dprintf, and gettextize, as above.
  41         (ctf_arc_write): Likewise.
  42         (ctf_arc_bufopen): Likewise.
  43         (ctf_arc_open_internal): Likewise.
  44         * ctf-labels.c (ctf_label_iter): Likewise.
  45         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
  46         (ctf_bfdopen): Likewise.
  47         (ctf_bfdopen_ctfsect): Likewise.
  48         (ctf_fdopen): Likewise.
  49         * ctf-string.c (ctf_str_write_strtab): Likewise.
  50         * ctf-types.c (ctf_type_resolve): Likewise.
  51         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
  52         (get_vbytes_v1): Pass down the ctf dict.
  53         (get_vbytes_v2): Likewise.
  54         (flip_ctf): Likewise.
  55         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
  56         gettextize, as above.
  57         (upgrade_types_v1): Adjust calls.
  58         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
  59         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
  60         emitted into individual dicts into the open errors if this turns
  61         out to be a failed open in the end.
  62         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
  63         argument.  Gettextize.  Don't emit the errmsg.
  64         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
  65         (ctf_dump_type): Likewise.
  66         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
  67         argument.  Gettextize.  Don't emit the errmsg.
  68         (ctf_link_one_type): Likewise.
  69         (ctf_link_lazy_open): Likewise.
  70         (ctf_link_one_input_archive): Likewise.
  71         (ctf_link_deduplicating_count_inputs): Likewise.
  72         (ctf_link_deduplicating_open_inputs): Likewise.
  73         (ctf_link_deduplicating_close_inputs): Likewise.
  74         (ctf_link_deduplicating): Likewise.
  75         (ctf_link): Likewise.
  76         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
  77         ctf_set_errnos to obscure error cases.
  78         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
  79         err argument.  Gettextize.  Don't emit the errmsg.
  80         (ctf_dedup_populate_mappings): Likewise.
  81         (ctf_dedup_detect_name_ambiguity): Likewise.
  82         (ctf_dedup_init): Likewise.
  83         (ctf_dedup_multiple_input_dicts): Likewise.
  84         (ctf_dedup_conflictify_unshared): Likewise.
  85         (ctf_dedup): Likewise.
  86         (ctf_dedup_rwalk_one_output_mapping): Likewise.
  87         (ctf_dedup_id_to_target): Likewise.
  88         (ctf_dedup_emit_type): Likewise.
  89         (ctf_dedup_emit_struct_members): Likewise.
  90         (ctf_dedup_populate_type_mapping): Likewise.
  91         (ctf_dedup_populate_type_mappings): Likewise.
  92         (ctf_dedup_emit): Likewise.
  93         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
  94         status setting.
  95         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
  96         unknown-type-kind messages (which signify file corruption).
  97
  98 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
  99
 100         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 101         declare this to be version 1.2.0.
 102         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 103         * Makefile.in: Regenerated.
 104         * configure: Regenerated.
 105         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 106         * ctf-impl.h: Include it.
 107         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 108         (ctf_errmsg): Actually translate them.
 109
 110 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 111
 112         PR binutils/25155:
 113         * ctf-create.c (EOVERFLOW): If not defined by system header,
 114         redirect to ERANGE as a poor man's substitute.
 115         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 116
 117 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 118
 119         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 120         (ctf_dtd_delete): Likewise.
 121         (ctf_dtd_lookup): Likewise.
 122         (ctf_rollback): Likewise.
 123         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 124         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 125
 126 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 127
 128         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 129
 130 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 131
 132         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 133         number if needed.
 134
 135 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 136
 137         * ctf-impl.h (ctf_list_splice): New.
 138         * ctf-util.h (ctf_list_splice): Likewise.
 139         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 140         (ctf_link_sort_inputs): Likewise.
 141         (ctf_link_deduplicating_count_inputs): Likewise.
 142         (ctf_link_deduplicating_open_inputs): Likewise.
 143         (ctf_link_deduplicating_close_inputs): Likewise.
 144         (ctf_link_deduplicating_variables): Likewise.
 145         (ctf_link_deduplicating_per_cu): Likewise.
 146         (ctf_link_deduplicating): Likewise.
 147         (ctf_link): Call it.
 148
 149 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 150
 151         * ctf-link.c (ctf_link_one_input_archive_member): Check
 152         CTF_LINK_OMIT_VARIABLES_SECTION.
 153
 154 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 155
 156         * ctf-impl.h (ctf_type_id_key): New, the key in the
 157         cd_id_to_file_t.
 158         (ctf_dedup): New, core deduplicator state.
 159         (ctf_file_t) <ctf_dedup>: New.
 160         <ctf_dedup_atoms>: New.
 161         <ctf_dedup_atoms_alloc>: New.
 162         (ctf_hash_type_id_key): New prototype.
 163         (ctf_hash_eq_type_id_key): Likewise.
 164         (ctf_dedup_atoms_init): Likewise.
 165         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 166         (ctf_dedup_atoms_init): Likewise.
 167         * ctf-create.c (ctf_serialize): Adjusted.
 168         (ctf_add_encoded): No longer static.
 169         (ctf_add_reftype): Likewise.
 170         * ctf-open.c (ctf_file_close): Destroy the
 171         ctf_dedup_atoms_alloc.
 172         * ctf-dedup.c: New file.
 173         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 174         * configure.ac: Check for stpcpy.
 175         * Makefile.am: Add it.
 176         * Makefile.in: Regenerate.
 177         * config.h.in: Regenerate.
 178         * configure: Regenerate.
 179
 180 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 181
 182         * configure.ac: Add --enable-libctf-hash-debugging.
 183         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 184         * Makefile.in: Regenerated.
 185         * configure: Likewise.
 186         * config.h.in: Likewise.
 187         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 188         (ctf_assert): Define to assert.
 189
 190 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 191
 192         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 193         sha1_process_bytes.
 194         * ctf-impl.h: Include it.
 195         (ctf_sha1_init): New.
 196         (ctf_sha1_add): Likewise.
 197         (ctf_sha1_fini): Likewise.
 198         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 199         producing strings.
 200         * Makefile.am: Add file.
 201         * Makefile.in: Regenerate.
 202
 203 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 204
 205         * libctf.ver (ctf_link_set_variable_filter): Add.
 206         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 207         <ctf_link_variable_filter_arg>: Likewise.
 208         * ctf-create.c (ctf_serialize): Adjust.
 209         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 210         (ctf_link_one_variable): Call it if set.
 211
 212 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 213
 214         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 215         conflicts, not the source type.
 216
 217 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 218
 219         * ctf-impl.h (ctf_file_t): Improve comments.
 220         <ctf_link_cu_mapping>: Split into...
 221         <ctf_link_in_cu_mapping>: ... this...
 222         <ctf_link_out_cu_mapping>: ... and this.
 223         * ctf-create.c (ctf_serialize): Adjust.
 224         * ctf-open.c (ctf_file_close): Likewise.
 225         * ctf-link.c (ctf_create_per_cu): Look things up in the
 226         in_cu_mapping instead of the cu_mapping.
 227         (ctf_link_add_cu_mapping): The deduplicating link will define
 228         what happens if many FROMs share a TO.
 229         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 230         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 231         create per-CU dicts here: they are already created when needed.
 232         (ctf_link_one_variable): Log a debug message if we skip a
 233         variable due to its type being concealed in a CU-mapped link.
 234         (This is probably too common a case to make into a warning.)
 235         (ctf_link): Create empty per-CU dicts if requested.
 236
 237 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 238
 239         * ctf-link.c (ctf_link_write): Close the fd.
 240
 241 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 242
 243         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 244         * Makefile.in: Regenerated.
 245         * ctf-impl.h (ctf_link_input_name): New.
 246         (ctf_file_t) <ctf_link_flags>: New.
 247         * ctf-create.c (ctf_serialize): Adjust accordingly.
 248         * ctf-link.c: Define ctf_open as weak when PIC.
 249         (ctf_arc_close_thunk): Remove unnecessary thunk.
 250         (ctf_file_close_thunk): Likewise.
 251         (ctf_link_input_name): New.
 252         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 253         (ctf_link_input_close): Adjust accordingly.
 254         (ctf_link_add_ctf_internal): New, split from...
 255         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 256         CTF is not possible.  Change to just call...
 257         (ctf_link_add): ... this new function.
 258         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 259         ctf_file_close_thunk.
 260         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 261         <in_file_name>: ... this.
 262         <arcname>: Drop.
 263         <share_mode>: Likewise (migrated to ctf_link_flags).
 264         <done_main_member>: Rename to...
 265         <done_parent>: ... this.
 266         <main_input_fp>: Rename to...
 267         <in_fp_parent>: ... this.
 268         <cu_mapped>: New.
 269         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 270         ctf_err_warn, removing a TODO.
 271         (ctf_link_one_variable): Note a case too common to warn about.
 272         Report in the debug stream if a cu-mapped link prevents addition
 273         of a conflicting variable.
 274         (ctf_link_one_input_archive_member): Adjust.
 275         (ctf_link_lazy_open): New, open a CTF archive for linking when
 276         needed.
 277         (ctf_link_close_one_input_archive): New, close it again.
 278         (ctf_link_one_input_archive): Adjust for lazy opening, member
 279         renames, and ctf_err_warn transition.  Move the
 280         empty_link_type_mapping call to...
 281         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 282         Don't spuriously fail if some input contains no CTF data.
 283         (ctf_link_write): ctf_err_warn transition.
 284         * libctf.ver: Remove not-yet-stable comment.
 285
 286 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 287
 288         * ctf-impl.h (ctf_strerror): Delete.
 289         * ctf-subr.c (ctf_strerror): Likewise.
 290         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 291         strerror directly.
 292
 293 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 294
 295         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 296         (ctf_import_unref): New.
 297         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 298         zero.  Don't recurse back in if the refcount is already zero.
 299         (ctf_import): Check ctf_parent_unreffed before deciding whether
 300         to close a pre-existing parent.  Set it to zero.
 301         (ctf_import_unreffed): New, as above, setting
 302         ctf_parent_unreffed to 1.
 303         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 304         child: use direct assignment, and set unreffed on the new and
 305         old children.
 306         * ctf-link.c (ctf_create_per_cu): Import the parent using
 307         ctf_import_unreffed.
 308
 309 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 310
 311         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 312         (ctf_link_type_key): ... this, adjusting member prefixes to
 313         match.
 314         (ctf_hash_type_mapping_key): Rename to...
 315         (ctf_hash_type_key): ... this.
 316         (ctf_hash_eq_type_mapping_key): Rename to...
 317         (ctf_hash_eq_type_key): ... this.
 318         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 319         (ctf_hash_type_key): ... this, and adjust for member name
 320         changes.
 321         (ctf_hash_eq_type_mapping_key): Rename to...
 322         (ctf_hash_eq_type_key): ... this, and adjust for member name
 323         changes.
 324         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 325         need for out-of-memory checking in this code.
 326         (ctf_type_mapping): Adjust.
 327
 328 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 329
 330         configure.ac: Check for vasprintf.
 331         configure: Regenerated.
 332         config.h.in: Likewise.
 333
 334 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 335
 336         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 337
 338 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 339
 340         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 341         New.
 342         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 343         if the input has no symtab, rather than dividing by
 344         zero. Arrange to free it later via ctfi_free_ctfsect.
 345         * ctf-archive.c (ctf_new_archive_internal): Do not
 346         ctfi_free_strsect by default.
 347         (ctf_arc_close): Possibly free it here.
 348
 349 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 350
 351         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 352         (ctf_dump_format_type): improve slice formatting.  Always print
 353         the type size, even of slices.
 354         (ctf_dump_member): Print slices (-> bitfields) differently from
 355         non-slices.  Failure to format a type is not an OOM.
 356
 357 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 358
 359         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 360         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 361         (ctf_dump_objts): Likewise.
 362         (ctf_dump_var): Likewise.
 363         (ctf_dump_type): Do not emit a duplicate message.  Move to
 364         ctf_err_warning, and swallow all errors.
 365
 366 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 367
 368         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 369         (ctf_decl_buf): Once it escapes, don't try to free it later.
 370
 371 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 372
 373         * ctf-types.c (ctf_type_aname): Print arg types here...
 374         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 375         in the type name here.
 376
 377 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 378
 379         * ctf-impl.h (ctf_assert): New.
 380         (ctf_err_warning_t): Likewise.
 381         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 382         (ctf_err_warn): New prototype.
 383         (ctf_assert_fail_internal): Likewise.
 384         * ctf-inlines.h (ctf_assert_internal): Likewise.
 385         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 386         * ctf-create.c (ctf_serialize): Copy it on serialization.
 387         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 388         (ctf_errwarning_next): New iterator, free and pass back
 389         errors/warnings in succession.
 390         * libctf.ver (ctf_errwarning_next): Add.
 391
 392 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 393
 394         * ctf-types.c (ctf_variable_iter): Fix error return.
 395
 396 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 397
 398         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 399
 400 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 401
 402         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 403
 404 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 405
 406         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 407         sorting functions.
 408         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 409         ctf_dynhash_next_sorted.
 410         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 411         <cu.ctn_s>: New, pointer to the dynset under iteration.
 412         (ctf_hash_sort_f): Sorting function passed to...
 413         (ctf_dynhash_next_sorted): ... this new function.
 414         (ctf_dynhash_next): New.
 415         (ctf_dynset_next): New.
 416         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 417         (ctf_dynhash_cnext): New.
 418         (ctf_dynset_cnext): New.
 419         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 420         (ctf_dynhash_next): New.
 421         (ctf_dynset_next): New.
 422         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 423         needed.
 424         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 425
 426 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 427
 428         * ctf-impl.h (ctf_next): New.
 429         (ctf_get_dict): New prototype.
 430         * ctf-lookup.c (ctf_get_dict): New, split out of...
 431         (ctf_lookup_by_id): ... here.
 432         * ctf-util.c (ctf_next_create): New.
 433         (ctf_next_destroy): New.
 434         (ctf_next_copy): New.
 435         * ctf-types.c (includes): Add <assert.h>.
 436         (ctf_member_next): New.
 437         (ctf_enum_next): New.
 438         (ctf_type_iter): Document the lack of iteration over parent
 439         types.
 440         (ctf_type_next): New.
 441         (ctf_variable_next): New.
 442         * ctf-archive.c (ctf_archive_next): New.
 443         * libctf.ver: Add new public functions.
 444
 445 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 446
 447         * libctf.ver (ctf_ref): New.
 448         * ctf-open.c (ctf_ref): Implement it.
 449
 450 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 451
 452         * ctf-inlines.h (ctf_forwardable_kind): New.
 453         * ctf-create.c (ctf_add_forward): Use it.
 454
 455 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 456
 457         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 458         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 459
 460 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 461
 462         * ctf-hash.c (ctf_dynset_eq_string): New.
 463         (ctf_dynset_create): New.
 464         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 465         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 466         (key_to_internal): New.
 467         (internal_to_key): New.
 468         (ctf_dynset_insert): New.
 469         (ctf_dynset_remove): New.
 470         (ctf_dynset_destroy): New.
 471         (ctf_dynset_lookup): New.
 472         (ctf_dynset_exists): New.
 473         (ctf_dynset_lookup_any): New.
 474         (ctf_hash_insert_type): Coding style.
 475         (ctf_hash_define_type): Likewise.
 476         * ctf-impl.h (ctf_dynset_t): New.
 477         (ctf_dynset_eq_string): New.
 478         (ctf_dynset_create): New.
 479         (ctf_dynset_insert): New.
 480         (ctf_dynset_remove): New.
 481         (ctf_dynset_destroy): New.
 482         (ctf_dynset_lookup): New.
 483         (ctf_dynset_exists): New.
 484         (ctf_dynset_lookup_any): New.
 485         * ctf-inlines.h (ctf_dynset_cinsert): New.
 486
 487 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 488
 489         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 490         <value_free>: Likewise.
 491         <owner>: New.
 492         (ctf_dynhash_item_free): Indirect through the owner.
 493         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 494         allocate space for the key_free and value_free fields fields
 495         if necessary.
 496         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 497         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 498         value_free if they will exist.  Set the slot's owner, but only
 499         if it exists.
 500         (ctf_dynhash_remove): Adjust.
 501
 502 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 503
 504         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 505         there is a key-freeing function and the key already exists.
 506
 507 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 508
 509         * ctf-inlines.h: New file.
 510         * ctf-impl.h: Include it.
 511         (ctf_hash_iter_find_f): New typedef.
 512         (ctf_dynhash_elements): New.
 513         (ctf_dynhash_lookup_kv): New.
 514         (ctf_dynhash_iter_find): New.
 515         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 516         (ctf_traverse_find_cb_arg_t): New.
 517         (ctf_hashtab_traverse_find): New.
 518         (ctf_dynhash_iter_find): New.
 519         (ctf_dynhash_elements): New.
 520
 521 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 522
 523         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 524
 525 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 526
 527         * ctf-archive.c (ctf_archive_count): New.
 528         * libctf.ver: New public function.
 529
 530 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 531
 532         * ctf-types.c (ctf_member_count): New.
 533         * libctf.ver: New public function.
 534
 535 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 536
 537         * ctf-types.c (ctf_type_kind_forwarded): New.
 538
 539 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 540
 541         * ctf-types.c (ctf_type_name_raw): New.
 542         (ctf_type_aname_raw): Reimplement accordingly.
 543
 544 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 545
 546         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 547
 548 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 549
 550         * ctf-impl.h (struct ctf_archive_internal)
 551         <ctfi_unmap_on_close>: New.
 552         (ctf_new_archive_internal): Adjust.
 553         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 554         Initialize ctfi_unmap_on_close.  Adjust error path.
 555         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 556         (unmap_on_close is 0).
 557         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 558         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 559
 560 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 561
 562         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 563         ints, floats or typedefs have no name.  Fix comment typo.
 564
 565 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 566
 567         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 568         resolves to an integral type.
 569         * ctf-types.c (ctf_type_encoding): Resolve the type before
 570         fishing its encoding out.
 571
 572 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 573
 574         * ctf-create.c (ctf_create): Mark dirty.
 575
 576 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 577
 578         * ctf-create.c (membcmp)  Skip nameless members.
 579
 580 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 581
 582         * ctf-create.c (ctf_add_member_offset): Support names of ""
 583         as if they were the null pointer.
 584
 585 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 586
 587         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 588         special-casing.
 589
 590 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 591
 592         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 593
 594 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 595
 596         * ctf-create.c (ctf_serialize): Add cast.
 597         (ctf_add_slice): Likewise.
 598
 599 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 600
 601         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 602         * ctf-create.c (ctf_add_function): Check for unimplemented type
 603         and populate at the same time.  Populate one-by-one, not via
 604         memcpy.
 605         (ctf_serialize): Remove unnecessary cast.
 606         * ctf-types.c (ctf_func_type_info): Likewise.
 607         (ctf_func_type_args): Likewise.  Fix comment typo.
 608
 609 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 610
 611         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 612         (ctf_add_array): Support array contents of type zero.
 613         (ctf_add_function): Support arguments and return types of
 614         type zero.
 615         (ctf_add_typedef): Support typedefs to type zero.
 616         (ctf_add_member_offset): Support members of type zero,
 617         unless added at unspecified (naturally-aligned) offset.
 618
 619 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 620
 621         * ctf-error.c: Include <stddef.h>, for offsetof.
 622         (_ctf_errlist): Migrate to...
 623         (_ctf_errlist_t): ... this.
 624         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 625         (_ctf_nerr): Remove.
 626         (ctf_errmsg): Adjust accordingly.
 627         * Makefile.am (BUILT_SOURCES): Note...
 628         (ctf-error.h): ... this new rule.
 629         * Makefile.in: Regenerate.
 630         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 631         * .gitignore: New, ignore ctf-error.h.
 632
 633 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 634
 635         * ctf-impl.h: Fix typos in comments.
 636
 637 2020-07-22  Nick Clifton  <nickc@redhat.com>
 638
 639         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 640         same file descriptor.
 641
 642 2020-07-04  Nick Clifton  <nickc@redhat.com>
 643
 644         Binutils 2.35 branch created.
 645
 646 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 647
 648         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 649         alphabetical order.
 650         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 651         * config.h.in: Regenerated.
 652         * Makefile.in: Likewise.
 653         * configure: Likewise.
 654
 655 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 656
 657         * ctf-create.c: Include <unistd.h>.
 658         * ctf-open-bfd.c: Likewise.
 659
 660 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 661
 662         PR libctf/25120
 663         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 664         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 665         means this is declared.
 666         (bswap_32): Likewise.
 667         (bswap_64): Likewise.
 668         (bswap_identity_64): Remove, unused.
 669         * configure: Regenerated.
 670         * config.h.in: Likewise.
 671
 672 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 673
 674         PR libctf/25120
 675         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 676         (_libctf_unlikely_): Likewise.
 677         (_libctf_unused): Likewise.
 678         (_libctf_malloc_): Likewise.
 679
 680 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 681
 682         PR libctf/25120
 683         * ctf-archive.c (search_nametbl): No longer global: declare...
 684         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 685         (search_modent_by_name): Take and use ARG for the nametbl.
 686
 687 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 688
 689         * ctf-impl.h (ctf_new_archive_internal): Declare.
 690         (ctf_arc_bufopen): Remove.
 691         (ctf_archive_internal) <ctfi_free_symsect>: New.
 692         * ctf-archive.c (ctf_arc_close): Use it.
 693         (ctf_arc_bufopen): Fuse into...
 694         (ctf_new_archive_internal): ... this, moved across from...
 695         * ctf-open-bfd.c: ... here.
 696         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 697         * libctf.ver: Add it.
 698
 699 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 700
 701         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 702         (ctf_dtd_delete): Remove correspondingly.
 703         (ctf_rollback): Likewise.
 704
 705 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 706
 707         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 708         unchanged.
 709
 710 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 711
 712         * ctf-create.c (ctf_add_forward): Don't add forwards to
 713         types that already exist.
 714
 715 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 716
 717         * ctf-open.c (init_types): Only intern root-visible types.
 718         * ctf-create.c (ctf_dtd_insert): Likewise.
 719         (ctf_dtd_delete): Only remove root-visible types.
 720         (ctf_rollback): Likewise.
 721         (ctf_add_generic): Adjust.
 722         (ctf_add_struct_sized): Adjust comment.
 723         (ctf_add_union_sized): Likewise.
 724         (ctf_add_enum): Likewise.
 725         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 726
 727 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 728
 729         * swap.h (bswap_identity_64): Make static.
 730
 731 2020-01-18  Nick Clifton  <nickc@redhat.com>
 732
 733         Binutils 2.34 branch created.
 734
 735 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 736
 737         PR binutils/25155:
 738         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 739         * configure, config.h.in: Regenerate.
 740
 741 2020-01-01  Alan Modra  <amodra@gmail.com>
 742
 743         Update year range in copyright notice of all files.
 744
 745 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 746
 747         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 748
 749 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 750
 751         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 752         * ctf-types.c (ctf_type_lname): Likewise.
 753
 754 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 755
 756         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 757         ctf_import after the first for a given file.
 758
 759 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 760
 761         * ctf-impl.h (ctf_str_append_noerr): Declare.
 762         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 763         ctf_str_append.
 764         * ctf-dump.c (str_append): New, call it.
 765         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 766         (ctf_dump_label): Likewise.
 767         (ctf_dump_objts): Likewise.
 768         (ctf_dump_funcs): Likewise.
 769         (ctf_dump_var): Likewise.
 770         (ctf_dump_member): Likewise.
 771         (ctf_dump_type): Likewise.
 772         (ctf_dump): Likewise.
 773
 774 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 775
 776         * ctf-impl.h (ctf_alloc): Remove.
 777         (ctf_free): Likewise.
 778         (ctf_strdup): Likewise.
 779         * ctf-subr.c (ctf_alloc): Remove.
 780         (ctf_free): Likewise.
 781         * ctf-util.c (ctf_strdup): Remove.
 782
 783         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 784         ctf_free; strdup, not ctf_strdup.
 785         (ctf_dtd_delete): Likewise.
 786         (ctf_dvd_delete): Likewise.
 787         (ctf_add_generic): Likewise.
 788         (ctf_add_function): Likewise.
 789         (ctf_add_enumerator): Likewise.
 790         (ctf_add_member_offset): Likewise.
 791         (ctf_add_variable): Likewise.
 792         (membadd): Likewise.
 793         (ctf_compress_write): Likewise.
 794         (ctf_write_mem): Likewise.
 795         * ctf-decl.c (ctf_decl_push): Likewise.
 796         (ctf_decl_fini): Likewise.
 797         (ctf_decl_sprintf): Likewise.  Check for OOM.
 798         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 799         ctf_free; strdup, not ctf_strdup.
 800         (ctf_dump_free): Likewise.
 801         (ctf_dump): Likewise.
 802         * ctf-open.c (upgrade_types_v1): Likewise.
 803         (init_types): Likewise.
 804         (ctf_file_close): Likewise.
 805         (ctf_bufopen_internal): Likewise.  Check for OOM.
 806         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 807         (ctf_cuname_set): Likewise.
 808         (ctf_import): Likewise.
 809         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 810         free, not ctf_free; strdup, not ctf_strdup.
 811         (ctf_str_free_atom): Likewise.
 812         (ctf_str_create_atoms): Likewise.
 813         (ctf_str_add_ref_internal): Likewise.
 814         (ctf_str_remove_ref): Likewise.
 815         (ctf_str_write_strtab): Likewise.
 816
 817 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 818
 819         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 820         work right for non-int/fps.
 821
 822 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 823
 824         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 825         null pointer.
 826
 827 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 828
 829         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 830         * ctf-open.c (ctf_file_close): Free it.
 831         * ctf-create.c (ctf_serialize): Adjust.
 832         (membcmp): When reporting a conflict due to an error, report the
 833         error.
 834         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 835         (ctf_add_type_internal): ... this.  Hand back types we are already
 836         in the middle of adding immediately.  Hand back structs/unions with
 837         the same number of members immediately.  Do not walk the dynamic
 838         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 839         forwards promoted to other types and the inverse case identically.
 840         Add structs to the mapping as soon as we intern them, before they
 841         gain any members.
 842
 843 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 844
 845         * ctf-impl.h (ctf_names_t): New.
 846         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 847         (ctf_file_t) <ctf_structs>: Likewise.
 848         <ctf_unions>: Likewise.
 849         <ctf_enums>: Likewise.
 850         <ctf_names>: Likewise.
 851         <ctf_lookups>: Improve comment.
 852         <ctf_ptrtab_len>: New.
 853         <ctf_prov_strtab>: New.
 854         <ctf_str_prov_offset>: New.
 855         <ctf_dtbyname>: Remove, redundant to the names hashes.
 856         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 857         (ctf_dtdef_t) <dtd_name>: Remove.
 858         <dtd_data>: Note that the ctt_name is now populated.
 859         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 860         offset for internal strings too.
 861         <csa_external_offset>: New, the external strtab offset.
 862         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 863         (ctf_name_table): New declaration.
 864         (ctf_lookup_by_rawname): Likewise.
 865         (ctf_lookup_by_rawhash): Likewise.
 866         (ctf_set_ctl_hashes): Likewise.
 867         (ctf_serialize): Likewise.
 868         (ctf_dtd_insert): Adjust.
 869         (ctf_simple_open_internal): Likewise.
 870         (ctf_bufopen_internal): Likewise.
 871         (ctf_list_empty_p): Likewise.
 872         (ctf_str_remove_ref): Likewise.
 873         (ctf_str_add): Returns uint32_t now.
 874         (ctf_str_add_ref): Likewise.
 875         (ctf_str_add_external): Now returns a boolean (int).
 876         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 877         for strings in the appropriate range.
 878         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 879         when adding the null string to the new strtab.
 880         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 881         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 882         make_provisional, populate the offset and fill in the
 883         ctf_prov_strtab accordingly.
 884         (ctf_str_add): Return the offset, not the string.
 885         (ctf_str_add_ref): Likewise.
 886         (ctf_str_add_external): Return a success integer.
 887         (ctf_str_remove_ref): New, remove a single ref.
 888         (ctf_str_count_strtab): Do not count the initial null string's
 889         length or the existence or length of any unreferenced internal
 890         atoms.
 891         (ctf_str_populate_sorttab): Skip atoms with no refs.
 892         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 893         to the cts_len for the null string, since it is no longer done
 894         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 895         Populate the csa_offset for both internal and external cases.
 896         Flush the ctf_prov_strtab afterwards, and reset the
 897         ctf_str_prov_offset.
 898         * ctf-create.c (ctf_grow_ptrtab): New.
 899         (ctf_create): Call it.  Initialize new fields rather than old
 900         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 901         Set the ctl hashes and data model.
 902         (ctf_update): Rename to...
 903         (ctf_serialize): ... this.  Leave a compatibility function behind.
 904         Tell ctf_simple_open_internal that this is a writable dictionary.
 905         Pass the new fields along from the old dictionary.  Drop
 906         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 907         Do not zero out the DTD's ctt_name.
 908         (ctf_prefixed_name): Rename to...
 909         (ctf_name_table): ... this.  No longer return a prefixed name: return
 910         the applicable name table instead.
 911         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 912         kind we're adding.  Migrate away from dtd_name.
 913         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 914         deleted ctt_name.
 915         (ctf_dtd_lookup_type_by_name): Remove.
 916         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 917         No longer check ctf_dtnextid: check ctf_typemax instead.
 918         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 919         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 920         ctf_name_table and the right name table, and migrate away from
 921         dtd_name as in ctf_dtd_delete.
 922         (ctf_add_generic): Pass in the kind explicitly and pass it to
 923         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 924         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 925         Grow the ptrtab if needed.
 926         (ctf_add_encoded): Pass in the kind.
 927         (ctf_add_slice): Likewise.
 928         (ctf_add_array): Likewise.
 929         (ctf_add_function): Likewise.
 930         (ctf_add_typedef): Likewise.
 931         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 932         ctt_name rather than dtd_name.
 933         (ctf_add_struct_sized): Pass in the kind.  Use
 934         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 935         ctf_dtd_lookup_type_by_name.
 936         (ctf_add_union_sized): Likewise.
 937         (ctf_add_enum): Likewise.
 938         (ctf_add_enum_encoded): Likewise.
 939         (ctf_add_forward): Likewise.
 940         (ctf_add_type): Likewise.
 941         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 942         being initialized until after the call.
 943         (ctf_write_mem): Likewise.
 944         (ctf_write): Likewise.
 945         * ctf-archive.c (arc_write_one_ctf): Likewise.
 946         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 947         ctf_hash_lookup_type.
 948         (ctf_lookup_by_id): No longer check the readonly types if the
 949         dictionary is writable.
 950         * ctf-open.c (init_types): Assert that this dictionary is not
 951         writable.  Adjust to use the new name hashes, ctf_name_table,
 952         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 953         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 954         if set.  Drop out early when dictionary is writable.  Split the
 955         ctf_lookups initialization into...
 956         (ctf_set_cth_hashes): ... this new function.
 957         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 958         (ctf_simple_open): Adjust accordingly.
 959         (ctf_bufopen): Likewise.
 960         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 961         destroy ctf_dtbyname, which is gone.
 962         (ctf_getdatasect): Remove spurious "extern".
 963         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 964         specified name table, given a kind.
 965         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 966         (ctf_member_iter): Add support for iterating over the
 967         dynamic type list.
 968         (ctf_enum_iter): Likewise.
 969         (ctf_variable_iter): Likewise.
 970         (ctf_type_rvisit): Likewise.
 971         (ctf_member_info): Add support for types in the dynamic type list.
 972         (ctf_enum_name): Likewise.
 973         (ctf_enum_value): Likewise.
 974         (ctf_func_type_info): Likewise.
 975         (ctf_func_type_args): Likewise.
 976         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 977         ctf_update.
 978         (ctf_link_write): Likewise.
 979         (ctf_link_intern_extern_string): Adjust for new
 980         ctf_str_add_external return value.
 981         (ctf_link_add_strtab): Likewise.
 982         * ctf-util.c (ctf_list_empty_p): New.
 983
 984 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 985
 986         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 987         type zero.
 988         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 989         members and types.
 990         (ctf_add_variable): Likewise for variables pointing to them.
 991         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 992         type link failure, but do warn for others.
 993         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 994         errors to be ENOMEM.
 995         (ctf_dump_member): Likewise.
 996         (ctf_dump_type): Likewise.
 997         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 998         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 999         (ctf_dump_header): Likewise.
1000         (ctf_dump_label): likewise.
1001         (ctf_dump_objts): likewise.
1002         (ctf_dump_funcs): likewise.
1003         (ctf_dump_var): likewise.
1004         (ctf_dump_str): Likewise.
1005
1006 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1007
1008         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1009         (LT_INIT): Likewise.
1010         (AM_INSTALL_LIBBFD): Likewise.
1011         (dlopen): Note why this is necessary in a comment.
1012         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1013         opcodes/.
1014         (SHARED_LDFLAGS): Likewise.
1015         (BFD_LIBADD): Likewise, for libbfd.
1016         (BFD_DEPENDENCIES): Likewise.
1017         (VERSION_FLAGS): Initialize, using a version script if ld supports
1018         one, or libtool -export-symbols-regex otherwise.
1019         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1020         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1021         (INCDIR): New.
1022         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1023         (noinst_LIBRARIES): Replace with...
1024         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1025         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1026         libctf-nobfd.la as well.
1027         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1028         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1029         (libctf_a_SOURCES): Rename to...
1030         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1031         ctf-open-bfd.c.
1032         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1033         with ctf-open-bfd.c added.
1034         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1035         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1036         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1037         * Makefile.am [INSTALL_LIBCTF]: Use it.
1038         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1039         libtool macros.
1040         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1041         the unstable components).
1042         * Makefile.in: Regenerated.
1043         * config.h.in: Likewise.
1044         * configure: Likewise.
1045
1046 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1047
1048         * configure.ac (INSTALL_LIBCTF): New, controlled by
1049         --enable-install-libctf.
1050         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1051         * Makefile.in: Regenerated.
1052         * configure: Regenerated.
1053
1054 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1055
1056         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1057         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1058
1059 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1060
1061         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1062
1063 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1064
1065         * ctf-impl.h (includes): Include <sys/param.h> here.
1066
1067 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1068
1069         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1070         (flip_objts): Likewise.
1071         (flip_vars): Likewise.
1072         (flip_types): Likewise.
1073
1074 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1075
1076         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1077         freeing functions: if set, free the key and value if the slot
1078         already exists.  Always reassign the key.
1079         (ctf_dynhash_insert): Adjust call appropriately.
1080         (ctf_hash_insert_type): Likewise.
1081
1082 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1083
1084         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1085         type kind.  Allow forwards to unify with pre-existing structs/
1086         unions/enums.
1087
1088 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1089
1090         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1091         <ctf_link_memb_name_changer>: Likewise.
1092         <ctf_link_memb_name_changer_arg>: Likewise.
1093         * ctf-create.c (ctf_update): Update accordingly.
1094         * ctf-open.c (ctf_file_close): Likewise.
1095         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1096         (ctf_link_add_cu_mapping): New.
1097         (ctf_link_set_memb_name_changer): Likewise.
1098         (ctf_change_parent_name): New.
1099         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1100         allocated by the caller's ctf_link_memb_name_changer.
1101         <ndynames>: Likewise.
1102         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1103         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1104         ctf_change_parent_name.  Free any resulting names.
1105
1106 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1107
1108         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1109         (ctf_link_one_type): ... here, with parent-name setting added.
1110         (check_variable): New.
1111         (ctf_link_one_variable): Likewise.
1112         (ctf_link_one_input_archive_member): Call it.
1113         * ctf-error.c (_ctf_errlist): Updated with new errors.
1114
1115 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1116
1117         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1118         (struct ctf_link_type_mapping_key): New.
1119         (ctf_hash_type_mapping_key): Likewise.
1120         (ctf_hash_eq_type_mapping_key): Likewise.
1121         (ctf_add_type_mapping): Likewise.
1122         (ctf_type_mapping): Likewise.
1123         (ctf_dynhash_empty): Likewise.
1124         * ctf-open.c (ctf_file_close): Update accordingly.
1125         * ctf-create.c (ctf_update): Likewise.
1126         (ctf_add_type): Populate the mapping.
1127         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1128         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1129         (ctf_dynhash_insert): Fix comment typo.
1130         (ctf_dynhash_empty): New.
1131         * ctf-link.c (ctf_add_type_mapping): New.
1132         (ctf_type_mapping): Likewise.
1133         (empty_link_type_mapping): New.
1134         (ctf_link_one_input_archive): Call it.
1135
1136 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1137
1138         * ctf-link.c: New file, linking of the string and type sections.
1139         * Makefile.am (libctf_a_SOURCES): Add it.
1140         * Makefile.in: Regenerate.
1141
1142         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1143         ctf_link_outputs.
1144         * ctf-create.c (ctf_update): Update accordingly.
1145         * ctf-open.c (ctf_file_close): Likewise.
1146         * ctf-error.c (_ctf_errlist): Updated with new errors.
1147
1148 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1149
1150         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1151
1152 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1153
1154         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1155         ctf_type_iter.
1156         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1157         (ctf_dump_format_type): Add non-root-type { } notation.
1158         Add root flag to prototype.
1159         (ctf_dump_label): Adjust accordingly.
1160         (ctf_dump_objts): Likewise.
1161         (ctf_dump_var): Likewise.
1162
1163 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1164
1165         * ctf-create.c (ctf_compress_write): Fix double-free.
1166
1167 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1168
1169         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1170         of...
1171         (ctf_arc_write_fd): ... this new function.
1172         * ctf-create.c (ctf_write_mem): New.
1173
1174 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1175
1176         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1177         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1178         (ctf_str_add_ref): Name the last arg.
1179         (ctf_str_add_external) New.
1180         (ctf_str_add_strraw_explicit): Likewise.
1181         (ctf_simple_open_internal): Likewise.
1182         (ctf_bufopen_internal): Likewise.
1183
1184         * ctf-string.c (ctf_strraw_explicit): Split from...
1185         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1186         (ctf_str_add_ref_internal): Return the atom, not the
1187         string.
1188         (ctf_str_add): Adjust accordingly.
1189         (ctf_str_add_ref): Likewise.  Move up in the file.
1190         (ctf_str_add_external): New: update the csa_offset.
1191         (ctf_str_count_strtab): Only account for strings with no csa_offset
1192         in the internal strtab length.
1193         (ctf_str_write_strtab): If the csa_offset is set, update the
1194         string's refs without writing the string out, and update the
1195         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1196         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1197         (ctf_update): Handle failure to populate the strtab.  Pass in the
1198         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1199         Call ctf_simple_open_internal, not ctf_simple_open.
1200         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1201         strings by hand.
1202         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1203         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1204         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1205         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1206         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1207         (ctf_simple_open_internal): ... this new function, which calls
1208         ctf_bufopen_internal.
1209         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1210         (ctf_bufopen_internal): ... this new function, which sets
1211         ctf_syn_ext_strtab.
1212
1213 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1214
1215         * ctf_types.c (ctf_type_iter_all): New.
1216
1217 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1218
1219         * ctf-open.c (init_symtab): Check for overflow against the right
1220         section.
1221         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1222         (upgrade_types_v1): Note that these sections are not checked.
1223         (flip_header): Endian-swap the header fields.
1224         (flip_ctf): Endian-swap the sections.
1225         (flip_objts): Update comment.
1226         (ctf_bufopen): Check header offsets and alignment for validity.
1227
1228 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1229
1230         * ctf-open-bfd.c: Add <assert.h>.
1231         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1232         techniques borrowed from bfd_elf_sym_name.
1233         (ctf_new_archive_internal): Improve comment.
1234         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1235         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1236         no symbol section, but not vice versa.
1237
1238 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1239
1240         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1241         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1242         * ctf-dump.c (dump_header): New function, dump the CTF header.
1243         (ctf_dump): Call it.
1244         (ctf_dump_header_strfield): New function.
1245         (ctf_dump_header_sectfield): Likewise.
1246
1247 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1248
1249         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1250         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1251         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1252         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1253         Print out ctf_cuname: only print out ctf_parname if set.
1254         (ctf_free_base): Removed, ctf_base is no longer freed: free
1255         ctf_dynbase instead.
1256         (ctf_set_version): Fix spacing.
1257         (upgrade_header): New, in-place header upgrading.
1258         (upgrade_types): Rename to...
1259         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1260         longer track old and new headers separately.  No longer allow for
1261         header sizes explicitly: squeeze the headers out on upgrade (they
1262         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1263         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1264         (upgrade_types): New, also handle ctf_parmax updating.
1265         (flip_header): Flip ctf_cuname.
1266         (flip_types): Flip BUF explicitly rather than deriving BUF from
1267         BASE.
1268         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1269         required alignment of objtoff and funcoff.  No longer store it in
1270         the ctf_buf unless that buf is derived unmodified from the input.
1271         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1272         that duplicate fields in ctf_file: move allocation of ctf_file
1273         further up instead.  Call upgrade_header as needed.  Move
1274         version-specific ctf_parmax initialization into upgrade_types.  More
1275         concise error handling.
1276         (ctf_file_close): No longer test for null pointers before freeing.
1277         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1278         ctf_free_base.
1279         (ctf_cuname): New.
1280         (ctf_cuname_set): New.
1281         * ctf-create.c (ctf_update): Populate ctf_cuname.
1282         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1283         comment.
1284         (ctf_write): Likewise.
1285         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1286         Fix the compression length: fp->ctf_size never counted the CTF
1287         header.  Simplify the compress call accordingly.
1288
1289 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1290
1291         * ctf-endian.h: Don't assume htole64 and le64toh are always
1292         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1293         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1294         not bswap_identity_64.
1295
1296 2019-09-18  Alan Modra  <amodra@gmail.com>
1297
1298         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1299
1300 2019-09-09  Phil Blundell  <pb@pbcl.net>
1301
1302         binutils 2.33 branch created.
1303
1304 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1305
1306         * ctf-types.c (ctf_type_aname_raw): New.
1307         (ctf_func_type_info): Likewise.
1308         (ctf_func_type_args): Likewise.
1309         * ctf-error.c (_ctf_errlist): Fix description.
1310         * ctf-lookup.c: Fix file description.
1311
1312 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1313
1314         * ctf-create.c (ctf_create): Fix off-by-one error.
1315
1316 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1317
1318         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1319         struct ctf_strs.
1320         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1321         (struct ctf_str_atom): New, disambiguated single string.
1322         (struct ctf_str_atom_ref): New, points to some other location that
1323         references this string's offset.
1324         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1325         Remove member ctf_dtvstrlen: we no longer track the total strlen
1326         as we add strings.
1327         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1328         (ctf_str_free_atoms): Likewise.
1329         (ctf_str_add): Likewise.
1330         (ctf_str_add_ref): Likewise.
1331         (ctf_str_rollback): Likewise.
1332         (ctf_str_purge_refs): Likewise.
1333         (ctf_str_write_strtab): Likewise.
1334         (ctf_realloc): Declare new function in ctf-util.c.
1335
1336         * ctf-open.c (ctf_bufopen): Create the atoms table.
1337         (ctf_file_close): Destroy it.
1338         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1339         special-case the position of the parname string.  Construct the
1340         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1341         rest of each buffer element is constructed, not via open-coding:
1342         realloc the CTF buffer and append the strtab to it.  No longer
1343         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1344         strtab construction.
1345         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1346         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1347         after buffer element construction instead.
1348         (ctf_copy_lmembers): Likewise.
1349         (ctf_copy_emembers): Likewise.
1350         (ctf_create): No longer maintain the ctf_dtvstrlen.
1351         (ctf_dtd_delete): Likewise.
1352         (ctf_dvd_delete): Likewise.
1353         (ctf_add_generic): Likewise.
1354         (ctf_add_enumerator): Likewise.
1355         (ctf_add_member_offset): Likewise.
1356         (ctf_add_variable): Likewise.
1357         (membadd): Likewise.
1358         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1359         if there are active ctf_str_num_refs.
1360         (ctf_strraw): Move to ctf-string.c.
1361         (ctf_strptr): Likewise.
1362         * ctf-string.c: New file, strtab manipulation.
1363
1364         * Makefile.am (libctf_a_SOURCES): Add it.
1365         * Makefile.in: Regenerate.
1366
1367 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1368
1369         * ctf-impl.h (ctf_hash_iter_f): New.
1370         (ctf_dynhash_iter): New declaration.
1371         (ctf_dynhash_iter_remove): New declaration.
1372         * ctf-hash.c (ctf_dynhash_iter): Define.
1373         (ctf_dynhash_iter_remove): Likewise.
1374         (ctf_hashtab_traverse): New.
1375         (ctf_hashtab_traverse_remove): Likewise.
1376         (struct ctf_traverse_cb_arg): Likewise.
1377         (struct ctf_traverse_remove_cb_arg): Likewise.
1378
1379 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1380
1381         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1382
1383 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1384
1385         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1386         (ctf_dump_funcs): Likewise.
1387
1388 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1389
1390         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1391         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1392         little-endian CTF archive magic.  Do not check the CTF version:
1393         ctf_simple_open does that in endian-safe ways.  Do not dereference
1394         null pointers on open failure.
1395
1396 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1397
1398         * ctf-open.c (get_vbytes_common): Return the new slice size.
1399         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1400         Remember to copy in the CTF data when opening an uncompressed
1401         foreign-endian CTF file.  Prune useless variable manipulation.
1402
1403 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1404
1405         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1406         seen.
1407
1408 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1409
1410         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1411         output.
1412
1413 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1414
1415         * ctf-subr.c (_PAGESIZE): Remove.
1416         (ctf_data_alloc): Likewise.
1417         (ctf_data_free): Likewise.
1418         (ctf_data_protect): Likewise.
1419         * ctf-impl.h: Remove declarations.
1420         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1421         ctf_free, not ctf_data_free.
1422         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1423         the buffer again on compression error.
1424         * ctf-open.c (ctf_set_base): No longer track the size: call
1425         ctf_free, not ctf_data_free.
1426         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1427         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1428
1429 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1430
1431         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1432         ctf_dynhash_insert.
1433         (ctf_dvd_insert): Likewise.
1434         (ctf_add_generic): Likewise.
1435         (ctf_add_variable): Likewise.
1436         * ctf-impl.h: Adjust declarations.
1437
1438 2019-06-14  Alan Modra  <amodra@gmail.com>
1439
1440         * configure: Regenerate.
1441
1442 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1443
1444         * ctf-decls.h: Include <libiberty.h>.
1445         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1446
1447 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1448
1449         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1450         (ctf_dump_objts): Likewise.
1451         (ctf_dump_funcs): Likewise.
1452         (ctf_dump_member): Likewise.
1453         (ctf_dump_str): Likewise.
1454
1455 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1456
1457         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1458         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1459
1460 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1461
1462         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1463         (ctf_arc_open_by_offset): Likewise.
1464         * ctf-create.c (ctf_add_type): Likewise.
1465
1466 2019-06-04  Tom Tromey  <tromey@adacore.com>
1467
1468         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1469         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1470
1471 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1472
1473         * configure.ac: Check for O_CLOEXEC.
1474         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1475         * config.h.in: Regenerate.
1476         * configure: Likewise.
1477
1478 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1479
1480         * qsort_r.c: Rename to...
1481         * ctf-qsort_r.c: ... this.
1482         (_quicksort): Define to ctf_qsort_r.
1483         * ctf-decls.h (qsort_r): Remove.
1484         (ctf_qsort_r): Add.
1485         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1486         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1487         * Makefile.am (libctf_a_LIBADD): Remove.
1488         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1489         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1490         * ctf-create.c (ctf_update): Likewise.
1491         * configure.ac: Check for BSD versus GNU qsort_r signature.
1492         * Makefile.in: Regenerate.
1493         * config.h.in: Likewise.
1494         * configure: Likewise.
1495
1496 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1497
1498         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1499
1500 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1501
1502         * Makefile.am (ZLIB): New.
1503         (ZLIBINC): Likewise.
1504         (AM_CFLAGS): Use them.
1505         (libctf_a_LIBADD): New, for LIBOBJS.
1506         * configure.ac: Check for zlib, endian.h, and qsort_r.
1507         * ctf-endian.h: New, providing htole64 and le64toh.
1508         * swap.h: Code style fixes.
1509         (bswap_identity_64): New.
1510         * qsort_r.c: New, from gnulib (with one added #include).
1511         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1512         and unconditional definitions of MIN and MAX.
1513         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1514         (ctf_set_errno): Now returns unsigned long.
1515         * ctf-util.c (ctf_set_errno): Adjust here too.
1516         * ctf-archive.c: Use ctf-endian.h.
1517         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1518         cts_flags and cts_offset.
1519         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1520         * ctf-create.c: Provide a definition of roundup if not defined.
1521         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1522         (ctf_add_reftype): Do not check if type IDs are below zero.
1523         (ctf_add_slice): Likewise.
1524         (ctf_add_typedef): Likewise.
1525         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1526         when known error-free.  Drop CTF_ERR usage for functions returning
1527         int.
1528         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1529         int.
1530         (ctf_add_variable): Likewise.
1531         (enumcmp): Likewise.
1532         (enumadd): Likewise.
1533         (membcmp): Likewise.
1534         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1535         when known error-free.
1536         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1537         returning int: use CTF_ERR for functions returning ctf_type_id.
1538         (ctf_dump_label): Likewise.
1539         (ctf_dump_objts): Likewise.
1540         * ctf-labels.c (ctf_label_topmost): Likewise.
1541         (ctf_label_iter): Likewise.
1542         (ctf_label_info): Likewise.
1543         * ctf-lookup.c (ctf_func_args): Likewise.
1544         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1545         (ctf_bufopen): Likewise.  Use zlib types as needed.
1546         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1547         returning int.
1548         (ctf_enum_iter): Likewise.
1549         (ctf_type_size): Likewise.
1550         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1551         (ctf_type_kind_unsliced): Likewise.
1552         (ctf_type_kind): Likewise.
1553         (ctf_type_encoding): Likewise.
1554         (ctf_member_info): Likewise.
1555         (ctf_array_info): Likewise.
1556         (ctf_enum_value): Likewise.
1557         (ctf_type_rvisit): Likewise.
1558         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1559         cts_offset.
1560         (ctf_simple_open): Likewise.
1561         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1562         * Makefile.in: Regenerate.
1563         * aclocal.m4: Likewise.
1564         * config.h: Likewise.
1565         * configure: Likewise.
1566
1567 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1568
1569         * configure.in: Check for bfd_section_from_elf_index.
1570         * configure: Regenerate.
1571         * config.h.in [HAVE_BFD_ELF]: Likewise.
1572         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1573         abfd is potentially unused now.
1574
1575 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1576
1577         * Makefile.am: New.
1578         * Makefile.in: Regenerated.
1579         * config.h.in: Likewise.
1580         * aclocal.m4: Likewise.
1581         * configure: Likewise.
1582
1583 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1584
1585         * ctf-dump.c: New.
1586
1587 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1588
1589         * ctf-labels.c: New.
1590
1591 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1592
1593         * ctf-impl.h (_libctf_version): New declaration.
1594         * ctf-subr.c (_libctf_version): Define it.
1595         (ctf_version): New.
1596
1597 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1598
1599         * ctf-create.c (enumcmp): New.
1600         (enumadd): Likewise.
1601         (membcmp): Likewise.
1602         (membadd): Likewise.
1603         (ctf_add_type): Likewise.
1604
1605 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1606
1607         * ctf-lookup.c (isqualifier): New.
1608         (ctf_lookup_by_name): Likewise.
1609         (struct ctf_lookup_var_key): Likewise.
1610         (ctf_lookup_var): Likewise.
1611         (ctf_lookup_variable): Likewise.
1612         (ctf_lookup_symbol_name): Likewise.
1613         (ctf_lookup_by_symbol): Likewise.
1614         (ctf_func_info): Likewise.
1615         (ctf_func_args): Likewise.
1616
1617 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1618
1619         * ctf-decl.c: New file.
1620         * ctf-types.c: Likewise.
1621         * ctf-impl.h: New declarations.
1622
1623 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1624
1625         * ctf-open-bfd.c: New file.
1626         * ctf-open.c (ctf_close): New.
1627         * ctf-impl.h: Include bfd.h.
1628         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1629         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1630         ctfi_bfd_close.
1631         (ctf_bfdopen_ctfsect): New declaration.
1632         (_CTF_SECTION): likewise.
1633
1634 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1635
1636         * ctf-archive.c: New.
1637         * ctf-impl.h (ctf_archive_internal): New type.
1638         (ctf_arc_open_internal): New declaration.
1639         (ctf_arc_bufopen): Likewise.
1640         (ctf_arc_close_internal): Likewise.
1641
1642 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1643
1644         * ctf-open.c: New file.
1645         * swap.h: Likewise.
1646
1647 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1648
1649         * ctf-create.c: New file.
1650         * ctf-lookup.c: New file.
1651
1652 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1653
1654         * ctf-impl.h: New definitions and declarations for type creation
1655         and lookup.
1656
1657 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1658
1659         * ctf-hash.c: New file.
1660         * ctf-impl.h: New declarations.
1661
1662 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1663
1664         * ctf-error.c: New file.
1665
1666 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1667
1668         * ctf-util.c: New file.
1669         * elf.h: Likewise.
1670         * ctf-impl.h: Include it, and add declarations.
1671
1672 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1673
1674         * ctf-impl.h: New file.
1675         * ctf-subr.c: New file.
1676
1677 \f
1678 Local Variables:
1679 mode: change-log
1680 left-margin: 8
1681 fill-column: 76
1682 version-control: never
1683 End: