1 From: Omar Ramirez Luna <x00omar@ti.com>
2 Subject: [PATCH] BRIDGE: Cosmetic changes reported from checkpatch
4 Cosmetic changes reported from checkpatch
6 Signed-off-by: Omar Ramirez Luna <x00omar@ti.com>
7 Acked-by: Hari Kanigeri <h-kanigeri2@ti.com>
9 drivers/dsp/bridge/gen/gs.c | 2 +-
10 drivers/dsp/bridge/gen/gt.c | 2 +-
11 drivers/dsp/bridge/pmgr/dbll.c | 4 ++--
12 drivers/dsp/bridge/pmgr/dev.c | 3 ++-
13 drivers/dsp/bridge/pmgr/wcd.c | 2 ++
14 drivers/dsp/bridge/rmgr/drv.c | 2 +-
15 drivers/dsp/bridge/rmgr/drv_interface.c | 12 +++++++-----
16 drivers/dsp/bridge/rmgr/node.c | 17 +++++++++++------
17 drivers/dsp/bridge/rmgr/proc.c | 19 +++++++++++++------
18 drivers/dsp/bridge/rmgr/strm.c | 14 ++++++++++----
19 drivers/dsp/bridge/services/cfg.c | 2 +-
20 drivers/dsp/bridge/services/mem.c | 2 +-
21 drivers/dsp/bridge/services/ntfy.c | 2 +-
22 drivers/dsp/bridge/services/services.c | 2 +-
23 drivers/dsp/bridge/services/sync.c | 2 +-
24 drivers/dsp/bridge/wmd/ue_deh.c | 6 ++++--
25 arch/arm/plat-omap/include/bridge/resourcecleanup.h | 3 ++-
26 17 files changed, 61 insertions(+), 35 deletions(-)
28 Index: lk/drivers/dsp/bridge/gen/gs.c
29 ===================================================================
30 --- lk.orig/drivers/dsp/bridge/gen/gs.c 2008-08-18 10:38:36.000000000 +0300
31 +++ lk/drivers/dsp/bridge/gen/gs.c 2008-08-18 10:38:40.000000000 +0300
36 - static bool curInit = false;
37 + static bool curInit;
39 if (curInit == false) {
41 Index: lk/drivers/dsp/bridge/gen/gt.c
42 ===================================================================
43 --- lk.orig/drivers/dsp/bridge/gen/gt.c 2008-08-18 10:38:40.000000000 +0300
44 +++ lk/drivers/dsp/bridge/gen/gt.c 2008-08-18 10:38:40.000000000 +0300
47 static unsigned char *GT_tMask[GT_BOUND];
49 -static bool curInit = false;
51 static char *separator;
52 static unsigned char tabMem[GT_BOUND][sizeof(unsigned char) * GT_BOUND];
54 Index: lk/drivers/dsp/bridge/pmgr/dbll.c
55 ===================================================================
56 --- lk.orig/drivers/dsp/bridge/pmgr/dbll.c 2008-08-18 10:38:39.000000000 +0300
57 +++ lk/drivers/dsp/bridge/pmgr/dbll.c 2008-08-18 10:38:40.000000000 +0300
59 static void symDelete(void *sp);
62 -static struct GT_Mask DBLL_debugMask = { NULL, NULL }; /* GT trace variable */
63 +static struct GT_Mask DBLL_debugMask = { NULL, NULL }; /* GT trace variable */
66 static u32 cRefs; /* module reference count */
68 /* Symbol Redefinition */
69 -static int bRedefinedSymbol = 0;
70 +static int bRedefinedSymbol;
71 static int bGblSearch = 1;
74 Index: lk/drivers/dsp/bridge/pmgr/dev.c
75 ===================================================================
76 --- lk.orig/drivers/dsp/bridge/pmgr/dev.c 2008-08-18 10:38:37.000000000 +0300
77 +++ lk/drivers/dsp/bridge/pmgr/dev.c 2008-08-18 10:38:40.000000000 +0300
79 status = DEV_GetCodMgr(hDevObject, &hCodMgr);
80 if (DSP_SUCCEEDED(status)) {
81 DBC_Assert(hCodMgr != NULL);
82 - status = COD_GetSymValue(hCodMgr, (char *)pstrSym, pulValue);
83 + status = COD_GetSymValue(hCodMgr, (char *)pstrSym,
88 Index: lk/drivers/dsp/bridge/pmgr/wcd.c
89 ===================================================================
90 --- lk.orig/drivers/dsp/bridge/pmgr/wcd.c 2008-08-18 10:38:39.000000000 +0300
91 +++ lk/drivers/dsp/bridge/pmgr/wcd.c 2008-08-18 10:38:40.000000000 +0300
95 /* ----------------------------------- Globals */
97 static struct GT_Mask WCD_debugMask = { NULL, NULL }; /* Core VxD Mask */
102 Index: lk/drivers/dsp/bridge/rmgr/drv.c
103 ===================================================================
104 --- lk.orig/drivers/dsp/bridge/rmgr/drv.c 2008-08-18 10:38:39.000000000 +0300
105 +++ lk/drivers/dsp/bridge/rmgr/drv.c 2008-08-18 10:38:40.000000000 +0300
109 /* Actual Node De-Allocation */
110 -DSP_STATUS DRV_ProcFreeNodeRes(HANDLE hPCtxt)
111 +static DSP_STATUS DRV_ProcFreeNodeRes(HANDLE hPCtxt)
113 struct PROCESS_CONTEXT *pCtxt = (struct PROCESS_CONTEXT *)hPCtxt;
114 DSP_STATUS status = DSP_SOK;
115 Index: lk/drivers/dsp/bridge/rmgr/drv_interface.c
116 ===================================================================
117 --- lk.orig/drivers/dsp/bridge/rmgr/drv_interface.c 2008-08-18 10:38:39.000000000 +0300
118 +++ lk/drivers/dsp/bridge/rmgr/drv_interface.c 2008-08-18 10:38:40.000000000 +0300
120 #if !defined(CONFIG_ARCH_OMAP2430) && !defined(CONFIG_ARCH_OMAP3430)
121 static int tc_wordswapon = 1; /* Default value is always TRUE */
123 -static int tc_wordswapon = 0; /* Default value is always true */
124 +static int tc_wordswapon; /* Default value is always true */
129 DRV_RemoveAllResources(pCtxtclosed);
130 if (pCtxtclosed->hProcessor != NULL) {
131 DRV_GetProcCtxtList(&pCtxttraverse,
132 - (struct DRV_OBJECT *)hDrvObject);
133 + (struct DRV_OBJECT *)hDrvObject);
134 if (pCtxttraverse->next == NULL) {
135 PROC_Detach(pCtxtclosed->hProcessor);
140 pTmp = pCtxtclosed->next;
141 - DRV_RemoveProcContext((struct DRV_OBJECT *)hDrvObject, pCtxtclosed,
142 - (void *)pCtxtclosed->pid);
143 + DRV_RemoveProcContext((struct DRV_OBJECT *)hDrvObject,
145 + (void *)pCtxtclosed->pid);
147 pTmp = pCtxtclosed->next;
151 dsp_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
152 if (DSP_SUCCEEDED(dsp_status))
153 - dsp_status = DRV_InsertProcContext((struct DRV_OBJECT *)hDrvObject, &pPctxt);
154 + dsp_status = DRV_InsertProcContext(
155 + (struct DRV_OBJECT *)hDrvObject, &pPctxt);
157 if (pPctxt != NULL) {
158 PRCS_GetCurrentHandle(&hProcess);
159 Index: lk/drivers/dsp/bridge/rmgr/node.c
160 ===================================================================
161 --- lk.orig/drivers/dsp/bridge/rmgr/node.c 2008-08-18 10:38:39.000000000 +0300
162 +++ lk/drivers/dsp/bridge/rmgr/node.c 2008-08-18 10:38:40.000000000 +0300
163 @@ -776,10 +776,13 @@
164 res_status = CFG_GetObject((u32 *)&hDrvObject,
166 if (DSP_SUCCEEDED(res_status)) {
167 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pPctxt,
169 + DRV_GetProcContext((u32)hProcess,
170 + (struct DRV_OBJECT *)hDrvObject,
171 + &pPctxt, *phNode, 0);
172 if (pPctxt == NULL) {
173 - DRV_InsertProcContext((struct DRV_OBJECT *)hDrvObject, &pPctxt);
174 + DRV_InsertProcContext(
175 + (struct DRV_OBJECT *)hDrvObject,
177 if (pPctxt != NULL) {
178 DRV_ProcUpdatestate(pPctxt,
181 res_status = CFG_GetObject((u32 *)&hDrvObject,
183 if (DSP_SUCCEEDED(res_status)) {
184 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pPctxt,
186 + DRV_GetProcContext((u32)hProcess,
187 + (struct DRV_OBJECT *)hDrvObject,
188 + &pPctxt, *phNode, 0);
189 if (pPctxt != NULL) {
190 DRV_InsertNodeResElement(*phNode, &nodeRes,
192 @@ -1775,7 +1779,8 @@
193 if (DSP_FAILED(res_status))
196 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, hNode, 0);
197 + DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject,
202 Index: lk/drivers/dsp/bridge/rmgr/proc.c
203 ===================================================================
204 --- lk.orig/drivers/dsp/bridge/rmgr/proc.c 2008-08-18 10:38:39.000000000 +0300
205 +++ lk/drivers/dsp/bridge/rmgr/proc.c 2008-08-18 10:38:40.000000000 +0300
207 if (DSP_FAILED(res_status))
210 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDRVObject, &pPctxt, NULL, 0);
211 + DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDRVObject,
213 if (pPctxt == NULL) {
214 DRV_InsertProcContext((struct DRV_OBJECT *)hDRVObject, &pPctxt);
215 if (pPctxt != NULL) {
217 PRCS_GetCurrentHandle(&hProcess);
218 res_status = CFG_GetObject((u32 *)&hDRVObject, REG_DRV_OBJECT);
219 if (DSP_SUCCEEDED(res_status)) {
220 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDRVObject, &pPctxt, NULL, 0);
221 + DRV_GetProcContext((u32)hProcess,
222 + (struct DRV_OBJECT *)hDRVObject, &pPctxt,
225 pPctxt->hProcessor = (DSP_HPROCESSOR)*phProcessor;
228 res_status = CFG_GetObject((u32 *)&hDRVObject, REG_DRV_OBJECT);
229 /* res_status = CFG_GetObject(REG_DRV_OBJECT, (u32*)&hDRVObject); */
230 if (DSP_SUCCEEDED(res_status)) {
231 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDRVObject, &pPctxt, NULL, 0);
232 + DRV_GetProcContext((u32)hProcess,
233 + (struct DRV_OBJECT *)hDRVObject, &pPctxt,
236 pPctxt->hProcessor = NULL;
238 @@ -1383,8 +1388,9 @@
239 res_status = CFG_GetObject((u32 *)&hDrvObject,
241 if (DSP_SUCCEEDED(res_status)) {
242 - if (DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt,
243 - NULL, (u32)pMpuAddr) != DSP_ENOTFOUND) {
244 + if (DRV_GetProcContext((u32)hProcess,
245 + (struct DRV_OBJECT *)hDrvObject, &pCtxt, NULL,
246 + (u32)pMpuAddr) != DSP_ENOTFOUND) {
247 DRV_InsertDMMResElement(&dmmRes, pCtxt);
248 DRV_UpdateDMMResElement(dmmRes, (u32)pMpuAddr,
249 ulSize, (u32)pReqAddr,
250 @@ -1737,7 +1743,8 @@
251 if (DSP_FAILED(res_status))
254 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, NULL, (u32)pMapAddr);
255 + DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject,
256 + &pCtxt, NULL, (u32)pMapAddr);
258 if (DRV_GetDMMResElement((u32)pMapAddr, &dmmRes, pCtxt) !=
260 Index: lk/drivers/dsp/bridge/rmgr/strm.c
261 ===================================================================
262 --- lk.orig/drivers/dsp/bridge/rmgr/strm.c 2008-08-18 10:38:39.000000000 +0300
263 +++ lk/drivers/dsp/bridge/rmgr/strm.c 2008-08-18 10:38:40.000000000 +0300
265 if (DSP_FAILED(res_status))
268 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, NULL, 0);
269 + DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject,
272 if (DRV_GetSTRMResElement(hStrm, &hSTRMRes, pCtxt) !=
275 if (DSP_FAILED(res_status))
278 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, NULL, 0);
279 + DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject,
282 if (DRV_GetSTRMResElement(hStrm, &hSTRMRes, pCtxt) !=
285 PRCS_GetCurrentHandle(&hProcess);
286 res_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
287 if (DSP_SUCCEEDED(res_status)) {
288 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, NULL, 0);
289 + DRV_GetProcContext((u32)hProcess,
290 + (struct DRV_OBJECT *)hDrvObject, &pCtxt,
293 if (DRV_GetSTRMResElement(hStrm, hSTRMRes, pCtxt) !=
296 PRCS_GetCurrentHandle(&hProcess);
297 res_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
298 if (DSP_SUCCEEDED(res_status)) {
299 - DRV_GetProcContext((u32)hProcess, (struct DRV_OBJECT *)hDrvObject, &pCtxt, hNode, 0);
300 + DRV_GetProcContext((u32)hProcess,
301 + (struct DRV_OBJECT *)hDrvObject, &pCtxt,
304 DRV_ProcInsertSTRMResElement(*phStrm, &hSTRMRes, pCtxt);
306 Index: lk/drivers/dsp/bridge/services/cfg.c
307 ===================================================================
308 --- lk.orig/drivers/dsp/bridge/services/cfg.c 2008-08-18 10:38:37.000000000 +0300
309 +++ lk/drivers/dsp/bridge/services/cfg.c 2008-08-18 10:38:40.000000000 +0300
312 /* ----------------------------------- Globals */
314 -static struct GT_Mask CFG_debugMask = { NULL, NULL }; /* CFG debug Mask */
315 +static struct GT_Mask CFG_debugMask = { NULL, NULL }; /* CFG debug Mask */
319 Index: lk/drivers/dsp/bridge/services/mem.c
320 ===================================================================
321 --- lk.orig/drivers/dsp/bridge/services/mem.c 2008-08-18 10:38:39.000000000 +0300
322 +++ lk/drivers/dsp/bridge/services/mem.c 2008-08-18 10:38:40.000000000 +0300
325 static u32 cRefs; /* module reference count */
327 -static bool extPhysMemPoolEnabled = false;
328 +static bool extPhysMemPoolEnabled;
330 struct extPhysMemPool {
332 Index: lk/drivers/dsp/bridge/services/ntfy.c
333 ===================================================================
334 --- lk.orig/drivers/dsp/bridge/services/ntfy.c 2008-08-18 10:38:37.000000000 +0300
335 +++ lk/drivers/dsp/bridge/services/ntfy.c 2008-08-18 10:38:40.000000000 +0300
338 /* ----------------------------------- Globals */
340 -static struct GT_Mask NTFY_debugMask = { NULL, NULL }; /* GT trace variable */
341 +static struct GT_Mask NTFY_debugMask = { NULL, NULL }; /* GT trace variable */
344 /* ----------------------------------- Function Prototypes */
345 Index: lk/drivers/dsp/bridge/services/services.c
346 ===================================================================
347 --- lk.orig/drivers/dsp/bridge/services/services.c 2008-08-18 10:38:37.000000000 +0300
348 +++ lk/drivers/dsp/bridge/services/services.c 2008-08-18 10:38:40.000000000 +0300
351 /* ----------------------------------- Globals */
353 -static struct GT_Mask SERVICES_debugMask = { NULL, NULL }; /* GT trace var. */
354 +static struct GT_Mask SERVICES_debugMask = { NULL, NULL }; /* GT trace var. */
357 static u32 cRefs; /* SERVICES module reference count */
358 Index: lk/drivers/dsp/bridge/services/sync.c
359 ===================================================================
360 --- lk.orig/drivers/dsp/bridge/services/sync.c 2008-08-18 10:38:37.000000000 +0300
361 +++ lk/drivers/dsp/bridge/services/sync.c 2008-08-18 10:38:40.000000000 +0300
364 /* ----------------------------------- Globals */
366 -static struct GT_Mask SYNC_debugMask = { NULL, NULL }; /* GT trace variable */
367 +static struct GT_Mask SYNC_debugMask = { NULL, NULL }; /* GT trace variable */
370 static int test_and_set(volatile void *ptr, int val)
371 Index: lk/drivers/dsp/bridge/wmd/ue_deh.c
372 ===================================================================
373 --- lk.orig/drivers/dsp/bridge/wmd/ue_deh.c 2008-08-18 10:38:39.000000000 +0300
374 +++ lk/drivers/dsp/bridge/wmd/ue_deh.c 2008-08-18 10:38:40.000000000 +0300
377 #include <_tiomap_mmu.h>
379 -static struct HW_MMUMapAttrs_t mapAttrs = { HW_LITTLE_ENDIAN, HW_ELEM_SIZE_16BIT,
380 +static struct HW_MMUMapAttrs_t mapAttrs = { HW_LITTLE_ENDIAN,
381 + HW_ELEM_SIZE_16BIT,
383 #define VirtToPhys(x) ((x) - PAGE_OFFSET + PHYS_OFFSET)
387 /* MMU fault routine should have set err info
389 - pDevContext = (struct WMD_DEV_CONTEXT *)pDehMgr->hWmdContext;
390 + pDevContext = (struct WMD_DEV_CONTEXT *)pDehMgr->
392 pDehMgr->errInfo.dwErrMask = DSP_MMUFAULT;
393 printk(KERN_INFO "WMD_DEH_Notify: DSP_MMUFAULT,"
394 "errInfo = 0x%x\n", dwErrInfo);
395 Index: lk/arch/arm/plat-omap/include/bridge/resourcecleanup.h
396 ===================================================================
397 --- lk.orig/arch/arm/plat-omap/include/bridge/resourcecleanup.h 2008-08-18 10:38:39.000000000 +0300
398 +++ lk/arch/arm/plat-omap/include/bridge/resourcecleanup.h 2008-08-18 10:38:40.000000000 +0300
400 extern DSP_STATUS DRV_GetProcCtxtList(struct PROCESS_CONTEXT **pPctxt,
401 struct DRV_OBJECT *hDrvObject);
403 -extern DSP_STATUS DRV_InsertProcContext(struct DRV_OBJECT *hDrVObject, HANDLE hPCtxt);
404 +extern DSP_STATUS DRV_InsertProcContext(struct DRV_OBJECT *hDrVObject,
407 extern DSP_STATUS DRV_RemoveAllDMMResElements(HANDLE pCtxt);