1 From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
2 Subject: [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw
4 This access causes hang on Freescale P2020DS board (that has OHCI
5 provided by ULI 1533 chip).
7 Since preserving OHCI_FMINTERVAL was originally done only for NVIDIA
8 hardware and only later (in c6187597) was turned unconditional, and
9 c6187597 commit message again mentions only NVIDIA, I think it should be
10 safe to disable preserving OHCI_FMINTERVAL if device vendor is ULI.
12 Signed-off-by: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
14 drivers/usb/host/pci-quirks.c | 8 +++++---
15 1 file changed, 5 insertions(+), 3 deletions(-)
17 diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
18 index 00661d3..5acbd5b 100644
19 --- a/drivers/usb/host/pci-quirks.c
20 +++ b/drivers/usb/host/pci-quirks.c
21 @@ -571,7 +571,7 @@ static void quirk_usb_handoff_ohci(struct pci_dev *pdev)
26 + u32 uninitialized_var(fminterval);
29 if (!mmio_resource_enabled(pdev, 0))
30 @@ -619,7 +619,8 @@ static void quirk_usb_handoff_ohci(struct pci_dev *pdev)
33 /* software reset of the controller, preserving HcFmInterval */
34 - fminterval = readl(base + OHCI_FMINTERVAL);
35 + if (pdev->vendor != PCI_VENDOR_ID_AL)
36 + fminterval = readl(base + OHCI_FMINTERVAL);
37 writel(OHCI_HCR, base + OHCI_CMDSTATUS);
39 /* reset requires max 10 us delay */
40 @@ -628,7 +629,8 @@ static void quirk_usb_handoff_ohci(struct pci_dev *pdev)
44 - writel(fminterval, base + OHCI_FMINTERVAL);
45 + if (pdev->vendor != PCI_VENDOR_ID_AL)
46 + writel(fminterval, base + OHCI_FMINTERVAL);
48 /* Now the controller is safely in SUSPEND and nothing can wake it up */