1 From f63563615e357b7d794a38e1d37276c325d1466f Mon Sep 17 00:00:00 2001
2 From: popcornmix <popcornmix@gmail.com>
3 Date: Sat, 7 May 2016 13:47:42 +0100
4 Subject: [PATCH] [exif] Fix for out-of-memory errors with large numbers
7 This reverts part of https://github.com/xbmc/xbmc/pull/7472
9 Basically the commit made the 4 comments in the exif block increase
10 from 2K to 64K each, so you now need 256K per photo.
12 When opening a folder exif information for all photos is extracted.
13 So, for a folder of 5000 jpegs, 1.2GB of RAM is needed just for
16 As a 64K comment string is of no use to kodi, just truncate them to 2K
20 http://trac.kodi.tv/ticket/16193
21 http://forum.kodi.tv/showthread.php?tid=251908
23 Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
24 (backported from upstream commit in master branch:
25 https://github.com/xbmc/xbmc/commit/f63563615e357b7d794a38e1d37276c325d1466f)
27 lib/libexif/libexif.h | 2 +-
28 1 file changed, 1 insertion(+), 1 deletion(-)
30 diff --git a/lib/libexif/libexif.h b/lib/libexif/libexif.h
31 index aa8da07..519ac30 100644
32 --- a/lib/libexif/libexif.h
33 +++ b/lib/libexif/libexif.h
34 @@ -81,7 +81,7 @@ typedef struct {
35 #define EXIF_COMMENT_CHARSET_UNICODE 3 // Exif: Unicode (UTF-16)
36 #define EXIF_COMMENT_CHARSET_JIS 4 // Exif: JIS X208-1990
38 -#define MAX_COMMENT 65533 // 2 bytes - 2 for the length param
39 +#define MAX_COMMENT 2000
40 #define MAX_DATE_COPIES 10