1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
5 #include "net/cert/cert_verify_proc.h"
9 #include "base/callback_helpers.h"
10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h"
12 #include "base/logging.h"
13 #include "base/sha1.h"
14 #include "base/strings/string_number_conversions.h"
15 #include "crypto/sha2.h"
16 #include "net/base/net_errors.h"
17 #include "net/base/test_data_directory.h"
18 #include "net/cert/asn1_util.h"
19 #include "net/cert/cert_status_flags.h"
20 #include "net/cert/cert_verifier.h"
21 #include "net/cert/cert_verify_result.h"
22 #include "net/cert/crl_set.h"
23 #include "net/cert/crl_set_storage.h"
24 #include "net/cert/test_root_certs.h"
25 #include "net/cert/x509_certificate.h"
26 #include "net/test/cert_test_util.h"
27 #include "net/test/test_certificate_data.h"
28 #include "testing/gtest/include/gtest/gtest.h"
31 #include "base/win/windows_version.h"
32 #elif defined(OS_ANDROID)
33 #include "base/android/build_info.h"
36 using base::HexEncode
;
42 // A certificate for www.paypal.com with a NULL byte in the common name.
43 // From http://www.gossamer-threads.com/lists/fulldisc/full-disclosure/70363
44 unsigned char paypal_null_fingerprint
[] = {
45 0x4c, 0x88, 0x9e, 0x28, 0xd7, 0x7a, 0x44, 0x1e, 0x13, 0xf2, 0x6a, 0xba,
46 0x1f, 0xe8, 0x1b, 0xd6, 0xab, 0x7b, 0xe8, 0xd7
49 // Mock CertVerifyProc that will set |verify_result->is_issued_by_known_root|
50 // for all certificates that are Verified.
51 class WellKnownCaCertVerifyProc
: public CertVerifyProc
{
53 // Initialize a CertVerifyProc that will set
54 // |verify_result->is_issued_by_known_root| to |is_well_known|.
55 explicit WellKnownCaCertVerifyProc(bool is_well_known
)
56 : is_well_known_(is_well_known
) {}
58 // CertVerifyProc implementation:
59 bool SupportsAdditionalTrustAnchors() const override
{ return false; }
62 ~WellKnownCaCertVerifyProc() override
{}
65 int VerifyInternal(X509Certificate
* cert
,
66 const std::string
& hostname
,
69 const CertificateList
& additional_trust_anchors
,
70 CertVerifyResult
* verify_result
) override
;
72 const bool is_well_known_
;
74 DISALLOW_COPY_AND_ASSIGN(WellKnownCaCertVerifyProc
);
77 int WellKnownCaCertVerifyProc::VerifyInternal(
78 X509Certificate
* cert
,
79 const std::string
& hostname
,
82 const CertificateList
& additional_trust_anchors
,
83 CertVerifyResult
* verify_result
) {
84 verify_result
->is_issued_by_known_root
= is_well_known_
;
88 bool SupportsReturningVerifiedChain() {
89 #if defined(OS_ANDROID)
90 // Before API level 17, Android does not expose the APIs necessary to get at
91 // the verified certificate chain.
92 if (base::android::BuildInfo::GetInstance()->sdk_int() < 17)
98 bool SupportsDetectingKnownRoots() {
99 #if defined(OS_ANDROID)
100 // Before API level 17, Android does not expose the APIs necessary to get at
101 // the verified certificate chain and detect known roots.
102 if (base::android::BuildInfo::GetInstance()->sdk_int() < 17)
110 class CertVerifyProcTest
: public testing::Test
{
113 : verify_proc_(CertVerifyProc::CreateDefault()) {
115 ~CertVerifyProcTest() override
{}
118 bool SupportsAdditionalTrustAnchors() {
119 return verify_proc_
->SupportsAdditionalTrustAnchors();
122 int Verify(X509Certificate
* cert
,
123 const std::string
& hostname
,
126 const CertificateList
& additional_trust_anchors
,
127 CertVerifyResult
* verify_result
) {
128 return verify_proc_
->Verify(cert
, hostname
, flags
, crl_set
,
129 additional_trust_anchors
, verify_result
);
132 const CertificateList empty_cert_list_
;
133 scoped_refptr
<CertVerifyProc
> verify_proc_
;
136 TEST_F(CertVerifyProcTest
, DISABLED_WithoutRevocationChecking
) {
137 // Check that verification without revocation checking works.
138 CertificateList certs
= CreateCertificateListFromFile(
139 GetTestCertsDirectory(),
140 "googlenew.chain.pem",
141 X509Certificate::FORMAT_PEM_CERT_SEQUENCE
);
143 X509Certificate::OSCertHandles intermediates
;
144 intermediates
.push_back(certs
[1]->os_cert_handle());
146 scoped_refptr
<X509Certificate
> google_full_chain
=
147 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
150 CertVerifyResult verify_result
;
152 Verify(google_full_chain
.get(),
160 #if defined(OS_ANDROID) || defined(USE_OPENSSL_CERTS)
161 // TODO(jnd): http://crbug.com/117478 - EV verification is not yet supported.
162 #define MAYBE_EVVerification DISABLED_EVVerification
164 #define MAYBE_EVVerification EVVerification
166 TEST_F(CertVerifyProcTest
, MAYBE_EVVerification
) {
167 CertificateList certs
= CreateCertificateListFromFile(
168 GetTestCertsDirectory(),
170 X509Certificate::FORMAT_PEM_CERT_SEQUENCE
);
171 ASSERT_EQ(3U, certs
.size());
173 X509Certificate::OSCertHandles intermediates
;
174 intermediates
.push_back(certs
[1]->os_cert_handle());
175 intermediates
.push_back(certs
[2]->os_cert_handle());
177 scoped_refptr
<X509Certificate
> comodo_chain
=
178 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
181 scoped_refptr
<CRLSet
> crl_set(CRLSet::ForTesting(false, NULL
, ""));
182 CertVerifyResult verify_result
;
183 int flags
= CertVerifier::VERIFY_EV_CERT
;
184 int error
= Verify(comodo_chain
.get(),
190 EXPECT_EQ(OK
, error
);
191 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_IS_EV
);
194 TEST_F(CertVerifyProcTest
, PaypalNullCertParsing
) {
195 scoped_refptr
<X509Certificate
> paypal_null_cert(
196 X509Certificate::CreateFromBytes(
197 reinterpret_cast<const char*>(paypal_null_der
),
198 sizeof(paypal_null_der
)));
200 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), paypal_null_cert
.get());
202 const SHA1HashValue
& fingerprint
=
203 paypal_null_cert
->fingerprint();
204 for (size_t i
= 0; i
< 20; ++i
)
205 EXPECT_EQ(paypal_null_fingerprint
[i
], fingerprint
.data
[i
]);
208 CertVerifyResult verify_result
;
209 int error
= Verify(paypal_null_cert
.get(),
215 #if defined(USE_NSS_CERTS) || defined(OS_IOS) || defined(OS_ANDROID)
216 EXPECT_EQ(ERR_CERT_COMMON_NAME_INVALID
, error
);
218 // TOOD(bulach): investigate why macosx and win aren't returning
219 // ERR_CERT_INVALID or ERR_CERT_COMMON_NAME_INVALID.
220 EXPECT_EQ(ERR_CERT_AUTHORITY_INVALID
, error
);
222 // Either the system crypto library should correctly report a certificate
223 // name mismatch, or our certificate blacklist should cause us to report an
224 // invalid certificate.
225 #if defined(USE_NSS_CERTS) || defined(OS_WIN) || defined(OS_IOS)
226 EXPECT_TRUE(verify_result
.cert_status
&
227 (CERT_STATUS_COMMON_NAME_INVALID
| CERT_STATUS_INVALID
));
231 // A regression test for http://crbug.com/31497.
232 #if defined(OS_ANDROID)
233 // Disabled on Android, as the Android verification libraries require an
234 // explicit policy to be specified, even when anyPolicy is permitted.
235 #define MAYBE_IntermediateCARequireExplicitPolicy \
236 DISABLED_IntermediateCARequireExplicitPolicy
238 #define MAYBE_IntermediateCARequireExplicitPolicy \
239 IntermediateCARequireExplicitPolicy
241 TEST_F(CertVerifyProcTest
, MAYBE_IntermediateCARequireExplicitPolicy
) {
242 base::FilePath certs_dir
= GetTestCertsDirectory();
244 CertificateList certs
= CreateCertificateListFromFile(
245 certs_dir
, "explicit-policy-chain.pem",
246 X509Certificate::FORMAT_AUTO
);
247 ASSERT_EQ(3U, certs
.size());
249 X509Certificate::OSCertHandles intermediates
;
250 intermediates
.push_back(certs
[1]->os_cert_handle());
252 scoped_refptr
<X509Certificate
> cert
=
253 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
255 ASSERT_TRUE(cert
.get());
257 ScopedTestRoot
scoped_root(certs
[2].get());
260 CertVerifyResult verify_result
;
261 int error
= Verify(cert
.get(),
262 "policy_test.example",
267 EXPECT_EQ(OK
, error
);
268 EXPECT_EQ(0u, verify_result
.cert_status
);
271 // Test for bug 58437.
272 // This certificate will expire on 2011-12-21. The test will still
273 // pass if error == ERR_CERT_DATE_INVALID.
274 // This test is DISABLED because it appears that we cannot do
275 // certificate revocation checking when running all of the net unit tests.
276 // This test passes when run individually, but when run with all of the net
277 // unit tests, the call to PKIXVerifyCert returns the NSS error -8180, which is
278 // SEC_ERROR_REVOKED_CERTIFICATE. This indicates a lack of revocation
279 // status, i.e. that the revocation check is failing for some reason.
280 TEST_F(CertVerifyProcTest
, DISABLED_GlobalSignR3EVTest
) {
281 base::FilePath certs_dir
= GetTestCertsDirectory();
283 scoped_refptr
<X509Certificate
> server_cert
=
284 ImportCertFromFile(certs_dir
, "2029_globalsign_com_cert.pem");
285 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), server_cert
.get());
287 scoped_refptr
<X509Certificate
> intermediate_cert
=
288 ImportCertFromFile(certs_dir
, "globalsign_ev_sha256_ca_cert.pem");
289 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), intermediate_cert
.get());
291 X509Certificate::OSCertHandles intermediates
;
292 intermediates
.push_back(intermediate_cert
->os_cert_handle());
293 scoped_refptr
<X509Certificate
> cert_chain
=
294 X509Certificate::CreateFromHandle(server_cert
->os_cert_handle(),
297 CertVerifyResult verify_result
;
298 int flags
= CertVerifier::VERIFY_REV_CHECKING_ENABLED
|
299 CertVerifier::VERIFY_EV_CERT
;
300 int error
= Verify(cert_chain
.get(),
301 "2029.globalsign.com",
307 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_IS_EV
);
309 EXPECT_EQ(ERR_CERT_DATE_INVALID
, error
);
312 // Test that verifying an ECDSA certificate doesn't crash on XP. (See
313 // crbug.com/144466).
314 TEST_F(CertVerifyProcTest
, ECDSA_RSA
) {
315 base::FilePath certs_dir
= GetTestCertsDirectory();
317 scoped_refptr
<X509Certificate
> cert
=
318 ImportCertFromFile(certs_dir
,
319 "prime256v1-ecdsa-ee-by-1024-rsa-intermediate.pem");
321 CertVerifyResult verify_result
;
322 Verify(cert
.get(), "127.0.0.1", 0, NULL
, empty_cert_list_
, &verify_result
);
324 // We don't check verify_result because the certificate is signed by an
325 // unknown CA and will be considered invalid on XP because of the ECDSA
329 // Currently, only RSA and DSA keys are checked for weakness, and our example
330 // weak size is 768. These could change in the future.
332 // Note that this means there may be false negatives: keys for other
333 // algorithms and which are weak will pass this test.
334 static bool IsWeakKeyType(const std::string
& key_type
) {
335 size_t pos
= key_type
.find("-");
336 std::string size
= key_type
.substr(0, pos
);
337 std::string type
= key_type
.substr(pos
+ 1);
339 if (type
== "rsa" || type
== "dsa")
340 return size
== "768";
345 TEST_F(CertVerifyProcTest
, RejectWeakKeys
) {
346 base::FilePath certs_dir
= GetTestCertsDirectory();
347 typedef std::vector
<std::string
> Strings
;
350 // generate-weak-test-chains.sh currently has:
351 // key_types="768-rsa 1024-rsa 2048-rsa prime256v1-ecdsa"
352 // We must use the same key types here. The filenames generated look like:
353 // 2048-rsa-ee-by-768-rsa-intermediate.pem
354 key_types
.push_back("768-rsa");
355 key_types
.push_back("1024-rsa");
356 key_types
.push_back("2048-rsa");
358 bool use_ecdsa
= true;
360 use_ecdsa
= base::win::GetVersion() > base::win::VERSION_XP
;
364 key_types
.push_back("prime256v1-ecdsa");
366 // Add the root that signed the intermediates for this test.
367 scoped_refptr
<X509Certificate
> root_cert
=
368 ImportCertFromFile(certs_dir
, "2048-rsa-root.pem");
369 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), root_cert
.get());
370 ScopedTestRoot
scoped_root(root_cert
.get());
372 // Now test each chain.
373 for (Strings::const_iterator ee_type
= key_types
.begin();
374 ee_type
!= key_types
.end(); ++ee_type
) {
375 for (Strings::const_iterator signer_type
= key_types
.begin();
376 signer_type
!= key_types
.end(); ++signer_type
) {
377 std::string basename
= *ee_type
+ "-ee-by-" + *signer_type
+
379 SCOPED_TRACE(basename
);
380 scoped_refptr
<X509Certificate
> ee_cert
=
381 ImportCertFromFile(certs_dir
, basename
);
382 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), ee_cert
.get());
384 basename
= *signer_type
+ "-intermediate.pem";
385 scoped_refptr
<X509Certificate
> intermediate
=
386 ImportCertFromFile(certs_dir
, basename
);
387 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), intermediate
.get());
389 X509Certificate::OSCertHandles intermediates
;
390 intermediates
.push_back(intermediate
->os_cert_handle());
391 scoped_refptr
<X509Certificate
> cert_chain
=
392 X509Certificate::CreateFromHandle(ee_cert
->os_cert_handle(),
395 CertVerifyResult verify_result
;
396 int error
= Verify(cert_chain
.get(),
403 if (IsWeakKeyType(*ee_type
) || IsWeakKeyType(*signer_type
)) {
404 EXPECT_NE(OK
, error
);
405 EXPECT_EQ(CERT_STATUS_WEAK_KEY
,
406 verify_result
.cert_status
& CERT_STATUS_WEAK_KEY
);
407 EXPECT_NE(CERT_STATUS_INVALID
,
408 verify_result
.cert_status
& CERT_STATUS_INVALID
);
410 EXPECT_EQ(OK
, error
);
411 EXPECT_EQ(0U, verify_result
.cert_status
& CERT_STATUS_WEAK_KEY
);
417 // Regression test for http://crbug.com/108514.
418 #if defined(OS_MACOSX) && !defined(OS_IOS)
419 // Disabled on OS X - Security.framework doesn't ignore superflous certificates
420 // provided by servers. See CertVerifyProcTest.CybertrustGTERoot for further
422 #define MAYBE_ExtraneousMD5RootCert DISABLED_ExtraneousMD5RootCert
424 #define MAYBE_ExtraneousMD5RootCert ExtraneousMD5RootCert
426 TEST_F(CertVerifyProcTest
, MAYBE_ExtraneousMD5RootCert
) {
427 if (!SupportsReturningVerifiedChain()) {
428 LOG(INFO
) << "Skipping this test in this platform.";
432 base::FilePath certs_dir
= GetTestCertsDirectory();
434 scoped_refptr
<X509Certificate
> server_cert
=
435 ImportCertFromFile(certs_dir
, "cross-signed-leaf.pem");
436 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), server_cert
.get());
438 scoped_refptr
<X509Certificate
> extra_cert
=
439 ImportCertFromFile(certs_dir
, "cross-signed-root-md5.pem");
440 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), extra_cert
.get());
442 scoped_refptr
<X509Certificate
> root_cert
=
443 ImportCertFromFile(certs_dir
, "cross-signed-root-sha256.pem");
444 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), root_cert
.get());
446 ScopedTestRoot
scoped_root(root_cert
.get());
448 X509Certificate::OSCertHandles intermediates
;
449 intermediates
.push_back(extra_cert
->os_cert_handle());
450 scoped_refptr
<X509Certificate
> cert_chain
=
451 X509Certificate::CreateFromHandle(server_cert
->os_cert_handle(),
454 CertVerifyResult verify_result
;
456 int error
= Verify(cert_chain
.get(),
462 EXPECT_EQ(OK
, error
);
464 // The extra MD5 root should be discarded
465 ASSERT_TRUE(verify_result
.verified_cert
.get());
467 verify_result
.verified_cert
->GetIntermediateCertificates().size());
468 EXPECT_TRUE(X509Certificate::IsSameOSCert(
469 verify_result
.verified_cert
->GetIntermediateCertificates().front(),
470 root_cert
->os_cert_handle()));
472 EXPECT_FALSE(verify_result
.has_md5
);
475 // Test for bug 94673.
476 TEST_F(CertVerifyProcTest
, GoogleDigiNotarTest
) {
477 base::FilePath certs_dir
= GetTestCertsDirectory();
479 scoped_refptr
<X509Certificate
> server_cert
=
480 ImportCertFromFile(certs_dir
, "google_diginotar.pem");
481 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), server_cert
.get());
483 scoped_refptr
<X509Certificate
> intermediate_cert
=
484 ImportCertFromFile(certs_dir
, "diginotar_public_ca_2025.pem");
485 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), intermediate_cert
.get());
487 X509Certificate::OSCertHandles intermediates
;
488 intermediates
.push_back(intermediate_cert
->os_cert_handle());
489 scoped_refptr
<X509Certificate
> cert_chain
=
490 X509Certificate::CreateFromHandle(server_cert
->os_cert_handle(),
493 CertVerifyResult verify_result
;
494 int flags
= CertVerifier::VERIFY_REV_CHECKING_ENABLED
;
495 int error
= Verify(cert_chain
.get(),
501 EXPECT_NE(OK
, error
);
503 // Now turn off revocation checking. Certificate verification should still
506 error
= Verify(cert_chain
.get(),
512 EXPECT_NE(OK
, error
);
515 TEST_F(CertVerifyProcTest
, DigiNotarCerts
) {
516 static const char* const kDigiNotarFilenames
[] = {
517 "diginotar_root_ca.pem",
518 "diginotar_cyber_ca.pem",
519 "diginotar_services_1024_ca.pem",
520 "diginotar_pkioverheid.pem",
521 "diginotar_pkioverheid_g2.pem",
525 base::FilePath certs_dir
= GetTestCertsDirectory();
527 for (size_t i
= 0; kDigiNotarFilenames
[i
]; i
++) {
528 scoped_refptr
<X509Certificate
> diginotar_cert
=
529 ImportCertFromFile(certs_dir
, kDigiNotarFilenames
[i
]);
530 std::string der_bytes
;
531 ASSERT_TRUE(X509Certificate::GetDEREncoded(
532 diginotar_cert
->os_cert_handle(), &der_bytes
));
534 base::StringPiece spki
;
535 ASSERT_TRUE(asn1::ExtractSPKIFromDERCert(der_bytes
, &spki
));
537 std::string spki_sha1
= base::SHA1HashString(spki
.as_string());
539 HashValueVector public_keys
;
540 HashValue
hash(HASH_VALUE_SHA1
);
541 ASSERT_EQ(hash
.size(), spki_sha1
.size());
542 memcpy(hash
.data(), spki_sha1
.data(), spki_sha1
.size());
543 public_keys
.push_back(hash
);
545 EXPECT_TRUE(CertVerifyProc::IsPublicKeyBlacklisted(public_keys
)) <<
546 "Public key not blocked for " << kDigiNotarFilenames
[i
];
550 TEST_F(CertVerifyProcTest
, NameConstraintsOk
) {
551 CertificateList ca_cert_list
=
552 CreateCertificateListFromFile(GetTestCertsDirectory(),
554 X509Certificate::FORMAT_AUTO
);
555 ASSERT_EQ(1U, ca_cert_list
.size());
556 ScopedTestRoot
test_root(ca_cert_list
[0].get());
558 CertificateList cert_list
= CreateCertificateListFromFile(
559 GetTestCertsDirectory(), "name_constraint_good.pem",
560 X509Certificate::FORMAT_AUTO
);
561 ASSERT_EQ(1U, cert_list
.size());
563 X509Certificate::OSCertHandles intermediates
;
564 scoped_refptr
<X509Certificate
> leaf
=
565 X509Certificate::CreateFromHandle(cert_list
[0]->os_cert_handle(),
569 CertVerifyResult verify_result
;
570 int error
= Verify(leaf
.get(),
576 EXPECT_EQ(OK
, error
);
577 EXPECT_EQ(0U, verify_result
.cert_status
);
580 TEST_F(CertVerifyProcTest
, NameConstraintsFailure
) {
581 if (!SupportsReturningVerifiedChain()) {
582 LOG(INFO
) << "Skipping this test in this platform.";
586 CertificateList ca_cert_list
=
587 CreateCertificateListFromFile(GetTestCertsDirectory(),
589 X509Certificate::FORMAT_AUTO
);
590 ASSERT_EQ(1U, ca_cert_list
.size());
591 ScopedTestRoot
test_root(ca_cert_list
[0].get());
593 CertificateList cert_list
= CreateCertificateListFromFile(
594 GetTestCertsDirectory(), "name_constraint_bad.pem",
595 X509Certificate::FORMAT_AUTO
);
596 ASSERT_EQ(1U, cert_list
.size());
598 X509Certificate::OSCertHandles intermediates
;
599 scoped_refptr
<X509Certificate
> leaf
=
600 X509Certificate::CreateFromHandle(cert_list
[0]->os_cert_handle(),
604 CertVerifyResult verify_result
;
605 int error
= Verify(leaf
.get(),
611 EXPECT_EQ(ERR_CERT_NAME_CONSTRAINT_VIOLATION
, error
);
612 EXPECT_EQ(CERT_STATUS_NAME_CONSTRAINT_VIOLATION
,
613 verify_result
.cert_status
& CERT_STATUS_NAME_CONSTRAINT_VIOLATION
);
616 TEST_F(CertVerifyProcTest
, TestHasTooLongValidity
) {
618 const char* const file
;
619 bool is_valid_too_long
;
621 {"twitter-chain.pem", false},
622 {"start_after_expiry.pem", true},
623 {"pre_br_validity_ok.pem", false},
624 {"pre_br_validity_bad_121.pem", true},
625 {"pre_br_validity_bad_2020.pem", true},
626 {"10_year_validity.pem", false},
627 {"11_year_validity.pem", true},
628 {"39_months_after_2015_04.pem", false},
629 {"40_months_after_2015_04.pem", true},
630 {"60_months_after_2012_07.pem", false},
631 {"61_months_after_2012_07.pem", true},
634 base::FilePath certs_dir
= GetTestCertsDirectory();
636 for (size_t i
= 0; i
< arraysize(tests
); ++i
) {
637 scoped_refptr
<X509Certificate
> certificate
=
638 ImportCertFromFile(certs_dir
, tests
[i
].file
);
639 SCOPED_TRACE(tests
[i
].file
);
640 ASSERT_TRUE(certificate
);
641 EXPECT_EQ(tests
[i
].is_valid_too_long
,
642 CertVerifyProc::HasTooLongValidity(*certificate
));
646 TEST_F(CertVerifyProcTest
, TestKnownRoot
) {
647 if (!SupportsDetectingKnownRoots()) {
648 LOG(INFO
) << "Skipping this test on this platform.";
652 base::FilePath certs_dir
= GetTestCertsDirectory();
653 CertificateList certs
= CreateCertificateListFromFile(
654 certs_dir
, "twitter-chain.pem", X509Certificate::FORMAT_AUTO
);
655 ASSERT_EQ(3U, certs
.size());
657 X509Certificate::OSCertHandles intermediates
;
658 intermediates
.push_back(certs
[1]->os_cert_handle());
660 scoped_refptr
<X509Certificate
> cert_chain
=
661 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
665 CertVerifyResult verify_result
;
666 // This will blow up, May 9th, 2016. Sorry! Please disable and file a bug
667 // against agl. See also PublicKeyHashes.
668 int error
= Verify(cert_chain
.get(), "twitter.com", flags
, NULL
,
669 empty_cert_list_
, &verify_result
);
670 EXPECT_EQ(OK
, error
);
671 EXPECT_TRUE(verify_result
.is_issued_by_known_root
);
674 TEST_F(CertVerifyProcTest
, PublicKeyHashes
) {
675 if (!SupportsReturningVerifiedChain()) {
676 LOG(INFO
) << "Skipping this test in this platform.";
680 base::FilePath certs_dir
= GetTestCertsDirectory();
681 CertificateList certs
= CreateCertificateListFromFile(
682 certs_dir
, "twitter-chain.pem", X509Certificate::FORMAT_AUTO
);
683 ASSERT_EQ(3U, certs
.size());
685 X509Certificate::OSCertHandles intermediates
;
686 intermediates
.push_back(certs
[1]->os_cert_handle());
688 scoped_refptr
<X509Certificate
> cert_chain
=
689 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
692 CertVerifyResult verify_result
;
694 // This will blow up, May 9th, 2016. Sorry! Please disable and file a bug
695 // against agl. See also TestKnownRoot.
696 int error
= Verify(cert_chain
.get(), "twitter.com", flags
, NULL
,
697 empty_cert_list_
, &verify_result
);
698 EXPECT_EQ(OK
, error
);
699 ASSERT_LE(3U, verify_result
.public_key_hashes
.size());
701 HashValueVector sha1_hashes
;
702 for (size_t i
= 0; i
< verify_result
.public_key_hashes
.size(); ++i
) {
703 if (verify_result
.public_key_hashes
[i
].tag
!= HASH_VALUE_SHA1
)
705 sha1_hashes
.push_back(verify_result
.public_key_hashes
[i
]);
707 ASSERT_LE(3u, sha1_hashes
.size());
709 for (size_t i
= 0; i
< 3; ++i
) {
710 EXPECT_EQ(HexEncode(kTwitterSPKIs
[i
], base::kSHA1Length
),
711 HexEncode(sha1_hashes
[i
].data(), base::kSHA1Length
));
714 HashValueVector sha256_hashes
;
715 for (size_t i
= 0; i
< verify_result
.public_key_hashes
.size(); ++i
) {
716 if (verify_result
.public_key_hashes
[i
].tag
!= HASH_VALUE_SHA256
)
718 sha256_hashes
.push_back(verify_result
.public_key_hashes
[i
]);
720 ASSERT_LE(3u, sha256_hashes
.size());
722 for (size_t i
= 0; i
< 3; ++i
) {
723 EXPECT_EQ(HexEncode(kTwitterSPKIsSHA256
[i
], crypto::kSHA256Length
),
724 HexEncode(sha256_hashes
[i
].data(), crypto::kSHA256Length
));
728 // A regression test for http://crbug.com/70293.
729 // The Key Usage extension in this RSA SSL server certificate does not have
730 // the keyEncipherment bit.
731 TEST_F(CertVerifyProcTest
, InvalidKeyUsage
) {
732 base::FilePath certs_dir
= GetTestCertsDirectory();
734 scoped_refptr
<X509Certificate
> server_cert
=
735 ImportCertFromFile(certs_dir
, "invalid_key_usage_cert.der");
736 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), server_cert
.get());
739 CertVerifyResult verify_result
;
740 int error
= Verify(server_cert
.get(),
746 #if defined(USE_OPENSSL_CERTS) && !defined(OS_ANDROID)
747 // This certificate has two errors: "invalid key usage" and "untrusted CA".
748 // However, OpenSSL returns only one (the latter), and we can't detect
750 EXPECT_EQ(ERR_CERT_AUTHORITY_INVALID
, error
);
752 EXPECT_EQ(ERR_CERT_INVALID
, error
);
753 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_INVALID
);
755 // TODO(wtc): fix http://crbug.com/75520 to get all the certificate errors
757 #if !defined(USE_NSS_CERTS) && !defined(OS_IOS) && !defined(OS_ANDROID)
758 // The certificate is issued by an unknown CA.
759 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_AUTHORITY_INVALID
);
763 // Basic test for returning the chain in CertVerifyResult. Note that the
764 // returned chain may just be a reflection of the originally supplied chain;
765 // that is, if any errors occur, the default chain returned is an exact copy
766 // of the certificate to be verified. The remaining VerifyReturn* tests are
767 // used to ensure that the actual, verified chain is being returned by
769 TEST_F(CertVerifyProcTest
, VerifyReturnChainBasic
) {
770 if (!SupportsReturningVerifiedChain()) {
771 LOG(INFO
) << "Skipping this test in this platform.";
775 base::FilePath certs_dir
= GetTestCertsDirectory();
776 CertificateList certs
= CreateCertificateListFromFile(
777 certs_dir
, "x509_verify_results.chain.pem",
778 X509Certificate::FORMAT_AUTO
);
779 ASSERT_EQ(3U, certs
.size());
781 X509Certificate::OSCertHandles intermediates
;
782 intermediates
.push_back(certs
[1]->os_cert_handle());
783 intermediates
.push_back(certs
[2]->os_cert_handle());
785 ScopedTestRoot
scoped_root(certs
[2].get());
787 scoped_refptr
<X509Certificate
> google_full_chain
=
788 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
790 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), google_full_chain
.get());
791 ASSERT_EQ(2U, google_full_chain
->GetIntermediateCertificates().size());
793 CertVerifyResult verify_result
;
794 EXPECT_EQ(static_cast<X509Certificate
*>(NULL
),
795 verify_result
.verified_cert
.get());
796 int error
= Verify(google_full_chain
.get(),
802 EXPECT_EQ(OK
, error
);
803 ASSERT_NE(static_cast<X509Certificate
*>(NULL
),
804 verify_result
.verified_cert
.get());
806 EXPECT_NE(google_full_chain
, verify_result
.verified_cert
);
807 EXPECT_TRUE(X509Certificate::IsSameOSCert(
808 google_full_chain
->os_cert_handle(),
809 verify_result
.verified_cert
->os_cert_handle()));
810 const X509Certificate::OSCertHandles
& return_intermediates
=
811 verify_result
.verified_cert
->GetIntermediateCertificates();
812 ASSERT_EQ(2U, return_intermediates
.size());
813 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[0],
814 certs
[1]->os_cert_handle()));
815 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[1],
816 certs
[2]->os_cert_handle()));
819 // Test that certificates issued for 'intranet' names (that is, containing no
820 // known public registry controlled domain information) issued by well-known
821 // CAs are flagged appropriately, while certificates that are issued by
822 // internal CAs are not flagged.
823 TEST_F(CertVerifyProcTest
, IntranetHostsRejected
) {
824 if (!SupportsDetectingKnownRoots()) {
825 LOG(INFO
) << "Skipping this test in this platform.";
829 CertificateList cert_list
= CreateCertificateListFromFile(
830 GetTestCertsDirectory(), "reject_intranet_hosts.pem",
831 X509Certificate::FORMAT_AUTO
);
832 ASSERT_EQ(1U, cert_list
.size());
833 scoped_refptr
<X509Certificate
> cert(cert_list
[0]);
835 CertVerifyResult verify_result
;
838 // Intranet names for public CAs should be flagged:
839 verify_proc_
= new WellKnownCaCertVerifyProc(true);
841 Verify(cert
.get(), "intranet", 0, NULL
, empty_cert_list_
, &verify_result
);
842 EXPECT_EQ(OK
, error
);
843 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_NON_UNIQUE_NAME
);
845 // However, if the CA is not well known, these should not be flagged:
846 verify_proc_
= new WellKnownCaCertVerifyProc(false);
848 Verify(cert
.get(), "intranet", 0, NULL
, empty_cert_list_
, &verify_result
);
849 EXPECT_EQ(OK
, error
);
850 EXPECT_FALSE(verify_result
.cert_status
& CERT_STATUS_NON_UNIQUE_NAME
);
853 // Test that the certificate returned in CertVerifyResult is able to reorder
854 // certificates that are not ordered from end-entity to root. While this is
855 // a protocol violation if sent during a TLS handshake, if multiple sources
856 // of intermediate certificates are combined, it's possible that order may
857 // not be maintained.
858 TEST_F(CertVerifyProcTest
, VerifyReturnChainProperlyOrdered
) {
859 if (!SupportsReturningVerifiedChain()) {
860 LOG(INFO
) << "Skipping this test in this platform.";
864 base::FilePath certs_dir
= GetTestCertsDirectory();
865 CertificateList certs
= CreateCertificateListFromFile(
866 certs_dir
, "x509_verify_results.chain.pem",
867 X509Certificate::FORMAT_AUTO
);
868 ASSERT_EQ(3U, certs
.size());
870 // Construct the chain out of order.
871 X509Certificate::OSCertHandles intermediates
;
872 intermediates
.push_back(certs
[2]->os_cert_handle());
873 intermediates
.push_back(certs
[1]->os_cert_handle());
875 ScopedTestRoot
scoped_root(certs
[2].get());
877 scoped_refptr
<X509Certificate
> google_full_chain
=
878 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
880 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), google_full_chain
.get());
881 ASSERT_EQ(2U, google_full_chain
->GetIntermediateCertificates().size());
883 CertVerifyResult verify_result
;
884 EXPECT_EQ(static_cast<X509Certificate
*>(NULL
),
885 verify_result
.verified_cert
.get());
886 int error
= Verify(google_full_chain
.get(),
892 EXPECT_EQ(OK
, error
);
893 ASSERT_NE(static_cast<X509Certificate
*>(NULL
),
894 verify_result
.verified_cert
.get());
896 EXPECT_NE(google_full_chain
, verify_result
.verified_cert
);
897 EXPECT_TRUE(X509Certificate::IsSameOSCert(
898 google_full_chain
->os_cert_handle(),
899 verify_result
.verified_cert
->os_cert_handle()));
900 const X509Certificate::OSCertHandles
& return_intermediates
=
901 verify_result
.verified_cert
->GetIntermediateCertificates();
902 ASSERT_EQ(2U, return_intermediates
.size());
903 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[0],
904 certs
[1]->os_cert_handle()));
905 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[1],
906 certs
[2]->os_cert_handle()));
909 // Test that Verify() filters out certificates which are not related to
910 // or part of the certificate chain being verified.
911 TEST_F(CertVerifyProcTest
, VerifyReturnChainFiltersUnrelatedCerts
) {
912 if (!SupportsReturningVerifiedChain()) {
913 LOG(INFO
) << "Skipping this test in this platform.";
917 base::FilePath certs_dir
= GetTestCertsDirectory();
918 CertificateList certs
= CreateCertificateListFromFile(
919 certs_dir
, "x509_verify_results.chain.pem",
920 X509Certificate::FORMAT_AUTO
);
921 ASSERT_EQ(3U, certs
.size());
922 ScopedTestRoot
scoped_root(certs
[2].get());
924 scoped_refptr
<X509Certificate
> unrelated_certificate
=
925 ImportCertFromFile(certs_dir
, "duplicate_cn_1.pem");
926 scoped_refptr
<X509Certificate
> unrelated_certificate2
=
927 ImportCertFromFile(certs_dir
, "aia-cert.pem");
928 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), unrelated_certificate
.get());
929 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), unrelated_certificate2
.get());
931 // Interject unrelated certificates into the list of intermediates.
932 X509Certificate::OSCertHandles intermediates
;
933 intermediates
.push_back(unrelated_certificate
->os_cert_handle());
934 intermediates
.push_back(certs
[1]->os_cert_handle());
935 intermediates
.push_back(unrelated_certificate2
->os_cert_handle());
936 intermediates
.push_back(certs
[2]->os_cert_handle());
938 scoped_refptr
<X509Certificate
> google_full_chain
=
939 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
941 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), google_full_chain
.get());
942 ASSERT_EQ(4U, google_full_chain
->GetIntermediateCertificates().size());
944 CertVerifyResult verify_result
;
945 EXPECT_EQ(static_cast<X509Certificate
*>(NULL
),
946 verify_result
.verified_cert
.get());
947 int error
= Verify(google_full_chain
.get(),
953 EXPECT_EQ(OK
, error
);
954 ASSERT_NE(static_cast<X509Certificate
*>(NULL
),
955 verify_result
.verified_cert
.get());
957 EXPECT_NE(google_full_chain
, verify_result
.verified_cert
);
958 EXPECT_TRUE(X509Certificate::IsSameOSCert(
959 google_full_chain
->os_cert_handle(),
960 verify_result
.verified_cert
->os_cert_handle()));
961 const X509Certificate::OSCertHandles
& return_intermediates
=
962 verify_result
.verified_cert
->GetIntermediateCertificates();
963 ASSERT_EQ(2U, return_intermediates
.size());
964 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[0],
965 certs
[1]->os_cert_handle()));
966 EXPECT_TRUE(X509Certificate::IsSameOSCert(return_intermediates
[1],
967 certs
[2]->os_cert_handle()));
970 TEST_F(CertVerifyProcTest
, AdditionalTrustAnchors
) {
971 if (!SupportsAdditionalTrustAnchors()) {
972 LOG(INFO
) << "Skipping this test in this platform.";
976 // |ca_cert| is the issuer of |cert|.
977 CertificateList ca_cert_list
= CreateCertificateListFromFile(
978 GetTestCertsDirectory(), "root_ca_cert.pem",
979 X509Certificate::FORMAT_AUTO
);
980 ASSERT_EQ(1U, ca_cert_list
.size());
981 scoped_refptr
<X509Certificate
> ca_cert(ca_cert_list
[0]);
983 CertificateList cert_list
= CreateCertificateListFromFile(
984 GetTestCertsDirectory(), "ok_cert.pem",
985 X509Certificate::FORMAT_AUTO
);
986 ASSERT_EQ(1U, cert_list
.size());
987 scoped_refptr
<X509Certificate
> cert(cert_list
[0]);
989 // Verification of |cert| fails when |ca_cert| is not in the trust anchors
992 CertVerifyResult verify_result
;
994 cert
.get(), "127.0.0.1", flags
, NULL
, empty_cert_list_
, &verify_result
);
995 EXPECT_EQ(ERR_CERT_AUTHORITY_INVALID
, error
);
996 EXPECT_EQ(CERT_STATUS_AUTHORITY_INVALID
, verify_result
.cert_status
);
997 EXPECT_FALSE(verify_result
.is_issued_by_additional_trust_anchor
);
999 // Now add the |ca_cert| to the |trust_anchors|, and verification should pass.
1000 CertificateList trust_anchors
;
1001 trust_anchors
.push_back(ca_cert
);
1003 cert
.get(), "127.0.0.1", flags
, NULL
, trust_anchors
, &verify_result
);
1004 EXPECT_EQ(OK
, error
);
1005 EXPECT_EQ(0U, verify_result
.cert_status
);
1006 EXPECT_TRUE(verify_result
.is_issued_by_additional_trust_anchor
);
1008 // Clearing the |trust_anchors| makes verification fail again (the cache
1009 // should be skipped).
1011 cert
.get(), "127.0.0.1", flags
, NULL
, empty_cert_list_
, &verify_result
);
1012 EXPECT_EQ(ERR_CERT_AUTHORITY_INVALID
, error
);
1013 EXPECT_EQ(CERT_STATUS_AUTHORITY_INVALID
, verify_result
.cert_status
);
1014 EXPECT_FALSE(verify_result
.is_issued_by_additional_trust_anchor
);
1017 // Tests that certificates issued by user-supplied roots are not flagged as
1018 // issued by a known root. This should pass whether or not the platform supports
1019 // detecting known roots.
1020 TEST_F(CertVerifyProcTest
, IsIssuedByKnownRootIgnoresTestRoots
) {
1021 // Load root_ca_cert.pem into the test root store.
1022 ScopedTestRoot
test_root(
1023 ImportCertFromFile(GetTestCertsDirectory(), "root_ca_cert.pem").get());
1025 scoped_refptr
<X509Certificate
> cert(
1026 ImportCertFromFile(GetTestCertsDirectory(), "ok_cert.pem"));
1028 // Verification should pass.
1030 CertVerifyResult verify_result
;
1032 cert
.get(), "127.0.0.1", flags
, NULL
, empty_cert_list_
, &verify_result
);
1033 EXPECT_EQ(OK
, error
);
1034 EXPECT_EQ(0U, verify_result
.cert_status
);
1035 // But should not be marked as a known root.
1036 EXPECT_FALSE(verify_result
.is_issued_by_known_root
);
1039 #if defined(OS_MACOSX) && !defined(OS_IOS)
1040 // Tests that, on OS X, issues with a cross-certified Baltimore CyberTrust
1041 // Root can be successfully worked around once Apple completes removing the
1042 // older GTE CyberTrust Root from its trusted root store.
1044 // The issue is caused by servers supplying the cross-certified intermediate
1045 // (necessary for certain mobile platforms), which OS X does not recognize
1046 // as already existing within its trust store.
1047 TEST_F(CertVerifyProcTest
, CybertrustGTERoot
) {
1048 CertificateList certs
= CreateCertificateListFromFile(
1049 GetTestCertsDirectory(),
1050 "cybertrust_omniroot_chain.pem",
1051 X509Certificate::FORMAT_PEM_CERT_SEQUENCE
);
1052 ASSERT_EQ(2U, certs
.size());
1054 X509Certificate::OSCertHandles intermediates
;
1055 intermediates
.push_back(certs
[1]->os_cert_handle());
1057 scoped_refptr
<X509Certificate
> cybertrust_basic
=
1058 X509Certificate::CreateFromHandle(certs
[0]->os_cert_handle(),
1060 ASSERT_TRUE(cybertrust_basic
.get());
1062 scoped_refptr
<X509Certificate
> baltimore_root
=
1063 ImportCertFromFile(GetTestCertsDirectory(),
1064 "cybertrust_baltimore_root.pem");
1065 ASSERT_TRUE(baltimore_root
.get());
1067 ScopedTestRoot
scoped_root(baltimore_root
.get());
1069 // Ensure that ONLY the Baltimore CyberTrust Root is trusted. This
1070 // simulates Keychain removing support for the GTE CyberTrust Root.
1071 TestRootCerts::GetInstance()->SetAllowSystemTrust(false);
1072 base::ScopedClosureRunner
reset_system_trust(
1073 base::Bind(&TestRootCerts::SetAllowSystemTrust
,
1074 base::Unretained(TestRootCerts::GetInstance()),
1077 // First, make sure a simple certificate chain from
1078 // EE -> Public SureServer SV -> Baltimore CyberTrust
1079 // works. Only the first two certificates are included in the chain.
1081 CertVerifyResult verify_result
;
1082 int error
= Verify(cybertrust_basic
.get(),
1083 "cacert.omniroot.com",
1088 EXPECT_EQ(OK
, error
);
1089 EXPECT_EQ(CERT_STATUS_SHA1_SIGNATURE_PRESENT
, verify_result
.cert_status
);
1091 // Attempt to verify with the first known cross-certified intermediate
1093 scoped_refptr
<X509Certificate
> baltimore_intermediate_1
=
1094 ImportCertFromFile(GetTestCertsDirectory(),
1095 "cybertrust_baltimore_cross_certified_1.pem");
1096 ASSERT_TRUE(baltimore_intermediate_1
.get());
1098 X509Certificate::OSCertHandles intermediate_chain_1
=
1099 cybertrust_basic
->GetIntermediateCertificates();
1100 intermediate_chain_1
.push_back(baltimore_intermediate_1
->os_cert_handle());
1102 scoped_refptr
<X509Certificate
> baltimore_chain_1
=
1103 X509Certificate::CreateFromHandle(cybertrust_basic
->os_cert_handle(),
1104 intermediate_chain_1
);
1105 error
= Verify(baltimore_chain_1
.get(),
1106 "cacert.omniroot.com",
1111 EXPECT_EQ(OK
, error
);
1112 EXPECT_EQ(CERT_STATUS_SHA1_SIGNATURE_PRESENT
, verify_result
.cert_status
);
1114 // Attempt to verify with the second known cross-certified intermediate
1116 scoped_refptr
<X509Certificate
> baltimore_intermediate_2
=
1117 ImportCertFromFile(GetTestCertsDirectory(),
1118 "cybertrust_baltimore_cross_certified_2.pem");
1119 ASSERT_TRUE(baltimore_intermediate_2
.get());
1121 X509Certificate::OSCertHandles intermediate_chain_2
=
1122 cybertrust_basic
->GetIntermediateCertificates();
1123 intermediate_chain_2
.push_back(baltimore_intermediate_2
->os_cert_handle());
1125 scoped_refptr
<X509Certificate
> baltimore_chain_2
=
1126 X509Certificate::CreateFromHandle(cybertrust_basic
->os_cert_handle(),
1127 intermediate_chain_2
);
1128 error
= Verify(baltimore_chain_2
.get(),
1129 "cacert.omniroot.com",
1134 EXPECT_EQ(OK
, error
);
1135 EXPECT_EQ(CERT_STATUS_SHA1_SIGNATURE_PRESENT
, verify_result
.cert_status
);
1137 // Attempt to verify when both a cross-certified intermediate AND
1138 // the legacy GTE root are provided.
1139 scoped_refptr
<X509Certificate
> cybertrust_root
=
1140 ImportCertFromFile(GetTestCertsDirectory(),
1141 "cybertrust_gte_root.pem");
1142 ASSERT_TRUE(cybertrust_root
.get());
1144 intermediate_chain_2
.push_back(cybertrust_root
->os_cert_handle());
1145 scoped_refptr
<X509Certificate
> baltimore_chain_with_root
=
1146 X509Certificate::CreateFromHandle(cybertrust_basic
->os_cert_handle(),
1147 intermediate_chain_2
);
1148 error
= Verify(baltimore_chain_with_root
.get(),
1149 "cacert.omniroot.com",
1154 EXPECT_EQ(OK
, error
);
1155 EXPECT_EQ(CERT_STATUS_SHA1_SIGNATURE_PRESENT
, verify_result
.cert_status
);
1157 TestRootCerts::GetInstance()->Clear();
1158 EXPECT_TRUE(TestRootCerts::GetInstance()->IsEmpty());
1162 #if defined(USE_NSS_CERTS) || defined(OS_IOS) || defined(OS_WIN) || \
1164 // Test that CRLSets are effective in making a certificate appear to be
1166 TEST_F(CertVerifyProcTest
, CRLSet
) {
1167 CertificateList ca_cert_list
=
1168 CreateCertificateListFromFile(GetTestCertsDirectory(),
1170 X509Certificate::FORMAT_AUTO
);
1171 ASSERT_EQ(1U, ca_cert_list
.size());
1172 ScopedTestRoot
test_root(ca_cert_list
[0].get());
1174 CertificateList cert_list
= CreateCertificateListFromFile(
1175 GetTestCertsDirectory(), "ok_cert.pem", X509Certificate::FORMAT_AUTO
);
1176 ASSERT_EQ(1U, cert_list
.size());
1177 scoped_refptr
<X509Certificate
> cert(cert_list
[0]);
1180 CertVerifyResult verify_result
;
1182 cert
.get(), "127.0.0.1", flags
, NULL
, empty_cert_list_
, &verify_result
);
1183 EXPECT_EQ(OK
, error
);
1184 EXPECT_EQ(0U, verify_result
.cert_status
);
1186 scoped_refptr
<CRLSet
> crl_set
;
1187 std::string crl_set_bytes
;
1189 // First test blocking by SPKI.
1190 EXPECT_TRUE(base::ReadFileToString(
1191 GetTestCertsDirectory().AppendASCII("crlset_by_leaf_spki.raw"),
1193 ASSERT_TRUE(CRLSetStorage::Parse(crl_set_bytes
, &crl_set
));
1195 error
= Verify(cert
.get(),
1201 EXPECT_EQ(ERR_CERT_REVOKED
, error
);
1203 // Second, test revocation by serial number of a cert directly under the
1205 crl_set_bytes
.clear();
1206 EXPECT_TRUE(base::ReadFileToString(
1207 GetTestCertsDirectory().AppendASCII("crlset_by_root_serial.raw"),
1209 ASSERT_TRUE(CRLSetStorage::Parse(crl_set_bytes
, &crl_set
));
1211 error
= Verify(cert
.get(),
1217 EXPECT_EQ(ERR_CERT_REVOKED
, error
);
1220 TEST_F(CertVerifyProcTest
, CRLSetLeafSerial
) {
1221 CertificateList ca_cert_list
=
1222 CreateCertificateListFromFile(GetTestCertsDirectory(),
1224 X509Certificate::FORMAT_AUTO
);
1225 ASSERT_EQ(1U, ca_cert_list
.size());
1226 ScopedTestRoot
test_root(ca_cert_list
[0].get());
1228 CertificateList intermediate_cert_list
=
1229 CreateCertificateListFromFile(GetTestCertsDirectory(),
1230 "quic_intermediate.crt",
1231 X509Certificate::FORMAT_AUTO
);
1232 ASSERT_EQ(1U, intermediate_cert_list
.size());
1233 X509Certificate::OSCertHandles intermediates
;
1234 intermediates
.push_back(intermediate_cert_list
[0]->os_cert_handle());
1236 CertificateList cert_list
= CreateCertificateListFromFile(
1237 GetTestCertsDirectory(), "quic_test.example.com.crt",
1238 X509Certificate::FORMAT_AUTO
);
1239 ASSERT_EQ(1U, cert_list
.size());
1241 scoped_refptr
<X509Certificate
> leaf
=
1242 X509Certificate::CreateFromHandle(cert_list
[0]->os_cert_handle(),
1246 CertVerifyResult verify_result
;
1247 int error
= Verify(leaf
.get(),
1253 EXPECT_EQ(OK
, error
);
1254 EXPECT_EQ(CERT_STATUS_SHA1_SIGNATURE_PRESENT
, verify_result
.cert_status
);
1256 // Test revocation by serial number of a certificate not under the root.
1257 scoped_refptr
<CRLSet
> crl_set
;
1258 std::string crl_set_bytes
;
1259 ASSERT_TRUE(base::ReadFileToString(
1260 GetTestCertsDirectory().AppendASCII("crlset_by_intermediate_serial.raw"),
1262 ASSERT_TRUE(CRLSetStorage::Parse(crl_set_bytes
, &crl_set
));
1264 error
= Verify(leaf
.get(),
1270 EXPECT_EQ(ERR_CERT_REVOKED
, error
);
1274 enum ExpectedAlgorithms
{
1275 EXPECT_MD2
= 1 << 0,
1276 EXPECT_MD4
= 1 << 1,
1277 EXPECT_MD5
= 1 << 2,
1278 EXPECT_SHA1
= 1 << 3
1281 struct WeakDigestTestData
{
1282 const char* root_cert_filename
;
1283 const char* intermediate_cert_filename
;
1284 const char* ee_cert_filename
;
1285 int expected_algorithms
;
1288 // GTest 'magic' pretty-printer, so that if/when a test fails, it knows how
1289 // to output the parameter that was passed. Without this, it will simply
1290 // attempt to print out the first twenty bytes of the object, which depending
1291 // on platform and alignment, may result in an invalid read.
1292 void PrintTo(const WeakDigestTestData
& data
, std::ostream
* os
) {
1294 << (data
.root_cert_filename
? data
.root_cert_filename
: "none")
1295 << "; intermediate: " << data
.intermediate_cert_filename
1296 << "; end-entity: " << data
.ee_cert_filename
;
1299 class CertVerifyProcWeakDigestTest
1300 : public CertVerifyProcTest
,
1301 public testing::WithParamInterface
<WeakDigestTestData
> {
1303 CertVerifyProcWeakDigestTest() {}
1304 virtual ~CertVerifyProcWeakDigestTest() {}
1307 TEST_P(CertVerifyProcWeakDigestTest
, Verify
) {
1308 WeakDigestTestData data
= GetParam();
1309 base::FilePath certs_dir
= GetTestCertsDirectory();
1311 ScopedTestRoot test_root
;
1312 if (data
.root_cert_filename
) {
1313 scoped_refptr
<X509Certificate
> root_cert
=
1314 ImportCertFromFile(certs_dir
, data
.root_cert_filename
);
1315 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), root_cert
.get());
1316 test_root
.Reset(root_cert
.get());
1319 scoped_refptr
<X509Certificate
> intermediate_cert
=
1320 ImportCertFromFile(certs_dir
, data
.intermediate_cert_filename
);
1321 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), intermediate_cert
.get());
1322 scoped_refptr
<X509Certificate
> ee_cert
=
1323 ImportCertFromFile(certs_dir
, data
.ee_cert_filename
);
1324 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), ee_cert
.get());
1326 X509Certificate::OSCertHandles intermediates
;
1327 intermediates
.push_back(intermediate_cert
->os_cert_handle());
1329 scoped_refptr
<X509Certificate
> ee_chain
=
1330 X509Certificate::CreateFromHandle(ee_cert
->os_cert_handle(),
1332 ASSERT_NE(static_cast<X509Certificate
*>(NULL
), ee_chain
.get());
1335 CertVerifyResult verify_result
;
1336 int rv
= Verify(ee_chain
.get(),
1342 EXPECT_EQ(!!(data
.expected_algorithms
& EXPECT_MD2
), verify_result
.has_md2
);
1343 EXPECT_EQ(!!(data
.expected_algorithms
& EXPECT_MD4
), verify_result
.has_md4
);
1344 EXPECT_EQ(!!(data
.expected_algorithms
& EXPECT_MD5
), verify_result
.has_md5
);
1345 EXPECT_EQ(!!(data
.expected_algorithms
& EXPECT_SHA1
), verify_result
.has_sha1
);
1347 EXPECT_FALSE(verify_result
.is_issued_by_additional_trust_anchor
);
1349 // Ensure that MD4 and MD2 are tagged as invalid.
1350 if (data
.expected_algorithms
& (EXPECT_MD2
| EXPECT_MD4
)) {
1351 EXPECT_EQ(CERT_STATUS_INVALID
,
1352 verify_result
.cert_status
& CERT_STATUS_INVALID
);
1355 // Ensure that MD5 is flagged as weak.
1356 if (data
.expected_algorithms
& EXPECT_MD5
) {
1358 CERT_STATUS_WEAK_SIGNATURE_ALGORITHM
,
1359 verify_result
.cert_status
& CERT_STATUS_WEAK_SIGNATURE_ALGORITHM
);
1362 // If a root cert is present, then check that the chain was rejected if any
1363 // weak algorithms are present. This is only checked when a root cert is
1364 // present because the error reported for incomplete chains with weak
1365 // algorithms depends on which implementation was used to validate (NSS,
1366 // OpenSSL, CryptoAPI, Security.framework) and upon which weak algorithm
1367 // present (MD2, MD4, MD5).
1368 if (data
.root_cert_filename
) {
1369 if (data
.expected_algorithms
& (EXPECT_MD2
| EXPECT_MD4
)) {
1370 EXPECT_EQ(ERR_CERT_INVALID
, rv
);
1371 } else if (data
.expected_algorithms
& EXPECT_MD5
) {
1372 EXPECT_EQ(ERR_CERT_WEAK_SIGNATURE_ALGORITHM
, rv
);
1379 // Unlike TEST/TEST_F, which are macros that expand to further macros,
1380 // INSTANTIATE_TEST_CASE_P is a macro that expands directly to code that
1381 // stringizes the arguments. As a result, macros passed as parameters (such as
1382 // prefix or test_case_name) will not be expanded by the preprocessor. To work
1383 // around this, indirect the macro for INSTANTIATE_TEST_CASE_P, so that the
1384 // pre-processor will expand macros such as MAYBE_test_name before
1385 // instantiating the test.
1386 #define WRAPPED_INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \
1387 INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator)
1389 // The signature algorithm of the root CA should not matter.
1390 const WeakDigestTestData kVerifyRootCATestData
[] = {
1391 { "weak_digest_md5_root.pem", "weak_digest_sha1_intermediate.pem",
1392 "weak_digest_sha1_ee.pem", EXPECT_SHA1
},
1393 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1394 // MD4 is not supported by OS X / NSS
1395 { "weak_digest_md4_root.pem", "weak_digest_sha1_intermediate.pem",
1396 "weak_digest_sha1_ee.pem", EXPECT_SHA1
},
1398 { "weak_digest_md2_root.pem", "weak_digest_sha1_intermediate.pem",
1399 "weak_digest_sha1_ee.pem", EXPECT_SHA1
},
1401 INSTANTIATE_TEST_CASE_P(VerifyRoot
, CertVerifyProcWeakDigestTest
,
1402 testing::ValuesIn(kVerifyRootCATestData
));
1404 // The signature algorithm of intermediates should be properly detected.
1405 const WeakDigestTestData kVerifyIntermediateCATestData
[] = {
1406 { "weak_digest_sha1_root.pem", "weak_digest_md5_intermediate.pem",
1407 "weak_digest_sha1_ee.pem", EXPECT_MD5
| EXPECT_SHA1
},
1408 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1409 // MD4 is not supported by OS X / NSS
1410 { "weak_digest_sha1_root.pem", "weak_digest_md4_intermediate.pem",
1411 "weak_digest_sha1_ee.pem", EXPECT_MD4
| EXPECT_SHA1
},
1413 { "weak_digest_sha1_root.pem", "weak_digest_md2_intermediate.pem",
1414 "weak_digest_sha1_ee.pem", EXPECT_MD2
| EXPECT_SHA1
},
1416 // Disabled on NSS - MD4 is not supported, and MD2 and MD5 are disabled.
1417 #if defined(USE_NSS_CERTS) || defined(OS_IOS)
1418 #define MAYBE_VerifyIntermediate DISABLED_VerifyIntermediate
1420 #define MAYBE_VerifyIntermediate VerifyIntermediate
1422 WRAPPED_INSTANTIATE_TEST_CASE_P(
1423 MAYBE_VerifyIntermediate
,
1424 CertVerifyProcWeakDigestTest
,
1425 testing::ValuesIn(kVerifyIntermediateCATestData
));
1427 // The signature algorithm of end-entity should be properly detected.
1428 const WeakDigestTestData kVerifyEndEntityTestData
[] = {
1429 { "weak_digest_sha1_root.pem", "weak_digest_sha1_intermediate.pem",
1430 "weak_digest_md5_ee.pem", EXPECT_MD5
| EXPECT_SHA1
},
1431 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1432 // MD4 is not supported by OS X / NSS
1433 { "weak_digest_sha1_root.pem", "weak_digest_sha1_intermediate.pem",
1434 "weak_digest_md4_ee.pem", EXPECT_MD4
| EXPECT_SHA1
},
1436 { "weak_digest_sha1_root.pem", "weak_digest_sha1_intermediate.pem",
1437 "weak_digest_md2_ee.pem", EXPECT_MD2
| EXPECT_SHA1
},
1439 // Disabled on NSS - NSS caches chains/signatures in such a way that cannot
1440 // be cleared until NSS is cleanly shutdown, which is not presently supported
1442 #if defined(USE_NSS_CERTS) || defined(OS_IOS)
1443 #define MAYBE_VerifyEndEntity DISABLED_VerifyEndEntity
1445 #define MAYBE_VerifyEndEntity VerifyEndEntity
1447 WRAPPED_INSTANTIATE_TEST_CASE_P(MAYBE_VerifyEndEntity
,
1448 CertVerifyProcWeakDigestTest
,
1449 testing::ValuesIn(kVerifyEndEntityTestData
));
1451 // Incomplete chains should still report the status of the intermediate.
1452 const WeakDigestTestData kVerifyIncompleteIntermediateTestData
[] = {
1453 { NULL
, "weak_digest_md5_intermediate.pem", "weak_digest_sha1_ee.pem",
1454 EXPECT_MD5
| EXPECT_SHA1
},
1455 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1456 // MD4 is not supported by OS X / NSS
1457 { NULL
, "weak_digest_md4_intermediate.pem", "weak_digest_sha1_ee.pem",
1458 EXPECT_MD4
| EXPECT_SHA1
},
1460 { NULL
, "weak_digest_md2_intermediate.pem", "weak_digest_sha1_ee.pem",
1461 EXPECT_MD2
| EXPECT_SHA1
},
1463 // Disabled on NSS - libpkix does not return constructed chains on error,
1464 // preventing us from detecting/inspecting the verified chain.
1465 #if defined(USE_NSS_CERTS) || defined(OS_IOS)
1466 #define MAYBE_VerifyIncompleteIntermediate \
1467 DISABLED_VerifyIncompleteIntermediate
1469 #define MAYBE_VerifyIncompleteIntermediate VerifyIncompleteIntermediate
1471 WRAPPED_INSTANTIATE_TEST_CASE_P(
1472 MAYBE_VerifyIncompleteIntermediate
,
1473 CertVerifyProcWeakDigestTest
,
1474 testing::ValuesIn(kVerifyIncompleteIntermediateTestData
));
1476 // Incomplete chains should still report the status of the end-entity.
1477 const WeakDigestTestData kVerifyIncompleteEETestData
[] = {
1478 { NULL
, "weak_digest_sha1_intermediate.pem", "weak_digest_md5_ee.pem",
1479 EXPECT_MD5
| EXPECT_SHA1
},
1480 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1481 // MD4 is not supported by OS X / NSS
1482 { NULL
, "weak_digest_sha1_intermediate.pem", "weak_digest_md4_ee.pem",
1483 EXPECT_MD4
| EXPECT_SHA1
},
1485 { NULL
, "weak_digest_sha1_intermediate.pem", "weak_digest_md2_ee.pem",
1486 EXPECT_MD2
| EXPECT_SHA1
},
1488 // Disabled on NSS - libpkix does not return constructed chains on error,
1489 // preventing us from detecting/inspecting the verified chain.
1490 #if defined(USE_NSS_CERTS) || defined(OS_IOS)
1491 #define MAYBE_VerifyIncompleteEndEntity DISABLED_VerifyIncompleteEndEntity
1493 #define MAYBE_VerifyIncompleteEndEntity VerifyIncompleteEndEntity
1495 WRAPPED_INSTANTIATE_TEST_CASE_P(
1496 MAYBE_VerifyIncompleteEndEntity
,
1497 CertVerifyProcWeakDigestTest
,
1498 testing::ValuesIn(kVerifyIncompleteEETestData
));
1500 // Differing algorithms between the intermediate and the EE should still be
1502 const WeakDigestTestData kVerifyMixedTestData
[] = {
1503 { "weak_digest_sha1_root.pem", "weak_digest_md5_intermediate.pem",
1504 "weak_digest_md2_ee.pem", EXPECT_MD2
| EXPECT_MD5
},
1505 { "weak_digest_sha1_root.pem", "weak_digest_md2_intermediate.pem",
1506 "weak_digest_md5_ee.pem", EXPECT_MD2
| EXPECT_MD5
},
1507 #if defined(USE_OPENSSL_CERTS) || defined(OS_WIN)
1508 // MD4 is not supported by OS X / NSS
1509 { "weak_digest_sha1_root.pem", "weak_digest_md4_intermediate.pem",
1510 "weak_digest_md2_ee.pem", EXPECT_MD2
| EXPECT_MD4
},
1513 // NSS does not support MD4 and does not enable MD2 by default, making all
1514 // permutations invalid.
1515 #if defined(USE_NSS_CERTS) || defined(OS_IOS)
1516 #define MAYBE_VerifyMixed DISABLED_VerifyMixed
1518 #define MAYBE_VerifyMixed VerifyMixed
1520 WRAPPED_INSTANTIATE_TEST_CASE_P(
1522 CertVerifyProcWeakDigestTest
,
1523 testing::ValuesIn(kVerifyMixedTestData
));
1525 // For the list of valid hostnames, see
1526 // net/cert/data/ssl/certificates/subjectAltName_sanity_check.pem
1527 static const struct CertVerifyProcNameData
{
1528 const char* hostname
;
1529 bool valid
; // Whether or not |hostname| matches a subjectAltName.
1530 } kVerifyNameData
[] = {
1531 { "127.0.0.1", false }, // Don't match the common name
1532 { "127.0.0.2", true }, // Matches the iPAddress SAN (IPv4)
1533 { "FE80:0:0:0:0:0:0:1", true }, // Matches the iPAddress SAN (IPv6)
1534 { "[FE80:0:0:0:0:0:0:1]", false }, // Should not match the iPAddress SAN
1535 { "FE80::1", true }, // Compressed form matches the iPAddress SAN (IPv6)
1536 { "::127.0.0.2", false }, // IPv6 mapped form should NOT match iPAddress SAN
1537 { "test.example", true }, // Matches the dNSName SAN
1538 { "test.example.", true }, // Matches the dNSName SAN (trailing . ignored)
1539 { "www.test.example", false }, // Should not match the dNSName SAN
1540 { "test..example", false }, // Should not match the dNSName SAN
1541 { "test.example..", false }, // Should not match the dNSName SAN
1542 { ".test.example.", false }, // Should not match the dNSName SAN
1543 { ".test.example", false }, // Should not match the dNSName SAN
1546 // GTest 'magic' pretty-printer, so that if/when a test fails, it knows how
1547 // to output the parameter that was passed. Without this, it will simply
1548 // attempt to print out the first twenty bytes of the object, which depending
1549 // on platform and alignment, may result in an invalid read.
1550 void PrintTo(const CertVerifyProcNameData
& data
, std::ostream
* os
) {
1551 *os
<< "Hostname: " << data
.hostname
<< "; valid=" << data
.valid
;
1554 class CertVerifyProcNameTest
1555 : public CertVerifyProcTest
,
1556 public testing::WithParamInterface
<CertVerifyProcNameData
> {
1558 CertVerifyProcNameTest() {}
1559 virtual ~CertVerifyProcNameTest() {}
1562 TEST_P(CertVerifyProcNameTest
, VerifyCertName
) {
1563 CertVerifyProcNameData data
= GetParam();
1565 CertificateList cert_list
= CreateCertificateListFromFile(
1566 GetTestCertsDirectory(), "subjectAltName_sanity_check.pem",
1567 X509Certificate::FORMAT_AUTO
);
1568 ASSERT_EQ(1U, cert_list
.size());
1569 scoped_refptr
<X509Certificate
> cert(cert_list
[0]);
1571 ScopedTestRoot
scoped_root(cert
.get());
1573 CertVerifyResult verify_result
;
1574 int error
= Verify(cert
.get(), data
.hostname
, 0, NULL
, empty_cert_list_
,
1577 EXPECT_EQ(OK
, error
);
1578 EXPECT_FALSE(verify_result
.cert_status
& CERT_STATUS_COMMON_NAME_INVALID
);
1580 EXPECT_EQ(ERR_CERT_COMMON_NAME_INVALID
, error
);
1581 EXPECT_TRUE(verify_result
.cert_status
& CERT_STATUS_COMMON_NAME_INVALID
);
1585 WRAPPED_INSTANTIATE_TEST_CASE_P(
1587 CertVerifyProcNameTest
,
1588 testing::ValuesIn(kVerifyNameData
));