1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
5 #include "chrome/browser/ui/views/frame/browser_view.h"
7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
10 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
11 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"
12 #include "chrome/browser/ui/views/frame/top_container_view.h"
13 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"
14 #include "chrome/browser/ui/views/tabs/tab_strip.h"
15 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
16 #include "chrome/common/url_constants.h"
17 #include "ui/views/controls/single_split_view.h"
18 #include "ui/views/controls/webview/webview.h"
22 // Tab strip bounds depend on the window frame sizes.
23 gfx::Point
ExpectedTabStripOrigin(BrowserView
* browser_view
) {
24 gfx::Rect
tabstrip_bounds(
25 browser_view
->frame()->GetBoundsForTabStrip(browser_view
->tabstrip()));
26 gfx::Point
tabstrip_origin(tabstrip_bounds
.origin());
27 views::View::ConvertPointToTarget(browser_view
->parent(),
30 return tabstrip_origin
;
35 typedef TestWithBrowserView BrowserViewTest
;
37 // Test basic construction and initialization.
38 TEST_F(BrowserViewTest
, BrowserView
) {
39 // The window is owned by the native widget, not the test class.
40 EXPECT_FALSE(window());
42 EXPECT_TRUE(browser_view()->browser());
44 // Test initial state.
45 EXPECT_TRUE(browser_view()->IsTabStripVisible());
46 EXPECT_FALSE(browser_view()->IsOffTheRecord());
47 EXPECT_FALSE(browser_view()->IsGuestSession());
48 EXPECT_FALSE(browser_view()->ShouldShowAvatar());
49 EXPECT_TRUE(browser_view()->IsBrowserTypeNormal());
50 EXPECT_FALSE(browser_view()->IsFullscreen());
51 EXPECT_FALSE(browser_view()->IsBookmarkBarVisible());
52 EXPECT_FALSE(browser_view()->IsBookmarkBarAnimating());
55 // Test layout of the top-of-window UI.
56 TEST_F(BrowserViewTest
, BrowserViewLayout
) {
57 BookmarkBarView::DisableAnimationsForTesting(true);
59 // |browser_view_| owns the Browser, not the test class.
60 Browser
* browser
= browser_view()->browser();
61 TopContainerView
* top_container
= browser_view()->top_container();
62 TabStrip
* tabstrip
= browser_view()->tabstrip();
63 ToolbarView
* toolbar
= browser_view()->toolbar();
64 views::View
* contents_container
=
65 browser_view()->GetContentsContainerForTest();
66 views::WebView
* contents_web_view
=
67 browser_view()->GetContentsWebViewForTest();
68 views::WebView
* devtools_web_view
=
69 browser_view()->GetDevToolsWebViewForTest();
71 // Start with a single tab open to a normal page.
72 AddTab(browser
, GURL("about:blank"));
74 // Verify the view hierarchy.
75 EXPECT_EQ(top_container
, browser_view()->tabstrip()->parent());
76 EXPECT_EQ(top_container
, browser_view()->toolbar()->parent());
77 EXPECT_EQ(top_container
, browser_view()->GetBookmarkBarView()->parent());
78 EXPECT_EQ(browser_view(), browser_view()->infobar_container()->parent());
80 // Find bar host is at the front of the view hierarchy, followed by the top
82 EXPECT_EQ(browser_view()->child_count() - 1,
83 browser_view()->GetIndexOf(browser_view()->find_bar_host_view()));
84 EXPECT_EQ(browser_view()->child_count() - 2,
85 browser_view()->GetIndexOf(top_container
));
87 // Verify basic layout.
88 EXPECT_EQ(0, top_container
->x());
89 EXPECT_EQ(0, top_container
->y());
90 EXPECT_EQ(browser_view()->width(), top_container
->width());
91 // Tabstrip layout varies based on window frame sizes.
92 gfx::Point expected_tabstrip_origin
= ExpectedTabStripOrigin(browser_view());
93 EXPECT_EQ(expected_tabstrip_origin
.x(), tabstrip
->x());
94 EXPECT_EQ(expected_tabstrip_origin
.y(), tabstrip
->y());
95 EXPECT_EQ(0, toolbar
->x());
97 tabstrip
->bounds().bottom() -
98 BrowserViewLayout::kToolbarTabStripVerticalOverlap
,
100 EXPECT_EQ(0, contents_container
->x());
101 EXPECT_EQ(toolbar
->bounds().bottom(), contents_container
->y());
102 EXPECT_EQ(top_container
->bounds().bottom(), contents_container
->y());
103 EXPECT_EQ(0, devtools_web_view
->x());
104 EXPECT_EQ(0, devtools_web_view
->y());
105 EXPECT_EQ(0, contents_web_view
->x());
106 EXPECT_EQ(0, contents_web_view
->y());
108 // Verify bookmark bar visibility.
109 BookmarkBarView
* bookmark_bar
= browser_view()->GetBookmarkBarView();
110 EXPECT_FALSE(bookmark_bar
->visible());
111 EXPECT_FALSE(bookmark_bar
->IsDetached());
112 chrome::ExecuteCommand(browser
, IDC_SHOW_BOOKMARK_BAR
);
113 EXPECT_TRUE(bookmark_bar
->visible());
114 EXPECT_FALSE(bookmark_bar
->IsDetached());
115 chrome::ExecuteCommand(browser
, IDC_SHOW_BOOKMARK_BAR
);
116 EXPECT_FALSE(bookmark_bar
->visible());
117 EXPECT_FALSE(bookmark_bar
->IsDetached());
119 // Bookmark bar is reparented to BrowserView on NTP.
120 NavigateAndCommitActiveTabWithTitle(browser
,
121 GURL(chrome::kChromeUINewTabURL
),
123 EXPECT_TRUE(bookmark_bar
->visible());
124 EXPECT_TRUE(bookmark_bar
->IsDetached());
125 EXPECT_EQ(browser_view(), bookmark_bar
->parent());
126 // Find bar host is still at the front of the view hierarchy, followed by
127 // the top container.
128 EXPECT_EQ(browser_view()->child_count() - 1,
129 browser_view()->GetIndexOf(browser_view()->find_bar_host_view()));
130 EXPECT_EQ(browser_view()->child_count() - 2,
131 browser_view()->GetIndexOf(top_container
));
133 // Bookmark bar layout on NTP.
134 EXPECT_EQ(0, bookmark_bar
->x());
136 tabstrip
->bounds().bottom() +
138 BrowserViewLayout::kToolbarTabStripVerticalOverlap
-
139 views::NonClientFrameView::kClientEdgeThickness
,
141 EXPECT_EQ(toolbar
->bounds().bottom(), contents_container
->y());
142 // Contents view has a "top margin" pushing it below the bookmark bar.
143 EXPECT_EQ(bookmark_bar
->height() -
144 views::NonClientFrameView::kClientEdgeThickness
,
145 devtools_web_view
->y());
146 EXPECT_EQ(bookmark_bar
->height() -
147 views::NonClientFrameView::kClientEdgeThickness
,
148 contents_web_view
->y());
150 // Bookmark bar is parented back to top container on normal page.
151 NavigateAndCommitActiveTabWithTitle(browser
,
154 EXPECT_FALSE(bookmark_bar
->visible());
155 EXPECT_FALSE(bookmark_bar
->IsDetached());
156 EXPECT_EQ(top_container
, bookmark_bar
->parent());
157 // Top container is still second from front.
158 EXPECT_EQ(browser_view()->child_count() - 2,
159 browser_view()->GetIndexOf(top_container
));
161 BookmarkBarView::DisableAnimationsForTesting(false);
164 class BrowserViewHostedAppTest
: public TestWithBrowserView
{
166 BrowserViewHostedAppTest()
167 : TestWithBrowserView(Browser::TYPE_POPUP
,
168 chrome::HOST_DESKTOP_TYPE_NATIVE
,
171 ~BrowserViewHostedAppTest() override
{}
174 DISALLOW_COPY_AND_ASSIGN(BrowserViewHostedAppTest
);
177 // Test basic layout for hosted apps.
178 TEST_F(BrowserViewHostedAppTest
, Layout
) {
179 // Add a tab because the browser starts out without any tabs at all.
180 AddTab(browser(), GURL("about:blank"));
182 views::View
* contents_container
=
183 browser_view()->GetContentsContainerForTest();
185 // The tabstrip, toolbar and bookmark bar should not be visible for hosted
187 EXPECT_FALSE(browser_view()->tabstrip()->visible());
188 EXPECT_FALSE(browser_view()->toolbar()->visible());
189 EXPECT_FALSE(browser_view()->IsBookmarkBarVisible());
191 gfx::Point header_offset
;
192 views::View::ConvertPointToTarget(
194 browser_view()->frame()->non_client_view()->frame_view(),
197 // The position of the bottom of the header (the bar with the window
198 // controls) in the coordinates of BrowserView.
199 int bottom_of_header
= browser_view()->frame()->GetTopInset() -
202 // The web contents should be flush with the bottom of the header.
203 EXPECT_EQ(bottom_of_header
, contents_container
->y());
205 // The find bar should overlap the 1px header/web-contents separator at the
206 // bottom of the header.
207 EXPECT_EQ(browser_view()->frame()->GetTopInset() - 1,
208 browser_view()->GetFindBarBoundingBox().y());