Address some additional cleanup work needed for the component flash updates on Linux.
[chromium-blink-merge.git] / native_client_sdk / PRESUBMIT.py
blob9e551bbbdd9290f263d922184b2c4573a38d1689
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
5 """Top-level presubmit script for native_client_sdk.
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into depot_tools.
9 """
12 def CommonChecks(input_api, output_api):
13 output = []
14 disabled_warnings = [
15 'F0401', # Unable to import module
16 'R0401', # Cyclic import
17 'W0613', # Unused argument
18 'W0403', # relative import warnings
19 'E1103', # subprocess.communicate() generates these :(
20 'R0201', # method could be function (doesn't reference self)
22 black_list = [
23 r'src[\\\/]build_tools[\\\/]tests[\\\/].*',
24 r'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*',
25 r'src[\\\/]doc[\\\/]*',
26 r'src[\\\/]gonacl_appengine[\\\/]*',
28 canned = input_api.canned_checks
29 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
30 disabled_warnings=disabled_warnings))
31 return output
34 def CheckChangeOnUpload(input_api, output_api):
35 return CommonChecks(input_api, output_api)
38 def CheckChangeOnCommit(input_api, output_api):
39 return CommonChecks(input_api, output_api)
42 def GetPreferredTryMasters(project, change):
43 return {
44 'tryserver.chromium.linux': {
45 'linux_nacl_sdk': set(['defaulttests']),
46 'linux_nacl_sdk_build': set(['defaulttests']),
48 'tryserver.chromium.win': {
49 'win_nacl_sdk': set(['defaulttests']),
50 'win_nacl_sdk_build': set(['defaulttests']),
52 'tryserver.chromium.mac': {
53 'mac_nacl_sdk': set(['defaulttests']),
54 'mac_nacl_sdk_build': set(['defaulttests']),