1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
5 // This test validates that the ProcessSingleton class properly makes sure
6 // that there is only one main browser process.
8 // It is currently compiled and run on Windows and Posix(non-Mac) platforms.
9 // Mac uses system services and ProcessSingletonMac is a noop. (Maybe it still
10 // makes sense to test that the system services are giving the behavior we
13 #include "base/bind.h"
14 #include "base/command_line.h"
15 #include "base/files/file_path.h"
16 #include "base/files/scoped_temp_dir.h"
17 #include "base/location.h"
18 #include "base/memory/ref_counted.h"
19 #include "base/path_service.h"
20 #include "base/process/launch.h"
21 #include "base/process/process.h"
22 #include "base/process/process_iterator.h"
23 #include "base/single_thread_task_runner.h"
24 #include "base/synchronization/waitable_event.h"
25 #include "base/test/test_timeouts.h"
26 #include "base/threading/thread.h"
27 #include "chrome/common/chrome_constants.h"
28 #include "chrome/common/chrome_paths.h"
29 #include "chrome/common/chrome_switches.h"
30 #include "chrome/test/base/in_process_browser_test.h"
31 #include "chrome/test/base/test_launcher_utils.h"
35 // This is for the code that is to be ran in multiple threads at once,
36 // to stress a race condition on first process start.
37 // We use the thread safe ref counted base class so that we can use the
38 // base::Bind to run the StartChrome methods in many threads.
39 class ChromeStarter
: public base::RefCountedThreadSafe
<ChromeStarter
> {
41 ChromeStarter(base::TimeDelta timeout
, const base::FilePath
& user_data_dir
)
42 : ready_event_(false /* manual */, false /* signaled */),
43 done_event_(false /* manual */, false /* signaled */),
44 process_terminated_(false),
46 user_data_dir_(user_data_dir
) {
49 // We must reset some data members since we reuse the same ChromeStarter
50 // object and start/stop it a few times. We must start fresh! :-)
54 if (process_
.IsValid())
56 process_terminated_
= false;
59 void StartChrome(base::WaitableEvent
* start_event
, bool first_run
) {
60 // TODO(mattm): maybe stuff should be refactored to use
61 // UITest::LaunchBrowserHelper somehow?
62 base::FilePath program
;
63 ASSERT_TRUE(PathService::Get(base::FILE_EXE
, &program
));
64 base::CommandLine
command_line(program
);
65 command_line
.AppendSwitchPath(switches::kUserDataDir
, user_data_dir_
);
68 command_line
.AppendSwitch(switches::kForceFirstRun
);
70 command_line
.AppendSwitch(switches::kNoFirstRun
);
72 // Add the normal test-mode switches, except for the ones we're adding
74 base::CommandLine
standard_switches(base::CommandLine::NO_PROGRAM
);
75 test_launcher_utils::PrepareBrowserCommandLineForTests(&standard_switches
);
76 const base::CommandLine::SwitchMap
& switch_map
=
77 standard_switches
.GetSwitches();
78 for (base::CommandLine::SwitchMap::const_iterator i
= switch_map
.begin();
79 i
!= switch_map
.end(); ++i
) {
80 const std::string
& switch_name
= i
->first
;
81 if (switch_name
== switches::kUserDataDir
||
82 switch_name
== switches::kForceFirstRun
||
83 switch_name
== switches::kNoFirstRun
)
86 command_line
.AppendSwitchNative(switch_name
, i
->second
);
89 // Try to get all threads to launch the app at the same time.
90 // So let the test know we are ready.
91 ready_event_
.Signal();
92 // And then wait for the test to tell us to GO!
93 ASSERT_NE(static_cast<base::WaitableEvent
*>(NULL
), start_event
);
96 // Here we don't wait for the app to be terminated because one of the
97 // process will stay alive while the others will be restarted. If we would
98 // wait here, we would never get a handle to the main process...
99 process_
= base::LaunchProcess(command_line
, base::LaunchOptions());
100 ASSERT_TRUE(process_
.IsValid());
102 // We can wait on the handle here, we should get stuck on one and only
103 // one process. The test below will take care of killing that process
104 // to unstuck us once it confirms there is only one.
106 process_terminated_
= process_
.WaitForExitWithTimeout(timeout_
, &exit_code
);
107 // Let the test know we are done.
108 done_event_
.Signal();
111 // Public access to simplify the test code using them.
112 base::WaitableEvent ready_event_
;
113 base::WaitableEvent done_event_
;
114 base::Process process_
;
115 bool process_terminated_
;
118 friend class base::RefCountedThreadSafe
<ChromeStarter
>;
122 base::TimeDelta timeout_
;
123 base::FilePath user_data_dir_
;
125 DISALLOW_COPY_AND_ASSIGN(ChromeStarter
);
130 // Our test fixture that initializes and holds onto a few global vars.
131 class ProcessSingletonTest
: public InProcessBrowserTest
{
133 ProcessSingletonTest()
134 // We use a manual reset so that all threads wake up at once when signaled
135 // and thus we must manually reset it for each attempt.
136 : threads_waker_(true /* manual */, false /* signaled */) {
137 EXPECT_TRUE(temp_profile_dir_
.CreateUniqueTempDir());
140 void SetUp() override
{
141 InProcessBrowserTest::SetUp();
142 // Start the threads and create the starters.
143 for (size_t i
= 0; i
< kNbThreads
; ++i
) {
144 chrome_starter_threads_
[i
].reset(new base::Thread("ChromeStarter"));
145 ASSERT_TRUE(chrome_starter_threads_
[i
]->Start());
146 chrome_starters_
[i
] = new ChromeStarter(
147 TestTimeouts::action_max_timeout(), temp_profile_dir_
.path());
151 void TearDown() override
{
153 for (size_t i
= 0; i
< kNbThreads
; ++i
)
154 chrome_starter_threads_
[i
]->Stop();
157 // This method is used to make sure we kill the main browser process after
158 // all of its child processes have successfully attached to it. This was added
159 // when we realized that if we just kill the parent process right away, we
160 // sometimes end up with dangling child processes. If we Sleep for a certain
161 // amount of time, we are OK... So we introduced this method to avoid a
162 // flaky wait. Instead, we kill all descendants of the main process after we
163 // killed it, relying on the fact that we can still get the parent id of a
164 // child process, even when the parent dies.
165 void KillProcessTree(const base::Process
& process
) {
166 class ProcessTreeFilter
: public base::ProcessFilter
{
168 explicit ProcessTreeFilter(base::ProcessId parent_pid
) {
169 ancestor_pids_
.insert(parent_pid
);
171 bool Includes(const base::ProcessEntry
& entry
) const override
{
172 if (ancestor_pids_
.find(entry
.parent_pid()) != ancestor_pids_
.end()) {
173 ancestor_pids_
.insert(entry
.pid());
180 mutable std::set
<base::ProcessId
> ancestor_pids_
;
181 } process_tree_filter(process
.Pid());
183 // Start by explicitly killing the main process we know about...
184 static const int kExitCode
= 42;
185 EXPECT_TRUE(process
.Terminate(kExitCode
, true /* wait */));
187 // Then loop until we can't find any of its descendant.
188 // But don't try more than kNbTries times...
189 static const int kNbTries
= 10;
191 base::FilePath program
;
192 ASSERT_TRUE(PathService::Get(base::FILE_EXE
, &program
));
193 base::FilePath::StringType exe_name
= program
.BaseName().value();
194 while (base::GetProcessCount(exe_name
, &process_tree_filter
) > 0 &&
195 num_tries
++ < kNbTries
) {
196 base::KillProcesses(exe_name
, kExitCode
, &process_tree_filter
);
198 DLOG_IF(ERROR
, num_tries
>= kNbTries
) << "Failed to kill all processes!";
201 // Since this is a hard to reproduce problem, we make a few attempts.
202 // We stop the attempts at the first error, and when there are no errors,
203 // we don't time-out of any wait, so it executes quite fast anyway.
204 static const size_t kNbAttempts
= 5;
206 // The idea is to start chrome from multiple threads all at once.
207 static const size_t kNbThreads
= 5;
208 scoped_refptr
<ChromeStarter
> chrome_starters_
[kNbThreads
];
209 scoped_ptr
<base::Thread
> chrome_starter_threads_
[kNbThreads
];
211 // The event that will get all threads to wake up simultaneously and try
212 // to start a chrome process at the same time.
213 base::WaitableEvent threads_waker_
;
215 // We don't want to use the default profile, but can't use UITest's since we
216 // don't use UITest::LaunchBrowser.
217 base::ScopedTempDir temp_profile_dir_
;
220 // Disabled on all platforms after code rot due to http://crbug.com/513534.
221 // Originally disabled on some platforms due to http://crbug.com/58219.
222 IN_PROC_BROWSER_TEST_F(ProcessSingletonTest
, DISABLED_StartupRaceCondition
) {
223 // We use this to stop the attempts loop on the first failure.
225 for (size_t attempt
= 0; attempt
< kNbAttempts
&& !failed
; ++attempt
) {
226 SCOPED_TRACE(testing::Message() << "Attempt: " << attempt
<< ".");
227 // We use a single event to get all threads to do the AppLaunch at the same
229 threads_waker_
.Reset();
231 // Test both with and without the first-run dialog, since they exercise
233 #if defined(OS_POSIX)
234 // TODO(mattm): test first run dialog singleton handling on linux too.
235 // On posix if we test the first run dialog, GracefulShutdownHandler gets
236 // the TERM signal, but since the message loop isn't running during the gtk
237 // first run dialog, the ShutdownDetector never handles it, and KillProcess
238 // has to time out (60 sec!) and SIGKILL.
239 bool first_run
= false;
241 // Test for races in both regular start up and first run start up cases.
242 bool first_run
= attempt
% 2;
245 // Here we prime all the threads with a ChromeStarter that will wait for
246 // our signal to launch its chrome process.
247 for (size_t i
= 0; i
< kNbThreads
; ++i
) {
248 ASSERT_NE(static_cast<ChromeStarter
*>(NULL
), chrome_starters_
[i
].get());
249 chrome_starters_
[i
]->Reset();
251 ASSERT_TRUE(chrome_starter_threads_
[i
]->IsRunning());
252 ASSERT_NE(static_cast<base::MessageLoop
*>(NULL
),
253 chrome_starter_threads_
[i
]->message_loop());
255 chrome_starter_threads_
[i
]->task_runner()->PostTask(
257 base::Bind(&ChromeStarter::StartChrome
, chrome_starters_
[i
].get(),
258 &threads_waker_
, first_run
));
261 // Wait for all the starters to be ready.
262 // We could replace this loop if we ever implement a WaitAll().
263 for (size_t i
= 0; i
< kNbThreads
; ++i
) {
264 SCOPED_TRACE(testing::Message() << "Waiting on thread: " << i
<< ".");
265 chrome_starters_
[i
]->ready_event_
.Wait();
268 threads_waker_
.Signal();
270 // As we wait for all threads to signal that they are done, we remove their
271 // index from this vector so that we get left with only the index of
272 // the thread that started the main process.
273 std::vector
<size_t> pending_starters(kNbThreads
);
274 for (size_t i
= 0; i
< kNbThreads
; ++i
)
275 pending_starters
[i
] = i
;
277 // We use a local array of starter's done events we must wait on...
278 // These are collected from the starters that we have not yet been removed
279 // from the pending_starters vector.
280 base::WaitableEvent
* starters_done_events
[kNbThreads
];
281 // At the end, "There can be only one" main browser process alive.
282 while (pending_starters
.size() > 1) {
283 SCOPED_TRACE(testing::Message() << pending_starters
.size() <<
285 for (size_t i
= 0; i
< pending_starters
.size(); ++i
) {
286 starters_done_events
[i
] =
287 &chrome_starters_
[pending_starters
[i
]]->done_event_
;
289 size_t done_index
= base::WaitableEvent::WaitMany(
290 starters_done_events
, pending_starters
.size());
291 size_t starter_index
= pending_starters
[done_index
];
292 // If the starter is done but has not marked itself as terminated,
293 // it is because it timed out of its WaitForExitCodeWithTimeout(). Only
294 // the last one standing should be left waiting... So we failed...
295 EXPECT_TRUE(chrome_starters_
[starter_index
]->process_terminated_
||
296 failed
) << "There is more than one main process.";
297 if (!chrome_starters_
[starter_index
]->process_terminated_
) {
298 // This will stop the "for kNbAttempts" loop.
300 // But we let the last loop turn finish so that we can properly
301 // kill all remaining processes. Starting with this one...
302 if (chrome_starters_
[starter_index
]->process_
.IsValid()) {
303 KillProcessTree(chrome_starters_
[starter_index
]->process_
);
306 pending_starters
.erase(pending_starters
.begin() + done_index
);
309 // "There can be only one!" :-)
310 ASSERT_EQ(static_cast<size_t>(1), pending_starters
.size());
311 size_t last_index
= pending_starters
.front();
312 pending_starters
.clear();
313 if (chrome_starters_
[last_index
]->process_
.IsValid()) {
314 KillProcessTree(chrome_starters_
[last_index
]->process_
);
315 chrome_starters_
[last_index
]->done_event_
.Wait();