chrome/browser/extensions/error_console/error_console_browsertest.cc

   1 // Copyright 2013 The Chromium Authors. All rights reserved.
   2 // Use of this source code is governed by a BSD-style license that can be
   3 // found in the LICENSE file.
   4
   5 #include "chrome/browser/extensions/error_console/error_console.h"
   6
   7 #include "base/files/file_path.h"
   8 #include "base/prefs/pref_service.h"
   9 #include "base/strings/string16.h"
  10 #include "base/strings/stringprintf.h"
  11 #include "base/strings/utf_string_conversions.h"
  12 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
  13 #include "chrome/browser/extensions/extension_browsertest.h"
  14 #include "chrome/browser/profiles/profile.h"
  15 #include "chrome/common/pref_names.h"
  16 #include "chrome/common/url_constants.h"
  17 #include "chrome/test/base/ui_test_utils.h"
  18 #include "extensions/browser/extension_error.h"
  19 #include "extensions/common/constants.h"
  20 #include "extensions/common/error_utils.h"
  21 #include "extensions/common/extension.h"
  22 #include "extensions/common/extension_urls.h"
  23 #include "extensions/common/feature_switch.h"
  24 #include "extensions/common/manifest_constants.h"
  25 #include "net/test/embedded_test_server/embedded_test_server.h"
  26 #include "testing/gtest/include/gtest/gtest.h"
  27 #include "url/gurl.h"
  28
  29 using base::string16;
  30 using base::UTF8ToUTF16;
  31
  32 namespace extensions {
  33
  34 namespace {
  35
  36 const char kTestingPage[] = "/extensions/test_file.html";
  37 const char kAnonymousFunction[] = "(anonymous function)";
  38 const char* const kBackgroundPageName =
  39     extensions::kGeneratedBackgroundPageFilename;
  40 const int kNoFlags = 0;
  41
  42 const StackTrace& GetStackTraceFromError(const ExtensionError* error) {
  43   CHECK(error->type() == ExtensionError::RUNTIME_ERROR);
  44   return (static_cast<const RuntimeError*>(error))->stack_trace();
  45 }
  46
  47 // Verify that a given |frame| has the proper source and function name.
  48 void CheckStackFrame(const StackFrame& frame,
  49                      const std::string& source,
  50                      const std::string& function) {
  51   EXPECT_EQ(base::UTF8ToUTF16(source), frame.source);
  52   EXPECT_EQ(base::UTF8ToUTF16(function), frame.function);
  53 }
  54
  55 // Verify that all properties of a given |frame| are correct. Overloaded because
  56 // we commonly do not check line/column numbers, as they are too likely
  57 // to change.
  58 void CheckStackFrame(const StackFrame& frame,
  59                      const std::string& source,
  60                      const std::string& function,
  61                      size_t line_number,
  62                      size_t column_number) {
  63   CheckStackFrame(frame, source, function);
  64   EXPECT_EQ(line_number, frame.line_number);
  65   EXPECT_EQ(column_number, frame.column_number);
  66 }
  67
  68 // Verify that all properties of a given |error| are correct.
  69 void CheckError(const ExtensionError* error,
  70                 ExtensionError::Type type,
  71                 const std::string& id,
  72                 const std::string& source,
  73                 bool from_incognito,
  74                 const std::string& message) {
  75   ASSERT_TRUE(error);
  76   EXPECT_EQ(type, error->type());
  77   EXPECT_EQ(id, error->extension_id());
  78   EXPECT_EQ(base::UTF8ToUTF16(source), error->source());
  79   EXPECT_EQ(from_incognito, error->from_incognito());
  80   EXPECT_EQ(base::UTF8ToUTF16(message), error->message());
  81 }
  82
  83 // Verify that all properties of a JS runtime error are correct.
  84 void CheckRuntimeError(const ExtensionError* error,
  85                        const std::string& id,
  86                        const std::string& source,
  87                        bool from_incognito,
  88                        const std::string& message,
  89                        logging::LogSeverity level,
  90                        const GURL& context,
  91                        size_t expected_stack_size) {
  92   CheckError(error,
  93              ExtensionError::RUNTIME_ERROR,
  94              id,
  95              source,
  96              from_incognito,
  97              message);
  98
  99   const RuntimeError* runtime_error = static_cast<const RuntimeError*>(error);
 100   EXPECT_EQ(level, runtime_error->level());
 101   EXPECT_EQ(context, runtime_error->context_url());
 102   EXPECT_EQ(expected_stack_size, runtime_error->stack_trace().size());
 103 }
 104
 105 void CheckManifestError(const ExtensionError* error,
 106                         const std::string& id,
 107                         const std::string& message,
 108                         const std::string& manifest_key,
 109                         const std::string& manifest_specific) {
 110   CheckError(error,
 111              ExtensionError::MANIFEST_ERROR,
 112              id,
 113              // source is always the manifest for ManifestErrors.
 114              base::FilePath(kManifestFilename).AsUTF8Unsafe(),
 115              false,  // manifest errors are never from incognito.
 116              message);
 117
 118   const ManifestError* manifest_error =
 119       static_cast<const ManifestError*>(error);
 120   EXPECT_EQ(base::UTF8ToUTF16(manifest_key), manifest_error->manifest_key());
 121   EXPECT_EQ(base::UTF8ToUTF16(manifest_specific),
 122             manifest_error->manifest_specific());
 123 }
 124
 125 }  // namespace
 126
 127 class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
 128  public:
 129   ErrorConsoleBrowserTest() : error_console_(NULL) { }
 130   ~ErrorConsoleBrowserTest() override {}
 131
 132  protected:
 133   // A helper class in order to wait for the proper number of errors to be
 134   // caught by the ErrorConsole. This will run the MessageLoop until a given
 135   // number of errors are observed.
 136   // Usage:
 137   //   ...
 138   //   ErrorObserver observer(3, error_console);
 139   //   <Cause three errors...>
 140   //   observer.WaitForErrors();
 141   //   <Perform any additional checks...>
 142   class ErrorObserver : public ErrorConsole::Observer {
 143    public:
 144     ErrorObserver(size_t errors_expected, ErrorConsole* error_console)
 145         : errors_observed_(0),
 146           errors_expected_(errors_expected),
 147           waiting_(false),
 148           error_console_(error_console) {
 149       error_console_->AddObserver(this);
 150     }
 151     virtual ~ErrorObserver() {
 152       if (error_console_)
 153         error_console_->RemoveObserver(this);
 154     }
 155
 156     // ErrorConsole::Observer implementation.
 157     void OnErrorAdded(const ExtensionError* error) override {
 158       ++errors_observed_;
 159       if (errors_observed_ >= errors_expected_) {
 160         if (waiting_)
 161           base::MessageLoopForUI::current()->Quit();
 162       }
 163     }
 164
 165     void OnErrorConsoleDestroyed() override { error_console_ = NULL; }
 166
 167     // Spin until the appropriate number of errors have been observed.
 168     void WaitForErrors() {
 169       if (errors_observed_ < errors_expected_) {
 170         waiting_ = true;
 171         content::RunMessageLoop();
 172         waiting_ = false;
 173       }
 174     }
 175
 176    private:
 177     size_t errors_observed_;
 178     size_t errors_expected_;
 179     bool waiting_;
 180
 181     ErrorConsole* error_console_;
 182
 183     DISALLOW_COPY_AND_ASSIGN(ErrorObserver);
 184   };
 185
 186   // The type of action which we take after we load an extension in order to
 187   // cause any errors.
 188   enum Action {
 189     // Navigate to a (non-chrome) page to allow a content script to run.
 190     ACTION_NAVIGATE,
 191     // Simulate a browser action click.
 192     ACTION_BROWSER_ACTION,
 193     // Navigate to the new tab page.
 194     ACTION_NEW_TAB,
 195     // Do nothing (errors will be caused by a background script,
 196     // or by a manifest/loading warning).
 197     ACTION_NONE
 198   };
 199
 200   void SetUpInProcessBrowserTestFixture() override {
 201     ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
 202
 203     // We need to enable the ErrorConsole FeatureSwitch in order to collect
 204     // errors. This should be enabled on any channel <= Dev, but let's make
 205     // sure (in case a test is running on, e.g., a beta channel).
 206     FeatureSwitch::error_console()->SetOverrideValue(
 207         FeatureSwitch::OVERRIDE_ENABLED);
 208   }
 209
 210   void SetUpOnMainThread() override {
 211     ExtensionBrowserTest::SetUpOnMainThread();
 212
 213     // Errors are only kept if we have Developer Mode enabled.
 214     profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
 215
 216     error_console_ = ErrorConsole::Get(profile());
 217     CHECK(error_console_);
 218
 219     test_data_dir_ = test_data_dir_.AppendASCII("error_console");
 220   }
 221
 222   const GURL& GetTestURL() {
 223     if (test_url_.is_empty()) {
 224       CHECK(embedded_test_server()->InitializeAndWaitUntilReady());
 225       test_url_ = embedded_test_server()->GetURL(kTestingPage);
 226     }
 227     return test_url_;
 228   }
 229
 230   // Load the extension at |path|, take the specified |action|, and wait for
 231   // |expected_errors| errors. Populate |extension| with a pointer to the loaded
 232   // extension.
 233   void LoadExtensionAndCheckErrors(
 234       const std::string& path,
 235       int flags,
 236       size_t errors_expected,
 237       Action action,
 238       const Extension** extension) {
 239     ErrorObserver observer(errors_expected, error_console_);
 240     *extension =
 241         LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags);
 242     ASSERT_TRUE(*extension);
 243
 244     switch (action) {
 245       case ACTION_NAVIGATE: {
 246         ui_test_utils::NavigateToURL(browser(), GetTestURL());
 247         break;
 248       }
 249       case ACTION_BROWSER_ACTION: {
 250         ExtensionActionAPI::Get(profile())->ExecuteExtensionAction(
 251             *extension, browser(), true);
 252         break;
 253       }
 254       case ACTION_NEW_TAB: {
 255         ui_test_utils::NavigateToURL(browser(),
 256                                      GURL(chrome::kChromeUINewTabURL));
 257         break;
 258       }
 259       case ACTION_NONE:
 260         break;
 261       default:
 262         NOTREACHED();
 263     }
 264
 265     observer.WaitForErrors();
 266
 267     // We should only have errors for a single extension, or should have no
 268     // entries, if no errors were expected.
 269     ASSERT_EQ(errors_expected > 0 ? 1u : 0u,
 270               error_console()->get_num_entries_for_test());
 271     ASSERT_EQ(
 272         errors_expected,
 273         error_console()->GetErrorsForExtension((*extension)->id()).size());
 274   }
 275
 276   ErrorConsole* error_console() { return error_console_; }
 277
 278  private:
 279   // The URL used in testing for simple page navigations.
 280   GURL test_url_;
 281
 282   // Weak reference to the ErrorConsole.
 283   ErrorConsole* error_console_;
 284 };
 285
 286 // Test to ensure that we are successfully reporting manifest errors as an
 287 // extension is installed.
 288 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, ReportManifestErrors) {
 289   const Extension* extension = NULL;
 290   // We expect two errors - one for an invalid permission, and a second for
 291   // an unknown key.
 292   LoadExtensionAndCheckErrors("manifest_warnings",
 293                               ExtensionBrowserTest::kFlagIgnoreManifestWarnings,
 294                               2,
 295                               ACTION_NONE,
 296                               &extension);
 297
 298   const ErrorList& errors =
 299       error_console()->GetErrorsForExtension(extension->id());
 300
 301   // Unfortunately, there's not always a hard guarantee of order in parsing the
 302   // manifest, so there's not a definitive order in which these errors may
 303   // occur. As such, we need to determine which error corresponds to which
 304   // expected error.
 305   const ExtensionError* permissions_error = NULL;
 306   const ExtensionError* unknown_key_error = NULL;
 307   const char kFakeKey[] = "not_a_real_key";
 308   for (size_t i = 0; i < errors.size(); ++i) {
 309     ASSERT_EQ(ExtensionError::MANIFEST_ERROR, errors[i]->type());
 310     std::string utf8_key = base::UTF16ToUTF8(
 311         (static_cast<const ManifestError*>(errors[i]))->manifest_key());
 312     if (utf8_key == manifest_keys::kPermissions)
 313       permissions_error = errors[i];
 314     else if (utf8_key == kFakeKey)
 315       unknown_key_error = errors[i];
 316   }
 317   ASSERT_TRUE(permissions_error);
 318   ASSERT_TRUE(unknown_key_error);
 319
 320   const char kFakePermission[] = "not_a_real_permission";
 321   CheckManifestError(permissions_error,
 322                      extension->id(),
 323                      ErrorUtils::FormatErrorMessage(
 324                          manifest_errors::kPermissionUnknownOrMalformed,
 325                          kFakePermission),
 326                      manifest_keys::kPermissions,
 327                      kFakePermission);
 328
 329   CheckManifestError(unknown_key_error,
 330                      extension->id(),
 331                      ErrorUtils::FormatErrorMessage(
 332                          manifest_errors::kUnrecognizedManifestKey,
 333                          kFakeKey),
 334                      kFakeKey,
 335                      std::string());
 336 }
 337
 338 // Test that we do not store any errors unless the Developer Mode switch is
 339 // toggled on the profile.
 340 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
 341                        DontStoreErrorsWithoutDeveloperMode) {
 342   profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
 343
 344   const Extension* extension = NULL;
 345   // Same test as ReportManifestErrors, except we don't expect any errors since
 346   // we disable Developer Mode.
 347   LoadExtensionAndCheckErrors("manifest_warnings",
 348                               ExtensionBrowserTest::kFlagIgnoreManifestWarnings,
 349                               0,
 350                               ACTION_NONE,
 351                               &extension);
 352
 353   // Now if we enable developer mode, the errors should be reported...
 354   profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
 355   EXPECT_EQ(2u, error_console()->GetErrorsForExtension(extension->id()).size());
 356
 357   // ... and if we disable it again, all errors which we were holding should be
 358   // removed.
 359   profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
 360   EXPECT_EQ(0u, error_console()->GetErrorsForExtension(extension->id()).size());
 361 }
 362
 363 // Load an extension which, upon visiting any page, first sends out a console
 364 // log, and then crashes with a JS TypeError.
 365 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
 366                        ContentScriptLogAndRuntimeError) {
 367   const Extension* extension = NULL;
 368   LoadExtensionAndCheckErrors(
 369       "content_script_log_and_runtime_error",
 370       kNoFlags,
 371       2u,  // Two errors: A log message and a JS type error.
 372       ACTION_NAVIGATE,
 373       &extension);
 374
 375   std::string script_url = extension->url().Resolve("content_script.js").spec();
 376
 377   const ErrorList& errors =
 378       error_console()->GetErrorsForExtension(extension->id());
 379
 380   // The first error should be a console log.
 381   CheckRuntimeError(errors[0],
 382                     extension->id(),
 383                     script_url,  // The source should be the content script url.
 384                     false,  // Not from incognito.
 385                     "Hello, World!",  // The error message is the log.
 386                     logging::LOG_INFO,
 387                     GetTestURL(),  // Content scripts run in the web page.
 388                     2u);
 389
 390   const StackTrace& stack_trace1 = GetStackTraceFromError(errors[0]);
 391   CheckStackFrame(stack_trace1[0],
 392                   script_url,
 393                   "logHelloWorld",  // function name
 394                   6u,  // line number
 395                   11u /* column number */);
 396
 397   CheckStackFrame(stack_trace1[1],
 398                   script_url,
 399                   kAnonymousFunction,
 400                   9u,
 401                   1u);
 402
 403   // The second error should be a runtime error.
 404   CheckRuntimeError(errors[1],
 405                     extension->id(),
 406                     script_url,
 407                     false,  // not from incognito
 408                     "Uncaught TypeError: "
 409                         "Cannot set property 'foo' of undefined",
 410                     logging::LOG_ERROR,  // JS errors are always ERROR level.
 411                     GetTestURL(),
 412                     1u);
 413
 414   const StackTrace& stack_trace2 = GetStackTraceFromError(errors[1]);
 415   CheckStackFrame(stack_trace2[0],
 416                   script_url,
 417                   kAnonymousFunction,
 418                   12u,
 419                   1u);
 420 }
 421
 422 // Catch an error from a BrowserAction; this is more complex than a content
 423 // script error, since browser actions are routed through our own code.
 424 #if defined(OS_WIN)  // Flakes on XP. http://crbug.com/517029
 425 #define MAYBE_BrowserActionRuntimeError DISABLED_BrowserActionRuntimeError
 426 #else
 427 #define MAYBE_BrowserActionRuntimeError BrowserActionRuntimeError
 428 #endif
 429 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
 430                        MAYBE_BrowserActionRuntimeError) {
 431   const Extension* extension = NULL;
 432   LoadExtensionAndCheckErrors(
 433       "browser_action_runtime_error",
 434       kNoFlags,
 435       1u,  // One error: A reference error from within the browser action.
 436       ACTION_BROWSER_ACTION,
 437       &extension);
 438
 439   std::string script_url = extension->url().Resolve("browser_action.js").spec();
 440
 441   const ErrorList& errors =
 442       error_console()->GetErrorsForExtension(extension->id());
 443
 444   std::string event_bindings_str =
 445       base::StringPrintf("extensions::%s", kEventBindings);
 446
 447   std::string event_dispatch_to_listener_str =
 448       base::StringPrintf("Event.publicClass.%s [as dispatchToListener]",
 449                          kAnonymousFunction);
 450
 451   CheckRuntimeError(
 452       errors[0],
 453       extension->id(),
 454       script_url,
 455       false,  // not incognito
 456       "Error in event handler for browserAction.onClicked: ReferenceError: "
 457           "baz is not defined",
 458       logging::LOG_ERROR,
 459       extension->url().Resolve(kBackgroundPageName),
 460       1u);
 461
 462   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
 463   // Note: This test used to have a stack trace of length 6 that contains stack
 464   // frames in the extension code, but since crbug.com/404406 was fixed only
 465   // stack frames within user-defined extension code are printed.
 466
 467   CheckStackFrame(stack_trace[0], script_url, kAnonymousFunction);
 468 }
 469
 470 // Test that we can catch an error for calling an API with improper arguments.
 471 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadAPIArgumentsRuntimeError) {
 472   const Extension* extension = NULL;
 473   LoadExtensionAndCheckErrors(
 474       "bad_api_arguments_runtime_error",
 475       kNoFlags,
 476       1,  // One error: call an API with improper arguments.
 477       ACTION_NONE,
 478       &extension);
 479
 480   const ErrorList& errors =
 481       error_console()->GetErrorsForExtension(extension->id());
 482
 483   std::string schema_utils_str =
 484       base::StringPrintf("extensions::%s", kSchemaUtils);
 485
 486   CheckRuntimeError(
 487       errors[0],
 488       extension->id(),
 489       schema_utils_str,  // API calls are checked in schemaUtils.js.
 490       false,  // not incognito
 491       "Uncaught Error: Invocation of form "
 492           "tabs.get(string, function) doesn't match definition "
 493           "tabs.get(integer tabId, function callback)",
 494       logging::LOG_ERROR,
 495       extension->url().Resolve(kBackgroundPageName),
 496       1u);
 497
 498   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
 499   ASSERT_EQ(1u, stack_trace.size());
 500   CheckStackFrame(stack_trace[0],
 501                   schema_utils_str,
 502                   kAnonymousFunction);
 503 }
 504
 505 // Test that we catch an error when we try to call an API method without
 506 // permission.
 507 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadAPIPermissionsRuntimeError) {
 508   const Extension* extension = NULL;
 509   LoadExtensionAndCheckErrors(
 510       "bad_api_permissions_runtime_error",
 511       kNoFlags,
 512       1,  // One error: we try to call addUrl() on chrome.history without
 513           // permission, which results in a TypeError.
 514       ACTION_NONE,
 515       &extension);
 516
 517   std::string script_url = extension->url().Resolve("background.js").spec();
 518
 519   const ErrorList& errors =
 520       error_console()->GetErrorsForExtension(extension->id());
 521
 522   CheckRuntimeError(
 523       errors[0],
 524       extension->id(),
 525       script_url,
 526       false,  // not incognito
 527       "Uncaught TypeError: Cannot read property 'addUrl' of undefined",
 528       logging::LOG_ERROR,
 529       extension->url().Resolve(kBackgroundPageName),
 530       1u);
 531
 532   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
 533   ASSERT_EQ(1u, stack_trace.size());
 534   CheckStackFrame(stack_trace[0],
 535                   script_url,
 536                   kAnonymousFunction,
 537                   5u, 1u);
 538 }
 539
 540 // Test that if there is an error in an HTML page loaded by an extension (most
 541 // common with apps), it is caught and reported by the ErrorConsole.
 542 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadExtensionPage) {
 543   const Extension* extension = NULL;
 544   LoadExtensionAndCheckErrors(
 545       "bad_extension_page",
 546       kNoFlags,
 547       1,  // One error: the page will load JS which has a reference error.
 548       ACTION_NEW_TAB,
 549       &extension);
 550 }
 551
 552 // Test that extension errors that go to chrome.runtime.lastError are caught
 553 // and reported by the ErrorConsole.
 554 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, CatchesLastError) {
 555   const Extension* extension = NULL;
 556   LoadExtensionAndCheckErrors(
 557       "trigger_last_error",
 558       kNoFlags,
 559       1,  // One error, which is sent through last error when trying to remove
 560           // a non-existent permisison.
 561       ACTION_NONE,
 562       &extension);
 563
 564   const ErrorList& errors =
 565       error_console()->GetErrorsForExtension(extension->id());
 566   ASSERT_EQ(1u, errors.size());
 567
 568   std::string script_url = extension->url().Resolve("background.js").spec();
 569
 570   CheckRuntimeError(
 571       errors[0],
 572       extension->id(),
 573       script_url,
 574       false,  // not incognito
 575       "Unchecked runtime.lastError while running permissions.remove: "
 576           "'foobar' is not a recognized permission.",
 577       logging::LOG_ERROR,
 578       extension->url().Resolve(kBackgroundPageName),
 579       1u);
 580
 581   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
 582   ASSERT_EQ(1u, stack_trace.size());
 583   CheckStackFrame(stack_trace[0],
 584                   script_url,
 585                   kAnonymousFunction,
 586                   12u, 20u);
 587 }
 588
 589 }  // namespace extensions