chrome/browser/ui/browser_command_controller_unittest.cc

   1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
   2 // Use of this source code is governed by a BSD-style license that can be
   3 // found in the LICENSE file.
   4
   5 #include "chrome/browser/ui/browser_command_controller.h"
   6
   7 #include "base/command_line.h"
   8 #include "chrome/app/chrome_command_ids.h"
   9 #include "chrome/browser/browser_process.h"
  10 #include "chrome/browser/command_updater.h"
  11 #include "chrome/browser/prefs/incognito_mode_prefs.h"
  12 #include "chrome/browser/profiles/profile_manager.h"
  13 #include "chrome/browser/profiles/profiles_state.h"
  14 #include "chrome/browser/ui/browser.h"
  15 #include "chrome/browser/ui/browser_commands.h"
  16 #include "chrome/browser/ui/browser_window_state.h"
  17 #include "chrome/common/chrome_switches.h"
  18 #include "chrome/common/pref_names.h"
  19 #include "chrome/test/base/browser_with_test_window_test.h"
  20 #include "chrome/test/base/test_browser_window.h"
  21 #include "chrome/test/base/testing_browser_process.h"
  22 #include "chrome/test/base/testing_profile.h"
  23 #include "chrome/test/base/testing_profile_manager.h"
  24 #include "components/signin/core/common/profile_management_switches.h"
  25 #include "content/public/browser/native_web_keyboard_event.h"
  26 #include "ui/events/keycodes/keyboard_codes.h"
  27
  28 typedef BrowserWithTestWindowTest BrowserCommandControllerTest;
  29
  30 TEST_F(BrowserCommandControllerTest, IsReservedCommandOrKey) {
  31 #if defined(OS_CHROMEOS)
  32   // F1-3 keys are reserved Chrome accelerators on Chrome OS.
  33   EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
  34       IDC_BACK, content::NativeWebKeyboardEvent(
  35           ui::ET_KEY_PRESSED, false, ui::VKEY_BROWSER_BACK, 0, 0)));
  36   EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
  37       IDC_FORWARD, content::NativeWebKeyboardEvent(
  38           ui::ET_KEY_PRESSED, false, ui::VKEY_BROWSER_FORWARD, 0, 0)));
  39   EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
  40       IDC_RELOAD, content::NativeWebKeyboardEvent(
  41           ui::ET_KEY_PRESSED, false, ui::VKEY_BROWSER_REFRESH, 0, 0)));
  42
  43   // When there are modifier keys pressed, don't reserve.
  44   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  45       IDC_RELOAD_IGNORING_CACHE, content::NativeWebKeyboardEvent(
  46           ui::ET_KEY_PRESSED, false, ui::VKEY_F3, ui::EF_SHIFT_DOWN, 0)));
  47   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  48       IDC_RELOAD_IGNORING_CACHE, content::NativeWebKeyboardEvent(
  49           ui::ET_KEY_PRESSED, false, ui::VKEY_F3, ui::EF_CONTROL_DOWN, 0)));
  50   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  51       IDC_FULLSCREEN, content::NativeWebKeyboardEvent(
  52           ui::ET_KEY_PRESSED, false, ui::VKEY_F4, ui::EF_SHIFT_DOWN, 0)));
  53
  54   // F4-10 keys are not reserved since they are Ash accelerators.
  55   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  56       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  57                                           ui::VKEY_F4, 0, 0)));
  58   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  59       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  60                                           ui::VKEY_F5, 0, 0)));
  61   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  62       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  63                                           ui::VKEY_F6, 0, 0)));
  64   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  65       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  66                                           ui::VKEY_F7, 0, 0)));
  67   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  68       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  69                                           ui::VKEY_F8, 0, 0)));
  70   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  71       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  72                                           ui::VKEY_F9, 0, 0)));
  73   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  74       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
  75                                           ui::VKEY_F10, 0, 0)));
  76
  77   // Shift+Control+Alt+F3 is also an Ash accelerator. Don't reserve it.
  78   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  79       -1, content::NativeWebKeyboardEvent(
  80           ui::ET_KEY_PRESSED, false,
  81           ui::VKEY_F3,
  82           ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN, 0)));
  83 #endif  // OS_CHROMEOS
  84
  85 #if defined(USE_AURA)
  86   // Ctrl+n, Ctrl+w are reserved while Ctrl+f is not.
  87
  88   // The content::NativeWebKeyboardEvent constructor is available only when
  89   // USE_AURA is #defined.
  90   EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
  91       IDC_NEW_WINDOW, content::NativeWebKeyboardEvent(
  92           ui::ET_KEY_PRESSED, false, ui::VKEY_N, ui::EF_CONTROL_DOWN, 0)));
  93   EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
  94       IDC_CLOSE_TAB, content::NativeWebKeyboardEvent(
  95           ui::ET_KEY_PRESSED, false, ui::VKEY_W, ui::EF_CONTROL_DOWN, 0)));
  96   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
  97       IDC_FIND, content::NativeWebKeyboardEvent(
  98           ui::ET_KEY_PRESSED, false, ui::VKEY_F, ui::EF_CONTROL_DOWN, 0)));
  99 #endif  // USE_AURA
 100 }
 101
 102 TEST_F(BrowserCommandControllerTest, IsReservedCommandOrKeyIsApp) {
 103   browser()->app_name_ = "app";
 104   ASSERT_TRUE(browser()->is_app());
 105
 106   // When is_app(), no keys are reserved.
 107 #if defined(OS_CHROMEOS)
 108   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 109       IDC_BACK, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
 110                                                 ui::VKEY_F1, 0, 0)));
 111   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 112       IDC_FORWARD, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
 113                                                    ui::VKEY_F2, 0, 0)));
 114   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 115       IDC_RELOAD, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
 116                                                   ui::VKEY_F3, 0, 0)));
 117   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 118       -1, content::NativeWebKeyboardEvent(ui::ET_KEY_PRESSED, false,
 119                                           ui::VKEY_F4, 0, 0)));
 120 #endif  // OS_CHROMEOS
 121
 122 #if defined(USE_AURA)
 123   // The content::NativeWebKeyboardEvent constructor is available only when
 124   // USE_AURA is #defined.
 125   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 126       IDC_NEW_WINDOW, content::NativeWebKeyboardEvent(
 127           ui::ET_KEY_PRESSED, false, ui::VKEY_N, ui::EF_CONTROL_DOWN, 0)));
 128   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 129       IDC_CLOSE_TAB, content::NativeWebKeyboardEvent(
 130           ui::ET_KEY_PRESSED, false, ui::VKEY_W, ui::EF_CONTROL_DOWN, 0)));
 131   EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
 132       IDC_FIND, content::NativeWebKeyboardEvent(
 133           ui::ET_KEY_PRESSED, false, ui::VKEY_F, ui::EF_CONTROL_DOWN, 0)));
 134 #endif  // USE_AURA
 135 }
 136
 137 TEST_F(BrowserCommandControllerTest, IncognitoCommands) {
 138   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 139   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 140   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_SHOW_SIGNIN));
 141
 142   TestingProfile* testprofile = browser()->profile()->AsTestingProfile();
 143   EXPECT_TRUE(testprofile);
 144   testprofile->SetGuestSession(true);
 145   chrome::BrowserCommandController
 146     ::UpdateSharedCommandsForIncognitoAvailability(
 147       browser()->command_controller()->command_updater(), testprofile);
 148   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 149   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 150   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_SIGNIN));
 151
 152   testprofile->SetGuestSession(false);
 153   IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
 154                                       IncognitoModePrefs::FORCED);
 155   chrome::BrowserCommandController
 156     ::UpdateSharedCommandsForIncognitoAvailability(
 157       browser()->command_controller()->command_updater(), testprofile);
 158   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 159   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 160   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_SIGNIN));
 161 }
 162
 163 TEST_F(BrowserCommandControllerTest, AppFullScreen) {
 164   // Enable for tabbed browser.
 165   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
 166
 167   // Enabled for app windows.
 168   browser()->app_name_ = "app";
 169   ASSERT_TRUE(browser()->is_app());
 170   browser()->command_controller()->FullscreenStateChanged();
 171   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
 172 }
 173
 174 TEST_F(BrowserCommandControllerTest, OldAvatarMenuEnabledForOneOrMoreProfiles) {
 175   if (!profiles::IsMultipleProfilesEnabled())
 176     return;
 177
 178   // The command line is reset at the end of every test by the test suite.
 179   switches::DisableNewAvatarMenuForTesting(
 180       base::CommandLine::ForCurrentProcess());
 181   ASSERT_FALSE(switches::IsNewAvatarMenu());
 182
 183   TestingProfileManager testing_profile_manager(
 184       TestingBrowserProcess::GetGlobal());
 185   ASSERT_TRUE(testing_profile_manager.SetUp());
 186   ProfileManager* profile_manager = testing_profile_manager.profile_manager();
 187
 188   chrome::BrowserCommandController command_controller(browser());
 189   const CommandUpdater* command_updater = command_controller.command_updater();
 190
 191   bool enabled = true;
 192 #if defined(OS_CHROMEOS)
 193   // Chrome OS uses system tray menu to handle multi-profiles.
 194   enabled = false;
 195 #endif
 196
 197   testing_profile_manager.CreateTestingProfile("p1");
 198   ASSERT_EQ(1U, profile_manager->GetNumberOfProfiles());
 199   EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 200
 201   testing_profile_manager.CreateTestingProfile("p2");
 202   ASSERT_EQ(2U, profile_manager->GetNumberOfProfiles());
 203   EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 204
 205   testing_profile_manager.DeleteTestingProfile("p1");
 206   ASSERT_EQ(1U, profile_manager->GetNumberOfProfiles());
 207   EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 208
 209   testing_profile_manager.DeleteTestingProfile("p2");
 210 }
 211
 212 TEST_F(BrowserCommandControllerTest, NewAvatarMenuEnabledWhenOnlyOneProfile) {
 213   if (!profiles::IsMultipleProfilesEnabled())
 214     return;
 215
 216   // The command line is reset at the end of every test by the test suite.
 217   switches::EnableNewAvatarMenuForTesting(
 218       base::CommandLine::ForCurrentProcess());
 219
 220   TestingProfileManager testing_profile_manager(
 221       TestingBrowserProcess::GetGlobal());
 222   ASSERT_TRUE(testing_profile_manager.SetUp());
 223   ProfileManager* profile_manager = testing_profile_manager.profile_manager();
 224
 225   chrome::BrowserCommandController command_controller(browser());
 226   const CommandUpdater* command_updater = command_controller.command_updater();
 227
 228   testing_profile_manager.CreateTestingProfile("p1");
 229   ASSERT_EQ(1U, profile_manager->GetNumberOfProfiles());
 230 #if defined(OS_CHROMEOS)
 231   // Chrome OS uses system tray menu to handle multi-profiles.
 232   EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 233 #else
 234   EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 235 #endif
 236   testing_profile_manager.DeleteTestingProfile("p1");
 237 }
 238
 239 TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysDisabledInIncognitoMode) {
 240   if (!profiles::IsMultipleProfilesEnabled())
 241     return;
 242
 243   // Set up a profile with an off the record profile.
 244   TestingProfile::Builder normal_builder;
 245   scoped_ptr<TestingProfile> original_profile = normal_builder.Build();
 246
 247   // Create a new browser based on the off the record profile.
 248   Browser::CreateParams profile_params(
 249       original_profile->GetOffTheRecordProfile(), chrome::GetActiveDesktop());
 250   scoped_ptr<Browser> otr_browser(
 251       chrome::CreateBrowserWithTestWindowForParams(&profile_params));
 252
 253   chrome::BrowserCommandController command_controller(otr_browser.get());
 254   const CommandUpdater* command_updater = command_controller.command_updater();
 255
 256   // Both the old style and the new style avatar menu should be disabled.
 257   EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 258   if (switches::IsNewAvatarMenu()) {
 259     switches::DisableNewAvatarMenuForTesting(
 260         base::CommandLine::ForCurrentProcess());
 261   } else {
 262     switches::EnableNewAvatarMenuForTesting(
 263         base::CommandLine::ForCurrentProcess());
 264   }
 265   EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
 266   // The command line is reset at the end of every test by the test suite.
 267 }
 268
 269 //////////////////////////////////////////////////////////////////////////////
 270
 271 // A test browser window that can toggle fullscreen state.
 272 class FullscreenTestBrowserWindow : public TestBrowserWindow {
 273  public:
 274   FullscreenTestBrowserWindow() : fullscreen_(false) {}
 275   ~FullscreenTestBrowserWindow() override {}
 276
 277   // TestBrowserWindow overrides:
 278   bool ShouldHideUIForFullscreen() const override { return fullscreen_; }
 279   bool IsFullscreen() const override { return fullscreen_; }
 280   void EnterFullscreen(const GURL& url,
 281                        ExclusiveAccessBubbleType type,
 282                        bool with_toolbar) override {
 283     fullscreen_ = true;
 284   }
 285   void ExitFullscreen() override { fullscreen_ = false; }
 286
 287  private:
 288   bool fullscreen_;
 289
 290   DISALLOW_COPY_AND_ASSIGN(FullscreenTestBrowserWindow);
 291 };
 292
 293 // Test that uses FullscreenTestBrowserWindow for its window.
 294 class BrowserCommandControllerFullscreenTest
 295     : public BrowserWithTestWindowTest {
 296  public:
 297   BrowserCommandControllerFullscreenTest() {}
 298   ~BrowserCommandControllerFullscreenTest() override {}
 299
 300   // BrowserWithTestWindowTest overrides:
 301   BrowserWindow* CreateBrowserWindow() override {
 302     return new FullscreenTestBrowserWindow;
 303   }
 304
 305  private:
 306   DISALLOW_COPY_AND_ASSIGN(BrowserCommandControllerFullscreenTest);
 307 };
 308
 309 TEST_F(BrowserCommandControllerFullscreenTest,
 310        UpdateCommandsForFullscreenMode) {
 311   // Defaults for a tabbed browser.
 312   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPEN_CURRENT_URL));
 313   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_AS_TAB));
 314   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_TOOLBAR));
 315   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_LOCATION));
 316   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_SEARCH));
 317   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_MENU_BAR));
 318   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_NEXT_PANE));
 319   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_PREVIOUS_PANE));
 320   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_BOOKMARKS));
 321   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_DEVELOPER_MENU));
 322 #if defined(GOOGLE_CHROME_BUILD)
 323   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FEEDBACK));
 324 #endif
 325   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 326   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 327   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_EDIT_SEARCH_ENGINES));
 328   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_VIEW_PASSWORDS));
 329   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ABOUT));
 330   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_SHOW_APP_MENU));
 331   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
 332
 333   // Simulate going fullscreen.
 334   chrome::ToggleFullscreenMode(browser());
 335   ASSERT_TRUE(browser()->window()->IsFullscreen());
 336   browser()->command_controller()->FullscreenStateChanged();
 337
 338   // Most commands are disabled in fullscreen.
 339   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_OPEN_CURRENT_URL));
 340   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_AS_TAB));
 341   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_TOOLBAR));
 342   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_LOCATION));
 343   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_SEARCH));
 344   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_MENU_BAR));
 345   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_NEXT_PANE));
 346   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_PREVIOUS_PANE));
 347   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_BOOKMARKS));
 348   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_DEVELOPER_MENU));
 349 #if defined(GOOGLE_CHROME_BUILD)
 350   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FEEDBACK));
 351 #endif
 352   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 353   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 354   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_EDIT_SEARCH_ENGINES));
 355   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_VIEW_PASSWORDS));
 356   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ABOUT));
 357   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_APP_MENU));
 358   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
 359
 360   // Exit fullscreen.
 361   chrome::ToggleFullscreenMode(browser());
 362   ASSERT_FALSE(browser()->window()->IsFullscreen());
 363   browser()->command_controller()->FullscreenStateChanged();
 364   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPEN_CURRENT_URL));
 365   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_AS_TAB));
 366   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_TOOLBAR));
 367   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_LOCATION));
 368   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_SEARCH));
 369   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_MENU_BAR));
 370   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_NEXT_PANE));
 371   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_PREVIOUS_PANE));
 372   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FOCUS_BOOKMARKS));
 373   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_DEVELOPER_MENU));
 374 #if defined(GOOGLE_CHROME_BUILD)
 375   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FEEDBACK));
 376 #endif
 377   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 378   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 379   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_EDIT_SEARCH_ENGINES));
 380   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_VIEW_PASSWORDS));
 381   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ABOUT));
 382   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_SHOW_APP_MENU));
 383   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
 384
 385   // Guest Profiles disallow some options.
 386   TestingProfile* testprofile = browser()->profile()->AsTestingProfile();
 387   EXPECT_TRUE(testprofile);
 388   testprofile->SetGuestSession(true);
 389
 390   browser()->command_controller()->FullscreenStateChanged();
 391   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
 392   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
 393 }
 394
 395 TEST_F(BrowserCommandControllerTest, IncognitoModeOnSigninAllowedPrefChange) {
 396   // Set up a profile with an off the record profile.
 397   scoped_ptr<TestingProfile> profile1 = TestingProfile::Builder().Build();
 398   Profile* profile2 = profile1->GetOffTheRecordProfile();
 399
 400   EXPECT_EQ(profile2->GetOriginalProfile(), profile1.get());
 401
 402   // Create a new browser based on the off the record profile.
 403   Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile(),
 404                                        chrome::GetActiveDesktop());
 405   scoped_ptr<Browser> browser2(
 406       chrome::CreateBrowserWithTestWindowForParams(&profile_params));
 407
 408   chrome::BrowserCommandController command_controller(browser2.get());
 409   const CommandUpdater* command_updater = command_controller.command_updater();
 410
 411   // Check that the SYNC_SETUP command is updated on preference change.
 412   EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SHOW_SYNC_SETUP));
 413   profile1->GetPrefs()->SetBoolean(prefs::kSigninAllowed, false);
 414   EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_SYNC_SETUP));
 415 }
 416
 417 TEST_F(BrowserCommandControllerTest, OnSigninAllowedPrefChange) {
 418   chrome::BrowserCommandController command_controller(browser());
 419   const CommandUpdater* command_updater = command_controller.command_updater();
 420
 421   // Check that the SYNC_SETUP command is updated on preference change.
 422   EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SHOW_SYNC_SETUP));
 423   profile()->GetPrefs()->SetBoolean(prefs::kSigninAllowed, false);
 424   EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_SYNC_SETUP));
 425 }