Fix Views web-modal dialog widget creation.
commit0483ec8a26befde2bcd0f30909284939bd166ec1
authormsw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 5 Jun 2014 03:15:06 +0000 (5 03:15 +0000)
committermsw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 5 Jun 2014 03:15:06 +0000 (5 03:15 +0000)
tree728fa18ff13ad16310c9a4469af3452f7d4d3fe2
parenta25664116cf216f0946ea3f60837ec207effa291
Fix Views web-modal dialog widget creation.

r272016 regressed web-modal dialog shadow styling.
Use CreateDialogWidget for dialog creation to fix that.
Only set SHADOW_TYPE_NONE for new-style dialogs there.
(removes the double border, consolidates dialog widget init)
Take WidgetDelegate for ConstrainedWebDialogDelegateViewViews.
Mark web-modals as ui::MODAL_TYPE_CHILD and child widgets.

Remove now unused Widget::CreateWindowAsFramelessChild.
(keep a copy for the system-modal captive portal dialog)
(that dialog is very odd, system-modal and "web-modal"?)

Add [Create|Show]WebModalDialogViews helper functions.
Use these for c/b/ui/views web-modal dialog init/show.
(cannot be used by c/b/chromeos, so cleanup less there)
Cleanup includes, cached widgets, using statements, etc.

BUG=376646,378970
TEST=Views tab-modal dialogs appear as expected.
R=wittman@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/301393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274991 0039d316-1c4b-4281-b951-d872f2087c98
31 files changed:
chrome/browser/chromeos/attestation/platform_verification_dialog.cc
chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc
chrome/browser/ui/views/autofill/autofill_dialog_views.cc
chrome/browser/ui/views/autofill/autofill_dialog_views.h
chrome/browser/ui/views/collected_cookies_views.cc
chrome/browser/ui/views/collected_cookies_views.h
chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
chrome/browser/ui/views/constrained_window_views.cc
chrome/browser/ui/views/constrained_window_views.h
chrome/browser/ui/views/constrained_window_views_browsertest.cc
chrome/browser/ui/views/desktop_media_picker_views.cc
chrome/browser/ui/views/download/download_danger_prompt_views.cc
chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.cc
chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.h
chrome/browser/ui/views/login_prompt_views.cc
chrome/browser/ui/views/pdf_password_dialog.cc
chrome/browser/ui/views/signed_certificate_timestamps_views.cc
chrome/browser/ui/views/ssl_client_certificate_selector.cc
chrome/browser/ui/views/ssl_client_certificate_selector.h
chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
chrome/browser/ui/views/tab_modal_confirm_dialog_views.h
chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
ui/views/widget/desktop_aura/desktop_screen_position_client.cc
ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc
ui/views/widget/widget.cc
ui/views/widget/widget.h
ui/views/window/dialog_delegate.cc
ui/views/window/dialog_delegate.h