| commit | d99095034d2e88897ae82c8353f3327a3a1d03a5 | |
| author | kalman <kalman@chromium.org> | |
| Mon, 13 Apr 2015 23:02:17 +0000 (13 16:02 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 13 Apr 2015 23:02:52 +0000 (13 23:02 +0000) | ||
| tree | 2e95876dfa630023c3ad100f86c95947164110df | treesnapshot (tar.gz zip) |
| parent | 8c8162e4c9d3cc2310cc290b10b8d509f876b607 | commitdiff |
Move the event attach/detach logic on unload from event.js to
event_bindings.cc.
This removes one of the reasons to call into JavaScript on context unload,
which can crash. It's also more robust; it's confusing trying to maintain a
data structure in JavaScript which reflects C++ state, which contributes to
bugs like crbug.com/474718.
Also clean up and formalise the script context invalidation system: CHECK
rather than guarding against multiple invalidations, only invalidate script
context related member variables, add an invalidation observer interface.
BUG=474718, 475536
R=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1074273002
Cr-Commit-Position: refs/heads/master@{#324933}
event_bindings.cc.
This removes one of the reasons to call into JavaScript on context unload,
which can crash. It's also more robust; it's confusing trying to maintain a
data structure in JavaScript which reflects C++ state, which contributes to
bugs like crbug.com/474718.
Also clean up and formalise the script context invalidation system: CHECK
rather than guarding against multiple invalidations, only invalidate script
context related member variables, add an invalidation observer interface.
BUG=474718, 475536
R=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1074273002
Cr-Commit-Position: refs/heads/master@{#324933}
22 files changed: