maint: rmdir: also use DS_... constants here
[coreutils.git] / cfg.mk
blob8957cca34b389207e121d9f5dda354582a2b0f43
1 # Customize maint.mk -*- makefile -*-
2 # Copyright (C) 2003-2022 Free Software Foundation, Inc.
4 # This program is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License as published by
6 # the Free Software Foundation, either version 3 of the License, or
7 # (at your option) any later version.
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
14 # You should have received a copy of the GNU General Public License
15 # along with this program. If not, see <https://www.gnu.org/licenses/>.
17 # Used in maint.mk's web-manual rule
18 manual_title = Core GNU utilities
20 # Use the direct link. This is guaranteed to work immediately, while
21 # it can take a while for the faster mirror links to become usable.
22 url_dir_list = https://ftp.gnu.org/gnu/$(PACKAGE)
24 # Exclude bundled external projects from syntax checks
25 VC_LIST_ALWAYS_EXCLUDE_REGEX = src/blake2/.*$$
27 # Tests not to run as part of "make distcheck".
28 local-checks-to-skip = \
29 sc_proper_name_utf8_requires_ICONV \
30 sc_indent
32 # Tools used to bootstrap this package, used for "announcement".
33 bootstrap-tools = autoconf,automake,gnulib,bison
35 # Now that we have better tests, make this the default.
36 export VERBOSE = yes
38 # Comparing tarball sizes compressed using different xz presets, we see that
39 # an -8e-compressed tarball is only 9KiB larger than the -9e-compressed one.
40 # Using -8e is preferred, since that lets the decompression process use half
41 # the memory (32MiB rather than 64MiB).
42 # $ for i in {7,8,9}{e,}; do \
43 # (n=$(xz -$i < coreutils-8.15*.tar|wc -c);echo $n $i) & done |sort -nr
44 # 5129388 7
45 # 5036524 7e
46 # 5017476 8
47 # 5010604 9
48 # 4923016 8e
49 # 4914152 9e
50 export XZ_OPT = -8e
52 old_NEWS_hash = f365e0cf2c7890c617df6abe70615fce
54 # Add an exemption for sc_makefile_at_at_check.
55 _makefile_at_at_check_exceptions = ' && !/^cu_install_prog/ && !/dynamic-dep/'
57 # Our help-version script is in a slightly different location.
58 _hv_file ?= $(srcdir)/tests/misc/help-version
60 # Ensure that the list of O_ symbols used to compute O_FULLBLOCK is complete.
61 dd = $(srcdir)/src/dd.c
62 sc_dd_O_FLAGS:
63 @rm -f $@.1 $@.2
64 @{ echo O_FULLBLOCK; echo O_NOCACHE; \
65 perl -nle '/^ +\| (O_\w*)$$/ and print $$1' $(dd); } | sort > $@.1
66 @{ echo O_NOFOLLOW; perl -nle '/{"[a-z]+",\s*(O_\w+)},/ and print $$1' \
67 $(dd); } | sort > $@.2
68 @diff -u $@.1 $@.2; diff=$$?; \
69 rm -f $@.1 $@.2; \
70 test "$$diff" = 0 \
71 || { echo '$(ME): $(dd) has inconsistent O_ flag lists'>&2; \
72 exit 1; }
74 # Ensure that dd's definition of LONGEST_SYMBOL stays in sync
75 # with the strings from the two affected variables.
76 dd_c = $(srcdir)/src/dd.c
77 sc_dd_max_sym_length:
78 ifneq ($(wildcard $(dd_c)),)
79 @len=$$( (sed -n '/conversions\[] =$$/,/^};/p' $(dd_c);\
80 sed -n '/flags\[] =$$/,/^};/p' $(dd_c) ) \
81 |sed -n '/"/s/^[^"]*"\([^"]*\)".*/\1/p'| wc -L);\
82 max=$$(sed -n '/^#define LONGEST_SYMBOL /s///p' $(dd_c) \
83 |tr -d '"' | wc -L); \
84 if test "$$len" = "$$max"; then :; else \
85 echo 'dd.c: LONGEST_SYMBOL is not longest' 1>&2; \
86 exit 1; \
88 endif
90 # Many m4 macros names once began with 'jm_'.
91 # On 2004-04-13, they were all changed to start with gl_ instead.
92 # Make sure that none are inadvertently reintroduced.
93 sc_prohibit_jm_in_m4:
94 @grep -nE 'jm_[A-Z]' \
95 $$($(VC_LIST) m4 |grep '\.m4$$'; echo /dev/null) && \
96 { echo '$(ME): do not use jm_ in m4 macro names' \
97 1>&2; exit 1; } || :
99 # Ensure that each root-requiring test is run via the "check-root" rule.
100 sc_root_tests:
101 @t1=sc-root.expected; t2=sc-root.actual; \
102 grep -nl '^ *require_root_$$' `$(VC_LIST) tests` | \
103 sed 's|.*/tests/|tests/|' | sort > $$t1; \
104 for t in $(all_root_tests); do echo $$t; done | sort > $$t2; \
105 st=0; diff -u $$t1 $$t2 || st=1; \
106 rm -f $$t1 $$t2; \
107 exit $$st
109 # Ensure that all version-controlled test cases are listed in $(all_tests).
110 sc_tests_list_consistency:
111 @bs="\\"; \
112 test_extensions_rx=`echo $(TEST_EXTENSIONS) \
113 | sed -e "s/ /|/g" -e "s/$$bs./$$bs$$bs./g"`; \
115 for t in $(all_tests); do echo $$t; done; \
116 cd $(top_srcdir); \
117 $(SHELL) build-aux/vc-list-files tests \
118 | grep -Ev '^tests/(factor/(run|create-test)|init)\.sh$$' \
119 | $(EGREP) "$$test_extensions_rx\$$"; \
120 } | sort | uniq -u | grep . && exit 1; :
122 # Ensure that all version-controlled test scripts are executable.
123 sc_tests_executable:
124 @set -o noglob 2>/dev/null || set -f; \
125 cd $(srcdir); \
126 find_ext="-name '' "`printf -- "-o -name *%s " $(TEST_EXTENSIONS)`;\
127 find $(srcdir)/tests/ \( $$find_ext \) \! -perm -u+x -print \
128 | { sed "s|^$(srcdir)/||"; git ls-files $(srcdir)/tests/; } \
129 | sort | uniq -d \
130 | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
131 && exit 1; :
133 # Ensure all gnulib patches apply cleanly
134 sc_ensure_gl_diffs_apply_cleanly:
135 @find $(srcdir)/gl/ -name '*.diff' | while read p; do \
136 patch --fuzz=0 -f -s -d $(srcdir)/gnulib/ -p1 --dry-run < "$$p" >&2 \
137 || { echo "$$p" >&2; echo 'To refresh all gl patches run:' \
138 'make refresh-gnulib-patches' >&2; exit 1; } \
139 done
141 # Avoid :>file which doesn't propagate errors
142 sc_prohibit_colon_redirection:
143 @cd $(srcdir)/tests && GIT_PAGER= git grep -En ': *>.*\|\|' \
144 && { echo '$(ME): '"The leading colon in :> will hide errors" >&2; \
145 exit 1; } \
146 || :
148 # Ensure emit_mandatory_arg_note() is called if required
149 sc_ensure_emit_mandatory_arg_note:
150 @cd $(srcdir)/src && GIT_PAGER= git \
151 grep -l -- '^ *-[^-].*--.*[^[]=' *.c \
152 | xargs grep -L emit_mandatory_arg_note | grep . \
153 && { echo '$(ME): '"emit_mandatory_arg_note() missing" 1>&2; \
154 exit 1; } || :
156 # Create a list of regular expressions matching the names
157 # of files included from system.h. Exclude a couple.
158 .re-list:
159 @sed -n '/^# *include /s///p' $(srcdir)/src/system.h \
160 | grep -Ev 'sys/(param|file)\.h' \
161 | sed 's/ .*//;;s/^["<]/^# *include [<"]/;s/\.h[">]$$/\\.h[">]/' \
162 > $@-t
163 @mv $@-t $@
165 define gl_trap_
166 Exit () { set +e; (exit $$1); exit $$1; }; \
167 for sig in 1 2 3 13 15; do \
168 eval "trap 'Exit $$(expr $$sig + 128)' $$sig"; \
169 done
170 endef
172 # Files in src/ should not include directly any of
173 # the headers already included via system.h.
174 sc_system_h_headers: .re-list
175 @if test -f $(srcdir)/src/system.h; then \
176 trap 'rc=$$?; rm -f .re-list; exit $$rc' 0; \
177 $(gl_trap_); \
178 grep -nE -f .re-list \
179 $$($(VC_LIST_EXCEPT) | grep -E '^($(srcdir)/)?src/') \
180 && { echo '$(ME): the above are already included via system.h'\
181 1>&2; exit 1; } || :; \
184 # Files in src/ should not use '%s' notation in format strings,
185 # i.e., single quotes around %s (or similar) should be avoided.
186 sc_prohibit_quotes_notation:
187 @cd $(srcdir)/src && GIT_PAGER= git grep -n "\".*[\`']%s'.*\"" *.c \
188 && { echo '$(ME): '"Use quote() to avoid quoted '%s' notation" 1>&2; \
189 exit 1; } \
190 || :
192 # Files in src/ should quote all strings in error() output, so that
193 # unexpected input chars like \r etc. don't corrupt the error.
194 # In edge cases this can be avoided by putting the format string
195 # on a separate line to the arguments, or the arguments in parenthesis.
196 sc_error_quotes:
197 @cd $(srcdir)/src && GIT_PAGER= git grep -n 'error *(.*%s.*, [^(]*);$$'\
198 *.c | grep -v ', q' \
199 && { echo '$(ME): '"Use quote() for error string arguments" 1>&2; \
200 exit 1; } \
201 || :
203 # Files in src/ should quote all file names in error() output
204 # using quotef(), to provide quoting only when necessary,
205 # but also provide better support for copy and paste when used.
206 sc_error_shell_quotes:
207 @cd $(srcdir)/src && \
208 { GIT_PAGER= git grep -E \
209 'error \(.*%s[:"], .*(name|file)[^"]*\);$$' *.c; \
210 GIT_PAGER= git grep -E \
211 ' quote[ _].*file' *.c; } \
212 | grep -Ev '(quotef|q[^ ]*name)' \
213 && { echo '$(ME): '"Use quotef() for colon delimited names" 1>&2; \
214 exit 1; } \
215 || :
217 # Files in src/ should quote all file names in error() output
218 # using quoteaf() when the name is separated with spaces,
219 # to distinguish the file name at issue and
220 # to provide better support for copy and paste.
221 sc_error_shell_always_quotes:
222 @cd $(srcdir)/src && GIT_PAGER= git grep -E \
223 'error \(.*[^:] %s[ "].*, .*(name|file)[^"]*\);$$' \
224 *.c | grep -Ev '(quoteaf|q[^ ]*name)' \
225 && { echo '$(ME): '"Use quoteaf() for space delimited names" 1>&2; \
226 exit 1; } \
227 || :
228 @cd $(srcdir)/src && GIT_PAGER= git grep -E -A1 \
229 'error \([^%]*[^:] %s[ "]' *.c | grep 'quotef' \
230 && { echo '$(ME): '"Use quoteaf() for space delimited names" 1>&2; \
231 exit 1; } \
232 || :
234 # Usage of error() with an exit constant, should instead use die(),
235 # as that avoids warnings and may generate better code, due to being apparent
236 # to the compiler that it doesn't return.
237 sc_die_EXIT_FAILURE:
238 @cd $(srcdir)/src && GIT_PAGER= git grep -E \
239 'error \([^?]*EXIT_' \
240 && { echo '$(ME): '"Use die() instead of error" 1>&2; \
241 exit 1; } \
242 || :
244 # Avoid unstyled quoting to internal slots and thus destined for diagnostics
245 # as that can leak unescaped control characters to the output, when using
246 # the default "literal" quoting style.
247 # Instead use quotef(), or quoteaf() or in edge cases quotearg_n_style_colon().
248 # A more general PCRE would be @prohibit='quotearg_.*(?!(style|buffer))'
249 sc_prohibit-quotearg:
250 @prohibit='quotearg(_n)?(|_colon|_char|_mem) ' \
251 in_vc_files='\.c$$' \
252 halt='Unstyled diagnostic quoting detected' \
253 $(_sc_search_regexp)
255 sc_prohibit-skip:
256 @prohibit='\|\| skip ' \
257 halt='Use skip_ not skip' \
258 $(_sc_search_regexp)
260 sc_sun_os_names:
261 @grep -nEi \
262 'solaris[^[:alnum:]]*2\.(7|8|9|[1-9][0-9])|sunos[^[:alnum:]][6-9]' \
263 $$($(VC_LIST_EXCEPT)) && \
264 { echo '$(ME): found misuse of Sun OS version numbers' 1>&2; \
265 exit 1; } || :
267 # Ensure that the list of programs and author names is accurate.
268 # We need a UTF8 locale. If a lack of locale support or a missing
269 # translation inhibits printing of UTF-8 names, just skip this test.
270 au_dotdot = authors-dotdot
271 au_actual = authors-actual
272 sc_check-AUTHORS: $(all_programs)
273 @locale=en_US.UTF-8; \
274 LC_ALL=$$locale ./src/factor --version \
275 | grep ' Torbjorn ' > /dev/null \
276 && { echo "$@: skipping this check"; exit 0; }; \
277 rm -f $(au_actual) $(au_dotdot); \
278 for i in `ls $(all_programs) \
279 | sed -e 's,^src/,,' -e 's,$(EXEEXT)$$,,' \
280 | sed /libstdbuf/d \
281 | $(ASSORT) -u`; do \
282 test "$$i" = '[' && continue; \
283 exe=$$i; \
284 if test "$$i" = install; then \
285 exe=ginstall; \
286 elif test "$$i" = test; then \
287 exe='['; \
288 fi; \
289 LC_ALL=$$locale ./src/$$exe --version \
290 | perl -0 -p -e 's/,\n/, /gm' \
291 | sed -n -e '/Written by /{ s//'"$$i"': /;' \
292 -e 's/,* and /, /; s/\.$$//; p; }'; \
293 done > $(au_actual) && \
294 sed -n '/^[^ ][^ ]*:/p' $(srcdir)/AUTHORS > $(au_dotdot) \
295 && diff $(au_actual) $(au_dotdot) \
296 && rm -f $(au_actual) $(au_dotdot)
298 # Each program with a non-ASCII author name must link with LIBICONV.
299 sc_check-I18N-AUTHORS:
300 @cd $(srcdir)/src && \
301 for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
302 grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
303 > /dev/null \
304 || { echo "$(ME): link rules for $$i do not include" \
305 '$$(LIBICONV)' 1>&2; exit 1; }; \
306 done
308 # Disallow the C99 printf size specifiers %z and %j as they're not portable.
309 # The gnulib printf replacement does support them, however the printf
310 # replacement is not currently explicitly depended on by the gnulib error()
311 # module for example. Also we use fprintf() in a few places to output simple
312 # formats but don't use the gnulib module as it is seen as overkill at present.
313 # We'd have to adjust the above gnulib items before disabling this.
314 sc_prohibit-c99-printf-format:
315 @cd $(srcdir)/src && GIT_PAGER= git grep -n '%[0*]*[jz][udx]' *.c \
316 && { echo '$(ME): Use PRI*MAX instead of %j or %z' 1>&2; exit 1; } \
317 || :
319 # Ensure the alternative __attribute (keyword) form isn't used as
320 # that form is not elided where required. Also ensure that we don't
321 # directly use attributes already defined by gnulib.
322 # TODO: move the check for _GL... attributes to gnulib.
323 sc_prohibit-gl-attributes:
324 @prohibit='__attribute |__(unused|pure|const)__' \
325 in_vc_files='\.[ch]$$' \
326 halt='Use _GL... attribute macros' \
327 $(_sc_search_regexp)
329 # Prefer the const declaration form, with const following the type
330 sc_prohibit-const-char:
331 @prohibit='const char \*' \
332 in_vc_files='\.[ch]$$' \
333 halt='Use char const *, not const char *' \
334 $(_sc_search_regexp)
336 # Look for lines longer than 80 characters, except omit:
337 # - urls
338 # - the fdl.texi file copied from gnulib,
339 # - the help2man script copied from upstream,
340 # - tests involving long checksum lines, and
341 # - the 'pr' test cases.
342 FILTER_LONG_LINES = \
343 \|^[^:]*NEWS:.*https\{,1\}://| d; \
344 \|^[^:]*doc/fdl.texi:| d; \
345 \|^[^:]*man/help2man:| d; \
346 \|^[^:]*tests/misc/sha[0-9]*sum.*\.pl[-:]| d; \
347 \|^[^:]*tests/pr/|{ \|^[^:]*tests/pr/pr-tests:| !d; };
348 sc_long_lines:
349 @wc -L /dev/null >/dev/null 2>/dev/null \
350 || { echo "$@: skipping: wc -L not supported"; exit 0; }; \
351 sed -r 1q /dev/null 2>/dev/null \
352 || { echo "$@: skipping: sed -r not supported"; exit 0; }; \
353 files=$$($(VC_LIST_EXCEPT) | xargs wc -L | sed -rn '/ total$$/d;\
354 s/^ *(8[1-9]|9[0-9]|[0-9]{3,}) //p'); \
355 halt='line(s) with more than 80 characters; reindent'; \
356 for file in $$files; do \
357 expand $$file | grep -nE '^.{80}.' | \
358 sed -e "s|^|$$file:|" -e '$(FILTER_LONG_LINES)'; \
359 done | grep . && { msg="$$halt" $(_sc_say_and_exit) } || :
361 # Option descriptions should not start with a capital letter.
362 # One could grep source directly as follows:
363 # grep -E " {2,6}-.*[^.] [A-Z][a-z]" $$($(VC_LIST_EXCEPT) | grep '\.c$$')
364 # but that would miss descriptions not on the same line as the -option.
365 sc_option_desc_uppercase: $(ALL_MANS)
366 @grep '^\\fB\\-' -A1 man/*.1 | LC_ALL=C grep '\.1.[A-Z][a-z]' \
367 && { echo 1>&2 '$@: found initial capitals in --help'; exit 1; } || :
369 # Ensure all man/*.[1x] files are present.
370 sc_man_file_correlation: check-x-vs-1 check-programs-vs-x
372 # Ensure that for each .x file in the 'man/' subdirectory, there is a
373 # corresponding .1 file in the definition of $(EXTRA_MANS).
374 # But since that expansion usually lacks programs like arch and hostname,
375 # add them here manually.
376 .PHONY: check-x-vs-1
377 check-x-vs-1:
378 @PATH=./src$(PATH_SEPARATOR)$$PATH; export PATH; \
379 t=$@-t; \
380 (cd $(srcdir)/man && ls -1 *.x) \
381 | sed 's/\.x$$//' | $(ASSORT) > $$t; \
382 (echo $(patsubst man/%,%,$(ALL_MANS)) \
383 | tr -s ' ' '\n' | sed 's/\.1$$//') \
384 | $(ASSORT) -u | diff - $$t || { rm $$t; exit 1; }; \
385 rm $$t
387 # Ensure that non-trivial .x files in the 'man/' subdirectory,
388 # i.e., files exceeding a line count of 20 or a byte count of 1000,
389 # contain a Copyright notice.
390 .PHONY: sc_man_check_x_copyright
391 sc_man_check_x_copyright:
392 @status=0; \
393 cd $(srcdir) && wc -cl man/*.x | head -n-1 \
394 | awk '$$1 >= 20 || $$2 >= 1000 {print $$3}' \
395 | xargs grep -L 'Copyright .* Free Software Foundation' \
396 | grep . \
397 && { echo 1>&2 '$@: exceeding file size/line count limit' \
398 '- please add a copyright note'; status=1; }; \
399 exit $$status
401 # Writing a portable rule to generate a manpage like '[.1' would be
402 # a nightmare, so filter that out.
403 all-progs-but-lbracket = $(filter-out [,$(patsubst src/%,%,$(all_programs)))
405 # Ensure that for each coreutils program there is a corresponding
406 # '.x' file in the 'man/' subdirectory.
407 .PHONY: check-programs-vs-x
408 check-programs-vs-x:
409 @status=0; \
410 for p in dummy $(all-progs-but-lbracket); do \
411 case $$p in *.so) continue;; esac; \
412 test $$p = dummy && continue; \
413 test $$p = ginstall && p=install || : ; \
414 test -f $(srcdir)/man/$$p.x \
415 || { echo missing $$p.x 1>&2; status=1; }; \
416 done; \
417 exit $$status
419 # Ensure we can check out on case insensitive file systems
420 sc_case_insensitive_file_names: src/uniq
421 @git -C $(srcdir) ls-files | sort -f | src/uniq -Di | grep . && \
422 { echo "$(ME): the above file(s) conflict on case insensitive" \
423 " file systems" 1>&2; exit 1; } || :
425 # Ensure that the end of each release's section is marked by two empty lines.
426 sc_NEWS_two_empty_lines:
427 @sed -n 4,/Noteworthy/p $(srcdir)/NEWS \
428 | perl -n0e '/(^|\n)\n\n\* Noteworthy/ or exit 1' \
429 || { echo '$(ME): use two empty lines to separate NEWS sections' \
430 1>&2; exit 1; } || :
432 # With split lines, don't leave an operator at end of line.
433 # Instead, put it on the following line, where it is more apparent.
434 # Don't bother checking for "*" at end of line, since it provokes
435 # far too many false positives, matching constructs like "TYPE *".
436 # Similarly, omit "=" (initializers).
437 binop_re_ ?= [-/+^!<>]|[-/+*^!<>=]=|&&?|\|\|?|<<=?|>>=?
438 sc_prohibit_operator_at_end_of_line:
439 @prohibit='. ($(binop_re_))$$' \
440 in_vc_files='\.[chly]$$' \
441 halt='found operator at end of line' \
442 $(_sc_search_regexp)
444 # Partial substitutes for GNU extensions \< and \> in regexps.
445 begword = (^|[^_[:alnum:]])
446 endword = ($$|[^_[:alnum:]])
448 # Don't use address of "stat" or "lstat" functions
449 sc_prohibit_stat_macro_address:
450 @prohibit='$(begword)l?stat '':|&l?stat$(endword)' \
451 halt='stat() and lstat() may be function-like macros' \
452 $(_sc_search_regexp)
454 # Ensure that date's --help output stays in sync with the info
455 # documentation for GNU strftime. The only exception is %N and %q,
456 # which date accepts but GNU strftime does not.
458 # "info foo" fails with error, but not "info foo >/dev/null".
459 extract_char = sed 's/^[^%][^%]*%\(.\).*/\1/'
460 sc_strftime_check:
461 @if test -f $(srcdir)/src/date.c; then \
462 if info libc date calendar format 2>/dev/null | \
463 grep "^ *['\`]%.'$$" >$@-tmp; then \
464 { echo N; echo q; $(extract_char) $@-tmp; }| sort \
465 >$@-info; \
466 grep '^ %. ' $(srcdir)/src/date.c | sort \
467 | $(extract_char) > $@-src; \
468 diff -u $@-src $@-info || exit 1; \
469 else \
470 echo '$(ME): skipping $@: libc info not installed' 1>&2; \
471 fi; \
472 rm -f $@-info $@-src $@-tmp; \
475 # Indent only with spaces.
476 sc_prohibit_tab_based_indentation:
477 @prohibit='^ * ' \
478 halt='TAB in indentation; use only spaces' \
479 $(_sc_search_regexp)
481 # Enforce lowercase 'e' in "I.e.".
482 sc_prohibit_uppercase_id_est:
483 @prohibit='I\.E\.' \
484 halt='Uppercase "Id Est" abbreviation; use "I.e.," instead' \
485 $(_sc_search_regexp)
487 # Enforce double-space before "I.e." at the beginning of a sentence.
488 sc_ensure_dblspace_after_dot_before_id_est:
489 @prohibit='\. I\.e\.' \
490 halt='Single space after dot before "i.e."; use ". i.e." instead' \
491 $(_sc_search_regexp)
493 # Enforce comma after "i.e." (at least before a blank or at EOL).
494 sc_ensure_comma_after_id_est:
495 @prohibit='[Ii]\.e\.( |$$)' \
496 halt='Missing comma after "i.e."; use "i.e.," instead' \
497 $(_sc_search_regexp)
499 # The SEE ALSO section of a man page should not be terminated with
500 # a period. Check the first line after each "SEE ALSO" line in man/*.x:
501 sc_prohibit_man_see_also_period:
502 @grep -nB1 '\.$$' $$($(VC_LIST_EXCEPT) | grep 'man/.*\.x$$') \
503 | grep -A1 -e '-\[SEE ALSO]' | grep '\.$$' && \
504 { echo '$(ME): do not end "SEE ALSO" section with a period' \
505 1>&2; exit 1; } || :
507 # Don't use "indent-tabs-mode: nil" anymore. No longer needed.
508 sc_prohibit_emacs__indent_tabs_mode__setting:
509 @prohibit='^( *[*#] *)?indent-tabs-mode:' \
510 halt='use of emacs indent-tabs-mode: setting' \
511 $(_sc_search_regexp)
513 # Ensure that tests don't include a redundant fail=0.
514 sc_prohibit_fail_0:
515 @prohibit='$(begword)fail=0$(endword)' \
516 halt='fail=0 initialization' \
517 $(_sc_search_regexp)
519 # Ensure that tests don't use `cmd ... && fail=1` as that hides crashes.
520 # The "exclude" expression allows common idioms like `test ... && fail=1`
521 # and the 2>... portion allows commands that redirect stderr and so probably
522 # independently check its contents and thus detect any crash messages.
523 sc_prohibit_and_fail_1:
524 @prohibit='&& fail=1' \
525 exclude='(returns_|stat|kill|test |EGREP|grep|compare|2> *[^/])' \
526 halt='&& fail=1 detected. Please use: returns_ 1 ... || fail=1' \
527 in_vc_files='^tests/' \
528 $(_sc_search_regexp)
530 # Ensure that tests don't use `cmd ... || fail` as that's a noop.
531 sc_prohibit_or_fail:
532 @prohibit='\|\| fail$$' \
533 exclude=':#' \
534 halt='|| fail detected. Please use: || fail=1' \
535 in_vc_files='^tests/' \
536 $(_sc_search_regexp)
538 # Ensure that env vars are not passed through returns_ as
539 # that was seen to fail on FreeBSD /bin/sh at least
540 sc_prohibit_env_returns:
541 @prohibit='=[^ ]* returns_ ' \
542 exclude='_ returns_ ' \
543 halt='Passing env vars to returns_ is non portable' \
544 in_vc_files='^tests/' \
545 $(_sc_search_regexp)
547 # The mode part of a setfacl -m option argument must be three bytes long.
548 # I.e., an argument of user:bin:rw or user:bin:r will make Solaris 10's
549 # setfacl reject it with: "Unrecognized character found in mode field".
550 # Use hyphens to give it a length of 3: "...:rw-" or "...:r--".
551 sc_prohibit_short_facl_mode_spec:
552 @prohibit='$(begword)setfacl .*-m.*:.*:[rwx-]{1,2} ' \
553 halt='setfacl mode string length < 3; extend with hyphen(s)' \
554 $(_sc_search_regexp)
556 # Ensure that "stdio--.h" is used where appropriate.
557 sc_require_stdio_safer:
558 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
559 files=$$(grep -l '$(begword)freopen \?(' $$($(VC_LIST_EXCEPT) \
560 | grep '\.[ch]$$')); \
561 test -n "$$files" && grep -LE 'include "stdio--.h"' $$files \
562 | grep . && \
563 { echo '$(ME): the above files should use "stdio--.h"' \
564 1>&2; exit 1; } || :; \
565 else :; \
568 sc_prohibit_perl_hash_quotes:
569 @prohibit="\{'[A-Z_]+' *[=}]" \
570 halt="in Perl code, write \$$hash{KEY}, not \$$hash{'K''EY'}" \
571 $(_sc_search_regexp)
573 # Prefer xnanosleep over other less-precise sleep methods
574 sc_prohibit_sleep:
575 @prohibit='$(begword)(nano|u)?sleep \(' \
576 halt='prefer xnanosleep over other sleep interfaces' \
577 $(_sc_search_regexp)
579 # Use print_ver_ (from init.cfg), not open-coded $VERBOSE check.
580 sc_prohibit_verbose_version:
581 @prohibit='test "\$$VERBOSE" = yes && .* --version' \
582 halt='use the print_ver_ function instead...' \
583 $(_sc_search_regexp)
585 # Enforce print_ver_ tracking of dependencies
586 # Each coreutils specific program a test requires
587 # should be tagged by calling through env(1).
588 sc_env_test_dependencies:
589 @cd $(top_srcdir) && GIT_PAGER= git grep -E \
590 "env ($$(build-aux/gen-lists-of-programs.sh --list-progs | \
591 grep -vF '[' |paste -d'|' -s))" tests | \
592 sed "s/\([^:]\):.*env \([^)' ]*\).*/\1 \2/" | uniq | \
593 while read test prog; do \
594 printf '%s' $$test | grep -q '\.pl$$' && continue; \
595 grep -q "print_ver_.* $$prog" $$test \
596 || echo $$test should call: print_ver_ $$prog; \
597 done | grep . && exit 1 || :
599 # Use framework_failure_, not the old name without the trailing underscore.
600 sc_prohibit_framework_failure:
601 @prohibit='$(begword)framework_''failure$(endword)' \
602 halt='use framework_failure_ instead' \
603 $(_sc_search_regexp)
605 # Prohibit the use of `...` in tests/. Use $(...) instead.
606 sc_prohibit_test_backticks:
607 @prohibit='`' in_vc_files='^tests/' \
608 halt='use $$(...), not `...` in tests/' \
609 $(_sc_search_regexp)
611 # Ensure that compare is used to check empty files
612 # so that the unexpected contents are displayed
613 sc_prohibit_test_empty:
614 @prohibit='test -s.*&&' in_vc_files='^tests/' \
615 halt='use `compare /dev/null ...`, not `test -s ...` in tests/' \
616 $(_sc_search_regexp)
618 # Programs like sort, ls, expr use PROG_FAILURE in place of EXIT_FAILURE.
619 # Others, use the EXIT_CANCELED, EXIT_ENOENT, etc. macros defined in system.h.
620 # In those programs, ensure that EXIT_FAILURE is not used by mistake.
621 sc_some_programs_must_avoid_exit_failure:
622 @cd $(srcdir) \
623 && grep -nw EXIT_FAILURE \
624 $$(git grep -El '[^T]_FAILURE|EXIT_CANCELED' $(srcdir)/src) \
625 | grep -vE '= EXIT_FAILURE|return .* \?' | grep . \
626 && { echo '$(ME): do not use EXIT_FAILURE in the above' \
627 1>&2; exit 1; } || :
629 # Ensure that tests call the get_min_ulimit_v_ function if using ulimit -v
630 sc_prohibit_test_ulimit_without_require_:
631 @(git -C $(srcdir) grep -l get_min_ulimit_v_ tests; \
632 git -C $(srcdir) grep -l 'ulimit -v' tests) \
633 | sort | uniq -u | grep . && { echo "$(ME): the above test(s)"\
634 " should match get_min_ulimit_v_ with ulimit -v" 1>&2; exit 1; } || :
636 # Ensure that tests call the cleanup_ function if using background processes
637 sc_prohibit_test_background_without_cleanup_:
638 @(git -C $(srcdir) grep -El '( &$$|&[^&]*=\$$!)' tests; \
639 git -C $(srcdir) grep -l 'cleanup_()' tests | sed p) \
640 | sort | uniq -u | grep . && { echo "$(ME): the above test(s)"\
641 " should use cleanup_ for background processes" 1>&2; exit 1; } || :
643 # Ensure that tests call the print_ver_ function for programs which are
644 # actually used in that test.
645 sc_prohibit_test_calls_print_ver_with_irrelevant_argument:
646 @git -C $(srcdir) grep -w print_ver_ tests \
647 | sed 's#:print_ver_##' \
648 | { fail=0; \
649 while read file name; do \
650 for i in $$name; do \
651 case "$$i" in install) i=ginstall;; esac; \
652 grep -w "$$i" $$file|grep -vw print_ver_|grep -q . \
653 || { fail=1; \
654 echo "*** Test: $$file, offending: $$i." 1>&2; };\
655 done; \
656 done; \
657 test $$fail = 0 || exit 1; \
658 } || { echo "$(ME): the above test(s) call print_ver_ for" \
659 "program(s) they don't use" 1>&2; exit 1; }
661 # Exempt the contents of any usage function from the following.
662 _continued_string_col_1 = \
663 s/^usage .*?\n}//ms;/\\\n\w/ and print ("$$ARGV\n"),$$e=1;END{$$e||=0;exit $$e}
664 # Ding any source file that has a continued string with an alphabetic in the
665 # first column of the following line. We prohibit them because they usually
666 # trigger false positives in tools that try to map an arbitrary line number
667 # to the enclosing function name. Of course, very many strings do precisely
668 # this, *when they are part of the usage function*. That is why we exempt
669 # the contents of any function named "usage".
670 sc_prohibit_continued_string_alpha_in_column_1:
671 @perl -0777 -ne '$(_continued_string_col_1)' \
672 $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$') \
673 || { echo '$(ME): continued string with word in first column' \
674 1>&2; exit 1; } || :
675 # Use this to list offending lines:
676 # git ls-files |grep '\.[ch]$' | xargs \
677 # perl -n -0777 -e 's/^usage.*?\n}//ms;/\\\n\w/ and print "$ARGV\n"' \
678 # | xargs grep -A1 '\\$'|grep '\.[ch][:-][_a-zA-Z]'
681 ###########################################################
682 _p0 = \([^"'/]\|"\([^\"]\|[\].\)*"\|'\([^\']\|[\].\)*'
683 _pre = $(_p0)\|[/][^"'/*]\|[/]"\([^\"]\|[\].\)*"\|[/]'\([^\']\|[\].\)*'\)*
684 _pre_anchored = ^\($(_pre)\)
685 _comment_and_close = [^*]\|[*][^/*]\)*[*][*]*/
686 # help font-lock mode: '
688 # A sed expression that removes ANSI C and ISO C99 comments.
689 # Derived from the one in GNU gettext's 'moopp' preprocessor.
690 _sed_remove_comments = \
691 /[/][/*]/{ \
692 ta; \
693 :a; \
694 s,$(_pre_anchored)//.*,\1,; \
695 te; \
696 s,$(_pre_anchored)/[*]\($(_comment_and_close),\1 ,; \
697 ta; \
698 /^$(_pre)[/][*]/{ \
699 s,$(_pre_anchored)/[*].*,\1 ,; \
700 tu; \
701 :u; \
702 n; \
703 s,^\($(_comment_and_close),,; \
704 tv; \
705 s,^.*$$,,; \
706 bu; \
707 :v; \
708 }; \
709 :e; \
711 # Quote all single quotes.
712 _sed_rm_comments_q = $(subst ','\'',$(_sed_remove_comments))
713 # help font-lock mode: '
715 _space_before_paren_exempt =? \\n\\$$
716 _space_before_paren_exempt = \
717 (^ *\#|\\n\\$$|%s\(to %s|(date|group|character)\(s\))
718 # Ensure that there is a space before each open parenthesis in C code.
719 sc_space_before_open_paren:
720 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
721 fail=0; \
722 for c in $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); do \
723 sed '$(_sed_rm_comments_q)' $$c 2>/dev/null \
724 | grep -i '[[:alnum:]](' \
725 | grep -vE '$(_space_before_paren_exempt)' \
726 | grep . && { fail=1; echo "*** $$c"; }; \
727 done; \
728 test $$fail = 1 && \
729 { echo '$(ME): the above files lack a space-before-open-paren' \
730 1>&2; exit 1; } || :; \
731 else :; \
734 # Similar to the gnulib maint.mk rule for sc_prohibit_strcmp
735 # Use STREQ_LEN or STRPREFIX rather than comparing strncmp == 0, or != 0.
736 sc_prohibit_strncmp:
737 @prohibit='^[^#].*str''ncmp *\(' \
738 halt='use STREQ_LEN or STRPREFIX instead of str''ncmp' \
739 $(_sc_search_regexp)
741 # Enforce recommended preprocessor indentation style.
742 sc_preprocessor_indentation:
743 @if cppi --version >/dev/null 2>&1; then \
744 $(VC_LIST_EXCEPT) | grep '\.[ch]$$' | xargs cppi -a -c \
745 || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
746 exit 1; }; \
747 else \
748 echo '$(ME): skipping test $@: cppi not installed' 1>&2; \
751 # THANKS.in is a list of name/email pairs for people who are mentioned in
752 # commit logs (and generated ChangeLog), but who are not also listed as an
753 # author of a commit. Name/email pairs of commit authors are automatically
754 # extracted from the repository. As a very minor factorization, when
755 # someone who was initially listed only in THANKS.in later authors a commit,
756 # this rule detects that their pair may now be removed from THANKS.in.
757 sc_THANKS_in_duplicates:
758 @{ git -C $(srcdir) log --pretty=format:%aN | sort -u; \
759 cut -b-36 $(srcdir)/THANKS.in \
760 | sed '/^$$/,/^$$/!d;/^$$/d;s/ *$$//'; } \
761 | sort | uniq -d | grep . \
762 && { echo '$(ME): remove the above names from THANKS.in' \
763 1>&2; exit 1; } || :
765 # Ensure the contributor list stays sorted. However, if the system's
766 # en_US.UTF-8 locale data is erroneous, give a diagnostic and skip
767 # this test. This affects OS X, up to at least 10.11.6.
768 # Use our sort as other implementations may result in a different order.
769 sc_THANKS_in_sorted:
770 @printf 'a\n.b\n'|LC_ALL=en_US.UTF-8 src/sort -c 2> /dev/null \
771 && { \
772 sed '/^$$/,/^$$/!d;/^$$/d' $(srcdir)/THANKS.in > $@.1 && \
773 LC_ALL=en_US.UTF-8 src/sort -f -k1,1 $@.1 > $@.2 && \
774 diff -u $@.1 $@.2; diff=$$?; \
775 rm -f $@.1 $@.2; \
776 test "$$diff" = 0 \
777 || { echo '$(ME): THANKS.in is unsorted' 1>&2; exit 1; }; \
779 || { echo '$(ME): this system has erroneous locale data;' \
780 'skipping $@' 1>&2; }
782 # Look for developer diagnostics that are marked for translation.
783 # This won't find any for which devmsg's format string is on a separate line.
784 sc_marked_devdiagnostics:
785 @prohibit='$(begword)devmsg *\(.*_\(' \
786 halt='found marked developer diagnostic(s)' \
787 $(_sc_search_regexp)
789 # Ensure we keep hex constants as 4 or 8 bytes for consistency
790 # and so that make src/fs-magic-compare works consistently
791 sc_fs-magic-compare:
792 @sed -n 's|.*/\* \(0x[0-9A-Fa-f]\{1,\}\) .*\*/|\1|p' \
793 $(srcdir)/src/stat.c | grep -Ev '^0x([0-9A-F]{4}){1,2}$$' \
794 && { echo '$(ME): Constants in src/stat.c should be 4 or 8' \
795 'upper-case chars' 1>&2; exit 1; } || :
797 # Ensure gnulib generated files are ignored
798 # TODO: Perhaps augment gnulib-tool to do this in lib/.gitignore?
799 sc_gitignore_missing:
800 @{ sed -n '/^\/lib\/.*\.h$$/{p;p}' $(srcdir)/.gitignore; \
801 find lib -name '*.in*' ! -name '*~' ! -name 'sys_*' | \
802 sed 's|^|/|; s|_\(.*in\.h\)|/\1|; s/\.in//'; } | \
803 sort | uniq -u | grep . && { echo '$(ME): Add above' \
804 'entries to .gitignore' >&2; exit 1; } || :
806 # Flag redundant entries in .gitignore
807 # Disabled for now as too aggressive flagging
808 # entries like /lib/arg-nonnull.h
809 #sc_gitignore_redundant:
810 # @{ grep ^/lib $(srcdir)/.gitignore; \
811 # sed 's|^|/lib|' $(srcdir)/lib/.gitignore; } | \
812 # sort | uniq -d | grep . && { echo '$(ME): Remove above' \
813 # 'entries from .gitignore' >&2; exit 1; } || :
815 sc_prohibit-form-feed:
816 @prohibit=$$'\f' \
817 in_vc_files='\.[chly]$$' \
818 halt='Form Feed (^L) detected' \
819 $(_sc_search_regexp)
821 # Override the default Cc: used in generating an announcement.
822 announcement_Cc_ = $(translation_project_), \
823 coreutils@gnu.org, coreutils-announce@gnu.org
825 -include $(srcdir)/dist-check.mk
827 update-copyright-env = \
828 UPDATE_COPYRIGHT_FORCE=1 \
829 UPDATE_COPYRIGHT_USE_INTERVALS=2 \
830 UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79
832 # List syntax-check exemptions.
833 exclude_file_name_regexp--sc_space_tab = \
834 ^(tests/pr/|tests/misc/nl\.sh$$|gl/.*\.diff$$|man/help2man$$)
835 exclude_file_name_regexp--sc_bindtextdomain = \
836 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list|src/cksum)\.c$$
837 exclude_file_name_regexp--sc_trailing_blank = \
838 ^(tests/pr/|gl/.*\.diff$$|man/help2man)
839 exclude_file_name_regexp--sc_system_h_headers = \
840 ^src/((die|system|copy|chown-core|find-mount-point)\.h|make-prime-list\.c)$$
842 _src = (crctab|false|lbracket|ls-(dir|ls|vdir)|tac-pipe|uname-(arch|uname))
843 _gl_src = (xdecto.max|cl-strtold)
844 exclude_file_name_regexp--sc_require_config_h_first = \
845 (^lib/buffer-lcm\.c|gl/lib/$(_gl_src)\.c|src/$(_src)\.c)$$
846 exclude_file_name_regexp--sc_require_config_h = \
847 $(exclude_file_name_regexp--sc_require_config_h_first)
849 exclude_file_name_regexp--sc_po_check = ^(gl/|man/help2man)
850 exclude_file_name_regexp--sc_prohibit_always-defined_macros = \
851 ^src/(seq|remove)\.c$$
852 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^tests/pr/
853 exclude_file_name_regexp--sc_program_name = \
854 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list)\.c$$
855 exclude_file_name_regexp--sc_file_system = \
856 NEWS|^(init\.cfg|src/df\.c|tests/df/df-P\.sh|tests/df/df-output\.sh)$$
857 exclude_file_name_regexp--sc_prohibit_always_true_header_tests = \
858 ^m4/stat-prog\.m4$$
859 exclude_file_name_regexp--sc_prohibit_fail_0 = \
860 (^.*/git-hooks/commit-msg|^tests/init\.sh|Makefile\.am|\.mk|.*\.texi)$$
861 exclude_file_name_regexp--sc_prohibit_test_minus_ao = *\.texi$$
862 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^lib/euidaccess-stat\.c$$
864 # longlong.h is maintained elsewhere.
865 _ll = ^src/longlong\.h$$
866 exclude_file_name_regexp--sc_useless_cpp_parens = $(_ll)
867 exclude_file_name_regexp--sc_space_before_open_paren = $(_ll)
869 tbi_1 = ^tests/pr/|(\.mk|^man/help2man)$$
870 tbi_2 = ^scripts/git-hooks/(pre-commit|pre-applypatch|applypatch-msg)$$
871 tbi_3 = (GNU)?[Mm]akefile(\.am)?$$|$(_ll)
872 exclude_file_name_regexp--sc_prohibit_tab_based_indentation = \
873 $(tbi_1)|$(tbi_2)|$(tbi_3)
875 exclude_file_name_regexp--sc_preprocessor_indentation = \
876 ^(gl/lib/rand-isaac\.[ch]|gl/tests/test-rand-isaac\.c)$$|$(_ll)
877 exclude_file_name_regexp--sc_prohibit_stat_st_blocks = \
878 ^(src/system\.h|tests/du/2g\.sh)$$
880 exclude_file_name_regexp--sc_prohibit_continued_string_alpha_in_column_1 = \
881 ^src/(system\.h|od\.c|printf\.c|getlimits\.c)$$
883 exclude_file_name_regexp--sc_prohibit_test_backticks = \
884 ^tests/(local\.mk|(init|misc/stdbuf|factor/create-test)\.sh)$$
886 # Exempt test.c, since it's nominally shared, and relatively static.
887 exclude_file_name_regexp--sc_prohibit_operator_at_end_of_line = \
888 ^src/(ptx|test|head)\.c$$
890 exclude_file_name_regexp--sc_error_message_uppercase = ^src/factor\.c$$
891 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^src/make-prime-list\.c$$
893 # Exception here as we don't want __attribute elided on non GCC
894 exclude_file_name_regexp--sc_prohibit-gl-attributes = ^src/libstdbuf\.c$$
896 exclude_file_name_regexp--sc_prohibit_uppercase_id_est = \.diff$$
897 exclude_file_name_regexp--sc_ensure_dblspace_after_dot_before_id_est = \.diff$$
898 exclude_file_name_regexp--sc_ensure_comma_after_id_est = \.diff|$(_ll)$$
899 exclude_file_name_regexp--sc_long_lines = \.diff$$|$(_ll)
901 # Augment AM_CFLAGS to include our per-directory options:
902 AM_CFLAGS += $($(@D)_CFLAGS)
904 src_CFLAGS = $(WARN_CFLAGS)
905 lib_CFLAGS = $(GNULIB_WARN_CFLAGS)
906 gnulib-tests_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS)
908 # Configuration to make the tight-scope syntax-check rule work with
909 # non-recursive make.
910 # Note _gl_TS_headers use _single line_ extern function declarations,
911 # while *_SOURCES use the _two line_ form.
912 export _gl_TS_headers = $(noinst_HEADERS)
913 # Add exceptions for --enable-single-binary renamed functions.
914 _gl_TS_unmarked_extern_functions = main usage
915 _gl_TS_unmarked_extern_functions += single_binary_main_.* _usage_.*
916 # Headers to search for single line extern _data_ declarations.
917 _gl_TS_other_headers = $(srcdir)/src/*.h src/*.h
918 # Tell the tight_scope rule about an exceptional "extern" variable.
919 # Normally, the rule would detect its declaration, but that uses a
920 # different name, __clz_tab.
921 _gl_TS_unmarked_extern_vars = factor_clz_tab
922 # Other tight_scope settings
923 _gl_TS_dir = .
924 _gl_TS_obj_files = src/*.$(OBJEXT)