maint.mk

   1 # -*-Makefile-*-
   2 # This Makefile fragment tries to be general-purpose enough to be
   3 # used by at least coreutils, idutils, CPPI, Bison, and Autoconf.
   4
   5 ## Copyright (C) 2001-2009 Free Software Foundation, Inc.
   6 ##
   7 ## This program is free software: you can redistribute it and/or modify
   8 ## it under the terms of the GNU General Public License as published by
   9 ## the Free Software Foundation, either version 3 of the License, or
  10 ## (at your option) any later version.
  11 ##
  12 ## This program is distributed in the hope that it will be useful,
  13 ## but WITHOUT ANY WARRANTY; without even the implied warranty of
  14 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  15 ## GNU General Public License for more details.
  16 ##
  17 ## You should have received a copy of the GNU General Public License
  18 ## along with this program.  If not, see <http://www.gnu.org/licenses/>.
  19
  20 # This is reported not to work with make-3.79.1
  21 # ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
  22 ME := maint.mk
  23
  24 # Do not save the original name or timestamp in the .tar.gz file.
  25 # Use --rsyncable if available.
  26 gzip_rsyncable := \
  27   $(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo --rsyncable)
  28 GZIP_ENV = '--no-name --best $(gzip_rsyncable)'
  29
  30 GIT = git
  31 VC = $(GIT)
  32 VC-tag = git tag -s -m '$(VERSION)'
  33
  34 VC_LIST = $(srcdir)/build-aux/vc-list-files
  35
  36 VC_LIST_EXCEPT = \
  37   $(VC_LIST) | if test -f .x-$@; then grep -vEf .x-$@; else grep -v ChangeLog; fi
  38
  39 ifeq ($(origin prev_version_file), undefined)
  40   prev_version_file = $(srcdir)/.prev-version
  41 endif
  42
  43 PREV_VERSION := $(shell cat $(prev_version_file))
  44 VERSION_REGEXP = $(subst .,\.,$(VERSION))
  45 PREV_VERSION_REGEXP = $(subst .,\.,$(PREV_VERSION))
  46
  47 ifeq ($(VC),$(GIT))
  48 this-vc-tag = v$(VERSION)
  49 this-vc-tag-regexp = v$(VERSION_REGEXP)
  50 else
  51 tag-package = $(shell echo "$(PACKAGE)" | tr '[:lower:]' '[:upper:]')
  52 tag-this-version = $(subst .,_,$(VERSION))
  53 this-vc-tag = $(tag-package)-$(tag-this-version)
  54 this-vc-tag-regexp = $(this-vc-tag)
  55 endif
  56 my_distdir = $(PACKAGE)-$(VERSION)
  57
  58 # Old releases are stored here.
  59 release_archive_dir ?= ../release
  60
  61 # Prevent programs like 'sort' from considering distinct strings to be equal.
  62 # Doing it here saves us from having to set LC_ALL elsewhere in this file.
  63 export LC_ALL = C
  64
  65 ## --------------- ##
  66 ## Sanity checks.  ##
  67 ## --------------- ##
  68
  69 # Collect the names of rules starting with `sc_'.
  70 syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \
  71                         $(srcdir)/$(ME) $(srcdir)/cfg.mk)
  72 .PHONY: $(syntax-check-rules)
  73
  74 local-checks-available = \
  75   patch-check $(syntax-check-rules) \
  76   makefile-check check-AUTHORS
  77 .PHONY: $(local-checks-available)
  78
  79 # Arrange to print the name of each syntax-checking rule just before running it.
  80 $(syntax-check-rules): %: %.m
  81 $(patsubst %, %.m, $(syntax-check-rules)):
  82         @echo $(patsubst sc_%.m, %, $@)
  83
  84 local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available))
  85
  86 syntax-check: $(local-check)
  87 #       @grep -nE '#  *include <(limits|std(def|arg|bool))\.h>'         \
  88 #           $$(find -type f -name '*.[chly]') &&                        \
  89 #         { echo '$(ME): found conditional include' 1>&2;               \
  90 #           exit 1; } || :
  91
  92 #       grep -nE '^#  *include <(string|stdlib)\.h>'                    \
  93 #           $(srcdir)/{lib,src}/*.[chy] &&                              \
  94 #         { echo '$(ME): FIXME' 1>&2;                                   \
  95 #           exit 1; } || :
  96 # FIXME: don't allow `#include .strings\.h' anywhere
  97
  98 # By default, _prohibit_regexp does not ignore case.
  99 export ignore_case =
 100 _ignore_case = $$(test -n "$$ignore_case" && echo -i || :)
 101
 102 # There are many rules below that prohibit constructs in this package.
 103 # If the offending construct can be matched with a grep-E-style regexp,
 104 # use this macro.  The shell variables "re" and "msg" must be defined.
 105 define _prohibit_regexp
 106   dummy=; : so we do not need a semicolon before each use               \
 107   test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; };  \
 108   test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\
 109   grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) &&              \
 110     { echo '$(ME): '"$$msg" 1>&2; exit 1; } || :
 111 endef
 112
 113 sc_avoid_if_before_free:
 114         @$(srcdir)/build-aux/useless-if-before-free                     \
 115                 $(useless_free_options)                                 \
 116             $$($(VC_LIST_EXCEPT)) &&                                    \
 117           { echo '$(ME): found useless "if" before "free" above' 1>&2;  \
 118             exit 1; } || :
 119
 120 sc_cast_of_argument_to_free:
 121         @re='\<free *\( *\(' msg='don'\''t cast free argument'          \
 122           $(_prohibit_regexp)
 123
 124 sc_cast_of_x_alloc_return_value:
 125         @re='\*\) *x(m|c|re)alloc\>'                                    \
 126         msg='don'\''t cast x*alloc return value'                        \
 127           $(_prohibit_regexp)
 128
 129 sc_cast_of_alloca_return_value:
 130         @re='\*\) *alloca\>' msg='don'\''t cast alloca return value'    \
 131           $(_prohibit_regexp)
 132
 133 sc_space_tab:
 134         @re='[ ]        ' msg='found SPACE-TAB sequence; remove the SPACE' \
 135           $(_prohibit_regexp)
 136
 137 # Don't use *scanf or the old ato* functions in `real' code.
 138 # They provide no error checking mechanism.
 139 # Instead, use strto* functions.
 140 sc_prohibit_atoi_atof:
 141         @re='\<([fs]?scanf|ato([filq]|ll)) *\('                         \
 142         msg='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q' \
 143           $(_prohibit_regexp)
 144
 145 # Use STREQ rather than comparing strcmp == 0, or != 0.
 146 sc_prohibit_strcmp:
 147         @grep -nE '! *str''cmp *\(|\<str''cmp *\([^)]+\) *=='           \
 148             $$($(VC_LIST_EXCEPT))                                       \
 149           | grep -vE ':# *define STREQ\(' &&                            \
 150           { echo '$(ME): use STREQ in place of the above uses of str''cmp' \
 151                 1>&2; exit 1; } || :
 152
 153 # Using EXIT_SUCCESS as the first argument to error is misleading,
 154 # since when that parameter is 0, error does not exit.  Use `0' instead.
 155 sc_error_exit_success:
 156         @grep -nF 'error (EXIT_SUCCESS,'                                \
 157             $$(find -type f -name '*.[chly]') &&                        \
 158           { echo '$(ME): found error (EXIT_SUCCESS' 1>&2;               \
 159             exit 1; } || :
 160
 161 # `FATAL:' should be fully upper-cased in error messages
 162 # `WARNING:' should be fully upper-cased, or fully lower-cased
 163 sc_error_message_warn_fatal:
 164         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 165             | grep -E '"Warning|"Fatal|"fatal' &&                       \
 166           { echo '$(ME): use FATAL, WARNING or warning' 1>&2;           \
 167             exit 1; } || :
 168
 169 # Error messages should not start with a capital letter
 170 sc_error_message_uppercase:
 171         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 172             | grep -E '"[A-Z]'                                          \
 173             | grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' &&           \
 174           { echo '$(ME): found capitalized error message' 1>&2;         \
 175             exit 1; } || :
 176
 177 # Error messages should not end with a period
 178 sc_error_message_period:
 179         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 180             | grep -E '[^."]\."' &&                                     \
 181           { echo '$(ME): found error message ending in period' 1>&2;    \
 182             exit 1; } || :
 183
 184 sc_file_system:
 185         @re=file''system ignore_case=1                                  \
 186         msg='found use of "file''system"; spell it "file system"'       \
 187           $(_prohibit_regexp)
 188
 189 # Don't use cpp tests of this symbol.  All code assumes config.h is included.
 190 sc_prohibit_have_config_h:
 191         @grep -n '^# *if.*HAVE''_CONFIG_H' $$($(VC_LIST_EXCEPT)) &&     \
 192           { echo '$(ME): found use of HAVE''_CONFIG_H; remove'          \
 193                 1>&2; exit 1; } || :
 194
 195 # Nearly all .c files must include <config.h>.
 196 sc_require_config_h:
 197         @if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then          \
 198           grep -L '^# *include <config\.h>'                             \
 199                 $$($(VC_LIST_EXCEPT) | grep '\.c$$')                    \
 200               | grep . &&                                               \
 201           { echo '$(ME): the above files do not include <config.h>'     \
 202                 1>&2; exit 1; } || :;                                   \
 203         else :;                                                         \
 204         fi
 205
 206 # You must include <config.h> before including any other header file.
 207 sc_require_config_h_first:
 208         @if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then          \
 209           fail=0;                                                       \
 210           for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do             \
 211             grep '^# *include\>' $$i | sed 1q                           \
 212                 | grep '^# *include <config\.h>' > /dev/null            \
 213               || { echo $$i; fail=1; };                                 \
 214           done;                                                         \
 215           test $$fail = 1 &&                                            \
 216             { echo '$(ME): the above files include some other header'   \
 217                 'before <config.h>' 1>&2; exit 1; } || :;               \
 218         else :;                                                         \
 219         fi
 220
 221 sc_prohibit_HAVE_MBRTOWC:
 222         @re='\bHAVE_MBRTOWC\b' msg="do not use $$re; it is always defined" \
 223           $(_prohibit_regexp)
 224
 225 # To use this "command" macro, you must first define two shell variables:
 226 # h: the header, enclosed in <> or ""
 227 # re: a regular expression that matches IFF something provided by $h is used.
 228 define _header_without_use
 229   h_esc=`echo "$$h"|sed 's/\./\\./'`;                                   \
 230   if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then                 \
 231     files=$$(grep -l '^# *include '"$$h_esc"                            \
 232              $$($(VC_LIST_EXCEPT) | grep '\.c$$')) &&                   \
 233     grep -LE "$$re" $$files | grep . &&                                 \
 234       { echo "$(ME): the above files include $$h but don't use it"      \
 235         1>&2; exit 1; } || :;                                           \
 236   else :;                                                               \
 237   fi
 238 endef
 239
 240 # Prohibit the inclusion of assert.h without an actual use of assert.
 241 sc_prohibit_assert_without_use:
 242         @h='<assert.h>' re='\<assert *\(' $(_header_without_use)
 243
 244 # Prohibit the inclusion of getopt.h without an actual use.
 245 sc_prohibit_getopt_without_use:
 246         @h='<getopt.h>' re='\<getopt(_long)? *\(' $(_header_without_use)
 247
 248 # Don't include quotearg.h unless you use one of its functions.
 249 sc_prohibit_quotearg_without_use:
 250         @h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_header_without_use)
 251
 252 # Don't include quote.h unless you use one of its functions.
 253 sc_prohibit_quote_without_use:
 254         @h='"quote.h"' re='\<quote(_n)? *\(' $(_header_without_use)
 255
 256 # Don't include this header unless you use one of its functions.
 257 sc_prohibit_long_options_without_use:
 258         @h='"long-options.h"' re='\<parse_long_options *\(' \
 259           $(_header_without_use)
 260
 261 # Don't include this header unless you use one of its functions.
 262 sc_prohibit_inttostr_without_use:
 263         @h='"inttostr.h"' re='\<(off|[iu]max|uint)tostr *\(' \
 264           $(_header_without_use)
 265
 266 # Don't include this header unless you use one of its functions.
 267 sc_prohibit_error_without_use:
 268         @h='"error.h"' \
 269         re='\<error(_at_line|_print_progname|_one_per_line|_message_count)? *\('\
 270           $(_header_without_use)
 271
 272 sc_prohibit_safe_read_without_use:
 273         @h='"safe-read.h"' re='(\<SAFE_READ_ERROR\>|\<safe_read *\()' \
 274           $(_header_without_use)
 275
 276 sc_prohibit_argmatch_without_use:
 277         @h='"argmatch.h"' \
 278         re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid) *\()' \
 279           $(_header_without_use)
 280
 281 sc_prohibit_root_dev_ino_without_use:
 282         @h='"root-dev-ino.h"' \
 283         re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \
 284           $(_header_without_use)
 285
 286 # Prohibit the inclusion of c-ctype.h without an actual use.
 287 ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
 288 |isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
 289 sc_prohibit_c_ctype_without_use:
 290         @h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' $(_header_without_use)
 291
 292 sc_obsolete_symbols:
 293         @re='\<(HAVE''_FCNTL_H|O''_NDELAY)\>'                           \
 294         msg='do not use HAVE''_FCNTL_H or O'_NDELAY                     \
 295           $(_prohibit_regexp)
 296
 297 # FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ
 298
 299 # Each nonempty line must start with a year number, or a TAB.
 300 sc_changelog:
 301         @grep -n '^[^12 ]' $$(find . -maxdepth 2 -name ChangeLog) &&    \
 302           { echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2;  \
 303             exit 1; } || :
 304
 305 # Ensure that each .c file containing a "main" function also
 306 # calls set_program_name.
 307 sc_program_name:
 308         @if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then          \
 309           files=$$(grep -l '^main *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$')); \
 310           grep -LE 'set_program_name *\(m?argv\[0\]\);' $$files         \
 311               | grep . &&                                               \
 312           { echo '$(ME): the above files do not call set_program_name'  \
 313                 1>&2; exit 1; } || :;                                   \
 314         else :;                                                         \
 315         fi
 316
 317 # Require that the final line of each test-lib.sh-using test be this one:
 318 # Exit $fail
 319 # Note: this test requires GNU grep's --label= option.
 320 sc_require_test_exit_idiom:
 321         @if test -f $(srcdir)/tests/test-lib.sh; then                   \
 322           die=0;                                                        \
 323           for i in $$(grep -l -F /../test-lib.sh $$($(VC_LIST) tests)); do \
 324             tail -n1 $$i | grep '^Exit \$$fail$$' > /dev/null           \
 325               && : || { die=1; echo $$i; }                              \
 326           done;                                                         \
 327           test $$die = 1 &&                                             \
 328             { echo 1>&2 '$(ME): the final line in each of the above is not:'; \
 329               echo 1>&2 'Exit $$fail';                                  \
 330               exit 1; } || :;                                           \
 331         fi
 332
 333 sc_the_the:
 334         @re='\<the ''the\>'                                             \
 335         ignore_case=1 msg='found use of "the ''the";'                   \
 336           $(_prohibit_regexp)
 337
 338 sc_trailing_blank:
 339         @re='[   ]$$'                                                   \
 340         ignore_case=1 msg='found trailing blank(s)'                     \
 341           $(_prohibit_regexp)
 342
 343 # Match lines like the following, but where there is only one space
 344 # between the options and the description:
 345 #   -D, --all-repeated[=delimit-method]  print all duplicate lines\n
 346 longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)?
 347 sc_two_space_separator_in_usage:
 348         @grep -nE '^   *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$'         \
 349             $$($(VC_LIST_EXCEPT)) &&                                    \
 350           { echo "$(ME): help2man requires at least two spaces between"; \
 351             echo "$(ME): an option and its description";                \
 352                 1>&2; exit 1; } || :
 353
 354 # Look for diagnostics that aren't marked for translation.
 355 # This won't find any for which error's format string is on a separate line.
 356 sc_unmarked_diagnostics:
 357         @grep -nE                                                       \
 358             '\<error \([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT))       \
 359           | grep -v '_''(' &&                                           \
 360           { echo '$(ME): found unmarked diagnostic(s)' 1>&2;            \
 361             exit 1; } || :
 362
 363 # Avoid useless parentheses like those in this example:
 364 # #if defined (SYMBOL) || defined (SYM2)
 365 sc_useless_cpp_parens:
 366         @grep -n '^# *if .*defined *(' $$($(VC_LIST_EXCEPT)) &&         \
 367           { echo '$(ME): found useless parentheses in cpp directive'    \
 368                 1>&2; exit 1; } || :
 369
 370 # Require the latest GPL.
 371 sc_GPL_version:
 372         @re='either ''version [^3]' msg='GPL vN, N!=3'                  \
 373           $(_prohibit_regexp)
 374
 375 cvs_keywords = \
 376   Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
 377
 378 sc_prohibit_cvs_keyword:
 379         @re='\$$($(cvs_keywords))\$$'                                   \
 380             msg='do not use CVS keyword expansion'                      \
 381           $(_prohibit_regexp)
 382
 383 # Make sure we don't use st_blocks.  Use ST_NBLOCKS instead.
 384 # This is a bit of a kludge, since it prevents use of the string
 385 # even in comments, but for now it does the job with no false positives.
 386 sc_prohibit_stat_st_blocks:
 387         @re='[.>]st_blocks' msg='do not use st_blocks; use ST_NBLOCKS'  \
 388           $(_prohibit_regexp)
 389
 390 # Make sure we don't define any S_IS* macros in src/*.c files.
 391 # They're already defined via gnulib's sys/stat.h replacement.
 392 sc_prohibit_S_IS_definition:
 393         @re='^ *# *define  *S_IS'                                       \
 394         msg='do not define S_IS* macros; include <sys/stat.h>'          \
 395           $(_prohibit_regexp)
 396
 397 # Each program that uses proper_name_utf8 must link with
 398 # one of the ICONV libraries.
 399 sc_proper_name_utf8_requires_ICONV:
 400         @progs=$$(grep -l 'proper_name_utf8 ''("' $$($(VC_LIST_EXCEPT)));\
 401         if test "x$$progs" != x; then                                   \
 402           fail=0;                                                       \
 403           for p in $$progs; do                                          \
 404             dir=$$(dirname "$$p");                                      \
 405             base=$$(basename "$$p" .c);                                 \
 406             grep "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \
 407               || { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \
 408           done;                                                         \
 409           test $$fail = 1 &&                                            \
 410             { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \
 411               exit 1; } || :;                                           \
 412         fi
 413
 414 # Warn about "c0nst struct Foo const foo[]",
 415 # but not about "char const *const foo" or "#define const const".
 416 sc_redundant_const:
 417         @re='\bconst\b[[:space:][:alnum:]]{2,}\bconst\b'                \
 418         msg='redundant "const" in declarations'                         \
 419           $(_prohibit_regexp)
 420
 421 sc_const_long_option:
 422         @grep '^ *static.*struct option ' $$($(VC_LIST_EXCEPT))         \
 423           | grep -Ev 'const struct option|struct option const' && {     \
 424               echo 1>&2 '$(ME): add "const" to the above declarations'; \
 425               exit 1; } || :
 426
 427 NEWS_hash = \
 428   $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
 429      $(srcdir)/NEWS | grep -v '^Copyright .*Free Software' | md5sum -)
 430
 431 # Ensure that we don't accidentally insert an entry into an old NEWS block.
 432 sc_immutable_NEWS:
 433         @if test -f $(srcdir)/NEWS; then                                \
 434           test "$(NEWS_hash)" = '$(old_NEWS_hash)' && : ||              \
 435             { echo '$(ME): you have modified old NEWS' 1>&2; exit 1; }; \
 436         fi
 437
 438 # Update the hash stored above.  Do this after each release and
 439 # for any corrections to old entries.
 440 update-NEWS-hash: NEWS
 441         perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
 442           $(srcdir)/cfg.mk
 443
 444 epoch_date = 1970-01-01 00:00:00.000000000 +0000
 445 # Ensure that the c99-to-c89 patch applies cleanly.
 446 patch-check:
 447         rm -rf src-c89 $@.1 $@.2
 448         cp -a $(srcdir)/src src-c89
 449         if test "x$(srcdir)" != x.; then \
 450           cp -a src/* src-c89; \
 451           dotfiles=`ls src/.[!.]* 2>/dev/null`; \
 452           test -z "$$dotfiles" || cp -a src/.[!.]* src-c89; \
 453         fi
 454         (cd src-c89; patch -p1 -V never --fuzz=0) < $(srcdir)/src/c99-to-c89.diff \
 455           > $@.1 2>&1
 456         if test "$(REGEN_PATCH)" = yes; then                    \
 457           diff -upr $(srcdir)/src src-c89 | sed 's,$(srcdir)/src-c89/,src/,'    \
 458             | grep -vE '^(Only in|File )'                       \
 459             | perl -pe 's/^((?:\+\+\+|---) \S+\t).*/$${1}$(epoch_date)/;' \
 460                -e 's/^ $$//'                                    \
 461             > new-diff || : ; fi
 462         grep -v '^patching file ' $@.1 > $@.2 || :
 463         msg=ok; test -s $@.2 && msg='fuzzy patch' || : ;        \
 464         rm -f src-c89/*.o || msg='rm failed';                   \
 465         $(MAKE) -C src-c89 CFLAGS='-Wdeclaration-after-statement -Werror' \
 466           || msg='compile failure with extra options';          \
 467         test "$$msg" = ok && rm -rf src-c89 $@.1 $@.2 || echo "$$msg" 1>&2; \
 468         test "$$msg" = ok
 469
 470 check-AUTHORS:
 471         $(MAKE) -C src $@
 472
 473 # Ensure that we use only the standard $(VAR) notation,
 474 # not @...@ in Makefile.am, now that we can rely on automake
 475 # to emit a definition for each substituted variable.
 476 # We use perl rather than "grep -nE ..." to exempt a single
 477 # use of an @...@-delimited variable name in src/Makefile.am.
 478 makefile-check:
 479         @perl -ne '/\@[A-Z_0-9]+\@/ && !/^cu_install_program =/'        \
 480           -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}'    \
 481             $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$')       \
 482           && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || :
 483
 484 news-date-check: NEWS
 485         today=`date +%Y-%m-%d`;                                         \
 486         if head NEWS | grep '^\*.* $(VERSION_REGEXP) ('$$today')'       \
 487             >/dev/null; then                                            \
 488           :;                                                            \
 489         else                                                            \
 490           echo "version or today's date is not in NEWS" 1>&2;           \
 491           exit 1;                                                       \
 492         fi
 493
 494 changelog-check:
 495         if head ChangeLog | grep 'Version $(VERSION_REGEXP)\.$$'        \
 496             >/dev/null; then                                            \
 497           :;                                                            \
 498         else                                                            \
 499           echo "$(VERSION) not in ChangeLog" 1>&2;                      \
 500           exit 1;                                                       \
 501         fi
 502
 503 sc_m4_quote_check:
 504         @grep -nE '(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]'              \
 505             $$($(VC_LIST_EXCEPT) | grep -E '(^configure\.ac|\.m4)$$')   \
 506           && { echo '$(ME): quote the first arg to AC_DEF*' 1>&2;       \
 507                exit 1; } || :
 508
 509 fix_po_file_diag = \
 510 'you have changed the set of files with translatable diagnostics;\n\
 511 apply the above patch\n'
 512
 513 # Verify that all source files using _() are listed in po/POTFILES.in.
 514 po_file = po/POTFILES.in
 515 sc_po_check:
 516         @if test -f $(po_file); then                                    \
 517           grep -E -v '^(#|$$)' $(po_file)                               \
 518             | grep -v '^src/false\.c$$' | sort > $@-1;                  \
 519           files=;                                                       \
 520           for file in $$($(VC_LIST_EXCEPT)) lib/*.[ch]; do              \
 521             case $$file in                                              \
 522               *.?|*.??) ;;                                              \
 523               *) continue;;                                             \
 524             esac;                                                       \
 525             case $$file in                                              \
 526             *.[ch])                                                     \
 527               base=`expr " $$file" : ' \(.*\)\..'`;                     \
 528               { test -f $$base.l || test -f $$base.y; } && continue;;   \
 529             esac;                                                       \
 530             files="$$files $$file";                                     \
 531           done;                                                         \
 532           grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files          \
 533             | sort -u > $@-2;                                           \
 534           diff -u -L $(po_file) -L $(po_file) $@-1 $@-2                 \
 535             || { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; };   \
 536           rm -f $@-1 $@-2;                                              \
 537         fi
 538
 539 # Sometimes it is useful to change the PATH environment variable
 540 # in Makefiles.  When doing so, it's better not to use the Unix-centric
 541 # path separator of `:', but rather the automake-provided `@PATH_SEPARATOR@'.
 542 # It'd be better to use `find -print0 ...|xargs -0 ...', but less portable,
 543 # and there probably aren't many projects with so many Makefile.am files
 544 # that we'd have to worry about limits on command line length.
 545 msg = '$(ME): Do not use `:'\'' above; use @PATH_SEPARATOR@ instead'
 546 sc_makefile_path_separator_check:
 547         @grep -n 'PATH=.*:' `find $(srcdir) -name Makefile.am` \
 548           && { echo $(msg) 1>&2; exit 1; } || :
 549
 550 # Check that `make alpha' will not fail at the end of the process.
 551 writable-files:
 552         if test -d $(release_archive_dir); then :; else                 \
 553           for file in $(distdir).tar.gz                                 \
 554                       $(release_archive_dir)/$(distdir).tar.gz; do      \
 555             test -e $$file || continue;                                 \
 556             test -w $$file                                              \
 557               || { echo ERROR: $$file is not writable; fail=1; };       \
 558           done;                                                         \
 559           test "$$fail" && exit 1 || : ;                                \
 560         fi
 561
 562 v_etc_file = lib/version-etc.c
 563 sample-test = tests/sample-test
 564 texi = doc/$(PACKAGE).texi
 565 # Make sure that the copyright date in $(v_etc_file) is up to date.
 566 # Do the same for the $(sample-test) and the main doc/.texi file.
 567 sc_copyright_check:
 568         @if test -f $(v_etc_file); then                                 \
 569           grep 'enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' $(v_etc_file) \
 570             >/dev/null                                                  \
 571           || { echo 'out of date copyright in $(v_etc_file); update it' 1>&2; \
 572                exit 1; };                                               \
 573         fi
 574         @if test -f $(sample-test); then                                \
 575           grep '# Copyright (C) '$$(date +%Y)' Free' $(sample-test)     \
 576             >/dev/null                                                  \
 577           || { echo 'out of date copyright in $(sample-test); update it' 1>&2; \
 578                exit 1; };                                               \
 579         fi
 580         @if test -f $(texi); then                                       \
 581           grep 'Copyright @copyright{} .*'$$(date +%Y)' Free' $(texi)   \
 582             >/dev/null                                                  \
 583           || { echo 'out of date copyright in $(texi); update it' 1>&2; \
 584                exit 1; };                                               \
 585         fi
 586
 587 vc-diff-check:
 588         $(VC) diff > vc-diffs || :
 589         if test -s vc-diffs; then                               \
 590           cat vc-diffs;                                         \
 591           echo "Some files are locally modified:" 1>&2;         \
 592           exit 1;                                               \
 593         else                                                    \
 594           rm vc-diffs;                                          \
 595         fi
 596
 597 cvs-check: vc-diff-check
 598
 599 maintainer-distcheck:
 600         $(MAKE) distcheck
 601         $(MAKE) taint-distcheck
 602         $(MAKE) my-distcheck
 603
 604
 605 # Don't make a distribution if checks fail.
 606 # Also, make sure the NEWS file is up-to-date.
 607 vc-dist: $(local-check) cvs-check maintainer-distcheck
 608         $(MAKE) dist
 609
 610 # Use this to make sure we don't run these programs when building
 611 # from a virgin tgz file, below.
 612 null_AM_MAKEFLAGS = \
 613   ACLOCAL=false \
 614   AUTOCONF=false \
 615   AUTOMAKE=false \
 616   AUTOHEADER=false \
 617   MAKEINFO=false
 618
 619 built_programs = $$(cd src && MAKEFLAGS= $(MAKE) -s built_programs.list)
 620
 621 warn_cflags = -Dlint -O -Werror -Wall -Wformat -Wshadow -Wpointer-arith
 622 bin=bin-$$$$
 623
 624 write_loser = printf '\#!%s\necho $$0: bad path 1>&2; exit 1\n' '$(SHELL)'
 625
 626 TMPDIR ?= /tmp
 627 t=$(TMPDIR)/$(PACKAGE)/test
 628 pfx=$(t)/i
 629
 630 # More than once, tainted build and source directory names would
 631 # have caused at least one "make check" test to apply "chmod 700"
 632 # to all directories under $HOME.  Make sure it doesn't happen again.
 633 tp := $(shell echo "$(TMPDIR)/$(PACKAGE)-$$$$")
 634 t_prefix = $(tp)/a
 635 t_taint = '$(t_prefix) b'
 636 fake_home = $(tp)/home
 637
 638 # Ensure that tests run from tainted build and src dir names work,
 639 # and don't affect anything in $HOME.  Create witness files in $HOME,
 640 # record their attributes, and build/test.  Then ensure that the
 641 # witnesses were not affected.
 642 taint-distcheck: $(DIST_ARCHIVES)
 643         test -d $(t_taint) && chmod -R 700 $(t_taint) || :
 644         -rm -rf $(t_taint) $(fake_home)
 645         mkdir -p $(t_prefix) $(t_taint) $(fake_home)
 646         GZIP=$(GZIP_ENV) $(AMTAR) -C $(t_taint) -zxf $(distdir).tar.gz
 647         mkfifo $(fake_home)/fifo
 648         touch $(fake_home)/f
 649         mkdir -p $(fake_home)/d/e
 650         ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-before
 651         cd $(t_taint)/$(distdir)                        \
 652           && ./configure                                \
 653           && $(MAKE)                                    \
 654           && HOME=$(fake_home) $(MAKE) check            \
 655           && ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-after \
 656           && diff $(tp)/.ls-before $(tp)/.ls-after      \
 657           && test -d $(t_prefix)
 658         rm -rf $(tp)
 659
 660 # Verify that a twisted use of --program-transform-name=PROGRAM works.
 661 define install-transform-check
 662   echo running install-transform-check                  \
 663     && rm -rf $(pfx)                                    \
 664     && $(MAKE) program_transform_name='s/.*/zyx/'       \
 665       prefix=$(pfx) install                             \
 666     && test "$$(echo $(pfx)/bin/*)" = "$(pfx)/bin/zyx"  \
 667     && test "$$(find $(pfx)/share/man -type f|sed 's,.*/,,;s,\..*,,')" = "zyx"
 668 endef
 669
 670 # Install, then verify that all binaries and man pages are in place.
 671 # Note that neither the binary, ginstall, nor the ].1 man page is installed.
 672 define my-instcheck
 673   $(MAKE) prefix=$(pfx) install                         \
 674     && test ! -f $(pfx)/bin/ginstall                    \
 675     && { fail=0;                                        \
 676       for i in $(built_programs); do                    \
 677         test "$$i" = ginstall && i=install;             \
 678         for j in "$(pfx)/bin/$$i"                       \
 679                  "$(pfx)/share/man/man1/$$i.1"; do      \
 680           case $$j in *'[.1') continue;; esac;          \
 681           test -f "$$j" && :                            \
 682             || { echo "$$j not installed"; fail=1; };   \
 683         done;                                           \
 684       done;                                             \
 685       test $$fail = 1 && exit 1 || :;                   \
 686     }
 687 endef
 688
 689 define coreutils-path-check
 690   {                                                     \
 691     if test -f $(srcdir)/src/true.c; then               \
 692       fail=1;                                           \
 693       mkdir $(bin)                                      \
 694         && ($(write_loser)) > $(bin)/loser              \
 695         && chmod a+x $(bin)/loser                       \
 696         && for i in $(built_programs); do               \
 697                case $$i in                              \
 698                  rm|expr|basename|echo|sort|ls|tr);;    \
 699                  cat|dirname|mv|wc);;                   \
 700                  *) ln $(bin)/loser $(bin)/$$i;;        \
 701                esac;                                    \
 702              done                                       \
 703           && ln -sf ../src/true $(bin)/false            \
 704           && PATH=`pwd`/$(bin):$$PATH $(MAKE) -C tests check \
 705           && { test -d gnulib-tests                     \
 706                  && $(MAKE) -C gnulib-tests check       \
 707                  || :; }                                \
 708           && rm -rf $(bin)                              \
 709           && fail=0;                                    \
 710     else                                                \
 711       fail=0;                                           \
 712     fi;                                                 \
 713     test $$fail = 1 && exit 1 || :;                     \
 714   }
 715 endef
 716
 717 # Use -Wformat -Werror to detect format-string/arg-list mismatches.
 718 # Also, check for shadowing problems with -Wshadow, and for pointer
 719 # arithmetic problems with -Wpointer-arith.
 720 # These CFLAGS are pretty strict.  If you build this target, you probably
 721 # have to have a recent version of gcc and glibc headers.
 722 # The hard-linking for-loop below ensures that there is a bin/ directory
 723 # full of all of the programs under test (except the ones that are required
 724 # for basic Makefile rules), all symlinked to the just-built "false" program.
 725 # This is to ensure that if ever a test neglects to make PATH include
 726 # the build srcdir, these always-failing programs will run.
 727 # Otherwise, it is too easy to test the wrong programs.
 728 # Note that "false" itself is a symlink to true, so it too will malfunction.
 729 my-distcheck: $(DIST_ARCHIVES) $(local-check)
 730         $(MAKE) syntax-check
 731         $(MAKE) check
 732         -rm -rf $(t)
 733         mkdir -p $(t)
 734         GZIP=$(GZIP_ENV) $(AMTAR) -C $(t) -zxf $(distdir).tar.gz
 735         cd $(t)/$(distdir)                              \
 736           && ./configure --disable-nls                  \
 737           && $(MAKE) CFLAGS='$(warn_cflags)'            \
 738               AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)'       \
 739           && $(MAKE) dvi                                \
 740           && $(install-transform-check)                 \
 741           && $(my-instcheck)                            \
 742           && $(coreutils-path-check)                    \
 743           && $(MAKE) distclean
 744         (cd $(t) && mv $(distdir) $(distdir).old        \
 745           && $(AMTAR) -zxf - ) < $(distdir).tar.gz
 746         diff -ur $(t)/$(distdir).old $(t)/$(distdir)
 747         -rm -rf $(t)
 748         @echo "========================"; \
 749         echo "$(distdir).tar.gz is ready for distribution"; \
 750         echo "========================"
 751
 752 WGET = wget
 753 WGETFLAGS = -C off
 754
 755 rel-check:
 756         tarz=/tmp/rel-check-tarz-$$$$; \
 757         md5_tmp=/tmp/rel-check-md5-$$$$; \
 758         set -e; \
 759         trap 'status=$$?; rm -f $$tarz $$md5_tmp; exit $$status' 0 1 2 3 15; \
 760         $(WGET) $(WGETFLAGS) -q --output-document=$$tarz $(url); \
 761         echo "$(md5)  -" > $$md5_tmp; \
 762         md5sum -c $$md5_tmp < $$tarz
 763
 764 rel-files = $(DIST_ARCHIVES)
 765
 766 gnulib-version = $$(cd $(gnulib_dir) && git describe)
 767
 768 announcement: NEWS ChangeLog $(rel-files)
 769         @./build-aux/announce-gen                                       \
 770             --release-type=$(RELEASE_TYPE)                              \
 771             --package=$(PACKAGE)                                        \
 772             --prev=$(PREV_VERSION)                                      \
 773             --curr=$(VERSION)                                           \
 774             --gpg-key-id=$(gpg_key_ID)                                  \
 775             --news=NEWS                                                 \
 776             --bootstrap-tools=autoconf,automake,bison,gnulib            \
 777             --gnulib-version=$(gnulib-version)                          \
 778             $(addprefix --url-dir=, $(url_dir_list))
 779
 780 ## ---------------- ##
 781 ## Updating files.  ##
 782 ## ---------------- ##
 783
 784 ftp-gnu = ftp://ftp.gnu.org/gnu
 785 www-gnu = http://www.gnu.org
 786
 787 # Use mv, if you don't have/want move-if-change.
 788 move_if_change ?= move-if-change
 789
 790 emit_upload_commands:
 791         @echo =====================================
 792         @echo =====================================
 793         @echo "$(srcdir)/build-aux/gnupload $(GNUPLOADFLAGS) \\"
 794         @echo "    --to $(gnu_rel_host):$(PACKAGE) \\"
 795         @echo "  $(rel-files)"
 796         @echo '# send the /tmp/announcement e-mail'
 797         @echo =====================================
 798         @echo =====================================
 799
 800 noteworthy = * Noteworthy changes in release ?.? (????-??-??) [?]
 801 define emit-commit-log
 802   printf '%s\n' 'post-release administrivia' '' \
 803     '* NEWS: Add header line for next release.' \
 804     '* .prev-version: Record previous version.' \
 805     '* cfg.mk (old_NEWS_hash): Auto-update.'
 806 endef
 807
 808 .PHONY: alpha beta major
 809 alpha beta major: $(local-check) writable-files
 810         test $@ = major                                         \
 811           && { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \
 812                || { echo "invalid version string: $(VERSION)" 1>&2; exit 1;};}\
 813           || :
 814         $(MAKE) vc-dist
 815         $(MAKE) news-date-check
 816         $(MAKE) -s announcement RELEASE_TYPE=$@ > /tmp/announce-$(my_distdir)
 817         if test -d $(release_archive_dir); then                 \
 818           ln $(rel-files) $(release_archive_dir);               \
 819           chmod a-w $(rel-files);                               \
 820         fi
 821         $(MAKE) -s emit_upload_commands RELEASE_TYPE=$@
 822         echo $(VERSION) > $(prev_version_file)
 823         $(MAKE) update-NEWS-hash
 824         perl -pi -e '$$. == 3 and print "$(noteworthy)\n\n\n"' NEWS
 825         $(emit-commit-log) > .ci-msg
 826         $(VC) commit -F .ci-msg -a