2 * Intel Cherry Trail ACPI INT33FE pseudo device driver
4 * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License version 2 as
8 * published by the Free Software Foundation.
10 * Some Intel Cherry Trail based device which ship with Windows 10, have
11 * this weird INT33FE ACPI device with a CRS table with 4 I2cSerialBusV2
12 * resources, for 4 different chips attached to various i2c busses:
13 * 1. The Whiskey Cove pmic, which is also described by the INT34D3 ACPI device
14 * 2. Maxim MAX17047 Fuel Gauge Controller
15 * 3. FUSB302 USB Type-C Controller
16 * 4. PI3USB30532 USB switch
18 * So this driver is a stub / pseudo driver whose only purpose is to
19 * instantiate i2c-clients for chips 2 - 4, so that standard i2c drivers
20 * for these chips can bind to the them.
23 #include <linux/acpi.h>
24 #include <linux/i2c.h>
25 #include <linux/interrupt.h>
26 #include <linux/module.h>
27 #include <linux/regulator/consumer.h>
28 #include <linux/slab.h>
30 #define EXPECTED_PTYPE 4
32 struct cht_int33fe_data
{
33 struct i2c_client
*max17047
;
34 struct i2c_client
*fusb302
;
35 struct i2c_client
*pi3usb30532
;
39 * Grrr I severly dislike buggy BIOS-es. At least one BIOS enumerates
40 * the max17047 both through the INT33FE ACPI device (it is right there
41 * in the resources table) as well as through a separate MAX17047 device.
43 * These helpers are used to work around this by checking if an i2c-client
44 * for the max17047 has already been registered.
46 static int cht_int33fe_check_for_max17047(struct device
*dev
, void *data
)
48 struct i2c_client
**max17047
= data
;
49 struct acpi_device
*adev
;
52 adev
= ACPI_COMPANION(dev
);
56 hid
= acpi_device_hid(adev
);
58 /* The MAX17047 ACPI node doesn't have an UID, so we don't check that */
59 if (strcmp(hid
, "MAX17047"))
62 *max17047
= to_i2c_client(dev
);
66 static struct i2c_client
*cht_int33fe_find_max17047(void)
68 struct i2c_client
*max17047
= NULL
;
70 i2c_for_each_dev(&max17047
, cht_int33fe_check_for_max17047
);
74 static const char * const max17047_suppliers
[] = { "bq24190-charger" };
76 static const struct property_entry max17047_props
[] = {
77 PROPERTY_ENTRY_STRING_ARRAY("supplied-from", max17047_suppliers
),
81 static const struct property_entry fusb302_props
[] = {
82 PROPERTY_ENTRY_STRING("fcs,extcon-name", "cht_wcove_pwrsrc"),
83 PROPERTY_ENTRY_U32("fcs,max-sink-microvolt", 12000000),
84 PROPERTY_ENTRY_U32("fcs,max-sink-microamp", 3000000),
85 PROPERTY_ENTRY_U32("fcs,max-sink-microwatt", 36000000),
89 static int cht_int33fe_probe(struct i2c_client
*client
)
91 struct device
*dev
= &client
->dev
;
92 struct i2c_board_info board_info
;
93 struct cht_int33fe_data
*data
;
94 struct i2c_client
*max17047
;
95 struct regulator
*regulator
;
96 unsigned long long ptyp
;
101 status
= acpi_evaluate_integer(ACPI_HANDLE(dev
), "PTYP", NULL
, &ptyp
);
102 if (ACPI_FAILURE(status
)) {
103 dev_err(dev
, "Error getting PTYPE\n");
108 * The same ACPI HID is used for different configurations check PTYP
109 * to ensure that we are dealing with the expected config.
111 if (ptyp
!= EXPECTED_PTYPE
)
114 /* Check presence of INT34D3 (hardware-rev 3) expected for ptype == 4 */
115 if (!acpi_dev_present("INT34D3", "1", 3)) {
116 dev_err(dev
, "Error PTYPE == %d, but no INT34D3 device\n",
122 * We expect the WC PMIC to be paired with a TI bq24292i charger-IC.
123 * We check for the bq24292i vbus regulator here, this has 2 purposes:
124 * 1) The bq24292i allows charging with up to 12V, setting the fusb302's
125 * max-snk voltage to 12V with another charger-IC is not good.
126 * 2) For the fusb302 driver to get the bq24292i vbus regulator, the
127 * regulator-map, which is part of the bq24292i regulator_init_data,
128 * must be registered before the fusb302 is instantiated, otherwise
129 * it will end up with a dummy-regulator.
130 * Note "cht_wc_usb_typec_vbus" comes from the regulator_init_data
131 * which is defined in i2c-cht-wc.c from where the bq24292i i2c-client
132 * gets instantiated. We use regulator_get_optional here so that we
133 * don't end up getting a dummy-regulator ourselves.
135 regulator
= regulator_get_optional(dev
, "cht_wc_usb_typec_vbus");
136 if (IS_ERR(regulator
)) {
137 ret
= PTR_ERR(regulator
);
138 return (ret
== -ENODEV
) ? -EPROBE_DEFER
: ret
;
140 regulator_put(regulator
);
142 /* The FUSB302 uses the irq at index 1 and is the only irq user */
143 fusb302_irq
= acpi_dev_gpio_irq_get(ACPI_COMPANION(dev
), 1);
144 if (fusb302_irq
< 0) {
145 if (fusb302_irq
!= -EPROBE_DEFER
)
146 dev_err(dev
, "Error getting FUSB302 irq\n");
150 data
= devm_kzalloc(dev
, sizeof(*data
), GFP_KERNEL
);
154 /* Work around BIOS bug, see comment on cht_int33fe_find_max17047 */
155 max17047
= cht_int33fe_find_max17047();
157 /* Pre-existing i2c-client for the max17047, add device-props */
158 ret
= device_add_properties(&max17047
->dev
, max17047_props
);
161 /* And re-probe to get the new device-props applied. */
162 ret
= device_reprobe(&max17047
->dev
);
164 dev_warn(dev
, "Reprobing max17047 error: %d\n", ret
);
166 memset(&board_info
, 0, sizeof(board_info
));
167 strlcpy(board_info
.type
, "max17047", I2C_NAME_SIZE
);
168 board_info
.dev_name
= "max17047";
169 board_info
.properties
= max17047_props
;
170 data
->max17047
= i2c_acpi_new_device(dev
, 1, &board_info
);
172 return -EPROBE_DEFER
; /* Wait for i2c-adapter to load */
175 memset(&board_info
, 0, sizeof(board_info
));
176 strlcpy(board_info
.type
, "typec_fusb302", I2C_NAME_SIZE
);
177 board_info
.dev_name
= "fusb302";
178 board_info
.properties
= fusb302_props
;
179 board_info
.irq
= fusb302_irq
;
181 data
->fusb302
= i2c_acpi_new_device(dev
, 2, &board_info
);
183 goto out_unregister_max17047
;
185 memset(&board_info
, 0, sizeof(board_info
));
186 board_info
.dev_name
= "pi3usb30532";
187 strlcpy(board_info
.type
, "pi3usb30532", I2C_NAME_SIZE
);
189 data
->pi3usb30532
= i2c_acpi_new_device(dev
, 3, &board_info
);
190 if (!data
->pi3usb30532
)
191 goto out_unregister_fusb302
;
193 i2c_set_clientdata(client
, data
);
197 out_unregister_fusb302
:
198 i2c_unregister_device(data
->fusb302
);
200 out_unregister_max17047
:
202 i2c_unregister_device(data
->max17047
);
204 return -EPROBE_DEFER
; /* Wait for the i2c-adapter to load */
207 static int cht_int33fe_remove(struct i2c_client
*i2c
)
209 struct cht_int33fe_data
*data
= i2c_get_clientdata(i2c
);
211 i2c_unregister_device(data
->pi3usb30532
);
212 i2c_unregister_device(data
->fusb302
);
214 i2c_unregister_device(data
->max17047
);
219 static const struct i2c_device_id cht_int33fe_i2c_id
[] = {
222 MODULE_DEVICE_TABLE(i2c
, cht_int33fe_i2c_id
);
224 static const struct acpi_device_id cht_int33fe_acpi_ids
[] = {
228 MODULE_DEVICE_TABLE(acpi
, cht_int33fe_acpi_ids
);
230 static struct i2c_driver cht_int33fe_driver
= {
232 .name
= "Intel Cherry Trail ACPI INT33FE driver",
233 .acpi_match_table
= ACPI_PTR(cht_int33fe_acpi_ids
),
235 .probe_new
= cht_int33fe_probe
,
236 .remove
= cht_int33fe_remove
,
237 .id_table
= cht_int33fe_i2c_id
,
238 .disable_i2c_core_irq_mapping
= true,
241 module_i2c_driver(cht_int33fe_driver
);
243 MODULE_DESCRIPTION("Intel Cherry Trail ACPI INT33FE pseudo device driver");
244 MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
245 MODULE_LICENSE("GPL");