| blob | 9eed3683ad76caffbbb2418e5dbea7551d374406 |
1 #!/usr/bin/env perl
2 # SPDX-License-Identifier: GPL-2.0
3 #
4 # (c) 2001, Dave Jones. (the file handling bit)
5 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
6 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
7 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
8 # (c) 2010-2018 Joe Perches <joe@perches.com>
73 # git output parsing needs US English output, so first set backtick child process LANGUAGE
87 Options:
94 --emacs emacs compile window format
95 --terse one line per report
98 single git commit with:
102 multiple git commits with:
106 git merges are ignored
124 is all off)
126 literally
129 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
130 with potential errors corrected to the preferred
131 checkpatch style
136 runtime errors.
139 --codespellfile Use this codespell dictionary
140 --typedefsfile Read additional types from this file
148 EOM
151 }
156 }
172 # Also catch when type or level is passed through a variable
173 while ($text =~ /(?:(\bCHK|\bWARN|\bERROR|&\{\$msg_level})\s*\(|\$msg_type\s*=)\s*"([^"]+)"/g) {
179 }
182 }
183 }
196 }
208 }
209 }
215 }
216 }
219 }
241 }
242 }
245 }
263 }
277 }
278 }
279 }
283 }
285 }
287 # Perl's Getopt::Long allows options to take optional arguments after a space.
288 # Prevent --color by itself from consuming other arguments
292 }
293 }
295 GetOptions(
337 # Use the user provided codespell file unconditionally
340 # If /usr/share/codespell/dictionary.txt is not present, try to find it
341 # under codespell's install directory: <codespell_root>/data/dictionary.txt
345 import os.path as op
346 import codespell_lib
350 EOF
354 }
355 }
357 # $help is 1 if either -h, --help or --version is passed as option - exitcode: 0
358 # $help is 2 if invalid option is passed - exitcode: 1
374 }
389 }
391 #if no filenames are given, push '-' to read patch from stdin
394 }
396 # skip TAB size 1 to avoid additional checks on $tabsize - 1
413 }
414 }
423 }
425 }
426 }
436 ## no critic
439 }
446 }
452 }
459 }
460 }
465 }
466 }
476 __user|
477 __kernel|
478 __force|
479 __iomem|
480 __must_check|
481 __kprobes|
482 __ref|
483 __refconst|
484 __refdata|
485 __rcu|
486 __private
494 # Notes to $Attribute:
495 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
497 const|
498 volatile|
499 __percpu|
500 __nocast|
501 __safe|
502 __bitwise|
503 __packed__|
504 __packed2__|
505 __naked|
506 __maybe_unused|
507 __always_unused|
508 __noreturn|
509 __used|
510 __cold|
511 __pure|
512 __noclone|
513 __deprecated|
514 __read_mostly|
515 __ro_after_init|
516 __kprobes|
519 ____cacheline_aligned|
520 ____cacheline_aligned_in_smp|
521 ____cacheline_internodealigned_in_smp|
522 __weak|
545 <=|>=|==|!=|
546 =>|->|<<|>>|<|>|!|~|
580 )};
583 atomic_t
584 )};
586 FILE
587 )};
593 )};
599 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
600 TP_printk|
602 panic|
605 )};
613 # dev_alloc_skb/netdev_alloc_skb, et al
614 dma_alloc_coherent
615 )};
625 To:|
626 Cc:
627 )};
631 #Create a search and print patterns for all these strings to be used directly below
638 }
642 }
646 [=-]*> |
647 <[=-]* |
648 \[ |
649 \] |
650 start |
651 called |
652 entered |
653 entry |
654 enter |
656 inside |
657 here |
658 begin |
660 end |
661 done |
662 leave |
663 completed |
664 out |
667 )};
673 # if underflow, return
675 }
680 }
681 }
683 }
693 # two dimensional array storing minimum edit distance
708 }
709 }
710 }
712 }
719 );
722 }
725 }
735 \Qspinics.net\E
736 )};
755 );
778 );
799 )};
806 );
810 );
817 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
824 );
828 #Create a search pattern for all these functions to speed up a loop below
833 }
851 );
853 #Create a search pattern for all these strings to speed up a loop below
858 }
862 S_IWUGO |
863 S_IWOTH |
864 S_IRWXUGO |
865 S_IALLUGO |
886 );
888 #Create a search pattern for all these strings to speed up a loop below
893 }
920 }
924 }
927 irq|
928 memory|
930 reboot
931 )};
932 # memory.h: ARM has a custom one
934 # Load common spelling mistakes and build regular expression list.
951 }
955 }
974 }
978 }
979 }
998 }
1002 }
1005 }
1008 }
1014 }
1021 }
1039 )
1046 )
1055 )
1059 $NonptrType
1064 $NonptrTypeMisordered
1070 }
1071 build_types();
1075 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
1076 # requires at least perl version v5.10.0
1077 # Any use must be runtime checked with $^V
1088 )};
1095 );
1104 }
1109 }
1133 }
1134 }
1135 }
1145 $maintained_status{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
1146 }
1149 }
1154 return 1 if (!$tree || which("python3") eq "" || !(-x "$root/scripts/spdxcheck.py") || !(-e "$gitroot"));
1160 }
1173 my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include`;
1184 }
1186 }
1194 }
1198 }
1203 }
1207 }
1215 }
1217 }
1218 }
1228 }
1242 # Maybe one day convert this block of bash into something that returns
1243 # all matching commit ids, but it's very slow...
1244 #
1245 # echo "checking commits $1..."
1246 # git rev-list --remotes | grep -i "^$1" |
1247 # while read line ; do
1248 # git log --format='%H %s' -1 $line |
1249 # echo "commit $(cut -c 1-12,41-)"
1250 # done
1251 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./ ||
1257 }
1260 }
1272 # If input is git commits, extract all commits from the commit expressions.
1273 # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
1286 }
1295 }
1296 }
1299 }
1319 }
1326 }
1331 }
1338 }
1342 }
1351 build_types();
1353 }
1364 EOM
1365 }
1371 EOM
1372 }
1373 }
1384 );
1389 }
1390 }
1392 }
1417 # If there's a name left after stripping spaces and
1418 # leading quotes, and the address doesn't have both
1419 # leading and trailing angle brackets, the address
1420 # is invalid. ie:
1421 # "joe smith joe@smith.com" bad
1422 # "joe smith <joe@smith.com" bad
1427 }
1428 }
1430 # Extract comments from names excluding quoted parts
1431 # "John D. (Doe)" - Do not extract
1434 }
1437 }
1448 }
1451 }
1465 }
1476 }
1479 }
1486 }
1498 }
1506 }
1507 }
1510 }
1518 }
1519 }
1522 }
1535 }
1537 }
1540 }
1543 }
1547 }
1552 # Drop the diff line leader and expand tabs
1556 # Pick the indent from the front of the line.
1560 }
1571 }
1572 }
1583 # Always copy over the diff marker.
1589 # Comments we are whacking completely including the begin
1590 # and end, all to $;.
1597 }
1603 }
1610 }
1612 # A \ in a string means ignore the next character.
1618 }
1619 # Regular quotes.
1628 }
1629 }
1631 #print "c<$c> SQ<$sanitise_quote>\n";
1640 }
1641 }
1645 }
1647 # The pathname on a #include may be surrounded by '<' and '>'.
1652 # The whole of a #error is a string.
1656 }
1661 }
1664 }
1672 }
1695 #warn "CSB: blk<$blk> remain<$remain>\n";
1696 # If we are about to drop off the end, pull in more
1697 # context.
1708 }
1709 # Bail if there is no further context.
1710 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
1713 }
1717 }
1718 }
1723 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1725 # Handle nested #if/#else.
1732 }
1734 # Statement ends at the ';' or a close '}' at the
1735 # outermost level.
1738 }
1740 # An else is really a conditional as long as its not else if
1747 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1748 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1749 }
1754 }
1762 #warn "CSB: mark coff<$coff>\n";
1763 }
1764 }
1768 }
1776 }
1778 }
1779 }
1780 # Preprocessor commands end at the newline unless escaped.
1786 }
1788 }
1789 # We are truly at the end, so shuffle to the next line.
1794 }
1799 #warn "STATEMENT<$statement>\n";
1800 #warn "CONDITION<$condition>\n";
1802 #print "coff<$coff> soff<$off> loff<$loff>\n";
1806 }
1811 # Strip the diff line prefixes and rip blank lines at start and end.
1819 }
1827 }
1848 }
1849 }
1857 # Grab the first conditional/block pair.
1860 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1864 }
1866 # Pull in the following conditional/block pairs and see if they
1867 # could continue the statement.
1871 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1873 #print "C: push\n";
1875 }
1878 }
1897 # Handle nested #if/#else.
1904 }
1907 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1911 }
1918 }
1919 }
1923 }
1926 }
1929 }
1935 }
1941 }
1947 }
1952 }
1957 }
1962 # If c99 comment on the current line, or the line before or after
1970 # Catch a comment on the end of the line itself.
1974 # Look through the context and try and figure out if there is a
1975 # comment.
1980 #warn " $line\n";
1983 }
1986 }
1989 }
1993 }
1994 }
1998 }
2003 ##print "LINE: $rawlines[$end_line - 1 ]\n";
2004 ##print "CMMT: $cmt\n";
2007 }
2020 }
2023 }
2031 }
2034 }
2042 }
2045 }
2057 }
2058 }
2062 }
2074 }
2094 }
2115 }
2144 # Assume all arms of the conditional end as this
2145 # one does, and continue as if the #endif was not here.
2162 }
2193 }
2205 }
2238 }
2253 }
2262 }
2266 }
2270 }
2271 }
2274 }
2283 DEFINE_\S+
2284 )$|
2288 case|
2292 \#|
2293 \#\#|
2299 # Check for modifiers.
2310 }
2311 }
2316 }
2317 build_types();
2320 }
2321 }
2333 }
2341 }
2350 }
2351 }
2356 }
2364 }
2368 }
2374 }
2379 }
2383 }
2394 }
2395 }
2422 }
2428 }
2435 }
2440 }
2443 }
2446 }
2454 };
2456 }
2464 };
2467 }
2476 }
2478 }
2486 }
2488 }
2496 }
2498 }
2504 ##print "absolute<$absolute>\n";
2506 # See if any suffix of this path is a path within the tree.
2509 ##print "file<$file>\n";
2511 }
2512 }
2515 }
2517 # It is, so see if the prefix is acceptable.
2521 ##print "prefix<$prefix>\n";
2525 }
2526 }
2534 }
2542 }
2550 }
2558 }
2567 #convert leading spaces to tabs
2569 #Remove spaces before a tab
2573 }
2587 }
2599 }
2600 }
2603 }
2612 }
2613 }
2616 }
2621 # Do not check for BPF programs (tools/testing/selftests/bpf/progs/*.c, samples/bpf/*_kern.c, *.bpf.c).
2625 }
2673 # Trace the real file/line as we go.
2686 # suppression flags
2694 # Pre-scan the patch sanitizing the lines.
2695 # Pre-scan the patch looking for any __setup documentation.
2696 #
2704 sanitise_line_reset();
2716 }
2717 #next;
2718 }
2725 }
2728 # Guestimate if this is a continuing comment. Run
2729 # the context looking for a comment "edge". If this
2730 # edge is a close comment then we must be in a comment
2731 # at context start.
2738 #print "RAW<$rawlines[$ln - 1]>\n";
2744 }
2745 }
2748 }
2750 # Guestimate if this is a continuing comment. If this
2751 # is the start of a diff block and this line starts
2752 # ' *' then it is very likely a comment.
2755 {
2757 }
2759 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
2763 # Standardise the strings and chars within the input to
2764 # simplify matching -- only bother with positive lines.
2766 }
2773 }
2775 #print "==>$rawline\n";
2776 #print "-->$line\n";
2780 }
2781 }
2797 # check if it's a mode change, rename or start of a patch
2803 }
2805 #extract the line range in the file after the patch is applied
2816 }
2817 annotate_reset();
2828 }
2831 # track the line number as we move through the hunk, note that
2832 # new versions of GNU diff omit the leading space on completely
2833 # blank context lines so we need to count that too.
2838 # Measure the line length and indent.
2841 # Track the previous line.
2846 #warn "line<$line>\n";
2850 }
2858 # extract the filename as it passes
2874 }
2878 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2879 }
2881 }
2883 #make up the handle for any error we report on this line
2891 }
2892 }
2897 "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n");
2898 }
2903 }
2914 "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
2915 }
2916 }
2919 }
2929 # Verify the existence of a commit log if appropriate
2930 # 2 is used because a $signature is counted in $commit_log_lines
2934 }
2939 }
2941 # Check if the commit log has what seems like a diff which can confuse patch
2950 }
2952 # Check for incorrect file permissions
2959 }
2960 }
2962 # Check the patch for a From:
2968 }
2972 }
2974 # Check the patch for a signoff:
3001 }
3004 }
3007 }
3008 }
3009 }
3010 }
3011 }
3013 # Check for patch separator
3017 }
3019 # Check if MAINTAINERS is being updated. If so, there's probably no need to
3020 # emit the "does MAINTAINERS need updating?" message on file add/move/delete
3023 }
3025 # Check signature styles
3044 }
3045 }
3046 }
3053 }
3054 }
3061 }
3063 }
3070 }
3071 }
3082 # Don't force email to have quotes
3083 # Allow just an angle bracketed address
3089 }
3090 }
3092 # Address part shouldn't have comments
3100 }
3101 }
3103 # Only one name comment should be allowed
3108 }
3111 # stable@vger.kernel.org or stable@kernel.org shouldn't
3112 # have an email name. In addition comments should strictly
3113 # begin with a #
3121 # Remove brackets enclosing comment text
3122 # and # from start of comments to get comment text
3135 }
3136 }
3140 # Extract comment text from within brackets or
3141 # c89 style /*...*/ comments
3146 $new_comment =~ s/^[^\w]$//; # Single lettered comment with non word character is usually a typo
3154 }
3155 }
3156 }
3158 # Check for duplicate signatures
3167 }
3169 # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
3173 "Co-developed-by: should not be used to attribute nominal patch author '$author'\n" . $herecurr);
3174 }
3180 "Co-developed-by: must be immediately followed by Signed-off-by:\n" . $herecurr . $rawlines[$linenr] . "\n");
3183 "Co-developed-by and Signed-off-by: name/email do not match\n" . $herecurr . $rawlines[$linenr] . "\n");
3184 }
3185 }
3187 # check if Reported-by: is followed by a Closes: tag
3191 "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . "\n");
3194 "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
3195 }
3196 }
3197 }
3199 # These indicate a bug fix
3203 }
3208 }
3210 # Check Fixes: styles is correct
3219 # Always strip leading/trailing parens then double quotes if existing
3224 }
3227 }
3243 "Please use correct Fixes: style 'Fixes: <12 chars of sha1> (\"<title line>\")' - ie: 'Fixes: $cid (\"$ctitle\")'\n" . $herecurr) &&
3246 }
3247 }
3248 }
3250 # Check email subject for common tools that don't need to be mentioned
3255 }
3257 # Check for Gerrit Change-Ids not in any patch context
3263 }
3264 }
3266 # Check if the commit log is in a possible stack dump
3270 # timestamp
3274 # stack dump address styles
3276 }
3278 # Check for line lengths > 75 in commit log, warn once
3282 # file delta changes
3284 # filename then :
3286 # A Fixes:, link or signature tag line
3291 }
3293 # Reset possible stack dump if a blank line is found
3297 }
3299 # Check for odd tags before a URI/URL
3308 }
3309 }
3311 # Check for misuse of the link tags
3319 }
3320 }
3322 # Check for lines starting with a #
3328 }
3329 }
3331 # Check for git id commit length and improperly formed commit descriptions
3332 # A correctly formed commit description is:
3333 # commit <SHA-1 hash length 12+ chars> ("Complete commit subject")
3334 # with the commit subject '("' prefix and '")' suffix
3335 # This is a fairly compilicated block as it tests for what appears to be
3336 # bare SHA-1 hash with minimum length of 5. It also avoids several types of
3337 # possible SHA-1 matches.
3338 # A commit match can span multiple lines so this block attempts to find a
3339 # complete typical commit on a maximum of 3 lines
3345 ($line =~ /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||
3368 # Always strip leading/trailing parens then double quotes if existing
3373 }
3375 }
3379 }
3381 }
3392 }
3401 "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herectx);
3402 }
3403 #don't report the next line if this line ends in commit and the sha1 hash is the next line
3405 }
3407 # Check for mailing list archives other than lore.kernel.org
3410 "Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr);
3411 }
3413 # Check for added, moved or deleted files
3423 }
3425 # Check for adding new DT bindings not in schema format
3430 "DT bindings should be in DT schema format. See: Documentation/devicetree/bindings/writing-schema.rst\n");
3431 }
3433 # Check for wrappage within a valid hunk of the file
3438 }
3440 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
3451 }
3453 # Check if it's the start of a commit log
3454 # (not a header line and we haven't seen the patch filename)
3461 }
3463 # Check if there is UTF-8 in a commit log when a mail header has explicitly
3464 # declined it, i.e defined some charset where it is missing.
3469 }
3475 }
3477 # Check for absolute kernel paths in commit message
3484 #
3487 }
3488 }
3489 }
3491 # Check for various typo / spelling mistakes
3508 }
3509 }
3510 }
3512 # check for invalid commit id
3520 }
3521 }
3523 # check for repeated words separated by a single space
3524 # avoid false positive from list command eg, '-rw-r--r-- 1 root root'
3537 }
3542 # check for character before and after the word matches
3551 # avoid repeating hex occurrences like 'ff ff fe 09 ...'
3554 }
3560 }
3561 }
3563 # if it's a repeated word on consecutive lines in a comment block
3572 }
3573 }
3574 }
3575 }
3577 # ignore non-hunk lines and lines being removed
3580 #trailing whitespace
3587 }
3594 }
3597 }
3599 # Check for FSF mailing addresses.
3608 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
3609 }
3611 # check for Kconfig help text having a real description
3612 # Only applies when adding the entry originally, after that we do not have
3613 # sufficient context to determine whether it is indeed long enough.
3615 # 'choice' is usually the last thing on the line (though
3616 # Kconfig supports named choices), so use a word boundary
3617 # (\b) rather than a whitespace character (\s)
3632 }
3636 }
3643 # At the end of this Kconfig block:
3644 # This only checks context lines in the patch
3645 # and so hopefully shouldn't trigger false
3646 # positives, even though some of these are
3647 # common words in help texts
3651 }
3653 }
3658 "please write a help paragraph that fully describes the config symbol\n" . "$here\n$stat_real\n");
3659 }
3660 }
3662 # check MAINTAINERS entries
3664 # check MAINTAINERS entries for the right form
3671 }
3672 }
3673 # check MAINTAINERS entries for the right ordering too
3697 }
3698 }
3699 }
3700 }
3710 };
3713 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
3714 }
3716 # check for DT compatible documentation
3735 }
3742 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
3743 }
3744 }
3745 }
3747 # check for using SPDX license tag at beginning of files
3761 }
3763 # check SPDX comment style for .[chsS] files
3769 }
3780 }
3789 $fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)/;
3790 }
3791 }
3796 }
3797 }
3798 }
3799 }
3801 # check for embedded filenames
3805 }
3807 # check we are in a valid source file if not then ignore this hunk
3810 # check for using SPDX-License-Identifier on the wrong line number
3816 }
3818 # line length limit (with some exclusions)
3819 #
3820 # There are a few types of lines that may extend beyond $max_line_length:
3821 # logging functions like pr_info that end in a string
3822 # lines with a single string
3823 # #defines that are a single string
3824 # lines with an RFC3986 like URL
3825 #
3826 # There are 3 different line length message types:
3827 # LONG_LINE_COMMENT a comment starts before but extends beyond $max_line_length
3828 # LONG_LINE_STRING a string starts before but extends beyond $max_line_length
3829 # LONG_LINE all other lines longer than $max_line_length
3830 #
3831 # if LONG_LINE is ignored, the other 2 types are also ignored
3832 #
3837 # Check the allowed long line types first
3839 # logging functions that end in a string that starts
3840 # before $max_line_length
3841 if ($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(?:KERN_\S+\s*|[^"]*))?($String\s*(?:|,|\)\s*;)\s*)$/ &&
3845 # lines with only strings (w/ possible termination)
3846 # #defines with only strings
3851 # More special cases
3856 # URL ($rawline is used in case the URL is in a comment)
3860 # Otherwise set the alternate message types
3862 # a comment starts before $max_line_length
3867 # a quoted string starts before $max_line_length
3871 }
3879 }
3880 }
3882 # check for adding lines without a newline.
3883 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
3888 }
3889 }
3891 # check for .L prefix local symbols in .S files
3895 "Avoid using '.L' prefixed local symbol names for denoting a range of code via 'SYM_*_START/END' annotations; see Documentation/core-api/asm-annotations.rst\n" . $herecurr);
3896 }
3898 # check we are in a valid source file C or perl if not then ignore this hunk
3901 # at the beginning of a line any tabs must come first and anything
3902 # more than $tabsize must use tabs.
3911 }
3912 }
3914 # check for space before tabs.
3924 }
3925 }
3927 # check for assignments on the start of a line
3933 # add assignment operator to the previous line, remove from current line
3936 }
3937 }
3939 # check for && or || at the start of a line
3945 # insert logical operator at last non-comment, non-whitepsace char on previous line
3950 }
3951 }
3953 # check indentation starts on a tab stop
3955 $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=])/) {
3962 }
3963 }
3964 }
3966 # check multi-line statement indentation matches previous line
3968 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|(?:\*\s*)*$Lval\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
3991 }
3992 }
3993 }
3994 }
3996 # check for space after cast like "(int) foo" or "(struct foo) bar"
3997 # avoid checking a few false positives:
3998 # "sizeof(<type>)" or "__alignof__(<type>)"
3999 # function pointer declarations like "(*foo)(int) = bar;"
4000 # structure definitions like "(struct foo) { 0 };"
4001 # multiline macros that define functions
4002 # known attributes or the __attribute__ keyword
4010 }
4011 }
4013 # Block comments use * on subsequent lines
4021 }
4023 # Block comments use */ on trailing lines
4030 }
4032 # Block comment * alignment
4046 }
4053 }
4054 }
4056 # check for missing blank lines after struct/union declarations
4057 # with exceptions for various attributes and macros
4073 }
4074 }
4076 # check for multiple consecutive blank lines
4084 }
4087 }
4089 # check for missing blank lines after declarations
4090 # (declarations must have the same indentation and not be at the start of line)
4092 # use temporaries
4095 # remove $Attribute/$Sparse uses to simplify comparisons
4099 # function pointer declarations
4101 # foo bar; where foo is some local typedef or #define
4103 # known declaration macros
4105 # for "else if" which can look like "$Ident $Ident"
4107 # other possible extensions of declaration lines
4109 # not starting a section or a macro "\" extended line
4111 # looks like a declaration
4113 # function pointer declarations
4115 # foo bar; where foo is some local typedef or #define
4117 # known declaration macros
4119 # start of struct or union or enum
4121 # start or end of block or continuation of declaration
4123 # bitfield continuation
4125 # other possible extensions of declaration lines
4131 }
4132 }
4133 }
4135 # check for spaces at the beginning of a line.
4136 # Exceptions:
4137 # 1) within comments
4138 # 2) indented preprocessor commands
4139 # 3) hanging labels
4146 }
4147 }
4149 # check we are in a valid C source file if not then ignore this hunk
4152 # check for unusual line ending [ or (
4156 }
4158 # check if this appears to be the start function declaration, save the name
4162 }
4164 # check if this appears to be the end of function declaration
4167 }
4169 # check indentation of any line with a bare else
4170 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
4171 # if the previous line is a break or return and is indented 1 tab more...
4180 }
4181 }
4183 # check indentation of a line with a break;
4184 # if the previous line is a goto, return or break
4185 # and is indented the same # of tabs
4193 }
4194 }
4195 }
4197 # check for RCS/CVS revision markers
4201 }
4203 # check for old HOTPLUG __dev<foo> section markings
4207 }
4209 # Check for potential 'bare' types
4212 #print "LINE<$line>\n";
4220 #print "linenr<$linenr> <$stat>\n";
4221 # If this statement has no statement boundaries within
4222 # it there is no point in retrying a statement scan
4223 # until we hit end of it.
4226 #print "skip<$line_nr_next>\n";
4228 }
4230 # Find the real next line.
4236 }
4241 # Ignore goto labels.
4244 # Ignore functions being called
4249 # declarations always start with types
4250 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
4255 # definitions in global scope can only start with types
4258 }
4260 # any (foo ... *) is a pointer cast, and foo is a type
4263 }
4265 # Check for any sort of function declaration.
4266 # int foo(something bar, other baz);
4267 # void (*store_gdt)(x86_descr_ptr *);
4268 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
4276 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
4279 }
4280 }
4281 }
4283 }
4285 #
4286 # Checks which may be anchored in the context.
4287 #
4289 # Check for switch () and associated case and default
4290 # statements should be at the same indent.
4304 }
4305 }
4309 }
4310 }
4312 # if/while/etc brace do not go on next line, unless defining a do while loop,
4313 # or if that brace on the next line is for something else
4314 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
4322 }
4333 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
4336 }
4338 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
4339 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
4345 }
4349 {
4355 }
4356 }
4357 }
4359 # Check relative indent for conditionals and blocks.
4360 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(?:do|else)\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
4368 # remove inline comments
4372 # Find out how long the conditional actually is.
4376 # Make sure we remove the line prefixes as we have
4377 # none on the first line, and are going to readd them
4378 # where necessary.
4382 }
4384 # We want to check the first line inside the block
4385 # starting at the end of the conditional, so remove:
4386 # 1) any blank line termination
4387 # 2) any opening brace { on end of the line
4388 # 3) any do (...) {
4395 }
4399 }
4401 # Also ignore a loop construct at the end of a
4402 # preprocessor statement.
4406 }
4413 # If we see an #else/#elif then the code
4414 # is not linear.
4417 }
4419 # Ignore:
4420 # 1) blank lines, they should be at 0,
4421 # 2) preprocessor lines, and
4422 # 3) labels.
4430 }
4431 }
4432 }
4437 # Check if either of these lines are modified, else
4438 # this is not this patch's fault.
4442 }
4445 }
4447 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
4456 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
4457 }
4458 }
4460 # Track the 'values' across context and added lines.
4470 }
4473 #ignore lines not being added
4476 # check for self assignments used to avoid compiler warnings
4477 # e.g.: int foo = foo, *bar = NULL;
4478 # struct foo bar = *(&(bar));
4481 if ($line =~ /^\+\s*(?:$Declare)?$var\s*=\s*(?:$var|\*\s*\(?\s*&\s*\(?\s*$var\s*\)?\s*\)?)\s*[;,]/) {
4484 }
4485 }
4487 # check for dereferences that span multiple lines
4497 }
4499 # check for declarations of signed or unsigned without int
4500 while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
4511 "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
4519 }
4520 }
4521 }
4523 # TEST: allow direct testing of the type matcher.
4531 }
4533 }
4534 # TEST: allow direct testing of the attribute matcher.
4542 }
4544 }
4546 # check for initialisation to aggregates open brace on the next line
4560 }
4561 }
4563 #
4564 # Checks which are anchored on the added line.
4565 #
4567 # check for malformed paths in #include statements (uses RAW line)
4573 }
4577 }
4578 }
4580 # no C99 // comments
4589 }
4590 }
4591 }
4592 # Remove C99 comments.
4596 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
4597 # the whole statement.
4598 #print "APW <$lines[$realline_next - 1]>\n";
4603 # Handle definitions which produce identifiers with
4604 # a prefix:
4605 # XXX(foo);
4606 # EXPORT_SYMBOL(something_foo);
4611 #print "FOO C name<$name>\n";
4622 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
4626 }
4627 }
4631 #print "FOO B <$lines[$linenr - 1]>\n";
4633 }
4638 }
4640 # check for global initialisers.
4647 }
4648 }
4649 # check for static initialisers.
4656 }
4657 }
4659 # check for misordered declarations of char/short/int/long with signed/unsigned
4663 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
4664 }
4666 # check for unnecessary <signed> int declarations of short/long/long long
4683 }
4684 }
4686 # check for static const char * arrays.
4691 }
4693 # check for initialized const char arrays that should be static const
4694 if ($line =~ /^\+\s*const\s+(char|unsigned\s+char|_*u8|(?:[us]_)?int8_t)\s+\w+\s*\[\s*(?:\w+\s*)?\]\s*=\s*"/) {
4699 }
4700 }
4702 # check for static char foo[] = "bar" declarations.
4707 }
4709 # check for const <foo> const where <foo> is not a pointer or array type
4718 }
4719 }
4721 # check for const static or static <non ptr type> const declarations
4722 # prefer 'static const <foo>' over 'const static <foo>' and 'static <foo> const'
4730 }
4731 }
4733 # check for non-global char *foo[] = {"bar", ...} declarations.
4738 }
4740 # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
4743 if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {
4749 }
4750 }
4751 }
4753 # check for function declarations without arguments like "int foo()"
4759 }
4760 }
4762 # check for new typedefs, only function parameters and sparse annotations
4763 # make sense.
4771 }
4773 # * goes on variable not on type
4774 # (char*[ const])
4776 #print "AA<$1>\n";
4779 # Should start with a space.
4781 # Should not end with a space.
4783 # '*'s should not have spaces between.
4785 }
4787 ## print "1: from<$from> to<$to> ident<$ident>\n";
4797 }
4798 }
4799 }
4801 #print "BB<$1>\n";
4804 # Should start with a space.
4806 # Should not end with a space.
4808 # '*'s should not have spaces between.
4810 }
4811 # Modifiers should have spaces.
4814 ## print "2: from<$from> to<$to> ident<$ident>\n";
4825 }
4826 }
4827 }
4829 # do not use BUG() or variants
4830 if ($line =~ /\b(?!AA_|BUILD_|DCCP_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
4834 "Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants\n" . $herecurr);
4835 }
4837 # avoid LINUX_VERSION_CODE
4840 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
4841 }
4843 # check for uses of printk_ratelimit
4847 }
4849 # printk should use KERN_* levels
4853 }
4855 # prefer variants of (subsystem|netdev|dev|pr)_<level> to printk(KERN_<LEVEL>
4868 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to $printk(KERN_$orig ...\n" . $herecurr);
4869 }
4871 # prefer dev_<level> to dev_printk(KERN_<LEVEL>
4879 }
4881 # trace_printk should not be used in production code.
4884 "Do not use $1() in production code (this can be ignored if built only with a debug config option)\n" . $herecurr);
4885 }
4887 # ENOSYS means "bad syscall nr" and nothing else. This will have a small
4888 # number of false positives, but assembly files are not checked, so at
4889 # least the arch entry code will not trigger this warning.
4893 }
4895 # ENOTSUPP is not a standard error code and should be avoided in new patches.
4896 # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP.
4897 # Similarly to ENOSYS warning a small number of false positives is expected.
4903 }
4904 }
4906 # function brace can't be on same line, except for #defines of do while,
4907 # or if closed on same line
4924 }
4925 }
4926 }
4928 # open braces for enum, union and struct go on the same line.
4942 }
4943 }
4944 }
4946 # missing space after union, struct or enum definition
4953 }
4954 }
4956 # Function pointer declarations
4957 # check spacing between type, funcptr, and args
4958 # canonical declaration is "type (*funcptr)(args...)"
4967 # the $Declare variable will capture all spaces after the type
4968 # so check it for a missing trailing missing space but pointer return types
4969 # don't need a space so don't warn for those.
4974 }
4979 }
4981 # unnecessary space "type (*funcptr)(args...)"
4982 # This test is not currently implemented because these declarations are
4983 # equivalent to
4984 # int foo(int bar, ...)
4985 # and this is form shouldn't/doesn't generate a checkpatch warning.
4986 #
4987 # elsif ($declare =~ /\s{2,}$/) {
4988 # WARN("SPACING",
4989 # "Multiple spaces after return type\n" . $herecurr);
4990 # }
4992 # unnecessary space "type ( *funcptr)(args...)"
4997 }
4999 # unnecessary space "type (* funcptr)(args...)"
5004 }
5006 # unnecessary space "type (*funcptr )(args...)"
5011 }
5013 # unnecessary space "type (*funcptr) (args...)"
5018 }
5022 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
5023 }
5024 }
5026 # check for spacing round square brackets; allowed:
5027 # 1. with a type on the left -- int [] a;
5028 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
5029 # 3. inside a curly brace -- = { [0...10] = 5 }
5040 }
5041 }
5042 }
5044 # check for spaces between functions and their parentheses.
5050 # Ignore those directives where spaces _are_ permitted.
5056 {
5057 # cpp #define statements have non-optional spaces, ie
5058 # if there is a space between the name and the open
5059 # parenthesis it is simply not a parameter group.
5062 # cpp #elif statement condition may start with a (
5065 # If this whole things ends with a type its most
5066 # likely a typedef for a function.
5075 }
5076 }
5077 }
5079 # Check operator spacing.
5085 <<=|>>=|<=|>=|==|!=|
5087 =>|->|<<|>>|<|>|=|!|~|
5093 ## print("element count: <" . $#elements . ">\n");
5094 ## foreach my $el (@elements) {
5095 ## print("el: <$el>\n");
5096 ## }
5104 }
5115 ## print("n: <$n> good: <$good>\n");
5119 # Pick up the preceding and succeeding characters.
5124 }
5147 }
5156 # Pull out the value of this operator.
5159 # Get the full operator variant.
5162 # Ignore operators passed as parameters.
5166 # # Ignore comments
5167 # } elsif ($op =~ /^$;+$/) {
5169 # ; should have either the end of line or a space or \ after it
5177 }
5178 }
5180 # // is a comment
5183 # : when part of a bitfield
5185 # skip the bitfield test for now
5187 # No spaces for:
5188 # ->
5196 }
5198 }
5199 }
5201 # , must not have a space before and must have a space on the right.
5210 }
5211 }
5218 }
5219 }
5225 }
5228 }
5229 }
5231 # '*' as part of a type definition -- reported already.
5233 #warn "'*' is part of type\n";
5235 # unary operators should have a space before and
5236 # none after. May be left adjacent to another
5237 # unary operator, or a cast
5247 }
5248 }
5249 }
5251 # A unary '*' may be const
5259 }
5261 }
5262 }
5264 # unary ++ and unary -- are allowed no space on one side.
5271 }
5272 }
5279 }
5280 }
5287 }
5289 }
5290 }
5292 # << and >> may either have or not have spaces both sides
5298 {
5306 }
5312 }
5313 }
5320 }
5322 }
5323 }
5325 # A colon needs no spaces before when it is
5326 # terminating a case value or a label.
5333 }
5334 }
5336 # All the others need spaces both sides.
5340 # Ignore email addresses <foo@bar>
5345 {
5347 }
5349 # for asm volatile statements
5350 # ignore a colon with another
5351 # colon immediately before or after
5355 }
5357 # messages are ERROR, but ?: are CHK
5367 }
5369 }
5370 }
5371 }
5374 ## print("n: <$n> GOOD: <$good>\n");
5377 }
5381 }
5385 }
5388 }
5390 # check for whitespace before a non-naked semicolon
5397 }
5398 }
5400 # check for multiple assignments
5404 }
5406 ## # check for multiple declarations, allowing for a function declaration
5407 ## # continuation.
5408 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
5409 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
5410 ##
5411 ## # Remove any bracketed sections to ensure we do not
5412 ## # falsely report the parameters of functions.
5413 ## my $ln = $line;
5414 ## while ($ln =~ s/\([^\(\)]*\)//g) {
5415 ## }
5416 ## if ($ln =~ /,/) {
5417 ## WARN("MULTIPLE_DECLARATION",
5418 ## "declaring multiple variables together should be avoided\n" . $herecurr);
5419 ## }
5420 ## }
5422 #need space before brace following if, while, etc
5429 }
5430 }
5432 ## # check for blank lines before declarations
5433 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
5434 ## $prevrawline =~ /^.\s*$/) {
5435 ## WARN("SPACING",
5436 ## "No blank lines before declarations\n" . $hereprev);
5437 ## }
5438 ##
5440 # closing brace should have a space following it when it has anything
5441 # on the line
5448 }
5449 }
5451 # check spacing on square brackets
5458 }
5459 }
5466 }
5467 }
5469 # check spacing on parentheses
5477 }
5478 }
5487 }
5488 }
5490 # check unnecessary parentheses around addressof/dereference single $Lvals
5491 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
5499 }
5500 }
5502 # check for unnecessary parentheses around function pointer uses
5503 # ie: (foo->bar)(); should be foo->bar();
5504 # but not "if (foo->bar) (" to avoid some false positives
5513 }
5514 }
5516 # check for unnecessary parentheses around comparisons in if uses
5517 # when !drivers/staging or command-line uses --strict
5524 while ($test =~ /(?:^|[^\w\&\!\~])+\s*\(\s*([\&\!\~]?\s*$Lval\s*(?:$Compare\s*$FuncArg)?)\s*\)/g) {
5526 # avoid parentheses around potential macro args
5535 }
5536 }
5539 }
5540 }
5542 # check that goto labels aren't indented (allow a single space indentation)
5543 # and ignore bitfield definitions like foo:1
5544 # Strictly, labels can have whitespace after the identifier and before the :
5545 # but this is not allowed here as many ?: uses would appear to be labels
5554 }
5555 }
5557 # check if a statement with a comma should be two statements like:
5558 # foo = bar(), /* comma should be semicolon */
5559 # bar = baz();
5561 $stat =~ /^\+\s*(?:$Lval\s*$Assignment\s*)?$FuncArg\s*,\s*(?:$Lval\s*$Assignment\s*)?$FuncArg\s*;\s*$/) {
5566 }
5568 # return is not a function
5578 }
5582 }
5583 }
5585 # unnecessary return in a void function
5586 # at end-of-function, with the previous line a single leading tab, then return;
5587 # and the line before that not a goto label target like "out:"
5595 }
5597 # if statements using unnecessary parentheses - ie: if ((foo == bar))
5603 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
5608 }
5609 }
5611 # comparisons with a constant or upper case identifier on the left
5612 # avoid cases like "foo + BAR < baz"
5613 # only fix matches surrounded by parentheses to avoid incorrect
5614 # conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
5635 }
5637 }
5638 }
5640 # Return of what appears to be an errno should normally be negative
5646 }
5647 }
5649 # Need a space before open parenthesis after if, while etc
5656 }
5657 }
5659 # Check for illegal assignment in if conditional -- and check for trailing
5660 # statements after the conditional.
5668 ##print "stat<$stat> stat_next<$stat_next>\n";
5671 # If the statement carries leading newlines,
5672 # then count those as offsets.
5680 }
5681 }
5692 if ($rawline =~ /^\+(\s+)if\s*\(\s*(\!)?\s*\(\s*(($Lval)\s*=\s*$LvalOrFunc)\s*\)\s*(?:($Compare)\s*($FuncArg))?\s*\)\s*(\{)?\s*$/) {
5712 }
5713 }
5714 }
5716 # Find out what is on the end of the line after the
5717 # conditional.
5723 {
5724 # Find out how long the conditional actually is.
5733 }
5747 }
5748 }
5749 }
5750 }
5752 # Check for bitwise tests written as boolean
5758 |
5763 {
5766 }
5768 # if and else should not have general statements after it
5775 }
5776 }
5777 # if should not continue a brace
5782 }
5783 # case and default should not have general statements after them
5789 {
5792 }
5794 # Check for }<nl>else {, these must be at the same
5795 # indent level to be relevant to each other.
5807 }
5811 }
5812 }
5818 # Find out what is on the end of the line after the
5819 # conditional.
5835 }
5836 }
5837 }
5839 #Specific variable tests
5843 #CamelCase
5846 #Ignore some autogenerated defines and enum values
5848 #Ignore Page<foo> variants
5850 #Ignore ETHTOOL_LINK_MODE_<foo> variants
5852 #Ignore SI style variants like nS, mV and dB
5853 #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
5855 #Ignore some three character SI units explicitly, like MiB and KHz
5861 seed_camelcase_includes();
5865 }
5866 }
5871 }
5872 }
5873 }
5874 }
5876 #no spaces allowed after \ in define
5882 }
5883 }
5885 # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
5886 # itself <asm/foo.h> (uses RAW line)
5893 {
5902 }
5903 }
5904 }
5905 }
5907 # multi-statement macros should be enclosed in a do while loop, grab the
5908 # first statement and ensure its the whole macro if its not enclosed
5909 # in a known good container
5921 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
5922 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
5937 }
5944 # Flatten any parentheses and braces
5948 {
5949 }
5951 # Flatten any obvious string concatenation.
5954 {
5955 }
5957 # Make asm volatile uses seem like a generic function
5962 module_param_named|
5963 MODULE_PARM_DESC|
5964 DECLARE_PER_CPU|
5965 DEFINE_PER_CPU|
5966 __typeof__\(|
5967 union|
5968 struct|
5973 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
5982 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
5988 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
5995 {
5998 "Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects\n" . "$herectx");
6005 }
6007 }
6009 # Make $define_stmt single line, comment-free, etc
6020 }
6021 }
6026 # check if any macro arguments are reused (ignore '...' and 'type')
6031 $tmp_stmt =~ s/\b(__must_be_array|offsetof|sizeof|sizeof_field|__stringify|typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;
6038 }
6039 # check if any macro arguments may have other precedence issues
6045 }
6047 # check if this is an unused argument
6051 }
6052 }
6054 # check for macros with flow control, but without ## concatenation
6055 # ## concatenation is commonly a macro that defines a function so ignore those
6062 }
6064 # check for line continuations outside of #defines, preprocessor #, and asm
6068 #print "REAL: $realfile\nln: $line\nkeys:", sort keys %maybe_linker_symbol;
6076 }
6077 }
6079 # do {} while (0) macro tests:
6080 # single-statement macros do not need to be enclosed in do while (0) loop,
6081 # macro should not end with a semicolon
6096 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
6108 }
6112 }
6120 }
6121 }
6123 # check for redundant bracing round if etc
6127 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
6128 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
6138 # If the condition carries leading newlines, then count those as offsets.
6143 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
6145 # We have looked at and allowed this specific line.
6155 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
6157 #print "APW: ALLOWED: cond<$cond>\n";
6159 }
6161 #print "APW: ALLOWED: block<$block>\n";
6163 }
6165 #print "APW: ALLOWED: lines block<$block>\n";
6167 }
6169 }
6174 }
6182 }
6183 }
6184 }
6185 }
6190 # Check the pre-context.
6192 #print "APW: ALLOWED: pre<$1>\n";
6194 }
6199 # Check the condition.
6201 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
6204 }
6206 #print "APW: ALLOWED: cond<$cond>\n";
6208 }
6210 #print "APW: ALLOWED: block<$block>\n";
6212 }
6214 #print "APW: ALLOWED: lines block<$block>\n";
6216 }
6217 # Check the post-context.
6222 }
6224 #print "APW: ALLOWED: chunk-1 block<$block>\n";
6226 }
6227 }
6234 }
6235 }
6237 # check for single line unbalanced braces
6241 }
6243 # check for unnecessary blank lines around braces
6249 }
6250 }
6256 }
6257 }
6259 # no volatiles please
6263 "Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . $herecurr);
6264 }
6266 # Check for user-visible strings broken across lines, which breaks the ability
6267 # to grep for the string. Make exceptions when the previous string ends in a
6268 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
6269 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
6282 }
6294 }
6296 }
6297 }
6299 # check for missing a space in a string concatenation
6303 }
6305 # check for an embedded function name in a string when the function is known
6306 # This does not work very well for -f --file checking as it depends on patch
6307 # context providing the function name or a single line form for in-file
6308 # function declarations
6314 "Prefer using '\"%s...\", __func__' to using '$context_function', this function's name, in a string\n" . $herecurr);
6315 }
6317 # check for unnecessary function tracing like uses
6318 # This does not use $logFunctions because there are many instances like
6319 # 'dprintk(FOO, "%s()\n", __func__);' which do not match $logFunctions
6320 if ($rawline =~ /^\+.*\([^"]*"$tracing_logging_tags{0,3}%s(?:\s*\(\s*\)\s*)?$tracing_logging_tags{0,3}(?:\\n)?"\s*,\s*__func__\s*\)\s*;/) {
6325 }
6326 }
6328 # check for spaces before a quoted newline
6334 }
6336 }
6338 # concatenated string without spaces between elements
6348 }
6349 }
6350 }
6352 # uncoalesced string fragments
6360 }
6361 }
6362 }
6364 # check for non-standard and hex prefixed decimal printf formats
6370 # check for %L
6375 }
6376 # check for %Z
6381 }
6382 # check for 0x<decimal>
6386 }
6387 }
6389 # check for line continuations in quoted strings with odd counts of "
6393 }
6395 # warn about #if 0
6399 }
6401 # warn about #if 1
6405 }
6407 # check for needless "if (<foo>) fn(<foo>)" uses
6411 if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?|(?:kmem_cache|mempool|dma_pool)_destroy)$expr/) {
6423 }
6428 }
6431 }
6435 }
6436 }
6437 }
6438 }
6440 # check for unnecessary "Out of Memory" messages
6449 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
6451 if ($s =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*$allocFunctions\s*\(/ &&
6455 }
6456 }
6458 # check for logging functions with KERN_<LEVEL>
6466 }
6467 }
6469 # check for logging continuations
6473 }
6475 # check for unnecessary use of %h[xudi] and %hh[xudi] in logging functions
6493 }
6494 }
6495 }
6497 # check for mask then right shift without a parentheses
6503 }
6505 # check for pointer comparisons to NULL
6515 }
6516 }
6517 }
6519 # check for bad placement of section $InitAttribute (e.g.: __initdata)
6522 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
6532 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
6533 }
6534 }
6535 }
6537 # check for $InitAttributeData (ie: __initdata) with const
6548 }
6549 }
6551 # check for $InitAttributeConst (ie: __initconst) without const
6563 }
6564 }
6566 # check for __read_mostly with const non-pointer (should just be const)
6573 }
6574 }
6576 # don't use __constant_<foo> functions outside of include/uapi/
6578 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
6586 }
6587 }
6589 # prefer usleep_range over udelay
6592 # ignore udelay's < 10, however
6595 "usleep_range is preferred over udelay; see function description of usleep_range() and udelay().\n" . $herecurr);
6596 }
6600 }
6601 }
6603 # warn about unexpectedly long msleep's
6607 "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr);
6608 }
6609 }
6611 # check for comparisons of jiffies
6614 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
6615 }
6617 # check for comparisons of get_jiffies_64()
6620 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
6621 }
6623 # warn about #ifdefs in C files
6624 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
6625 # print "#ifdef in C files should be avoided\n";
6626 # print "$herecurr";
6627 # $clean = 0;
6628 # }
6630 # warn about spacing in #ifdefs
6637 }
6639 }
6641 # check for spinlock_t definitions without a comment.
6648 }
6649 }
6650 # check for memory barriers without a comment.
6653 mb|
6654 rmb|
6655 wmb
6658 mb__before_atomic|
6659 mb__after_atomic|
6660 store_release|
6661 load_acquire|
6662 store_mb|
6675 }
6676 }
6686 }
6688 # check for waitqueue_active without a comment.
6693 }
6694 }
6696 # check for data_race without a comment.
6701 }
6702 }
6704 # check of hardware specific defines
6705 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
6708 }
6710 # check that the storage class is not after a type
6714 }
6715 # Check that the storage class is at the beginning of a declaration
6722 }
6724 # check the location of the inline attribute, that it is between
6725 # storage class and type.
6730 }
6732 # Check for __inline__ and __inline, prefer inline
6740 }
6741 }
6743 # Check for compiler attributes
6773 );
6788 }
6797 }
6798 }
6799 }
6801 # Check for __attribute__ unused, prefer __always_unused or __maybe_unused
6804 "__always_unused or __maybe_unused is preferred over __attribute__((__unused__))\n" . $herecurr);
6805 }
6806 }
6808 # Check for __attribute__ weak, or __weak declarations (may have link issues)
6810 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
6815 }
6817 # check for c99 types like uint8_t used outside of uapi/ and tools/
6832 }
6833 }
6834 }
6836 # check for cast of C90 native int or longer types constants
6848 }
6850 "Unnecessary typecast of c90 int constant - '$cast$const' could be '$const$suffix'\n" . $herecurr) &&
6853 }
6854 }
6856 # check for sizeof(&)
6860 }
6862 # check for sizeof without parenthesis
6867 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
6868 }
6869 }
6871 # check for struct spinlock declarations
6875 }
6877 # check for seq_printf uses that could be seq_puts
6886 }
6887 }
6888 }
6890 # check for vsprintf extension %p<foo> misuses
6918 }
6922 }
6924 "Using vsprintf specifier '\%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '\%p'.\n" . "$here\n$stat_real\n");
6925 }
6926 }
6938 }
6942 }
6943 }
6944 }
6946 # Check for misused memsets
6961 }
6962 }
6964 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
6965 # if ($perl_version_ok &&
6966 # defined $stat &&
6967 # $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
6968 # if (WARN("PREFER_ETHER_ADDR_COPY",
6969 # "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") &&
6970 # $fix) {
6971 # $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
6972 # }
6973 # }
6975 # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)
6976 # if ($perl_version_ok &&
6977 # defined $stat &&
6978 # $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
6979 # WARN("PREFER_ETHER_ADDR_EQUAL",
6980 # "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n")
6981 # }
6983 # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
6984 # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
6985 # if ($perl_version_ok &&
6986 # defined $stat &&
6987 # $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
6988 #
6989 # my $ms_val = $7;
6990 #
6991 # if ($ms_val =~ /^(?:0x|)0+$/i) {
6992 # if (WARN("PREFER_ETH_ZERO_ADDR",
6993 # "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") &&
6994 # $fix) {
6995 # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;
6996 # }
6997 # } elsif ($ms_val =~ /^(?:0xff|255)$/i) {
6998 # if (WARN("PREFER_ETH_BROADCAST_ADDR",
6999 # "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") &&
7000 # $fix) {
7001 # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;
7002 # }
7003 # }
7004 # }
7006 # strcpy uses that should likely be strscpy
7010 }
7012 # strlcpy uses that should likely be strscpy
7016 }
7018 # strncpy uses that should likely be strscpy or strscpy_pad
7021 "Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90\n" . $herecurr);
7022 }
7024 # ethtool_sprintf uses that should likely be ethtool_puts
7029 $fixed[$fixlinenr] =~ s/\bethtool_sprintf\s*\(\s*($FuncArg)\s*,\s*($FuncArg)/ethtool_puts($1, $7)/;
7030 }
7031 }
7033 # use $rawline because $line loses %s via sanitization and thus we can't match against it.
7038 $fixed[$fixlinenr] =~ s/\bethtool_sprintf\s*\(\s*($FuncArg)\s*,\s*"\%s"\s*,\s*($FuncArg)/ethtool_puts($1, $7)/;
7039 }
7040 }
7043 # typecasts on min/max could be min_t/max_t
7061 }
7064 }
7065 }
7067 # check usleep_range arguments
7075 "usleep_range should not use min == max args; see function description of usleep_range().\n" . "$here\n$stat\n");
7079 "usleep_range args reversed, use min then max; see function description of usleep_range().\n" . "$here\n$stat\n");
7080 }
7081 }
7083 # check for naked sscanf
7095 }
7097 # check for simple sscanf that should be kstrto<foo>
7111 }
7112 }
7113 }
7115 # check for new externs in .h files.
7122 }
7123 }
7125 # check for new externs in .c files.
7128 {
7135 }
7137 {
7140 }
7145 }
7149 {
7153 #print "Linker symbol? $st_name : $s\n";
7154 goto LIKELY_LINKER_SYMBOL
7156 }
7160 LIKELY_LINKER_SYMBOL:
7164 {
7167 }
7169 # check for function declarations that have arguments without identifier names
7171 $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s &&
7179 }
7180 }
7181 }
7183 # check for function definitions
7189 # check for multiline function definition with misplaced open brace
7199 }
7203 }
7204 }
7206 # checks for new __setup's
7212 "__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.txt\n" . $herecurr);
7213 }
7214 }
7216 # check for pointless casting of alloc functions
7219 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
7220 }
7222 # alloc style
7223 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
7225 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*((?:kv|k|v)[mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
7228 }
7230 # check for (kv|k)[mz]alloc with multiplies that could be kmalloc_array/kvmalloc_array/kvcalloc/kcalloc
7233 $stat =~ /^\+\s*($Lval)\s*\=\s*(?:$balanced_parens)?\s*((?:kv|k)[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
7246 }
7256 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*((?:kv|k)[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
7257 }
7258 }
7259 }
7261 # check for krealloc arg reuse
7267 }
7269 # check for alloc argument mismatch
7273 }
7275 # check for multiple semicolons
7281 }
7282 }
7284 # check for #defines like: 1 << <digit> that could be BIT(digit), it is not exported to uapi
7293 }
7294 }
7296 # check for IS_ENABLED() without CONFIG_<FOO> ($rawline for comments too)
7300 }
7302 # check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
7303 if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(${CONFIG_}[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
7309 }
7310 }
7312 # check for /* fallthrough */ like comment, prefer fallthrough;
7321 );
7330 }
7331 }
7332 }
7334 # check for switch/default statements without a break;
7343 }
7345 # check for gcc specific __FUNCTION__
7351 }
7352 }
7354 # check for uses of __DATE__, __TIME__, __TIMESTAMP__
7358 }
7360 # check for use of yield()
7364 }
7366 # check for comparisons against true and false
7382 }
7387 ## maybe suggesting a correct construct would better
7388 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
7390 }
7391 }
7393 # check for semaphores initialized locked
7397 }
7399 # recommend kstrto* over simple_strto* and strict_strto*
7403 }
7405 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
7408 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
7409 }
7411 # check for spin_is_locked(), suggest lockdep instead
7414 "Where possible, use lockdep_assert_held instead of assertions based on spin_is_locked\n" . $herecurr);
7415 }
7417 # check for deprecated apis
7423 }
7425 # check for various structs that are normally const (ops, kgdb, device_tree)
7426 # and avoid what seem like struct definitions 'struct foo {'
7432 }
7434 # use of NR_CPUS is usually wrong
7435 # ignore definitions of NR_CPUS and usage to define arrays as likely right
7436 # ignore designated initializers using NR_CPUS
7444 {
7446 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
7447 }
7449 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
7453 }
7455 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
7460 }
7462 # return sysfs_emit(foo, fmt, ...) fmt without newline
7470 }
7471 }
7473 # check for array definition/declarations that should use flexible arrays instead
7477 "Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays\n" . $hereprev) &&
7480 }
7481 }
7483 # nested likely/unlikely calls
7487 }
7489 # whine mightly about in_atomic
7497 }
7498 }
7500 # Complain about RCU Tasks Trace used outside of BPF (and of course, RCU).
7502 rcu_read_lock_trace |
7503 rcu_read_lock_trace_held |
7504 rcu_read_unlock_trace |
7505 call_rcu_tasks_trace |
7506 synchronize_rcu_tasks_trace |
7507 rcu_barrier_tasks_trace |
7508 rcu_request_urgent_qs_task
7509 )};
7515 include/linux/rcu
7516 )};
7521 }
7522 }
7524 # check for lockdep_set_novalidate_class
7532 }
7533 }
7538 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
7539 }
7541 # check for DEVICE_ATTR uses that could be DEVICE_ATTR_<FOO>
7542 # and whether or not function naming is typical and if
7543 # DEVICE_ATTR permissions uses are unusual too
7546 $stat =~ /\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*\)?\s*,\s*(\w+)\s*,\s*(\w+)\s*\)/) {
7558 $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*$show\s*,\s*$store\s*\)/DEVICE_ATTR_RW(${var})/;
7559 }
7566 $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*$show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(${var})/;
7567 }
7574 $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*NULL\s*,\s*$store\s*\)/DEVICE_ATTR_WO(${var})/;
7575 }
7586 }
7589 }
7595 }
7596 }
7598 # Mode permission misuses where it seems decimal should be octal
7599 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
7600 # o Ignore module_param*(...) uses with a decimal 0 permission as that has a
7601 # specific definition of not visible in sysfs.
7602 # o Ignore proc_create*(...) uses with a decimal 0 permission as that means
7603 # use the default permissions
7619 }
7629 }
7632 "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . "$here\n" . $stat_real);
7633 }
7634 }
7635 }
7636 }
7638 # check for uses of S_<PERMS> that could be octal for readability
7643 "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.\n" . $herecurr) &&
7646 }
7647 }
7649 # validate content of MODULE_LICENSE against list from include/linux/module.h
7653 GPL|
7654 GPL\ v2|
7659 Proprietary
7664 }
7667 "Prefer \"GPL\" over \"GPL v2\" - see commit bf7fbeeae6db (\"module: Cure the MODULE_LICENSE \"GPL\" vs. \"GPL v2\" bogosity\")\n" . $herecurr) &&
7670 }
7671 }
7672 }
7674 # check for sysctl duplicate constants
7677 "duplicated sysctl range checking value '$1', consider using the shared one in include/linux/sysctl.h\n" . $herecurr);
7678 }
7679 }
7681 # If we have no input at all, then there is nothing to report on
7682 # so just keep quiet.
7685 }
7687 # In mailback mode only produce a report in the negative, for
7688 # things that appear to be patches.
7691 }
7693 # This is not a patch, and we are in 'no-patch' mode so
7694 # just keep quiet.
7697 }
7702 }
7707 }
7708 }
7714 # authorsignoff values:
7715 # 0 -> missing sign off
7716 # 1 -> sign off identical
7717 # 2 -> names and addresses match, comments mismatch
7718 # 3 -> addresses match, names different
7719 # 4 -> names match, addresses different
7720 # 5 -> names match, addresses excluding subaddress details (refer RFC 5233) match
7739 }
7740 }
7741 }
7749 }
7752 # If there were any defects found and not already fixing them
7758 EOM
7759 }
7760 # If there were whitespace errors which cleanpatch can fix
7761 # then suggest that.
7768 EOM
7769 }
7770 }
7790 }
7793 }
7794 }
7802 Do _NOT_ trust the results written to this file.
7805 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
7807 EOM
7808 }
7809 }
7817 }
7818 }
7820 }