1 /* SPDX-License-Identifier: GPL-2.0 */
2 #ifndef _LINUX_CLEANUP_H
3 #define _LINUX_CLEANUP_H
5 #include <linux/compiler.h>
8 * DOC: scope-based cleanup helpers
10 * The "goto error" pattern is notorious for introducing subtle resource
11 * leaks. It is tedious and error prone to add new resource acquisition
12 * constraints into code paths that already have several unwind
13 * conditions. The "cleanup" helpers enable the compiler to help with
14 * this tedium and can aid in maintaining LIFO (last in first out)
15 * unwind ordering to avoid unintentional leaks.
17 * As drivers make up the majority of the kernel code base, here is an
18 * example of using these helpers to clean up PCI drivers. The target of
19 * the cleanups are occasions where a goto is used to unwind a device
20 * reference (pci_dev_put()), or unlock the device (pci_dev_unlock())
23 * The DEFINE_FREE() macro can arrange for PCI device references to be
24 * dropped when the associated variable goes out of scope::
26 * DEFINE_FREE(pci_dev_put, struct pci_dev *, if (_T) pci_dev_put(_T))
28 * struct pci_dev *dev __free(pci_dev_put) =
29 * pci_get_slot(parent, PCI_DEVFN(0, 0));
31 * The above will automatically call pci_dev_put() if @dev is non-NULL
32 * when @dev goes out of scope (automatic variable scope). If a function
33 * wants to invoke pci_dev_put() on error, but return @dev (i.e. without
34 * freeing it) on success, it can do::
36 * return no_free_ptr(dev);
42 * The DEFINE_GUARD() macro can arrange for the PCI device lock to be
43 * dropped when the scope where guard() is invoked ends::
45 * DEFINE_GUARD(pci_dev, struct pci_dev *, pci_dev_lock(_T), pci_dev_unlock(_T))
47 * guard(pci_dev)(dev);
49 * The lifetime of the lock obtained by the guard() helper follows the
50 * scope of automatic variable declaration. Take the following example::
56 * guard(pci_dev)(dev); // pci_dev_lock() invoked here
58 * } // <- implied pci_dev_unlock() triggered here
61 * Observe the lock is held for the remainder of the "if ()" block not
62 * the remainder of "func()".
64 * Now, when a function uses both __free() and guard(), or multiple
65 * instances of __free(), the LIFO order of variable definition order
66 * matters. GCC documentation says:
68 * "When multiple variables in the same scope have cleanup attributes,
69 * at exit from the scope their associated cleanup functions are run in
70 * reverse order of definition (last defined, first cleanup)."
72 * When the unwind order matters it requires that variables be defined
73 * mid-function scope rather than at the top of the file. Take the
74 * following example and notice the bug highlighted by "!!"::
80 * struct list_head node;
83 * static struct object *alloc_add(void)
87 * lockdep_assert_held(&lock);
88 * obj = kzalloc(sizeof(*obj), GFP_KERNEL);
90 * LIST_HEAD_INIT(&obj->node);
91 * list_add(obj->node, &list):
96 * static void remove_free(struct object *obj)
98 * lockdep_assert_held(&lock);
99 * list_del(&obj->node);
103 * DEFINE_FREE(remove_free, struct object *, if (_T) remove_free(_T))
104 * static int init(void)
106 * struct object *obj __free(remove_free) = NULL;
109 * guard(mutex)(&lock);
115 * err = other_init(obj);
117 * return err; // remove_free() called without the lock!!
123 * That bug is fixed by changing init() to call guard() and define +
124 * initialize @obj in this order::
126 * guard(mutex)(&lock);
127 * struct object *obj __free(remove_free) = alloc_add();
129 * Given that the "__free(...) = NULL" pattern for variables defined at
130 * the top of the function poses this potential interdependency problem
131 * the recommendation is to always define and assign variables in one
132 * statement and not group variable definitions at the top of the
133 * function when __free() is used.
135 * Lastly, given that the benefit of cleanup helpers is removal of
136 * "goto", and that the "goto" statement can jump between scopes, the
137 * expectation is that usage of "goto" and cleanup helpers is never
138 * mixed in the same function. I.e. for a given routine, convert all
139 * resources that need a "goto" cleanup to scope-based cleanup, or
140 * convert none of them.
144 * DEFINE_FREE(name, type, free):
145 * simple helper macro that defines the required wrapper for a __free()
146 * based cleanup function. @free is an expression using '_T' to access the
147 * variable. @free should typically include a NULL test before calling a
148 * function, see the example below.
151 * variable attribute to add a scoped based cleanup to the variable.
154 * like a non-atomic xchg(var, NULL), such that the cleanup function will
155 * be inhibited -- provided it sanely deals with a NULL value.
157 * NOTE: this has __must_check semantics so that it is harder to accidentally
161 * returns p while inhibiting the __free().
165 * DEFINE_FREE(kfree, void *, if (_T) kfree(_T))
167 * void *alloc_obj(...)
169 * struct obj *p __free(kfree) = kmalloc(...);
179 * NOTE: the DEFINE_FREE()'s @free expression includes a NULL test even though
180 * kfree() is fine to be called with a NULL value. This is on purpose. This way
181 * the compiler sees the end of our alloc_obj() function as:
189 * And through the magic of value-propagation and dead-code-elimination, it
190 * eliminates the actual cleanup call and compiles into:
194 * Without the NULL test it turns into a mess and the compiler can't help us.
197 #define DEFINE_FREE(_name, _type, _free) \
198 static inline void __free_##_name(void *p) { _type _T = *(_type *)p; _free; }
200 #define __free(_name) __cleanup(__free_##_name)
202 #define __get_and_null(p, nullvalue) \
204 __auto_type __ptr = &(p); \
205 __auto_type __val = *__ptr; \
206 *__ptr = nullvalue; \
210 static inline __must_check
211 const volatile void * __must_check_fn(const volatile void *val
)
214 #define no_free_ptr(p) \
215 ((typeof(p)) __must_check_fn(__get_and_null(p, NULL)))
217 #define return_ptr(p) return no_free_ptr(p)
221 * DEFINE_CLASS(name, type, exit, init, init_args...):
222 * helper to define the destructor and constructor for a type.
223 * @exit is an expression using '_T' -- similar to FREE above.
224 * @init is an expression in @init_args resulting in @type
226 * EXTEND_CLASS(name, ext, init, init_args...):
227 * extends class @name to @name@ext with the new constructor
229 * CLASS(name, var)(args...):
230 * declare the variable @var as an instance of the named class
234 * DEFINE_CLASS(fdget, struct fd, fdput(_T), fdget(fd), int fd)
236 * CLASS(fdget, f)(fd);
240 * // use 'f' without concern
243 #define DEFINE_CLASS(_name, _type, _exit, _init, _init_args...) \
244 typedef _type class_##_name##_t; \
245 static inline void class_##_name##_destructor(_type *p) \
246 { _type _T = *p; _exit; } \
247 static inline _type class_##_name##_constructor(_init_args) \
248 { _type t = _init; return t; }
250 #define EXTEND_CLASS(_name, ext, _init, _init_args...) \
251 typedef class_##_name##_t class_##_name##ext##_t; \
252 static inline void class_##_name##ext##_destructor(class_##_name##_t *p)\
253 { class_##_name##_destructor(p); } \
254 static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
255 { class_##_name##_t t = _init; return t; }
257 #define CLASS(_name, var) \
258 class_##_name##_t var __cleanup(class_##_name##_destructor) = \
259 class_##_name##_constructor
263 * DEFINE_GUARD(name, type, lock, unlock):
264 * trivial wrapper around DEFINE_CLASS() above specifically
267 * DEFINE_GUARD_COND(name, ext, condlock)
268 * wrapper around EXTEND_CLASS above to add conditional lock
269 * variants to a base class, eg. mutex_trylock() or
270 * mutex_lock_interruptible().
273 * an anonymous instance of the (guard) class, not recommended for
276 * if_not_guard(name, args...) { <error handling> }:
277 * convenience macro for conditional guards that calls the statement that
278 * follows only if the lock was not acquired (typically an error return).
280 * Only for conditional locks.
282 * scoped_guard (name, args...) { }:
283 * similar to CLASS(name, scope)(args), except the variable (with the
284 * explicit name 'scope') is declard in a for-loop such that its scope is
285 * bound to the next (compound) statement.
287 * for conditional locks the loop body is skipped when the lock is not
290 * scoped_cond_guard (name, fail, args...) { }:
291 * similar to scoped_guard(), except it does fail when the lock
294 * Only for conditional locks.
297 #define __DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond) \
298 static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
300 #define DEFINE_GUARD(_name, _type, _lock, _unlock) \
301 __DEFINE_CLASS_IS_CONDITIONAL(_name, false); \
302 DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T); \
303 static inline void * class_##_name##_lock_ptr(class_##_name##_t *_T) \
304 { return (void *)(__force unsigned long)*_T; }
306 #define DEFINE_GUARD_COND(_name, _ext, _condlock) \
307 __DEFINE_CLASS_IS_CONDITIONAL(_name##_ext, true); \
308 EXTEND_CLASS(_name, _ext, \
309 ({ void *_t = _T; if (_T && !(_condlock)) _t = NULL; _t; }), \
310 class_##_name##_t _T) \
311 static inline void * class_##_name##_ext##_lock_ptr(class_##_name##_t *_T) \
312 { return class_##_name##_lock_ptr(_T); }
314 #define guard(_name) \
315 CLASS(_name, __UNIQUE_ID(guard))
317 #define __guard_ptr(_name) class_##_name##_lock_ptr
318 #define __is_cond_ptr(_name) class_##_name##_is_conditional
321 * Helper macro for scoped_guard().
323 * Note that the "!__is_cond_ptr(_name)" part of the condition ensures that
324 * compiler would be sure that for the unconditional locks the body of the
325 * loop (caller-provided code glued to the else clause) could not be skipped.
326 * It is needed because the other part - "__guard_ptr(_name)(&scope)" - is too
327 * hard to deduce (even if could be proven true for unconditional locks).
329 #define __scoped_guard(_name, _label, args...) \
330 for (CLASS(_name, scope)(args); \
331 __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
332 ({ goto _label; })) \
338 #define scoped_guard(_name, args...) \
339 __scoped_guard(_name, __UNIQUE_ID(label), args)
341 #define __scoped_cond_guard(_name, _fail, _label, args...) \
342 for (CLASS(_name, scope)(args); true; ({ goto _label; })) \
343 if (!__guard_ptr(_name)(&scope)) { \
344 BUILD_BUG_ON(!__is_cond_ptr(_name)); \
350 #define scoped_cond_guard(_name, _fail, args...) \
351 __scoped_cond_guard(_name, _fail, __UNIQUE_ID(label), args)
353 #define __if_not_guard(_name, _id, args...) \
354 BUILD_BUG_ON(!__is_cond_ptr(_name)); \
355 CLASS(_name, _id)(args); \
356 if (!__guard_ptr(_name)(&_id))
358 #define if_not_guard(_name, args...) \
359 __if_not_guard(_name, __UNIQUE_ID(guard), args)
362 * Additional helper macros for generating lock guards with types, either for
363 * locks that don't have a native type (eg. RCU, preempt) or those that need a
364 * 'fat' pointer (eg. spin_lock_irqsave).
366 * DEFINE_LOCK_GUARD_0(name, lock, unlock, ...)
367 * DEFINE_LOCK_GUARD_1(name, type, lock, unlock, ...)
368 * DEFINE_LOCK_GUARD_1_COND(name, ext, condlock)
370 * will result in the following type:
373 * type *lock; // 'type := void' for the _0 variant
375 * } class_##name##_t;
377 * As above, both _lock and _unlock are statements, except this time '_T' will
378 * be a pointer to the above struct.
381 #define __DEFINE_UNLOCK_GUARD(_name, _type, _unlock, ...) \
385 } class_##_name##_t; \
387 static inline void class_##_name##_destructor(class_##_name##_t *_T) \
389 if (_T->lock) { _unlock; } \
392 static inline void *class_##_name##_lock_ptr(class_##_name##_t *_T) \
394 return (void *)(__force unsigned long)_T->lock; \
398 #define __DEFINE_LOCK_GUARD_1(_name, _type, _lock) \
399 static inline class_##_name##_t class_##_name##_constructor(_type *l) \
401 class_##_name##_t _t = { .lock = l }, *_T = &_t; \
406 #define __DEFINE_LOCK_GUARD_0(_name, _lock) \
407 static inline class_##_name##_t class_##_name##_constructor(void) \
409 class_##_name##_t _t = { .lock = (void*)1 }, \
410 *_T __maybe_unused = &_t; \
415 #define DEFINE_LOCK_GUARD_1(_name, _type, _lock, _unlock, ...) \
416 __DEFINE_CLASS_IS_CONDITIONAL(_name, false); \
417 __DEFINE_UNLOCK_GUARD(_name, _type, _unlock, __VA_ARGS__) \
418 __DEFINE_LOCK_GUARD_1(_name, _type, _lock)
420 #define DEFINE_LOCK_GUARD_0(_name, _lock, _unlock, ...) \
421 __DEFINE_CLASS_IS_CONDITIONAL(_name, false); \
422 __DEFINE_UNLOCK_GUARD(_name, void, _unlock, __VA_ARGS__) \
423 __DEFINE_LOCK_GUARD_0(_name, _lock)
425 #define DEFINE_LOCK_GUARD_1_COND(_name, _ext, _condlock) \
426 __DEFINE_CLASS_IS_CONDITIONAL(_name##_ext, true); \
427 EXTEND_CLASS(_name, _ext, \
428 ({ class_##_name##_t _t = { .lock = l }, *_T = &_t;\
429 if (_T->lock && !(_condlock)) _T->lock = NULL; \
431 typeof_member(class_##_name##_t, lock) l) \
432 static inline void * class_##_name##_ext##_lock_ptr(class_##_name##_t *_T) \
433 { return class_##_name##_lock_ptr(_T); }
436 #endif /* _LINUX_CLEANUP_H */