SubmittingPatches.html

   1 <?xml version="1.0" encoding="UTF-8"?>
   2 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
   3     "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
   4 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
   5 <head>
   6 <meta http-equiv="Content-Type" content="application/xhtml+xml; charset=UTF-8" />
   7 <meta name="generator" content="AsciiDoc 10.2.0" />
   8 <title>Submitting Patches</title>
   9 <style type="text/css">
  10 /* Shared CSS for AsciiDoc xhtml11 and html5 backends */
  11
  12 /* Default font. */
  13 body {
  14   font-family: Georgia,serif;
  15 }
  16
  17 /* Title font. */
  18 h1, h2, h3, h4, h5, h6,
  19 div.title, caption.title,
  20 thead, p.table.header,
  21 #toctitle,
  22 #author, #revnumber, #revdate, #revremark,
  23 #footer {
  24   font-family: Arial,Helvetica,sans-serif;
  25 }
  26
  27 body {
  28   margin: 1em 5% 1em 5%;
  29 }
  30
  31 a {
  32   color: blue;
  33   text-decoration: underline;
  34 }
  35 a:visited {
  36   color: fuchsia;
  37 }
  38
  39 em {
  40   font-style: italic;
  41   color: navy;
  42 }
  43
  44 strong {
  45   font-weight: bold;
  46   color: #083194;
  47 }
  48
  49 h1, h2, h3, h4, h5, h6 {
  50   color: #527bbd;
  51   margin-top: 1.2em;
  52   margin-bottom: 0.5em;
  53   line-height: 1.3;
  54 }
  55
  56 h1, h2, h3 {
  57   border-bottom: 2px solid silver;
  58 }
  59 h2 {
  60   padding-top: 0.5em;
  61 }
  62 h3 {
  63   float: left;
  64 }
  65 h3 + * {
  66   clear: left;
  67 }
  68 h5 {
  69   font-size: 1.0em;
  70 }
  71
  72 div.sectionbody {
  73   margin-left: 0;
  74 }
  75
  76 hr {
  77   border: 1px solid silver;
  78 }
  79
  80 p {
  81   margin-top: 0.5em;
  82   margin-bottom: 0.5em;
  83 }
  84
  85 ul, ol, li > p {
  86   margin-top: 0;
  87 }
  88 ul > li     { color: #aaa; }
  89 ul > li > * { color: black; }
  90
  91 .monospaced, code, pre {
  92   font-family: "Courier New", Courier, monospace;
  93   font-size: inherit;
  94   color: navy;
  95   padding: 0;
  96   margin: 0;
  97 }
  98 pre {
  99   white-space: pre-wrap;
 100 }
 101
 102 #author {
 103   color: #527bbd;
 104   font-weight: bold;
 105   font-size: 1.1em;
 106 }
 107 #email {
 108 }
 109 #revnumber, #revdate, #revremark {
 110 }
 111
 112 #footer {
 113   font-size: small;
 114   border-top: 2px solid silver;
 115   padding-top: 0.5em;
 116   margin-top: 4.0em;
 117 }
 118 #footer-text {
 119   float: left;
 120   padding-bottom: 0.5em;
 121 }
 122 #footer-badges {
 123   float: right;
 124   padding-bottom: 0.5em;
 125 }
 126
 127 #preamble {
 128   margin-top: 1.5em;
 129   margin-bottom: 1.5em;
 130 }
 131 div.imageblock, div.exampleblock, div.verseblock,
 132 div.quoteblock, div.literalblock, div.listingblock, div.sidebarblock,
 133 div.admonitionblock {
 134   margin-top: 1.0em;
 135   margin-bottom: 1.5em;
 136 }
 137 div.admonitionblock {
 138   margin-top: 2.0em;
 139   margin-bottom: 2.0em;
 140   margin-right: 10%;
 141   color: #606060;
 142 }
 143
 144 div.content { /* Block element content. */
 145   padding: 0;
 146 }
 147
 148 /* Block element titles. */
 149 div.title, caption.title {
 150   color: #527bbd;
 151   font-weight: bold;
 152   text-align: left;
 153   margin-top: 1.0em;
 154   margin-bottom: 0.5em;
 155 }
 156 div.title + * {
 157   margin-top: 0;
 158 }
 159
 160 td div.title:first-child {
 161   margin-top: 0.0em;
 162 }
 163 div.content div.title:first-child {
 164   margin-top: 0.0em;
 165 }
 166 div.content + div.title {
 167   margin-top: 0.0em;
 168 }
 169
 170 div.sidebarblock > div.content {
 171   background: #ffffee;
 172   border: 1px solid #dddddd;
 173   border-left: 4px solid #f0f0f0;
 174   padding: 0.5em;
 175 }
 176
 177 div.listingblock > div.content {
 178   border: 1px solid #dddddd;
 179   border-left: 5px solid #f0f0f0;
 180   background: #f8f8f8;
 181   padding: 0.5em;
 182 }
 183
 184 div.quoteblock, div.verseblock {
 185   padding-left: 1.0em;
 186   margin-left: 1.0em;
 187   margin-right: 10%;
 188   border-left: 5px solid #f0f0f0;
 189   color: #888;
 190 }
 191
 192 div.quoteblock > div.attribution {
 193   padding-top: 0.5em;
 194   text-align: right;
 195 }
 196
 197 div.verseblock > pre.content {
 198   font-family: inherit;
 199   font-size: inherit;
 200 }
 201 div.verseblock > div.attribution {
 202   padding-top: 0.75em;
 203   text-align: left;
 204 }
 205 /* DEPRECATED: Pre version 8.2.7 verse style literal block. */
 206 div.verseblock + div.attribution {
 207   text-align: left;
 208 }
 209
 210 div.admonitionblock .icon {
 211   vertical-align: top;
 212   font-size: 1.1em;
 213   font-weight: bold;
 214   text-decoration: underline;
 215   color: #527bbd;
 216   padding-right: 0.5em;
 217 }
 218 div.admonitionblock td.content {
 219   padding-left: 0.5em;
 220   border-left: 3px solid #dddddd;
 221 }
 222
 223 div.exampleblock > div.content {
 224   border-left: 3px solid #dddddd;
 225   padding-left: 0.5em;
 226 }
 227
 228 div.imageblock div.content { padding-left: 0; }
 229 span.image img { border-style: none; vertical-align: text-bottom; }
 230 a.image:visited { color: white; }
 231
 232 dl {
 233   margin-top: 0.8em;
 234   margin-bottom: 0.8em;
 235 }
 236 dt {
 237   margin-top: 0.5em;
 238   margin-bottom: 0;
 239   font-style: normal;
 240   color: navy;
 241 }
 242 dd > *:first-child {
 243   margin-top: 0.1em;
 244 }
 245
 246 ul, ol {
 247     list-style-position: outside;
 248 }
 249 ol.arabic {
 250   list-style-type: decimal;
 251 }
 252 ol.loweralpha {
 253   list-style-type: lower-alpha;
 254 }
 255 ol.upperalpha {
 256   list-style-type: upper-alpha;
 257 }
 258 ol.lowerroman {
 259   list-style-type: lower-roman;
 260 }
 261 ol.upperroman {
 262   list-style-type: upper-roman;
 263 }
 264
 265 div.compact ul, div.compact ol,
 266 div.compact p, div.compact p,
 267 div.compact div, div.compact div {
 268   margin-top: 0.1em;
 269   margin-bottom: 0.1em;
 270 }
 271
 272 tfoot {
 273   font-weight: bold;
 274 }
 275 td > div.verse {
 276   white-space: pre;
 277 }
 278
 279 div.hdlist {
 280   margin-top: 0.8em;
 281   margin-bottom: 0.8em;
 282 }
 283 div.hdlist tr {
 284   padding-bottom: 15px;
 285 }
 286 dt.hdlist1.strong, td.hdlist1.strong {
 287   font-weight: bold;
 288 }
 289 td.hdlist1 {
 290   vertical-align: top;
 291   font-style: normal;
 292   padding-right: 0.8em;
 293   color: navy;
 294 }
 295 td.hdlist2 {
 296   vertical-align: top;
 297 }
 298 div.hdlist.compact tr {
 299   margin: 0;
 300   padding-bottom: 0;
 301 }
 302
 303 .comment {
 304   background: yellow;
 305 }
 306
 307 .footnote, .footnoteref {
 308   font-size: 0.8em;
 309 }
 310
 311 span.footnote, span.footnoteref {
 312   vertical-align: super;
 313 }
 314
 315 #footnotes {
 316   margin: 20px 0 20px 0;
 317   padding: 7px 0 0 0;
 318 }
 319
 320 #footnotes div.footnote {
 321   margin: 0 0 5px 0;
 322 }
 323
 324 #footnotes hr {
 325   border: none;
 326   border-top: 1px solid silver;
 327   height: 1px;
 328   text-align: left;
 329   margin-left: 0;
 330   width: 20%;
 331   min-width: 100px;
 332 }
 333
 334 div.colist td {
 335   padding-right: 0.5em;
 336   padding-bottom: 0.3em;
 337   vertical-align: top;
 338 }
 339 div.colist td img {
 340   margin-top: 0.3em;
 341 }
 342
 343 @media print {
 344   #footer-badges { display: none; }
 345 }
 346
 347 #toc {
 348   margin-bottom: 2.5em;
 349 }
 350
 351 #toctitle {
 352   color: #527bbd;
 353   font-size: 1.1em;
 354   font-weight: bold;
 355   margin-top: 1.0em;
 356   margin-bottom: 0.1em;
 357 }
 358
 359 div.toclevel0, div.toclevel1, div.toclevel2, div.toclevel3, div.toclevel4 {
 360   margin-top: 0;
 361   margin-bottom: 0;
 362 }
 363 div.toclevel2 {
 364   margin-left: 2em;
 365   font-size: 0.9em;
 366 }
 367 div.toclevel3 {
 368   margin-left: 4em;
 369   font-size: 0.9em;
 370 }
 371 div.toclevel4 {
 372   margin-left: 6em;
 373   font-size: 0.9em;
 374 }
 375
 376 span.aqua { color: aqua; }
 377 span.black { color: black; }
 378 span.blue { color: blue; }
 379 span.fuchsia { color: fuchsia; }
 380 span.gray { color: gray; }
 381 span.green { color: green; }
 382 span.lime { color: lime; }
 383 span.maroon { color: maroon; }
 384 span.navy { color: navy; }
 385 span.olive { color: olive; }
 386 span.purple { color: purple; }
 387 span.red { color: red; }
 388 span.silver { color: silver; }
 389 span.teal { color: teal; }
 390 span.white { color: white; }
 391 span.yellow { color: yellow; }
 392
 393 span.aqua-background { background: aqua; }
 394 span.black-background { background: black; }
 395 span.blue-background { background: blue; }
 396 span.fuchsia-background { background: fuchsia; }
 397 span.gray-background { background: gray; }
 398 span.green-background { background: green; }
 399 span.lime-background { background: lime; }
 400 span.maroon-background { background: maroon; }
 401 span.navy-background { background: navy; }
 402 span.olive-background { background: olive; }
 403 span.purple-background { background: purple; }
 404 span.red-background { background: red; }
 405 span.silver-background { background: silver; }
 406 span.teal-background { background: teal; }
 407 span.white-background { background: white; }
 408 span.yellow-background { background: yellow; }
 409
 410 span.big { font-size: 2em; }
 411 span.small { font-size: 0.6em; }
 412
 413 span.underline { text-decoration: underline; }
 414 span.overline { text-decoration: overline; }
 415 span.line-through { text-decoration: line-through; }
 416
 417 div.unbreakable { page-break-inside: avoid; }
 418
 419
 420 /*
 421  * xhtml11 specific
 422  *
 423  * */
 424
 425 div.tableblock {
 426   margin-top: 1.0em;
 427   margin-bottom: 1.5em;
 428 }
 429 div.tableblock > table {
 430   border: 3px solid #527bbd;
 431 }
 432 thead, p.table.header {
 433   font-weight: bold;
 434   color: #527bbd;
 435 }
 436 p.table {
 437   margin-top: 0;
 438 }
 439 /* Because the table frame attribute is overridden by CSS in most browsers. */
 440 div.tableblock > table[frame="void"] {
 441   border-style: none;
 442 }
 443 div.tableblock > table[frame="hsides"] {
 444   border-left-style: none;
 445   border-right-style: none;
 446 }
 447 div.tableblock > table[frame="vsides"] {
 448   border-top-style: none;
 449   border-bottom-style: none;
 450 }
 451
 452
 453 /*
 454  * html5 specific
 455  *
 456  * */
 457
 458 table.tableblock {
 459   margin-top: 1.0em;
 460   margin-bottom: 1.5em;
 461 }
 462 thead, p.tableblock.header {
 463   font-weight: bold;
 464   color: #527bbd;
 465 }
 466 p.tableblock {
 467   margin-top: 0;
 468 }
 469 table.tableblock {
 470   border-width: 3px;
 471   border-spacing: 0px;
 472   border-style: solid;
 473   border-color: #527bbd;
 474   border-collapse: collapse;
 475 }
 476 th.tableblock, td.tableblock {
 477   border-width: 1px;
 478   padding: 4px;
 479   border-style: solid;
 480   border-color: #527bbd;
 481 }
 482
 483 table.tableblock.frame-topbot {
 484   border-left-style: hidden;
 485   border-right-style: hidden;
 486 }
 487 table.tableblock.frame-sides {
 488   border-top-style: hidden;
 489   border-bottom-style: hidden;
 490 }
 491 table.tableblock.frame-none {
 492   border-style: hidden;
 493 }
 494
 495 th.tableblock.halign-left, td.tableblock.halign-left {
 496   text-align: left;
 497 }
 498 th.tableblock.halign-center, td.tableblock.halign-center {
 499   text-align: center;
 500 }
 501 th.tableblock.halign-right, td.tableblock.halign-right {
 502   text-align: right;
 503 }
 504
 505 th.tableblock.valign-top, td.tableblock.valign-top {
 506   vertical-align: top;
 507 }
 508 th.tableblock.valign-middle, td.tableblock.valign-middle {
 509   vertical-align: middle;
 510 }
 511 th.tableblock.valign-bottom, td.tableblock.valign-bottom {
 512   vertical-align: bottom;
 513 }
 514
 515
 516 /*
 517  * manpage specific
 518  *
 519  * */
 520
 521 body.manpage h1 {
 522   padding-top: 0.5em;
 523   padding-bottom: 0.5em;
 524   border-top: 2px solid silver;
 525   border-bottom: 2px solid silver;
 526 }
 527 body.manpage h2 {
 528   border-style: none;
 529 }
 530 body.manpage div.sectionbody {
 531   margin-left: 3em;
 532 }
 533
 534 @media print {
 535   body.manpage div#toc { display: none; }
 536 }
 537
 538
 539 </style>
 540 <script type="text/javascript">
 541 /*<![CDATA[*/
 542 var asciidoc = {  // Namespace.
 543
 544 /////////////////////////////////////////////////////////////////////
 545 // Table Of Contents generator
 546 /////////////////////////////////////////////////////////////////////
 547
 548 /* Author: Mihai Bazon, September 2002
 549  * http://students.infoiasi.ro/~mishoo
 550  *
 551  * Table Of Content generator
 552  * Version: 0.4
 553  *
 554  * Feel free to use this script under the terms of the GNU General Public
 555  * License, as long as you do not remove or alter this notice.
 556  */
 557
 558  /* modified by Troy D. Hanson, September 2006. License: GPL */
 559  /* modified by Stuart Rackham, 2006, 2009. License: GPL */
 560
 561 // toclevels = 1..4.
 562 toc: function (toclevels) {
 563
 564   function getText(el) {
 565     var text = "";
 566     for (var i = el.firstChild; i != null; i = i.nextSibling) {
 567       if (i.nodeType == 3 /* Node.TEXT_NODE */) // IE doesn't speak constants.
 568         text += i.data;
 569       else if (i.firstChild != null)
 570         text += getText(i);
 571     }
 572     return text;
 573   }
 574
 575   function TocEntry(el, text, toclevel) {
 576     this.element = el;
 577     this.text = text;
 578     this.toclevel = toclevel;
 579   }
 580
 581   function tocEntries(el, toclevels) {
 582     var result = new Array;
 583     var re = new RegExp('[hH]([1-'+(toclevels+1)+'])');
 584     // Function that scans the DOM tree for header elements (the DOM2
 585     // nodeIterator API would be a better technique but not supported by all
 586     // browsers).
 587     var iterate = function (el) {
 588       for (var i = el.firstChild; i != null; i = i.nextSibling) {
 589         if (i.nodeType == 1 /* Node.ELEMENT_NODE */) {
 590           var mo = re.exec(i.tagName);
 591           if (mo && (i.getAttribute("class") || i.getAttribute("className")) != "float") {
 592             result[result.length] = new TocEntry(i, getText(i), mo[1]-1);
 593           }
 594           iterate(i);
 595         }
 596       }
 597     }
 598     iterate(el);
 599     return result;
 600   }
 601
 602   var toc = document.getElementById("toc");
 603   if (!toc) {
 604     return;
 605   }
 606
 607   // Delete existing TOC entries in case we're reloading the TOC.
 608   var tocEntriesToRemove = [];
 609   var i;
 610   for (i = 0; i < toc.childNodes.length; i++) {
 611     var entry = toc.childNodes[i];
 612     if (entry.nodeName.toLowerCase() == 'div'
 613      && entry.getAttribute("class")
 614      && entry.getAttribute("class").match(/^toclevel/))
 615       tocEntriesToRemove.push(entry);
 616   }
 617   for (i = 0; i < tocEntriesToRemove.length; i++) {
 618     toc.removeChild(tocEntriesToRemove[i]);
 619   }
 620
 621   // Rebuild TOC entries.
 622   var entries = tocEntries(document.getElementById("content"), toclevels);
 623   for (var i = 0; i < entries.length; ++i) {
 624     var entry = entries[i];
 625     if (entry.element.id == "")
 626       entry.element.id = "_toc_" + i;
 627     var a = document.createElement("a");
 628     a.href = "#" + entry.element.id;
 629     a.appendChild(document.createTextNode(entry.text));
 630     var div = document.createElement("div");
 631     div.appendChild(a);
 632     div.className = "toclevel" + entry.toclevel;
 633     toc.appendChild(div);
 634   }
 635   if (entries.length == 0)
 636     toc.parentNode.removeChild(toc);
 637 },
 638
 639
 640 /////////////////////////////////////////////////////////////////////
 641 // Footnotes generator
 642 /////////////////////////////////////////////////////////////////////
 643
 644 /* Based on footnote generation code from:
 645  * http://www.brandspankingnew.net/archive/2005/07/format_footnote.html
 646  */
 647
 648 footnotes: function () {
 649   // Delete existing footnote entries in case we're reloading the footnodes.
 650   var i;
 651   var noteholder = document.getElementById("footnotes");
 652   if (!noteholder) {
 653     return;
 654   }
 655   var entriesToRemove = [];
 656   for (i = 0; i < noteholder.childNodes.length; i++) {
 657     var entry = noteholder.childNodes[i];
 658     if (entry.nodeName.toLowerCase() == 'div' && entry.getAttribute("class") == "footnote")
 659       entriesToRemove.push(entry);
 660   }
 661   for (i = 0; i < entriesToRemove.length; i++) {
 662     noteholder.removeChild(entriesToRemove[i]);
 663   }
 664
 665   // Rebuild footnote entries.
 666   var cont = document.getElementById("content");
 667   var spans = cont.getElementsByTagName("span");
 668   var refs = {};
 669   var n = 0;
 670   for (i=0; i<spans.length; i++) {
 671     if (spans[i].className == "footnote") {
 672       n++;
 673       var note = spans[i].getAttribute("data-note");
 674       if (!note) {
 675         // Use [\s\S] in place of . so multi-line matches work.
 676         // Because JavaScript has no s (dotall) regex flag.
 677         note = spans[i].innerHTML.match(/\s*\[([\s\S]*)]\s*/)[1];
 678         spans[i].innerHTML =
 679           "[<a id='_footnoteref_" + n + "' href='#_footnote_" + n +
 680           "' title='View footnote' class='footnote'>" + n + "</a>]";
 681         spans[i].setAttribute("data-note", note);
 682       }
 683       noteholder.innerHTML +=
 684         "<div class='footnote' id='_footnote_" + n + "'>" +
 685         "<a href='#_footnoteref_" + n + "' title='Return to text'>" +
 686         n + "</a>. " + note + "</div>";
 687       var id =spans[i].getAttribute("id");
 688       if (id != null) refs["#"+id] = n;
 689     }
 690   }
 691   if (n == 0)
 692     noteholder.parentNode.removeChild(noteholder);
 693   else {
 694     // Process footnoterefs.
 695     for (i=0; i<spans.length; i++) {
 696       if (spans[i].className == "footnoteref") {
 697         var href = spans[i].getElementsByTagName("a")[0].getAttribute("href");
 698         href = href.match(/#.*/)[0];  // Because IE return full URL.
 699         n = refs[href];
 700         spans[i].innerHTML =
 701           "[<a href='#_footnote_" + n +
 702           "' title='View footnote' class='footnote'>" + n + "</a>]";
 703       }
 704     }
 705   }
 706 },
 707
 708 install: function(toclevels) {
 709   var timerId;
 710
 711   function reinstall() {
 712     asciidoc.footnotes();
 713     if (toclevels) {
 714       asciidoc.toc(toclevels);
 715     }
 716   }
 717
 718   function reinstallAndRemoveTimer() {
 719     clearInterval(timerId);
 720     reinstall();
 721   }
 722
 723   timerId = setInterval(reinstall, 500);
 724   if (document.addEventListener)
 725     document.addEventListener("DOMContentLoaded", reinstallAndRemoveTimer, false);
 726   else
 727     window.onload = reinstallAndRemoveTimer;
 728 }
 729
 730 }
 731 asciidoc.install();
 732 /*]]>*/
 733 </script>
 734 </head>
 735 <body class="article">
 736 <div id="header">
 737 <h1>Submitting Patches</h1>
 738 <span id="revdate">2023-06-13</span>
 739 </div>
 740 <div id="content">
 741 <div class="sect1">
 742 <h2 id="_guidelines">Guidelines</h2>
 743 <div class="sectionbody">
 744 <div class="paragraph"><p>Here are some guidelines for people who want to contribute their code to this
 745 software. There is also a <a href="MyFirstContribution.html">step-by-step tutorial</a>
 746 available which covers many of these same guidelines.</p></div>
 747 <div class="sect2">
 748 <h3 id="base-branch">Decide what to base your work on.</h3>
 749 <div class="paragraph"><p>In general, always base your work on the oldest branch that your
 750 change is relevant to.</p></div>
 751 <div class="ulist"><ul>
 752 <li>
 753 <p>
 754 A bugfix should be based on <code>maint</code> in general. If the bug is not
 755   present in <code>maint</code>, base it on <code>master</code>. For a bug that&#8217;s not yet
 756   in <code>master</code>, find the topic that introduces the regression, and
 757   base your work on the tip of the topic.
 758 </p>
 759 </li>
 760 <li>
 761 <p>
 762 A new feature should be based on <code>master</code> in general. If the new
 763   feature depends on other topics that are in <code>next</code>, but not in
 764   <code>master</code>, fork a branch from the tip of <code>master</code>, merge these topics
 765   to the branch, and work on that branch.  You can remind yourself of
 766   how you prepared the base with <code>git log --first-parent master..</code>.
 767 </p>
 768 </li>
 769 <li>
 770 <p>
 771 Corrections and enhancements to a topic not yet in <code>master</code> should
 772   be based on the tip of that topic. If the topic has not been merged
 773   to <code>next</code>, it&#8217;s alright to add a note to squash minor corrections
 774   into the series.
 775 </p>
 776 </li>
 777 <li>
 778 <p>
 779 In the exceptional case that a new feature depends on several topics
 780   not in <code>master</code>, start working on <code>next</code> or <code>seen</code> privately and
 781   send out patches only for discussion. Once your new feature starts
 782   to stabilize, you would have to rebase it (see the "depends on other
 783   topics" above).
 784 </p>
 785 </li>
 786 <li>
 787 <p>
 788 Some parts of the system have dedicated maintainers with their own
 789   repositories (see the section "Subsystems" below).  Changes to
 790   these parts should be based on their trees.
 791 </p>
 792 </li>
 793 </ul></div>
 794 <div class="paragraph"><p>To find the tip of a topic branch, run <code>git log --first-parent
 795 master..seen</code> and look for the merge commit. The second parent of this
 796 commit is the tip of the topic branch.</p></div>
 797 </div>
 798 <div class="sect2">
 799 <h3 id="separate-commits">Make separate commits for logically separate changes.</h3>
 800 <div class="paragraph"><p>Unless your patch is really trivial, you should not be sending
 801 out a patch that was generated between your working tree and
 802 your commit head.  Instead, always make a commit with complete
 803 commit message and generate a series of patches from your
 804 repository.  It is a good discipline.</p></div>
 805 <div class="paragraph"><p>Give an explanation for the change(s) that is detailed enough so
 806 that people can judge if it is good thing to do, without reading
 807 the actual patch text to determine how well the code does what
 808 the explanation promises to do.</p></div>
 809 <div class="paragraph"><p>If your description starts to get too long, that&#8217;s a sign that you
 810 probably need to split up your commit to finer grained pieces.
 811 That being said, patches which plainly describe the things that
 812 help reviewers check the patch, and future maintainers understand
 813 the code, are the most beautiful patches.  Descriptions that summarize
 814 the point in the subject well, and describe the motivation for the
 815 change, the approach taken by the change, and if relevant how this
 816 differs substantially from the prior version, are all good things
 817 to have.</p></div>
 818 <div class="paragraph"><p>Make sure that you have tests for the bug you are fixing.  See
 819 <code>t/README</code> for guidance.</p></div>
 820 <div class="paragraph" id="tests"><p>When adding a new feature, make sure that you have new tests to show
 821 the feature triggers the new behavior when it should, and to show the
 822 feature does not trigger when it shouldn&#8217;t.  After any code change,
 823 make sure that the entire test suite passes.  When fixing a bug, make
 824 sure you have new tests that break if somebody else breaks what you
 825 fixed by accident to avoid regression.  Also, try merging your work to
 826 <em>next</em> and <em>seen</em> and make sure the tests still pass; topics by others
 827 that are still in flight may have unexpected interactions with what
 828 you are trying to do in your topic.</p></div>
 829 <div class="paragraph"><p>Pushing to a fork of <a href="https://github.com/git/git">https://github.com/git/git</a> will use their CI
 830 integration to test your changes on Linux, Mac and Windows. See the
 831 <a href="#GHCI">GitHub CI</a> section for details.</p></div>
 832 <div class="paragraph"><p>Do not forget to update the documentation to describe the updated
 833 behavior and make sure that the resulting documentation set formats
 834 well (try the Documentation/doc-diff script).</p></div>
 835 <div class="paragraph"><p>We currently have a liberal mixture of US and UK English norms for
 836 spelling and grammar, which is somewhat unfortunate.  A huge patch that
 837 touches the files all over the place only to correct the inconsistency
 838 is not welcome, though.  Potential clashes with other changes that can
 839 result from such a patch are not worth it.  We prefer to gradually
 840 reconcile the inconsistencies in favor of US English, with small and
 841 easily digestible patches, as a side effect of doing some other real
 842 work in the vicinity (e.g. rewriting a paragraph for clarity, while
 843 turning en_UK spelling to en_US).  Obvious typographical fixes are much
 844 more welcomed ("teh &#8594; "the"), preferably submitted as independent
 845 patches separate from other documentation changes.</p></div>
 846 <div class="paragraph" id="whitespace-check"><p>Oh, another thing.  We are picky about whitespaces.  Make sure your
 847 changes do not trigger errors with the sample pre-commit hook shipped
 848 in <code>templates/hooks--pre-commit</code>.  To help ensure this does not happen,
 849 run <code>git diff --check</code> on your changes before you commit.</p></div>
 850 </div>
 851 <div class="sect2">
 852 <h3 id="describe-changes">Describe your changes well.</h3>
 853 <div class="paragraph"><p>The log message that explains your changes is just as important as the
 854 changes themselves.  Your code may be clearly written with in-code
 855 comment to sufficiently explain how it works with the surrounding
 856 code, but those who need to fix or enhance your code in the future
 857 will need to know <em>why</em> your code does what it does, for a few
 858 reasons:</p></div>
 859 <div class="olist arabic"><ol class="arabic">
 860 <li>
 861 <p>
 862 Your code may be doing something differently from what you wanted it
 863   to do.  Writing down what you actually wanted to achieve will help
 864   them fix your code and make it do what it should have been doing
 865   (also, you often discover your own bugs yourself, while writing the
 866   log message to summarize the thought behind it).
 867 </p>
 868 </li>
 869 <li>
 870 <p>
 871 Your code may be doing things that were only necessary for your
 872   immediate needs (e.g. "do X to directories" without implementing or
 873   even designing what is to be done on files).  Writing down why you
 874   excluded what the code does not do will help guide future developers.
 875   Writing down "we do X to directories, because directories have
 876   characteristic Y" would help them infer "oh, files also have the same
 877   characteristic Y, so perhaps doing X to them would also make sense?".
 878   Saying "we don&#8217;t do the same X to files, because &#8230;" will help them
 879   decide if the reasoning is sound (in which case they do not waste
 880   time extending your code to cover files), or reason differently (in
 881   which case, they can explain why they extend your code to cover
 882   files, too).
 883 </p>
 884 </li>
 885 </ol></div>
 886 <div class="paragraph"><p>The goal of your log message is to convey the <em>why</em> behind your
 887 change to help future developers.</p></div>
 888 <div class="paragraph"><p>The first line of the commit message should be a short description (50
 889 characters is the soft limit, see DISCUSSION in <a href="git-commit.html">git-commit(1)</a>),
 890 and should skip the full stop.  It is also conventional in most cases to
 891 prefix the first line with "area: " where the area is a filename or
 892 identifier for the general area of the code being modified, e.g.</p></div>
 893 <div class="ulist"><ul>
 894 <li>
 895 <p>
 896 doc: clarify distinction between sign-off and pgp-signing
 897 </p>
 898 </li>
 899 <li>
 900 <p>
 901 githooks.txt: improve the intro section
 902 </p>
 903 </li>
 904 </ul></div>
 905 <div class="paragraph"><p>If in doubt which identifier to use, run <code>git log --no-merges</code> on the
 906 files you are modifying to see the current conventions.</p></div>
 907 <div class="paragraph" id="summary-section"><p>The title sentence after the "area:" prefix omits the full stop at the
 908 end, and its first word is not capitalized (the omission
 909 of capitalization applies only to the word after the "area:"
 910 prefix of the title) unless there is a reason to
 911 capitalize it other than because it is the first word in the sentence.
 912 E.g. "doc: clarify&#8230;", not "doc: Clarify&#8230;", or "githooks.txt:
 913 improve&#8230;", not "githooks.txt: Improve&#8230;".  But "refs: HEAD is also
 914 treated as a ref" is correct, as we spell <code>HEAD</code> in all caps even when
 915 it appears in the middle of a sentence.</p></div>
 916 <div class="paragraph" id="meaningful-message"><p>The body should provide a meaningful commit message, which:</p></div>
 917 <div class="olist arabic"><ol class="arabic">
 918 <li>
 919 <p>
 920 explains the problem the change tries to solve, i.e. what is wrong
 921   with the current code without the change.
 922 </p>
 923 </li>
 924 <li>
 925 <p>
 926 justifies the way the change solves the problem, i.e. why the
 927   result with the change is better.
 928 </p>
 929 </li>
 930 <li>
 931 <p>
 932 alternate solutions considered but discarded, if any.
 933 </p>
 934 </li>
 935 </ol></div>
 936 <div class="paragraph" id="present-tense"><p>The problem statement that describes the status quo is written in the
 937 present tense.  Write "The code does X when it is given input Y",
 938 instead of "The code used to do Y when given input X".  You do not
 939 have to say "Currently"---the status quo in the problem statement is
 940 about the code <em>without</em> your change, by project convention.</p></div>
 941 <div class="paragraph" id="imperative-mood"><p>Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
 942 instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
 943 to do frotz", as if you are giving orders to the codebase to change
 944 its behavior.  Try to make sure your explanation can be understood
 945 without external resources. Instead of giving a URL to a mailing list
 946 archive, summarize the relevant points of the discussion.</p></div>
 947 <div class="paragraph" id="commit-reference"><p>There are a few reasons why you may want to refer to another commit in
 948 the "more stable" part of the history (i.e. on branches like <code>maint</code>,
 949 <code>master</code>, and <code>next</code>):</p></div>
 950 <div class="olist arabic"><ol class="arabic">
 951 <li>
 952 <p>
 953 A commit that introduced the root cause of a bug you are fixing.
 954 </p>
 955 </li>
 956 <li>
 957 <p>
 958 A commit that introduced a feature that you are enhancing.
 959 </p>
 960 </li>
 961 <li>
 962 <p>
 963 A commit that conflicts with your work when you made a trial merge
 964   of your work into <code>next</code> and <code>seen</code> for testing.
 965 </p>
 966 </li>
 967 </ol></div>
 968 <div class="paragraph"><p>When you reference a commit on a more stable branch (like <code>master</code>,
 969 <code>maint</code> and <code>next</code>), use the format "abbreviated hash (subject,
 970 date)", like this:</p></div>
 971 <div class="literalblock">
 972 <div class="content">
 973 <pre><code>        Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30)
 974         noticed that ...</code></pre>
 975 </div></div>
 976 <div class="paragraph"><p>The "Copy commit summary" command of gitk can be used to obtain this
 977 format (with the subject enclosed in a pair of double-quotes), or this
 978 invocation of <code>git show</code>:</p></div>
 979 <div class="literalblock">
 980 <div class="content">
 981 <pre><code>        git show -s --pretty=reference &lt;commit&gt;</code></pre>
 982 </div></div>
 983 <div class="paragraph"><p>or, on an older version of Git without support for --pretty=reference:</p></div>
 984 <div class="literalblock">
 985 <div class="content">
 986 <pre><code>        git show -s --date=short --pretty='format:%h (%s, %ad)' &lt;commit&gt;</code></pre>
 987 </div></div>
 988 </div>
 989 <div class="sect2">
 990 <h3 id="sign-off">Certify your work by adding your <code>Signed-off-by</code> trailer</h3>
 991 <div class="paragraph"><p>To improve tracking of who did what, we ask you to certify that you
 992 wrote the patch or have the right to pass it on under the same license
 993 as ours, by "signing off" your patch.  Without sign-off, we cannot
 994 accept your patches.</p></div>
 995 <div class="paragraph"><p>If (and only if) you certify the below D-C-O:</p></div>
 996 <div class="quoteblock" id="dco">
 997 <div class="title">Developer&#8217;s Certificate of Origin 1.1</div>
 998 <div class="content">
 999 <div class="paragraph"><p>By making a contribution to this project, I certify that:</p></div>
1000 <div class="olist loweralpha"><ol class="loweralpha">
1001 <li>
1002 <p>
1003 The contribution was created in whole or in part by me and I
1004    have the right to submit it under the open source license
1005    indicated in the file; or
1006 </p>
1007 </li>
1008 <li>
1009 <p>
1010 The contribution is based upon previous work that, to the best
1011    of my knowledge, is covered under an appropriate open source
1012    license and I have the right under that license to submit that
1013    work with modifications, whether created in whole or in part
1014    by me, under the same open source license (unless I am
1015    permitted to submit under a different license), as indicated
1016    in the file; or
1017 </p>
1018 </li>
1019 <li>
1020 <p>
1021 The contribution was provided directly to me by some other
1022    person who certified (a), (b) or (c) and I have not modified
1023    it.
1024 </p>
1025 </li>
1026 <li>
1027 <p>
1028 I understand and agree that this project and the contribution
1029    are public and that a record of the contribution (including all
1030    personal information I submit with it, including my sign-off) is
1031    maintained indefinitely and may be redistributed consistent with
1032    this project or the open source license(s) involved.
1033 </p>
1034 </li>
1035 </ol></div>
1036 </div>
1037 <div class="attribution">
1038 </div></div>
1039 <div class="paragraph"><p>you add a "Signed-off-by" trailer to your commit, that looks like
1040 this:</p></div>
1041 <div class="literalblock">
1042 <div class="content">
1043 <pre><code>        Signed-off-by: Random J Developer &lt;random@developer.example.org&gt;</code></pre>
1044 </div></div>
1045 <div class="paragraph"><p>This line can be added by Git if you run the git-commit command with
1046 the -s option.</p></div>
1047 <div class="paragraph"><p>Notice that you can place your own <code>Signed-off-by</code> trailer when
1048 forwarding somebody else&#8217;s patch with the above rules for
1049 D-C-O.  Indeed you are encouraged to do so.  Do not forget to
1050 place an in-body "From: " line at the beginning to properly attribute
1051 the change to its true author (see (2) above).</p></div>
1052 <div class="paragraph"><p>This procedure originally came from the Linux kernel project, so our
1053 rule is quite similar to theirs, but what exactly it means to sign-off
1054 your patch differs from project to project, so it may be different
1055 from that of the project you are accustomed to.</p></div>
1056 <div class="paragraph" id="real-name"><p>Also notice that a real name is used in the <code>Signed-off-by</code> trailer. Please
1057 don&#8217;t hide your real name.</p></div>
1058 <div class="paragraph" id="commit-trailers"><p>If you like, you can put extra tags at the end:</p></div>
1059 <div class="olist arabic"><ol class="arabic">
1060 <li>
1061 <p>
1062 <code>Reported-by:</code> is used to credit someone who found the bug that
1063   the patch attempts to fix.
1064 </p>
1065 </li>
1066 <li>
1067 <p>
1068 <code>Acked-by:</code> says that the person who is more familiar with the area
1069   the patch attempts to modify liked the patch.
1070 </p>
1071 </li>
1072 <li>
1073 <p>
1074 <code>Reviewed-by:</code>, unlike the other tags, can only be offered by the
1075   reviewers themselves when they are completely satisfied with the
1076   patch after a detailed analysis.
1077 </p>
1078 </li>
1079 <li>
1080 <p>
1081 <code>Tested-by:</code> is used to indicate that the person applied the patch
1082   and found it to have the desired effect.
1083 </p>
1084 </li>
1085 </ol></div>
1086 <div class="paragraph"><p>You can also create your own tag or use one that&#8217;s in common usage
1087 such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".</p></div>
1088 </div>
1089 <div class="sect2">
1090 <h3 id="git-tools">Generate your patch using Git tools out of your commits.</h3>
1091 <div class="paragraph"><p>Git based diff tools generate unidiff which is the preferred format.</p></div>
1092 <div class="paragraph"><p>You do not have to be afraid to use <code>-M</code> option to <code>git diff</code> or
1093 <code>git format-patch</code>, if your patch involves file renames.  The
1094 receiving end can handle them just fine.</p></div>
1095 <div class="paragraph" id="review-patch"><p>Please make sure your patch does not add commented out debugging code,
1096 or include any extra files which do not relate to what your patch
1097 is trying to achieve. Make sure to review
1098 your patch after generating it, to ensure accuracy.  Before
1099 sending out, please make sure it cleanly applies to the base you
1100 have chosen in the "Decide what to base your work on" section,
1101 and unless it targets the <code>master</code> branch (which is the default),
1102 mark your patches as such.</p></div>
1103 </div>
1104 <div class="sect2">
1105 <h3 id="send-patches">Sending your patches.</h3>
1106 <div class="paragraph"><p>Before sending any patches, please note that patches that may be
1107 security relevant should be submitted privately to the Git Security
1108 mailing list<span class="footnote" id="_footnote_security-ml"><br />[The Git Security mailing list: <a href="mailto:git-security@googlegroups.com">git-security@googlegroups.com</a>]<br /></span>, instead of the public mailing list.</p></div>
1109 <div class="paragraph"><p>Learn to use format-patch and send-email if possible.  These commands
1110 are optimized for the workflow of sending patches, avoiding many ways
1111 your existing e-mail client that is optimized for "multipart/*" mime
1112 type e-mails to corrupt and render your patches unusable.</p></div>
1113 <div class="paragraph"><p>People on the Git mailing list need to be able to read and
1114 comment on the changes you are submitting.  It is important for
1115 a developer to be able to "quote" your changes, using standard
1116 e-mail tools, so that they may comment on specific portions of
1117 your code.  For this reason, each patch should be submitted
1118 "inline" in a separate message.</p></div>
1119 <div class="paragraph"><p>Multiple related patches should be grouped into their own e-mail
1120 thread to help readers find all parts of the series.  To that end,
1121 send them as replies to either an additional "cover letter" message
1122 (see below), the first patch, or the respective preceding patch.</p></div>
1123 <div class="paragraph"><p>If your log message (including your name on the
1124 <code>Signed-off-by</code> trailer) is not writable in ASCII, make sure that
1125 you send off a message in the correct encoding.</p></div>
1126 <div class="admonitionblock">
1127 <table><tr>
1128 <td class="icon">
1129 <div class="title">Warning</div>
1130 </td>
1131 <td class="content">Be wary of your MUAs word-wrap
1132 corrupting your patch.  Do not cut-n-paste your patch; you can
1133 lose tabs that way if you are not careful.</td>
1134 </tr></table>
1135 </div>
1136 <div class="paragraph"><p>It is a common convention to prefix your subject line with
1137 [PATCH].  This lets people easily distinguish patches from other
1138 e-mail discussions.  Use of markers in addition to PATCH within
1139 the brackets to describe the nature of the patch is also
1140 encouraged.  E.g. [RFC PATCH] (where RFC stands for "request for
1141 comments") is often used to indicate a patch needs further
1142 discussion before being accepted, [PATCH v2], [PATCH v3] etc.
1143 are often seen when you are sending an update to what you have
1144 previously sent.</p></div>
1145 <div class="paragraph"><p>The <code>git format-patch</code> command follows the best current practice to
1146 format the body of an e-mail message.  At the beginning of the
1147 patch should come your commit message, ending with the
1148 <code>Signed-off-by</code> trailers, and a line that consists of three dashes,
1149 followed by the diffstat information and the patch itself.  If
1150 you are forwarding a patch from somebody else, optionally, at
1151 the beginning of the e-mail message just before the commit
1152 message starts, you can put a "From: " line to name that person.
1153 To change the default "[PATCH]" in the subject to "[&lt;text&gt;]", use
1154 <code>git format-patch --subject-prefix=&lt;text&gt;</code>.  As a shortcut, you
1155 can use <code>--rfc</code> instead of <code>--subject-prefix="RFC PATCH"</code>, or
1156 <code>-v &lt;n&gt;</code> instead of <code>--subject-prefix="PATCH v&lt;n&gt;"</code>.</p></div>
1157 <div class="paragraph"><p>You often want to add additional explanation about the patch,
1158 other than the commit message itself.  Place such "cover letter"
1159 material between the three-dash line and the diffstat.  For
1160 patches requiring multiple iterations of review and discussion,
1161 an explanation of changes between each iteration can be kept in
1162 Git-notes and inserted automatically following the three-dash
1163 line via <code>git format-patch --notes</code>.</p></div>
1164 <div class="paragraph" id="attachment"><p>Do not attach the patch as a MIME attachment, compressed or not.
1165 Do not let your e-mail client send quoted-printable.  Do not let
1166 your e-mail client send format=flowed which would destroy
1167 whitespaces in your patches. Many
1168 popular e-mail applications will not always transmit a MIME
1169 attachment as plain text, making it impossible to comment on
1170 your code.  A MIME attachment also takes a bit more time to
1171 process.  This does not decrease the likelihood of your
1172 MIME-attached change being accepted, but it makes it more likely
1173 that it will be postponed.</p></div>
1174 <div class="paragraph"><p>Exception:  If your mailer is mangling patches then someone may ask
1175 you to re-send them using MIME, that is OK.</p></div>
1176 <div class="paragraph" id="pgp-signature"><p>Do not PGP sign your patch. Most likely, your maintainer or other people on the
1177 list would not have your PGP key and would not bother obtaining it anyway.
1178 Your patch is not judged by who you are; a good patch from an unknown origin
1179 has a far better chance of being accepted than a patch from a known, respected
1180 origin that is done poorly or does incorrect things.</p></div>
1181 <div class="paragraph"><p>If you really really really really want to do a PGP signed
1182 patch, format it as "multipart/signed", not a text/plain message
1183 that starts with <code>-----BEGIN PGP SIGNED MESSAGE-----</code>.  That is
1184 not a text/plain, it&#8217;s something else.</p></div>
1185 <div class="paragraph"><p>As mentioned at the beginning of the section, patches that may be
1186 security relevant should not be submitted to the public mailing list
1187 mentioned below, but should instead be sent privately to the Git
1188 Security mailing list<span class="footnoteref"><br /><a href="#_footnote_security-ml">[security-ml]</a><br /></span>.</p></div>
1189 <div class="paragraph"><p>Send your patch with "To:" set to the mailing list, with "cc:" listing
1190 people who are involved in the area you are touching (the <code>git
1191 contacts</code> command in <code>contrib/contacts/</code> can help to
1192 identify them), to solicit comments and reviews.  Also, when you made
1193 trial merges of your topic to <code>next</code> and <code>seen</code>, you may have noticed
1194 work by others conflicting with your changes.  There is a good possibility
1195 that these people may know the area you are touching well.</p></div>
1196 <div class="paragraph"><p>After the list reached a consensus that it is a good idea to apply the
1197 patch, re-send it with "To:" set to the maintainer<span class="footnote"><br />[The current maintainer: <a href="mailto:gitster@pobox.com">gitster@pobox.com</a>]<br /></span>
1198 and "cc:" the list<span class="footnote"><br />[The mailing list: <a href="mailto:git@vger.kernel.org">git@vger.kernel.org</a>]<br /></span> for inclusion.  This is especially relevant
1199 when the maintainer did not heavily participate in the discussion and
1200 instead left the review to trusted others.</p></div>
1201 <div class="paragraph"><p>Do not forget to add trailers such as <code>Acked-by:</code>, <code>Reviewed-by:</code> and
1202 <code>Tested-by:</code> lines as necessary to credit people who helped your
1203 patch, and "cc:" them when sending such a final version for inclusion.</p></div>
1204 </div>
1205 </div>
1206 </div>
1207 <div class="sect1">
1208 <h2 id="_subsystems_with_dedicated_maintainers">Subsystems with dedicated maintainers</h2>
1209 <div class="sectionbody">
1210 <div class="paragraph"><p>Some parts of the system have dedicated maintainers with their own
1211 repositories.</p></div>
1212 <div class="ulist"><ul>
1213 <li>
1214 <p>
1215 <code>git-gui/</code> comes from git-gui project, maintained by Pratyush Yadav:
1216 </p>
1217 <div class="literalblock">
1218 <div class="content">
1219 <pre><code>https://github.com/prati0100/git-gui.git</code></pre>
1220 </div></div>
1221 </li>
1222 <li>
1223 <p>
1224 <code>gitk-git/</code> comes from Paul Mackerras&#8217;s gitk project:
1225 </p>
1226 <div class="literalblock">
1227 <div class="content">
1228 <pre><code>git://git.ozlabs.org/~paulus/gitk</code></pre>
1229 </div></div>
1230 <div class="literalblock">
1231 <div class="content">
1232 <pre><code>Those who are interested in improve gitk can volunteer to help Paul
1233 in maintaining it cf. &lt;YntxL/fTplFm8lr6@cleo&gt;.</code></pre>
1234 </div></div>
1235 </li>
1236 <li>
1237 <p>
1238 <code>po/</code> comes from the localization coordinator, Jiang Xin:
1239 </p>
1240 <div class="literalblock">
1241 <div class="content">
1242 <pre><code>https://github.com/git-l10n/git-po/</code></pre>
1243 </div></div>
1244 </li>
1245 </ul></div>
1246 <div class="paragraph"><p>Patches to these parts should be based on their trees.</p></div>
1247 </div>
1248 </div>
1249 <div class="sect1">
1250 <h2 id="patch-flow">An ideal patch flow</h2>
1251 <div class="sectionbody">
1252 <div class="paragraph"><p>Here is an ideal patch flow for this project the current maintainer
1253 suggests to the contributors:</p></div>
1254 <div class="olist arabic"><ol class="arabic">
1255 <li>
1256 <p>
1257 You come up with an itch.  You code it up.
1258 </p>
1259 </li>
1260 <li>
1261 <p>
1262 Send it to the list and cc people who may need to know about
1263   the change.
1264 </p>
1265 <div class="paragraph"><p>The people who may need to know are the ones whose code you
1266 are butchering.  These people happen to be the ones who are
1267 most likely to be knowledgeable enough to help you, but
1268 they have no obligation to help you (i.e. you ask for help,
1269 don&#8217;t demand).  <code>git log -p &#45;&#45; <em>$area_you_are_modifying</em></code> would
1270 help you find out who they are.</p></div>
1271 </li>
1272 <li>
1273 <p>
1274 You get comments and suggestions for improvements.  You may
1275   even get them in an "on top of your change" patch form.
1276 </p>
1277 </li>
1278 <li>
1279 <p>
1280 Polish, refine, and re-send to the list and the people who
1281   spend their time to improve your patch.  Go back to step (2).
1282 </p>
1283 </li>
1284 <li>
1285 <p>
1286 The list forms consensus that the last round of your patch is
1287   good.  Send it to the maintainer and cc the list.
1288 </p>
1289 </li>
1290 <li>
1291 <p>
1292 A topic branch is created with the patch and is merged to <code>next</code>,
1293   and cooked further and eventually graduates to <code>master</code>.
1294 </p>
1295 </li>
1296 </ol></div>
1297 <div class="paragraph"><p>In any time between the (2)-(3) cycle, the maintainer may pick it up
1298 from the list and queue it to <code>seen</code>, in order to make it easier for
1299 people play with it without having to pick up and apply the patch to
1300 their trees themselves.</p></div>
1301 </div>
1302 </div>
1303 <div class="sect1">
1304 <h2 id="patch-status">Know the status of your patch after submission</h2>
1305 <div class="sectionbody">
1306 <div class="ulist"><ul>
1307 <li>
1308 <p>
1309 You can use Git itself to find out when your patch is merged in
1310   master. <code>git pull --rebase</code> will automatically skip already-applied
1311   patches, and will let you know. This works only if you rebase on top
1312   of the branch in which your patch has been merged (i.e. it will not
1313   tell you if your patch is merged in <code>seen</code> if you rebase on top of
1314   master).
1315 </p>
1316 </li>
1317 <li>
1318 <p>
1319 Read the Git mailing list, the maintainer regularly posts messages
1320   entitled "What&#8217;s cooking in git.git" and "What&#8217;s in git.git" giving
1321   the status of various proposed changes.
1322 </p>
1323 </li>
1324 </ul></div>
1325 </div>
1326 </div>
1327 <div class="sect1">
1328 <h2 id="_github_ci_a_id_ghci_a">GitHub CI<a id="GHCI"></a></h2>
1329 <div class="sectionbody">
1330 <div class="paragraph"><p>With an account at GitHub, you can use GitHub CI to test your changes
1331 on Linux, Mac and Windows. See
1332 <a href="https://github.com/git/git/actions/workflows/main.yml">https://github.com/git/git/actions/workflows/main.yml</a> for examples of
1333 recent CI runs.</p></div>
1334 <div class="paragraph"><p>Follow these steps for the initial setup:</p></div>
1335 <div class="olist arabic"><ol class="arabic">
1336 <li>
1337 <p>
1338 Fork <a href="https://github.com/git/git">https://github.com/git/git</a> to your GitHub account.
1339   You can find detailed instructions how to fork here:
1340   <a href="https://help.github.com/articles/fork-a-repo/">https://help.github.com/articles/fork-a-repo/</a>
1341 </p>
1342 </li>
1343 </ol></div>
1344 <div class="paragraph"><p>After the initial setup, CI will run whenever you push new changes
1345 to your fork of Git on GitHub.  You can monitor the test state of all your
1346 branches here: <code>https://github.com/&lt;Your GitHub handle&gt;/git/actions/workflows/main.yml</code></p></div>
1347 <div class="paragraph"><p>If a branch did not pass all test cases then it is marked with a red
1348 cross. In that case you can click on the failing job and navigate to
1349 "ci/run-build-and-tests.sh" and/or "ci/print-test-failures.sh". You
1350 can also download "Artifacts" which are tarred (or zipped) archives
1351 with test data relevant for debugging.</p></div>
1352 <div class="paragraph"><p>Then fix the problem and push your fix to your GitHub fork. This will
1353 trigger a new CI build to ensure all tests pass.</p></div>
1354 </div>
1355 </div>
1356 <div class="sect1">
1357 <h2 id="mua">MUA specific hints</h2>
1358 <div class="sectionbody">
1359 <div class="paragraph"><p>Some of the patches I receive or pick up from the list share common
1360 patterns of breakage.  Please make sure your MUA is set up
1361 properly not to corrupt whitespaces.</p></div>
1362 <div class="paragraph"><p>See the DISCUSSION section of <a href="git-format-patch.html">git-format-patch(1)</a> for hints on
1363 checking your patch by mailing it to yourself and applying with
1364 <a href="git-am.html">git-am(1)</a>.</p></div>
1365 <div class="paragraph"><p>While you are at it, check the resulting commit log message from
1366 a trial run of applying the patch.  If what is in the resulting
1367 commit is not exactly what you would want to see, it is very
1368 likely that your maintainer would end up hand editing the log
1369 message when he applies your patch.  Things like "Hi, this is my
1370 first patch.\n", if you really want to put in the patch e-mail,
1371 should come after the three-dash line that signals the end of the
1372 commit message.</p></div>
1373 <div class="sect2">
1374 <h3 id="_pine">Pine</h3>
1375 <div class="paragraph"><p>(Johannes Schindelin)</p></div>
1376 <div class="literalblock">
1377 <div class="content">
1378 <pre><code>I don't know how many people still use pine, but for those poor
1379 souls it may be good to mention that the quell-flowed-text is
1380 needed for recent versions.
1381
1382 ... the "no-strip-whitespace-before-send" option, too. AFAIK it
1383 was introduced in 4.60.</code></pre>
1384 </div></div>
1385 <div class="paragraph"><p>(Linus Torvalds)</p></div>
1386 <div class="literalblock">
1387 <div class="content">
1388 <pre><code>And 4.58 needs at least this.
1389
1390 diff-tree 8326dd8350be64ac7fc805f6563a1d61ad10d32c (from e886a61f76edf5410573e92e38ce22974f9c40f1)
1391 Author: Linus Torvalds &lt;torvalds@g5.osdl.org&gt;
1392 Date:   Mon Aug 15 17:23:51 2005 -0700
1393
1394     Fix pine whitespace-corruption bug
1395
1396     There's no excuse for unconditionally removing whitespace from
1397     the pico buffers on close.
1398
1399 diff --git a/pico/pico.c b/pico/pico.c
1400 --- a/pico/pico.c
1401 +++ b/pico/pico.c
1402 @@ -219,7 +219,9 @@ PICO *pm;
1403             switch(pico_all_done){      /* prepare for/handle final events */
1404               case COMP_EXIT :          /* already confirmed */
1405                 packheader();
1406 +#if 0
1407                 stripwhitespace();
1408 +#endif
1409                 c |= COMP_EXIT;
1410                 break;</code></pre>
1411 </div></div>
1412 <div class="paragraph"><p>(Daniel Barkalow)</p></div>
1413 <div class="literalblock">
1414 <div class="content">
1415 <pre><code>&gt; A patch to SubmittingPatches, MUA specific help section for
1416 &gt; users of Pine 4.63 would be very much appreciated.
1417
1418 Ah, it looks like a recent version changed the default behavior to do the
1419 right thing, and inverted the sense of the configuration option. (Either
1420 that or Gentoo did it.) So you need to set the
1421 "no-strip-whitespace-before-send" option, unless the option you have is
1422 "strip-whitespace-before-send", in which case you should avoid checking
1423 it.</code></pre>
1424 </div></div>
1425 </div>
1426 <div class="sect2">
1427 <h3 id="_thunderbird_kmail_gmail">Thunderbird, KMail, GMail</h3>
1428 <div class="paragraph"><p>See the MUA-SPECIFIC HINTS section of <a href="git-format-patch.html">git-format-patch(1)</a>.</p></div>
1429 </div>
1430 <div class="sect2">
1431 <h3 id="_gnus">Gnus</h3>
1432 <div class="paragraph"><p>"|" in the <code>*Summary*</code> buffer can be used to pipe the current
1433 message to an external program, and this is a handy way to drive
1434 <code>git am</code>.  However, if the message is MIME encoded, what is
1435 piped into the program is the representation you see in your
1436 <code>*Article*</code> buffer after unwrapping MIME.  This is often not what
1437 you would want for two reasons.  It tends to screw up non ASCII
1438 characters (most notably in people&#8217;s names), and also
1439 whitespaces (fatal in patches).  Running "C-u g" to display the
1440 message in raw form before using "|" to run the pipe can work
1441 this problem around.</p></div>
1442 </div>
1443 </div>
1444 </div>
1445 </div>
1446 <div id="footnotes"><hr /></div>
1447 <div id="footer">
1448 <div id="footer-text">
1449 Last updated
1450  2023-06-01 01:26:46 PDT
1451 </div>
1452 </div>
1453 </body>
1454 </html>