Merge branch 'jn/run-command-error-failure' into maint
[git/jnareb-git.git] / revision.c
blob707a703a09d6c7ffc1adfcd89da83d5b97da397f
1 #include "cache.h"
2 #include "tag.h"
3 #include "blob.h"
4 #include "tree.h"
5 #include "commit.h"
6 #include "diff.h"
7 #include "refs.h"
8 #include "revision.h"
9 #include "graph.h"
10 #include "grep.h"
11 #include "reflog-walk.h"
12 #include "patch-ids.h"
13 #include "decorate.h"
14 #include "log-tree.h"
15 #include "string-list.h"
17 volatile show_early_output_fn_t show_early_output;
19 char *path_name(const struct name_path *path, const char *name)
21 const struct name_path *p;
22 char *n, *m;
23 int nlen = strlen(name);
24 int len = nlen + 1;
26 for (p = path; p; p = p->up) {
27 if (p->elem_len)
28 len += p->elem_len + 1;
30 n = xmalloc(len);
31 m = n + len - (nlen + 1);
32 strcpy(m, name);
33 for (p = path; p; p = p->up) {
34 if (p->elem_len) {
35 m -= p->elem_len + 1;
36 memcpy(m, p->elem, p->elem_len);
37 m[p->elem_len] = '/';
40 return n;
43 void add_object(struct object *obj,
44 struct object_array *p,
45 struct name_path *path,
46 const char *name)
48 add_object_array(obj, path_name(path, name), p);
51 static void mark_blob_uninteresting(struct blob *blob)
53 if (!blob)
54 return;
55 if (blob->object.flags & UNINTERESTING)
56 return;
57 blob->object.flags |= UNINTERESTING;
60 void mark_tree_uninteresting(struct tree *tree)
62 struct tree_desc desc;
63 struct name_entry entry;
64 struct object *obj = &tree->object;
66 if (!tree)
67 return;
68 if (obj->flags & UNINTERESTING)
69 return;
70 obj->flags |= UNINTERESTING;
71 if (!has_sha1_file(obj->sha1))
72 return;
73 if (parse_tree(tree) < 0)
74 die("bad tree %s", sha1_to_hex(obj->sha1));
76 init_tree_desc(&desc, tree->buffer, tree->size);
77 while (tree_entry(&desc, &entry)) {
78 switch (object_type(entry.mode)) {
79 case OBJ_TREE:
80 mark_tree_uninteresting(lookup_tree(entry.sha1));
81 break;
82 case OBJ_BLOB:
83 mark_blob_uninteresting(lookup_blob(entry.sha1));
84 break;
85 default:
86 /* Subproject commit - not in this repository */
87 break;
92 * We don't care about the tree any more
93 * after it has been marked uninteresting.
95 free(tree->buffer);
96 tree->buffer = NULL;
99 void mark_parents_uninteresting(struct commit *commit)
101 struct commit_list *parents = commit->parents;
103 while (parents) {
104 struct commit *commit = parents->item;
105 if (!(commit->object.flags & UNINTERESTING)) {
106 commit->object.flags |= UNINTERESTING;
109 * Normally we haven't parsed the parent
110 * yet, so we won't have a parent of a parent
111 * here. However, it may turn out that we've
112 * reached this commit some other way (where it
113 * wasn't uninteresting), in which case we need
114 * to mark its parents recursively too..
116 if (commit->parents)
117 mark_parents_uninteresting(commit);
121 * A missing commit is ok iff its parent is marked
122 * uninteresting.
124 * We just mark such a thing parsed, so that when
125 * it is popped next time around, we won't be trying
126 * to parse it and get an error.
128 if (!has_sha1_file(commit->object.sha1))
129 commit->object.parsed = 1;
130 parents = parents->next;
134 static void add_pending_object_with_mode(struct rev_info *revs, struct object *obj, const char *name, unsigned mode)
136 if (revs->no_walk && (obj->flags & UNINTERESTING))
137 revs->no_walk = 0;
138 if (revs->reflog_info && obj->type == OBJ_COMMIT) {
139 struct strbuf buf = STRBUF_INIT;
140 int len = interpret_branch_name(name, &buf);
141 int st;
143 if (0 < len && name[len] && buf.len)
144 strbuf_addstr(&buf, name + len);
145 st = add_reflog_for_walk(revs->reflog_info,
146 (struct commit *)obj,
147 buf.buf[0] ? buf.buf: name);
148 strbuf_release(&buf);
149 if (st)
150 return;
152 add_object_array_with_mode(obj, name, &revs->pending, mode);
155 void add_pending_object(struct rev_info *revs, struct object *obj, const char *name)
157 add_pending_object_with_mode(revs, obj, name, S_IFINVALID);
160 void add_head_to_pending(struct rev_info *revs)
162 unsigned char sha1[20];
163 struct object *obj;
164 if (get_sha1("HEAD", sha1))
165 return;
166 obj = parse_object(sha1);
167 if (!obj)
168 return;
169 add_pending_object(revs, obj, "HEAD");
172 static struct object *get_reference(struct rev_info *revs, const char *name, const unsigned char *sha1, unsigned int flags)
174 struct object *object;
176 object = parse_object(sha1);
177 if (!object)
178 die("bad object %s", name);
179 object->flags |= flags;
180 return object;
183 static struct commit *handle_commit(struct rev_info *revs, struct object *object, const char *name)
185 unsigned long flags = object->flags;
188 * Tag object? Look what it points to..
190 while (object->type == OBJ_TAG) {
191 struct tag *tag = (struct tag *) object;
192 if (revs->tag_objects && !(flags & UNINTERESTING))
193 add_pending_object(revs, object, tag->tag);
194 if (!tag->tagged)
195 die("bad tag");
196 object = parse_object(tag->tagged->sha1);
197 if (!object) {
198 if (flags & UNINTERESTING)
199 return NULL;
200 die("bad object %s", sha1_to_hex(tag->tagged->sha1));
205 * Commit object? Just return it, we'll do all the complex
206 * reachability crud.
208 if (object->type == OBJ_COMMIT) {
209 struct commit *commit = (struct commit *)object;
210 if (parse_commit(commit) < 0)
211 die("unable to parse commit %s", name);
212 if (flags & UNINTERESTING) {
213 commit->object.flags |= UNINTERESTING;
214 mark_parents_uninteresting(commit);
215 revs->limited = 1;
217 if (revs->show_source && !commit->util)
218 commit->util = (void *) name;
219 return commit;
223 * Tree object? Either mark it uninteresting, or add it
224 * to the list of objects to look at later..
226 if (object->type == OBJ_TREE) {
227 struct tree *tree = (struct tree *)object;
228 if (!revs->tree_objects)
229 return NULL;
230 if (flags & UNINTERESTING) {
231 mark_tree_uninteresting(tree);
232 return NULL;
234 add_pending_object(revs, object, "");
235 return NULL;
239 * Blob object? You know the drill by now..
241 if (object->type == OBJ_BLOB) {
242 struct blob *blob = (struct blob *)object;
243 if (!revs->blob_objects)
244 return NULL;
245 if (flags & UNINTERESTING) {
246 mark_blob_uninteresting(blob);
247 return NULL;
249 add_pending_object(revs, object, "");
250 return NULL;
252 die("%s is unknown object", name);
255 static int everybody_uninteresting(struct commit_list *orig)
257 struct commit_list *list = orig;
258 while (list) {
259 struct commit *commit = list->item;
260 list = list->next;
261 if (commit->object.flags & UNINTERESTING)
262 continue;
263 return 0;
265 return 1;
269 * The goal is to get REV_TREE_NEW as the result only if the
270 * diff consists of all '+' (and no other changes), REV_TREE_OLD
271 * if the whole diff is removal of old data, and otherwise
272 * REV_TREE_DIFFERENT (of course if the trees are the same we
273 * want REV_TREE_SAME).
274 * That means that once we get to REV_TREE_DIFFERENT, we do not
275 * have to look any further.
277 static int tree_difference = REV_TREE_SAME;
279 static void file_add_remove(struct diff_options *options,
280 int addremove, unsigned mode,
281 const unsigned char *sha1,
282 const char *fullpath, unsigned dirty_submodule)
284 int diff = addremove == '+' ? REV_TREE_NEW : REV_TREE_OLD;
286 tree_difference |= diff;
287 if (tree_difference == REV_TREE_DIFFERENT)
288 DIFF_OPT_SET(options, HAS_CHANGES);
291 static void file_change(struct diff_options *options,
292 unsigned old_mode, unsigned new_mode,
293 const unsigned char *old_sha1,
294 const unsigned char *new_sha1,
295 const char *fullpath,
296 unsigned old_dirty_submodule, unsigned new_dirty_submodule)
298 tree_difference = REV_TREE_DIFFERENT;
299 DIFF_OPT_SET(options, HAS_CHANGES);
302 static int rev_compare_tree(struct rev_info *revs, struct commit *parent, struct commit *commit)
304 struct tree *t1 = parent->tree;
305 struct tree *t2 = commit->tree;
307 if (!t1)
308 return REV_TREE_NEW;
309 if (!t2)
310 return REV_TREE_OLD;
312 if (revs->simplify_by_decoration) {
314 * If we are simplifying by decoration, then the commit
315 * is worth showing if it has a tag pointing at it.
317 if (lookup_decoration(&name_decoration, &commit->object))
318 return REV_TREE_DIFFERENT;
320 * A commit that is not pointed by a tag is uninteresting
321 * if we are not limited by path. This means that you will
322 * see the usual "commits that touch the paths" plus any
323 * tagged commit by specifying both --simplify-by-decoration
324 * and pathspec.
326 if (!revs->prune_data.nr)
327 return REV_TREE_SAME;
330 tree_difference = REV_TREE_SAME;
331 DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
332 if (diff_tree_sha1(t1->object.sha1, t2->object.sha1, "",
333 &revs->pruning) < 0)
334 return REV_TREE_DIFFERENT;
335 return tree_difference;
338 static int rev_same_tree_as_empty(struct rev_info *revs, struct commit *commit)
340 int retval;
341 void *tree;
342 unsigned long size;
343 struct tree_desc empty, real;
344 struct tree *t1 = commit->tree;
346 if (!t1)
347 return 0;
349 tree = read_object_with_reference(t1->object.sha1, tree_type, &size, NULL);
350 if (!tree)
351 return 0;
352 init_tree_desc(&real, tree, size);
353 init_tree_desc(&empty, "", 0);
355 tree_difference = REV_TREE_SAME;
356 DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
357 retval = diff_tree(&empty, &real, "", &revs->pruning);
358 free(tree);
360 return retval >= 0 && (tree_difference == REV_TREE_SAME);
363 static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
365 struct commit_list **pp, *parent;
366 int tree_changed = 0, tree_same = 0;
369 * If we don't do pruning, everything is interesting
371 if (!revs->prune)
372 return;
374 if (!commit->tree)
375 return;
377 if (!commit->parents) {
378 if (rev_same_tree_as_empty(revs, commit))
379 commit->object.flags |= TREESAME;
380 return;
384 * Normal non-merge commit? If we don't want to make the
385 * history dense, we consider it always to be a change..
387 if (!revs->dense && !commit->parents->next)
388 return;
390 pp = &commit->parents;
391 while ((parent = *pp) != NULL) {
392 struct commit *p = parent->item;
394 if (parse_commit(p) < 0)
395 die("cannot simplify commit %s (because of %s)",
396 sha1_to_hex(commit->object.sha1),
397 sha1_to_hex(p->object.sha1));
398 switch (rev_compare_tree(revs, p, commit)) {
399 case REV_TREE_SAME:
400 tree_same = 1;
401 if (!revs->simplify_history || (p->object.flags & UNINTERESTING)) {
402 /* Even if a merge with an uninteresting
403 * side branch brought the entire change
404 * we are interested in, we do not want
405 * to lose the other branches of this
406 * merge, so we just keep going.
408 pp = &parent->next;
409 continue;
411 parent->next = NULL;
412 commit->parents = parent;
413 commit->object.flags |= TREESAME;
414 return;
416 case REV_TREE_NEW:
417 if (revs->remove_empty_trees &&
418 rev_same_tree_as_empty(revs, p)) {
419 /* We are adding all the specified
420 * paths from this parent, so the
421 * history beyond this parent is not
422 * interesting. Remove its parents
423 * (they are grandparents for us).
424 * IOW, we pretend this parent is a
425 * "root" commit.
427 if (parse_commit(p) < 0)
428 die("cannot simplify commit %s (invalid %s)",
429 sha1_to_hex(commit->object.sha1),
430 sha1_to_hex(p->object.sha1));
431 p->parents = NULL;
433 /* fallthrough */
434 case REV_TREE_OLD:
435 case REV_TREE_DIFFERENT:
436 tree_changed = 1;
437 pp = &parent->next;
438 continue;
440 die("bad tree compare for commit %s", sha1_to_hex(commit->object.sha1));
442 if (tree_changed && !tree_same)
443 return;
444 commit->object.flags |= TREESAME;
447 static void commit_list_insert_by_date_cached(struct commit *p, struct commit_list **head,
448 struct commit_list *cached_base, struct commit_list **cache)
450 struct commit_list *new_entry;
452 if (cached_base && p->date < cached_base->item->date)
453 new_entry = commit_list_insert_by_date(p, &cached_base->next);
454 else
455 new_entry = commit_list_insert_by_date(p, head);
457 if (cache && (!*cache || p->date < (*cache)->item->date))
458 *cache = new_entry;
461 static int add_parents_to_list(struct rev_info *revs, struct commit *commit,
462 struct commit_list **list, struct commit_list **cache_ptr)
464 struct commit_list *parent = commit->parents;
465 unsigned left_flag;
466 struct commit_list *cached_base = cache_ptr ? *cache_ptr : NULL;
468 if (commit->object.flags & ADDED)
469 return 0;
470 commit->object.flags |= ADDED;
473 * If the commit is uninteresting, don't try to
474 * prune parents - we want the maximal uninteresting
475 * set.
477 * Normally we haven't parsed the parent
478 * yet, so we won't have a parent of a parent
479 * here. However, it may turn out that we've
480 * reached this commit some other way (where it
481 * wasn't uninteresting), in which case we need
482 * to mark its parents recursively too..
484 if (commit->object.flags & UNINTERESTING) {
485 while (parent) {
486 struct commit *p = parent->item;
487 parent = parent->next;
488 if (p)
489 p->object.flags |= UNINTERESTING;
490 if (parse_commit(p) < 0)
491 continue;
492 if (p->parents)
493 mark_parents_uninteresting(p);
494 if (p->object.flags & SEEN)
495 continue;
496 p->object.flags |= SEEN;
497 commit_list_insert_by_date_cached(p, list, cached_base, cache_ptr);
499 return 0;
503 * Ok, the commit wasn't uninteresting. Try to
504 * simplify the commit history and find the parent
505 * that has no differences in the path set if one exists.
507 try_to_simplify_commit(revs, commit);
509 if (revs->no_walk)
510 return 0;
512 left_flag = (commit->object.flags & SYMMETRIC_LEFT);
514 for (parent = commit->parents; parent; parent = parent->next) {
515 struct commit *p = parent->item;
517 if (parse_commit(p) < 0)
518 return -1;
519 if (revs->show_source && !p->util)
520 p->util = commit->util;
521 p->object.flags |= left_flag;
522 if (!(p->object.flags & SEEN)) {
523 p->object.flags |= SEEN;
524 commit_list_insert_by_date_cached(p, list, cached_base, cache_ptr);
526 if (revs->first_parent_only)
527 break;
529 return 0;
532 static void cherry_pick_list(struct commit_list *list, struct rev_info *revs)
534 struct commit_list *p;
535 int left_count = 0, right_count = 0;
536 int left_first;
537 struct patch_ids ids;
538 unsigned cherry_flag;
540 /* First count the commits on the left and on the right */
541 for (p = list; p; p = p->next) {
542 struct commit *commit = p->item;
543 unsigned flags = commit->object.flags;
544 if (flags & BOUNDARY)
546 else if (flags & SYMMETRIC_LEFT)
547 left_count++;
548 else
549 right_count++;
552 if (!left_count || !right_count)
553 return;
555 left_first = left_count < right_count;
556 init_patch_ids(&ids);
557 ids.diffopts.pathspec = revs->diffopt.pathspec;
559 /* Compute patch-ids for one side */
560 for (p = list; p; p = p->next) {
561 struct commit *commit = p->item;
562 unsigned flags = commit->object.flags;
564 if (flags & BOUNDARY)
565 continue;
567 * If we have fewer left, left_first is set and we omit
568 * commits on the right branch in this loop. If we have
569 * fewer right, we skip the left ones.
571 if (left_first != !!(flags & SYMMETRIC_LEFT))
572 continue;
573 commit->util = add_commit_patch_id(commit, &ids);
576 /* either cherry_mark or cherry_pick are true */
577 cherry_flag = revs->cherry_mark ? PATCHSAME : SHOWN;
579 /* Check the other side */
580 for (p = list; p; p = p->next) {
581 struct commit *commit = p->item;
582 struct patch_id *id;
583 unsigned flags = commit->object.flags;
585 if (flags & BOUNDARY)
586 continue;
588 * If we have fewer left, left_first is set and we omit
589 * commits on the left branch in this loop.
591 if (left_first == !!(flags & SYMMETRIC_LEFT))
592 continue;
595 * Have we seen the same patch id?
597 id = has_commit_patch_id(commit, &ids);
598 if (!id)
599 continue;
600 id->seen = 1;
601 commit->object.flags |= cherry_flag;
604 /* Now check the original side for seen ones */
605 for (p = list; p; p = p->next) {
606 struct commit *commit = p->item;
607 struct patch_id *ent;
609 ent = commit->util;
610 if (!ent)
611 continue;
612 if (ent->seen)
613 commit->object.flags |= cherry_flag;
614 commit->util = NULL;
617 free_patch_ids(&ids);
620 /* How many extra uninteresting commits we want to see.. */
621 #define SLOP 5
623 static int still_interesting(struct commit_list *src, unsigned long date, int slop)
626 * No source list at all? We're definitely done..
628 if (!src)
629 return 0;
632 * Does the destination list contain entries with a date
633 * before the source list? Definitely _not_ done.
635 if (date < src->item->date)
636 return SLOP;
639 * Does the source list still have interesting commits in
640 * it? Definitely not done..
642 if (!everybody_uninteresting(src))
643 return SLOP;
645 /* Ok, we're closing in.. */
646 return slop-1;
650 * "rev-list --ancestry-path A..B" computes commits that are ancestors
651 * of B but not ancestors of A but further limits the result to those
652 * that are descendants of A. This takes the list of bottom commits and
653 * the result of "A..B" without --ancestry-path, and limits the latter
654 * further to the ones that can reach one of the commits in "bottom".
656 static void limit_to_ancestry(struct commit_list *bottom, struct commit_list *list)
658 struct commit_list *p;
659 struct commit_list *rlist = NULL;
660 int made_progress;
663 * Reverse the list so that it will be likely that we would
664 * process parents before children.
666 for (p = list; p; p = p->next)
667 commit_list_insert(p->item, &rlist);
669 for (p = bottom; p; p = p->next)
670 p->item->object.flags |= TMP_MARK;
673 * Mark the ones that can reach bottom commits in "list",
674 * in a bottom-up fashion.
676 do {
677 made_progress = 0;
678 for (p = rlist; p; p = p->next) {
679 struct commit *c = p->item;
680 struct commit_list *parents;
681 if (c->object.flags & (TMP_MARK | UNINTERESTING))
682 continue;
683 for (parents = c->parents;
684 parents;
685 parents = parents->next) {
686 if (!(parents->item->object.flags & TMP_MARK))
687 continue;
688 c->object.flags |= TMP_MARK;
689 made_progress = 1;
690 break;
693 } while (made_progress);
696 * NEEDSWORK: decide if we want to remove parents that are
697 * not marked with TMP_MARK from commit->parents for commits
698 * in the resulting list. We may not want to do that, though.
702 * The ones that are not marked with TMP_MARK are uninteresting
704 for (p = list; p; p = p->next) {
705 struct commit *c = p->item;
706 if (c->object.flags & TMP_MARK)
707 continue;
708 c->object.flags |= UNINTERESTING;
711 /* We are done with the TMP_MARK */
712 for (p = list; p; p = p->next)
713 p->item->object.flags &= ~TMP_MARK;
714 for (p = bottom; p; p = p->next)
715 p->item->object.flags &= ~TMP_MARK;
716 free_commit_list(rlist);
720 * Before walking the history, keep the set of "negative" refs the
721 * caller has asked to exclude.
723 * This is used to compute "rev-list --ancestry-path A..B", as we need
724 * to filter the result of "A..B" further to the ones that can actually
725 * reach A.
727 static struct commit_list *collect_bottom_commits(struct commit_list *list)
729 struct commit_list *elem, *bottom = NULL;
730 for (elem = list; elem; elem = elem->next)
731 if (elem->item->object.flags & UNINTERESTING)
732 commit_list_insert(elem->item, &bottom);
733 return bottom;
736 /* Assumes either left_only or right_only is set */
737 static void limit_left_right(struct commit_list *list, struct rev_info *revs)
739 struct commit_list *p;
741 for (p = list; p; p = p->next) {
742 struct commit *commit = p->item;
744 if (revs->right_only) {
745 if (commit->object.flags & SYMMETRIC_LEFT)
746 commit->object.flags |= SHOWN;
747 } else /* revs->left_only is set */
748 if (!(commit->object.flags & SYMMETRIC_LEFT))
749 commit->object.flags |= SHOWN;
753 static int limit_list(struct rev_info *revs)
755 int slop = SLOP;
756 unsigned long date = ~0ul;
757 struct commit_list *list = revs->commits;
758 struct commit_list *newlist = NULL;
759 struct commit_list **p = &newlist;
760 struct commit_list *bottom = NULL;
762 if (revs->ancestry_path) {
763 bottom = collect_bottom_commits(list);
764 if (!bottom)
765 die("--ancestry-path given but there are no bottom commits");
768 while (list) {
769 struct commit_list *entry = list;
770 struct commit *commit = list->item;
771 struct object *obj = &commit->object;
772 show_early_output_fn_t show;
774 list = list->next;
775 free(entry);
777 if (revs->max_age != -1 && (commit->date < revs->max_age))
778 obj->flags |= UNINTERESTING;
779 if (add_parents_to_list(revs, commit, &list, NULL) < 0)
780 return -1;
781 if (obj->flags & UNINTERESTING) {
782 mark_parents_uninteresting(commit);
783 if (revs->show_all)
784 p = &commit_list_insert(commit, p)->next;
785 slop = still_interesting(list, date, slop);
786 if (slop)
787 continue;
788 /* If showing all, add the whole pending list to the end */
789 if (revs->show_all)
790 *p = list;
791 break;
793 if (revs->min_age != -1 && (commit->date > revs->min_age))
794 continue;
795 date = commit->date;
796 p = &commit_list_insert(commit, p)->next;
798 show = show_early_output;
799 if (!show)
800 continue;
802 show(revs, newlist);
803 show_early_output = NULL;
805 if (revs->cherry_pick || revs->cherry_mark)
806 cherry_pick_list(newlist, revs);
808 if (revs->left_only || revs->right_only)
809 limit_left_right(newlist, revs);
811 if (bottom) {
812 limit_to_ancestry(bottom, newlist);
813 free_commit_list(bottom);
816 revs->commits = newlist;
817 return 0;
820 struct all_refs_cb {
821 int all_flags;
822 int warned_bad_reflog;
823 struct rev_info *all_revs;
824 const char *name_for_errormsg;
827 static int handle_one_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
829 struct all_refs_cb *cb = cb_data;
830 struct object *object = get_reference(cb->all_revs, path, sha1,
831 cb->all_flags);
832 add_pending_object(cb->all_revs, object, path);
833 return 0;
836 static void init_all_refs_cb(struct all_refs_cb *cb, struct rev_info *revs,
837 unsigned flags)
839 cb->all_revs = revs;
840 cb->all_flags = flags;
843 static void handle_refs(const char *submodule, struct rev_info *revs, unsigned flags,
844 int (*for_each)(const char *, each_ref_fn, void *))
846 struct all_refs_cb cb;
847 init_all_refs_cb(&cb, revs, flags);
848 for_each(submodule, handle_one_ref, &cb);
851 static void handle_one_reflog_commit(unsigned char *sha1, void *cb_data)
853 struct all_refs_cb *cb = cb_data;
854 if (!is_null_sha1(sha1)) {
855 struct object *o = parse_object(sha1);
856 if (o) {
857 o->flags |= cb->all_flags;
858 add_pending_object(cb->all_revs, o, "");
860 else if (!cb->warned_bad_reflog) {
861 warning("reflog of '%s' references pruned commits",
862 cb->name_for_errormsg);
863 cb->warned_bad_reflog = 1;
868 static int handle_one_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
869 const char *email, unsigned long timestamp, int tz,
870 const char *message, void *cb_data)
872 handle_one_reflog_commit(osha1, cb_data);
873 handle_one_reflog_commit(nsha1, cb_data);
874 return 0;
877 static int handle_one_reflog(const char *path, const unsigned char *sha1, int flag, void *cb_data)
879 struct all_refs_cb *cb = cb_data;
880 cb->warned_bad_reflog = 0;
881 cb->name_for_errormsg = path;
882 for_each_reflog_ent(path, handle_one_reflog_ent, cb_data);
883 return 0;
886 static void handle_reflog(struct rev_info *revs, unsigned flags)
888 struct all_refs_cb cb;
889 cb.all_revs = revs;
890 cb.all_flags = flags;
891 for_each_reflog(handle_one_reflog, &cb);
894 static int add_parents_only(struct rev_info *revs, const char *arg, int flags)
896 unsigned char sha1[20];
897 struct object *it;
898 struct commit *commit;
899 struct commit_list *parents;
901 if (*arg == '^') {
902 flags ^= UNINTERESTING;
903 arg++;
905 if (get_sha1(arg, sha1))
906 return 0;
907 while (1) {
908 it = get_reference(revs, arg, sha1, 0);
909 if (it->type != OBJ_TAG)
910 break;
911 if (!((struct tag*)it)->tagged)
912 return 0;
913 hashcpy(sha1, ((struct tag*)it)->tagged->sha1);
915 if (it->type != OBJ_COMMIT)
916 return 0;
917 commit = (struct commit *)it;
918 for (parents = commit->parents; parents; parents = parents->next) {
919 it = &parents->item->object;
920 it->flags |= flags;
921 add_pending_object(revs, it, arg);
923 return 1;
926 void init_revisions(struct rev_info *revs, const char *prefix)
928 memset(revs, 0, sizeof(*revs));
930 revs->abbrev = DEFAULT_ABBREV;
931 revs->ignore_merges = 1;
932 revs->simplify_history = 1;
933 DIFF_OPT_SET(&revs->pruning, RECURSIVE);
934 DIFF_OPT_SET(&revs->pruning, QUICK);
935 revs->pruning.add_remove = file_add_remove;
936 revs->pruning.change = file_change;
937 revs->lifo = 1;
938 revs->dense = 1;
939 revs->prefix = prefix;
940 revs->max_age = -1;
941 revs->min_age = -1;
942 revs->skip_count = -1;
943 revs->max_count = -1;
944 revs->max_parents = -1;
946 revs->commit_format = CMIT_FMT_DEFAULT;
948 revs->grep_filter.status_only = 1;
949 revs->grep_filter.pattern_tail = &(revs->grep_filter.pattern_list);
950 revs->grep_filter.header_tail = &(revs->grep_filter.header_list);
951 revs->grep_filter.regflags = REG_NEWLINE;
953 diff_setup(&revs->diffopt);
954 if (prefix && !revs->diffopt.prefix) {
955 revs->diffopt.prefix = prefix;
956 revs->diffopt.prefix_length = strlen(prefix);
960 static void add_pending_commit_list(struct rev_info *revs,
961 struct commit_list *commit_list,
962 unsigned int flags)
964 while (commit_list) {
965 struct object *object = &commit_list->item->object;
966 object->flags |= flags;
967 add_pending_object(revs, object, sha1_to_hex(object->sha1));
968 commit_list = commit_list->next;
972 static void prepare_show_merge(struct rev_info *revs)
974 struct commit_list *bases;
975 struct commit *head, *other;
976 unsigned char sha1[20];
977 const char **prune = NULL;
978 int i, prune_num = 1; /* counting terminating NULL */
980 if (get_sha1("HEAD", sha1) || !(head = lookup_commit(sha1)))
981 die("--merge without HEAD?");
982 if (get_sha1("MERGE_HEAD", sha1) || !(other = lookup_commit(sha1)))
983 die("--merge without MERGE_HEAD?");
984 add_pending_object(revs, &head->object, "HEAD");
985 add_pending_object(revs, &other->object, "MERGE_HEAD");
986 bases = get_merge_bases(head, other, 1);
987 add_pending_commit_list(revs, bases, UNINTERESTING);
988 free_commit_list(bases);
989 head->object.flags |= SYMMETRIC_LEFT;
991 if (!active_nr)
992 read_cache();
993 for (i = 0; i < active_nr; i++) {
994 struct cache_entry *ce = active_cache[i];
995 if (!ce_stage(ce))
996 continue;
997 if (ce_path_match(ce, &revs->prune_data)) {
998 prune_num++;
999 prune = xrealloc(prune, sizeof(*prune) * prune_num);
1000 prune[prune_num-2] = ce->name;
1001 prune[prune_num-1] = NULL;
1003 while ((i+1 < active_nr) &&
1004 ce_same_name(ce, active_cache[i+1]))
1005 i++;
1007 free_pathspec(&revs->prune_data);
1008 init_pathspec(&revs->prune_data, prune);
1009 revs->limited = 1;
1012 int handle_revision_arg(const char *arg, struct rev_info *revs,
1013 int flags,
1014 int cant_be_filename)
1016 unsigned mode;
1017 char *dotdot;
1018 struct object *object;
1019 unsigned char sha1[20];
1020 int local_flags;
1022 dotdot = strstr(arg, "..");
1023 if (dotdot) {
1024 unsigned char from_sha1[20];
1025 const char *next = dotdot + 2;
1026 const char *this = arg;
1027 int symmetric = *next == '.';
1028 unsigned int flags_exclude = flags ^ UNINTERESTING;
1030 *dotdot = 0;
1031 next += symmetric;
1033 if (!*next)
1034 next = "HEAD";
1035 if (dotdot == arg)
1036 this = "HEAD";
1037 if (!get_sha1(this, from_sha1) &&
1038 !get_sha1(next, sha1)) {
1039 struct commit *a, *b;
1040 struct commit_list *exclude;
1042 a = lookup_commit_reference(from_sha1);
1043 b = lookup_commit_reference(sha1);
1044 if (!a || !b) {
1045 die(symmetric ?
1046 "Invalid symmetric difference expression %s...%s" :
1047 "Invalid revision range %s..%s",
1048 arg, next);
1051 if (!cant_be_filename) {
1052 *dotdot = '.';
1053 verify_non_filename(revs->prefix, arg);
1056 if (symmetric) {
1057 exclude = get_merge_bases(a, b, 1);
1058 add_pending_commit_list(revs, exclude,
1059 flags_exclude);
1060 free_commit_list(exclude);
1061 a->object.flags |= flags | SYMMETRIC_LEFT;
1062 } else
1063 a->object.flags |= flags_exclude;
1064 b->object.flags |= flags;
1065 add_pending_object(revs, &a->object, this);
1066 add_pending_object(revs, &b->object, next);
1067 return 0;
1069 *dotdot = '.';
1071 dotdot = strstr(arg, "^@");
1072 if (dotdot && !dotdot[2]) {
1073 *dotdot = 0;
1074 if (add_parents_only(revs, arg, flags))
1075 return 0;
1076 *dotdot = '^';
1078 dotdot = strstr(arg, "^!");
1079 if (dotdot && !dotdot[2]) {
1080 *dotdot = 0;
1081 if (!add_parents_only(revs, arg, flags ^ UNINTERESTING))
1082 *dotdot = '^';
1085 local_flags = 0;
1086 if (*arg == '^') {
1087 local_flags = UNINTERESTING;
1088 arg++;
1090 if (get_sha1_with_mode(arg, sha1, &mode))
1091 return -1;
1092 if (!cant_be_filename)
1093 verify_non_filename(revs->prefix, arg);
1094 object = get_reference(revs, arg, sha1, flags ^ local_flags);
1095 add_pending_object_with_mode(revs, object, arg, mode);
1096 return 0;
1099 struct cmdline_pathspec {
1100 int alloc;
1101 int nr;
1102 const char **path;
1105 static void append_prune_data(struct cmdline_pathspec *prune, const char **av)
1107 while (*av) {
1108 ALLOC_GROW(prune->path, prune->nr+1, prune->alloc);
1109 prune->path[prune->nr++] = *(av++);
1113 static void read_pathspec_from_stdin(struct rev_info *revs, struct strbuf *sb,
1114 struct cmdline_pathspec *prune)
1116 while (strbuf_getwholeline(sb, stdin, '\n') != EOF) {
1117 int len = sb->len;
1118 if (len && sb->buf[len - 1] == '\n')
1119 sb->buf[--len] = '\0';
1120 ALLOC_GROW(prune->path, prune->nr+1, prune->alloc);
1121 prune->path[prune->nr++] = xstrdup(sb->buf);
1125 static void read_revisions_from_stdin(struct rev_info *revs,
1126 struct cmdline_pathspec *prune)
1128 struct strbuf sb;
1129 int seen_dashdash = 0;
1131 strbuf_init(&sb, 1000);
1132 while (strbuf_getwholeline(&sb, stdin, '\n') != EOF) {
1133 int len = sb.len;
1134 if (len && sb.buf[len - 1] == '\n')
1135 sb.buf[--len] = '\0';
1136 if (!len)
1137 break;
1138 if (sb.buf[0] == '-') {
1139 if (len == 2 && sb.buf[1] == '-') {
1140 seen_dashdash = 1;
1141 break;
1143 die("options not supported in --stdin mode");
1145 if (handle_revision_arg(sb.buf, revs, 0, 1))
1146 die("bad revision '%s'", sb.buf);
1148 if (seen_dashdash)
1149 read_pathspec_from_stdin(revs, &sb, prune);
1150 strbuf_release(&sb);
1153 static void add_grep(struct rev_info *revs, const char *ptn, enum grep_pat_token what)
1155 append_grep_pattern(&revs->grep_filter, ptn, "command line", 0, what);
1158 static void add_header_grep(struct rev_info *revs, enum grep_header_field field, const char *pattern)
1160 append_header_grep_pattern(&revs->grep_filter, field, pattern);
1163 static void add_message_grep(struct rev_info *revs, const char *pattern)
1165 add_grep(revs, pattern, GREP_PATTERN_BODY);
1168 static int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
1169 int *unkc, const char **unkv)
1171 const char *arg = argv[0];
1172 const char *optarg;
1173 int argcount;
1175 /* pseudo revision arguments */
1176 if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
1177 !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
1178 !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
1179 !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk") ||
1180 !strcmp(arg, "--bisect"))
1182 unkv[(*unkc)++] = arg;
1183 return 1;
1186 if ((argcount = parse_long_opt("max-count", argv, &optarg))) {
1187 revs->max_count = atoi(optarg);
1188 revs->no_walk = 0;
1189 return argcount;
1190 } else if ((argcount = parse_long_opt("skip", argv, &optarg))) {
1191 revs->skip_count = atoi(optarg);
1192 return argcount;
1193 } else if ((*arg == '-') && isdigit(arg[1])) {
1194 /* accept -<digit>, like traditional "head" */
1195 revs->max_count = atoi(arg + 1);
1196 revs->no_walk = 0;
1197 } else if (!strcmp(arg, "-n")) {
1198 if (argc <= 1)
1199 return error("-n requires an argument");
1200 revs->max_count = atoi(argv[1]);
1201 revs->no_walk = 0;
1202 return 2;
1203 } else if (!prefixcmp(arg, "-n")) {
1204 revs->max_count = atoi(arg + 2);
1205 revs->no_walk = 0;
1206 } else if ((argcount = parse_long_opt("max-age", argv, &optarg))) {
1207 revs->max_age = atoi(optarg);
1208 return argcount;
1209 } else if ((argcount = parse_long_opt("since", argv, &optarg))) {
1210 revs->max_age = approxidate(optarg);
1211 return argcount;
1212 } else if ((argcount = parse_long_opt("after", argv, &optarg))) {
1213 revs->max_age = approxidate(optarg);
1214 return argcount;
1215 } else if ((argcount = parse_long_opt("min-age", argv, &optarg))) {
1216 revs->min_age = atoi(optarg);
1217 return argcount;
1218 } else if ((argcount = parse_long_opt("before", argv, &optarg))) {
1219 revs->min_age = approxidate(optarg);
1220 return argcount;
1221 } else if ((argcount = parse_long_opt("until", argv, &optarg))) {
1222 revs->min_age = approxidate(optarg);
1223 return argcount;
1224 } else if (!strcmp(arg, "--first-parent")) {
1225 revs->first_parent_only = 1;
1226 } else if (!strcmp(arg, "--ancestry-path")) {
1227 revs->ancestry_path = 1;
1228 revs->simplify_history = 0;
1229 revs->limited = 1;
1230 } else if (!strcmp(arg, "-g") || !strcmp(arg, "--walk-reflogs")) {
1231 init_reflog_walk(&revs->reflog_info);
1232 } else if (!strcmp(arg, "--default")) {
1233 if (argc <= 1)
1234 return error("bad --default argument");
1235 revs->def = argv[1];
1236 return 2;
1237 } else if (!strcmp(arg, "--merge")) {
1238 revs->show_merge = 1;
1239 } else if (!strcmp(arg, "--topo-order")) {
1240 revs->lifo = 1;
1241 revs->topo_order = 1;
1242 } else if (!strcmp(arg, "--simplify-merges")) {
1243 revs->simplify_merges = 1;
1244 revs->rewrite_parents = 1;
1245 revs->simplify_history = 0;
1246 revs->limited = 1;
1247 } else if (!strcmp(arg, "--simplify-by-decoration")) {
1248 revs->simplify_merges = 1;
1249 revs->rewrite_parents = 1;
1250 revs->simplify_history = 0;
1251 revs->simplify_by_decoration = 1;
1252 revs->limited = 1;
1253 revs->prune = 1;
1254 load_ref_decorations(DECORATE_SHORT_REFS);
1255 } else if (!strcmp(arg, "--date-order")) {
1256 revs->lifo = 0;
1257 revs->topo_order = 1;
1258 } else if (!prefixcmp(arg, "--early-output")) {
1259 int count = 100;
1260 switch (arg[14]) {
1261 case '=':
1262 count = atoi(arg+15);
1263 /* Fallthrough */
1264 case 0:
1265 revs->topo_order = 1;
1266 revs->early_output = count;
1268 } else if (!strcmp(arg, "--parents")) {
1269 revs->rewrite_parents = 1;
1270 revs->print_parents = 1;
1271 } else if (!strcmp(arg, "--dense")) {
1272 revs->dense = 1;
1273 } else if (!strcmp(arg, "--sparse")) {
1274 revs->dense = 0;
1275 } else if (!strcmp(arg, "--show-all")) {
1276 revs->show_all = 1;
1277 } else if (!strcmp(arg, "--remove-empty")) {
1278 revs->remove_empty_trees = 1;
1279 } else if (!strcmp(arg, "--merges")) {
1280 revs->min_parents = 2;
1281 } else if (!strcmp(arg, "--no-merges")) {
1282 revs->max_parents = 1;
1283 } else if (!prefixcmp(arg, "--min-parents=")) {
1284 revs->min_parents = atoi(arg+14);
1285 } else if (!prefixcmp(arg, "--no-min-parents")) {
1286 revs->min_parents = 0;
1287 } else if (!prefixcmp(arg, "--max-parents=")) {
1288 revs->max_parents = atoi(arg+14);
1289 } else if (!prefixcmp(arg, "--no-max-parents")) {
1290 revs->max_parents = -1;
1291 } else if (!strcmp(arg, "--boundary")) {
1292 revs->boundary = 1;
1293 } else if (!strcmp(arg, "--left-right")) {
1294 revs->left_right = 1;
1295 } else if (!strcmp(arg, "--left-only")) {
1296 if (revs->right_only)
1297 die("--left-only is incompatible with --right-only"
1298 " or --cherry");
1299 revs->left_only = 1;
1300 } else if (!strcmp(arg, "--right-only")) {
1301 if (revs->left_only)
1302 die("--right-only is incompatible with --left-only");
1303 revs->right_only = 1;
1304 } else if (!strcmp(arg, "--cherry")) {
1305 if (revs->left_only)
1306 die("--cherry is incompatible with --left-only");
1307 revs->cherry_mark = 1;
1308 revs->right_only = 1;
1309 revs->max_parents = 1;
1310 revs->limited = 1;
1311 } else if (!strcmp(arg, "--count")) {
1312 revs->count = 1;
1313 } else if (!strcmp(arg, "--cherry-mark")) {
1314 if (revs->cherry_pick)
1315 die("--cherry-mark is incompatible with --cherry-pick");
1316 revs->cherry_mark = 1;
1317 revs->limited = 1; /* needs limit_list() */
1318 } else if (!strcmp(arg, "--cherry-pick")) {
1319 if (revs->cherry_mark)
1320 die("--cherry-pick is incompatible with --cherry-mark");
1321 revs->cherry_pick = 1;
1322 revs->limited = 1;
1323 } else if (!strcmp(arg, "--objects")) {
1324 revs->tag_objects = 1;
1325 revs->tree_objects = 1;
1326 revs->blob_objects = 1;
1327 } else if (!strcmp(arg, "--objects-edge")) {
1328 revs->tag_objects = 1;
1329 revs->tree_objects = 1;
1330 revs->blob_objects = 1;
1331 revs->edge_hint = 1;
1332 } else if (!strcmp(arg, "--unpacked")) {
1333 revs->unpacked = 1;
1334 } else if (!prefixcmp(arg, "--unpacked=")) {
1335 die("--unpacked=<packfile> no longer supported.");
1336 } else if (!strcmp(arg, "-r")) {
1337 revs->diff = 1;
1338 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1339 } else if (!strcmp(arg, "-t")) {
1340 revs->diff = 1;
1341 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1342 DIFF_OPT_SET(&revs->diffopt, TREE_IN_RECURSIVE);
1343 } else if (!strcmp(arg, "-m")) {
1344 revs->ignore_merges = 0;
1345 } else if (!strcmp(arg, "-c")) {
1346 revs->diff = 1;
1347 revs->dense_combined_merges = 0;
1348 revs->combine_merges = 1;
1349 } else if (!strcmp(arg, "--cc")) {
1350 revs->diff = 1;
1351 revs->dense_combined_merges = 1;
1352 revs->combine_merges = 1;
1353 } else if (!strcmp(arg, "-v")) {
1354 revs->verbose_header = 1;
1355 } else if (!strcmp(arg, "--pretty")) {
1356 revs->verbose_header = 1;
1357 revs->pretty_given = 1;
1358 get_commit_format(arg+8, revs);
1359 } else if (!prefixcmp(arg, "--pretty=") || !prefixcmp(arg, "--format=")) {
1361 * Detached form ("--pretty X" as opposed to "--pretty=X")
1362 * not allowed, since the argument is optional.
1364 revs->verbose_header = 1;
1365 revs->pretty_given = 1;
1366 get_commit_format(arg+9, revs);
1367 } else if (!strcmp(arg, "--show-notes")) {
1368 revs->show_notes = 1;
1369 revs->show_notes_given = 1;
1370 } else if (!prefixcmp(arg, "--show-notes=")) {
1371 struct strbuf buf = STRBUF_INIT;
1372 revs->show_notes = 1;
1373 revs->show_notes_given = 1;
1374 if (!revs->notes_opt.extra_notes_refs)
1375 revs->notes_opt.extra_notes_refs = xcalloc(1, sizeof(struct string_list));
1376 if (!prefixcmp(arg+13, "refs/"))
1377 /* happy */;
1378 else if (!prefixcmp(arg+13, "notes/"))
1379 strbuf_addstr(&buf, "refs/");
1380 else
1381 strbuf_addstr(&buf, "refs/notes/");
1382 strbuf_addstr(&buf, arg+13);
1383 string_list_append(revs->notes_opt.extra_notes_refs,
1384 strbuf_detach(&buf, NULL));
1385 } else if (!strcmp(arg, "--no-notes")) {
1386 revs->show_notes = 0;
1387 revs->show_notes_given = 1;
1388 } else if (!strcmp(arg, "--standard-notes")) {
1389 revs->show_notes_given = 1;
1390 revs->notes_opt.suppress_default_notes = 0;
1391 } else if (!strcmp(arg, "--no-standard-notes")) {
1392 revs->notes_opt.suppress_default_notes = 1;
1393 } else if (!strcmp(arg, "--oneline")) {
1394 revs->verbose_header = 1;
1395 get_commit_format("oneline", revs);
1396 revs->pretty_given = 1;
1397 revs->abbrev_commit = 1;
1398 } else if (!strcmp(arg, "--graph")) {
1399 revs->topo_order = 1;
1400 revs->rewrite_parents = 1;
1401 revs->graph = graph_init(revs);
1402 } else if (!strcmp(arg, "--root")) {
1403 revs->show_root_diff = 1;
1404 } else if (!strcmp(arg, "--no-commit-id")) {
1405 revs->no_commit_id = 1;
1406 } else if (!strcmp(arg, "--always")) {
1407 revs->always_show_header = 1;
1408 } else if (!strcmp(arg, "--no-abbrev")) {
1409 revs->abbrev = 0;
1410 } else if (!strcmp(arg, "--abbrev")) {
1411 revs->abbrev = DEFAULT_ABBREV;
1412 } else if (!prefixcmp(arg, "--abbrev=")) {
1413 revs->abbrev = strtoul(arg + 9, NULL, 10);
1414 if (revs->abbrev < MINIMUM_ABBREV)
1415 revs->abbrev = MINIMUM_ABBREV;
1416 else if (revs->abbrev > 40)
1417 revs->abbrev = 40;
1418 } else if (!strcmp(arg, "--abbrev-commit")) {
1419 revs->abbrev_commit = 1;
1420 } else if (!strcmp(arg, "--full-diff")) {
1421 revs->diff = 1;
1422 revs->full_diff = 1;
1423 } else if (!strcmp(arg, "--full-history")) {
1424 revs->simplify_history = 0;
1425 } else if (!strcmp(arg, "--relative-date")) {
1426 revs->date_mode = DATE_RELATIVE;
1427 revs->date_mode_explicit = 1;
1428 } else if ((argcount = parse_long_opt("date", argv, &optarg))) {
1429 revs->date_mode = parse_date_format(optarg);
1430 revs->date_mode_explicit = 1;
1431 return argcount;
1432 } else if (!strcmp(arg, "--log-size")) {
1433 revs->show_log_size = 1;
1436 * Grepping the commit log
1438 else if ((argcount = parse_long_opt("author", argv, &optarg))) {
1439 add_header_grep(revs, GREP_HEADER_AUTHOR, optarg);
1440 return argcount;
1441 } else if ((argcount = parse_long_opt("committer", argv, &optarg))) {
1442 add_header_grep(revs, GREP_HEADER_COMMITTER, optarg);
1443 return argcount;
1444 } else if ((argcount = parse_long_opt("grep", argv, &optarg))) {
1445 add_message_grep(revs, optarg);
1446 return argcount;
1447 } else if (!strcmp(arg, "--extended-regexp") || !strcmp(arg, "-E")) {
1448 revs->grep_filter.regflags |= REG_EXTENDED;
1449 } else if (!strcmp(arg, "--regexp-ignore-case") || !strcmp(arg, "-i")) {
1450 revs->grep_filter.regflags |= REG_ICASE;
1451 } else if (!strcmp(arg, "--fixed-strings") || !strcmp(arg, "-F")) {
1452 revs->grep_filter.fixed = 1;
1453 } else if (!strcmp(arg, "--all-match")) {
1454 revs->grep_filter.all_match = 1;
1455 } else if ((argcount = parse_long_opt("encoding", argv, &optarg))) {
1456 if (strcmp(optarg, "none"))
1457 git_log_output_encoding = xstrdup(optarg);
1458 else
1459 git_log_output_encoding = "";
1460 return argcount;
1461 } else if (!strcmp(arg, "--reverse")) {
1462 revs->reverse ^= 1;
1463 } else if (!strcmp(arg, "--children")) {
1464 revs->children.name = "children";
1465 revs->limited = 1;
1466 } else {
1467 int opts = diff_opt_parse(&revs->diffopt, argv, argc);
1468 if (!opts)
1469 unkv[(*unkc)++] = arg;
1470 return opts;
1473 return 1;
1476 void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
1477 const struct option *options,
1478 const char * const usagestr[])
1480 int n = handle_revision_opt(revs, ctx->argc, ctx->argv,
1481 &ctx->cpidx, ctx->out);
1482 if (n <= 0) {
1483 error("unknown option `%s'", ctx->argv[0]);
1484 usage_with_options(usagestr, options);
1486 ctx->argv += n;
1487 ctx->argc -= n;
1490 static int for_each_bad_bisect_ref(const char *submodule, each_ref_fn fn, void *cb_data)
1492 return for_each_ref_in_submodule(submodule, "refs/bisect/bad", fn, cb_data);
1495 static int for_each_good_bisect_ref(const char *submodule, each_ref_fn fn, void *cb_data)
1497 return for_each_ref_in_submodule(submodule, "refs/bisect/good", fn, cb_data);
1501 * Parse revision information, filling in the "rev_info" structure,
1502 * and removing the used arguments from the argument list.
1504 * Returns the number of arguments left that weren't recognized
1505 * (which are also moved to the head of the argument list)
1507 int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct setup_revision_opt *opt)
1509 int i, flags, left, seen_dashdash, read_from_stdin, got_rev_arg = 0;
1510 struct cmdline_pathspec prune_data;
1511 const char *submodule = NULL;
1512 const char *optarg;
1513 int argcount;
1515 memset(&prune_data, 0, sizeof(prune_data));
1516 if (opt)
1517 submodule = opt->submodule;
1519 /* First, search for "--" */
1520 seen_dashdash = 0;
1521 for (i = 1; i < argc; i++) {
1522 const char *arg = argv[i];
1523 if (strcmp(arg, "--"))
1524 continue;
1525 argv[i] = NULL;
1526 argc = i;
1527 if (argv[i + 1])
1528 append_prune_data(&prune_data, argv + i + 1);
1529 seen_dashdash = 1;
1530 break;
1533 /* Second, deal with arguments and options */
1534 flags = 0;
1535 read_from_stdin = 0;
1536 for (left = i = 1; i < argc; i++) {
1537 const char *arg = argv[i];
1538 if (*arg == '-') {
1539 int opts;
1541 if (!strcmp(arg, "--all")) {
1542 handle_refs(submodule, revs, flags, for_each_ref_submodule);
1543 handle_refs(submodule, revs, flags, head_ref_submodule);
1544 continue;
1546 if (!strcmp(arg, "--branches")) {
1547 handle_refs(submodule, revs, flags, for_each_branch_ref_submodule);
1548 continue;
1550 if (!strcmp(arg, "--bisect")) {
1551 handle_refs(submodule, revs, flags, for_each_bad_bisect_ref);
1552 handle_refs(submodule, revs, flags ^ UNINTERESTING, for_each_good_bisect_ref);
1553 revs->bisect = 1;
1554 continue;
1556 if (!strcmp(arg, "--tags")) {
1557 handle_refs(submodule, revs, flags, for_each_tag_ref_submodule);
1558 continue;
1560 if (!strcmp(arg, "--remotes")) {
1561 handle_refs(submodule, revs, flags, for_each_remote_ref_submodule);
1562 continue;
1564 if ((argcount = parse_long_opt("glob", argv + i, &optarg))) {
1565 struct all_refs_cb cb;
1566 i += argcount - 1;
1567 init_all_refs_cb(&cb, revs, flags);
1568 for_each_glob_ref(handle_one_ref, optarg, &cb);
1569 continue;
1571 if (!prefixcmp(arg, "--branches=")) {
1572 struct all_refs_cb cb;
1573 init_all_refs_cb(&cb, revs, flags);
1574 for_each_glob_ref_in(handle_one_ref, arg + 11, "refs/heads/", &cb);
1575 continue;
1577 if (!prefixcmp(arg, "--tags=")) {
1578 struct all_refs_cb cb;
1579 init_all_refs_cb(&cb, revs, flags);
1580 for_each_glob_ref_in(handle_one_ref, arg + 7, "refs/tags/", &cb);
1581 continue;
1583 if (!prefixcmp(arg, "--remotes=")) {
1584 struct all_refs_cb cb;
1585 init_all_refs_cb(&cb, revs, flags);
1586 for_each_glob_ref_in(handle_one_ref, arg + 10, "refs/remotes/", &cb);
1587 continue;
1589 if (!strcmp(arg, "--reflog")) {
1590 handle_reflog(revs, flags);
1591 continue;
1593 if (!strcmp(arg, "--not")) {
1594 flags ^= UNINTERESTING;
1595 continue;
1597 if (!strcmp(arg, "--no-walk")) {
1598 revs->no_walk = 1;
1599 continue;
1601 if (!strcmp(arg, "--do-walk")) {
1602 revs->no_walk = 0;
1603 continue;
1605 if (!strcmp(arg, "--stdin")) {
1606 if (revs->disable_stdin) {
1607 argv[left++] = arg;
1608 continue;
1610 if (read_from_stdin++)
1611 die("--stdin given twice?");
1612 read_revisions_from_stdin(revs, &prune_data);
1613 continue;
1616 opts = handle_revision_opt(revs, argc - i, argv + i, &left, argv);
1617 if (opts > 0) {
1618 i += opts - 1;
1619 continue;
1621 if (opts < 0)
1622 exit(128);
1623 continue;
1626 if (handle_revision_arg(arg, revs, flags, seen_dashdash)) {
1627 int j;
1628 if (seen_dashdash || *arg == '^')
1629 die("bad revision '%s'", arg);
1631 /* If we didn't have a "--":
1632 * (1) all filenames must exist;
1633 * (2) all rev-args must not be interpretable
1634 * as a valid filename.
1635 * but the latter we have checked in the main loop.
1637 for (j = i; j < argc; j++)
1638 verify_filename(revs->prefix, argv[j]);
1640 append_prune_data(&prune_data, argv + i);
1641 break;
1643 else
1644 got_rev_arg = 1;
1647 if (prune_data.nr) {
1648 ALLOC_GROW(prune_data.path, prune_data.nr+1, prune_data.alloc);
1649 prune_data.path[prune_data.nr++] = NULL;
1650 init_pathspec(&revs->prune_data,
1651 get_pathspec(revs->prefix, prune_data.path));
1654 if (revs->def == NULL)
1655 revs->def = opt ? opt->def : NULL;
1656 if (opt && opt->tweak)
1657 opt->tweak(revs, opt);
1658 if (revs->show_merge)
1659 prepare_show_merge(revs);
1660 if (revs->def && !revs->pending.nr && !got_rev_arg) {
1661 unsigned char sha1[20];
1662 struct object *object;
1663 unsigned mode;
1664 if (get_sha1_with_mode(revs->def, sha1, &mode))
1665 die("bad default revision '%s'", revs->def);
1666 object = get_reference(revs, revs->def, sha1, 0);
1667 add_pending_object_with_mode(revs, object, revs->def, mode);
1670 /* Did the user ask for any diff output? Run the diff! */
1671 if (revs->diffopt.output_format & ~DIFF_FORMAT_NO_OUTPUT)
1672 revs->diff = 1;
1674 /* Pickaxe, diff-filter and rename following need diffs */
1675 if (revs->diffopt.pickaxe ||
1676 revs->diffopt.filter ||
1677 DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
1678 revs->diff = 1;
1680 if (revs->topo_order)
1681 revs->limited = 1;
1683 if (revs->prune_data.nr) {
1684 diff_tree_setup_paths(revs->prune_data.raw, &revs->pruning);
1685 /* Can't prune commits with rename following: the paths change.. */
1686 if (!DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
1687 revs->prune = 1;
1688 if (!revs->full_diff)
1689 diff_tree_setup_paths(revs->prune_data.raw, &revs->diffopt);
1691 if (revs->combine_merges)
1692 revs->ignore_merges = 0;
1693 revs->diffopt.abbrev = revs->abbrev;
1694 if (diff_setup_done(&revs->diffopt) < 0)
1695 die("diff_setup_done failed");
1697 compile_grep_patterns(&revs->grep_filter);
1699 if (revs->reverse && revs->reflog_info)
1700 die("cannot combine --reverse with --walk-reflogs");
1701 if (revs->rewrite_parents && revs->children.name)
1702 die("cannot combine --parents and --children");
1705 * Limitations on the graph functionality
1707 if (revs->reverse && revs->graph)
1708 die("cannot combine --reverse with --graph");
1710 if (revs->reflog_info && revs->graph)
1711 die("cannot combine --walk-reflogs with --graph");
1713 return left;
1716 static void add_child(struct rev_info *revs, struct commit *parent, struct commit *child)
1718 struct commit_list *l = xcalloc(1, sizeof(*l));
1720 l->item = child;
1721 l->next = add_decoration(&revs->children, &parent->object, l);
1724 static int remove_duplicate_parents(struct commit *commit)
1726 struct commit_list **pp, *p;
1727 int surviving_parents;
1729 /* Examine existing parents while marking ones we have seen... */
1730 pp = &commit->parents;
1731 while ((p = *pp) != NULL) {
1732 struct commit *parent = p->item;
1733 if (parent->object.flags & TMP_MARK) {
1734 *pp = p->next;
1735 continue;
1737 parent->object.flags |= TMP_MARK;
1738 pp = &p->next;
1740 /* count them while clearing the temporary mark */
1741 surviving_parents = 0;
1742 for (p = commit->parents; p; p = p->next) {
1743 p->item->object.flags &= ~TMP_MARK;
1744 surviving_parents++;
1746 return surviving_parents;
1749 struct merge_simplify_state {
1750 struct commit *simplified;
1753 static struct merge_simplify_state *locate_simplify_state(struct rev_info *revs, struct commit *commit)
1755 struct merge_simplify_state *st;
1757 st = lookup_decoration(&revs->merge_simplification, &commit->object);
1758 if (!st) {
1759 st = xcalloc(1, sizeof(*st));
1760 add_decoration(&revs->merge_simplification, &commit->object, st);
1762 return st;
1765 static struct commit_list **simplify_one(struct rev_info *revs, struct commit *commit, struct commit_list **tail)
1767 struct commit_list *p;
1768 struct merge_simplify_state *st, *pst;
1769 int cnt;
1771 st = locate_simplify_state(revs, commit);
1774 * Have we handled this one?
1776 if (st->simplified)
1777 return tail;
1780 * An UNINTERESTING commit simplifies to itself, so does a
1781 * root commit. We do not rewrite parents of such commit
1782 * anyway.
1784 if ((commit->object.flags & UNINTERESTING) || !commit->parents) {
1785 st->simplified = commit;
1786 return tail;
1790 * Do we know what commit all of our parents should be rewritten to?
1791 * Otherwise we are not ready to rewrite this one yet.
1793 for (cnt = 0, p = commit->parents; p; p = p->next) {
1794 pst = locate_simplify_state(revs, p->item);
1795 if (!pst->simplified) {
1796 tail = &commit_list_insert(p->item, tail)->next;
1797 cnt++;
1800 if (cnt) {
1801 tail = &commit_list_insert(commit, tail)->next;
1802 return tail;
1806 * Rewrite our list of parents.
1808 for (p = commit->parents; p; p = p->next) {
1809 pst = locate_simplify_state(revs, p->item);
1810 p->item = pst->simplified;
1812 cnt = remove_duplicate_parents(commit);
1815 * It is possible that we are a merge and one side branch
1816 * does not have any commit that touches the given paths;
1817 * in such a case, the immediate parents will be rewritten
1818 * to different commits.
1820 * o----X X: the commit we are looking at;
1821 * / / o: a commit that touches the paths;
1822 * ---o----'
1824 * Further reduce the parents by removing redundant parents.
1826 if (1 < cnt) {
1827 struct commit_list *h = reduce_heads(commit->parents);
1828 cnt = commit_list_count(h);
1829 free_commit_list(commit->parents);
1830 commit->parents = h;
1834 * A commit simplifies to itself if it is a root, if it is
1835 * UNINTERESTING, if it touches the given paths, or if it is a
1836 * merge and its parents simplifies to more than one commits
1837 * (the first two cases are already handled at the beginning of
1838 * this function).
1840 * Otherwise, it simplifies to what its sole parent simplifies to.
1842 if (!cnt ||
1843 (commit->object.flags & UNINTERESTING) ||
1844 !(commit->object.flags & TREESAME) ||
1845 (1 < cnt))
1846 st->simplified = commit;
1847 else {
1848 pst = locate_simplify_state(revs, commit->parents->item);
1849 st->simplified = pst->simplified;
1851 return tail;
1854 static void simplify_merges(struct rev_info *revs)
1856 struct commit_list *list;
1857 struct commit_list *yet_to_do, **tail;
1859 if (!revs->topo_order)
1860 sort_in_topological_order(&revs->commits, revs->lifo);
1861 if (!revs->prune)
1862 return;
1864 /* feed the list reversed */
1865 yet_to_do = NULL;
1866 for (list = revs->commits; list; list = list->next)
1867 commit_list_insert(list->item, &yet_to_do);
1868 while (yet_to_do) {
1869 list = yet_to_do;
1870 yet_to_do = NULL;
1871 tail = &yet_to_do;
1872 while (list) {
1873 struct commit *commit = list->item;
1874 struct commit_list *next = list->next;
1875 free(list);
1876 list = next;
1877 tail = simplify_one(revs, commit, tail);
1881 /* clean up the result, removing the simplified ones */
1882 list = revs->commits;
1883 revs->commits = NULL;
1884 tail = &revs->commits;
1885 while (list) {
1886 struct commit *commit = list->item;
1887 struct commit_list *next = list->next;
1888 struct merge_simplify_state *st;
1889 free(list);
1890 list = next;
1891 st = locate_simplify_state(revs, commit);
1892 if (st->simplified == commit)
1893 tail = &commit_list_insert(commit, tail)->next;
1897 static void set_children(struct rev_info *revs)
1899 struct commit_list *l;
1900 for (l = revs->commits; l; l = l->next) {
1901 struct commit *commit = l->item;
1902 struct commit_list *p;
1904 for (p = commit->parents; p; p = p->next)
1905 add_child(revs, p->item, commit);
1909 int prepare_revision_walk(struct rev_info *revs)
1911 int nr = revs->pending.nr;
1912 struct object_array_entry *e, *list;
1914 e = list = revs->pending.objects;
1915 revs->pending.nr = 0;
1916 revs->pending.alloc = 0;
1917 revs->pending.objects = NULL;
1918 while (--nr >= 0) {
1919 struct commit *commit = handle_commit(revs, e->item, e->name);
1920 if (commit) {
1921 if (!(commit->object.flags & SEEN)) {
1922 commit->object.flags |= SEEN;
1923 commit_list_insert_by_date(commit, &revs->commits);
1926 e++;
1928 free(list);
1930 if (revs->no_walk)
1931 return 0;
1932 if (revs->limited)
1933 if (limit_list(revs) < 0)
1934 return -1;
1935 if (revs->topo_order)
1936 sort_in_topological_order(&revs->commits, revs->lifo);
1937 if (revs->simplify_merges)
1938 simplify_merges(revs);
1939 if (revs->children.name)
1940 set_children(revs);
1941 return 0;
1944 enum rewrite_result {
1945 rewrite_one_ok,
1946 rewrite_one_noparents,
1947 rewrite_one_error
1950 static enum rewrite_result rewrite_one(struct rev_info *revs, struct commit **pp)
1952 struct commit_list *cache = NULL;
1954 for (;;) {
1955 struct commit *p = *pp;
1956 if (!revs->limited)
1957 if (add_parents_to_list(revs, p, &revs->commits, &cache) < 0)
1958 return rewrite_one_error;
1959 if (p->parents && p->parents->next)
1960 return rewrite_one_ok;
1961 if (p->object.flags & UNINTERESTING)
1962 return rewrite_one_ok;
1963 if (!(p->object.flags & TREESAME))
1964 return rewrite_one_ok;
1965 if (!p->parents)
1966 return rewrite_one_noparents;
1967 *pp = p->parents->item;
1971 static int rewrite_parents(struct rev_info *revs, struct commit *commit)
1973 struct commit_list **pp = &commit->parents;
1974 while (*pp) {
1975 struct commit_list *parent = *pp;
1976 switch (rewrite_one(revs, &parent->item)) {
1977 case rewrite_one_ok:
1978 break;
1979 case rewrite_one_noparents:
1980 *pp = parent->next;
1981 continue;
1982 case rewrite_one_error:
1983 return -1;
1985 pp = &parent->next;
1987 remove_duplicate_parents(commit);
1988 return 0;
1991 static int commit_match(struct commit *commit, struct rev_info *opt)
1993 if (!opt->grep_filter.pattern_list && !opt->grep_filter.header_list)
1994 return 1;
1995 return grep_buffer(&opt->grep_filter,
1996 NULL, /* we say nothing, not even filename */
1997 commit->buffer, strlen(commit->buffer));
2000 static inline int want_ancestry(struct rev_info *revs)
2002 return (revs->rewrite_parents || revs->children.name);
2005 enum commit_action get_commit_action(struct rev_info *revs, struct commit *commit)
2007 if (commit->object.flags & SHOWN)
2008 return commit_ignore;
2009 if (revs->unpacked && has_sha1_pack(commit->object.sha1))
2010 return commit_ignore;
2011 if (revs->show_all)
2012 return commit_show;
2013 if (commit->object.flags & UNINTERESTING)
2014 return commit_ignore;
2015 if (revs->min_age != -1 && (commit->date > revs->min_age))
2016 return commit_ignore;
2017 if (revs->min_parents || (revs->max_parents >= 0)) {
2018 int n = 0;
2019 struct commit_list *p;
2020 for (p = commit->parents; p; p = p->next)
2021 n++;
2022 if ((n < revs->min_parents) ||
2023 ((revs->max_parents >= 0) && (n > revs->max_parents)))
2024 return commit_ignore;
2026 if (!commit_match(commit, revs))
2027 return commit_ignore;
2028 if (revs->prune && revs->dense) {
2029 /* Commit without changes? */
2030 if (commit->object.flags & TREESAME) {
2031 /* drop merges unless we want parenthood */
2032 if (!want_ancestry(revs))
2033 return commit_ignore;
2034 /* non-merge - always ignore it */
2035 if (!commit->parents || !commit->parents->next)
2036 return commit_ignore;
2039 return commit_show;
2042 enum commit_action simplify_commit(struct rev_info *revs, struct commit *commit)
2044 enum commit_action action = get_commit_action(revs, commit);
2046 if (action == commit_show &&
2047 !revs->show_all &&
2048 revs->prune && revs->dense && want_ancestry(revs)) {
2049 if (rewrite_parents(revs, commit) < 0)
2050 return commit_error;
2052 return action;
2055 static struct commit *get_revision_1(struct rev_info *revs)
2057 if (!revs->commits)
2058 return NULL;
2060 do {
2061 struct commit_list *entry = revs->commits;
2062 struct commit *commit = entry->item;
2064 revs->commits = entry->next;
2065 free(entry);
2067 if (revs->reflog_info) {
2068 fake_reflog_parent(revs->reflog_info, commit);
2069 commit->object.flags &= ~(ADDED | SEEN | SHOWN);
2073 * If we haven't done the list limiting, we need to look at
2074 * the parents here. We also need to do the date-based limiting
2075 * that we'd otherwise have done in limit_list().
2077 if (!revs->limited) {
2078 if (revs->max_age != -1 &&
2079 (commit->date < revs->max_age))
2080 continue;
2081 if (add_parents_to_list(revs, commit, &revs->commits, NULL) < 0)
2082 die("Failed to traverse parents of commit %s",
2083 sha1_to_hex(commit->object.sha1));
2086 switch (simplify_commit(revs, commit)) {
2087 case commit_ignore:
2088 continue;
2089 case commit_error:
2090 die("Failed to simplify parents of commit %s",
2091 sha1_to_hex(commit->object.sha1));
2092 default:
2093 return commit;
2095 } while (revs->commits);
2096 return NULL;
2099 static void gc_boundary(struct object_array *array)
2101 unsigned nr = array->nr;
2102 unsigned alloc = array->alloc;
2103 struct object_array_entry *objects = array->objects;
2105 if (alloc <= nr) {
2106 unsigned i, j;
2107 for (i = j = 0; i < nr; i++) {
2108 if (objects[i].item->flags & SHOWN)
2109 continue;
2110 if (i != j)
2111 objects[j] = objects[i];
2112 j++;
2114 for (i = j; i < nr; i++)
2115 objects[i].item = NULL;
2116 array->nr = j;
2120 static void create_boundary_commit_list(struct rev_info *revs)
2122 unsigned i;
2123 struct commit *c;
2124 struct object_array *array = &revs->boundary_commits;
2125 struct object_array_entry *objects = array->objects;
2128 * If revs->commits is non-NULL at this point, an error occurred in
2129 * get_revision_1(). Ignore the error and continue printing the
2130 * boundary commits anyway. (This is what the code has always
2131 * done.)
2133 if (revs->commits) {
2134 free_commit_list(revs->commits);
2135 revs->commits = NULL;
2139 * Put all of the actual boundary commits from revs->boundary_commits
2140 * into revs->commits
2142 for (i = 0; i < array->nr; i++) {
2143 c = (struct commit *)(objects[i].item);
2144 if (!c)
2145 continue;
2146 if (!(c->object.flags & CHILD_SHOWN))
2147 continue;
2148 if (c->object.flags & (SHOWN | BOUNDARY))
2149 continue;
2150 c->object.flags |= BOUNDARY;
2151 commit_list_insert(c, &revs->commits);
2155 * If revs->topo_order is set, sort the boundary commits
2156 * in topological order
2158 sort_in_topological_order(&revs->commits, revs->lifo);
2161 static struct commit *get_revision_internal(struct rev_info *revs)
2163 struct commit *c = NULL;
2164 struct commit_list *l;
2166 if (revs->boundary == 2) {
2168 * All of the normal commits have already been returned,
2169 * and we are now returning boundary commits.
2170 * create_boundary_commit_list() has populated
2171 * revs->commits with the remaining commits to return.
2173 c = pop_commit(&revs->commits);
2174 if (c)
2175 c->object.flags |= SHOWN;
2176 return c;
2180 * Now pick up what they want to give us
2182 c = get_revision_1(revs);
2183 if (c) {
2184 while (0 < revs->skip_count) {
2185 revs->skip_count--;
2186 c = get_revision_1(revs);
2187 if (!c)
2188 break;
2193 * Check the max_count.
2195 switch (revs->max_count) {
2196 case -1:
2197 break;
2198 case 0:
2199 c = NULL;
2200 break;
2201 default:
2202 revs->max_count--;
2205 if (c)
2206 c->object.flags |= SHOWN;
2208 if (!revs->boundary) {
2209 return c;
2212 if (!c) {
2214 * get_revision_1() runs out the commits, and
2215 * we are done computing the boundaries.
2216 * switch to boundary commits output mode.
2218 revs->boundary = 2;
2221 * Update revs->commits to contain the list of
2222 * boundary commits.
2224 create_boundary_commit_list(revs);
2226 return get_revision_internal(revs);
2230 * boundary commits are the commits that are parents of the
2231 * ones we got from get_revision_1() but they themselves are
2232 * not returned from get_revision_1(). Before returning
2233 * 'c', we need to mark its parents that they could be boundaries.
2236 for (l = c->parents; l; l = l->next) {
2237 struct object *p;
2238 p = &(l->item->object);
2239 if (p->flags & (CHILD_SHOWN | SHOWN))
2240 continue;
2241 p->flags |= CHILD_SHOWN;
2242 gc_boundary(&revs->boundary_commits);
2243 add_object_array(p, NULL, &revs->boundary_commits);
2246 return c;
2249 struct commit *get_revision(struct rev_info *revs)
2251 struct commit *c;
2252 struct commit_list *reversed;
2254 if (revs->reverse) {
2255 reversed = NULL;
2256 while ((c = get_revision_internal(revs))) {
2257 commit_list_insert(c, &reversed);
2259 revs->commits = reversed;
2260 revs->reverse = 0;
2261 revs->reverse_output_stage = 1;
2264 if (revs->reverse_output_stage)
2265 return pop_commit(&revs->commits);
2267 c = get_revision_internal(revs);
2268 if (c && revs->graph)
2269 graph_update(revs->graph, c);
2270 return c;
2273 char *get_revision_mark(const struct rev_info *revs, const struct commit *commit)
2275 if (commit->object.flags & BOUNDARY)
2276 return "-";
2277 else if (commit->object.flags & UNINTERESTING)
2278 return "^";
2279 else if (commit->object.flags & PATCHSAME)
2280 return "=";
2281 else if (!revs || revs->left_right) {
2282 if (commit->object.flags & SYMMETRIC_LEFT)
2283 return "<";
2284 else
2285 return ">";
2286 } else if (revs->graph)
2287 return "*";
2288 else if (revs->cherry_mark)
2289 return "+";
2290 return "";
2293 void put_revision_mark(const struct rev_info *revs, const struct commit *commit)
2295 char *mark = get_revision_mark(revs, commit);
2296 if (!strlen(mark))
2297 return;
2298 fputs(mark, stdout);
2299 putchar(' ');