1 2009-09-23 Werner Koch <wk@g10code.com>
3 * command.c (register_commands) [HAVE_ASSUAN_SET_IO_MONITOR]:
5 (start_command_handler) [HAVE_ASSUAN_SET_IO_MONITOR]: Ditto.
7 2009-09-23 Marcus Brinkmann <marcus@g10code.de>
9 * gpg-agent.c (parse_rereadable_options): Don't set global assuan
10 log file (there ain't one anymore).
11 (main): Update to new API.
12 (check_own_socket_pid_cb): Return gpg_error_t instead of int.
13 (check_own_socket_thread, check_for_running_agent): Create assuan
14 context before connecting to server.
15 * command.c: Include "scdaemon.h" before <assuan.h> because of
16 GPG_ERR_SOURCE_DEFAULT check.
17 (write_and_clear_outbuf): Use gpg_error_t instead of
19 (cmd_geteventcounter, cmd_istrusted, cmd_listtrusted)
20 (cmd_marktrusted, cmd_havekey, cmd_sigkey, cmd_setkeydesc)
21 (cmd_sethash, cmd_pksign, cmd_pkdecrypt, cmd_genkey, cmd_readkey)
22 (cmd_keyinfo, cmd_get_passphrase, cmd_clear_passphrase)
23 (cmd_get_confirmation, cmd_learn, cmd_passwd)
24 (cmd_preset_passphrase, cmd_scd, cmd_getval, cmd_putval)
25 (cmd_updatestartuptty, cmd_killagent, cmd_reloadagent)
26 (cmd_getinfo, option_handler): Return gpg_error_t instead of int.
27 (post_cmd_notify): Change type of ERR to gpg_error_t from int.
28 (io_monitor): Add hook argument. Use symbols for constants.
29 (register_commands): Change return type of HANDLER to gpg_error_t.
30 (start_command_handler): Allocate assuan context before starting
32 * call-pinentry.c: Include "scdaemon.h" before <assuan.h> because
33 of GPG_ERR_SOURCE_DEFAULT check.
34 (unlock_pinentry): Call assuan_release instead of
36 (getinfo_pid_cb, getpin_cb): Return gpg_error_t instead of int.
37 (start_pinentry): Allocate assuan context before connecting to
39 * call-scd.c (membuf_data_cb, learn_status_cb, get_serialno_cb)
40 (membuf_data_cb, inq_needpin, card_getattr_cb, pass_status_thru)
41 (pass_data_thru): Change return type to gpg_error_t.
42 (start_scd): Allocate assuan context before connecting to server.
44 2009-09-04 Marcus Brinkmann <marcus@g10code.com>
46 * command.c (start_command_handler): Add comment about gap in
47 implementation (in dead code), for future reference.
49 2009-08-11 Werner Koch <wk@g10code.com>
51 * divert-scd.c (ask_for_card): I18n a prompt string.
53 2009-07-06 Werner Koch <wk@g10code.com>
55 * agent.h: Include session-env.h.
56 (opt): Replace most of the startup_xxx fields by a session_env_t.
57 (struct server_control_s): Likewise.
58 * gpg-agent.c (main): Rewrite setting of the startup fields.
59 (handle_connections, main): Allocate SESSION_ENV.
60 (agent_init_default_ctrl, agent_deinit_default_ctrl): Change
62 * command.c (option_handler): Ditto.
63 (cmd_updatestartuptty): Change accordingly. Protect old values
64 from out of core failures.
65 * command-ssh.c (start_command_handler_ssh): Ditto.
66 (start_command_handler_ssh): Replace strdup by xtrystrdup.
67 * call-pinentry.c (atfork_cb): Pass new envrinmnet variables.
68 (start_pinentry): Use session_env stuff.
69 * protect-tool.c (main): Adjust call to gnupg_prepare_get_passphrase.
71 2009-06-24 Werner Koch <wk@g10code.com>
73 * genkey.c (agent_protect_and_store): Return RC and not 0.
74 * protect.c (do_encryption): Fix ignored error code from malloc.
75 Reported by Fabian Keil.
77 2009-06-17 Werner Koch <wk@g10code.com>
79 * call-pinentry.c (agent_get_confirmation): Add arg WITH_CANCEL.
81 * trustlist.c (agent_marktrusted): Use WITH_CANCEL
83 2009-06-09 Werner Koch <wk@g10code.com>
85 * learncard.c (send_cert_back): Ignore certain error codes.
87 2009-06-05 Werner Koch <wk@g10code.com>
89 * protect-tool.c (store_private_key): Fix last change by appending
92 2009-06-03 Werner Koch <wk@g10code.com>
94 * protect-tool.c: Include estream.h.
95 (store_private_key): Replace stdio streams by estream functions
96 for a portable use of the "x" mode.
97 * trustlist.c: Include estream.h.
98 (agent_marktrusted): Replace stdio stream by estream functions.
100 * protect-tool.c (store_private_key): Use bin2hex.
102 2009-06-02 Werner Koch <wk@g10code.com>
104 * gpg-agent.c (main): Run pth_kill after fork. Fixes bug#1066.
106 2009-05-19 Werner Koch <wk@g10code.com>
108 * gpg-agent.c (JNLIB_NEED_AFLOCAL): Define.
109 (create_server_socket): Use SUN_LEN macro.
111 2009-05-15 Werner Koch <wk@g10code.com>
115 * agent.h (lookup_ttl_t): New.
116 * findkey.c (unprotect): Add arg LOOKUP_TTL.
117 (agent_key_from_file): Ditto.
118 * pksign.c (agent_pksign_do): Ditto.
119 * command-ssh.c (ttl_from_sshcontrol): New.
120 (data_sign): Pass new function to agent_pksign_do.
121 (search_control_file): Add new arg R_TTL.
123 2009-05-14 Werner Koch <wk@g10code.com>
125 * command.c (cmd_get_passphrase): Add option --qualitybar.
126 * call-pinentry.c (agent_askpin): Factor some code out to ...
127 (setup_qualitybar): .. new.
128 (agent_get_passphrase): Add arg WITH_QUALITYBAR and implement it.
130 2009-04-14 Marcus Brinkmann <marcus@g10code.de>
132 * call-pinentry.c (agent_get_confirmation): Try SETNOTOK command
135 2009-04-01 Werner Koch <wk@g10code.com>
137 * protect-tool.c (pe_opt): New.
138 (opts): Add option --agent-program. Use ARGPARSE macros.
139 (get_new_passphrase): Remove.
140 (get_passphrase): Use gpg-agent directly. Remove arg OPT_CHECK and
142 * Makefile.am (gpg_protect_tool_LDADD): Replace pwquery_libs by
144 (gpg_protect_tool_CFLAGS): New.
146 * command.c (percent_plus_unescape): Remove.
147 (cmd_putval): Use percent_plus_unescape_inplace.
148 * call-scd.c (unescape_status_string): Remove.
149 (card_getattr_cb): Use percent_plus_unescape.
150 * protect-tool.c (main): Use percent_plus_unescape from common/.
151 (percent_plus_unescape, percent_plus_unescape_string): Remove.
153 2009-03-27 Werner Koch <wk@g10code.com>
155 * learncard.c (agent_handle_learn): Add new certtype 111.
157 2009-03-26 Werner Koch <wk@g10code.com>
159 * agent.h (MAX_DIGEST_LEN): Change to 64.
160 * command.c (cmd_sethash): Allow digest length of 48 and 64.
161 (cmd_sethash): Allow more hash algos.
163 * trustlist.c (reformat_name): New.
164 (agent_marktrusted): Use a reformatted name. Reload the table
165 before the update and always reload it at the end.
166 (agent_istrusted): Check early for the disabled flag.
168 2009-03-25 Werner Koch <wk@g10code.com>
170 * pkdecrypt.c (agent_pkdecrypt): Return a specific error message
171 if the key is not available.
173 * gpg-agent.c (main): Print a started message to show the real pid.
175 2009-03-20 Werner Koch <wk@g10code.com>
177 * learncard.c (struct kpinfo_cp_parm_s): Add field CTRL.
178 (struct certinfo_cb_parm_s): Ditto.
179 (agent_handle_learn): Set CTRL field.
180 (kpinfo_cb, certinfo_cb): Send progress status.
182 * agent.h (agent_write_status): Flag with GNUPG_GCC_A_SENTINEL.
184 2009-03-19 Werner Koch <wk@g10code.com>
186 * trustlist.c (struct trustitem_s): Add field DISABLED.
187 (read_one_trustfile): Parse the '!' flag.
188 (agent_istrusted, agent_listtrusted): Check flag.
189 (agent_istrusted): Add arg R_DISABLED. Change all callers.
190 (agent_marktrusted): Do not ask if flagged as disabled. Reverse
191 the order of the questions. Store the disabled flag.
193 * gpg-agent.c (main): Save signal mask and open fds. Restore mask
194 and close all fds prior to the exec. Fixes bug#1013.
196 2009-03-17 Werner Koch <wk@g10code.com>
198 * command.c (cmd_get_passphrase): Break repeat loop on error.
200 (cmd_getinfo): Add subcommand "cmd_has_option".
201 (command_has_option): New.
203 2009-03-17 Daiki Ueno <ueno@unixuser.org>
205 * command.c (option_value): New function.
206 (cmd_get_passphrase): Accept new option --repeat, which makes
207 gpg-agent to ask passphrase several times.
209 2009-03-06 Werner Koch <wk@g10code.com>
211 * command.c (cmd_keyinfo): New command.
212 (register_commands): Register it.
213 (agent_write_status): Make sure not to print LR or CR.
214 * divert-scd.c (ask_for_card): Factor shadow info parsing out to ...
215 * protect.c (parse_shadow_info): New.
216 * findkey.c (agent_key_from_file): Use make_canon_sexp.
217 (agent_write_private_key, unprotect, read_key_file)
218 (agent_key_available): Use bin2hex.
219 (agent_key_info_from_file): New.
220 (read_key_file): Log no error message for ENOENT.
222 2009-03-05 Werner Koch <wk@g10code.com>
224 * divert-scd.c (getpin_cb): Support flag 'P'. Change max_digits
225 from 8 to 16. Append a message about keypads.
226 * findkey.c (unprotect): Change max digits to 16.
228 2009-03-02 Werner Koch <wk@g10code.com>
230 * command.c (cmd_getinfo): Add subcommand "scd_running".
232 * call-scd.c (agent_scd_check_running): New.
234 * gpg-agent.c: Add missing option strings for "--batch" and
235 "--homedir". Reported by Petr Uzel.
237 * protect-tool.c (import_p12_file): Take care of canceled
238 passphrase entry. Fixes bug#1003.
239 (export_p12_file): Ditto.
241 2008-12-17 Werner Koch <wk@g10code.com>
243 * gpg-agent.c (handle_connections): Set action of all pth event
244 handled signals to SIG_IGN. Use a different pth_sigmask strategy.
246 2008-12-10 Werner Koch <wk@g10code.com>
248 * command.c (cmd_get_passphrase): Implement option --no-ask.
250 2008-12-09 Werner Koch <wk@g10code.com>
252 * gpg-agent.c (main): Call i18n_init before init_common_subsystems.
253 * preset-passphrase.c (main): Ditto.
254 * protect-tool.c (main): Ditto.
256 * command.c (cmd_preset_passphrase): Allow an arbitrary string for
259 2008-12-08 Werner Koch <wk@g10code.com>
261 * gpg-agent.c (handle_connections): Sync the ticker to the next
262 full second. This is bug#871.
264 2008-12-05 Werner Koch <wk@g10code.com>
266 * minip12.c (decrypt_block): Fix const modified of CHARSETS.
267 * learncard.c (sinfo_cb_parm_s): Remove superflous semicolon.
268 Reported by Stoyan Angelov.
270 2008-11-18 Werner Koch <wk@g10code.com>
272 * gpg-agent.c (make_libversion): New.
273 (my_strusage): Print libgcrypt version
275 2008-11-11 Werner Koch <wk@g10code.com>
277 * call-scd.c (membuf_data_cb): Change return type to
278 assuan_error_t to avoid warnings with newer libassuan versions.
280 2008-11-04 Werner Koch <wk@g10code.com>
282 * command.c (cmd_killagent): Stop the agent immediately.
283 (start_command_handler): Take care of GPG_ERR_EOF.
285 2008-10-29 Werner Koch <wk@g10code.com>
287 * gpg-agent.c (main): Move USE_STANDARD_SOCKET to the outer scope.
288 (create_socket_name): Remove arg USE_STANDARD_SOCKET. Change all
290 (create_server_socket): Remove IS_STANDARD_NAME and replace it by
291 USE_STANDARD_SOCKET. Change all callers.
292 (check_own_socket_running): New.
293 (check_own_socket, check_own_socket_thread): New.
294 (handle_tick): Check server socket once a minute.
295 (handle_connections): Remove the extra pth_wait in the shutdown
298 2008-10-20 Werner Koch <wk@g10code.com>
300 * command.c (cmd_geteventcounter): Mark unused arg.
301 (cmd_listtrusted, cmd_pksign, cmd_pkdecrypt, cmd_genkey): Ditto.
302 (cmd_updatestartuptty, post_cmd_notify): Ditto.
303 * command-ssh.c (add_control_entry)
304 (ssh_handler_request_identities, ssh_handler_remove_identity)
305 (ssh_handler_remove_all_identities, ssh_handler_lock)
306 (ssh_handler_unlock): Ditto.
307 * call-pinentry.c (pinentry_active_p, popup_message_thread)
308 (agent_popup_message_stop): Ditto.
309 * findkey.c (agent_public_key_from_file): Ditto.
310 * genkey.c (check_passphrase_pattern): Ditto.
311 * call-scd.c (atfork_cb): Ditto.
312 * protect-tool.c (import_p12_cert_cb): Ditto.
313 * t-protect.c (main): Ditto.
315 2008-10-17 Werner Koch <wk@g10code.com>
317 * call-scd.c (start_scd) [W32]: Use snprintf again because we now
318 always use the estream variant.
320 2008-10-15 Werner Koch <wk@g10code.com>
322 * call-scd.c (start_scd): Enable assuan loggging if requested.
323 (agent_scd_check_aliveness) [W32]: Fix use of GetExitCodeProcess.
325 2008-10-14 Werner Koch <wk@g10code.com>
327 * gpg-agent.c (get_agent_scd_notify_event): Need to use a manual
330 2008-09-29 Werner Koch <wk@g10code.com>
332 * agent.h (GCRY_MD_USER): Rename to GCRY_MODULE_ID_USER.
333 (GCRY_MD_USER_TLS_MD5SHA1): Rename to MD_USER_TLS_MD5SHA1 and
336 2008-09-25 Werner Koch <wk@g10code.com>
338 * divert-scd.c (getpin_cb): Support a Reset Code style PINs..
340 2008-09-03 Werner Koch <wk@g10code.com>
342 * command.c (parse_keygrip): Use hex2bin.
343 (cmd_preset_passphrase): Decode the passphrase. Reported by Kiss
344 Gabor. Fixes #679 again.
345 * preset-passphrase.c (make_hexstring): Remove.
346 (preset_passphrase): Use bin2hex.
348 2008-05-27 Werner Koch <wk@g10code.com>
350 * trustlist.c (insert_colons): Fix stupidly wrong allocation size
353 2008-05-26 Werner Koch <wk@g10code.com>
355 * gpg-agent.c (main): Re-initialize default assuan log stream if a
358 * trustlist.c (agent_marktrusted): Use xtryasprintf and xfree.
360 * gpg-agent.c (main, agent_deinit_default_ctrl): Always use xfree
361 because our asprintf is mapped to an xmalloc style function in
362 util.h. Replace xstrdup by xtrystrdup.
363 * w32main.c (build_argv): Ditto.
364 * preset-passphrase.c (preset_passphrase): Ditto.
365 * divert-scd.c (ask_for_card): Ditto.
366 * command.c (option_handler): Ditto.
367 * command-ssh.c (ssh_handler_request_identities): Ditto.
368 * call-pinentry.c (start_pinentry): Ditto.
370 * gpg-agent.c (start_connection_thread)
371 (start_connection_thread_ssh): Use pth_thread_id for useful output
373 (pth_thread_id) [!PTH_HAVE_PTH_THREAD_ID]: New.
375 2008-03-17 Werner Koch <wk@g10code.com>
377 * agent.h (agent_inq_pinentry_launched): New prototype.
379 * call-pinentry.c: Include sys/types.h and signal.h.
381 2008-02-14 Werner Koch <wk@g10code.com>
383 * command.c (agent_inq_pinentry_launched): New.
384 (option_handler): Add option allow-pinentry-notify.
385 * call-pinentry.c (getinfo_pid_cb): New.
386 (start_pinentry): Ask for the PID and notify the client.
388 2008-01-15 Marcus Brinkmann <marcus@g10code.de>
390 * call-pinentry.c (start_pinentry): Start pinentry in detached
393 2007-12-04 Werner Koch <wk@g10code.com>
395 * call-pinentry.c (agent_askpin): Use gnupg_get_help_string.
397 2007-12-03 Werner Koch <wk@g10code.com>
399 * gpg-agent.c (main): s/standard_socket/use_standard_socket/ for
401 (create_server_socket): New arg IS_SSH to avoid testing with
404 2007-11-20 Werner Koch <wk@g10code.com>
406 * gpg-agent.c (get_agent_scd_notify_event): New.
407 (handle_signal): Factor SIGUSR2 code out to:
408 (agent_sigusr2_action): .. New.
409 (agent_sighup_action): Print info message here and not in
411 (handle_connections) [PTH_EVENT_HANDLE]: Call agent_sigusr2_action.
413 * call-scd.c (agent_scd_check_aliveness) [W32]: Implemented.
414 (start_scd) [W32]: Send event-signal option.
416 2007-11-19 Werner Koch <wk@g10code.com>
418 * call-pinentry.c (agent_askpin): Set the tooltip for the quality
421 2007-11-15 Werner Koch <wk@g10code.com>
423 * agent.h (struct server_control_s): Add XAUTHORITY and
425 * gpg-agent.c: New option --xauthority.
426 (main, agent_init_default_ctrl)
427 (agent_deinit_default_ctrl): Implemented
428 * command.c (cmd_updatestartuptty): Ditto.
429 * command-ssh.c (start_command_handler_ssh): Ditto.
430 * call-pinentry.c (atfork_cb): Set the environment.
431 (start_pinentry): Pass CTRL as arg to atfork_cb.
433 2007-11-14 Werner Koch <wk@g10code.com>
435 * call-scd.c (start_scd) [W32]: Take care of fflush peculiarities.
437 2007-11-07 Werner Koch <wk@g10code.com>
439 * agent.h: Remove errors.h.
441 2007-10-24 Werner Koch <wk@g10code.com>
443 * genkey.c (check_passphrase_constraints): Changed the wording of
444 the warning messages.
446 2007-10-19 Werner Koch <wk@g10code.com>
448 * protect-tool.c (get_passphrase): Use new utf8 switch fucntions.
450 2007-10-15 Daiki Ueno <ueno@unixuser.org> (wk)
452 * command-ssh.c (reenter_compare_cb): New function; imported from
454 (ssh_identity_register): Ask initial passphrase twice.
456 2007-10-02 Werner Koch <wk@g10code.com>
458 * command.c (cmd_getinfo): Add "pid" subcommand.
460 2007-10-01 Werner Koch <wk@g10code.com>
462 * agent.h (struct server_control_s): Remove unused CONNECTION_FD.
464 * gpg-agent.c: Remove w32-afunix.h. Include mkdtemp.h.
465 (socket_nonce, socket_nonce_ssh): New.
466 (create_server_socket): Use assuan socket wrappers. Remove W32
467 specific stuff. Save the server nonce.
469 (start_connection_thread, start_connection_thread_ssh): Call it.
470 (handle_connections): Change args to gnupg_fd_t.
471 * command.c (start_command_handler): Change LISTEN_FD to gnupg_fd_t.
472 * command-ssh.c (start_command_handler_ssh): Ditto.
474 2007-09-18 Werner Koch <wk@g10code.com>
476 * agent.h (struct pin_entry_info_s): Add element WITH_QUALITYBAR.
477 * genkey.c (check_passphrase_constraints): New arg SILENT.
479 (agent_protect_and_store, agent_genkey): Enable qualitybar.
480 * call-pinentry.c (agent_askpin): Send that option.
481 (unescape_passphrase_string): New.
483 (estimate_passphrase_quality): New.
485 2007-09-14 Marcus Brinkmann <marcus@g10code.de>
487 * call-pinentry.c (agent_popup_message_stop): Implement kill for
490 2007-08-28 Werner Koch <wk@g10code.com>
492 * gpg-agent.c (main): Add option --faked-system-time.
494 * protect-tool.c (read_and_unprotect): Print the protected-at date.
496 * agent.h (struct server_control_s): Add member IN_PASSWD.
497 * command.c (cmd_passwd): Set it.
498 * findkey.c (try_unprotect_cb): Use it.
500 * protect.c (do_encryption): Replace asprintf by xtryasprint.
501 (agent_protect): Create the protected-at item.
502 (agent_unprotect): Add optional arg PROTECTED_AT.
503 (merge_lists): Add args CUTOFF and CUTLEN.
504 (agent_unprotect): Use them.
505 * findkey.c (try_unprotect_cb): Add code to test for expired keys.
506 (unprotect): Allow changing the passphrase.
508 2007-08-27 Werner Koch <wk@g10code.com>
510 * gpg-agent.c: Add options --min-passphrase-nonalpha,
511 --check-passphrase-pattern and --enforce-passphrase-constraints.
512 (MIN_PASSPHRASE_NONALPHA): Init nonalpha option to 1.
513 (main): Declare options for gpgconf.
514 * agent.h (struct): Add members MIN_PASSPHRASE_NONALPHA,
515 ENFORCE_PASSPHRASE_CONSTRAINTS and CHECK_PASSPHRASE_PATTERN.
516 * genkey.c (nonalpha_charcount): New.
517 (check_passphrase_pattern): New.
518 (check_passphrase_constraints): Implement. Factor some code out...
519 (take_this_one_anyway, take_this_one_anyway2): .. New.
521 * call-pinentry.c (agent_show_message): New.
522 (agent_askpin): We better reset the pin buffer before asking.
524 * trustlist.c (insert_colons): New.
525 (agent_marktrusted): Pretty print the fpr.
527 2007-08-22 Werner Koch <wk@g10code.com>
529 * findkey.c (O_BINARY): Make sure it is defined.
530 (agent_write_private_key): Use O_BINARY
532 * protect-tool.c (import_p12_file): Add hack to allow importing of
533 gnupg 2.0.4 generated files.
535 2007-08-06 Werner Koch <wk@g10code.com>
537 * trustlist.c (read_one_trustfile): Add flag "cm".
538 (agent_istrusted): Ditto.
540 2007-08-02 Werner Koch <wk@g10code.com>
542 * gpg-agent.c: Include gc-opt-flags.h and remove their definition
545 2007-07-13 Werner Koch <wk@g10code.com>
547 * genkey.c (check_passphrase_constraints): Require a confirmation
548 for an empty passphrase.
549 (agent_genkey, agent_protect_and_store): No need to repeat an
552 2007-07-05 Werner Koch <wk@g10code.com>
554 * call-scd.c (struct inq_needpin_s): New.
555 (inq_needpin): Pass unknown inquiries up.
557 2007-07-04 Werner Koch <wk@g10code.com>
559 * gpg-agent.c (TIMERTICK_INTERVAL): New.
560 (fixed_gcry_pth_init, main): Kludge to fix Pth initialization.
562 2007-07-03 Werner Koch <wk@g10code.com>
564 * gpg-agent.c (handle_connections): Do not use FD_SETSIZE for
565 select but compute the correct number.
567 2007-07-02 Werner Koch <wk@g10code.com>
569 * command.c (cmd_reloadagent) [W32]: New.
570 (register_commands) [W32]: New command RELOADAGENT.
572 * Makefile.am (gpg_agent_SOURCES): Remove w32main.c and w32main.h.
573 (gpg_agent_res_ldflags): Remove icon file as we don't have a
575 * gpg-agent.c (main): do not include w32main.h. Remove all calls
577 (agent_sighup_action): New.
578 (handle_signal): Use it.
580 2007-06-26 Werner Koch <wk@g10code.com>
582 * gpg-agent.c (create_directories) [W32]: Made it work.
584 2007-06-21 Werner Koch <wk@g10code.com>
586 * agent.h (ctrl_t): Remove. It is now declared in ../common/util.h.
588 * gpg-agent.c (check_for_running_agent): New arg SILENT. Changed
590 (create_server_socket): If the standard socket is in use check
591 whether a agent is running and avoid starting another one.
593 2007-06-18 Marcus Brinkmann <marcus@g10code.de>
595 * gpg-agent.c (main): Percent escape pathname in --gpgconf-list
598 2007-06-18 Werner Koch <wk@g10code.com>
600 * w32main.c (build_argv): New.
603 * command.c (cmd_killagent) [W32]: New.
605 * gpg-agent.c (get_agent_ssh_socket_name): New.
606 (no_force_standard_socket) New.
607 (create_server_socket): Use it.
608 * Makefile.am (gpg_agent_res_ldflags): Pass windows option to ld.
610 2007-06-14 Werner Koch <wk@g10code.com>
612 * protect-tool.c (main): Setup default socket name for
614 (MAP_SPWQ_ERROR_IMPL): New. Use map_spwq_error for spqw related
616 * preset-passphrase.c (main): Setup default socket name for
618 (map_spwq_error): Remove.
619 (MAP_SPWQ_ERROR_IMPL): New.
621 * call-pinentry.c (start_pinentry): Use gnupg_module_name.
622 * call-scd.c (start_scd): Ditto.
624 2007-06-12 Werner Koch <wk@g10code.com>
628 * trustlist.c (read_one_trustfile): Replace GNUPG_SYSCONFDIR by a
630 (read_trustfiles): Ditto.
632 * gpg-agent.c (main): Replace some calls by init_common_subsystems.
633 * preset-passphrase.c (main): Ditto.
634 * protect-tool.c (main): Ditto.
636 2007-06-11 Werner Koch <wk@g10code.com>
638 * Makefile.am (common_libs): Use libcommonstd macro.
639 (commonpth_libs): Use libcommonpth macro.
641 * protect-tool.c (main) [W32]: Call pth_init.
643 * preset-passphrase.c (main) [W32]: Replace the explicit Winsocket
644 init by a call to pth_init.
646 * trustlist.c (initialize_module_trustlist): New.
647 * gpg-agent.c (main): Call it.
649 * call-pinentry.c (initialize_module_query): Rename to
650 initialize_module_call_pinentry.
652 * minip12.c: Remove iconv.h. Add utf8conf.h. Changed all iconv
653 calss to use these jnlib wrappers.
655 2007-06-06 Werner Koch <wk@g10code.com>
657 * minip12.c (enum): Rename CONTEXT to ASNCONTEXT as winnt.h
658 defines such a symbol to access the process context.
660 * call-pinentry.c (dump_mutex_state) [W32]: Handle the W32Pth case.
661 * call-scd.c (dump_mutex_state): Ditto.
663 * protect-tool.c (i18n_init): Remove.
664 * preset-passphrase.c (i18n_init): Remove.
665 * gpg-agent.c (i18n_init): Remove.
667 2007-05-19 Marcus Brinkmann <marcus@g10code.de>
669 * protect-tool.c (get_passphrase): Free ORIG_CODESET on error.
671 2007-05-14 Werner Koch <wk@g10code.com>
673 * protect.c (make_shadow_info): Replace sprintf by smklen.
675 2007-04-20 Werner Koch <wk@g10code.com>
677 * gpg-agent.c (my_gcry_logger, my_gcry_outofcore_handler): Removed.
678 (main): Call the setup_libgcrypt_logging helper.
679 * protect-tool.c (my_gcry_logger): Removed.
680 (main): Call the setup_libgcrypt_logging helper.
682 2007-04-03 Werner Koch <wk@g10code.com>
684 * trustlist.c (read_trustfiles): Take a missing trustlist as an
687 2007-03-20 Werner Koch <wk@g10code.com>
689 * protect-tool.c: New option --p12-charset.
690 * minip12.c (p12_build): Implement it.
692 2007-03-19 Werner Koch <wk@g10code.com>
694 * minip12.c: Include iconv.h.
695 (decrypt_block): New.
696 (parse_bag_encrypted_data, parse_bag_data): Use it here.
697 (bag_data_p, bag_decrypted_data_p): New helpers.
699 2007-03-06 Werner Koch <wk@g10code.com>
701 * gpg-agent.c (main) <gpgconf>: Add entries for all ttl options.
703 2007-02-20 Werner Koch <wk@g10code.com>
705 * call-pinentry.c (start_pinentry): Fix for OS X to allow loading
706 of the bundle. Tested by Benjamin Donnachie.
708 2007-02-14 Werner Koch <wk@g10code.com>
710 * gpg-agent.c: New option --pinentry-touch-file.
711 (get_agent_socket_name): New.
712 * agent.h (opt): Add pinentry_touch_file.
713 * call-pinentry.c (start_pinentry): Send new option to the
716 2007-01-31 Moritz Schulte <moritz@g10code.com> (wk)
718 * command-ssh.c (stream_read_string): Initialize LENGTH to zero.
719 (start_command_handler_ssh): Use es_fgetc/es_ungetc to check if
720 EOF has been reached before trying to process another request.
722 2007-01-31 Werner Koch <wk@g10code.com>
724 * command-ssh.c (start_command_handler_ssh):
726 * Makefile.am (t_common_ldadd): Add LIBICONV.
728 2007-01-25 Werner Koch <wk@g10code.com>
730 * genkey.c (check_passphrase_constraints): Get ngettext call right
731 and use UTF-8 aware strlen.
733 * protect-tool.c (get_passphrase): New arg OPT_CHECK.
734 (get_new_passphrase): Enable OPT_CHECK on the first call.
735 * command.c (cmd_get_passphrase): Implement option --check.
737 2007-01-24 Werner Koch <wk@g10code.com>
739 * gpg-agent.c (MIN_PASSPHRASE_LEN): New
740 (parse_rereadable_options): New option --min-passphrase-len.
741 * genkey.c (check_passphrase_constraints): New.
742 (agent_genkey, agent_protect_and_store): Call new function. Fix
745 * call-pinentry.c (agent_askpin): Allow translation of the displayed
747 (agent_popup_message_start): Remove arg CANCEL_BTN.
748 (popup_message_thread): Use --one-button option.
750 * command.c (cmd_passwd): Now that we don't distinguish between
751 assuan and regular error codes we can jump to the end on error.
753 2006-12-07 David Shaw <dshaw@jabberwocky.com>
755 * Makefile.am: Link to iconv for jnlib dependency.
757 2006-11-20 Werner Koch <wk@g10code.com>
759 * call-pinentry.c (agent_popup_message_stop): Use SIGKILL.
760 * call-scd.c (inq_needpin): Implement POPUPKEYPADPROMPT and
763 2006-11-15 Werner Koch <wk@g10code.com>
765 * protect.c (make_shadow_info): Cast printf arg to unsigned int.
766 * minip12.c (parse_bag_encrypted_data): Ditto.
767 (parse_bag_data, p12_parse): Ditto.
768 * command-ssh.c (ssh_identity_register): Changed buffer_n to
771 * agent.h (struct server_control_s): New field thread_startup.
772 * command.c (start_command_handler): Moved CTRL init code to ..
773 * gpg-agent.c (start_connection_thread): .. here.
774 (agent_deinit_default_ctrl): New.
775 (agent_init_default_ctrl): Made static.
776 (handle_connections): Allocate CTRL and pass it pth_spawn.
777 * command-ssh.c (start_command_handler_ssh): Moved CTRL init code
779 * gpg-agent.c (start_connection_thread_ssh): .. here.
781 2006-11-14 Werner Koch <wk@g10code.com>
783 * command.c (bump_key_eventcounter): New.
784 (bump_card_eventcounter): New.
785 (cmd_geteventcounter): New command.
786 * gpg-agent.c (handle_signal): Call bump_card_eventcounter.
787 * findkey.c (agent_write_private_key): Call bump_key_eventcounter.
788 * trustlist.c (agent_reload_trustlist): Ditto.
790 * command.c (post_cmd_notify, io_monitor): New.
791 (register_commands, start_command_handler): Register them.
793 2006-11-09 Werner Koch <wk@g10code.com>
795 * gpg-agent.c (main): In detached mode connect standard
796 descriptors to /dev/null.
798 * trustlist.c (read_trustfiles): Make sure not to pass a zero size
799 to realloc as the C standards says that this behaves like free.
801 2006-11-06 Werner Koch <wk@g10code.com>
803 * protect-tool.c (my_strusage): Fixed typo.
805 2006-10-23 Werner Koch <wk@g10code.com>
807 * gpg-agent.c (main): New command --gpgconf-test.
809 * minip12.c (parse_bag_encrypted_data, parse_bag_data): Allow for
812 2006-10-20 Werner Koch <wk@g10code.com>
814 * Makefile.am (t_common_ldadd): Use GPG_ERROR_LIBS instead -o just -l
816 2006-10-19 Werner Koch <wk@g10code.com>
818 * findkey.c (unprotect): Use it to avoid unnecessary calls to
820 * call-pinentry.c (pinentry_active_p): New.
822 2006-10-17 Werner Koch <wk@g10code.com>
824 * Makefile.am (gpg_agent_LDADD): Link to libcommonpth.
825 (gpg_agent_CFLAGS): New. This allows to only link this with Pth.
827 2006-10-16 Werner Koch <wk@g10code.com>
829 * call-pinentry.c (agent_get_confirmation): Map Cancel code here too.
830 * trustlist.c (agent_marktrusted): Return Cancel instead of
831 Not_Confirmed for the first question.
833 2006-10-12 Werner Koch <wk@g10code.com>
835 * protect-tool.c (get_passphrase): Fix if !HAVE_LANGINFO_CODESET.
837 2006-10-06 Werner Koch <wk@g10code.com>
839 * Makefile.am (AM_CFLAGS): Use PTH version of libassuan.
840 (gpg_agent_LDADD): Ditto.
842 * divert-scd.c (divert_pksign): Use PKAUTH for the TLS algo.
844 2006-10-05 Werner Koch <wk@g10code.com>
846 * command.c (has_option_name): New.
847 (cmd_sethash): New --hash option.
848 * pksign.c (do_encode_raw_pkcs1): New.
849 (agent_pksign_do): Use it here for the TLS algo.
850 * agent.h (GCRY_MD_USER_TLS_MD5SHA1): New.
851 * divert-scd.c (pksign): Add case for tls-md5sha1.
853 * divert-scd.c (encode_md_for_card): Check that the algo is valid.
855 2006-10-04 Werner Koch <wk@g10code.com>
857 * call-pinentry.c (agent_get_passphrase): Changed to return the
858 unencoded passphrase.
859 (agent_askpin, agent_get_passphrase, agent_get_confirmation): Need
860 to map the cancel error.
861 * command.c (send_back_passphrase): New.
862 (cmd_get_passphrase): Use it here. Also implement --data option.
865 2006-09-26 Werner Koch <wk@g10code.com>
867 * learncard.c (agent_handle_learn): Send back the keypair
870 2006-09-25 Werner Koch <wk@g10code.com>
872 * trustlist.c (read_one_trustfile): Allow extra flags.
873 (struct trustitem_s): Replaced KEYFLAGS by a FLAGS struct.
874 Changed all code to use this.
875 (agent_istrusted): New arg CTRL. Changed all callers. Send back
877 * command.c (agent_write_status): New.
879 2006-09-20 Werner Koch <wk@g10code.com>
881 * Makefile.am: Changes to allow parallel make runs.
883 2006-09-15 Werner Koch <wk@g10code.com>
885 * trustlist.c: Entirely rewritten.
886 (agent_trustlist_housekeeping): Removed and removed all calls.
888 2006-09-14 Werner Koch <wk@g10code.com>
890 Replaced all call gpg_error_from_errno(errno) by
891 gpg_error_from_syserror().
893 * call-pinentry.c (start_pinentry): Replaced pipe_connect2 by
895 * call-scd.c (start_scd): Ditto.
896 * command.c (start_command_handler): Replaced
897 init_connected_socket_server by init_socket_server_ext.
899 2006-09-13 Werner Koch <wk@g10code.com>
901 * preset-passphrase.c (main) [W32]: Check for WSAStartup error.
903 2006-09-08 Werner Koch <wk@g10code.com>
905 * call-scd.c: Add signal.h as we are referencing SIGUSR2.
907 2006-09-06 Marcus Brinkmann <marcus@g10code.de>
909 * Makefile.am (AM_CFLAGS): Add $(GPG_ERR_CFLAGS).
910 (gpg_agent_LDADD): Replace -lgpg-error with $(GPG_ERROR_LIBS).
912 2006-09-06 Werner Koch <wk@g10code.com>
914 * query.c: Renamed to ..
915 * call-pinentry.c: .. this.
917 * agent.h (out_of_core): Removed.
918 (CTRL): Removed and changed everywhere to ctrl_t.
920 Replaced all Assuan error codes by libgpg-error codes. Removed
921 all map_to_assuan_status and map_assuan_err.
923 * gpg-agent.c (main): Call assuan_set_assuan_err_source to have Assuan
924 switch to gpg-error codes.
925 * command.c (set_error): Adjusted.
927 2006-09-04 Werner Koch <wk@g10code.com>
929 * command.c (percent_plus_unescape): New.
930 (cmd_get_val, cmd_putval): New.
932 2006-08-29 Werner Koch <wk@g10code.com>
934 * command-ssh.c (stream_read_mpi): Sanity check for early
935 detecting of too large keys.
936 * gpg-agent.c (my_gcry_outofcore_handler): New.
938 (main): No allocate 32k secure memory (was 16k).
940 2006-07-31 Werner Koch <wk@g10code.com>
942 * preset-passphrase.c (make_hexstring): For consistency use
943 xtrymalloc and changed caller to use xfree. Fixed function
946 2006-07-29 Marcus Brinkmann <marcus@g10code.de>
948 * preset-passphrase.c (preset_passphrase): Do not strip off last
949 character of passphrase.
950 (make_hexstring): New function.
951 * command.c (cmd_preset_passphrase): Use parse_hexstring to syntax
952 check passphrase argument. Truncate passphrase at delimiter.
954 2006-07-24 Werner Koch <wk@g10code.com>
956 * minip12.c (build_key_bag): New args SHA1HASH and
957 KEYIDSTR. Append bag Attributes if these args are given.
958 (build_cert_sequence): ditto.
959 (p12_build): Calculate certificate hash and pass to build
962 2006-07-21 Werner Koch <wk@g10code.com>
964 * minip12.c (oid_pkcs_12_keyBag): New.
965 (parse_bag_encrypted_data): New arg R_RESULT. Support keybags and
966 return the key object.
967 (p12_parse): Take new arg into account. Free RESULT on error.
969 2006-06-26 Werner Koch <wk@g10code.com>
971 * gpg-agent.c (handle_signal): Print info for SIGUSR2 only in
974 2006-06-22 Werner Koch <wk@g10code.com>
976 * command-ssh.c (make_cstring): Use memcpy instead of strncpy.
977 (ssh_receive_mpint_list, sexp_key_extract, data_sign): Use
978 xtrycalloc instead of xtrymalloc followed by memset.
980 2006-06-20 Werner Koch <wk@g10code.com>
982 * minip12.c (create_final): New arg PW. Add code to calculate the
985 2006-06-09 Marcus Brinkmann <marcus@g10code.de>
987 * Makefile.am (gpg_agent_LDADD): Add $(NETLIBS).
988 (gpg_protect_tool_LDADD): Likewise.
989 (gpg_preset_passphrase_LDADD): Likewise.
991 2006-04-09 Moritz Schulte <moritz@g10code.com>
993 * command-ssh.c (ssh_request_process): Removed FIXME mentioning a
996 2006-04-01 Moritz Schulte <moritz@g10code.com>
998 * command-ssh.c (ssh_identity_register): Make KEY_GRIP_RAW be 20
999 instead of 21 bytes long; do not fill KEY_GRIP_RAW[20] with NUL
1000 byte - KEY_GRIP_RAW is a raw binary string anyway.
1002 2006-02-09 Werner Koch <wk@g10code.com>
1004 * call-scd.c (struct scd_local_s): New field next_local.
1005 (scd_local_list): New.
1006 (start_scd): Put new local into list.
1007 (agent_reset_scd): Remove it from the list.
1008 (agent_scd_check_aliveness): Here is the actual reason why we need
1010 (agent_reset_scd): Send the new command RESTART instead of RESET.
1012 2005-12-16 Werner Koch <wk@g10code.com>
1014 * minip12.c (cram_octet_string): New
1015 (p12_parse): Use it for NDEFed bags.
1016 (parse_bag_data): Ditto.
1017 (string_to_key, set_key_iv, crypt_block): New arg SALTLEN.
1018 (p12_build): Use old value 8 for new arg.
1019 (parse_bag_encrypted_data, parse_bag_data): Allow for salts of 8
1020 to 16 bytes. Add new arg R_CONSUMED.
1022 2005-11-24 Werner Koch <wk@g10code.com>
1024 * minip12.c (p12_parse): Fixed for case that the key object comes
1025 prior to the certificate.
1027 2005-10-19 Werner Koch <wk@g10code.com>
1029 * divert-scd.c (getpin_cb): Hack to use it for a keypad message.
1031 * call-scd.c (inq_needpin): Reworked to support the new KEYPADINFO.
1033 * query.c (start_pinentry): Keep track of the owner.
1034 (popup_message_thread, agent_popup_message_start)
1035 (agent_popup_message_stop, agent_reset_query): New.
1036 * command.c (start_command_handler): Make sure a popup window gets
1039 2005-10-08 Marcus Brinkmann <marcus@g10code.de>
1041 * Makefile.am (gpg_protect_tool_LDADD): Add ../gl/libgnu.a.
1042 (gpg_preset_passphrase_LDADD, t_common_ldadd): Likewise.
1043 (gpg_agent_LDADD): Add ../gl/libgnu.a after ../common/libcommon.a.
1045 2005-09-16 Werner Koch <wk@g10code.com>
1047 * minip12.c (build_key_sequence, build_cert_sequence): Fixed
1050 2005-09-15 Moritz Schulte <moritz@g10code.com>
1052 * t-protect.c (test_agent_protect): Implemented.
1053 (main): Disable use of secure memory.
1055 2005-09-09 Werner Koch <wk@g10code.com>
1057 * minip12.c (p12_build): Oops, array needs to be larger for the
1059 (build_cert_bag): Fixed yesterdays change.
1061 * command-ssh.c (card_key_available): Let the card handler decide
1062 whether the card is supported here. Also get a short serial
1063 number to return from the card handler.
1065 2005-09-08 Werner Koch <wk@g10code.com>
1067 * minip12.c (build_cert_bag): Use a non constructed object.
1068 i.e. 0x80 and not 0xa0.
1070 2005-08-16 Werner Koch <wk@g10code.com>
1072 * gpg-agent.c (main): Use a default file name for --write-env-file.
1074 2005-07-25 Werner Koch <wk@g10code.com>
1076 * findkey.c (agent_public_key_from_file): Fixed array assignment.
1077 This was the cause for random segvs.
1079 2005-06-29 Werner Koch <wk@g10code.com>
1081 * command-ssh.c (data_sign): Removed empty statement.
1083 2005-06-21 Werner Koch <wk@g10code.com>
1085 * minip12.c (create_final): Cast size_t to ulong for printf.
1086 (build_key_bag, build_cert_bag, build_cert_sequence): Ditto.
1088 2005-06-16 Werner Koch <wk@g10code.com>
1090 * protect-tool.c (make_advanced): Makde RESULT a plain char.
1091 * call-scd.c (unescape_status_string): Need to cast unsigned char*
1093 (agent_card_pksign): Made arg R_BUF an unsigned char**.
1094 * divert-scd.c (divert_pksign): Made SIGVAL unsigned char*.
1095 (encode_md_for_card): Initialize R_VAL and R_LEN.
1096 * genkey.c (store_key): Made BUF unsigned.
1097 * protect.c (do_encryption): Ditto.
1098 (do_encryption): Made arg PROTBEGIN unsigned. Initialize RESULT
1099 and RESULTLEN even on error.
1100 (merge_lists): Need to cast unsigned char * for strcpy. Initialize
1101 RESULTand RESULTLEN even on error.
1102 (agent_unprotect): Likewise for strtoul.
1103 (make_shadow_info): Made P and INFO plain char.
1104 (agent_shadow_key): Made P plain char.
1106 2005-06-15 Werner Koch <wk@g10code.com>
1108 * query.c (agent_get_passphrase): Made HEXSTRING a char*.
1109 * command-ssh.c (ssh_key_grip): Made arg BUFFER unsigned.
1110 (ssh_key_grip): Simplified.
1111 (data_sign): Initialize variables with the definition.
1112 (ssh_convert_key_to_blob): Make sure that BLOB and BLOB_SIZE
1113 are set to NULL on error. Cool, gcc-4 detects uninitialized stuff
1114 beyond function boundaries; well it can't know that we do error
1115 proper error handling so that this was not a real error.
1116 (file_to_buffer): Likewise for BUFFER and BUFFER_N.
1117 (data_sign): Likewise for SIG and SIG_N.
1118 (stream_read_byte): Set B to a value even on error.
1119 * command.c (cmd_genkey): Changed VALUE to char.
1120 (cmd_readkey): Cast arg for gcry_sexp_sprint.
1121 * agent.h (struct server_control_s): Made KEYGRIP unsigned.
1123 2005-06-13 Werner Koch <wk@g10code.com>
1125 * command-ssh.c (start_command_handler_ssh): Reset the SCD.
1127 2005-06-09 Werner Koch <wk@g10code.com>
1129 * gpg-agent.c (create_socket_name): New option --max-cache-ttl-ssh.
1130 * cache.c (housekeeping): Use it.
1131 (agent_put_cache): Use a switch to get the default ttl so that it
1132 is easier to add more cases.
1134 2005-06-06 Werner Koch <wk@g10code.com>
1136 * gpg-agent.c: New option --default-cache-ttl-ssh.
1137 * agent.h (cache_mode_t): New.
1138 * pksign.c (agent_pksign_do): New arg CACHE_MODE to replace the
1139 ARG IGNORE_CACHE. Changed all callers.
1140 (agent_pksign): Ditto.
1141 * findkey.c (agent_key_from_file): Ditto. Canged all callers.
1143 * command-ssh.c (data_sign): Use CACHE_MODE_SSH.
1144 * cache.c (agent_get_cache): New arg CACHE_MODE.
1145 (agent_put_cache): Ditto. Store it in the cache.
1147 * query.c (agent_query_dump_state, dump_mutex_state): New.
1148 (unlock_pinentry): Reset the global context before releasing the
1150 * gpg-agent.c (handle_signal): Dump query.c info on SIGUSR1.
1152 * call-scd.c (agent_scd_check_aliveness): Always do a waitpid and
1153 add a timeout to the locking.
1155 2005-06-03 Werner Koch <wk@g10code.com>
1157 * command.c (cmd_updatestartuptty): New.
1159 * gpg-agent.c: New option --write-env-file.
1161 * gpg-agent.c (handle_connections): Make sure that the signals we
1162 are handling are not blocked.Block signals while creating new
1165 2005-06-02 Werner Koch <wk@g10code.com>
1167 * call-scd.c (agent_scd_dump_state, dump_mutex_state): New.
1168 * gpg-agent.c (handle_signal): Print it on SIGUSR1.
1169 (handle_connections): Include the file descriptor into the
1172 2005-06-01 Werner Koch <wk@g10code.com>
1174 * gpg-agent.c: Include setenv.h.
1176 2005-05-31 Werner Koch <wk@g10code.com>
1178 * agent.h (out_of_core): s/__inline__/inine. Noted by Ray Link.
1180 2005-05-25 Werner Koch <wk@g10code.com>
1182 * gpg-agent.c (main): Do not unset the DISPLAY when we are
1183 continuing as child.
1185 2005-05-24 Werner Koch <wk@g10code.com>
1187 * call-scd.c (inq_needpin): Skip leading spaces in of PIN
1189 * divert-scd.c (getpin_cb): Enhanced to cope with description
1191 * query.c (agent_askpin): Add arg PROMPT_TEXT. Changed all
1194 2005-05-21 Werner Koch <wk@g10code.com>
1196 * call-scd.c (start_scd): Don't test for an alive scdaemon here.
1197 (agent_scd_check_aliveness): New.
1198 * gpg-agent.c (handle_tick): Test for an alive scdaemon.
1199 (handle_signal): Print thread info on SIGUSR1.
1201 2005-05-20 Werner Koch <wk@g10code.com>
1203 * protect-tool.c: New option --canonical.
1204 (show_file): Implement it.
1206 * keyformat.txt: Define the created-at attribute for keys.
1208 2005-05-18 Werner Koch <wk@g10code.com>
1210 * divert-scd.c (ask_for_card): Removed the card reset kludge.
1212 2005-05-17 Werner Koch <wk@g10code.com>
1214 * call-scd.c (unlock_scd): Add new arg CTRL. Changed all callers.
1215 (start_scd): Reoworked to allow for additional connections.
1216 * agent.h (ctrl_t): Add local data for the SCdaemon.
1217 * command.c (start_command_handler): Release SERVER_LOCAL.
1219 * gpg-agent.c (create_server_socket): Use xmalloc.
1220 (main): Removed option --disable-pth a dummy. Removed non-pth
1222 (cleanup_sh): Removed. Not needed anymore.
1224 2005-05-05 Moritz Schulte <moritz@g10code.com>
1226 * command-ssh.c (ssh_key_to_buffer): Rename to ...
1227 (ssh_key_to_protected_buffer): ... this; change callers.
1228 Improved documentation.
1229 Use ssh_key_grip(), where gcry_pk_get_keygrip() has been used
1231 (ssh_handler_sign_request): Removed unusued variable P.
1233 2005-04-20 Moritz Schulte <moritz@g10code.com>
1235 * command-ssh.c (ssh_handler_request_identities): Removed
1236 debugging code (sleep call), which was commited unintenionally.
1238 2005-04-20 Werner Koch <wk@g10code.com>
1240 * minip12.c (parse_bag_encrypted_data): Fix the unpadding hack.
1242 * gpg-agent.c: New option --disable-scdaemon.
1243 (handle_connections): Add time event to drive ...
1244 (handle_tick): New function.
1245 (main): Record the parent PID. Fixed segv when using ssh and a
1248 * call-scd.c (start_scd): Take care of this option.
1250 2005-04-03 Moritz Schulte <moritz@g10code.com>
1252 * command-ssh.c (ssh_request_spec): New member: secret_input.
1253 (REQUEST_SPEC_DEFINE): New argument: secret_input.
1254 (request_specs): Add secret_input flag.
1255 (request_spec_lookup): New function ...
1256 (ssh_request_process): ... use it here; depending on secret_input
1257 flag allocate secure or non-secure memory.
1259 2005-03-02 Moritz Schulte <moritz@g10code.com>
1261 * command-ssh.c (sexp_key_extract): Removed FIXME, since
1262 xtrymallos does set errno correctly by now.
1263 (sexp_extract_identifier): Remove const attribute from identifier.
1264 (ssh_handler_request_identities): Remove const attribute from
1265 key_type; removes ugly casts and FIXME.
1266 (sexp_key_extract): Remove const attribute from comment.
1267 (ssh_send_key_public): Remove const attribute from
1268 key_type/comment; removes ugly cast.
1269 (data_sign): Remove const attribute from identifier; removes ugly
1271 (key_secret_to_public): Remove const attribute from comment;
1273 (ssh_handler_sign_request): Remove const attribute from p.
1274 (sexp_key_extract): Use make_cstring().
1275 (ssh_key_extract_comment): Likewise.
1276 (ssh_key_to_buffer): Use secure memory for memory area to hold the
1278 Added more comments.
1280 2005-02-25 Werner Koch <wk@g10code.com>
1282 * findkey.c (modify_description): Keep invalid % escapes, so that
1283 %0A may pass through.
1285 * agent.h (server_control_s): New field USE_AUTH_CALL.
1286 * call-scd.c (agent_card_pksign): Make use of it.
1287 * command-ssh.c (data_sign): Set the flag.
1288 (ssh_send_key_public): New arg OVERRIDE_COMMENT.
1289 (card_key_available): Add new arg CARDSN.
1290 (ssh_handler_request_identities): Use the card s/n as comment.
1291 (sexp_key_extract): Use GCRYMPI_FMT_STD.
1294 * learncard.c (make_shadow_info): Moved to ..
1295 * protect.c (make_shadow_info): .. here. Return NULL on malloc
1296 failure. Made global.
1297 * agent.h: Add prototype.
1299 2005-02-24 Werner Koch <wk@g10code.com>
1301 * call-scd.c (unescape_status_string): New. Actual a copy of
1303 (card_getattr_cb, agent_card_getattr): New.
1305 * command-ssh.c (card_key_available): New.
1306 (ssh_handler_request_identities): First see whether a card key is
1309 * gpg-agent.c (handle_connections): Need to check for events if
1310 select returns with -1.
1312 2005-02-23 Werner Koch <wk@g10code.com>
1314 * command-ssh.c (get_passphrase): Removed.
1315 (ssh_identity_register): Partly rewritten.
1316 (open_control_file, search_control_file, add_control_entry): New.
1317 (ssh_handler_request_identities): Return only files listed in our
1320 * findkey.c (unprotect): Check for allocation error.
1322 * agent.h (opt): Add fields to record the startup terminal
1324 * gpg-agent.c (main): Record them and do not force keep display
1325 with --enable-ssh-support.
1326 * command-ssh.c (start_command_handler_ssh): Use them here.
1328 * gpg-agent.c: Renamed option --ssh-support to
1329 --enable-ssh-support.
1331 * command.c (cmd_readkey): New.
1332 (register_commands): Register new command "READKEY".
1334 * command-ssh.c (ssh_request_process): Improved logging.
1336 * findkey.c (agent_write_private_key): Always use plain open.
1337 Don't depend on an umask for permissions.
1338 (agent_key_from_file): Factored file reading code out to ..
1339 (read_key_file): .. new function.
1340 (agent_public_key_from_file): New.
1342 2005-02-22 Werner Koch <wk@g10code.com>
1344 * command-ssh.c (stream_read_string): Removed call to abort on
1345 memory error because the CVS version of libgcrypt makes sure
1346 that ERRNO gets always set on error even with a faulty user
1349 2005-02-19 Moritz Schulte <moritz@g10code.com>
1351 * command-ssh.c (ssh_receive_mpint_list): Slightly rewritten, do
1352 not use elems_secret member of key_spec.
1353 (ssh_key_type_spec): Removed member: elems_secret.
1354 (ssh_key_types): Removed elems_secret data.
1355 (ssh_sexp_construct): Renamed to ...
1356 (sexp_key_construct): ... this; changed callers.
1357 (ssh_sexp_extract): Renamed to ...
1358 (sexp_key_extract): ... this; changed callers.
1359 (ssh_sexp_extract_key_type): Renamed to ...
1360 (sexp_extract_identifier): ... this; changed callers; use
1362 Added more comments.
1364 2005-02-18 Moritz Schulte <moritz@g10code.com>
1366 * command-ssh.c (ssh_sexp_construct): Rewritten generation of sexp
1367 template, clarified.
1368 (ssh_sexp_extract): Support shadowed-private-key-sexp; treat
1369 protected-private key and shadowed-private-key as public keys.
1370 (key_secret_to_public): Rewritten: simply use ssh_sexp_extract()
1371 and ssh_sexp_construct().
1373 2005-02-15 Werner Koch <wk@g10code.com>
1375 * findkey.c (modify_description): Don't increment OUT_LEN during
1378 2005-02-14 Moritz Schulte <moritz@g10code.com>
1380 * command-ssh.c (es_read_byte): Renamed to ...
1381 (stream_es_read_byte): ... this; changed callers.
1382 (es_write_byte): Renamed to ...
1383 (stream_write_byte): ... this; changed callers.
1384 (es_read_uint32): Renamed to ...
1385 (stream_read_uint32): ... this; changed callers.
1386 (es_write_uint32): Renamed to ...
1387 (stream_write_uint32): ... this; changed callers.
1388 (es_read_data): Renamed to ...
1389 (stream_read_data): ... this; changed callers.
1390 (es_write_data): Renamed to ...
1391 (stream_write_data): ... this; changed callers.
1392 (es_read_string): Renamed to ...
1393 (stream_read_string): ... this; changed callers.
1394 (es_read_cstring): Renamed to ...
1395 (stream_read_cstring): ... this; changed callers.
1396 (es_write_string): Renamed to ...
1397 (stream_write_string): ... this; changed callers.
1398 (es_write_cstring): Renamed to ...
1399 (stream_write_cstring): ... this; changed callers.
1400 (es_read_mpi): Renamed to ...
1401 (stream_read_mpi): ... this; changed callers.
1402 (es_write_mpi): Renamed to ...
1403 (stream_write_mpi): ... this; changed callers.
1404 (es_copy): Renamed to ...
1405 (stream_copy): ... this; changed callers.
1406 (es_read_file): Renamed to ...
1407 (file_to_buffer): ... this; changed callers.
1408 (ssh_identity_register): Removed variable description_length;
1409 changed code to use asprintf for description.
1410 (stream_write_uint32): Do not filter out the last byte of shift
1412 (uint32_construct): New macro ...
1413 (stream_read_uint32): ... use it; removed unnecessary cast.
1415 2005-02-03 Werner Koch <wk@g10code.com>
1417 * agent.h (agent_exit): Add JNLIB_GCC_A_NR to indicate that this
1418 function won't return.
1420 * gpg-agent.c (check_for_running_agent): Initialize pid to a
1421 default value if not needed.
1423 * command-ssh.c: Removed stdint.h. s/byte_t/unsigned char/,
1424 s/uint32/u32/ becuase that is what we have always used in GnuPG.
1425 (ssh_request_specs): Moved to top of file.
1426 (ssh_key_types): Ditto.
1427 (make_cstring): Ditto.
1428 (data_sign): Don't use a variable for the passphrase prompt, make
1430 (ssh_request_process):
1433 * findkey.c (modify_description): Renamed arguments for clarity,
1434 polished documentation. Make comment a C-string. Fixed case of
1435 DESCRIPTION being just "%".
1436 (agent_key_from_file): Make sure comment string to a C-string.
1438 * gpg-agent.c (create_socket_name): Cleanup the implemntation, use
1439 DIMof, agent_exit, removed superflous args and return the
1440 allocated string as value. Documented. Changed callers.
1441 (create_server_socket): Cleanups similar to above. Changed callers.
1442 (cleanup_do): Renamed to ..
1443 (remove_socket): .. this. Changed caller.
1444 (handle_connections): The signals are to be handled in the select
1445 and not in the accept. Test all FDs after returning from a
1446 select. Remove the event tests from the accept calls. The select
1447 already assured that the accept won't block.
1449 2005-01-29 Moritz Schulte <moritz@g10code.com>
1451 * command-ssh.c (ssh_handler_request_identities)
1452 (ssh_handler_sign_request, ssh_handler_add_identity)
1453 (ssh_handler_remove_identity, ssh_handler_remove_all_identities)
1454 (ssh_handler_lock, ssh_handler_unlock): Changed to return an error
1455 code instead of a boolean.
1456 (ssh_request_process): Changed to return a boolean instead of an
1457 error; adjust caller.
1458 (ssh_request_handle_t): Adjusted type.
1459 (ssh_request_spec): New member: identifier.
1460 (REQUEST_SPEC_DEFINE): New macro; use it for initialization of
1462 (ssh_request_process): In debugging mode, log identifier of
1464 (start_command_handler_ssh): Moved most of the stream handling
1466 (ssh_request_process): ... here.
1468 2005-01-28 Moritz Schulte <moritz@g10code.com>
1470 * command-ssh.c (ssh_handler_add_identity): Pass ctrl to
1471 ssh_identity_register().
1472 (ssh_identity_register): New argument: ctrl; pass ctrl to
1474 (get_passphrase): Pass ctrl instead of NULL to agent_askpin().
1475 (start_command_handler_ssh): Use agent_init_default_ctrl();
1476 deallocate structure members, which might be dynamically
1478 (lifetime_default): Removed variable.
1479 (ssh_handler_add_identity): Fix ttl handling; renamed variable
1481 (ssh_identity_register): Fix key grip handling.
1483 2005-01-26 Moritz Schulte <moritz@g10code.com>
1485 * command-ssh.c (ssh_handler_sign_request): Confirm to agent
1486 protocol in case of failure.
1488 * command-ssh.c: New file.
1490 * Makefile.am (gpg_agent_SOURCES): New source file: command-ssh.c.
1492 * findkey.c (modify_description): New function.
1493 (agent_key_from_file): Support comment field in key s-expressions.
1495 * gpg-agent.c (enum cmd_and_opt_values): New item: oSSHSupport.
1496 (opts) New entry for oSSHSupport.
1497 New variable: socket_name_ssh.
1498 (cleanup_do): New function based on cleanup().
1499 (cleanup): Use cleanup_do() for socket_name and socket_name_ssh.
1500 (main): New switch case for oSSHSupport.
1501 (main): Move socket name creation code to ...
1502 (create_socket_name): ... this new function.
1503 (main): Use create_socket_name() for creating socket names for
1504 socket_name and for socket_name_ssh in case ssh support is
1506 Move socket creation code to ...
1507 (create_server_socket): ... this new function.
1508 (main): Use create_server_socket() for creating sockets.
1509 In case standard_socket is set, do not only store a socket name in
1510 socket_name, but also in socket_name_ssh.
1511 Generate additional environment info strings for ssh support.
1512 Pass additional ssh socket argument to handle_connections.
1513 (start_connection_thread_ssh): New function.
1514 (handle_connections): Use select to multiplex between gpg-agent
1515 and ssh-agent protocol.
1517 * agent.h (struct opt): New member: ssh_support.
1518 (start_command_handler_ssh): Add prototype.
1520 2005-01-04 Werner Koch <wk@g10code.com>
1522 * trustlist.c (agent_marktrusted): Use "Cancel" for the first
1523 confirmation and made the strings translatable.
1525 * cache.c (agent_put_cache): Fix the test for using the default
1528 2004-12-21 Werner Koch <wk@g10code.com>
1530 * preset-passphrase.c (preset_passphrase): Handle --passphrase.
1532 * Makefile.am (gpg_preset_passphrase_LDADD): Reorder libs so that
1533 pwquery may use stuff from jnlib. Conditionally add -lwsock2
1534 (gpg_protect_tool_LDADD): Ditto.
1536 * preset-passphrase.c (main): Use default_homedir().
1537 (main) [W32]: Initialize sockets.
1539 2004-12-21 Marcus Brinkmann <marcus@g10code.de>
1541 * Makefile.am (libexec_PROGRAMS): Add gpg-preset-passphrase.
1542 (gpg_preset_passphrase_SOURCES, gpg_preset_passphrase_LDADD): New
1544 * agent.h (opt): New member allow_cache_passphrase.
1545 * cache.c (housekeeping): Check if R->ttl is not negative.
1546 (agent_put_cache): Allow ttl to be negative.
1547 * command.c (parse_hexstring): Allow something to follow the
1549 (cmd_cache_passphrase): New function.
1550 (register_commands): Add it.
1551 * gpg-agent.c: Handle --allow-preset-passphrase.
1552 * preset-passphrase.c: New file.
1554 2004-12-21 Werner Koch <wk@g10code.com>
1556 * gpg-agent.c (main): Use default_homedir().
1557 * protect-tool.c (main): Ditto.
1559 2004-12-20 Werner Koch <wk@g10code.com>
1561 * gpg-agent.c (main) [W32]: Now that Mutexes work we can remove
1562 the pth_init kludge.
1563 (main): Add new options --[no-]use-standard-socket.
1564 (check_for_running_agent): Check whether it is running on the
1567 * call-scd.c (init_membuf, put_membuf, get_membuf): Removed. We
1568 now use the identical implementation from ../common/membuf.c.
1570 * pksign.c (agent_pksign): Changed arg OUTFP to OUTBUF and use
1571 membuf functions to return the value.
1572 * pkdecrypt.c (agent_pkdecrypt): Ditto.
1573 * genkey.c (agent_genkey): Ditto.
1574 * command.c (cmd_pksign, cmd_pkdecrypt, cmd_genkey): Replaced
1575 assuan_get_data_fp() by a the membuf scheme.
1576 (clear_outbuf, write_and_clear_outbuf): New.
1578 2004-12-19 Werner Koch <wk@g10code.com>
1580 * query.c (initialize_module_query): New.
1581 * call-scd.c (initialize_module_call_scd): New.
1582 * gpg-agent.c (main): Call them.
1584 2004-12-18 Werner Koch <wk@g10code.com>
1586 * gpg-agent.c (main): Remove special Pth initialize.
1588 * agent.h (map_assuan_err): Define in terms of
1589 map_assuan_err_with_source.
1591 2004-12-17 Moritz Schulte <moritz@g10code.com>
1593 * query.c: Undo change from 2004-12-05.
1595 2004-12-15 Werner Koch <wk@g10code.com>
1597 * gpg-agent.c [W32]: Various hacks to make it work.
1599 * findkey.c (agent_write_private_key) [W32]: Adjust open call.
1601 * call-scd.c (start_scd) [W32]: Don't check whether the daemon
1602 didn't died. To hard to do under Windows.
1603 (start_scd) [W32]: Disable sending of the event signal option.
1605 * protect-tool.c (read_file, export_p12_file) [W32]: Use setmode
1606 to get stdout and stin into binary mode.
1608 2004-12-05 Moritz Schulte <moritz@g10code.com>
1610 * query.c (start_pinentry): Allow CTRL be NULL.
1612 2004-10-22 Werner Koch <wk@g10code.com>
1614 * gpg-agent.c (parse_rereadable_options): Return "not handled"
1615 when the log file has not beend hadled. This is will let the main
1616 option processing continue. Fixed a bug introduced on 2004-09-4
1617 resulting in logging to stderr until a HUP has been given.
1618 (main): Don't close the listen FD.
1620 2004-09-30 Werner Koch <wk@g10code.com>
1622 * Makefile.am: Adjusted from gettext 1.14.
1624 2004-09-29 Werner Koch <wk@g10code.com>
1626 * minip12.c (parse_bag_encrypted_data): Print error if a bad
1627 passphrase has been given.
1629 2004-09-28 Werner Koch <wk@g10code.com>
1631 * protect.c (agent_unprotect): Fixed wiping of CLEARTEXT. Thanks
1632 to Moritz for pointing this out.
1634 2004-09-25 Moritz Schulte <moritz@g10code.com>
1636 * agent.h: Declare: agent_pksign_do.
1637 (struct server_control_s): New member: raw_value.
1639 * pksign.c (do_encode_md): New argument: raw_value; support
1640 generation of raw (non-pkcs1) data objects; adjust callers.
1641 (agent_pksign_do): New function, based on code ripped
1642 out from agent_pksign.
1643 (agent_pksign): Use agent_pksign_do.
1645 * command.c (start_command_handler): Set ctrl.digest.raw_value.
1647 2004-09-09 Werner Koch <wk@g10code.de>
1649 * gpg-agent.c (check_for_running_agent): New.
1650 (main): The default action is now to check for an already running
1652 (parse_rereadable_options): Set logfile only on reread.
1653 (main): Do not print the "is development version" note.
1655 2004-08-20 Werner Koch <wk@g10code.de>
1657 * gpg-agent.c: New option --max-cache-ttl. Suggested by Alexander
1659 * cache.c (housekeeping): Use it here instead of the hardwired
1662 * query.c (start_pinentry): Use a timeout for the pinentry lock.
1664 2004-08-18 Werner Koch <wk@g10code.de>
1666 * protect-tool.c (get_passphrase): Make sure that the default
1667 prompts passed to gpg-agent are utf-8 encoded. Add new prompt values.
1668 (import_p12_file, import_p12_file, export_p12_file): Changed calls
1669 to get_passphrase so that better prompts are displayed.
1670 (get_new_passphrase): New.
1672 2004-07-22 Werner Koch <wk@g10code.de>
1674 * trustlist.c (read_list): Allow colons in the fingerprint.
1675 (headerblurb): Rephrased.
1677 * gpg-agent.c (handle_connections): Increase the stack size ot 256k.
1679 2004-06-20 Moritz Schulte <moritz@g10code.com>
1681 * gpg-agent.c: Include <sys/stat.h> (build fix for BSD).
1683 2004-05-11 Werner Koch <wk@gnupg.org>
1685 * gpg-agent.c (handle_signal): Reload the trustlist on SIGHUP.
1686 (start_connection_thread): Hack to simulate a ticker.
1687 * trustlist.c (agent_trustlist_housekeeping)
1688 (agent_reload_trustlist): New. Protected all global functions
1689 here with a simple counter which is sufficient for Pth.
1691 2004-05-03 Werner Koch <wk@gnupg.org>
1693 * gpg-agent.c: Remove help texts for options lile --lc-ctype.
1694 (main): New option --allow-mark-trusted.
1695 * trustlist.c (agent_marktrusted): Use it here.
1697 2004-04-30 Werner Koch <wk@gnupg.org>
1699 * protect-tool.c: New option --enable-status-msg.
1700 (store_private_key): Print status messages for imported keys.
1701 (read_and_unprotect): Ditto for bad passphrase.
1703 * gpg-agent.c (parse_rereadable_options): New arg REREAD. Allow
1705 (current_logfile): New.
1707 2004-04-26 Werner Koch <wk@gnupg.org>
1709 * call-scd.c (start_scd): Do not register an event signal if we
1710 are running as a pipe server.
1712 2004-04-21 Werner Koch <wk@gnupg.org>
1714 * call-scd.c (start_scd): Send event-signal option. Always check
1715 that the scdaemon is still running.
1717 * gpg-agent.c (handle_signal): Do not use SIGUSR{1,2} anymore for
1718 changing the verbosity.
1720 2004-04-16 Werner Koch <wk@gnupg.org>
1722 * gpg-agent.c (main): Tell the logging code that we are running
1725 2004-04-06 Werner Koch <wk@gnupg.org>
1727 * gpg-agent.c (main): Use new libgcrypt thread library register
1730 2004-03-23 Marcus Brinkmann <marcus@g10code.de>
1732 * gpg-agent.c (main): For now, always print the default config
1733 file name for --gpgconf-list.
1735 2004-03-17 Werner Koch <wk@gnupg.org>
1737 * gpg-agent.c (main) <gpgconf>: Fixed default value quoting.
1739 2004-03-16 Werner Koch <wk@gnupg.org>
1741 * gpg-agent.c (parse_rereadable_options): Use the new
1742 DEFAULT_CACHE_TTL macro.
1743 (main): Updated --gpgconf-list output.
1745 2004-02-21 Werner Koch <wk@gnupg.org>
1747 * command.c (cmd_passwd): Take acount of a key description.
1749 * genkey.c (reenter_compare_cb): Do not set the error text.
1750 (agent_protect_and_store, agent_genkey): Force a re-enter after a
1751 non-matching passphrase.
1752 * query.c (agent_askpin): Add new arg INITIAL_ERRTEXT; changed
1755 2004-02-19 Werner Koch <wk@gnupg.org>
1757 * protect-tool.c: New options --have-cert and --prompt.
1758 (export_p12_file): Read a certificate from STDIN and pass it to
1759 p12_build. Detect a keygrip and construct the filename in that
1760 case. Unprotcet a key if needed. Print error messages for key
1761 formats we can't handle.
1762 (release_passphrase): New.
1763 (get_passphrase): New arg PROMPTNO. Return the allocated
1764 string. Changed all callers.
1766 * minip12.c: Revamped the build part.
1767 (p12_build): New args CERT and CERTLEN.
1769 2004-02-18 Werner Koch <wk@gnupg.org>
1771 * protect-tool.c (main): Setup the used character set.
1772 * gpg-agent.c (main): Ditto.
1774 * gpg-agent.c (set_debug): New. New option --debug-level.
1775 (main): New option --gpgconf-list.
1777 2004-02-17 Werner Koch <wk@gnupg.org>
1779 * pksign.c (do_encode_md): Cleaned up by using gcry_sexp_build.
1781 * Makefile.am (gpg_protect_tool_SOURCES): Removed
1782 simple-pwquery.[ch], as we once moved it to ../common.
1784 2004-02-13 Werner Koch <wk@gnupg.org>
1786 * command.c (cmd_setkeydesc): New.
1787 (register_commands): Add command SETKEYDESC.
1788 (cmd_pksign, cmd_pkdecrypt): Use the key description.
1789 (reset_notify): Reset the description.
1790 * findkey.c (unprotect): Add arg DESC_TEXT.
1791 (agent_key_from_file): Ditto.
1792 * pksign.c (agent_pksign): Ditto.
1793 * pkdecrypt.c (agent_pkdecrypt): Ditto. Made CIPHERTEXT an
1796 * protect-tool.c (main): New options --no-fail-on-exist, --homedir.
1797 (store_private_key): Use them here.
1799 2004-02-12 Werner Koch <wk@gnupg.org>
1801 * protect-tool.c (read_file, main): Allow reading from stdin.
1803 * Makefile.am: Include cmacros.am for common flags.
1804 (libexec_PROGRAMS): Put gpg-protect-tool there.
1806 2004-02-10 Werner Koch <wk@gnupg.org>
1808 * minip12.c (parse_bag_encrypted_data): Finished implementation.
1809 (p12_parse): Add callback args.
1810 * protect-tool.c (import_p12_cert_cb): New.
1811 (import_p12_file): Use it.
1813 2004-02-06 Werner Koch <wk@gnupg.org>
1815 * minip12.c (crypt_block): Add arg CIPHER_ALGO; changed all callers.
1816 (set_key_iv): Add arg KEYBYTES; changed caller.
1818 2004-02-03 Werner Koch <wk@gnupg.org>
1820 * findkey.c (agent_key_from_file): Extra paranoid wipe.
1821 * protect.c (agent_unprotect): Ditto.
1822 (merge_lists): Ditto. Add arg RESULTLEN.
1823 * pkdecrypt.c (agent_pkdecrypt): Don't show the secret key even in
1826 * protect.c: Add DSA and Elgamal description.
1828 2004-01-29 Werner Koch <wk@gnupg.org>
1830 * agent.h (server_control_s): Add connection_fd field.
1831 * command.c (start_command_handler): Init it here.
1832 * gpg-agent.c (agent_init_default_ctrl): and here.
1833 * call-scd.c: Add the CTRL arg to all functions calling start_scd
1834 and pass it to start_scd. Changed all callers
1835 (start_scd): Keep track of the current active connection.
1836 (agent_reset_scd): New.
1837 * command.c (start_command_handler): Call it here.
1838 * learncard.c (agent_handle_learn): Add arg CTRL; changed caller.
1839 (send_cert_back): Ditto.
1841 2004-01-28 Werner Koch <wk@gnupg.org>
1843 * trustlist.c (agent_marktrusted): Check whether the trustlist is
1846 2004-01-27 Werner Koch <wk@gnupg.org>
1848 * sexp-parse.h: Moved to ../common.
1850 2004-01-24 Werner Koch <wk@gnupg.org>
1852 * call-scd.c (atfork_cb): New.
1853 (start_scd): Make sure secmem gets cleared.
1854 * query.c (atfork_cb): New.
1855 (start_pinentry): Make sure secmem gets cleared.
1857 2004-01-16 Werner Koch <wk@gnupg.org>
1859 * findkey.c (agent_key_from_file): Now return an error code so
1860 that we have more detailed error messages in the upper layers.
1861 This fixes the handling of pinentry's cancel button.
1862 * pksign.c (agent_pksign): Changed accordingly.
1863 * pkdecrypt.c (agent_pkdecrypt): Ditto.
1864 * command.c (cmd_passwd): Ditto.
1866 2003-12-16 Werner Koch <wk@gnupg.org>
1868 * gpg-agent.c (main): Set the prefixes for assuan logging.
1870 2003-12-15 Werner Koch <wk@gnupg.org>
1872 * protect.c (do_encryption): Use gcry_create_nonce instad of the
1873 obsolete WEAK_RANDOM.
1875 2003-11-20 Werner Koch <wk@gnupg.org>
1877 * sexp-parse.h (snext): Don't use atoi_1 and digitp macros, so
1878 that this file is useful by other applications too.
1880 2003-10-27 Werner Koch <wk@gnupg.org>
1882 * command.c (cmd_get_confirmation): New command.
1884 2003-08-20 Timo Schulz <twoaday@freakmail.de>
1886 * pksign.c (do_encode_md): Allocate enough space. Cast md
1887 byte to unsigned char to prevent sign extension.
1889 2003-08-14 Timo Schulz <twoaday@freakmail.de>
1891 * pksign.c (do_encode_md): Due to the fact pkcs#1 padding
1892 is now in Libgcrypt, use the new interface.
1894 2003-07-31 Werner Koch <wk@gnupg.org>
1896 * Makefile.am (gpg_agent_LDADD): Added INTLLIBS.
1897 (gpg_protect_tool_SOURCES): Added simple-pwquery.[ch]
1899 2003-07-27 Werner Koch <wk@gnupg.org>
1901 Adjusted for gcry_mpi_print and gcry_mpi_scan API change.
1903 2003-07-15 Werner Koch <wk@gnupg.org>
1905 * simple-pwquery.c, simple-pwquery.h: Moved to ../common.
1906 * Makefile.am (gpg_protect_tool_LDADD): Add simple-pwquery.o.
1907 Removed it from xx_SOURCES.
1909 2003-07-04 Werner Koch <wk@gnupg.org>
1911 * gpg-agent.c (handle_connections): Kludge to allow use of Pth 1
1914 2003-06-30 Werner Koch <wk@gnupg.org>
1916 * call-scd.c (learn_status_cb): Store the serialno in PARM.
1918 2003-06-26 Werner Koch <wk@gnupg.org>
1920 * call-scd.c (agent_card_serialno): Don't do a RESET anymore.
1922 2003-06-25 Werner Koch <wk@gnupg.org>
1924 * command.c (cmd_scd): New.
1925 * call-scd.c (agent_card_scd): New.
1926 * divert-scd.c (divert_generic_cmd): New
1928 * call-scd.c (agent_card_learn): New callback args SINFO.
1929 (learn_status_cb): Pass all other status lines to the sinfo
1931 * learncard.c (release_sinfo, sinfo_cb): New.
1932 (agent_handle_learn): Pass the new cb to the learn function and
1933 pass the collected information back to the client's assuan
1936 * gpg-agent.c (main): Moved pth_init before gcry_check_version.
1938 2003-06-24 Werner Koch <wk@gnupg.org>
1940 * gpg-agent.c (handle_connections): Adjusted for Pth 2.0
1942 Adjusted for changes in the libgcrypt API. Some more fixes for the
1945 2003-06-04 Werner Koch <wk@gnupg.org>
1947 Renamed error codes from INVALID to INV and removed _ERROR suffixes.
1949 2003-06-03 Werner Koch <wk@gnupg.org>
1951 Changed all error codes in all files to the new libgpg-error scheme.
1953 * agent.h: Include gpg-error.h and errno.h
1954 * Makefile.am: Link with libgpg-error
1956 * query.c: assuan.h is now a system header.
1957 * genkey.c (agent_genkey): Fixed silly use of xmalloc by
1960 2003-04-29 Werner Koch <wk@gnupg.org>
1962 * command.c (register_commands): Adjusted for new Assuan semantics.
1964 * Makefile.am: Don't override LDFLAGS.
1966 2002-12-04 Werner Koch <wk@gnupg.org>
1968 * gpg-agent.c: New variable config_filename.
1969 (parse_rereadable_options): New.
1970 (main): Use it here. Add setting of default values, set
1972 (reread_configuration): Filled with actual code.
1974 2002-12-03 Werner Koch <wk@gnupg.org>
1976 * protect-tool.c (read_key): Don't run make_canonical on a NULL
1979 * command.c (parse_hexstring): New.
1980 (cmd_sethash): Use it.
1981 (parse_keygrip): New.
1982 (cmd_havekey, cmd_sigkey): Use it.
1984 * genkey.c (agent_protect_and_store): New.
1985 (store_key): Add arg FORCE.
1986 (agent_genkey): Pass false to this force of store_key.
1988 2002-11-13 Werner Koch <wk@gnupg.org>
1990 * gpg-agent.c (main): Switch all messages to utf-8.
1992 * simple-pwquery.c (agent_send_all_options): Use $GPG_TTY and
1995 * cache.c (new_data): Uiih - /sizeof d/sizeof *d/.
1997 2002-11-10 Werner Koch <wk@gnupg.org>
1999 * command.c (option_handler): Fix keep_tty check.
2001 2002-11-06 Werner Koch <wk@gnupg.org>
2003 * gpg-agent.c (main): Make sure we have a default ttyname.
2004 * command.c (option_handler): Check opt.keep_tty here
2005 * query.c (start_pinentry): but not anymore here.
2007 2002-11-05 Werner Koch <wk@gnupg.org>
2009 * agent.h (opt,server_control_s): Move display and lc_ variables
2010 to the control struct so that they are per connection.
2011 * gpg-agent.c (agent_init_default_ctrl): New.
2012 (main): Assign those command line options to new default_* variables.
2013 Reset DISPLAY in server mode so that tehre is no implicit default.
2014 * command.c (start_command_handler): Initialize and deinitialize
2016 (option_handler): Work on the ctrl values and not on the opt.
2017 * query.c (start_pinentry): New argument CTRL to set the display
2018 connection specific. Changed all callers to pass this value.
2019 (agent_askpin,agent_get_passphrase,agent_get_confirmation): Add
2020 CTRL arg and pass it ot start_pinentry.
2021 * command.c (cmd_get_passphrase): Pass CTRL argument.
2022 * trustlist.c (agent_marktrusted): Add CTRL argument
2023 * command.c (cmd_marktrusted): Pass CTRL argument
2024 * divert-scd.c (ask_for_card): Add CTRL arg.
2025 (divert_pksign,divert_pkdecrypt): Ditto. Changed caller.
2026 (getpin_cb): Use OPAQUE to pass the CTRL variable. Changed both
2028 * findkey.c (unprotect): Add CTRL arg.
2029 (agent_key_from_file): Ditto.
2031 * query.c (unlock_pinentry): Disconnect the pinentry so that we
2032 start a new one for each request. This is required to support
2033 clients with different environments (e.g. X magic cookies).
2035 2002-09-05 Neal H. Walfield <neal@cs.uml.edu>
2037 * gpg-agent.c (main) [USE_GNU_PTH]: No need to call
2038 assuan_set_io_func as assuan is smart.
2040 2002-09-25 Werner Koch <wk@gnupg.org>
2042 * gpg-agent.c (handle_signal): Flush cache on SIGHUP.
2043 * cache.c (agent_flush_cache): New.
2045 * gpg-agent.c, agent.h: Add --keep-display and --keep-tty.
2046 * query.c (start_pinentry): Implement them. The option passing
2047 needs more thoughts.
2049 2002-09-09 Werner Koch <wk@gnupg.org>
2051 * gpg-agent.c (create_private_keys_directory)
2052 (create_directories): New.
2053 (main): Try to create a home directory.
2055 2002-09-04 Neal H. Walfield <neal@g10code.de>
2057 * gpg-agent.c (main): Use sigaction, not signal.
2059 2002-09-03 Neal H. Walfield <neal@g10code.de>
2061 * findkey.c: Include <fcntl.h>.
2062 (agent_write_private_key): Prefer POSIX compatibity, open and
2063 fdopen, over the simplicity of GNU extensions, fopen(file, "x").
2065 2002-08-22 Werner Koch <wk@gnupg.org>
2067 * query.c (agent_askpin): Provide the default desc text depending
2068 on the pininfo. Do the basic PIN verification only when
2071 2002-08-21 Werner Koch <wk@gnupg.org>
2073 * query.c (agent_askpin): Hack to show the right default prompt.
2074 (agent_get_passphrase): Ditto.
2076 * trans.c: Removed and replaced all usages with standard _()
2078 * divert-scd.c (getpin_cb): Pass a more descritive text to the
2081 * Makefile.am: Renamed the binary protect-tool to gpg-protect-tool.
2082 * protect-tool.c: Removed the note about internal use only.
2084 * gpg-agent.c (main): New option --daemon so that the program is
2085 not accidently started in the background.
2087 2002-08-16 Werner Koch <wk@gnupg.org>
2089 * call-scd.c (learn_status_cb): Handle CERTINFO status.
2090 (agent_card_learn): Add args for certinfo cb.
2091 * learncard.c (release_certinfo,certinfo_cb): New.
2092 (send_cert_back): New. With factored out code from ..
2093 (agent_handle_learn): here. Return certinfo stuff.
2095 2002-07-26 Werner Koch <wk@gnupg.org>
2097 * gpg-agent.c (main): New option --ignore-cache-for-signing.
2098 * command.c (option_handler): New server option
2099 use-cache-for-signing defaulting to true.
2100 (cmd_pksign): handle global and per session option.
2101 * findkey.c (agent_key_from_file, unprotect): New arg
2102 ignore_cache. Changed all callers.
2103 * pksign.c (agent_pksign): Likewise.
2105 2002-06-29 Werner Koch <wk@gnupg.org>
2107 * query.c (start_pinentry): Use GNUPG_DERAULT_PINENTRY.
2108 * call-scd.c (start_scd): Use GNUPG_DEFAULT_SCDAEMON.
2110 2002-06-28 Werner Koch <wk@gnupg.org>
2112 * protect-tool.c (export_p12_file): New.
2113 (main): New command --p12-export.
2114 * minip12.c (create_final,p12_build,compute_tag_length): New.
2115 (store_tag_length): New.
2117 2002-06-27 Werner Koch <wk@gnupg.org>
2119 * minip12.c (crypt_block): Renamed from decrypt_block, add arg to
2122 * Makefile.am (pkglib_PROGRAMS): Put protect-tool there.
2124 * findkey.c (agent_write_private_key,agent_key_from_file)
2125 (agent_key_available): Use GNUPG_PRIVATE_KEYS_DIR constant.
2126 * gpg-agent.c (main): Use GNUPG_DEFAULT_HOMEDIR constant.
2128 * protect-tool.c (store_private_key): New.
2129 (import_p12_file): Store the new file if requested.
2130 (main): New options --force and --store.
2132 * gpg-agent.c (main): Set a global flag when running detached.
2133 * query.c (start_pinentry): Pass the list of FD to keep in the
2134 child when not running detached.
2135 * call-scd.c (start_scd): Ditto.
2137 2002-06-26 Werner Koch <wk@gnupg.org>
2139 * command.c (cmd_istrusted, cmd_listtrusted, cmd_marktrusted)
2140 (cmd_pksign, cmd_pkdecrypt, cmd_genkey, cmd_get_passphrase)
2141 (cmd_learn): Print an error message for a failed operation.
2143 * simple-pwquery.c, simple-pwquery.h: New.
2144 * protect-tool. (get_passphrase): New, used to get a passphrase
2145 from the agent if none was given on the command line.
2147 2002-06-25 Werner Koch <wk@gnupg.org>
2149 * protect-tool.c (rsa_key_check): New.
2150 (import_p12_file): New.
2151 (main): New command --p12-import.
2152 * minip12.c, minip12.h: New.
2154 2002-06-24 Werner Koch <wk@gnupg.org>
2156 * protect-tool.c (read_file): New.
2157 (read_key): Factored most code out to read_file.
2159 2002-06-17 Werner Koch <wk@gnupg.org>
2161 * agent.h: Add a callback function to the pin_entry_info structure.
2162 * query.c (agent_askpin): Use the callback to check for a correct
2163 PIN. Removed the start_err_text argument because it is not
2164 anymore needed; changed callers.
2165 * findkey.c (unprotect): Replace our own check loop by a callback.
2166 (try_unprotect_cb): New.
2167 * genkey.c (reenter_compare_cb): New.
2168 (agent_genkey): Use this callback here. Fixed setting of the pi2
2169 variable and a segv in case of an empty PIN.
2171 * divert-scd.c (getpin_cb): Removed some unused stuff and
2172 explained what we still have to change.
2174 2002-06-12 Werner Koch <wk@gnupg.org>
2176 * gpg-agent.c (main): New option --disable-pth.
2178 2002-06-11 Werner Koch <wk@gnupg.org>
2180 * protect-tool.c: Add command --show-keygrip
2181 (show_keygrip): New.
2183 2002-05-23 Werner Koch <wk@gnupg.org>
2185 * call-scd.c: Seirialized all scdaeom access when using Pth.
2187 * cache.c: Made the cache Pth-thread-safe.
2188 (agent_unlock_cache_entry): New.
2189 * findkey.c (unprotect): Unlock the returned cache value.
2190 * command.c (cmd_get_passphrase): Ditto.
2192 * gpg-agent.c (main): Register pth_read/write with Assuan.
2194 2002-05-22 Werner Koch <wk@gnupg.org>
2196 * query.c: Serialized all pinentry access when using Pth.
2198 * gpg-agent.c (handle_signal,start_connection_thread)
2199 (handle_connections): New
2200 (main): Use the new Pth stuff to allow concurrent connections.
2201 * command.c (start_command_handler): Add new arg FD so that the
2202 fucntion can also be used for an already connected socket.
2203 * Makefile.am: Link with Pth.
2205 2002-05-14 Werner Koch <wk@gnupg.org>
2207 * cache.c (housekeeping, agent_put_cache): Use our time() wrapper.
2209 2002-04-26 Werner Koch <wk@gnupg.org>
2211 * cache.c (agent_put_cache): Reinitialize the creation time and
2212 the ttl when reusing a slot.
2214 * call-scd.c (start_scd): Print debug messages only with debug
2216 * query.c (start_pinentry): Ditto.
2218 2002-04-25 Marcus Brinkmann <marcus@g10code.de>
2220 * agent.h (agent_get_confirmation): Replace paramter prompt with
2221 two parameters ok and cancel.
2222 * query.c (agent_get_confirmation): Likewise. Implement this.
2223 * trustlist.c (agent_marktrusted): Fix invocation of
2224 agent_get_confirmation.
2225 * divert-scd.c (ask_for_card): Likewise.
2227 2002-04-24 Marcus Brinkmann <marcus@g10code.de>
2229 * agent.h (struct opt): Add members display, ttyname, ttytype,
2230 lc_ctype, and lc_messages.
2231 * gpg-agent.c (enum cmd_and_opt_values): Add oDisplay, oTTYname,
2232 oTTYtype, oLCctype, and LCmessages.
2233 (main): Handle these options.
2234 * command.c (option_handler): New function.
2235 (register_commands): Register option handler.
2236 * query.c (start_pinentry): Pass the various display and tty
2237 options to the pinentry.
2239 2002-04-05 Werner Koch <wk@gnupg.org>
2241 * protect-tool.c (show_file): New. Used as default action.
2243 2002-03-28 Werner Koch <wk@gnupg.org>
2245 * divert-scd.c (encode_md_for_card): Don't do the pkcs-1 padding,
2246 the scdaemon should take care of it.
2247 (ask_for_card): Hack to not display the trailing zero.
2249 2002-03-11 Werner Koch <wk@gnupg.org>
2251 * learncard.c (kpinfo_cb): Remove the content restrictions from
2254 2002-03-06 Werner Koch <wk@gnupg.org>
2257 * divert-scd.c (ask_for_card): The serial number is binary so
2258 convert it to hex here.
2259 * findkey.c (agent_write_private_key): New.
2260 * genkey.c (store_key): And use it here.
2262 * pkdecrypt.c (agent_pkdecrypt): Changed the way the diversion is done.
2263 * divert-scd.c (divert_pkdecrypt): Changed interface and
2266 2002-03-05 Werner Koch <wk@gnupg.org>
2268 * call-scd.c (inq_needpin): New.
2269 (agent_card_pksign): Add getpin_cb args.
2270 (agent_card_pkdecrypt): New.
2272 2002-03-04 Werner Koch <wk@gnupg.org>
2274 * pksign.c (agent_pksign): Changed how the diversion is done.
2275 * divert-scd.c (divert_pksign): Changed interface and implemented it.
2276 (encode_md_for_card): New.
2277 * call-scd.c (agent_card_pksign): New.
2279 2002-02-28 Werner Koch <wk@gnupg.org>
2281 * pksign.c (agent_pksign): Detect whether a Smartcard is to be
2282 used and divert the operation in this case.
2283 * pkdecrypt.c (agent_pkdecrypt): Likewise
2284 * findkey.c (agent_key_from_file): Add optional arg shadow_info
2285 and have it return information about a shadowed key.
2286 * protect.c (agent_get_shadow_info): New.
2288 * protect.c (snext,sskip,smatch): Moved to
2289 * sexp-parse.h: New file.
2290 * divert-scd.c: New.
2292 2002-02-27 Werner Koch <wk@gnupg.org>
2294 * protect.c (agent_shadow_key): New.
2296 * command.c (cmd_learn): New command LEARN.
2297 * gpg-agent.c: New option --scdaemon-program.
2298 * call-scd.c (start_scd): New. Based on query.c
2299 * query.c: Add 2 more arguments to all uses of assuan_transact.
2301 2002-02-18 Werner Koch <wk@gnupg.org>
2303 * findkey.c (unprotect): Show an error message for a bad passphrase.
2305 * command.c (cmd_marktrusted): Implemented.
2306 * trustlist.c (agent_marktrusted): New.
2307 (open_list): Add APPEND arg.
2309 * query.c (agent_get_confirmation): New.
2311 2002-02-06 Werner Koch <wk@gnupg.org>
2313 * cache.c (housekeeping): Fixed linking in the remove case.
2315 2002-02-01 Werner Koch <wk@gnupg.org>
2317 * gpg-agent.c: New option --default-cache-ttl.
2318 * cache.c (agent_put_cache): Use it.
2320 * cache.c: Add a few debug outputs.
2322 * protect.c (agent_private_key_type): New.
2323 * agent.h: Add PRIVATE_KEY_ enums.
2324 * findkey.c (agent_key_from_file): Use it to decide whether we
2325 have to unprotect a key.
2326 (unprotect): Cache the passphrase.
2328 * findkey.c (agent_key_from_file,agent_key_available): The key
2329 files do now require a ".key" suffix to make a script's life
2331 * genkey.c (store_key): Ditto.
2333 2002-01-31 Werner Koch <wk@gnupg.org>
2335 * genkey.c (store_key): Protect the key.
2336 (agent_genkey): Ask for the passphrase.
2337 * findkey.c (unprotect): Actually unprotect the key.
2338 * query.c (agent_askpin): Add an optional start_err_text.
2340 2002-01-30 Werner Koch <wk@gnupg.org>
2343 (hash_passphrase): Based on the GnuPG 1.0.6 version.
2344 * protect-tool.c: New
2346 2002-01-29 Werner Koch <wk@gnupg.org>
2348 * findkey.c (agent_key_available): New.
2349 * command.c (cmd_havekey): New.
2350 (register_commands): And register new command.
2352 2002-01-20 Werner Koch <wk@gnupg.org>
2354 * command.c (cmd_get_passphrase): Remove the plus signs.
2356 * query.c (start_pinentry): Send no-grab option to pinentry
2357 * gpg-agent.c (main): Move variable grab as no_grab to agent.h.
2359 2002-01-19 Werner Koch <wk@gnupg.org>
2361 * gpg-agent.c (main): Disable core dumps.
2364 * command.c (cmd_get_passphrase): Use the cache.
2365 (cmd_clear_passphrase): Ditto.
2367 * gpg-agent.c: Removed unused cruft and implement the socket
2369 (my_strusage): Take bug report address from configure.ac.
2370 * command.c (start_command_handler): Add an argument to start as
2372 (start_command_handler): Enable Assuan logging.
2374 2002-01-15 Werner Koch <wk@gnupg.org>
2377 * command.c (cmd_istrusted, cmd_listtrusted, cmd_marktrusted): New.
2379 2002-01-07 Werner Koch <wk@gnupg.org>
2381 * genkey.c: Store the secret part and return the public part.
2383 2002-01-03 Werner Koch <wk@gnupg.org>
2385 * command.c (cmd_get_passphrase): New.
2386 (cmd_clear_passphrase): New.
2387 * query.c (agent_get_passphrase): New.
2389 2002-01-02 Werner Koch <wk@gnupg.org>
2392 * command.c (cmd_genkey): New.
2394 * command.c (rc_to_assuan_status): Removed and changed all callers
2395 to use map_to_assuan_status.
2397 2001-12-19 Werner Koch <wk@gnupg.org>
2399 * keyformat.txt: New.
2401 2001-12-19 Marcus Brinkmann <marcus@g10code.de>
2403 * query.c (start_pinentry): Add new argument to assuan_pipe_connect.
2405 2001-12-18 Werner Koch <wk@gnupg.org>
2407 * Makefile.am: Use LIBGCRYPT macros
2409 2001-12-14 Werner Koch <wk@gnupg.org>
2411 * gpg-agent.c (main): New option --batch. New option --debug-wait
2412 n, so that it is possible to attach gdb when used in server mode.
2413 * query.c (agent_askpin): Don't ask in batch mode.
2415 * command.c: Removed the conversion macros as they are now in
2418 2001-12-14 Marcus Brinkmann <marcus@g10code.de>
2420 * query.c (LINELENGTH): Removed.
2421 (agent_askpin): Use ASSUAN_LINELENGTH, not LINELENGTH.
2423 2001-11-19 Werner Koch <wk@gnupg.org>
2425 * gpg-agent.c: Removed all GUI code, removed code for old
2426 protocol. New code to use the Assuan protocol as a server and
2427 also to communicate with a new ask-passphrase utility.
2429 2000-11-22 Werner Koch <wk@gnupg.org>
2431 * gpg-agent.c (main): csh support by Dan Winship, new options --sh
2432 and --csh and set default by consulting $SHELL.
2434 Mon Aug 21 17:59:17 CEST 2000 Werner Koch <wk@openit.de>
2436 * gpg-agent.c (passphrase_dialog): Cleanup the window and added the
2437 user supplied text to the window.
2438 (main): Fixed segv in gtk_init when used without a command to start.
2440 * gpg-agent.c: --flush option.
2442 (req_clear_passphrase): Implemented.
2444 Fri Aug 18 14:27:14 CEST 2000 Werner Koch <wk@openit.de>
2450 Copyright 2001, 2002, 2003, 2004, 2005,
2451 2007, 2008, 2009 Free Software Foundation, Inc.
2453 This file is free software; as a special exception the author gives
2454 unlimited permission to copy and/or distribute it, with or without
2455 modifications, as long as this notice is preserved.
2457 This file is distributed in the hope that it will be useful, but
2458 WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
2459 implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.