1 2009-06-24 Werner Koch <wk@g10code.com>
3 * genkey.c (agent_protect_and_store): Return RC and not 0.
4 * protect.c (do_encryption): Fix ignored error code from malloc.
5 Reported by Fabian Keil.
7 2009-06-17 Werner Koch <wk@g10code.com>
9 * call-pinentry.c (agent_get_confirmation): Add arg WITH_CANCEL.
11 * trustlist.c (agent_marktrusted): Use WITH_CANCEL
13 2009-06-09 Werner Koch <wk@g10code.com>
15 * learncard.c (send_cert_back): Ignore certain error codes.
17 2009-06-05 Werner Koch <wk@g10code.com>
19 * protect-tool.c (store_private_key): Fix last change by appending
22 2009-06-03 Werner Koch <wk@g10code.com>
24 * protect-tool.c: Include estream.h.
25 (store_private_key): Replace stdio streams by estream functions
26 for a portable use of the "x" mode.
27 * trustlist.c: Include estream.h.
28 (agent_marktrusted): Replace stdio stream by estream functions.
30 * protect-tool.c (store_private_key): Use bin2hex.
32 2009-06-02 Werner Koch <wk@g10code.com>
34 * gpg-agent.c (main): Run pth_kill after fork. Fixes bug#1066.
36 2009-05-19 Werner Koch <wk@g10code.com>
38 * gpg-agent.c (JNLIB_NEED_AFLOCAL): Define.
39 (create_server_socket): Use SUN_LEN macro.
41 2009-05-15 Werner Koch <wk@g10code.com>
45 * agent.h (lookup_ttl_t): New.
46 * findkey.c (unprotect): Add arg LOOKUP_TTL.
47 (agent_key_from_file): Ditto.
48 * pksign.c (agent_pksign_do): Ditto.
49 * command-ssh.c (ttl_from_sshcontrol): New.
50 (data_sign): Pass new function to agent_pksign_do.
51 (search_control_file): Add new arg R_TTL.
53 2009-05-14 Werner Koch <wk@g10code.com>
55 * command.c (cmd_get_passphrase): Add option --qualitybar.
56 * call-pinentry.c (agent_askpin): Factor some code out to ...
57 (setup_qualitybar): .. new.
58 (agent_get_passphrase): Add arg WITH_QUALITYBAR and implement it.
60 2009-04-14 Marcus Brinkmann <marcus@g10code.de>
62 * call-pinentry.c (agent_get_confirmation): Try SETNOTOK command
65 2009-04-01 Werner Koch <wk@g10code.com>
67 * protect-tool.c (pe_opt): New.
68 (opts): Add option --agent-program. Use ARGPARSE macros.
69 (get_new_passphrase): Remove.
70 (get_passphrase): Use gpg-agent directly. Remove arg OPT_CHECK and
72 * Makefile.am (gpg_protect_tool_LDADD): Replace pwquery_libs by
74 (gpg_protect_tool_CFLAGS): New.
76 * command.c (percent_plus_unescape): Remove.
77 (cmd_putval): Use percent_plus_unescape_inplace.
78 * call-scd.c (unescape_status_string): Remove.
79 (card_getattr_cb): Use percent_plus_unescape.
80 * protect-tool.c (main): Use percent_plus_unescape from common/.
81 (percent_plus_unescape, percent_plus_unescape_string): Remove.
83 2009-03-27 Werner Koch <wk@g10code.com>
85 * learncard.c (agent_handle_learn): Add new certtype 111.
87 2009-03-26 Werner Koch <wk@g10code.com>
89 * agent.h (MAX_DIGEST_LEN): Change to 64.
90 * command.c (cmd_sethash): Allow digest length of 48 and 64.
91 (cmd_sethash): Allow more hash algos.
93 * trustlist.c (reformat_name): New.
94 (agent_marktrusted): Use a reformatted name. Reload the table
95 before the update and always reload it at the end.
96 (agent_istrusted): Check early for the disabled flag.
98 2009-03-25 Werner Koch <wk@g10code.com>
100 * pkdecrypt.c (agent_pkdecrypt): Return a specific error message
101 if the key is not available.
103 * gpg-agent.c (main): Print a started message to show the real pid.
105 2009-03-20 Werner Koch <wk@g10code.com>
107 * learncard.c (struct kpinfo_cp_parm_s): Add field CTRL.
108 (struct certinfo_cb_parm_s): Ditto.
109 (agent_handle_learn): Set CTRL field.
110 (kpinfo_cb, certinfo_cb): Send progress status.
112 * agent.h (agent_write_status): Flag with GNUPG_GCC_A_SENTINEL.
114 2009-03-19 Werner Koch <wk@g10code.com>
116 * trustlist.c (struct trustitem_s): Add field DISABLED.
117 (read_one_trustfile): Parse the '!' flag.
118 (agent_istrusted, agent_listtrusted): Check flag.
119 (agent_istrusted): Add arg R_DISABLED. Change all callers.
120 (agent_marktrusted): Do not ask if flagged as disabled. Reverse
121 the order of the questions. Store the disabled flag.
123 * gpg-agent.c (main): Save signal mask and open fds. Restore mask
124 and close all fds prior to the exec. Fixes bug#1013.
126 2009-03-17 Werner Koch <wk@g10code.com>
128 * command.c (cmd_get_passphrase): Break repeat loop on error.
130 (cmd_getinfo): Add subcommand "cmd_has_option".
131 (command_has_option): New.
133 2009-03-17 Daiki Ueno <ueno@unixuser.org>
135 * command.c (option_value): New function.
136 (cmd_get_passphrase): Accept new option --repeat, which makes
137 gpg-agent to ask passphrase several times.
139 2009-03-06 Werner Koch <wk@g10code.com>
141 * command.c (cmd_keyinfo): New command.
142 (register_commands): Register it.
143 (agent_write_status): Make sure not to print LR or CR.
144 * divert-scd.c (ask_for_card): Factor shadow info parsing out to ...
145 * protect.c (parse_shadow_info): New.
146 * findkey.c (agent_key_from_file): Use make_canon_sexp.
147 (agent_write_private_key, unprotect, read_key_file)
148 (agent_key_available): Use bin2hex.
149 (agent_key_info_from_file): New.
150 (read_key_file): Log no error message for ENOENT.
152 2009-03-05 Werner Koch <wk@g10code.com>
154 * divert-scd.c (getpin_cb): Support flag 'P'. Change max_digits
155 from 8 to 16. Append a message about keypads.
156 * findkey.c (unprotect): Change max digits to 16.
158 2009-03-02 Werner Koch <wk@g10code.com>
160 * command.c (cmd_getinfo): Add subcommand "scd_running".
162 * call-scd.c (agent_scd_check_running): New.
164 * gpg-agent.c: Add missing option strings for "--batch" and
165 "--homedir". Reported by Petr Uzel.
167 * protect-tool.c (import_p12_file): Take care of canceled
168 passphrase entry. Fixes bug#1003.
169 (export_p12_file): Ditto.
171 2008-12-17 Werner Koch <wk@g10code.com>
173 * gpg-agent.c (handle_connections): Set action of all pth event
174 handled signals to SIG_IGN. Use a different pth_sigmask strategy.
176 2008-12-10 Werner Koch <wk@g10code.com>
178 * command.c (cmd_get_passphrase): Implement option --no-ask.
180 2008-12-09 Werner Koch <wk@g10code.com>
182 * gpg-agent.c (main): Call i18n_init before init_common_subsystems.
183 * preset-passphrase.c (main): Ditto.
184 * protect-tool.c (main): Ditto.
186 * command.c (cmd_preset_passphrase): Allow an arbitrary string for
189 2008-12-08 Werner Koch <wk@g10code.com>
191 * gpg-agent.c (handle_connections): Sync the ticker to the next
192 full second. This is bug#871.
194 2008-12-05 Werner Koch <wk@g10code.com>
196 * minip12.c (decrypt_block): Fix const modified of CHARSETS.
197 * learncard.c (sinfo_cb_parm_s): Remove superflous semicolon.
198 Reported by Stoyan Angelov.
200 2008-11-18 Werner Koch <wk@g10code.com>
202 * gpg-agent.c (make_libversion): New.
203 (my_strusage): Print libgcrypt version
205 2008-11-11 Werner Koch <wk@g10code.com>
207 * call-scd.c (membuf_data_cb): Change return type to
208 assuan_error_t to avoid warnings with newer libassuan versions.
210 2008-11-04 Werner Koch <wk@g10code.com>
212 * command.c (cmd_killagent): Stop the agent immediately.
213 (start_command_handler): Take care of GPG_ERR_EOF.
215 2008-10-29 Werner Koch <wk@g10code.com>
217 * gpg-agent.c (main): Move USE_STANDARD_SOCKET to the outer scope.
218 (create_socket_name): Remove arg USE_STANDARD_SOCKET. Change all
220 (create_server_socket): Remove IS_STANDARD_NAME and replace it by
221 USE_STANDARD_SOCKET. Change all callers.
222 (check_own_socket_running): New.
223 (check_own_socket, check_own_socket_thread): New.
224 (handle_tick): Check server socket once a minute.
225 (handle_connections): Remove the extra pth_wait in the shutdown
228 2008-10-20 Werner Koch <wk@g10code.com>
230 * command.c (cmd_geteventcounter): Mark unused arg.
231 (cmd_listtrusted, cmd_pksign, cmd_pkdecrypt, cmd_genkey): Ditto.
232 (cmd_updatestartuptty, post_cmd_notify): Ditto.
233 * command-ssh.c (add_control_entry)
234 (ssh_handler_request_identities, ssh_handler_remove_identity)
235 (ssh_handler_remove_all_identities, ssh_handler_lock)
236 (ssh_handler_unlock): Ditto.
237 * call-pinentry.c (pinentry_active_p, popup_message_thread)
238 (agent_popup_message_stop): Ditto.
239 * findkey.c (agent_public_key_from_file): Ditto.
240 * genkey.c (check_passphrase_pattern): Ditto.
241 * call-scd.c (atfork_cb): Ditto.
242 * protect-tool.c (import_p12_cert_cb): Ditto.
243 * t-protect.c (main): Ditto.
245 2008-10-17 Werner Koch <wk@g10code.com>
247 * call-scd.c (start_scd) [W32]: Use snprintf again because we now
248 always use the estream variant.
250 2008-10-15 Werner Koch <wk@g10code.com>
252 * call-scd.c (start_scd): Enable assuan loggging if requested.
253 (agent_scd_check_aliveness) [W32]: Fix use of GetExitCodeProcess.
255 2008-10-14 Werner Koch <wk@g10code.com>
257 * gpg-agent.c (get_agent_scd_notify_event): Need to use a manual
260 2008-09-29 Werner Koch <wk@g10code.com>
262 * agent.h (GCRY_MD_USER): Rename to GCRY_MODULE_ID_USER.
263 (GCRY_MD_USER_TLS_MD5SHA1): Rename to MD_USER_TLS_MD5SHA1 and
266 2008-09-25 Werner Koch <wk@g10code.com>
268 * divert-scd.c (getpin_cb): Support a Reset Code style PINs..
270 2008-09-03 Werner Koch <wk@g10code.com>
272 * command.c (parse_keygrip): Use hex2bin.
273 (cmd_preset_passphrase): Decode the passphrase. Reported by Kiss
274 Gabor. Fixes #679 again.
275 * preset-passphrase.c (make_hexstring): Remove.
276 (preset_passphrase): Use bin2hex.
278 2008-05-27 Werner Koch <wk@g10code.com>
280 * trustlist.c (insert_colons): Fix stupidly wrong allocation size
283 2008-05-26 Werner Koch <wk@g10code.com>
285 * gpg-agent.c (main): Re-initialize default assuan log stream if a
288 * trustlist.c (agent_marktrusted): Use xtryasprintf and xfree.
290 * gpg-agent.c (main, agent_deinit_default_ctrl): Always use xfree
291 because our asprintf is mapped to an xmalloc style function in
292 util.h. Replace xstrdup by xtrystrdup.
293 * w32main.c (build_argv): Ditto.
294 * preset-passphrase.c (preset_passphrase): Ditto.
295 * divert-scd.c (ask_for_card): Ditto.
296 * command.c (option_handler): Ditto.
297 * command-ssh.c (ssh_handler_request_identities): Ditto.
298 * call-pinentry.c (start_pinentry): Ditto.
300 * gpg-agent.c (start_connection_thread)
301 (start_connection_thread_ssh): Use pth_thread_id for useful output
303 (pth_thread_id) [!PTH_HAVE_PTH_THREAD_ID]: New.
305 2008-03-17 Werner Koch <wk@g10code.com>
307 * agent.h (agent_inq_pinentry_launched): New prototype.
309 * call-pinentry.c: Include sys/types.h and signal.h.
311 2008-02-14 Werner Koch <wk@g10code.com>
313 * command.c (agent_inq_pinentry_launched): New.
314 (option_handler): Add option allow-pinentry-notify.
315 * call-pinentry.c (getinfo_pid_cb): New.
316 (start_pinentry): Ask for the PID and notify the client.
318 2008-01-15 Marcus Brinkmann <marcus@g10code.de>
320 * call-pinentry.c (start_pinentry): Start pinentry in detached
323 2007-12-04 Werner Koch <wk@g10code.com>
325 * call-pinentry.c (agent_askpin): Use gnupg_get_help_string.
327 2007-12-03 Werner Koch <wk@g10code.com>
329 * gpg-agent.c (main): s/standard_socket/use_standard_socket/ for
331 (create_server_socket): New arg IS_SSH to avoid testing with
334 2007-11-20 Werner Koch <wk@g10code.com>
336 * gpg-agent.c (get_agent_scd_notify_event): New.
337 (handle_signal): Factor SIGUSR2 code out to:
338 (agent_sigusr2_action): .. New.
339 (agent_sighup_action): Print info message here and not in
341 (handle_connections) [PTH_EVENT_HANDLE]: Call agent_sigusr2_action.
343 * call-scd.c (agent_scd_check_aliveness) [W32]: Implemented.
344 (start_scd) [W32]: Send event-signal option.
346 2007-11-19 Werner Koch <wk@g10code.com>
348 * call-pinentry.c (agent_askpin): Set the tooltip for the quality
351 2007-11-15 Werner Koch <wk@g10code.com>
353 * agent.h (struct server_control_s): Add XAUTHORITY and
355 * gpg-agent.c: New option --xauthority.
356 (main, agent_init_default_ctrl)
357 (agent_deinit_default_ctrl): Implemented
358 * command.c (cmd_updatestartuptty): Ditto.
359 * command-ssh.c (start_command_handler_ssh): Ditto.
360 * call-pinentry.c (atfork_cb): Set the environment.
361 (start_pinentry): Pass CTRL as arg to atfork_cb.
363 2007-11-14 Werner Koch <wk@g10code.com>
365 * call-scd.c (start_scd) [W32]: Take care of fflush peculiarities.
367 2007-11-07 Werner Koch <wk@g10code.com>
369 * agent.h: Remove errors.h.
371 2007-10-24 Werner Koch <wk@g10code.com>
373 * genkey.c (check_passphrase_constraints): Changed the wording of
374 the warning messages.
376 2007-10-19 Werner Koch <wk@g10code.com>
378 * protect-tool.c (get_passphrase): Use new utf8 switch fucntions.
380 2007-10-15 Daiki Ueno <ueno@unixuser.org> (wk)
382 * command-ssh.c (reenter_compare_cb): New function; imported from
384 (ssh_identity_register): Ask initial passphrase twice.
386 2007-10-02 Werner Koch <wk@g10code.com>
388 * command.c (cmd_getinfo): Add "pid" subcommand.
390 2007-10-01 Werner Koch <wk@g10code.com>
392 * agent.h (struct server_control_s): Remove unused CONNECTION_FD.
394 * gpg-agent.c: Remove w32-afunix.h. Include mkdtemp.h.
395 (socket_nonce, socket_nonce_ssh): New.
396 (create_server_socket): Use assuan socket wrappers. Remove W32
397 specific stuff. Save the server nonce.
399 (start_connection_thread, start_connection_thread_ssh): Call it.
400 (handle_connections): Change args to gnupg_fd_t.
401 * command.c (start_command_handler): Change LISTEN_FD to gnupg_fd_t.
402 * command-ssh.c (start_command_handler_ssh): Ditto.
404 2007-09-18 Werner Koch <wk@g10code.com>
406 * agent.h (struct pin_entry_info_s): Add element WITH_QUALITYBAR.
407 * genkey.c (check_passphrase_constraints): New arg SILENT.
409 (agent_protect_and_store, agent_genkey): Enable qualitybar.
410 * call-pinentry.c (agent_askpin): Send that option.
411 (unescape_passphrase_string): New.
413 (estimate_passphrase_quality): New.
415 2007-09-14 Marcus Brinkmann <marcus@g10code.de>
417 * call-pinentry.c (agent_popup_message_stop): Implement kill for
420 2007-08-28 Werner Koch <wk@g10code.com>
422 * gpg-agent.c (main): Add option --faked-system-time.
424 * protect-tool.c (read_and_unprotect): Print the protected-at date.
426 * agent.h (struct server_control_s): Add member IN_PASSWD.
427 * command.c (cmd_passwd): Set it.
428 * findkey.c (try_unprotect_cb): Use it.
430 * protect.c (do_encryption): Replace asprintf by xtryasprint.
431 (agent_protect): Create the protected-at item.
432 (agent_unprotect): Add optional arg PROTECTED_AT.
433 (merge_lists): Add args CUTOFF and CUTLEN.
434 (agent_unprotect): Use them.
435 * findkey.c (try_unprotect_cb): Add code to test for expired keys.
436 (unprotect): Allow changing the passphrase.
438 2007-08-27 Werner Koch <wk@g10code.com>
440 * gpg-agent.c: Add options --min-passphrase-nonalpha,
441 --check-passphrase-pattern and --enforce-passphrase-constraints.
442 (MIN_PASSPHRASE_NONALPHA): Init nonalpha option to 1.
443 (main): Declare options for gpgconf.
444 * agent.h (struct): Add members MIN_PASSPHRASE_NONALPHA,
445 ENFORCE_PASSPHRASE_CONSTRAINTS and CHECK_PASSPHRASE_PATTERN.
446 * genkey.c (nonalpha_charcount): New.
447 (check_passphrase_pattern): New.
448 (check_passphrase_constraints): Implement. Factor some code out...
449 (take_this_one_anyway, take_this_one_anyway2): .. New.
451 * call-pinentry.c (agent_show_message): New.
452 (agent_askpin): We better reset the pin buffer before asking.
454 * trustlist.c (insert_colons): New.
455 (agent_marktrusted): Pretty print the fpr.
457 2007-08-22 Werner Koch <wk@g10code.com>
459 * findkey.c (O_BINARY): Make sure it is defined.
460 (agent_write_private_key): Use O_BINARY
462 * protect-tool.c (import_p12_file): Add hack to allow importing of
463 gnupg 2.0.4 generated files.
465 2007-08-06 Werner Koch <wk@g10code.com>
467 * trustlist.c (read_one_trustfile): Add flag "cm".
468 (agent_istrusted): Ditto.
470 2007-08-02 Werner Koch <wk@g10code.com>
472 * gpg-agent.c: Include gc-opt-flags.h and remove their definition
475 2007-07-13 Werner Koch <wk@g10code.com>
477 * genkey.c (check_passphrase_constraints): Require a confirmation
478 for an empty passphrase.
479 (agent_genkey, agent_protect_and_store): No need to repeat an
482 2007-07-05 Werner Koch <wk@g10code.com>
484 * call-scd.c (struct inq_needpin_s): New.
485 (inq_needpin): Pass unknown inquiries up.
487 2007-07-04 Werner Koch <wk@g10code.com>
489 * gpg-agent.c (TIMERTICK_INTERVAL): New.
490 (fixed_gcry_pth_init, main): Kludge to fix Pth initialization.
492 2007-07-03 Werner Koch <wk@g10code.com>
494 * gpg-agent.c (handle_connections): Do not use FD_SETSIZE for
495 select but compute the correct number.
497 2007-07-02 Werner Koch <wk@g10code.com>
499 * command.c (cmd_reloadagent) [W32]: New.
500 (register_commands) [W32]: New command RELOADAGENT.
502 * Makefile.am (gpg_agent_SOURCES): Remove w32main.c and w32main.h.
503 (gpg_agent_res_ldflags): Remove icon file as we don't have a
505 * gpg-agent.c (main): do not include w32main.h. Remove all calls
507 (agent_sighup_action): New.
508 (handle_signal): Use it.
510 2007-06-26 Werner Koch <wk@g10code.com>
512 * gpg-agent.c (create_directories) [W32]: Made it work.
514 2007-06-21 Werner Koch <wk@g10code.com>
516 * agent.h (ctrl_t): Remove. It is now declared in ../common/util.h.
518 * gpg-agent.c (check_for_running_agent): New arg SILENT. Changed
520 (create_server_socket): If the standard socket is in use check
521 whether a agent is running and avoid starting another one.
523 2007-06-18 Marcus Brinkmann <marcus@g10code.de>
525 * gpg-agent.c (main): Percent escape pathname in --gpgconf-list
528 2007-06-18 Werner Koch <wk@g10code.com>
530 * w32main.c (build_argv): New.
533 * command.c (cmd_killagent) [W32]: New.
535 * gpg-agent.c (get_agent_ssh_socket_name): New.
536 (no_force_standard_socket) New.
537 (create_server_socket): Use it.
538 * Makefile.am (gpg_agent_res_ldflags): Pass windows option to ld.
540 2007-06-14 Werner Koch <wk@g10code.com>
542 * protect-tool.c (main): Setup default socket name for
544 (MAP_SPWQ_ERROR_IMPL): New. Use map_spwq_error for spqw related
546 * preset-passphrase.c (main): Setup default socket name for
548 (map_spwq_error): Remove.
549 (MAP_SPWQ_ERROR_IMPL): New.
551 * call-pinentry.c (start_pinentry): Use gnupg_module_name.
552 * call-scd.c (start_scd): Ditto.
554 2007-06-12 Werner Koch <wk@g10code.com>
558 * trustlist.c (read_one_trustfile): Replace GNUPG_SYSCONFDIR by a
560 (read_trustfiles): Ditto.
562 * gpg-agent.c (main): Replace some calls by init_common_subsystems.
563 * preset-passphrase.c (main): Ditto.
564 * protect-tool.c (main): Ditto.
566 2007-06-11 Werner Koch <wk@g10code.com>
568 * Makefile.am (common_libs): Use libcommonstd macro.
569 (commonpth_libs): Use libcommonpth macro.
571 * protect-tool.c (main) [W32]: Call pth_init.
573 * preset-passphrase.c (main) [W32]: Replace the explicit Winsocket
574 init by a call to pth_init.
576 * trustlist.c (initialize_module_trustlist): New.
577 * gpg-agent.c (main): Call it.
579 * call-pinentry.c (initialize_module_query): Rename to
580 initialize_module_call_pinentry.
582 * minip12.c: Remove iconv.h. Add utf8conf.h. Changed all iconv
583 calss to use these jnlib wrappers.
585 2007-06-06 Werner Koch <wk@g10code.com>
587 * minip12.c (enum): Rename CONTEXT to ASNCONTEXT as winnt.h
588 defines such a symbol to access the process context.
590 * call-pinentry.c (dump_mutex_state) [W32]: Handle the W32Pth case.
591 * call-scd.c (dump_mutex_state): Ditto.
593 * protect-tool.c (i18n_init): Remove.
594 * preset-passphrase.c (i18n_init): Remove.
595 * gpg-agent.c (i18n_init): Remove.
597 2007-05-19 Marcus Brinkmann <marcus@g10code.de>
599 * protect-tool.c (get_passphrase): Free ORIG_CODESET on error.
601 2007-05-14 Werner Koch <wk@g10code.com>
603 * protect.c (make_shadow_info): Replace sprintf by smklen.
605 2007-04-20 Werner Koch <wk@g10code.com>
607 * gpg-agent.c (my_gcry_logger, my_gcry_outofcore_handler): Removed.
608 (main): Call the setup_libgcrypt_logging helper.
609 * protect-tool.c (my_gcry_logger): Removed.
610 (main): Call the setup_libgcrypt_logging helper.
612 2007-04-03 Werner Koch <wk@g10code.com>
614 * trustlist.c (read_trustfiles): Take a missing trustlist as an
617 2007-03-20 Werner Koch <wk@g10code.com>
619 * protect-tool.c: New option --p12-charset.
620 * minip12.c (p12_build): Implement it.
622 2007-03-19 Werner Koch <wk@g10code.com>
624 * minip12.c: Include iconv.h.
625 (decrypt_block): New.
626 (parse_bag_encrypted_data, parse_bag_data): Use it here.
627 (bag_data_p, bag_decrypted_data_p): New helpers.
629 2007-03-06 Werner Koch <wk@g10code.com>
631 * gpg-agent.c (main) <gpgconf>: Add entries for all ttl options.
633 2007-02-20 Werner Koch <wk@g10code.com>
635 * call-pinentry.c (start_pinentry): Fix for OS X to allow loading
636 of the bundle. Tested by Benjamin Donnachie.
638 2007-02-14 Werner Koch <wk@g10code.com>
640 * gpg-agent.c: New option --pinentry-touch-file.
641 (get_agent_socket_name): New.
642 * agent.h (opt): Add pinentry_touch_file.
643 * call-pinentry.c (start_pinentry): Send new option to the
646 2007-01-31 Moritz Schulte <moritz@g10code.com> (wk)
648 * command-ssh.c (stream_read_string): Initialize LENGTH to zero.
649 (start_command_handler_ssh): Use es_fgetc/es_ungetc to check if
650 EOF has been reached before trying to process another request.
652 2007-01-31 Werner Koch <wk@g10code.com>
654 * command-ssh.c (start_command_handler_ssh):
656 * Makefile.am (t_common_ldadd): Add LIBICONV.
658 2007-01-25 Werner Koch <wk@g10code.com>
660 * genkey.c (check_passphrase_constraints): Get ngettext call right
661 and use UTF-8 aware strlen.
663 * protect-tool.c (get_passphrase): New arg OPT_CHECK.
664 (get_new_passphrase): Enable OPT_CHECK on the first call.
665 * command.c (cmd_get_passphrase): Implement option --check.
667 2007-01-24 Werner Koch <wk@g10code.com>
669 * gpg-agent.c (MIN_PASSPHRASE_LEN): New
670 (parse_rereadable_options): New option --min-passphrase-len.
671 * genkey.c (check_passphrase_constraints): New.
672 (agent_genkey, agent_protect_and_store): Call new function. Fix
675 * call-pinentry.c (agent_askpin): Allow translation of the displayed
677 (agent_popup_message_start): Remove arg CANCEL_BTN.
678 (popup_message_thread): Use --one-button option.
680 * command.c (cmd_passwd): Now that we don't distinguish between
681 assuan and regular error codes we can jump to the end on error.
683 2006-12-07 David Shaw <dshaw@jabberwocky.com>
685 * Makefile.am: Link to iconv for jnlib dependency.
687 2006-11-20 Werner Koch <wk@g10code.com>
689 * call-pinentry.c (agent_popup_message_stop): Use SIGKILL.
690 * call-scd.c (inq_needpin): Implement POPUPKEYPADPROMPT and
693 2006-11-15 Werner Koch <wk@g10code.com>
695 * protect.c (make_shadow_info): Cast printf arg to unsigned int.
696 * minip12.c (parse_bag_encrypted_data): Ditto.
697 (parse_bag_data, p12_parse): Ditto.
698 * command-ssh.c (ssh_identity_register): Changed buffer_n to
701 * agent.h (struct server_control_s): New field thread_startup.
702 * command.c (start_command_handler): Moved CTRL init code to ..
703 * gpg-agent.c (start_connection_thread): .. here.
704 (agent_deinit_default_ctrl): New.
705 (agent_init_default_ctrl): Made static.
706 (handle_connections): Allocate CTRL and pass it pth_spawn.
707 * command-ssh.c (start_command_handler_ssh): Moved CTRL init code
709 * gpg-agent.c (start_connection_thread_ssh): .. here.
711 2006-11-14 Werner Koch <wk@g10code.com>
713 * command.c (bump_key_eventcounter): New.
714 (bump_card_eventcounter): New.
715 (cmd_geteventcounter): New command.
716 * gpg-agent.c (handle_signal): Call bump_card_eventcounter.
717 * findkey.c (agent_write_private_key): Call bump_key_eventcounter.
718 * trustlist.c (agent_reload_trustlist): Ditto.
720 * command.c (post_cmd_notify, io_monitor): New.
721 (register_commands, start_command_handler): Register them.
723 2006-11-09 Werner Koch <wk@g10code.com>
725 * gpg-agent.c (main): In detached mode connect standard
726 descriptors to /dev/null.
728 * trustlist.c (read_trustfiles): Make sure not to pass a zero size
729 to realloc as the C standards says that this behaves like free.
731 2006-11-06 Werner Koch <wk@g10code.com>
733 * protect-tool.c (my_strusage): Fixed typo.
735 2006-10-23 Werner Koch <wk@g10code.com>
737 * gpg-agent.c (main): New command --gpgconf-test.
739 * minip12.c (parse_bag_encrypted_data, parse_bag_data): Allow for
742 2006-10-20 Werner Koch <wk@g10code.com>
744 * Makefile.am (t_common_ldadd): Use GPG_ERROR_LIBS instead -o just -l
746 2006-10-19 Werner Koch <wk@g10code.com>
748 * findkey.c (unprotect): Use it to avoid unnecessary calls to
750 * call-pinentry.c (pinentry_active_p): New.
752 2006-10-17 Werner Koch <wk@g10code.com>
754 * Makefile.am (gpg_agent_LDADD): Link to libcommonpth.
755 (gpg_agent_CFLAGS): New. This allows to only link this with Pth.
757 2006-10-16 Werner Koch <wk@g10code.com>
759 * call-pinentry.c (agent_get_confirmation): Map Cancel code here too.
760 * trustlist.c (agent_marktrusted): Return Cancel instead of
761 Not_Confirmed for the first question.
763 2006-10-12 Werner Koch <wk@g10code.com>
765 * protect-tool.c (get_passphrase): Fix if !HAVE_LANGINFO_CODESET.
767 2006-10-06 Werner Koch <wk@g10code.com>
769 * Makefile.am (AM_CFLAGS): Use PTH version of libassuan.
770 (gpg_agent_LDADD): Ditto.
772 * divert-scd.c (divert_pksign): Use PKAUTH for the TLS algo.
774 2006-10-05 Werner Koch <wk@g10code.com>
776 * command.c (has_option_name): New.
777 (cmd_sethash): New --hash option.
778 * pksign.c (do_encode_raw_pkcs1): New.
779 (agent_pksign_do): Use it here for the TLS algo.
780 * agent.h (GCRY_MD_USER_TLS_MD5SHA1): New.
781 * divert-scd.c (pksign): Add case for tls-md5sha1.
783 * divert-scd.c (encode_md_for_card): Check that the algo is valid.
785 2006-10-04 Werner Koch <wk@g10code.com>
787 * call-pinentry.c (agent_get_passphrase): Changed to return the
788 unencoded passphrase.
789 (agent_askpin, agent_get_passphrase, agent_get_confirmation): Need
790 to map the cancel error.
791 * command.c (send_back_passphrase): New.
792 (cmd_get_passphrase): Use it here. Also implement --data option.
795 2006-09-26 Werner Koch <wk@g10code.com>
797 * learncard.c (agent_handle_learn): Send back the keypair
800 2006-09-25 Werner Koch <wk@g10code.com>
802 * trustlist.c (read_one_trustfile): Allow extra flags.
803 (struct trustitem_s): Replaced KEYFLAGS by a FLAGS struct.
804 Changed all code to use this.
805 (agent_istrusted): New arg CTRL. Changed all callers. Send back
807 * command.c (agent_write_status): New.
809 2006-09-20 Werner Koch <wk@g10code.com>
811 * Makefile.am: Changes to allow parallel make runs.
813 2006-09-15 Werner Koch <wk@g10code.com>
815 * trustlist.c: Entirely rewritten.
816 (agent_trustlist_housekeeping): Removed and removed all calls.
818 2006-09-14 Werner Koch <wk@g10code.com>
820 Replaced all call gpg_error_from_errno(errno) by
821 gpg_error_from_syserror().
823 * call-pinentry.c (start_pinentry): Replaced pipe_connect2 by
825 * call-scd.c (start_scd): Ditto.
826 * command.c (start_command_handler): Replaced
827 init_connected_socket_server by init_socket_server_ext.
829 2006-09-13 Werner Koch <wk@g10code.com>
831 * preset-passphrase.c (main) [W32]: Check for WSAStartup error.
833 2006-09-08 Werner Koch <wk@g10code.com>
835 * call-scd.c: Add signal.h as we are referencing SIGUSR2.
837 2006-09-06 Marcus Brinkmann <marcus@g10code.de>
839 * Makefile.am (AM_CFLAGS): Add $(GPG_ERR_CFLAGS).
840 (gpg_agent_LDADD): Replace -lgpg-error with $(GPG_ERROR_LIBS).
842 2006-09-06 Werner Koch <wk@g10code.com>
844 * query.c: Renamed to ..
845 * call-pinentry.c: .. this.
847 * agent.h (out_of_core): Removed.
848 (CTRL): Removed and changed everywhere to ctrl_t.
850 Replaced all Assuan error codes by libgpg-error codes. Removed
851 all map_to_assuan_status and map_assuan_err.
853 * gpg-agent.c (main): Call assuan_set_assuan_err_source to have Assuan
854 switch to gpg-error codes.
855 * command.c (set_error): Adjusted.
857 2006-09-04 Werner Koch <wk@g10code.com>
859 * command.c (percent_plus_unescape): New.
860 (cmd_get_val, cmd_putval): New.
862 2006-08-29 Werner Koch <wk@g10code.com>
864 * command-ssh.c (stream_read_mpi): Sanity check for early
865 detecting of too large keys.
866 * gpg-agent.c (my_gcry_outofcore_handler): New.
868 (main): No allocate 32k secure memory (was 16k).
870 2006-07-31 Werner Koch <wk@g10code.com>
872 * preset-passphrase.c (make_hexstring): For consistency use
873 xtrymalloc and changed caller to use xfree. Fixed function
876 2006-07-29 Marcus Brinkmann <marcus@g10code.de>
878 * preset-passphrase.c (preset_passphrase): Do not strip off last
879 character of passphrase.
880 (make_hexstring): New function.
881 * command.c (cmd_preset_passphrase): Use parse_hexstring to syntax
882 check passphrase argument. Truncate passphrase at delimiter.
884 2006-07-24 Werner Koch <wk@g10code.com>
886 * minip12.c (build_key_bag): New args SHA1HASH and
887 KEYIDSTR. Append bag Attributes if these args are given.
888 (build_cert_sequence): ditto.
889 (p12_build): Calculate certificate hash and pass to build
892 2006-07-21 Werner Koch <wk@g10code.com>
894 * minip12.c (oid_pkcs_12_keyBag): New.
895 (parse_bag_encrypted_data): New arg R_RESULT. Support keybags and
896 return the key object.
897 (p12_parse): Take new arg into account. Free RESULT on error.
899 2006-06-26 Werner Koch <wk@g10code.com>
901 * gpg-agent.c (handle_signal): Print info for SIGUSR2 only in
904 2006-06-22 Werner Koch <wk@g10code.com>
906 * command-ssh.c (make_cstring): Use memcpy instead of strncpy.
907 (ssh_receive_mpint_list, sexp_key_extract, data_sign): Use
908 xtrycalloc instead of xtrymalloc followed by memset.
910 2006-06-20 Werner Koch <wk@g10code.com>
912 * minip12.c (create_final): New arg PW. Add code to calculate the
915 2006-06-09 Marcus Brinkmann <marcus@g10code.de>
917 * Makefile.am (gpg_agent_LDADD): Add $(NETLIBS).
918 (gpg_protect_tool_LDADD): Likewise.
919 (gpg_preset_passphrase_LDADD): Likewise.
921 2006-04-09 Moritz Schulte <moritz@g10code.com>
923 * command-ssh.c (ssh_request_process): Removed FIXME mentioning a
926 2006-04-01 Moritz Schulte <moritz@g10code.com>
928 * command-ssh.c (ssh_identity_register): Make KEY_GRIP_RAW be 20
929 instead of 21 bytes long; do not fill KEY_GRIP_RAW[20] with NUL
930 byte - KEY_GRIP_RAW is a raw binary string anyway.
932 2006-02-09 Werner Koch <wk@g10code.com>
934 * call-scd.c (struct scd_local_s): New field next_local.
935 (scd_local_list): New.
936 (start_scd): Put new local into list.
937 (agent_reset_scd): Remove it from the list.
938 (agent_scd_check_aliveness): Here is the actual reason why we need
940 (agent_reset_scd): Send the new command RESTART instead of RESET.
942 2005-12-16 Werner Koch <wk@g10code.com>
944 * minip12.c (cram_octet_string): New
945 (p12_parse): Use it for NDEFed bags.
946 (parse_bag_data): Ditto.
947 (string_to_key, set_key_iv, crypt_block): New arg SALTLEN.
948 (p12_build): Use old value 8 for new arg.
949 (parse_bag_encrypted_data, parse_bag_data): Allow for salts of 8
950 to 16 bytes. Add new arg R_CONSUMED.
952 2005-11-24 Werner Koch <wk@g10code.com>
954 * minip12.c (p12_parse): Fixed for case that the key object comes
955 prior to the certificate.
957 2005-10-19 Werner Koch <wk@g10code.com>
959 * divert-scd.c (getpin_cb): Hack to use it for a keypad message.
961 * call-scd.c (inq_needpin): Reworked to support the new KEYPADINFO.
963 * query.c (start_pinentry): Keep track of the owner.
964 (popup_message_thread, agent_popup_message_start)
965 (agent_popup_message_stop, agent_reset_query): New.
966 * command.c (start_command_handler): Make sure a popup window gets
969 2005-10-08 Marcus Brinkmann <marcus@g10code.de>
971 * Makefile.am (gpg_protect_tool_LDADD): Add ../gl/libgnu.a.
972 (gpg_preset_passphrase_LDADD, t_common_ldadd): Likewise.
973 (gpg_agent_LDADD): Add ../gl/libgnu.a after ../common/libcommon.a.
975 2005-09-16 Werner Koch <wk@g10code.com>
977 * minip12.c (build_key_sequence, build_cert_sequence): Fixed
980 2005-09-15 Moritz Schulte <moritz@g10code.com>
982 * t-protect.c (test_agent_protect): Implemented.
983 (main): Disable use of secure memory.
985 2005-09-09 Werner Koch <wk@g10code.com>
987 * minip12.c (p12_build): Oops, array needs to be larger for the
989 (build_cert_bag): Fixed yesterdays change.
991 * command-ssh.c (card_key_available): Let the card handler decide
992 whether the card is supported here. Also get a short serial
993 number to return from the card handler.
995 2005-09-08 Werner Koch <wk@g10code.com>
997 * minip12.c (build_cert_bag): Use a non constructed object.
998 i.e. 0x80 and not 0xa0.
1000 2005-08-16 Werner Koch <wk@g10code.com>
1002 * gpg-agent.c (main): Use a default file name for --write-env-file.
1004 2005-07-25 Werner Koch <wk@g10code.com>
1006 * findkey.c (agent_public_key_from_file): Fixed array assignment.
1007 This was the cause for random segvs.
1009 2005-06-29 Werner Koch <wk@g10code.com>
1011 * command-ssh.c (data_sign): Removed empty statement.
1013 2005-06-21 Werner Koch <wk@g10code.com>
1015 * minip12.c (create_final): Cast size_t to ulong for printf.
1016 (build_key_bag, build_cert_bag, build_cert_sequence): Ditto.
1018 2005-06-16 Werner Koch <wk@g10code.com>
1020 * protect-tool.c (make_advanced): Makde RESULT a plain char.
1021 * call-scd.c (unescape_status_string): Need to cast unsigned char*
1023 (agent_card_pksign): Made arg R_BUF an unsigned char**.
1024 * divert-scd.c (divert_pksign): Made SIGVAL unsigned char*.
1025 (encode_md_for_card): Initialize R_VAL and R_LEN.
1026 * genkey.c (store_key): Made BUF unsigned.
1027 * protect.c (do_encryption): Ditto.
1028 (do_encryption): Made arg PROTBEGIN unsigned. Initialize RESULT
1029 and RESULTLEN even on error.
1030 (merge_lists): Need to cast unsigned char * for strcpy. Initialize
1031 RESULTand RESULTLEN even on error.
1032 (agent_unprotect): Likewise for strtoul.
1033 (make_shadow_info): Made P and INFO plain char.
1034 (agent_shadow_key): Made P plain char.
1036 2005-06-15 Werner Koch <wk@g10code.com>
1038 * query.c (agent_get_passphrase): Made HEXSTRING a char*.
1039 * command-ssh.c (ssh_key_grip): Made arg BUFFER unsigned.
1040 (ssh_key_grip): Simplified.
1041 (data_sign): Initialize variables with the definition.
1042 (ssh_convert_key_to_blob): Make sure that BLOB and BLOB_SIZE
1043 are set to NULL on error. Cool, gcc-4 detects uninitialized stuff
1044 beyond function boundaries; well it can't know that we do error
1045 proper error handling so that this was not a real error.
1046 (file_to_buffer): Likewise for BUFFER and BUFFER_N.
1047 (data_sign): Likewise for SIG and SIG_N.
1048 (stream_read_byte): Set B to a value even on error.
1049 * command.c (cmd_genkey): Changed VALUE to char.
1050 (cmd_readkey): Cast arg for gcry_sexp_sprint.
1051 * agent.h (struct server_control_s): Made KEYGRIP unsigned.
1053 2005-06-13 Werner Koch <wk@g10code.com>
1055 * command-ssh.c (start_command_handler_ssh): Reset the SCD.
1057 2005-06-09 Werner Koch <wk@g10code.com>
1059 * gpg-agent.c (create_socket_name): New option --max-cache-ttl-ssh.
1060 * cache.c (housekeeping): Use it.
1061 (agent_put_cache): Use a switch to get the default ttl so that it
1062 is easier to add more cases.
1064 2005-06-06 Werner Koch <wk@g10code.com>
1066 * gpg-agent.c: New option --default-cache-ttl-ssh.
1067 * agent.h (cache_mode_t): New.
1068 * pksign.c (agent_pksign_do): New arg CACHE_MODE to replace the
1069 ARG IGNORE_CACHE. Changed all callers.
1070 (agent_pksign): Ditto.
1071 * findkey.c (agent_key_from_file): Ditto. Canged all callers.
1073 * command-ssh.c (data_sign): Use CACHE_MODE_SSH.
1074 * cache.c (agent_get_cache): New arg CACHE_MODE.
1075 (agent_put_cache): Ditto. Store it in the cache.
1077 * query.c (agent_query_dump_state, dump_mutex_state): New.
1078 (unlock_pinentry): Reset the global context before releasing the
1080 * gpg-agent.c (handle_signal): Dump query.c info on SIGUSR1.
1082 * call-scd.c (agent_scd_check_aliveness): Always do a waitpid and
1083 add a timeout to the locking.
1085 2005-06-03 Werner Koch <wk@g10code.com>
1087 * command.c (cmd_updatestartuptty): New.
1089 * gpg-agent.c: New option --write-env-file.
1091 * gpg-agent.c (handle_connections): Make sure that the signals we
1092 are handling are not blocked.Block signals while creating new
1095 2005-06-02 Werner Koch <wk@g10code.com>
1097 * call-scd.c (agent_scd_dump_state, dump_mutex_state): New.
1098 * gpg-agent.c (handle_signal): Print it on SIGUSR1.
1099 (handle_connections): Include the file descriptor into the
1102 2005-06-01 Werner Koch <wk@g10code.com>
1104 * gpg-agent.c: Include setenv.h.
1106 2005-05-31 Werner Koch <wk@g10code.com>
1108 * agent.h (out_of_core): s/__inline__/inine. Noted by Ray Link.
1110 2005-05-25 Werner Koch <wk@g10code.com>
1112 * gpg-agent.c (main): Do not unset the DISPLAY when we are
1113 continuing as child.
1115 2005-05-24 Werner Koch <wk@g10code.com>
1117 * call-scd.c (inq_needpin): Skip leading spaces in of PIN
1119 * divert-scd.c (getpin_cb): Enhanced to cope with description
1121 * query.c (agent_askpin): Add arg PROMPT_TEXT. Changed all
1124 2005-05-21 Werner Koch <wk@g10code.com>
1126 * call-scd.c (start_scd): Don't test for an alive scdaemon here.
1127 (agent_scd_check_aliveness): New.
1128 * gpg-agent.c (handle_tick): Test for an alive scdaemon.
1129 (handle_signal): Print thread info on SIGUSR1.
1131 2005-05-20 Werner Koch <wk@g10code.com>
1133 * protect-tool.c: New option --canonical.
1134 (show_file): Implement it.
1136 * keyformat.txt: Define the created-at attribute for keys.
1138 2005-05-18 Werner Koch <wk@g10code.com>
1140 * divert-scd.c (ask_for_card): Removed the card reset kludge.
1142 2005-05-17 Werner Koch <wk@g10code.com>
1144 * call-scd.c (unlock_scd): Add new arg CTRL. Changed all callers.
1145 (start_scd): Reoworked to allow for additional connections.
1146 * agent.h (ctrl_t): Add local data for the SCdaemon.
1147 * command.c (start_command_handler): Release SERVER_LOCAL.
1149 * gpg-agent.c (create_server_socket): Use xmalloc.
1150 (main): Removed option --disable-pth a dummy. Removed non-pth
1152 (cleanup_sh): Removed. Not needed anymore.
1154 2005-05-05 Moritz Schulte <moritz@g10code.com>
1156 * command-ssh.c (ssh_key_to_buffer): Rename to ...
1157 (ssh_key_to_protected_buffer): ... this; change callers.
1158 Improved documentation.
1159 Use ssh_key_grip(), where gcry_pk_get_keygrip() has been used
1161 (ssh_handler_sign_request): Removed unusued variable P.
1163 2005-04-20 Moritz Schulte <moritz@g10code.com>
1165 * command-ssh.c (ssh_handler_request_identities): Removed
1166 debugging code (sleep call), which was commited unintenionally.
1168 2005-04-20 Werner Koch <wk@g10code.com>
1170 * minip12.c (parse_bag_encrypted_data): Fix the unpadding hack.
1172 * gpg-agent.c: New option --disable-scdaemon.
1173 (handle_connections): Add time event to drive ...
1174 (handle_tick): New function.
1175 (main): Record the parent PID. Fixed segv when using ssh and a
1178 * call-scd.c (start_scd): Take care of this option.
1180 2005-04-03 Moritz Schulte <moritz@g10code.com>
1182 * command-ssh.c (ssh_request_spec): New member: secret_input.
1183 (REQUEST_SPEC_DEFINE): New argument: secret_input.
1184 (request_specs): Add secret_input flag.
1185 (request_spec_lookup): New function ...
1186 (ssh_request_process): ... use it here; depending on secret_input
1187 flag allocate secure or non-secure memory.
1189 2005-03-02 Moritz Schulte <moritz@g10code.com>
1191 * command-ssh.c (sexp_key_extract): Removed FIXME, since
1192 xtrymallos does set errno correctly by now.
1193 (sexp_extract_identifier): Remove const attribute from identifier.
1194 (ssh_handler_request_identities): Remove const attribute from
1195 key_type; removes ugly casts and FIXME.
1196 (sexp_key_extract): Remove const attribute from comment.
1197 (ssh_send_key_public): Remove const attribute from
1198 key_type/comment; removes ugly cast.
1199 (data_sign): Remove const attribute from identifier; removes ugly
1201 (key_secret_to_public): Remove const attribute from comment;
1203 (ssh_handler_sign_request): Remove const attribute from p.
1204 (sexp_key_extract): Use make_cstring().
1205 (ssh_key_extract_comment): Likewise.
1206 (ssh_key_to_buffer): Use secure memory for memory area to hold the
1208 Added more comments.
1210 2005-02-25 Werner Koch <wk@g10code.com>
1212 * findkey.c (modify_description): Keep invalid % escapes, so that
1213 %0A may pass through.
1215 * agent.h (server_control_s): New field USE_AUTH_CALL.
1216 * call-scd.c (agent_card_pksign): Make use of it.
1217 * command-ssh.c (data_sign): Set the flag.
1218 (ssh_send_key_public): New arg OVERRIDE_COMMENT.
1219 (card_key_available): Add new arg CARDSN.
1220 (ssh_handler_request_identities): Use the card s/n as comment.
1221 (sexp_key_extract): Use GCRYMPI_FMT_STD.
1224 * learncard.c (make_shadow_info): Moved to ..
1225 * protect.c (make_shadow_info): .. here. Return NULL on malloc
1226 failure. Made global.
1227 * agent.h: Add prototype.
1229 2005-02-24 Werner Koch <wk@g10code.com>
1231 * call-scd.c (unescape_status_string): New. Actual a copy of
1233 (card_getattr_cb, agent_card_getattr): New.
1235 * command-ssh.c (card_key_available): New.
1236 (ssh_handler_request_identities): First see whether a card key is
1239 * gpg-agent.c (handle_connections): Need to check for events if
1240 select returns with -1.
1242 2005-02-23 Werner Koch <wk@g10code.com>
1244 * command-ssh.c (get_passphrase): Removed.
1245 (ssh_identity_register): Partly rewritten.
1246 (open_control_file, search_control_file, add_control_entry): New.
1247 (ssh_handler_request_identities): Return only files listed in our
1250 * findkey.c (unprotect): Check for allocation error.
1252 * agent.h (opt): Add fields to record the startup terminal
1254 * gpg-agent.c (main): Record them and do not force keep display
1255 with --enable-ssh-support.
1256 * command-ssh.c (start_command_handler_ssh): Use them here.
1258 * gpg-agent.c: Renamed option --ssh-support to
1259 --enable-ssh-support.
1261 * command.c (cmd_readkey): New.
1262 (register_commands): Register new command "READKEY".
1264 * command-ssh.c (ssh_request_process): Improved logging.
1266 * findkey.c (agent_write_private_key): Always use plain open.
1267 Don't depend on an umask for permissions.
1268 (agent_key_from_file): Factored file reading code out to ..
1269 (read_key_file): .. new function.
1270 (agent_public_key_from_file): New.
1272 2005-02-22 Werner Koch <wk@g10code.com>
1274 * command-ssh.c (stream_read_string): Removed call to abort on
1275 memory error because the CVS version of libgcrypt makes sure
1276 that ERRNO gets always set on error even with a faulty user
1279 2005-02-19 Moritz Schulte <moritz@g10code.com>
1281 * command-ssh.c (ssh_receive_mpint_list): Slightly rewritten, do
1282 not use elems_secret member of key_spec.
1283 (ssh_key_type_spec): Removed member: elems_secret.
1284 (ssh_key_types): Removed elems_secret data.
1285 (ssh_sexp_construct): Renamed to ...
1286 (sexp_key_construct): ... this; changed callers.
1287 (ssh_sexp_extract): Renamed to ...
1288 (sexp_key_extract): ... this; changed callers.
1289 (ssh_sexp_extract_key_type): Renamed to ...
1290 (sexp_extract_identifier): ... this; changed callers; use
1292 Added more comments.
1294 2005-02-18 Moritz Schulte <moritz@g10code.com>
1296 * command-ssh.c (ssh_sexp_construct): Rewritten generation of sexp
1297 template, clarified.
1298 (ssh_sexp_extract): Support shadowed-private-key-sexp; treat
1299 protected-private key and shadowed-private-key as public keys.
1300 (key_secret_to_public): Rewritten: simply use ssh_sexp_extract()
1301 and ssh_sexp_construct().
1303 2005-02-15 Werner Koch <wk@g10code.com>
1305 * findkey.c (modify_description): Don't increment OUT_LEN during
1308 2005-02-14 Moritz Schulte <moritz@g10code.com>
1310 * command-ssh.c (es_read_byte): Renamed to ...
1311 (stream_es_read_byte): ... this; changed callers.
1312 (es_write_byte): Renamed to ...
1313 (stream_write_byte): ... this; changed callers.
1314 (es_read_uint32): Renamed to ...
1315 (stream_read_uint32): ... this; changed callers.
1316 (es_write_uint32): Renamed to ...
1317 (stream_write_uint32): ... this; changed callers.
1318 (es_read_data): Renamed to ...
1319 (stream_read_data): ... this; changed callers.
1320 (es_write_data): Renamed to ...
1321 (stream_write_data): ... this; changed callers.
1322 (es_read_string): Renamed to ...
1323 (stream_read_string): ... this; changed callers.
1324 (es_read_cstring): Renamed to ...
1325 (stream_read_cstring): ... this; changed callers.
1326 (es_write_string): Renamed to ...
1327 (stream_write_string): ... this; changed callers.
1328 (es_write_cstring): Renamed to ...
1329 (stream_write_cstring): ... this; changed callers.
1330 (es_read_mpi): Renamed to ...
1331 (stream_read_mpi): ... this; changed callers.
1332 (es_write_mpi): Renamed to ...
1333 (stream_write_mpi): ... this; changed callers.
1334 (es_copy): Renamed to ...
1335 (stream_copy): ... this; changed callers.
1336 (es_read_file): Renamed to ...
1337 (file_to_buffer): ... this; changed callers.
1338 (ssh_identity_register): Removed variable description_length;
1339 changed code to use asprintf for description.
1340 (stream_write_uint32): Do not filter out the last byte of shift
1342 (uint32_construct): New macro ...
1343 (stream_read_uint32): ... use it; removed unnecessary cast.
1345 2005-02-03 Werner Koch <wk@g10code.com>
1347 * agent.h (agent_exit): Add JNLIB_GCC_A_NR to indicate that this
1348 function won't return.
1350 * gpg-agent.c (check_for_running_agent): Initialize pid to a
1351 default value if not needed.
1353 * command-ssh.c: Removed stdint.h. s/byte_t/unsigned char/,
1354 s/uint32/u32/ becuase that is what we have always used in GnuPG.
1355 (ssh_request_specs): Moved to top of file.
1356 (ssh_key_types): Ditto.
1357 (make_cstring): Ditto.
1358 (data_sign): Don't use a variable for the passphrase prompt, make
1360 (ssh_request_process):
1363 * findkey.c (modify_description): Renamed arguments for clarity,
1364 polished documentation. Make comment a C-string. Fixed case of
1365 DESCRIPTION being just "%".
1366 (agent_key_from_file): Make sure comment string to a C-string.
1368 * gpg-agent.c (create_socket_name): Cleanup the implemntation, use
1369 DIMof, agent_exit, removed superflous args and return the
1370 allocated string as value. Documented. Changed callers.
1371 (create_server_socket): Cleanups similar to above. Changed callers.
1372 (cleanup_do): Renamed to ..
1373 (remove_socket): .. this. Changed caller.
1374 (handle_connections): The signals are to be handled in the select
1375 and not in the accept. Test all FDs after returning from a
1376 select. Remove the event tests from the accept calls. The select
1377 already assured that the accept won't block.
1379 2005-01-29 Moritz Schulte <moritz@g10code.com>
1381 * command-ssh.c (ssh_handler_request_identities)
1382 (ssh_handler_sign_request, ssh_handler_add_identity)
1383 (ssh_handler_remove_identity, ssh_handler_remove_all_identities)
1384 (ssh_handler_lock, ssh_handler_unlock): Changed to return an error
1385 code instead of a boolean.
1386 (ssh_request_process): Changed to return a boolean instead of an
1387 error; adjust caller.
1388 (ssh_request_handle_t): Adjusted type.
1389 (ssh_request_spec): New member: identifier.
1390 (REQUEST_SPEC_DEFINE): New macro; use it for initialization of
1392 (ssh_request_process): In debugging mode, log identifier of
1394 (start_command_handler_ssh): Moved most of the stream handling
1396 (ssh_request_process): ... here.
1398 2005-01-28 Moritz Schulte <moritz@g10code.com>
1400 * command-ssh.c (ssh_handler_add_identity): Pass ctrl to
1401 ssh_identity_register().
1402 (ssh_identity_register): New argument: ctrl; pass ctrl to
1404 (get_passphrase): Pass ctrl instead of NULL to agent_askpin().
1405 (start_command_handler_ssh): Use agent_init_default_ctrl();
1406 deallocate structure members, which might be dynamically
1408 (lifetime_default): Removed variable.
1409 (ssh_handler_add_identity): Fix ttl handling; renamed variable
1411 (ssh_identity_register): Fix key grip handling.
1413 2005-01-26 Moritz Schulte <moritz@g10code.com>
1415 * command-ssh.c (ssh_handler_sign_request): Confirm to agent
1416 protocol in case of failure.
1418 * command-ssh.c: New file.
1420 * Makefile.am (gpg_agent_SOURCES): New source file: command-ssh.c.
1422 * findkey.c (modify_description): New function.
1423 (agent_key_from_file): Support comment field in key s-expressions.
1425 * gpg-agent.c (enum cmd_and_opt_values): New item: oSSHSupport.
1426 (opts) New entry for oSSHSupport.
1427 New variable: socket_name_ssh.
1428 (cleanup_do): New function based on cleanup().
1429 (cleanup): Use cleanup_do() for socket_name and socket_name_ssh.
1430 (main): New switch case for oSSHSupport.
1431 (main): Move socket name creation code to ...
1432 (create_socket_name): ... this new function.
1433 (main): Use create_socket_name() for creating socket names for
1434 socket_name and for socket_name_ssh in case ssh support is
1436 Move socket creation code to ...
1437 (create_server_socket): ... this new function.
1438 (main): Use create_server_socket() for creating sockets.
1439 In case standard_socket is set, do not only store a socket name in
1440 socket_name, but also in socket_name_ssh.
1441 Generate additional environment info strings for ssh support.
1442 Pass additional ssh socket argument to handle_connections.
1443 (start_connection_thread_ssh): New function.
1444 (handle_connections): Use select to multiplex between gpg-agent
1445 and ssh-agent protocol.
1447 * agent.h (struct opt): New member: ssh_support.
1448 (start_command_handler_ssh): Add prototype.
1450 2005-01-04 Werner Koch <wk@g10code.com>
1452 * trustlist.c (agent_marktrusted): Use "Cancel" for the first
1453 confirmation and made the strings translatable.
1455 * cache.c (agent_put_cache): Fix the test for using the default
1458 2004-12-21 Werner Koch <wk@g10code.com>
1460 * preset-passphrase.c (preset_passphrase): Handle --passphrase.
1462 * Makefile.am (gpg_preset_passphrase_LDADD): Reorder libs so that
1463 pwquery may use stuff from jnlib. Conditionally add -lwsock2
1464 (gpg_protect_tool_LDADD): Ditto.
1466 * preset-passphrase.c (main): Use default_homedir().
1467 (main) [W32]: Initialize sockets.
1469 2004-12-21 Marcus Brinkmann <marcus@g10code.de>
1471 * Makefile.am (libexec_PROGRAMS): Add gpg-preset-passphrase.
1472 (gpg_preset_passphrase_SOURCES, gpg_preset_passphrase_LDADD): New
1474 * agent.h (opt): New member allow_cache_passphrase.
1475 * cache.c (housekeeping): Check if R->ttl is not negative.
1476 (agent_put_cache): Allow ttl to be negative.
1477 * command.c (parse_hexstring): Allow something to follow the
1479 (cmd_cache_passphrase): New function.
1480 (register_commands): Add it.
1481 * gpg-agent.c: Handle --allow-preset-passphrase.
1482 * preset-passphrase.c: New file.
1484 2004-12-21 Werner Koch <wk@g10code.com>
1486 * gpg-agent.c (main): Use default_homedir().
1487 * protect-tool.c (main): Ditto.
1489 2004-12-20 Werner Koch <wk@g10code.com>
1491 * gpg-agent.c (main) [W32]: Now that Mutexes work we can remove
1492 the pth_init kludge.
1493 (main): Add new options --[no-]use-standard-socket.
1494 (check_for_running_agent): Check whether it is running on the
1497 * call-scd.c (init_membuf, put_membuf, get_membuf): Removed. We
1498 now use the identical implementation from ../common/membuf.c.
1500 * pksign.c (agent_pksign): Changed arg OUTFP to OUTBUF and use
1501 membuf functions to return the value.
1502 * pkdecrypt.c (agent_pkdecrypt): Ditto.
1503 * genkey.c (agent_genkey): Ditto.
1504 * command.c (cmd_pksign, cmd_pkdecrypt, cmd_genkey): Replaced
1505 assuan_get_data_fp() by a the membuf scheme.
1506 (clear_outbuf, write_and_clear_outbuf): New.
1508 2004-12-19 Werner Koch <wk@g10code.com>
1510 * query.c (initialize_module_query): New.
1511 * call-scd.c (initialize_module_call_scd): New.
1512 * gpg-agent.c (main): Call them.
1514 2004-12-18 Werner Koch <wk@g10code.com>
1516 * gpg-agent.c (main): Remove special Pth initialize.
1518 * agent.h (map_assuan_err): Define in terms of
1519 map_assuan_err_with_source.
1521 2004-12-17 Moritz Schulte <moritz@g10code.com>
1523 * query.c: Undo change from 2004-12-05.
1525 2004-12-15 Werner Koch <wk@g10code.com>
1527 * gpg-agent.c [W32]: Various hacks to make it work.
1529 * findkey.c (agent_write_private_key) [W32]: Adjust open call.
1531 * call-scd.c (start_scd) [W32]: Don't check whether the daemon
1532 didn't died. To hard to do under Windows.
1533 (start_scd) [W32]: Disable sending of the event signal option.
1535 * protect-tool.c (read_file, export_p12_file) [W32]: Use setmode
1536 to get stdout and stin into binary mode.
1538 2004-12-05 Moritz Schulte <moritz@g10code.com>
1540 * query.c (start_pinentry): Allow CTRL be NULL.
1542 2004-10-22 Werner Koch <wk@g10code.com>
1544 * gpg-agent.c (parse_rereadable_options): Return "not handled"
1545 when the log file has not beend hadled. This is will let the main
1546 option processing continue. Fixed a bug introduced on 2004-09-4
1547 resulting in logging to stderr until a HUP has been given.
1548 (main): Don't close the listen FD.
1550 2004-09-30 Werner Koch <wk@g10code.com>
1552 * Makefile.am: Adjusted from gettext 1.14.
1554 2004-09-29 Werner Koch <wk@g10code.com>
1556 * minip12.c (parse_bag_encrypted_data): Print error if a bad
1557 passphrase has been given.
1559 2004-09-28 Werner Koch <wk@g10code.com>
1561 * protect.c (agent_unprotect): Fixed wiping of CLEARTEXT. Thanks
1562 to Moritz for pointing this out.
1564 2004-09-25 Moritz Schulte <moritz@g10code.com>
1566 * agent.h: Declare: agent_pksign_do.
1567 (struct server_control_s): New member: raw_value.
1569 * pksign.c (do_encode_md): New argument: raw_value; support
1570 generation of raw (non-pkcs1) data objects; adjust callers.
1571 (agent_pksign_do): New function, based on code ripped
1572 out from agent_pksign.
1573 (agent_pksign): Use agent_pksign_do.
1575 * command.c (start_command_handler): Set ctrl.digest.raw_value.
1577 2004-09-09 Werner Koch <wk@g10code.de>
1579 * gpg-agent.c (check_for_running_agent): New.
1580 (main): The default action is now to check for an already running
1582 (parse_rereadable_options): Set logfile only on reread.
1583 (main): Do not print the "is development version" note.
1585 2004-08-20 Werner Koch <wk@g10code.de>
1587 * gpg-agent.c: New option --max-cache-ttl. Suggested by Alexander
1589 * cache.c (housekeeping): Use it here instead of the hardwired
1592 * query.c (start_pinentry): Use a timeout for the pinentry lock.
1594 2004-08-18 Werner Koch <wk@g10code.de>
1596 * protect-tool.c (get_passphrase): Make sure that the default
1597 prompts passed to gpg-agent are utf-8 encoded. Add new prompt values.
1598 (import_p12_file, import_p12_file, export_p12_file): Changed calls
1599 to get_passphrase so that better prompts are displayed.
1600 (get_new_passphrase): New.
1602 2004-07-22 Werner Koch <wk@g10code.de>
1604 * trustlist.c (read_list): Allow colons in the fingerprint.
1605 (headerblurb): Rephrased.
1607 * gpg-agent.c (handle_connections): Increase the stack size ot 256k.
1609 2004-06-20 Moritz Schulte <moritz@g10code.com>
1611 * gpg-agent.c: Include <sys/stat.h> (build fix for BSD).
1613 2004-05-11 Werner Koch <wk@gnupg.org>
1615 * gpg-agent.c (handle_signal): Reload the trustlist on SIGHUP.
1616 (start_connection_thread): Hack to simulate a ticker.
1617 * trustlist.c (agent_trustlist_housekeeping)
1618 (agent_reload_trustlist): New. Protected all global functions
1619 here with a simple counter which is sufficient for Pth.
1621 2004-05-03 Werner Koch <wk@gnupg.org>
1623 * gpg-agent.c: Remove help texts for options lile --lc-ctype.
1624 (main): New option --allow-mark-trusted.
1625 * trustlist.c (agent_marktrusted): Use it here.
1627 2004-04-30 Werner Koch <wk@gnupg.org>
1629 * protect-tool.c: New option --enable-status-msg.
1630 (store_private_key): Print status messages for imported keys.
1631 (read_and_unprotect): Ditto for bad passphrase.
1633 * gpg-agent.c (parse_rereadable_options): New arg REREAD. Allow
1635 (current_logfile): New.
1637 2004-04-26 Werner Koch <wk@gnupg.org>
1639 * call-scd.c (start_scd): Do not register an event signal if we
1640 are running as a pipe server.
1642 2004-04-21 Werner Koch <wk@gnupg.org>
1644 * call-scd.c (start_scd): Send event-signal option. Always check
1645 that the scdaemon is still running.
1647 * gpg-agent.c (handle_signal): Do not use SIGUSR{1,2} anymore for
1648 changing the verbosity.
1650 2004-04-16 Werner Koch <wk@gnupg.org>
1652 * gpg-agent.c (main): Tell the logging code that we are running
1655 2004-04-06 Werner Koch <wk@gnupg.org>
1657 * gpg-agent.c (main): Use new libgcrypt thread library register
1660 2004-03-23 Marcus Brinkmann <marcus@g10code.de>
1662 * gpg-agent.c (main): For now, always print the default config
1663 file name for --gpgconf-list.
1665 2004-03-17 Werner Koch <wk@gnupg.org>
1667 * gpg-agent.c (main) <gpgconf>: Fixed default value quoting.
1669 2004-03-16 Werner Koch <wk@gnupg.org>
1671 * gpg-agent.c (parse_rereadable_options): Use the new
1672 DEFAULT_CACHE_TTL macro.
1673 (main): Updated --gpgconf-list output.
1675 2004-02-21 Werner Koch <wk@gnupg.org>
1677 * command.c (cmd_passwd): Take acount of a key description.
1679 * genkey.c (reenter_compare_cb): Do not set the error text.
1680 (agent_protect_and_store, agent_genkey): Force a re-enter after a
1681 non-matching passphrase.
1682 * query.c (agent_askpin): Add new arg INITIAL_ERRTEXT; changed
1685 2004-02-19 Werner Koch <wk@gnupg.org>
1687 * protect-tool.c: New options --have-cert and --prompt.
1688 (export_p12_file): Read a certificate from STDIN and pass it to
1689 p12_build. Detect a keygrip and construct the filename in that
1690 case. Unprotcet a key if needed. Print error messages for key
1691 formats we can't handle.
1692 (release_passphrase): New.
1693 (get_passphrase): New arg PROMPTNO. Return the allocated
1694 string. Changed all callers.
1696 * minip12.c: Revamped the build part.
1697 (p12_build): New args CERT and CERTLEN.
1699 2004-02-18 Werner Koch <wk@gnupg.org>
1701 * protect-tool.c (main): Setup the used character set.
1702 * gpg-agent.c (main): Ditto.
1704 * gpg-agent.c (set_debug): New. New option --debug-level.
1705 (main): New option --gpgconf-list.
1707 2004-02-17 Werner Koch <wk@gnupg.org>
1709 * pksign.c (do_encode_md): Cleaned up by using gcry_sexp_build.
1711 * Makefile.am (gpg_protect_tool_SOURCES): Removed
1712 simple-pwquery.[ch], as we once moved it to ../common.
1714 2004-02-13 Werner Koch <wk@gnupg.org>
1716 * command.c (cmd_setkeydesc): New.
1717 (register_commands): Add command SETKEYDESC.
1718 (cmd_pksign, cmd_pkdecrypt): Use the key description.
1719 (reset_notify): Reset the description.
1720 * findkey.c (unprotect): Add arg DESC_TEXT.
1721 (agent_key_from_file): Ditto.
1722 * pksign.c (agent_pksign): Ditto.
1723 * pkdecrypt.c (agent_pkdecrypt): Ditto. Made CIPHERTEXT an
1726 * protect-tool.c (main): New options --no-fail-on-exist, --homedir.
1727 (store_private_key): Use them here.
1729 2004-02-12 Werner Koch <wk@gnupg.org>
1731 * protect-tool.c (read_file, main): Allow reading from stdin.
1733 * Makefile.am: Include cmacros.am for common flags.
1734 (libexec_PROGRAMS): Put gpg-protect-tool there.
1736 2004-02-10 Werner Koch <wk@gnupg.org>
1738 * minip12.c (parse_bag_encrypted_data): Finished implementation.
1739 (p12_parse): Add callback args.
1740 * protect-tool.c (import_p12_cert_cb): New.
1741 (import_p12_file): Use it.
1743 2004-02-06 Werner Koch <wk@gnupg.org>
1745 * minip12.c (crypt_block): Add arg CIPHER_ALGO; changed all callers.
1746 (set_key_iv): Add arg KEYBYTES; changed caller.
1748 2004-02-03 Werner Koch <wk@gnupg.org>
1750 * findkey.c (agent_key_from_file): Extra paranoid wipe.
1751 * protect.c (agent_unprotect): Ditto.
1752 (merge_lists): Ditto. Add arg RESULTLEN.
1753 * pkdecrypt.c (agent_pkdecrypt): Don't show the secret key even in
1756 * protect.c: Add DSA and Elgamal description.
1758 2004-01-29 Werner Koch <wk@gnupg.org>
1760 * agent.h (server_control_s): Add connection_fd field.
1761 * command.c (start_command_handler): Init it here.
1762 * gpg-agent.c (agent_init_default_ctrl): and here.
1763 * call-scd.c: Add the CTRL arg to all functions calling start_scd
1764 and pass it to start_scd. Changed all callers
1765 (start_scd): Keep track of the current active connection.
1766 (agent_reset_scd): New.
1767 * command.c (start_command_handler): Call it here.
1768 * learncard.c (agent_handle_learn): Add arg CTRL; changed caller.
1769 (send_cert_back): Ditto.
1771 2004-01-28 Werner Koch <wk@gnupg.org>
1773 * trustlist.c (agent_marktrusted): Check whether the trustlist is
1776 2004-01-27 Werner Koch <wk@gnupg.org>
1778 * sexp-parse.h: Moved to ../common.
1780 2004-01-24 Werner Koch <wk@gnupg.org>
1782 * call-scd.c (atfork_cb): New.
1783 (start_scd): Make sure secmem gets cleared.
1784 * query.c (atfork_cb): New.
1785 (start_pinentry): Make sure secmem gets cleared.
1787 2004-01-16 Werner Koch <wk@gnupg.org>
1789 * findkey.c (agent_key_from_file): Now return an error code so
1790 that we have more detailed error messages in the upper layers.
1791 This fixes the handling of pinentry's cancel button.
1792 * pksign.c (agent_pksign): Changed accordingly.
1793 * pkdecrypt.c (agent_pkdecrypt): Ditto.
1794 * command.c (cmd_passwd): Ditto.
1796 2003-12-16 Werner Koch <wk@gnupg.org>
1798 * gpg-agent.c (main): Set the prefixes for assuan logging.
1800 2003-12-15 Werner Koch <wk@gnupg.org>
1802 * protect.c (do_encryption): Use gcry_create_nonce instad of the
1803 obsolete WEAK_RANDOM.
1805 2003-11-20 Werner Koch <wk@gnupg.org>
1807 * sexp-parse.h (snext): Don't use atoi_1 and digitp macros, so
1808 that this file is useful by other applications too.
1810 2003-10-27 Werner Koch <wk@gnupg.org>
1812 * command.c (cmd_get_confirmation): New command.
1814 2003-08-20 Timo Schulz <twoaday@freakmail.de>
1816 * pksign.c (do_encode_md): Allocate enough space. Cast md
1817 byte to unsigned char to prevent sign extension.
1819 2003-08-14 Timo Schulz <twoaday@freakmail.de>
1821 * pksign.c (do_encode_md): Due to the fact pkcs#1 padding
1822 is now in Libgcrypt, use the new interface.
1824 2003-07-31 Werner Koch <wk@gnupg.org>
1826 * Makefile.am (gpg_agent_LDADD): Added INTLLIBS.
1827 (gpg_protect_tool_SOURCES): Added simple-pwquery.[ch]
1829 2003-07-27 Werner Koch <wk@gnupg.org>
1831 Adjusted for gcry_mpi_print and gcry_mpi_scan API change.
1833 2003-07-15 Werner Koch <wk@gnupg.org>
1835 * simple-pwquery.c, simple-pwquery.h: Moved to ../common.
1836 * Makefile.am (gpg_protect_tool_LDADD): Add simple-pwquery.o.
1837 Removed it from xx_SOURCES.
1839 2003-07-04 Werner Koch <wk@gnupg.org>
1841 * gpg-agent.c (handle_connections): Kludge to allow use of Pth 1
1844 2003-06-30 Werner Koch <wk@gnupg.org>
1846 * call-scd.c (learn_status_cb): Store the serialno in PARM.
1848 2003-06-26 Werner Koch <wk@gnupg.org>
1850 * call-scd.c (agent_card_serialno): Don't do a RESET anymore.
1852 2003-06-25 Werner Koch <wk@gnupg.org>
1854 * command.c (cmd_scd): New.
1855 * call-scd.c (agent_card_scd): New.
1856 * divert-scd.c (divert_generic_cmd): New
1858 * call-scd.c (agent_card_learn): New callback args SINFO.
1859 (learn_status_cb): Pass all other status lines to the sinfo
1861 * learncard.c (release_sinfo, sinfo_cb): New.
1862 (agent_handle_learn): Pass the new cb to the learn function and
1863 pass the collected information back to the client's assuan
1866 * gpg-agent.c (main): Moved pth_init before gcry_check_version.
1868 2003-06-24 Werner Koch <wk@gnupg.org>
1870 * gpg-agent.c (handle_connections): Adjusted for Pth 2.0
1872 Adjusted for changes in the libgcrypt API. Some more fixes for the
1875 2003-06-04 Werner Koch <wk@gnupg.org>
1877 Renamed error codes from INVALID to INV and removed _ERROR suffixes.
1879 2003-06-03 Werner Koch <wk@gnupg.org>
1881 Changed all error codes in all files to the new libgpg-error scheme.
1883 * agent.h: Include gpg-error.h and errno.h
1884 * Makefile.am: Link with libgpg-error
1886 * query.c: assuan.h is now a system header.
1887 * genkey.c (agent_genkey): Fixed silly use of xmalloc by
1890 2003-04-29 Werner Koch <wk@gnupg.org>
1892 * command.c (register_commands): Adjusted for new Assuan semantics.
1894 * Makefile.am: Don't override LDFLAGS.
1896 2002-12-04 Werner Koch <wk@gnupg.org>
1898 * gpg-agent.c: New variable config_filename.
1899 (parse_rereadable_options): New.
1900 (main): Use it here. Add setting of default values, set
1902 (reread_configuration): Filled with actual code.
1904 2002-12-03 Werner Koch <wk@gnupg.org>
1906 * protect-tool.c (read_key): Don't run make_canonical on a NULL
1909 * command.c (parse_hexstring): New.
1910 (cmd_sethash): Use it.
1911 (parse_keygrip): New.
1912 (cmd_havekey, cmd_sigkey): Use it.
1914 * genkey.c (agent_protect_and_store): New.
1915 (store_key): Add arg FORCE.
1916 (agent_genkey): Pass false to this force of store_key.
1918 2002-11-13 Werner Koch <wk@gnupg.org>
1920 * gpg-agent.c (main): Switch all messages to utf-8.
1922 * simple-pwquery.c (agent_send_all_options): Use $GPG_TTY and
1925 * cache.c (new_data): Uiih - /sizeof d/sizeof *d/.
1927 2002-11-10 Werner Koch <wk@gnupg.org>
1929 * command.c (option_handler): Fix keep_tty check.
1931 2002-11-06 Werner Koch <wk@gnupg.org>
1933 * gpg-agent.c (main): Make sure we have a default ttyname.
1934 * command.c (option_handler): Check opt.keep_tty here
1935 * query.c (start_pinentry): but not anymore here.
1937 2002-11-05 Werner Koch <wk@gnupg.org>
1939 * agent.h (opt,server_control_s): Move display and lc_ variables
1940 to the control struct so that they are per connection.
1941 * gpg-agent.c (agent_init_default_ctrl): New.
1942 (main): Assign those command line options to new default_* variables.
1943 Reset DISPLAY in server mode so that tehre is no implicit default.
1944 * command.c (start_command_handler): Initialize and deinitialize
1946 (option_handler): Work on the ctrl values and not on the opt.
1947 * query.c (start_pinentry): New argument CTRL to set the display
1948 connection specific. Changed all callers to pass this value.
1949 (agent_askpin,agent_get_passphrase,agent_get_confirmation): Add
1950 CTRL arg and pass it ot start_pinentry.
1951 * command.c (cmd_get_passphrase): Pass CTRL argument.
1952 * trustlist.c (agent_marktrusted): Add CTRL argument
1953 * command.c (cmd_marktrusted): Pass CTRL argument
1954 * divert-scd.c (ask_for_card): Add CTRL arg.
1955 (divert_pksign,divert_pkdecrypt): Ditto. Changed caller.
1956 (getpin_cb): Use OPAQUE to pass the CTRL variable. Changed both
1958 * findkey.c (unprotect): Add CTRL arg.
1959 (agent_key_from_file): Ditto.
1961 * query.c (unlock_pinentry): Disconnect the pinentry so that we
1962 start a new one for each request. This is required to support
1963 clients with different environments (e.g. X magic cookies).
1965 2002-09-05 Neal H. Walfield <neal@cs.uml.edu>
1967 * gpg-agent.c (main) [USE_GNU_PTH]: No need to call
1968 assuan_set_io_func as assuan is smart.
1970 2002-09-25 Werner Koch <wk@gnupg.org>
1972 * gpg-agent.c (handle_signal): Flush cache on SIGHUP.
1973 * cache.c (agent_flush_cache): New.
1975 * gpg-agent.c, agent.h: Add --keep-display and --keep-tty.
1976 * query.c (start_pinentry): Implement them. The option passing
1977 needs more thoughts.
1979 2002-09-09 Werner Koch <wk@gnupg.org>
1981 * gpg-agent.c (create_private_keys_directory)
1982 (create_directories): New.
1983 (main): Try to create a home directory.
1985 2002-09-04 Neal H. Walfield <neal@g10code.de>
1987 * gpg-agent.c (main): Use sigaction, not signal.
1989 2002-09-03 Neal H. Walfield <neal@g10code.de>
1991 * findkey.c: Include <fcntl.h>.
1992 (agent_write_private_key): Prefer POSIX compatibity, open and
1993 fdopen, over the simplicity of GNU extensions, fopen(file, "x").
1995 2002-08-22 Werner Koch <wk@gnupg.org>
1997 * query.c (agent_askpin): Provide the default desc text depending
1998 on the pininfo. Do the basic PIN verification only when
2001 2002-08-21 Werner Koch <wk@gnupg.org>
2003 * query.c (agent_askpin): Hack to show the right default prompt.
2004 (agent_get_passphrase): Ditto.
2006 * trans.c: Removed and replaced all usages with standard _()
2008 * divert-scd.c (getpin_cb): Pass a more descritive text to the
2011 * Makefile.am: Renamed the binary protect-tool to gpg-protect-tool.
2012 * protect-tool.c: Removed the note about internal use only.
2014 * gpg-agent.c (main): New option --daemon so that the program is
2015 not accidently started in the background.
2017 2002-08-16 Werner Koch <wk@gnupg.org>
2019 * call-scd.c (learn_status_cb): Handle CERTINFO status.
2020 (agent_card_learn): Add args for certinfo cb.
2021 * learncard.c (release_certinfo,certinfo_cb): New.
2022 (send_cert_back): New. With factored out code from ..
2023 (agent_handle_learn): here. Return certinfo stuff.
2025 2002-07-26 Werner Koch <wk@gnupg.org>
2027 * gpg-agent.c (main): New option --ignore-cache-for-signing.
2028 * command.c (option_handler): New server option
2029 use-cache-for-signing defaulting to true.
2030 (cmd_pksign): handle global and per session option.
2031 * findkey.c (agent_key_from_file, unprotect): New arg
2032 ignore_cache. Changed all callers.
2033 * pksign.c (agent_pksign): Likewise.
2035 2002-06-29 Werner Koch <wk@gnupg.org>
2037 * query.c (start_pinentry): Use GNUPG_DERAULT_PINENTRY.
2038 * call-scd.c (start_scd): Use GNUPG_DEFAULT_SCDAEMON.
2040 2002-06-28 Werner Koch <wk@gnupg.org>
2042 * protect-tool.c (export_p12_file): New.
2043 (main): New command --p12-export.
2044 * minip12.c (create_final,p12_build,compute_tag_length): New.
2045 (store_tag_length): New.
2047 2002-06-27 Werner Koch <wk@gnupg.org>
2049 * minip12.c (crypt_block): Renamed from decrypt_block, add arg to
2052 * Makefile.am (pkglib_PROGRAMS): Put protect-tool there.
2054 * findkey.c (agent_write_private_key,agent_key_from_file)
2055 (agent_key_available): Use GNUPG_PRIVATE_KEYS_DIR constant.
2056 * gpg-agent.c (main): Use GNUPG_DEFAULT_HOMEDIR constant.
2058 * protect-tool.c (store_private_key): New.
2059 (import_p12_file): Store the new file if requested.
2060 (main): New options --force and --store.
2062 * gpg-agent.c (main): Set a global flag when running detached.
2063 * query.c (start_pinentry): Pass the list of FD to keep in the
2064 child when not running detached.
2065 * call-scd.c (start_scd): Ditto.
2067 2002-06-26 Werner Koch <wk@gnupg.org>
2069 * command.c (cmd_istrusted, cmd_listtrusted, cmd_marktrusted)
2070 (cmd_pksign, cmd_pkdecrypt, cmd_genkey, cmd_get_passphrase)
2071 (cmd_learn): Print an error message for a failed operation.
2073 * simple-pwquery.c, simple-pwquery.h: New.
2074 * protect-tool. (get_passphrase): New, used to get a passphrase
2075 from the agent if none was given on the command line.
2077 2002-06-25 Werner Koch <wk@gnupg.org>
2079 * protect-tool.c (rsa_key_check): New.
2080 (import_p12_file): New.
2081 (main): New command --p12-import.
2082 * minip12.c, minip12.h: New.
2084 2002-06-24 Werner Koch <wk@gnupg.org>
2086 * protect-tool.c (read_file): New.
2087 (read_key): Factored most code out to read_file.
2089 2002-06-17 Werner Koch <wk@gnupg.org>
2091 * agent.h: Add a callback function to the pin_entry_info structure.
2092 * query.c (agent_askpin): Use the callback to check for a correct
2093 PIN. Removed the start_err_text argument because it is not
2094 anymore needed; changed callers.
2095 * findkey.c (unprotect): Replace our own check loop by a callback.
2096 (try_unprotect_cb): New.
2097 * genkey.c (reenter_compare_cb): New.
2098 (agent_genkey): Use this callback here. Fixed setting of the pi2
2099 variable and a segv in case of an empty PIN.
2101 * divert-scd.c (getpin_cb): Removed some unused stuff and
2102 explained what we still have to change.
2104 2002-06-12 Werner Koch <wk@gnupg.org>
2106 * gpg-agent.c (main): New option --disable-pth.
2108 2002-06-11 Werner Koch <wk@gnupg.org>
2110 * protect-tool.c: Add command --show-keygrip
2111 (show_keygrip): New.
2113 2002-05-23 Werner Koch <wk@gnupg.org>
2115 * call-scd.c: Seirialized all scdaeom access when using Pth.
2117 * cache.c: Made the cache Pth-thread-safe.
2118 (agent_unlock_cache_entry): New.
2119 * findkey.c (unprotect): Unlock the returned cache value.
2120 * command.c (cmd_get_passphrase): Ditto.
2122 * gpg-agent.c (main): Register pth_read/write with Assuan.
2124 2002-05-22 Werner Koch <wk@gnupg.org>
2126 * query.c: Serialized all pinentry access when using Pth.
2128 * gpg-agent.c (handle_signal,start_connection_thread)
2129 (handle_connections): New
2130 (main): Use the new Pth stuff to allow concurrent connections.
2131 * command.c (start_command_handler): Add new arg FD so that the
2132 fucntion can also be used for an already connected socket.
2133 * Makefile.am: Link with Pth.
2135 2002-05-14 Werner Koch <wk@gnupg.org>
2137 * cache.c (housekeeping, agent_put_cache): Use our time() wrapper.
2139 2002-04-26 Werner Koch <wk@gnupg.org>
2141 * cache.c (agent_put_cache): Reinitialize the creation time and
2142 the ttl when reusing a slot.
2144 * call-scd.c (start_scd): Print debug messages only with debug
2146 * query.c (start_pinentry): Ditto.
2148 2002-04-25 Marcus Brinkmann <marcus@g10code.de>
2150 * agent.h (agent_get_confirmation): Replace paramter prompt with
2151 two parameters ok and cancel.
2152 * query.c (agent_get_confirmation): Likewise. Implement this.
2153 * trustlist.c (agent_marktrusted): Fix invocation of
2154 agent_get_confirmation.
2155 * divert-scd.c (ask_for_card): Likewise.
2157 2002-04-24 Marcus Brinkmann <marcus@g10code.de>
2159 * agent.h (struct opt): Add members display, ttyname, ttytype,
2160 lc_ctype, and lc_messages.
2161 * gpg-agent.c (enum cmd_and_opt_values): Add oDisplay, oTTYname,
2162 oTTYtype, oLCctype, and LCmessages.
2163 (main): Handle these options.
2164 * command.c (option_handler): New function.
2165 (register_commands): Register option handler.
2166 * query.c (start_pinentry): Pass the various display and tty
2167 options to the pinentry.
2169 2002-04-05 Werner Koch <wk@gnupg.org>
2171 * protect-tool.c (show_file): New. Used as default action.
2173 2002-03-28 Werner Koch <wk@gnupg.org>
2175 * divert-scd.c (encode_md_for_card): Don't do the pkcs-1 padding,
2176 the scdaemon should take care of it.
2177 (ask_for_card): Hack to not display the trailing zero.
2179 2002-03-11 Werner Koch <wk@gnupg.org>
2181 * learncard.c (kpinfo_cb): Remove the content restrictions from
2184 2002-03-06 Werner Koch <wk@gnupg.org>
2187 * divert-scd.c (ask_for_card): The serial number is binary so
2188 convert it to hex here.
2189 * findkey.c (agent_write_private_key): New.
2190 * genkey.c (store_key): And use it here.
2192 * pkdecrypt.c (agent_pkdecrypt): Changed the way the diversion is done.
2193 * divert-scd.c (divert_pkdecrypt): Changed interface and
2196 2002-03-05 Werner Koch <wk@gnupg.org>
2198 * call-scd.c (inq_needpin): New.
2199 (agent_card_pksign): Add getpin_cb args.
2200 (agent_card_pkdecrypt): New.
2202 2002-03-04 Werner Koch <wk@gnupg.org>
2204 * pksign.c (agent_pksign): Changed how the diversion is done.
2205 * divert-scd.c (divert_pksign): Changed interface and implemented it.
2206 (encode_md_for_card): New.
2207 * call-scd.c (agent_card_pksign): New.
2209 2002-02-28 Werner Koch <wk@gnupg.org>
2211 * pksign.c (agent_pksign): Detect whether a Smartcard is to be
2212 used and divert the operation in this case.
2213 * pkdecrypt.c (agent_pkdecrypt): Likewise
2214 * findkey.c (agent_key_from_file): Add optional arg shadow_info
2215 and have it return information about a shadowed key.
2216 * protect.c (agent_get_shadow_info): New.
2218 * protect.c (snext,sskip,smatch): Moved to
2219 * sexp-parse.h: New file.
2220 * divert-scd.c: New.
2222 2002-02-27 Werner Koch <wk@gnupg.org>
2224 * protect.c (agent_shadow_key): New.
2226 * command.c (cmd_learn): New command LEARN.
2227 * gpg-agent.c: New option --scdaemon-program.
2228 * call-scd.c (start_scd): New. Based on query.c
2229 * query.c: Add 2 more arguments to all uses of assuan_transact.
2231 2002-02-18 Werner Koch <wk@gnupg.org>
2233 * findkey.c (unprotect): Show an error message for a bad passphrase.
2235 * command.c (cmd_marktrusted): Implemented.
2236 * trustlist.c (agent_marktrusted): New.
2237 (open_list): Add APPEND arg.
2239 * query.c (agent_get_confirmation): New.
2241 2002-02-06 Werner Koch <wk@gnupg.org>
2243 * cache.c (housekeeping): Fixed linking in the remove case.
2245 2002-02-01 Werner Koch <wk@gnupg.org>
2247 * gpg-agent.c: New option --default-cache-ttl.
2248 * cache.c (agent_put_cache): Use it.
2250 * cache.c: Add a few debug outputs.
2252 * protect.c (agent_private_key_type): New.
2253 * agent.h: Add PRIVATE_KEY_ enums.
2254 * findkey.c (agent_key_from_file): Use it to decide whether we
2255 have to unprotect a key.
2256 (unprotect): Cache the passphrase.
2258 * findkey.c (agent_key_from_file,agent_key_available): The key
2259 files do now require a ".key" suffix to make a script's life
2261 * genkey.c (store_key): Ditto.
2263 2002-01-31 Werner Koch <wk@gnupg.org>
2265 * genkey.c (store_key): Protect the key.
2266 (agent_genkey): Ask for the passphrase.
2267 * findkey.c (unprotect): Actually unprotect the key.
2268 * query.c (agent_askpin): Add an optional start_err_text.
2270 2002-01-30 Werner Koch <wk@gnupg.org>
2273 (hash_passphrase): Based on the GnuPG 1.0.6 version.
2274 * protect-tool.c: New
2276 2002-01-29 Werner Koch <wk@gnupg.org>
2278 * findkey.c (agent_key_available): New.
2279 * command.c (cmd_havekey): New.
2280 (register_commands): And register new command.
2282 2002-01-20 Werner Koch <wk@gnupg.org>
2284 * command.c (cmd_get_passphrase): Remove the plus signs.
2286 * query.c (start_pinentry): Send no-grab option to pinentry
2287 * gpg-agent.c (main): Move variable grab as no_grab to agent.h.
2289 2002-01-19 Werner Koch <wk@gnupg.org>
2291 * gpg-agent.c (main): Disable core dumps.
2294 * command.c (cmd_get_passphrase): Use the cache.
2295 (cmd_clear_passphrase): Ditto.
2297 * gpg-agent.c: Removed unused cruft and implement the socket
2299 (my_strusage): Take bug report address from configure.ac.
2300 * command.c (start_command_handler): Add an argument to start as
2302 (start_command_handler): Enable Assuan logging.
2304 2002-01-15 Werner Koch <wk@gnupg.org>
2307 * command.c (cmd_istrusted, cmd_listtrusted, cmd_marktrusted): New.
2309 2002-01-07 Werner Koch <wk@gnupg.org>
2311 * genkey.c: Store the secret part and return the public part.
2313 2002-01-03 Werner Koch <wk@gnupg.org>
2315 * command.c (cmd_get_passphrase): New.
2316 (cmd_clear_passphrase): New.
2317 * query.c (agent_get_passphrase): New.
2319 2002-01-02 Werner Koch <wk@gnupg.org>
2322 * command.c (cmd_genkey): New.
2324 * command.c (rc_to_assuan_status): Removed and changed all callers
2325 to use map_to_assuan_status.
2327 2001-12-19 Werner Koch <wk@gnupg.org>
2329 * keyformat.txt: New.
2331 2001-12-19 Marcus Brinkmann <marcus@g10code.de>
2333 * query.c (start_pinentry): Add new argument to assuan_pipe_connect.
2335 2001-12-18 Werner Koch <wk@gnupg.org>
2337 * Makefile.am: Use LIBGCRYPT macros
2339 2001-12-14 Werner Koch <wk@gnupg.org>
2341 * gpg-agent.c (main): New option --batch. New option --debug-wait
2342 n, so that it is possible to attach gdb when used in server mode.
2343 * query.c (agent_askpin): Don't ask in batch mode.
2345 * command.c: Removed the conversion macros as they are now in
2348 2001-12-14 Marcus Brinkmann <marcus@g10code.de>
2350 * query.c (LINELENGTH): Removed.
2351 (agent_askpin): Use ASSUAN_LINELENGTH, not LINELENGTH.
2353 2001-11-19 Werner Koch <wk@gnupg.org>
2355 * gpg-agent.c: Removed all GUI code, removed code for old
2356 protocol. New code to use the Assuan protocol as a server and
2357 also to communicate with a new ask-passphrase utility.
2359 2000-11-22 Werner Koch <wk@gnupg.org>
2361 * gpg-agent.c (main): csh support by Dan Winship, new options --sh
2362 and --csh and set default by consulting $SHELL.
2364 Mon Aug 21 17:59:17 CEST 2000 Werner Koch <wk@openit.de>
2366 * gpg-agent.c (passphrase_dialog): Cleanup the window and added the
2367 user supplied text to the window.
2368 (main): Fixed segv in gtk_init when used without a command to start.
2370 * gpg-agent.c: --flush option.
2372 (req_clear_passphrase): Implemented.
2374 Fri Aug 18 14:27:14 CEST 2000 Werner Koch <wk@openit.de>
2380 Copyright 2001, 2002, 2003, 2004, 2005,
2381 2007, 2008, 2009 Free Software Foundation, Inc.
2383 This file is free software; as a special exception the author gives
2384 unlimited permission to copy and/or distribute it, with or without
2385 modifications, as long as this notice is preserved.
2387 This file is distributed in the hope that it will be useful, but
2388 WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
2389 implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.