1 2007-09-18 Denis Ovsienko
3 * ospf_network.c: (ospf_adjust_sndbuflen) Don't complain
4 about getting more buffer space, than requested.
5 * ospfd.[ch]: (ospf_new) Abandon OSPF_SNDBUFLEN_DEFAULT
6 and consider OS's initial buffer size instead.
7 * ospf_interface.c: (ospf_if_up) Fix missing argument.
9 2007-08-21 Denis Ovsienko
11 * ospfd.h: Extend struct ospf with maxsndbuflen field and
12 define its default value.
13 * ospfd.c: (ospf_new) init maxsndbuflen
14 * ospf_interface.c: (ospf_if_up) Call ospf_adjust_sndbuflen()
15 for each regular interface being brought up.
16 * ospf_network.[ch]: (ospf_adjust_sndbuflen) New function
17 makes sure ospf socket sending buffer is large enough
18 to cover the biggest interface MTU we have seen ever.
19 * ospf_packet.c: (ospf_write) Use maxsndbuflen to decide on
20 the biggest amount of data we are going to send at once.
22 2007-08-07 Paul Jakma <paul.jakma@sun.com>
24 * ospf_spf.c: (ospf_spf_next) Finish off the explanatory
25 comment made in previous commit
27 2007-08-07 Atis Elsts <atis@mikrotik.com>
29 * ospf_spf.c: (ospf_spf_next) Sort heap in correct direction
30 after vertex cost is changed, thus fixing incorrect SPF
31 calculation on certain topologies.
33 2007-08-06 Paul Jakma <paul.jakma@sun.com>
35 * ospf_lsa.c: (router_lsa_flags) Bug #331, NSSA regression caused
36 caused ASBRs to not advertise E-bit into NSSA areas.
38 2007-05-09 Milan Kocian <milon@wq.cz>
40 * ospf_vty.c: Fix commands: 'ip ospf authentication A.B.C.D',
41 'no ip ospf authentication A.B.C.D', 'no ip ospf
42 authentication-key A.B.C.D'. Simply fix argv's indexes and
43 argc check in DEFUN functions.
45 2007-05-07 Paul Jakma <paul.jakma@sun.com>
47 * ospf_spf.c: (ospf_vertex_new) Dont init vertices to infinity,
48 just let 0 be a special case.
49 (ospf_spf_add_parent) 0 distance candidate vertex is special,
50 cost still to be initialised - asserting that new distance
51 is <= existing only makes sense where w already has a cost.
52 (ospf_spf_next) Infinite cost links should not be followed,
53 bar those of the root.
55 2007-04-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
57 * ospfd.c: (ospf_network_match_iface) Comment out
58 COMPATIBILITY_MODE. Going forward, the ospf "network" command
59 will use a simple test: does the network command prefix
60 contain the connected (destination) prefix of the interface?
62 2007-04-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
64 * ospf_interface.c: (ospf_if_set_multicast) Fix bug: was testing
65 interface passive status improperly in light of the recent
66 'passive-interface default' patch. Now need to test
67 OSPF_IF_PASSIVE_STATUS(oi) instead of
68 OSPF_IF_PARAM(oi, passive_interface).
70 2007-03-23 Paul Jakma <paul.jakma@sun.com>
72 * ospf_spf.c: (various) Add more debug statements.
73 (ospf_nexthop_calculation) Fix silly regression causing ospfd
74 to fail to calculate paths past networks not attached to root
75 vertex, introduced with bug #330 fixes.
77 2007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
79 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
80 map internal quagga neighbor states to SNMP standard values.
81 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
83 2007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
85 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
86 where inet_ntoa was used twice in the same debug message,
87 which doesn't work because there's a single shared buffer
88 for the returned string. The fix is to use inet_ntop.
90 2007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
92 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
93 actually running (e.g. the config file was empty). Fixes
94 bug where SIGTERM would not kill ospfd.
96 2007-02-26 Paul Jakma <paul.jakma@sun.com>
98 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
99 cost update added to ospf_spf_add_parent only handled PtP
100 case, differing from same functionality in higher-level
101 ospf_spf_next. Regression diagnosed by Anders Pedersen,
102 mailnews+router-quagga-dev@news.cohaesio.com.
103 (ospf_vertex_new) Initialise vertices to max-cost.
104 (ospf_spf_init) Root vertex always creates with 0 cost.
105 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
106 code, instead take the new distance as a parameter.
107 (ospf_nexthop_calculation) Take distance as parameter, so it
108 can be passed down to add_parent.
109 (ospf_spf_next) Dont initialise candiate vertex distance,
110 vertex_new does so already. Pass distance down to
111 nexthop_calculation (see above).
113 2007-01-24 Paul Jakma <paul.jakma@sun.com>
115 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
116 and it needs to indicate this result to SPF.
117 (ospf_spf_add_parent) Flush of parent list needs to be done here,
119 (ospf_nexthop_calculation) Caller needs to know whether
120 nexthop calculation succeeded. Every return statement must
121 correctly indicate such.
122 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
123 must take into account whether nexthop_calculation succeeded,
124 or SPF may fail to find best paths.
126 2006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
128 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
129 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
131 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
132 macro, both options collapse into the same code.
133 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
135 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
137 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
138 instead of testing the IFF_POINTOPOINT flag.
139 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
140 instead of testing with if_is_pointopoint. And add commented-out
141 code to implement alternative (in my opinion) more elegant behavior
142 that has no special-case treatment for PtP addresses.
143 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
145 2006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
147 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
148 Previously, after creating a single ospf_interface on a given
149 network interface, the code would skip to the next interface
150 without considering other connected addresses on the interface.
151 After removing the 'break', we now consider all connected addresses.
153 2006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
155 * ospf_zebra.c: (ospf_router_id_update_zebra,
156 ospf_interface_address_add, ospf_interface_address_delete)
157 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
158 add a debug message about what Zebra is telling us.
159 (ospf_zebra_add_discard) Add a debug message matching the one
160 already in ospf_zebra_delete_discard.
162 2006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
164 * ospf_vty.c: (ospf_passive_interface_default) Take additional
165 'newval' arg so we can update ospf->passive_interface_default inside
166 this function. More importantly, we now call ospf_if_set_multicast
167 on all ospf_interfaces.
168 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
169 for 'default' case, argv[0] is undefined, so we must test for
170 (argc == 0) before using argv[0]. And since
171 ospf_passive_interface_default now calls ospf_if_set_multicast as
172 needed, we can just return after calling
173 ospf_passive_interface_default.
175 2006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
177 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
178 a new value for ospf->default_originate was being ignored
179 if a previous 'default-information originate' command
180 had already been processed.
182 2006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
184 * (general) Add support for passive-interface default (with
185 minor edits by Paul Jakma).
186 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
187 at configured value, or the global 'default' value, as
189 * ospf_interface.c: (ospf_if_new_hook) Leave passive
190 unconfigured per default, allowing global 'default' to
191 take effect for unconfigured interfaces.
192 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
193 * ospf_vty.c: (ospf_passive_interface_default) new function,
194 unset passive from all interfaces if default is enabled, as
195 the per-iface settings become redundant.
196 (ospf_passive_interface_update) new func, update passive
197 setting taking global default into account.
198 ({no,}ospf_passive_interface_addr_cmd) Add support for
199 'default' variant of command.
200 (show_ip_ospf_interface_sub) Update to take global
201 default into account when printing passive status.
202 (ospf_config_write) ditto.
203 * ospfd.c: (ospf_new) set global passive-interface default.
204 * ospfd.h: (struct ospf) Add field for global
207 2006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
209 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
210 Fix zlog_warn messages to eliminate compiler warnings.
211 (ospf_hello) Improve warning messages to show why we
214 2006-08-28 Andy Gay <andy@andynet.net>
216 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
217 fixes does not hold up with addition of Ogier DB-Exchange
218 optimisation, which can empty the db-summary list in between
219 sent DD packets. Remove assert, update More-bit always when
222 2006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
224 * ospfd.c: (ospf_finish_final) default redistribute should be
225 unset too, fixes bug where reconfiguring ospfd completely
226 can no longer enable default redistribution.
228 2006-08-25 Paul Jakma <paul.jakma@sun.com>
230 * (general) Bug #134. Be more robust to backward time changes,
231 use the newly added libzebra time functions.
232 In most cases: recent_time -> recent_relative_time()
233 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
235 (ospf_make_md5_digest) time() call deliberately not changed.
236 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
237 tv_orig time was already set in ospf_lsa_new, called via
238 ospf_external_lsa_new.
240 2006-08-04 Paul Jakma <paul.jakma@sun.com>
242 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
243 exact same functionality replicated in other functions.
244 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
245 (ospf_lsdb_delete) ditto.
246 (ospf_lsdb_delete_all) ditto.
248 2006-08-03 Paul Jakma <paul.jakma@sun.com>
250 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
251 after constructing the packet, if appropriate.
252 (ospf_db_desc_proc) Speed up Exchange, slave should raise
253 ExchangeDone earlier, as RFC mandates, by forming its reply
254 before deciding whether both sides are done, avoids a
255 needless round of empty DD packet exchanges at the end of
256 Exchange, hence speeding up ExchangeDone.
257 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
258 (ospf_db_desc) use UNSET_FLAG macro.
260 2006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
262 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
263 selecting the router ID: if there is not a statically configured ID,
264 then stick to the most recent value to avoid disruptive changes.
265 This should fix bug #288.
267 2006-07-26 Paul Jakma <paul.jakma@sun.com>
269 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
270 to the LSA to be 'unlocked', so that, if the LSA is freed, the
271 callers pointer to the LSA can be NULLed out, allowing any further
272 use of that pointer to provoke a crash sooner rather than later.
273 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
274 previous. Try annotate 'locking' somewhat to show which 'locks'
275 are protecting what LSA reference, if not obvious.
276 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
277 goto, replace with return.
278 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
279 the dual-loop predated the delete-safe list-loop macro.
281 2006-07-25 Paul Jakma <paul.jakma@sun.com>
283 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
284 neighbour state statistics fields, timestamps for progressive
285 and regressive state changes, and pointer to event string
286 for the latter state change.
287 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
289 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
290 new per-neighbour state change stats.
292 2006-07-10 Paul Jakma <paul.jakma@sun.com>
294 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
295 adjacency losses, hence removing need for nsm_reset_nbr.
296 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
297 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
298 (ospf_nsm_event) Allow NSM function to be NULL, this along with
299 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
301 Remove some useless variables.
302 (nsm_ignore) now useless, remove.
303 (nsm_bad_ls_req) ditto
304 (nsm_seq_number_mismatch) "
305 (nsm_oneway_received) "
306 (nsm_inactivity_timer) "
308 (NSM) replace removed action functions with NULL.
309 (nsm_notice_state_changes) Move state change logging code to new
310 func to declutter nsm_change_state and ospf_nsm_event.
311 Log event with AdjChange, it's useful to know.
312 (nsm_change_state) move adjchange and snmp logging to previous.
313 (ospf_nsm_event) call nsm_notice_state_changes from here.
314 Move the debug message to entry of function, so it gets out
315 even if something goes wrong.
316 Record state change timestamp and event in nbr struct.
317 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
318 timestamp of last NSM change and event.
319 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
320 last state change timestamp and event, if available.
322 2006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
324 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
325 message to include interface name and conflicting prefix lengths.
327 2006-07-07 Paul Jakma <paul.jakma@sun.com>
329 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
330 state indicating the neighbour is to be deleted.
331 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
332 neighbours, thus allowing code to be slightly more obvious
334 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
336 (nsm_kill_nbr) No need for special case call to nsm_change_state
338 Make the assert and error-handling for same case more readable
340 Remove the call to ospf_nbr_delete, nsm_change_state can do
341 this generally now via NSM_Deleted.
342 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
343 that can lead to nsm_kill_nbr all now transition the NBR to
344 NSM_Deleted and the general change_state function can be left
346 (ospf_nsm_event) Special casing of events and early-return can
348 On transition into Deleted, delete the nbr.
349 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
351 2006-07-06 Paul Jakma <paul.jakma@sun.com>
353 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
354 being deleted, requires early-return too. Likely explains
355 some crash reports after interface events.
357 2006-07-04 Paul Jakma <paul.jakma@sun.com>
359 * ospf_nsm.c: (general) Various small cleanups from Andrew's
360 review of last set of patches.
361 (nsm_timer_set) Loading, Full and default can share
363 (nsm_should_adj) Can just be one big OR.
364 (nsm_twoway_received) Collapse into return statement.
366 2006-07-02 Paul Jakma <paul.jakma@sun.com>
368 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
369 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
370 (nsm_twoway_received/nsm_adj_ok) Use former.
371 (nsm_clear_adj) clear adjacency related state for a
372 neighbour, needed for some state changes from > ExStart down
373 to ExStart or less, which need not go through nsm_reset_nbr.
374 (nsm_reset_nbr) move code to former. Should be static.
375 (ospf_nsm_event) Don't allow action functions to change
376 next_state if the NSM tables do not indicate next_state is
377 conditional, log warning if one tries - existing code
379 Remove long dead code.
380 Use nsm_clear_adj for state changes that take down
381 adjacencies to TwoWay/ExStart.
382 (nsm_timer_set) ls_req timer should be OFF in early states.
383 Compact several identical sections.
384 Set inactivity timer to OFF for Down, for documentary
386 (nsm_kill_nbr) Oops, action function shouldn't try return
388 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
390 2006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
392 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
393 of that neighbor (since it may appear on multiple interfaces)
394 instead of bailing out after showing the first match.
396 2006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
398 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
399 change from state Init to ExStart, the test for whether the
400 neighboring router is DR or BDR should be against the
401 local router's notion of DR/BDR, not the neighbor's view.
403 2006-06-28 Erik Muller <erikm@internap.com>
405 * ospfd.h: Define 2 new struct ospf config flags:
406 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
407 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
409 * ospf_vty.c (ospf_log_adjacency_changes): New command function
410 to implement ospf subcommand "log-adjacency-changes [detail]".
411 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
412 (show_ip_ospf) Show whether adjacency changes are logged.
413 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
414 (ospf_vty_init) Add ospf_log_adjacency_changes and
415 no_ospf_log_adjacency_changes.
417 2006-06-26 Paul Jakma <paul.jakma@sun.com>
419 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
420 be ASBRs, or other routers may rightfully refuse to install
421 translated type-5s LSAs. reported by dendroot@gmail.com.
422 (ospf_abr_nssa_check_status) Detect change in translator
423 state when ABR, and inc/dec redistribute count as when we
424 leave/enter the disabled state - so that translate-enabled
425 ABR properly sets ASBR bit on non-NSSA areas.
426 Run the resulting function through indent to clean it up.
427 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
428 NSSA area is same as stub area.
430 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
432 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
433 info log message to indicate why the trap is being sent.
435 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
437 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
438 status properly (not ism status).
440 2006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
442 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
443 with a call to if_get_by_name -- if the interface does not exist
444 already, it should be created. And remove the obsolete warning
447 2006-06-15 Paul Jakma <paul.jakma@sun.com>
449 * ospf_interface.h: (struct ospf_if_info) Add reference counts
450 for multicast group memberships. Add various macros to help
451 manipulate/check membership state.
452 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
453 ospf_if_info reference counts, and only actually drop
454 memberships if it hits 0, to avoid losing membership when
455 OSPF is disabled on an interface with multiple active OSPF
457 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
459 multicast membership.
460 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
462 2006-05-31 Paul Jakma <paul.jakma@sun.com>
464 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
466 * ospf_lsa.c: (ospf_discard_from_db) ditto.
467 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
468 mitigation (but not solution) for bug #269.
470 2006-05-30 Paul Jakma <paul.jakma@sun.com>
472 * ospf_packet.c: (ospf_read) Debug message about packets
473 received on unenabled interfaces should be conditional on
476 2006-05-23 Paul Jakma <paul.jakma@sun.com>
478 * ospf_vty.c: (general) Replace in-place route redistribution
479 command and help strings with the new auto-generated defines
480 from lib/route_types.h
482 2006-05-13 Paul Jakma <paul.jakma@sun.com>
484 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
485 check to match the assert, small error in CID #13 fix.
487 2006-05-12 Paul Jakma <paul.jakma@sun.com>
489 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
490 call, which is not checked for NULL return, by stripping out
491 functionality which is never used, hence fixing Coverity CID
493 (struct lsa_action) remove unused member.
494 (ospf_translated_nssa_refresh) Add non-assert sanity check,
495 in case DEBUG isn't defined.
496 Debug message when no type7 exists should print the ID from
497 the type5, not the type7, fixes CID #13.
498 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
499 check on ospf_lookup, CID #27.
500 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
501 call by taking the struct ospf * as argument, which the
502 caller has, fixing CID #28.
503 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
504 * ospf_zebra.c: (ospf_redistribute_unset) update call to
505 ospf_redistribute_withdraw to match.
506 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
507 NULL when passed to ospf_find_asbr_route_through_area,
508 check for NULL first, CID #14.
509 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
510 useless, it's always valid. Only possibility where it
511 couldn't be is if there is a race between abr_task and
512 cleaning up oi's, in which case a NULL check here isn't going
513 to do anything. Fixes CID #15.
515 2006-05-11 Paul Jakma <paul.jakma@sun.com>
517 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
518 ensure check for NULL result, make vty messages consistent.
519 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
520 result, fixes Coverity CID #70.
521 (no_ospf_area_filter_list) Check NULL result from
522 ospf_area_lookup_by_area_id, fixes Coverity CID #69
523 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
524 NULL check by moving into check-protected block, fix CID #49.
525 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
526 range, should just lookup to see if one exists, the new range
527 is just leaked. Fixes CID #46.
528 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
529 take (struct ospf *) as thread argument, rather than (struct
530 ospf *)->default_originate, thus avoiding having to call
532 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
533 of ospf_default_originate_timer thread to match.
534 * ospfd.c: (ospf_router_id_update) ditto.
536 2006-04-24 Paul Jakma <paul.jakma@sun.com>
538 * (general) More Virtual-link fixes, again with much help in
539 testing / debug from Juergen Kammer. Primarily in SPF.
540 * ospf_spf.h: Add guard. ospf_interface.h will include this
542 * ospf_interface.h: Modify ospf_vl_lookup definition to take
543 struct ospf as argument, so as to allow for NULL area
545 (struct ospf_vl_data) Remove out_oi, instead add a struct
546 vertex_nexthop, to use as initial nexthop for backbone paths
548 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
549 NULL area to be passed to indicate "any" (first) area.
551 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
552 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
554 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
555 backbone, don't bother checking.
556 * ospf_spf.c: (static struct list vertex_list) Record vertices
557 that will need to be freed.
558 (cmp) Order network before router vertices, as required,
560 (vertex_nexthop_free) Mild additional robustness check.
561 (vertex_parent_free) Take void argument, as this function
562 is passed as list deconstructor for vertex parent list.
563 (ospf_vertex_new) More debug. Set deconstructor for parent
564 list. Track allocated vertices on the vertex_list.
565 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
566 vertices. Now frees only the given vertex.
567 (ospf_vertex_add_parent) Fix assert.
568 (ospf_nexthop_calculation) Fix calculation of nexthop for
569 VLink vertices, lookup the vl_data and use its previously
570 recorded nexthop information.
571 (ospf_spf_calculate) Vertices are freed simply by deleting
572 vertex_list nodes and letting ospf_vertex_free as deconstructor
574 (ospf_spf_calculate_timer) Trivial optimisation, leave
575 backbone SPF calculation till last to reduce SPF churn on
577 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
578 (no_ospf_area_vlink_cmd) ditto.
579 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
580 more interesting than the output interface.
582 2006-04-03 Paul Jakma <paul.jakma@sun.com>
584 * (general) Fix issues with handling of Vlinks and entries
585 in the nbrs route-table which were highlighted by the
586 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
587 Kammer for his help and efforts in testing out debug patches to
589 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
590 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
591 to create key in nbrs table for a given nbr.
592 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
593 document an expected state.
594 (ospf_nbr_add_self) Ditto.
595 (ospf_nbr_lookup_by_addr) Add an assert.
596 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
599 2006-03-27 Paul Jakma <paul.jakma@sun.com>
601 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
602 the ambiguities of ANSI and C99 C with respect to type
603 conversion. Detailed problem report and test case with
604 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
606 2006-03-25 Paul Jakma <paul.jakma@sun.com>
608 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
609 we can never ever receive packets on those. Should fix
610 case where CARP is run with address in same subnet as real
611 interface. Problem report and diagnosis thanks to:
612 Landon Fuller <landonf@opendarwin.org>.
613 However, ospf_read() still can't deal deterministically with
614 multiple interfaces in same subnet.
616 2006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
618 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
619 conversion of OSPF_MAX_SEQUENCE_NUMBER
621 2006-01-19 Paul Jakma <paul.jakma@sun.com>
623 * (general) various miscellaneous compiler warning fixes.
624 Remove redundant break statements from switch clauses
626 return from main, not exit, cause it annoys SOS.
627 Remove stray semi-colons which cause empty-statement
630 2006-01-18 Juergen Kammer <j.kammer@eurodata.de>
632 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
633 stream data until it is constructed, data reference is
634 volatile due to the potential resize in link_info_set
636 2006-01-18 Paul Jakma <paul.jakma@sun.com>
638 * ospf_lsa.c: (link_info_set) Resize the stream if required and
639 possible. Return number of links added.
640 (lsa_link_*_set) use return value from previous.
641 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
643 2006-01-17 Paul Jakma <paul.jakma@sun.com>
645 * ospf_packet.c: (ospf_verify_header) print out the types
646 involved if there's a mismatch.
647 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
649 2006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
651 * (general) Bug #234, see also [quagga-dev 3902].
652 Fix problem with nbr_self not being properly reinitialised
653 when an interface comes up, after having been down.
654 Some re-arrangement done by Paul Jakma, any bugs introduced
655 on top of Len's suggested changes are his.
656 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
657 initialisation of nbr_self parameters here.
658 * ospf_interface.c: (ospf_if_new) deleting initialisation of
659 parameters of nbr_self, just rely on call to
661 (ospf_if_cleanup) ditto.
662 * ospfd.c: (ospf_network_run) ditto.
664 2006-01-10 Juris Kalnins <juris@mt.lv>
666 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
667 struct connected in an error case.
668 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
669 undefined effect, assignment of an increment expression.
671 2006-01-10 Paul Jakma <paul.jakma@sun.com>
673 * ospfd.c: (ospf_network_run) checking to see if router-id
674 is set should be on ospf->router_id, not router_id_static.
675 This was causing ospfd to not start if router-id had not
676 been configured statically.
677 (ospf_if_update) ditto.
678 * ospf_vty.c: (config_write_ospf_distribute) trim down
681 2005-11-26 Paul Jakma <paul.jakma@sun.com>
683 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
684 array to C99 incomplete type array.
685 * (general) s/graceful/deferred/ in all files, the former term
686 is confusing wrt OSPF Graceful-Restart.
687 * ospfd.c: (ospf_deferred_shutdown_check) dont return
688 a function which returns void. SOS complains about this.
691 2005-11-20 Paul Jakma <paul.jakma@sun.com>
693 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
694 (struct ospf) remove the router_id timer thread.
695 remove export of ospf_router_id_update_timer.
696 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
697 poke interfaces into action after ID has been configured.
698 (ospf_router_id_update_timer) removed.
699 (ospf_finish_final) t_router_id_update timer is gone.
700 (ospf_network_run) router-id update timer gone.
701 call ospf_router_id_update directly if ID not configured.
702 In the per-iface loop, don't ospf_if_up interfaces if
703 ID is still not configured. The update function will call
704 ospf_if_update anyway.
705 (ospf_if_update) ID update timer is gone. Just return if no
707 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
709 * ospf_zebra.c: (ospf_router_id_update_zebra) call
710 ospf_router_id_update directly, not via timer.
711 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
712 returned LSA of ospf_summary_lsa_refresh and print warning if
714 (ospf_abr_announce_network_to_area) similar
715 (ospf_abr_announce_rtr_to_area) similar
716 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
717 (ospf_router_lsa_originate) similar
718 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
719 (ospf_summary_lsa_new) Check ID is valid.
720 (ospf_summary_lsa_originate) ditto, and check returned LSA from
721 previous function is !NULL.
722 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
724 (ospf_summary_asbr_lsa_new) ID valid check.
725 (ospf_summary_asbr_lsa_originate) similar.
727 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
729 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
730 for use with ospf_timer_dump and ospf_timeval_dump.
731 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
732 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
733 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
734 call to ospf_timer_dump.
736 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
738 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
739 in 'do {...} while(0)'.
741 2005-11-14 Paul Jakma <paul.jakma@sun.com>
743 * ospfd.c: (ospf_new) stub-shutdown should just default to
744 unconfigured, too strange otherwise.
745 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
746 preprocessor conditional on HAVE_OPAQUE_LSA.
747 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
748 no longer used, plus it wasn't in range that the command
750 * ospf_zebra.h: Depends on vty.h, include it.
752 2005-11-11 Paul Jakma <paul.jakma@sun.com>
754 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
755 the nexthops pointing to the root vertex. We may visit a
756 vertex twice or the vertex may have some inherited nexthops,
757 if we free other nexthops we could crash.
759 2005-11-04 Paul Jakma <paul.jakma@sun.com>
761 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
762 function rather than unportable timersub.
764 2005-11-03 Paul Jakma <paul.jakma@sun.com>
766 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
767 * ospf_packet.c: include checksum.h, remove the in_cksum extern
769 * ospf_te.h: Add braces, quell warning.
770 * ospf_packet.c: Change level of some warnings to
773 2005-10-29 Paul Jakma <paul.jakma@sun.com>
775 * (general) RFC3137 stub-router support
776 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
777 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
778 options, to allow shutdown to distinguish between complete
779 shutdown and shutdown of a subset of ospf instances.
781 Add stub_router_{startup,shutdown_}time, configuration of startup
782 and shutdown time for stub-router.
783 Add t_graceful_shutdown struct thread, timer for graceful
785 (struct ospf_area) Add stub_router_state - run time state of
786 stub-router for an area. Add flags for ADMIN, IS and WAS
788 Add t_stub_router, timer thread to resend router-lsa for an
790 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
791 either the given lnks cost or infinite cost if stub-router is
793 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
794 previous function for transit-links.
795 (ospf_stub_router_timer) timer thread for end of startup stub
796 router. Change state as required for the area and setup
797 re-origination of router-lsa.
798 (ospf_stub_router_check) Check/do whether stub-router should be
799 enabled, and whether it requires timer to be setup.
800 (ospf_router_lsa_new) call previous function at top.
801 (ospf_router_lsa_originate) no external callers, made static.
802 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
803 * ospf_main.c: (sigint) make static.
804 remove call to exit, as ospf_terminate now deals with
806 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
807 * ospf_vty.c: (show_ip_ospf_area) print out state of
808 stub-router, if active.
809 (show_ip_ospf) print out configuration of stub-router
810 support, and details of graceful-shutdown if the timer is
812 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
813 commands to (de-)?configure stub-router support.
814 (config_write_stub_router) write out config of stub-router.
815 (ospf_config_write) call previous.
816 (ospf_vty_init) install the new stub-router commands.
817 * ospfd.c: various functions made static.
818 (ospf_new) Set defaults for stub-router. Graceful shutdown
819 is made to default on, just to be adventerous.
820 (ospf_graceful_shutdown_finish) new function, final part of
822 (ospf_graceful_shutdown_timer) timer thread wrapper for
824 (ospf_graceful_shutdown_check) check whether to setup timer
825 for shutdown or proceed directly to final shutdown.
826 (ospf_terminate) moved here from ospf_route.c, call
827 ospf_finish for each instance.
828 (ospf_finish) renamed to ospf_finish_final and made static.
829 (ospf_finish) new function, exported wrapper around
830 ospf_graceful_shutdown_check.
831 (ospf_finish_final) complete shutdown of an instance.
832 Add missing TIMER_OFF's of two timer threads.
833 (ospf_area_free) opaque self lsa timer should be turned off.
835 2005-10-23 Paul Jakma <paul.jakma@sun.com>
837 * ospf_apiserver.c: (ospf_apiserver_term) This function should
838 not have side-effects (eg segv) if no apiserver instances are
839 active, ie be robust.
840 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
841 has not yet been run.
843 2005-10-21 Paul Jakma <paul.jakma@sun.com>
845 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
847 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
850 2005-10-21 Paul Jakma <paul.jakma@sun.com>
852 * (general) SPF millisecond resolution timer with adaptive,
853 linear back-off holdtime. Prettification of ospf_timer_dump.
854 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
855 ospf_timer_dump, but made to be more dynamic in printing out
856 the relative timeval, sliding the precision printed out
857 according to the value.
858 (ospf_timer_dump) guts moved to ospf_timeval_dump.
859 * ospf_dump.h: export ospf_timeval_dump.
860 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
861 the libzebra exported recent_time instead, as it's not
862 terribly critical to have time exactly right - the dropped
863 LSA will be retransmited to us if we don't ACK it.
864 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
865 not transmitting, just putting LSA back on update transmit list.
866 * ospfd.h: delay and holdtimes should be unsigned.
867 Add spf_max_holdtime and spf_hold_multiplier.
868 Update default defines for delay and hold time to be in msec.
869 (struct ospf) change the SPF timestamp to a struct timeval.
870 Remove ospf_timers_spf_(un)?set.
871 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
872 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
873 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
874 now, update with gettimeofday.
875 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
877 Make the holdtime be adaptive, with a linear increase in
878 holdtime ever consecutive SPF run which occurs within holdtime
879 of previous SPF, bounded by spf_max_holdtime.
880 * ospf_vty.c: Update spf timers commands.
881 (ospf_timers_spf_set) trivial helper.
882 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
883 initial hold and max hold times with millisecond resolution.
884 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
885 convert to msec, truncate to new limits.
886 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
887 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
888 (show_ip_ospf_cmd) Display SPF parameters and times.
889 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
891 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
892 the multiple spaces which were making the lines even longer.
893 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
894 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
895 widths for NBMA neighbours.
896 (show_ip_ospf_neighbor_int) Use header function.
897 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
899 (show_ip_ospf_neighbor_detail_sub) ditto
900 (ospf_vty_init) install the new SPF throttle timer commands.
902 2005-10-21 Paul Jakma <paul.jakma@sun.com>
904 * (general) OSPF fast, sub-second hello and 1s dead-interval
906 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
907 Callers typically specify a length of 9, so most see
908 millisecs unless they specify the additional length.
909 * ospf_interface.h: (struct ospf_interface) new interface param,
911 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
913 (ospf_new_if_params) Initialise fast_hello param.
914 (ospf_free_if_params) Check whether fast_hello is configured.
915 (ospf_if_new_hook) set fast_hello to default.
916 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
917 prevent funny side-effects from its if statement when this
918 macro is used conditionally by other macros.
919 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
920 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
921 to whether fast_hello is set.
922 * ospf_ism.c: Update all setting of the hello timer to use
923 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
924 former is used when hello is to be sent immediately.
926 * ospf_packet.c: (ospf_hello) hello-interval is not checked
927 for mismatch if fast_hello is set.
928 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
929 rather than a warning, as it can be perfectly normal to
930 receive packets when logical subnets are used.
931 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
933 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
934 nit, don't vty_out if this command is given, it gets tired
936 (show_ip_ospf_interface_sub) Print the hello-interval
937 according to whether fast-hello is set or not.
938 Print the extra 5 millisec characters from (ospf_timer_dump)
939 if fast-hello is configured.
940 (ospf_vty_dead_interval_set) new function, common to all
941 forms of dead-interval command, to set dead-interval and
942 fast-hello correctly. If a dead-interval is given, unset
943 fast-hello, else if a hello-multiplier is set, set
944 dead-interval to 1 and fast-hello to given multiplier.
945 (ip_ospf_dead_interval_addr_cmd) use
946 ospf_vty_dead_interval_set().
947 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
948 (no_ip_ospf_dead_interval) Unset fast-hello.
949 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
950 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
951 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
952 (config_write_interface) Write out fast-hello.
953 (ospf_config_write) Write a comment about
954 "auto-cost reference-bandwidth" having to be equal on all
955 routers. Hopefully just as noticeable as old practice of
956 writing to vty, but less annoying.
957 (ospf_vty_if_init) install the two new dead-interval
959 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
960 and OSPF_FAST_HELLO_DEFAULT.
962 2005-10-18 Paul Jakma <paul.jakma@sun.com>
964 * (general) SPF memory management cleanup and fix for rare
966 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
967 specific data, eg the backlink and the parent vertex pointer,
968 and point to the appropriate general struct vertex_nexthop.
969 (struct vertex_nexthop) remove parent vertex pointer, so
970 this struct can be shared across vertices.
971 (struct vertex) rename list child to list children. Remove
972 list of nexthops, replace with list of vertex_parents.
973 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
974 (vertex_nexthop_new) remove init of parent - field is gone
975 from struct vertex_nexthop.
976 (ospf_canonical_nexthops_free) Remove the canonical
977 vertex_nexthop memory objects. These are the vertex_nexthops
978 attached to the first level of router vertices from the root.
979 (vertex_parent_new) new function, create a vertex_parent.
980 (vertex_parent_free) ditto, but free it.
981 (ospf_vertex_new) Update to match changes to struct vertex.
982 (ospf_vertex_free) Recursively free a struct vertex and its
983 children. The parent list is used as a reference count.
984 vertex_nexthops must be free seperately, if required.
985 (ospf_vertex_dump) update to match struct vertex changes.
986 Print out backlink of parents too.
987 (ospf_vertex_add_parent) ditto.
988 (ospf_lsa_has_link) update comment.
989 (ospf_nexthop_add_unique) removed, not needed anymore.
990 (ospf_nexthop_merge) ditto.
991 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
992 Simplified to just create vertex_parent and add it.
993 (ospf_spf_flush_parents) new function, flush out the parent
995 (ospf_nexthop_calculation) Take the relevant route_lsa_link
996 as an argument, which simplifies things and removes the need
997 for the hack in ospf_nexthop_add_unique - ospf_spf_next
998 already knew exactly which link the cost calculated was for.
999 Update to match struct vertex changes too.
1000 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
1001 it's there's a vertex already created for W, use it, and
1002 hence there's no need to free it either.
1003 Update some manipulation/comparisons of distance to match.
1004 Flush the parent list if a lower cost path is found.
1005 (ospf_spf_route_free) unused, removed.
1006 (ospf_spf_dump) match the struct vertex changes, and dump the
1008 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
1009 and call ospf_vertex_free on the root vertex to free the
1011 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
1013 * ospf_route.c: (ospf_intra_route_add) ditto
1014 (ospf_route_copy_nexthops_from_vertex) ditto
1016 2005-10-11 Paul Jakma <paul.jakma@sun.com>
1018 * ospf_api.c: sign warnings.
1019 * ospf_apiserver.c: sign warning and convert all the struct
1020 in_addr initialisations so as not to make assumptions about
1021 how this struct is organised, initialise the s_addr member
1023 * ospf_packet.c: Add const qualifier to auth_key.
1025 2005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
1027 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
1028 which now allows snmpwalk to work with ospfIfTable and
1029 also with ospfIfMetricTable
1031 2005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1033 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
1034 (ospf_redist_string) New function implemented using new library
1035 function zebra_route_string(). Note that there are a few differences
1036 in the output that will result: the new function returns strings
1037 that are lower-case, whereas the old table was mixed case. Also,
1038 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
1039 new function returns "ospf6".
1040 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
1041 and add extern const char *ospf_redist_string(u_int route_type)
1043 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
1044 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
1045 * ospf_vty.c: Remove local hard-coded table distribute_str.
1046 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
1047 new library function zebra_route_string() instead of distribute_str[].
1048 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
1049 ospf_redistribute_default_set,ospf_redistribute_check)
1050 In debug messages, use ospf_redist_string() instead of
1051 LOOKUP(ospf_redistributed_proto).
1053 2005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
1055 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
1058 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1060 * ospf_ism.c: generate SNMP traps on Interface state change
1061 * ospf_nsm.c: generate SNMP traps on Neighbour state change
1062 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
1064 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1066 * ospf_vty.c: forece default route LSA to be re_issued whenever
1067 cost is changed ( [no] ip ospf area XXX default-cost YYY)
1068 Support ignore-mtu option
1069 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1070 * ospf_packet.c: support ignore-mtu option
1071 * ospf_interface.h: field added for skipping MTU check
1072 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1073 Set mtu_ignore field to default value
1074 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1075 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1077 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1078 convert OSPFIFSTATE internal status into SNMP values
1080 2005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1082 * ospf_packet.c: use new md5 API
1084 2005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1086 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1087 (nexthop) since it is not used in the function (except inside
1088 some commented-out code).
1089 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1090 Comment out the 5th argument to ospf_external_lsa_flush.
1091 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1092 to ospf_external_lsa_flush.
1093 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1094 uninitialized nexthop arg to ospf_external_lsa_flush.
1095 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1096 to ospf_external_lsa_flush.
1097 * ospfd.c: (ospf_network_set) Comment out 5th arg
1098 to ospf_external_lsa_flush.
1100 2005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1103 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1104 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1106 2005-08-21 Hasso Tepper <hasso at quagga.net>
1108 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1109 Interface should be specified by name now.
1111 2005-08-17 Hasso Tepper <hasso at quagga.net>
1113 * ospf_vty.c: Check carefully if interface exists before trying to
1114 print info about it.
1116 2005-08-05 Hasso Tepper <hasso at quagga.net>
1118 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1119 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1120 for default-information.
1122 2005-07-26 Paul Jakma <paul.jakma@sun.com>
1124 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1125 should be on lsa not old, which may be freed for one thing,
1128 2005-07-12 Paul Jakma <paul.jakma@sun.com>
1130 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1131 OSPF_ABR_CISCO be the default ABR type.
1132 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1133 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1134 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1135 (ospf_config_write) test whether default abr_type against
1136 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1138 2005-06-20 Hasso Tepper <hasso at quagga.net>
1140 * ospf_nsm.c: Make database exchange for NSSA database work.
1142 2005-06-13 Paul Jakma <paul.jakma@sun.com>
1144 * ospf_spf.c: Try get more information on a SEGV under
1145 ospf_spf_vertex_add_parent.
1146 (ospf_vertex_free) NULL out the child and nexthop lists
1147 (ospf_vertex_add_parent) nexthop and child can not be NULL
1148 vertex_nexthop's parent->child list can not be NULL
1149 (ospf_spf_next) w and cw are per-loop iteration variables, move
1150 declarations into loop body.
1152 2005-06-07 Hasso Tepper <hasso at quagga.net>
1154 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1155 changes - oi->ifp->status doesn't give to us info about ISM,
1158 2005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1160 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1162 2005-05-26 Paul Jakma <paul.jakma@sun.com>
1164 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1165 had been fixed long ago by Sowmini.
1167 2005-05-19 Paul Jakma <paul.jakma@sun.com>
1169 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1171 1: this function is supposed to lookup
1172 entries in the oifs ospf_interface route_table and return either
1173 an existing oi or NULL to indicate not found, its caller depends
1174 on this, yet this function uses route_node_get which /always/
1175 returns a route_node - one is created if none exists. Use
1176 route_node_lookup instead. This should fix root cause of the
1177 reports of the (ospf_add_to_if) assert being hit.
1178 2: oi's are inserted into this table with prefixlength set to
1179 /32 (indeed, it should be a hash table, not a route_table),
1180 however prefixlength to lookup was not changed, if no valid entry
1181 can be inserted other than /32, then nothng but /32 should be
1182 looked up. This possibly only worked by fluke..
1183 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1184 backport candidate once it has been incubated in HEAD for a while.
1185 Thanks to Patrick Friedel and Ivan Warren for testing.
1187 2005-05-11 Paul Jakma <paul.jakma@sun.com>
1189 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1190 with much debugging done by by scott collins <scollins@agile.tv>.
1191 * ospf_lsa.c: (ospf_discard_from_db) dont call
1192 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1193 never registered with ase in the first place.
1194 * ospf_packet.c: (general) Disabuse opaque related code of its
1195 tendency to try gather up things into temporary lists.
1196 (ospf_ls_upd) remove the temporary lists opaque uses, call
1197 opaque functions inline, just like all other types.
1198 (ospf_ls_ack) ditto.
1199 (ospf_recv_packet) fixup sign warning.
1200 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1201 untwist some of the logic.
1202 (ospf_opaque_self_originated_lsa_received) take a single LSA
1203 as argument, not a list of them. Remove the list loop. Logic
1204 otherwise unchanged.
1205 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1206 move the actions up into the switch block, remove the goto's and
1207 sanitise the logic near the end a bit.
1208 * ospf_opaque.h: Adjust definitions of aforementioned functions
1209 in ospf_opaque.c to match.
1211 2005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1213 * ospf_network.c: Log ifindex on multicast membership leave/join
1216 2005-05-06 Paul Jakma <paul.jakma@sun.com>
1218 * (general) extern and static qualifiers added.
1219 unspecified arguments in definitions fixed, typically they should
1221 function casts added for callbacks.
1222 Guards added to headers which lacked them.
1223 Proper headers included rather than relying on incomplete
1225 gcc noreturn function attribute where appropriate.
1226 * ospf_opaque.c: remove the private definition of ospf_lsa's
1227 ospf_lsa_refresh_delay.
1228 * ospf_lsa.h: export ospf_lsa_refresh_delay
1229 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1230 correct thing to do - removes need for the casts later.
1231 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1232 home-brewed versions, shuts up several warnings.
1233 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1234 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1235 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1236 overloading of the THREAD_ARG pointer should at least use
1239 2005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1241 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1242 to approve LSAs for the case where metric has changed, lsa gets
1243 flushed otherwise. (backport candidate).
1245 2005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1247 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1250 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1252 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1253 function that does not exist.
1255 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1257 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1258 if_lookup_by_name_len.
1260 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1262 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1264 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1266 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1267 flags to help with debugging.
1268 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1269 to IFINDEX_INTERNAL.
1270 (zebra_interface_if_lookup) Make function static. Tighten up code.
1272 2005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1274 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1277 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1279 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1280 interface changes, print a debug message and call ospf_if_reset()
1281 to simulate down/up on the interface.
1282 * ospf_interface.h: Declare new function ospf_if_reset().
1283 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1284 and ospf_if_up for all ospf interfaces attached to an interface.
1286 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1288 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1289 show MTU. Also make function static.
1290 (ospf_write) Enhance error message to show interface name and MTU.
1291 Also make function static.
1293 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1295 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1296 bandwidth; this is useful for debugging problems. Also, the function
1299 2005-03-27 Hasso Tepper <hasso at quagga.net>
1301 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1304 2005-03-25 Hasso Tepper <hasso at quagga.net>
1306 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1308 2005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1310 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1311 backward, then current time may be less than
1312 ospf->lsa_refresher_started. This was causing invalid values
1313 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1314 Problem fixed by casting the expression to unsigned before taking
1317 2005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1319 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1320 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1321 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1322 (ospf_finish) Call stream_free(ospf->ibuf.
1323 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1324 pass it to ospf_recv_packet for use in receiving the packet
1325 (instead of allocating a new stream for each packet received).
1326 Eliminate all calls to stream_free(ibuf).
1327 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1328 an argument. No need to use recvfrom to peek at the packet
1329 header (to see how big it is), just use ospf->ibuf which is
1330 always large enough (this eliminates a system call to recvfrom).
1331 Therefore, no need to allocate a stream just for this packet,
1332 and no need to free it when done.
1334 2005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1336 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1337 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1338 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1339 * ospf_spf.c: New functions cmp() and update_stat() to manage
1340 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1341 ospf_install_candidate() and ospf_spf_register() functions not needed
1342 any more. Update ospf_vertex_new(), ospf_spf_next() and
1343 ospf_spf_calculate() functions to use pqueue instead of linked list.
1345 2005-02-21 Hasso Tepper <hasso at quagga.net>
1347 * ospf_ase.c: Don't show messages related to the ase calculations if
1348 we are not debugging.
1350 2005-02-19 Hasso Tepper <hasso at quagga.net>
1352 * ospf_api.h: char isn't always signed, but it has to be it here.
1354 2005-02-19 Paul Jakma <paul.jakma@sun.com>
1356 * ospf_packet.c: (ospf_stream_copy) remove
1357 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1359 2005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1361 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1362 packet in the queue, it must be discarded. Improve warning messages.
1363 Fix scope to static.
1364 (ospf_read) Fix bug: should reset the read thread in all cases
1365 to make sure we continue to get incoming messages.
1367 2005-02-15 Paul Jakma <paul.jakma@sun.com>
1369 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1370 ibuf. Thanks Andrew.
1372 2005-02-14 Paul Jakma <paul.jakma@sun.com>
1374 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1376 2005-02-11 Hasso Tepper <hasso at quagga.net>
1378 * ospf_lsdb.c: Fix sum of checksums calculation.
1380 2005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1382 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1385 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1387 * ospf_interface.h: Reduce structure padding by putting new u_char
1388 field multicast_memberships in a better spot (grouped with
1389 other u_char fields type and state).
1391 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1393 * ospf_interface.h: Improve passive_interface comment. Add new
1394 multicast_memberships bitmask to struct ospf_interface to track
1395 active multicast subscriptions. Declare new function
1396 ospf_if_set_multicast.
1397 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1398 multicast memberships properly based on the current
1399 multicast_memberships status and the current values of the
1400 ospf_interface state, type, and passive_interface status.
1401 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1402 now handled by ism_change_state's call to ospf_if_set_multicast).
1403 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1404 handled by ism_change_state).
1405 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1406 the DRouters multicast group (now handled by ism_change_state's call
1407 to ospf_if_set_multicast).
1408 (ism_change_state) Add call to ospf_if_set_multicast to change
1409 multicast memberships as necessary to reflect the new interface state.
1410 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1411 passive interface: 1. Increase the severity of the error message
1412 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1413 message (packet destination address and interface address);
1414 and 3. If the packet was sent to ospf-all-routers, then try
1415 to fix the multicast group memberships.
1416 (ospf_read) When a packet is received on an interface whose state
1417 is ISM_Down, enhance the warning message to show the packet
1418 destination address, and try to update/fix the multicast group
1419 memberships if the packet was sent to a multicast address.
1420 When a packet is received for ospf-designated-routers, but the
1421 current interface state is not DR or BDR, then increase the
1422 severity level of the error message from LOG_INFO to LOG_WARNING,
1423 and try to fix the multicast group memberships.
1424 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1425 any ospf interface that may have changed from active to passive.
1426 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1427 any ospf interface that may have changed from passive to active.
1428 (show_ip_ospf_interface_sub) Show multicast group memberships.
1430 2005-02-08 Paul Jakma <paul@dishone.st>
1432 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1434 2005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1436 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1437 not for event ISM_InterfaceDown. And improve the message by
1438 adding the interface flags.
1440 2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1442 * ospf_network.c: (ospf_sock_init) Save errno before calling
1445 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1447 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1448 an error message and return.
1449 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1450 a warning message and ignore the packet.
1452 2005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1454 * ospf_packet.h: Remove commented out definition of
1455 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1457 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1458 when deciding if an update will fit.
1459 (ospf_packet_authspace): Factor out calculation of size required
1461 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1462 Don't confuse readers that there is a macro.
1464 2004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1466 * ospf_network.c: Improve all setsockopt error messages to give detailed
1467 information on the arguments.
1469 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1471 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1472 messages from LOG_WARNING to LOG_INFO, since this seems to be
1475 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1477 * ospf_packet.c: (ospf_read) Always look up the interface if
1478 ospf_recv_packet returns NULL ifp, since some platforms such
1479 as Solaris 8 appear to support ifindex retrieval but don't.
1481 2004-12-22 Hasso Tepper <hasso at quagga.net>
1483 * ospf_dump.c: Show debug configuration in vtysh.
1484 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1485 any case if it's configured as "translate-never".
1486 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1487 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1488 number of all LSAs with AS scope, this includes opaque as LSAs as
1489 well, show this number separately. Show numbers and sums of
1490 checksums for each type of LSAs.
1491 * ospf_lsa.c: Calculate checksum before putting LSA into database.
1493 2004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1495 * ospf_interface.h: Declare new function ospf_default_iftype.
1496 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1497 this logic in one place.
1498 * ospf_zebra.c: (ospf_interface_add) Use new function
1499 ospf_default_iftype.
1500 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1501 by using new function ospf_default_iftype.
1503 2004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1505 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1506 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1507 messages to include identifying information (e.g. router id).
1508 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1509 router id and state names.
1511 2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1513 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1514 ospf_apiserver * from listnode. Remove unused variables. Follows
1515 suggestion from Jay Fenlason.
1517 2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1519 * *.c: Change level of debug messages to LOG_DEBUG.
1521 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1523 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1525 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1527 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1528 from LOG_NOTICE to LOG_DEBUG.
1530 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1532 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1533 (main) Issue a startup announcement using zlog_notice.
1535 2004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1537 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1538 message and in comment.
1539 (ospf_db_desc) Warning message that a packet is being discarded
1540 should give the router id of the packet source. Fix spelling
1541 of packet in two warning messages.
1542 (ospf_ls_req) Warning message that a link state request is being
1543 discarded should give the router id of the neighbor that sent it.
1545 2004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1547 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1548 lib/debug.h has now been deleted).
1550 2004-11-25 Hasso Tepper <hasso at quagga.net>
1552 * ospf_main.c: Make group to run as configurable.
1554 2004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1556 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1557 and works (lib/zebra.h provides if OS doesn't).
1559 2004-11-15 Paul Jakma <paul@dishone.st>
1561 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1563 2004-11-12 Paul Jakma <paul@dishone.st>
1565 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1566 ignore stub area summary default. Even so it seems a strange
1567 check, add a comment to that effect.
1569 2004-11-04 Paul Jakma <paul@dishone.st>
1571 * ospfd.c: (ospf_network_match_iface) revert to previous network
1572 statement match behaviour.
1574 2004-11-02 Paul Jakma <paul@dishone.st>
1576 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1577 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1578 fixing the unfortunate borkenness introduced in moving of this code
1580 (ospf_write) remove iovp and fix up call to previous.
1581 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1582 glibc's size_t format modifier is not portable.
1584 2004-10-31 Paul Jakma <paul@dishone.st>
1586 * ospf_packet.c: (ospf_write_frags) Add debug output
1587 (ospf_write) set type early, so we can pass it to
1589 (ospf_ls_upd_packet_new) print size in debug output when too large
1590 packet is encountered.
1591 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1592 THREAD_ARG to store an integer, but it should at least use same
1593 same type to retrieve the value. Assert value is sane.
1595 2004-10-22 Paul Jakma <paul@dishone.st>
1597 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1599 * ospf_packet.c: (ospf_read) manually look up ifindex
1600 if system could not have returned one, eg openbsd, thanks to Rivo
1601 Nurges for highlighting problem and fix.
1602 Change setsockopt_pktinfo to setsockopt_ifindex.
1604 2004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1606 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1607 with dedicated subnets properly.
1608 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1609 * ospfd.c: (ospf_network_match_iface) ditto.
1610 (ospf_network_run) ditto.
1611 * ospf_interface.c: (ospf_if_is_configured) ditto.
1612 (ospf_if_lookup_by_prefix) ditto.
1613 (ospf_if_lookup_recv_if) ditto.
1614 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1615 broadcast address if present.
1617 2004-10-13 Hasso Tepper <hasso at quagga.net>
1619 * ospf_main.c: Unbreak compilation with ospfapi disabled.
1620 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1621 snmpd. Connection is initialized only if smux peer is configured.
1623 2004-10-12 Hasso Tepper <hasso at quagga.net>
1625 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1626 static variable from ospf_main.c into ospf_opaque.c.
1628 2004-10-11 Hasso Tepper <hasso at quagga.net>
1630 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1631 command line switch to enable it.
1633 2004-10-11 Paul Jakma <paul@dishone.st>
1635 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1636 remove ntohs that should have dissappeared. Take struct ip
1637 as argument, caller has to know there's an IP header at start of
1639 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1640 * ospf_packet.c: (ospf_write) correct call to
1641 sockopt_iphdrincl_swab_htosys which was munging the header.
1642 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1643 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1645 * (global) Const char update and signed/unsigned fixes.
1646 * (various headers) size defines should be unsigned.
1647 * ospf_interface.h: remove duplicated defines, include the
1648 authoritative header - though, these defines should probably
1649 be moved to a dedicated header, or ospfd.h.
1650 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1651 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
1653 2004-10-08 Hasso Tepper <hasso at quagga.net>
1655 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1656 unsigned, remove unused variables etc.
1658 2004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1660 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1661 use of variable names 'node' and 'nextnode' to avoid possible
1662 conflict with list macros. Move variable declaration inside for
1663 loop after a statement to top of function.
1665 2004-10-07 Paul Jakma <paul@dishone.st>
1667 * ospf_snmp.c: Missed list typedef update
1668 * ospf_dump.c: Include sockopt.h for header swab functions.
1670 2004-10-05 Paul Jakma <paul@dishone.st>
1672 * ospf_packet.c: replace ospf_swap_iph_to... with
1673 sockopt_iphdrincl_swab_...
1675 2004-10-03 James R. Leu <jleu at mindspring.com>
1677 * ospf_zebra.c: Read router id related messages from zebra daemon.
1678 Schedule router-id update thread if it's changed.
1679 * ospfd.c: Remove own router-id selection function. Use router id from
1680 zebra daemon if it isn't manually overriden in configuration.
1682 2004-09-27 Paul Jakma <paul@dishone.st>
1684 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1685 Apply to offset too. Print ip_cksum, lets not worry about
1686 possible 2.0.37 compile problems.
1687 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1688 HAVE_IP_HDRINCL_BSD_ORDER.
1689 (ospf_recv_packet) ditto.
1690 (ospf_write) Fixup iov argument to ospf_write_frags.
1691 (struct msghdr).msg_name is caddr_t on most platforms.
1692 (ospf_recv_packet) ditto. And msg_flags is not always there
1693 memset struct then set fields we care about rather than
1694 initialise all fields individually.
1696 2004-09-26 Hasso Tepper <hasso at quagga.net>
1698 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1699 ospf_zebra.c: Fix compiler warnings.
1701 2004-09-24 Paul Jakma <paul@dishone.st>
1703 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1704 update some list loops to LIST_LOOP. some miscellaneous indent
1706 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1707 referenced node in loop.
1708 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1709 deletes referenced nodes from apiserver_list, fixed.
1710 * ospf_interface.h: lists typedef removal cleanup.
1711 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1712 loops to LIST_LOOP. miscellaneous style and indent fixups.
1713 * ospf_te.{c,h}: ditto
1714 * ospf_packet.c: lists typedef removal cleanup.
1715 (ospf_write) ifdef fragmentation support. move actual
1716 fragmentation out to a new, similarly ifdefed, function.
1717 (ospf_write_frags) fragmented write support, moved from previous.
1719 2004-09-23 Hasso Tepper <hasso at quagga.net>
1721 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1723 2004-09-12 Paul Jakma <paul@dishone.st>
1725 * ospf_packet.c: Fix bugzilla #107
1726 (ospf_packet_max) get rid of the magic 88 constant
1727 (ospf_swab_iph_ton) new function. set ip header to network order,
1728 taking BSDisms into account.
1729 (ospf_swab_iph_toh) the inverse.
1730 (ospf_write) Add support for IP fragmentation, will only work on
1731 linux though, other kernels make it impossible. get rid of the
1733 (ospf_make_ls_upd) Bound check to end of stream, not to
1735 (ospf_ls_upd_packet_new) New function, allocate upd packet
1736 taking oversized LSAs into account.
1737 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1738 rather than statically allocating mtu sized packet buffer, which
1739 actually was wrong - it didnt take ip header into account, which
1740 should not be included in packet buffer.
1741 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1744 2004-08-31 David Wiggins <dwiggins@bbn.com>
1746 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1747 print statements. New function ospf_vertex_dump used in debugging.
1749 2004-08-31 David Wiggins <dwiggins@bbn.com>
1751 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1753 2004-08-31 David Wiggins <dwiggins@bbn.com>
1755 * ospf_route.c: When finding an alternate route, log cost as well.
1757 2004-08-31 David Wiggins <dwiggins@bbn.com>
1759 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1760 struct prefix allocated on stack.
1762 2004-08-31 David Wiggins <dwiggins@bbn.com>
1764 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1765 acks to AllSPFRouters, rather than All-DR.
1767 2004-08-27 Hasso Tepper <hasso at quagga.net>
1769 * ospf_vty.c: Don't print ospf network type under interface only
1770 if interface is in broadcast mode and interface type really is
1771 broadcast. Fixes Bugzilla #108.
1773 2004-08-27 David Wiggins <dwiggins@bbn.com>
1775 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1776 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1779 2004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1781 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
1782 buffer used to get interface index so that it compiles on other
1783 than Linux and includes the required alignment space. Probably
1784 this was only working on sparc/sparc64 because most of
1785 sockaddr_dl was not being written.
1787 2004-08-19 Paul Jakma <paul@dishone.st>
1789 * ospf_packet.c: update to match sockopt renames.
1791 2004-08-04 Paul Jakma <paul@dishone.st>
1793 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1794 Compare only against list head - all nexthops must be same cost
1795 anyway, fixes a reference-listnode-after-delete bug noted by
1797 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1798 candidates attached to root.
1800 2004-07-27 Paul Jakma <paul@dishone.st>
1802 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1803 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1804 ospf_ls_upd_queue_send() - guaranteed segfault.
1806 2004-07-27 Paul Jakma <paul@dishone.st>
1808 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1809 the LSA as then free_opaque_info_per_id() can never unlock (and
1810 free) the LSA. Reported by Gunnar Stigen.
1812 2004-07-23 Paul Jakma <paul@dishone.st>
1814 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1816 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1817 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1819 2004-07-14 Paul Jakma <paul@dishone.st>
1821 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1822 problem reported by Peter Frost amongst others, where function
1823 will spin indefinitely if update list contains LSAs greater than
1824 MTU-headers or other condition leading to update list never being
1825 cleared. Problem of what to do with these LSAs remains.
1826 (ospf_make_ls_upd) add comment about large LSA problem,
1827 indentation cleanup.
1829 2004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1831 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1833 2004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1835 * Makefile.am: Add shlib support.
1837 2004-06-10 Hasso Tepper <hasso@estpak.ee>
1839 * *: Removed ifdefs HAVE_NSSA.
1841 2004-06-06 Paul Jakma <paul@dishone.st>
1843 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1844 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1846 2004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1848 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1849 index is out of range.
1850 ospf_flood.c: endianness fix
1851 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1854 2004-05-10 Hasso Tepper <hasso@estpak.ee>
1856 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1857 to ospf_zebra.c from ospfd.c and add redistribution updates if
1858 route-map is used in redistribution.
1859 * ospf_main.c: Remove now useless call to ospf_init().
1861 2004-05-08 Paul Jakma <paul@dishone.st>
1863 * ospf_zebra.c: Sync with lib/zclient changes
1865 2004-05-05 Paul Jakma <paul@dishone.st>
1867 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1868 defined. Warn at compile and runtime. Use
1869 IPTOS_PREC_INTERNETCONTROL otherwise.
1870 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1871 some of the checks up to ospf_read, return either a
1872 virtual link oi, or NULL.
1873 (ospf_read) Cleanup, make it responsible for checks. Remove
1874 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1875 lookups to use new wrappers exported by ospf_neighbor.
1876 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1877 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1878 neighbour table by router-id for virtual-link ospf_interfaces,
1879 not by peer_addr (which breaks for asymmetric vlinks)
1880 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1882 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1883 address for either end of a virtual-link, and hence potential cost
1886 2004-04-22 Hasso Tepper <hasso@estpak.ee>
1888 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1889 to "summarize" routes in ASBR at the moment.
1891 2004-04-20 Hasso Tepper <hasso@estpak.ee>
1893 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1894 Fixes UNH OSPF_NSSA.1.2a comment.
1895 * ospf_abr.c: Originate default into stub/nssa area even if
1896 summaries are disabled.
1897 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1899 2004-04-19 Hasso Tepper <hasso@estpak.ee>
1901 * ospf_vty.c: Don't warn that export- and import-list can't be
1902 configured to backbone area if they are applied and are working
1905 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1907 * ospf_packet.c: Don't drop packets in Solaris x86.
1910 2004-03-18 Amir Guindehi <amir@datacore.ch>
1912 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1913 Quagga's ospfd in the special situation that a node's opaque
1914 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1916 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1918 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1919 should be configured with the highest cost path within the range,
1922 2004-02-17 Paul Jakma <paul@dishone.st>
1924 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1925 params, nor the interface structure, if an interface delete
1926 message is received from zebra.
1927 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1928 params and interface, ie that which was previously removed in
1929 (ospf_interface_delete) above.
1931 2004-02-11 Hasso Tepper <hasso@estpak.ee>
1932 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1933 if oi doesn't exist any more.
1935 2004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1936 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1937 LSA if it was originated with older router-id ([zebra 14710] #6).
1939 2003-12-08 Mattias Amnefelt <mattiasa@kth.se>
1941 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1944 2003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1946 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1947 while trying not to change semantics. Add ifdefed-out code to
1948 avoid matching ppp interfaces whose destination address does not
1949 also match the prefix under consideration, to help out people with
1950 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1953 2003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1955 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1956 node in body of the loop to avoid chance that route node
1957 is unlocked and deleted before the next iteration tries to
1958 get next route node.
1960 2003-05-24 Kenji Yabuuchi
1962 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1963 match for interface lookup.
1965 2003-05-18 Hasso Tepper <hasso@estpak.ee>
1967 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1970 2003-05-16 Hasso Tepper <hasso@estpak.ee>
1972 * ospf_lsa.c: Fix handling of NSSA
1974 2003-04-23 Hasso Tepper <hasso@estpak.ee>
1976 * ospf_vty.c: fix "router xxx" node commands in vtysh
1978 2003-04-19 Hasso Tepper <hasso@estpak.ee>
1980 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1981 * ospf_routemap.c: sync daemon's route-map commands to have same
1984 2003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1986 * ospf_packet.c: Add missing param to zlog
1987 * ospf_flood.c: remove unused vars
1989 2003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1991 * ospf_interface.c: fix incorrect memset
1993 2003-04-10 Amir Guindehi <amir@datacore.ch>
1995 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1997 2003-04-03 David Watson <dwatson@eecs.umich.edu>
1999 * ospf_lsa.c: byte order fix
2001 2002-03-17 Amir Guindehi <amir@datacore.ch>
2003 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
2004 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
2005 * ospfclient: OSPFAPI demonstration client.
2007 2003-01-23 Masahiko Endo <endo@suri.co.jp>
2009 * ospf_ism.c: NSM event schedule bug fix.
2011 2002-10-30 Greg Troxel <gdt@ir.bbn.com>
2013 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
2015 2002-10-23 endo@suri.co.jp (Masahiko Endo)
2017 * ospf_opaque.c: Update Opaque LSA patch.
2019 2002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
2021 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
2023 2002-10-23 Juris Kalnins <juris@mt.lv>
2025 * ospf_interface.c (ospf_if_stream_unset): When write queue
2026 becomes empty stop write timer.
2028 2002-10-10 Greg Troxel <gdt@ir.bbn.com>
2030 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
2033 2002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2035 * zebra-0.93 released.
2037 2002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2039 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
2040 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
2041 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
2042 Paul Jakma <paulj@alphyra.ie>.
2044 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
2047 2002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2049 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
2051 2001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2053 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
2054 OSPF interface information.
2055 (ospf_delete_from_if): Likewise.
2057 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
2059 2001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2061 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
2062 is OSPF, do not unset redistribute flag.
2064 2001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2066 * zebra-0.92a released.
2068 2001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2070 * zebra-0.92 released.
2072 2001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2074 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2075 configuration display.
2077 2001-07-24 David Watson <dwatson@eecs.umich.edu>
2079 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2080 check for an existing link before connecting the parent and child.
2081 ospf_nexthop_calculation is also modified to check for duplicate
2082 entries when copying from the parent. Finally, ospf_spf_next
2083 removes duplicates when it merges two equal cost candidates.
2085 2001-07-23 itojun@iijlab.net
2087 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2090 2001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2092 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2095 2001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2097 * ospf_zebra.c (config_write_ospf_default_metric): Display
2098 default-metric configuration.
2100 2001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2102 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2104 2001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2106 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2108 (ospfIfMetricEntry): Likewise.
2110 2001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2112 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2113 Lin'Kova" <jen@stack.net>.
2115 2001-03-15 Gleb Natapov <gleb@nbase.co.il>
2117 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2118 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2120 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2122 2001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2124 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2125 (iph.ip_hl << 2) to iph.ip_len.
2127 2001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2129 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2130 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2132 * ospf_zebra.c (zebra_init): Remove zebra node.
2134 * ospfd.c (ospf_area_range_set): Function name is changed from
2136 (ospf_area_range_unset): New function which separated from DEFUN.
2137 New commands are added:
2138 "no area A.B.C.D range A.B.C.D/M advertise"
2139 "no area <0-4294967295> range A.B.C.D/M advertise"
2140 "no area A.B.C.D range A.B.C.D/M not-advertise"
2141 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2143 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2145 2001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2147 * ospf_network.c (ospf_if_add_allspfrouters): Use
2148 setsockopt_multicast_ipv4.
2149 (ospf_if_drop_allspfrouters): Likewise.
2151 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2152 (ospf_network_lsa_install): Likewise.
2153 (ospf_summary_lsa_install): Likewise.
2154 (ospf_summary_asbr_lsa_install): Likewise.
2155 (ospf_external_lsa_install): Likewise.
2156 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2159 2001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2161 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2162 structure when ospfd receive interface delete message to support
2165 2001-02-01 Dick Glasspool <dick@ipinfusion.com>
2167 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2168 command to "not-advertise".
2170 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2173 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2174 updating the area-range, the lowest cost is now saved.
2176 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2177 numbers rather than creating overflow during calculation.
2179 2001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2181 * zebra-0.91 is released.
2183 2001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2185 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2186 NSM_SeqNumberMismatch is scheduled.
2187 (ospf_ls_req): Free ls_upd when return from this function.
2188 (ospf_ls_upd_timer): When update list is empty do not call
2189 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2192 2001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2194 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2195 MaxAge. RFC2328 Section 14.
2196 (ospf_maxage_lsa_remover): Call above function during removing
2199 2001-01-26 Dick Glasspool <dick@ipinfusion.com>
2201 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2202 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2204 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2206 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2208 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2210 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2212 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2214 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2217 * ospfd.c (data_injection): Function to inject LSA. This is
2220 2001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2222 * ospf_route.c (ospf_route_match_same): Remove function.
2223 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2225 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2226 oi->address. Suggested by Matthew Grant
2227 <grantma@anathoth.gen.nz>.
2228 (ospf_zebra_add): Remove function.
2229 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2231 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2233 * ospf_zebra.c: Likewise.
2235 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2237 * ospf_ase.c: Remove OLD_RIB part.
2239 * ospf_route.c: Likewise.
2241 * zebra-0.90 is released.
2243 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2246 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2248 * ospf_route.c (ospf_route_delete): Use
2249 ospf_zebra_delete_multipath.
2251 2001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2253 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2254 from ospf_if_free(). Rewrite whole procudure to support primary
2257 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2258 address deletion process.
2260 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2262 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2263 treatment like FreeBSD.
2265 2001-01-09 endo@suri.co.jp (Masahiko Endo)
2267 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2268 strips IP header size from receiving IP Packet. So we adjust
2269 ip_len to whole IP packet size by adding IP header size.
2271 2001-01-08 endo@suri.co.jp (Masahiko Endo)
2273 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2275 (ospf_serv_sock): Close socket when it is not used.
2277 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2279 (ospf_write): When bind is fined, close sock.
2281 2001-01-07 Gleb Natapov <gleb@nbase.co.il>
2283 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2284 appears when you try to configure bandwidth on the ppp interface
2285 that is not yet configured in ospfd.
2287 2001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2289 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2290 will print nexthops for AS-external routes.
2292 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2293 ASE route under multipath environment.
2294 (ospf_ase_compare_tables): Likewise.
2296 2001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2298 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2300 2000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2302 * ospf_route.c (ospf_route_install): Install multipath information
2305 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2306 multipath information to zebra daemon.
2308 2000-12-25 Dick Glasspool <dick@ipinfusion.com>
2310 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2312 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2315 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2316 leave Type-7 LSA at Lock Count = 2.
2318 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2319 NSSA no P-bit off during Area flooding, but P-bit is turned off
2320 for mulitple NSSA AS flooding.
2322 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2325 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2326 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2329 2000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2331 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2332 found LSA and if the LSA is MAXAGE we should call refresh instead
2335 2000-12-18 Dick Glasspool <dick@ipinfusion.com>
2337 * ospf_abr.c: Removed redundant "...flood" in
2338 announce_network_to_area(). Repaired nssa Unlock by using
2341 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2343 * ospfd.c: Free up all data bases including NSSA.
2345 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2346 discard_callback. Added routine to get ip addr from within the
2349 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2351 * ospf_lsa.h: Added prototype for the below. struct in_addr
2352 ospf_get_ip_from_ifp (struct interface *ifp).
2354 2000-12-14 Gleb Natapov <gleb@nbase.co.il>
2356 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2357 Now maximum packet length may be 65535 bytes (maximum IP packet
2360 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2362 * ospfd.c (config_write_network_area): Remove unnecessary area
2365 2000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2367 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2369 2000-12-13 Gleb Natapov <gleb@nbase.co.il>
2371 * ospfd.c (config_write_network_area): Fix bug in
2372 config_write_network_area function.
2374 2000-12-12 Gleb Natapov <gleb@nbase.co.il>
2376 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2377 LSA's origination and refreshment as same as other type of LSA.
2379 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2381 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2383 2000-12-08 Dick Glasspool <dick@ipinfusion.com>
2385 The bulk of NSSA changes are contained herein; This version will
2386 require manual setting of "always" for NSSA Translator, and will
2387 not perform aggregation yet.
2389 * ospf_dump.c: "debug ospf nssa" is added.
2391 * ospf_dump.h: Likewise.
2393 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2395 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2396 'never, candidate, always'. Change "suppress" to "not-advertise".
2398 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2401 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2404 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2407 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2408 NSSA translator, then do it. Approve the global list, and flush
2411 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2412 Type-5 resulted from a Local Type-7 translation; not used for
2413 flooding, but used for flushing.
2415 * ospf_flood.c: New NSSA flooding.
2417 2000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2419 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2421 (ospf_vl_set_security): Virtual link configuration with
2423 (ospf_vl_set_timers): Set timers for virtual link.
2425 * New commands are added.
2426 "area A.B.C.D virtual-link A.B.C.D"
2427 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2428 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2429 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2430 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2431 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2433 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2434 cryptographic sequence number treatment.
2435 (ospf_check_auth): OSPF input buffer is added to argument.
2436 (ospf_read): Save neighbor's cryptographic sequence number.
2438 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2439 number when neighbor status is changed to NSM down.
2441 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2443 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2444 sequence number to neighbor structure.
2446 2000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2448 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2449 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2451 2000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2453 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2455 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2456 of the OSPF interface.
2457 (no_router_ospf): 'no router ospf' unregister redistribution
2458 requests from zebra.
2460 2000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2462 * ospf_ism.c (ism_change_status): Increment status change number.
2464 * ospf_interface.h (struct ospf_interface): Add new member for
2465 status change statistics.
2467 * Makefile.am: Update dependencies.
2469 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2470 (ospf_interface_delete): OSPF SNMP interface delete.
2472 * ospf_snmp.h: New file is added.
2474 2000-11-23 Dick Glasspool <dick@ipinfusion.com>
2476 * ospfd.h: Add new ospf_area structure member for
2477 NSSATranslatorRole and NSSATranslator state.
2479 * ospfd.c: Provided for eventual commands to specify NSSA
2480 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2481 decimal integer version of area-suppress.
2483 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2485 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2486 translator, advertise Nt bit.
2488 * ospf_route.c: 1st version of "sh ip os border-routers".
2490 2000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2492 * ospfd.c (area_vlink): Virtual link can not configured in stub
2495 2000-11-23 Gleb Natapov <gleb@nbase.co.il>
2497 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2498 slave must resend its last Database Description packet in response
2499 to duplicate Database Description packets received from the
2500 master. For this reason the slave must wait RouterDeadInterval
2501 seconds before freeing the last Database Description packet.
2502 Reception of a Database Description packet from the master after
2503 this interval will generate a SeqNumberMismatch neighbor
2504 event. RFC2328 Section 10.8
2505 (ospf_make_db_desc): DD Master flag treatment.
2507 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2508 nsm_change_status().
2509 (nsm_bad_ls_req): Likewise.
2510 (nsm_adj_ok): Likewise.
2511 (nsm_seq_number_mismatch): Likewise.
2512 (nsm_oneway_received): Likewise.
2514 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2515 last_send_ts for timestemp when last Database Description packet
2518 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2519 there. Call ospf_db_desc_resend() in any case.
2521 2000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2523 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2524 network (suppose you have only one router with interface priority
2525 0). It's router LSA does not contain the link information about
2528 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2529 interface from/to 0 ISM_NeighborChange event should be scheduled
2530 in order to elect new DR/BDR on the network.
2532 * ospf_interface.c (ip_ospf_priority): Likewise.
2534 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2535 retransmit list we need to check whether the present old LSA in
2536 retransmit list is not more recent than the new
2539 2000-11-09 Dick Glasspool <dick@ipinfusion.com>
2541 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2542 area. Any that exit the NSSA area are translated to type-5 LSA's.
2543 The instantiated image is restored after translation.
2544 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2545 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2547 (ospf_ls_ack_send): Likewise.
2549 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2550 local area. Otherwise they are allowed out the area to be
2551 translated by ospf_packet.c.
2553 * ospf_lsa.c: Undo some previous changes for NSSA.
2555 * ospf_lsdb.h: New access for type 7.
2557 2000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2559 * ospf_route.c (ospf_path_exist): New function to check nexthop
2560 and interface are in current OSPF path or not.
2561 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2562 when it is not there. Reported by Michael Rozhavsky
2563 <mrozhavsky@opticalaccess.com>
2565 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2567 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2568 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2571 2000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2573 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2575 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2577 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2580 2000-11-06 Dick Glasspool <dick@ipinfusion.com>
2582 * ospfd.h: Add ait_ntoa function prototype.
2584 * ospfd.c (ait_ntoa): New function for displaying area ID and
2586 (show_ip_ospf_interface_sub): Use ait_ntoa.
2587 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2588 (show_ip_ospf_neighbor_detail_sub): Likewise.
2590 * ospf_route.c (ospf_intra_route_add): Set external routing type
2592 (ospf_intra_add_router): Likewise.
2593 (ospf_intra_add_transit): Likewise.
2594 (ospf_intra_add_stub): Likewise.
2595 (ospf_add_discard_route): Likewise.
2596 (show_ip_ospf_route_network): Use ait_ntoa.
2597 (show_ip_ospf_route_network): Likewise.
2598 (show_ip_ospf_route_router): Likewise.
2600 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2601 (show_lsa_detail_adv_router): Likewise.
2602 (show_ip_ospf_database_summary): Likewise.
2604 * ospf_route.h (struct route_standard): Add new member
2607 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2609 (ospf_update_network_route): Likewise.
2610 (ospf_update_router_route): Likewise.
2612 2000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2614 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2615 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2617 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2619 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2620 Please specify "debug ospf event" for enable logging.
2622 * ospf_ism.c: Do not extern debug flag varible. It is done by
2624 * ospf_asbr.c: Likewise.
2625 * ospf_lsa.c: Likewise.
2626 * ospf_nsm.c: Likewise.
2627 * ospf_zebra.c: Likewise.
2629 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2632 * ospfd.c (router_ospf): Change logging from vty_out() to
2634 (ospf_area_stub_cmd): Likewise.
2636 * ospf_dump.h: Extern term_debug flags.
2637 (OSPF_DEBUG_EVENT): Add new flag.
2638 (IS_DEBUG_OSPF_EVENT): Add new macro.
2640 2000-11-03 Dick Glasspool <dick@ipinfusion.com>
2642 * ospf_flood.c (ospf_process_self_originated_lsa):
2643 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2644 (ospf_flood): Type-5's have no change. Type-7's can be received,
2645 and will Flood the AS as Type-5's They will also flood the local
2646 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2647 during re-fresh will be converted back to Type-7's (if within an
2649 (ospf_flood_through): Incoming Type-7's were allowed here if our
2650 neighbor was an NSSA. So Flood our area with the Type-7 and also
2651 if we are an ABR, flood thru AS as Type-5.
2653 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2654 area and other area.
2656 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2657 exists in DD packet, make it sure that this area is not stub.
2658 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2660 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2661 then discard the lsa. If the LSA is NSSA LSA and the area is not
2662 NSSA then discard the lsa.
2664 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2666 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2667 is not properly set when interface comes up.
2669 2000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2671 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2673 2000-11-01 Dick Glasspool <dick@ipinfusion.com>
2675 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2676 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2678 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2681 2000-10-31 Dick Glasspool <dick@ipinfusion.com>
2683 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2685 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2686 function is added. ALIASES which have "show ip ospf database
2687 nssa-external" is added.
2688 (show_ip_ospf_border_routers): New command "show ip ospf
2689 border-routers" is added.
2691 2000-10-30 Dick Glasspool <dick@ipinfusion.com>
2693 * ospfd.c (router_ospf): NSSA Enabled message is added for
2695 (ospf_area_type_set): Are type set for NSSA area.
2696 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2697 and summary information. If NSSA is enabled pass the information
2698 to ospf_area_type_set().
2699 (area_nssa): New commands are added:
2701 "area <0-4294967295> nssa"
2702 "area A.B.C.D nssa no-summary"
2703 "area <0-4294967295> nssa no-summary"
2704 (ospf_no_area_stub_cmd): Special translation of no_summary into
2705 NSSA and summary information. If external_routing is
2706 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2708 (show_ip_ospf_area): Display NSSA status.
2709 (config_write_ospf_area): Show NSSA configuration.
2711 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2714 2000-10-26 Gleb Natapov <gleb@nbase.co.il>
2716 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2717 those routers that are fully adjacent to the Designated Router;
2718 each fully adjacent router is identified by its OSPF Router ID.
2719 The Designated Router includes itself in this list. RFC2328,
2722 2000-10-23 Jochen Friedrich <jochen@scram.de>
2724 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2725 it is registered. So those variables must be static.
2727 2000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2729 * ospfd.c: Add area_default_cost_decimal_cmd and
2730 no_area_default_cost_decimal_cmd alias.
2732 2000-10-05 Gleb Natapov <gleb@nbase.co.il>
2734 * ospfd.c (ospf_network_new): Fix setting area format.
2735 (no_router_ospf): Check area existance when calling
2736 ospf_interface_down().
2738 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2741 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2743 * zebra-0.89 is released.
2745 2000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2747 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2749 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2752 2000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2754 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2756 2000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2758 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2761 2000-09-25 Toshiaki Takada <takada@zebra.org>
2763 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2764 Add CISCO compatible command.
2766 2000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2768 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2769 area range lookup in OSPF-MIB.
2770 (ospf_area_range_lookup_next): Likewise.
2772 2000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2774 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2777 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2778 EXTERNAL_INFO(type).
2780 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2781 ospf_vl_data_free().
2783 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2784 when ospf_vl_shutdown is called.
2785 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2788 2000-09-21 Gleb Natapov <gleb@nbase.co.il>
2790 * ospf_lsa.c: New implementation of OSPF refresh.
2792 2000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2794 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2796 2000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2798 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2800 2000-09-18 Gleb Natapov <gleb@nbase.co.il>
2802 * ospf_route.h (route_standard): Change member from `struct area'
2805 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2806 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2807 (ospf_abr_process_router_rt):
2808 * ospf_ase.c (ospf_find_asbr_route),
2809 (ospf_find_asbr_router_through_area),
2810 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2811 (process_summary_lsa), (ospf_update_network_route),
2812 (ospf_update_router_route):
2813 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2814 (ospf_intra_add_transit), (ospf_intra_add_stub),
2815 (ospf_route_table_dump), (show_ip_ospf_route_network),
2816 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2817 (ospf_prune_unreachable_routers):
2818 * ospf_spf.c (ospf_rtrs_print):
2819 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2821 2000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2823 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2826 2000-09-13 Gleb Natapov <gleb@nbase.co.il>
2828 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2830 * ospf_network.c (ospf_serv_sock_init): Add socket option
2831 SO_BINDTODEVICE on read socket.
2833 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2836 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2837 (ospf_area_add_if): New function added.
2839 2000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2841 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2844 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2845 starting SPF calculation.
2847 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2849 2000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2851 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2854 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2855 lsa_originate_count.
2856 (ospf_network_lsa_originate): Likewise.
2857 (ospf_summary_lsa_originate): Likewise.
2858 (ospf_summary_asbr_lsa_originate): Likewise.
2859 (ospf_external_lsa_originate): Likewise.
2861 2000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2863 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2864 syntax is IpAddress.
2865 (ospf_admin_stat): New function for OSPF administrative status
2868 2000-09-10 Jochen Friedrich <jochen@scram.de>
2870 * ospf_snmp.c: Implement OSPF MIB skeleton.
2872 2000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2874 * ospf_snmp.c: New file is added.
2876 2000-09-07 David Lipovkov <davidl@nbase.co.il>
2878 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2881 * ospf_interface.c (interface_config_write): Likewise.
2883 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2885 * zebra-0.88 is released.
2887 2000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2889 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2890 when Area is removed.
2892 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2894 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2895 (ZEBRA_ROUTE_CONNECT).
2896 (no_network_area): Likewise.
2898 2000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2900 * ospfd.h (struct ospf): Add distance_table and
2901 distance_{all,intra,inter,external}.
2903 * ospf_zebra.c: Add OSPF distance related functions.
2905 2000-08-15 Gleb Natapov <gleb@nbase.co.il>
2907 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2909 * ospf_lsa.c (ospf_default_external_info),
2910 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2914 (ospf_default_information_originate_metric_type_routemap),
2915 (ospf_default_information_originate_always_metric_type_routemap):
2916 Change name and add route-map function.
2917 (ospf_default_information_originate_metric_routemap),
2918 (ospf_default_information_originate_routemap),
2919 (ospf_default_information_originate_type_metric_routemap):
2922 2000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2924 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2925 restore size from two octet to four.
2927 2000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2929 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2930 AS-external-LSA in 16.6 of RFC2328.
2932 2000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2934 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2935 calculation algorithm.
2937 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2939 2000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2941 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2944 2000-08-10 Toshiaki Takada <takada@zebra.org>
2946 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2947 `auto-cost reference-bandwidth' OSPF router command added.
2949 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2951 * ospf_routemap.c (ospf_route_map_update): New function added.
2952 Add route-map event hook.
2954 2000-08-08 Toshiaki Takada <takada@zebra.org>
2956 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2957 prefix is connected route on OSPF enabled interface, suppress to
2960 2000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2962 * ospf_interface.c (ospf_if_get_output_cost):
2963 New function added. Handle bandwidth parameter for cost
2966 2000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2968 * ospf_interface.c (interface_config_write): Show interface
2969 configuration regardless interface is down.
2971 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2972 route calculate function.
2974 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2976 * ospf_routemap.c: New file added.
2978 * ospf_asbr.c (ospf_reset_route_map_set_values),
2979 (ospf_route_map_set_compare): New function added.
2981 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2982 with AS-external-LSA.
2984 2000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2986 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2987 ospf_zebra_add as metric.
2988 (ospf_ase_calculate_route_add): Likewise.
2990 * ospf_route.c (ospf_route_install): Pass or->cost to
2991 ospf_zebra_add as metric.
2993 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2994 (ospf_zebra_delete): Likewise.
2996 2000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2998 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2999 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
3002 2000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
3004 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
3007 * ospf_interface.c (ospf_if_free): Fix bug of crash with
3008 Point-to-Point interface.
3010 2000-07-27 Michael Rozhavsky <mike@nbase.co.il>
3012 * ospf_flood.c (ospf_process_self_originated_lsa):
3013 Make sure to clear LSA->param (redistributed external information)
3016 2000-07-27 Gleb Natapov <gleb@nbase.co.il>
3018 * ospfd.c (refresh_group_limit), (refresh_per_slice),
3019 (refresh_age_diff): New defun added. Refresher related parameter
3020 can be configurable.
3022 2000-07-27 Akihiro Mizutani <mizutani@dml.com>
3024 * ospf_interface.c (interface_config_write): Print `description'
3025 config directive to work.
3027 2000-07-24 Akihiro Mizutani <mizutani@dml.com>
3029 * ospf_interface.c (ospf_if_init): Use install_default for
3032 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
3034 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
3035 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
3036 This make sending always as many LS update/Ack combined in one ospf
3039 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
3041 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
3042 LSA is AS-external-LSA.
3044 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
3046 2000-07-21 Toshiaki Takada <takada@zebra.org>
3048 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
3049 `default-information originate'. Fix some default originate
3052 2000-07-12 Toshiaki Takada <takada@zebra.org>
3054 * ospf_lsa.c (stream_put_ospf_metric): New function added.
3056 2000-07-12 Toshiaki Takada <takada@zebra.org>
3058 * ospf_lsa.c (show_ip_ospf_database_router),
3059 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
3060 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
3061 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
3062 (show_any_lsa_self): Functions removed.
3064 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
3065 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
3066 New functions added. Replace above functions.
3068 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3070 (show_ip_ospf_database_summary): New functions added. Replace
3073 (show_ip_ospf_database_cmd): DEFUN rearranged.
3074 (show_ip_ospf_database_type_id_cmd),
3075 (show_ip_ospf_database_type_id_adv_router_cmd),
3076 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3077 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3078 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3080 2000-07-11 Toshiaki Takada <takada@zebra.org>
3082 * ospf_asbr.c (ospf_external_info_new),
3083 (ospf_external_info_free): New functions added.
3085 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3086 origination parameter for external-LSA.
3087 Remove member `redistribute'.
3089 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3090 command executed, metric and metric-type values are overridden.
3091 If one of those is changed refresh AS-external-LSAs for appropriate
3094 2000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3096 * ospf_lsa.c (ospf_summary_lsa_refresh),
3097 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3099 * ospf_abr.c (set_metric): New function added.
3101 2000-07-07 Toshiaki Takada <takada@zebra.org>
3103 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3104 (ospf_default_information_originate_type_metric): New defun added.
3105 Metic and Metric type can be set to default route.
3106 (ospf_default_information_originate_always_metric_type):
3107 (ospf_default_information_originate_always_type_metric):
3108 New defun added. Metric and Metric type can be set to default
3111 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3114 2000-07-06 Gleb Natapov <gleb@nbase.co.il>
3116 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3117 on the same interface the LSA was received from.
3119 2000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3121 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3122 command with `write mem'.
3124 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3126 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3127 zebra interface delete event.
3129 2000-07-06 Toshiaki Takada <takada@zebra.org>
3131 * ospf_zebra.c (ospf_default_information_originate),
3132 (ospf_default_information_originate_always): New DEFUN added.
3134 2000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3136 * ospf_route.c (ospf_terminate): Make sure to remove external route
3137 when SIGINT received.
3139 2000-07-03 Gleb Natapov <gleb@nbase.co.il>
3141 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3142 many structure with `no router ospf'.
3144 2000-06-30 Gleb Natapov <gleb@nbase.co.il>
3146 * ospf_neighbor.c (ospf_nbr_new),
3147 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3148 when neighbor enters Exchange state.
3150 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
3152 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3153 ospf_packet.c (ospf_db_desc_proc):
3154 Do not cancel DD retransmit timer when Master.
3156 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
3158 * ospf_abr.c (ospf_abr_announce_network_to_area),
3159 (ospf_abr_announce_rtr_to_area)
3160 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3161 ospf_flood.c (ospf_process_self_originated_lsa),
3162 (ospf_flood_through_area), (ospf_ls_request_delete),
3163 ospf_interface.c (ospf_if_free),
3164 ospf_ism.c (ism_change_status),
3165 ospf_lsa.c (ospf_router_lsa_update_timer),
3166 (ospf_router_lsa_install), (ospf_network_lsa_install),
3167 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3168 (ospf_schedule_lsa_flood_area),
3169 ospf_nsm.c (nsm_change_status),
3170 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3171 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3173 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3175 * ospf_lsa.c (ospf_discard_from_db): New function added.
3177 2000-06-26 Toshiaki Takada <takada@zebra.org>
3179 * ospfd.h (ospf): struct member `external_lsa' name changed to
3182 2000-06-26 Toshiaki Takada <takada@zebra.org>
3184 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3185 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3186 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3187 Functions re-arranged.
3189 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3191 2000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3193 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3194 verification of LS type.
3196 2000-06-20 Gleb Natapov <gleb@nbase.co.il>
3198 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3199 whether rn->info is NULL.
3201 2000-06-20 Toshiaki Takada <takada@zebra.org>
3203 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3204 DR and Backup correctly with `show ip ospf interface' command.
3206 2000-06-20 Toshiaki Takada <takada@zebra.org>
3208 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3209 (ospf_lsa_discard): These functions are used for avoiding
3210 unexpected reference to freed LSAs.
3212 2000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3214 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3217 2000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3219 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3221 2000-06-12 Toshiaki Takada <takada@zebra.org>
3223 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3224 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3227 2000-06-10 Toshiaki Takada <takada@zebra.org>
3229 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3230 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3231 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3232 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3233 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3234 removed for migration to new_lsdb.
3236 * ospf_lsa.c (ospf_summary_lsa_install),
3237 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3238 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3239 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3240 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3241 (ospf_get_free_id_for_prefix): Funcitions removed.
3243 2000-06-09 Gleb Natapov <gleb@nbase.co.il>
3245 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3247 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3248 (ospf_hello): Always copy router-ID when hello is received.
3250 2000-06-08 Gleb Natapov <gleb@nbase.co.il>
3252 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3255 2000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3257 * ospf_ase.c (ospf_asbr_route_same): New function added.
3258 This function makes sure external route calculation more
3261 2000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3263 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3264 network-LSA deletion instead of using ospf_lsdb_delete.
3265 Also cancel network-LSA origination timer.
3267 2000-06-07 Levi Harper <lharper@kennedytech.com>
3269 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3272 2000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3274 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3275 avoid ambiguous else.
3277 * ospf_flood.c (ospf_external_info_check): Likewise.
3279 2000-06-05 Toshiaki Takada <takada@zebra.org>
3281 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3283 2000-06-04 Toshiaki Takada <takada@zebra.org>
3285 * ospf_zebra.c (ospf_default_information_originate),
3286 (no_ospf_default_information_originate): New DEFUN added.
3288 2000-06-03 Toshiaki Takada <takada@zebra.org>
3290 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3291 ospf_lsa.h to ospf_asbr.h.
3293 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3294 (ospf_external_info_delete): Function moved from ospf_lsa.c
3297 2000-06-03 Toshiaki Takada <takada@zebra.org>
3299 * ospf_flood.c (ospf_external_info_check): New function added.
3300 (ospf_process_self_orignated_lsa): Make sure to flush
3301 self-originated AS-external-LSA, when router reboot and no longer
3302 originate those AS-external-LSA.
3304 2000-06-02 Toshiaki Takada <takada@zebra.org>
3306 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3309 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3310 unicast destination packets.
3312 2000-06-02 Toshiaki Takada <takada@zebra.org>
3314 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3315 specified LSA matches.
3317 2000-06-02 Gleb Natapov <gleb@nbase.co.il>
3319 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3322 2000-06-01 Akihiro Mizutani <mizutani@dml.com>
3324 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3325 Replace string `OSPF information\n' with OSPF_STR.
3327 2000-06-01 Toshiaki Takada <takada@zebra.org>
3329 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3332 2000-06-01 Toshiaki Takada <takada@zebra.org>
3334 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3335 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3336 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3337 (term_debug_ospf_packet), (term_debug_ospf_event),
3338 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3339 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3340 variable to use for debug option flags.
3342 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3343 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3344 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3347 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3348 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3349 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3350 (IS_CONF_DEBUG_OSPF): New Macro added.
3352 2000-05-31 Toshiaki Takada <takada@zebra.org>
3354 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3355 Currently this command is used for only debugging.
3357 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3358 for network-LSA when DR has no full neighbors.
3360 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3362 2000-05-30 Toshiaki Takada <takada@zebra.org>
3364 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3365 maxage_lsa_remover when LSA is replaced.
3367 2000-05-25 Gleb Natapov <gleb@nbase.co.il>
3369 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3370 `struct ospf_area' to remove LSA from Link State retransmission list
3371 of neighbor from only one Area.
3373 2000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3375 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3376 overriting old LSA with new LSA.
3378 2000-05-24 Gleb Natapov <gleb@nbase.co.il>
3380 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3383 2000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3385 * ospf_route.c (ospf_intra_add_stub):
3386 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3387 value instead of u_int16_t.
3389 2000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3391 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3392 equal cost path calculation.
3394 2000-05-21 Toshiaki Takada <takada@zebra.org>
3396 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3397 Make sure, when rotuer route is deleted, related external routes
3400 2000-05-20 Toshiaki Takada <takada@zebra.org>
3402 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3405 2000-05-16 Toshiaki Takada <takada@zebra.org>
3407 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3410 * ospfd.h (EXTERNAL_INFO): Macro added.
3411 Substitute `ospf_top->external_info[type]' with it.
3413 2000-05-16 Toshiaki Takada <takada@zebra.org>
3415 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3417 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
3419 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3420 * ospf_lsdb.c (new_lsdb_insert)
3421 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3423 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
3425 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3426 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3428 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3430 2000-05-13 Toshiaki Takada <takada@zebra.org>
3432 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3433 time_t to struct timeval.
3434 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3435 (tv_sub), (tv_cmp): timeval utillity functions added.
3437 2000-05-12 Toshiaki Takada <takada@zebra.org>
3439 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3440 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3442 router-LSA refresh timer related stuff is re-organized.
3444 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
3446 * ospf_interface.c (ospf_vl_set_params):
3447 * ospf_packet.c (ospf_check_network_mask):
3448 * ospf_spf.[ch] (ospf_spf_next):
3449 Remove field address from `struct vertex', and search for peer
3450 address of virtual link in function `ospf_vl_set_params' instead.
3452 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
3454 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3456 2000-05-08 Thomas Molkenbur <tmo@datus.com>
3458 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3459 with ospf_stream_dup() to fix memory leak.
3461 2000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3463 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3464 LSA update without DROther.
3466 2000-05-04 Gleb Natapov <gleb@nbase.co.il>
3468 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3470 2000-05-03 Toshiaki Takada <takada@zebra.org>
3472 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3473 instead linked-list.
3474 (ospf_db_summary_count), (ospf_db_summary_isempty):
3477 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3479 2000-05-02 Gleb Natapov <gleb@nbase.co.il>
3481 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3482 not needed any more, then free them.
3484 2000-05-02 Toshiaki Takada <takada@zebra.org>
3486 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3487 SPF calculation timers related stuff is rearranged.
3489 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3490 SPF timer is scheduled by SPF calculation delay and holdtime
3491 configuration variable.
3493 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3494 forwarding address when nexthop learned by other protocols is
3497 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3498 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3501 2000-05-01 Toshiaki Takada <takada@zebra.org>
3503 * ospf_flood.c (ospf_ls_retransmit_count),
3504 (ospf_ls_retransmit_isempty): New function added.
3506 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3507 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3508 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3509 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3512 2000-04-29 Toshiaki Takada <takada@zebra.org>
3514 * ospfd.c (no_network_area): Add check Area-ID whether specified
3515 Area-ID with prefix matches config.
3517 2000-04-27 Toshiaki Takada <takada@zebra.org>
3519 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3520 remaining withdrawn routes on zebra.
3522 2000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3524 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3525 (ospf_nsm_event): Fix network-LSA re-origination problem.
3527 2000-04-24 Toshiaki Takada <takada@zebra.org>
3529 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3530 with DD retransmission.
3532 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3533 a neighbor disappears.
3535 2000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3537 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3538 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3539 flag to new LSA. when summary-LSA is reoriginatd.
3541 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3542 procedure. Change the condition of interface selection.
3544 2000-04-21 Toshiaki Takada <takada@zebra.org>
3546 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3549 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3550 `show ip ospf neighbor' related commands are re-arranged.
3552 2000-04-20 Toshiaki Takada <takada@zebra.org>
3554 * ospf_dump.c (debug_ospf_zebra): New defun added.
3555 Suppress zebra related debug information.
3557 2000-04-19 Toshiaki Takada <takada@zebra.org>
3559 * ospf_zebra.c (ospf_distribute_list_update_timer),
3560 (ospf_distribute_list_update), (ospf_filter_update):
3561 New function added. Re-organize `distribute-list' router ospf
3564 2000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3566 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3568 2000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3570 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3571 interface transmit_delay.
3573 2000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3575 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3576 Add to schedule router_lsa origination when the interface cost changes.
3578 2000-04-12 Toshiaki Takada <takada@zebra.org>
3580 * ospf_lsa.c (ospf_refresher_register_lsa),
3581 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3583 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3585 2000-03-29 Toshiaki Takada <takada@zebra.org>
3587 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3589 2000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3591 * ospf_lsa.c (ospf_network_lsa):
3592 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3595 2000-03-28 Toshiaki Takada <takada@zebra.org>
3597 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3598 (nsm_oneway_received): Fix bug of NSM state flapping between
3599 ExStart and Exchange.
3601 2000-03-28 Toshiaki Takada <takada@zebra.org>
3603 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3604 change u_int8_t to u_char.
3606 2000-03-27 Toshiaki Takada <takada@zebra.org>
3608 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3610 2000-03-27 Toshiaki Takada <takada@zebra.org>
3612 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3614 2000-03-26 Love <lha@s3.kth.se>
3616 * ospf_packet.c (ospf_write): Chack result of sendto().
3618 2000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3620 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3622 2000-03-23 Libor Pechacek <farco@clnet.cz>
3624 * ospf_lsa.c (ospf_network_lsa)
3625 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3628 2000-03-23 Toshiaki Takada <takada@zebra.org>
3630 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3631 `area A.B.C.D authentication'.
3633 2000-03-22 Toshiaki Takada <takada@zebra.org>
3635 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3636 Suppress all zlog related to LSAs with this config option.
3638 2000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3640 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3642 2000-03-21 Toshiaki Takada <takada@zebra.org>
3644 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3645 Fix bug of memory leak about linklist.
3647 * ospf_flood.c (ospf_flood_through_area): Likewise.
3649 2000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3651 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3652 to identify LSA uniquely. This fix routes lost.
3654 2000-03-18 Toshiaki Takada <takada@zebra.org>
3656 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3659 2000-03-17 Alex Zinin <zinin@amt.ru>
3661 * ospf_spf.[ch]: Bug fix.
3662 The 2nd stage of Dijkstra could consider one vertex
3663 more than once if there is more than one link
3664 between the routers, thus adding extra CPU overhead
3665 and extra next-hops.
3668 2000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3670 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3672 2000-03-14 Toshiaki Takada <takada@zebra.org>
3674 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3675 ospf_path. Actually ignore merging ospf_route with completely same
3678 2000-03-12 Toshiaki Takada <takada@zebra.org>
3680 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3681 external route tag byte order.
3683 2000-03-11 Toshiaki Takada <takada@zebra.org>
3685 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3687 2000-03-09 Toshiaki Takada <takada@zebra.org>
3689 * ospf_lsa.c (ospf_external_lsa_install),
3690 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3691 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3692 LSDB of AS-external-LSAs instead of ospf_lsdb.
3694 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3695 Use for assigning Unique Link State ID instead of
3696 ospf_get_free_id_for_prefix().
3698 2000-03-09 Toshiaki Takada <takada@zebra.org>
3700 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3701 fault reported by George Bonser <george@siteROCK.com>.
3703 2000-03-07 Libor Pechacek <farco@clnet.cz>
3705 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3707 2000-03-06 Toshiaki Takada <takada@zebra.org>
3709 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3711 2000-03-02 Alex Zinin <zinin@amt.ru>
3712 * ospfd.h, ospf_ia.h
3713 New Shortcut ABR code. Now area's flag can be configured
3714 with Default, Enable, and Disable values.
3715 More info will be in the new ver of I-D soon (see IETF web).
3717 2000-02-25 Toshiaki Takada <takada@zebra.org>
3719 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3720 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3721 (ospf_external_lsa_originate_from_queue): New function added.
3722 (ospf_external_lsa): Function removed.
3724 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3725 when listen a route from Zebra, instead creating external route.
3727 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3728 (ospf_asbr_route_add_queue_lsa),
3729 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3732 * ospf_ase.c (process_ase_lsa): Function will not be used.
3733 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3734 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3735 process_ase_lsa () is separated to these functions.
3737 OSPF AS-external-LSA origination is whole re-organized.
3739 2000-02-18 Toshiaki Takada <takada@zebra.org>
3741 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3743 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3744 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3747 2000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3749 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3750 checksum after change Advertised Router field.
3752 2000-02-09 Toshiaki Takada <takada@zebra.org>
3754 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3756 2000-02-08 Toshiaki Takada <takada@zebra.org>
3758 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3759 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3760 Router ID is chosen from all of eligible interface addresses even if
3761 it is not enable to OSPF.
3763 2000-02-08 Toshiaki Takada <takada@zebra.org>
3765 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3766 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3767 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3768 waited to install to LSDB.
3769 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3771 2000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3773 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3774 in the ACK before deleting.
3776 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3777 and no shutdown of the interface.
3779 2000-01-31 Toshiaki Takada <takada@zebra.org>
3781 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3782 packets respond to a Link State Request packet.
3784 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3786 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3787 is not configured and set virtual-link to no-backbone area,
3790 2000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3792 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3795 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3796 treatment. That should be done in OSPF flooding procedure.
3798 * ospf_flood.c (ospf_flood_through_area): Enclose
3799 ospf_check_nbr_loding inside if-else close.
3801 2000-01-31 Toshiaki Takada <takada@zebra.org>
3803 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3805 2000-01-29 Toshiaki Takada <takada@zebra.org>
3807 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3809 2000-01-28 Toshiaki Takada <takada@zebra.org>
3811 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3813 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3815 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3816 removing LSA from nbr->db_summary.
3818 2000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3820 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3821 destination when the link is point-to-point.
3822 (ospf_ls_ack_send_delayed): Likewise.
3824 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3826 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3827 pointer lookup after the node is freed.
3829 2000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3831 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3832 external route, use ospf_top->external_self.
3834 2000-01-27 Toshiaki Takada <takada@zebra.org>
3836 * ospf_lsa.c (ospf_forward_address_get): New function added.
3838 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3839 only when it should be replaced.
3841 2000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3843 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3845 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3848 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3849 change. Self originated LSA is freed but not deleted from lsdb.
3851 2000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3853 * ospf_ism.c (ism_interface_down): Don't use router_id for
3854 detecting self neighbor structure. Instead of that compare
3857 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3859 (ospf_nbr_free): Free last send packet.
3861 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3862 Instead of that src is introduced.
3864 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3866 2000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3868 * ospfd.c: Change part of passive interface implementation. For
3869 passive interface just disabling sending/receiving Hello on the
3872 2000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3874 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3875 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3876 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3877 * ospfd.c (passive_interface): New command passive-interface is
3879 (ospf_config_write): Print passive interface.
3881 2000-01-15 Toshiaki Takada <takada@zebra.org>
3883 * ospf_interface.h (crypt_key): New struct added to store
3884 multiple cryptographic autheitication keys.
3885 (ospf_interface): struct changed.
3887 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3888 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3890 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3891 multiple cryptographic authentication keys.
3893 2000-01-14 Toshiaki Takada <takada@zebra.org>
3895 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3897 Old notation `ospf *' still remains backward compatibility.
3899 1999-12-29 Alex Zinin <zinin@amt.ru>
3900 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3901 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3902 int goes down, also check DD flags correctly (bug fix)
3904 1999-12-28 Alex Zinin <zinin@amt.ru>
3905 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3907 1999-12-23 Alex Zinin <zinin@amt.ru>
3908 * added RFC1583Compatibility flag
3909 * added dynamic interface up/down functionality
3911 1999-11-19 Toshiaki Takada <takada@zebra.org>
3913 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3914 for NSM state change statistics.
3916 1999-11-19 Toshiaki Takada <takada@zebra.org>
3918 * ospfd.c (show_ip_ospf_neighbor_detail),
3919 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3921 1999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3923 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3926 1999-11-11 Toshiaki Takada <takada@zebra.org>
3928 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3929 This macro is expanded to ospf_examine_summaries ()
3930 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3931 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3932 This macro is expanded to ospf_examine_transit_summaries ()
3933 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3935 1999-11-11 Toshiaki Takada <takada@zebra.org>
3937 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3938 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3939 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3940 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3941 (ospf_find_self_external_lsa_by_prefix): Changed to
3942 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3944 1999-11-11 Toshiaki Takada <takada@zebra.org>
3946 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3947 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3949 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3950 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3953 1999-11-10 Toshiaki Takada <takada@zebra.org>
3955 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3956 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3958 1999-11-01 Alex Zinin <zinin@amt.ru>
3960 some correction to LSU processing
3962 * ospf_lsa.c ospfd.h
3963 randomize initial LSA refreshment interval
3964 and limit the size of LSA-group to 10
3965 to let randomization work more effectively.
3967 1999-10-31 Alex Zinin <zinin@amt.ru>
3969 cancel t_network_lsa_self
3970 when freeing int structure
3972 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3973 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3975 Summary and ASE LSA refreshment functions
3976 added---LSA refreshment is paced to 70 LSAs
3977 per sec to avoid link overflow. Refreshment events
3978 are further randomized within a 10 sec interval
3981 Also the sigfault of memcmp() in ospf_lsa_is_different()
3984 1999-10-30 Alex Zinin <zinin@amt.ru>
3986 Fix the bug where MAX_AGE LSAs
3987 are included into the DB summary.
3990 allocate 2*MTU input buffer instead of just MTU
3991 for the cases when the other router mistakenly
3992 sends larger packets thus causing fragmentation, etc.
3995 in nsm_reset_nbr() lists should be freed
3996 not when they are empty.
3998 1999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4000 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
4001 check inside of if (ospf_top).
4003 1999-10-29 Alex Zinin <zinin@amt.ru>
4004 * ospf_lsa.c ospf_lsdb.c :
4005 add assertion in lsa and lsa->data alloc functions,
4006 as well as in lsdb_add for new->data
4008 * ospf_lsdb.c: free hash table correctly
4010 1999-10-28 John Capo <jc@irbs.com>
4012 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
4015 1999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4017 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
4019 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
4021 1999-10-27 Alex Zinin <zinin@amt.ru>
4022 * ospfd, ospf_zebra, ospf_abr
4023 "area import-list" command is added.
4024 This command allows to filter the inter-area routes
4025 injected into an area. Access list hook function
4026 extended to invalidate area exp/imp lists.
4028 1999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
4030 * ospfd.c (ospf_interface_run): Enable to detect P2P network
4031 on an OSPF interface.
4033 1999-10-19 Jordan Mendelson <jordy@wserv.com>
4035 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
4036 in ospf_ls_retransmit_lookup ().
4038 1999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
4040 * ospf_route.c: Workaround about installation of OSPF routes into
4041 the zebra daemon. Add checking of existance routes. Free
4042 ospf_top->old_table if it exists.
4044 1999-10-15 Jordan Mendelson <jordy@wserv.com>
4046 * Add support for MD5 authentication.
4048 1999-10-12 Alex Zinin <zinin@amt.ru>
4049 * ospfd.c, ospfd.h, ospf_abr.c:
4050 a new command "area export-list" was added, it allows
4051 the admin. to control which intra-area routes are
4052 announced to other areas by the ABR
4054 1999-10-12 Alex Zinin <zinin@amt.ru>
4055 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
4056 when "no redistribute" is used after a distribute list
4057 denying some networks was used
4059 1999-10-05 Toshiaki Takada <takada@zebra.org>
4061 * ospf_route.c (ospf_path_dup): New function added.
4063 1999-10-05 Toshiaki Takada <takada@zebra.org>
4065 * ospf_interface.[ch]: Some of VL related funciton name changed.
4067 1999-09-27 Alex Zinin <zinin@amt.ru>
4069 * ospf_zebra.c: Distribute-list functionality added
4071 1999-09-27 Toshiaki Takada <takada@zebra.org>
4073 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4076 1999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4078 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4079 instead of node->next. Reported by Hiroki Ishibashi
4080 <ishibasi@dcd.abk.nec.co.jp>.
4082 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4085 1999-09-23 Alex Zinin <zinin@amt.ru>
4087 * stub area support added
4089 1999-09-23 Alex Zinin <zinin@amt.ru>
4091 * fwd_addr in ASE-LSAs is now set correctly
4092 * ASE routing changed to check the fwd_addr
4093 and skip the route if the addr points to one
4094 of our interfaces to avoid loops.
4096 1999-09-22 Alex Zinin <zinin@amt.ru>
4099 ospf_vls_in_area() added, it returns
4100 the number of VLs configured through the area
4102 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4103 honor correct mem alloc
4105 1999-09-22 Alex Zinin <zinin@amt.ru>
4108 Some OSPF mem types added,
4109 plus more info in "show mem"
4111 1999-09-21 Alex Zinin <zinin@amt.ru>
4114 "area range substitute" added.
4115 It can be used on NAT-enabled (IP-masquarade)
4116 routers to announce private networks
4117 from an area as public ones into the outside
4118 world (not in the RFC, btw :)
4120 1999-09-21 Alex Zinin <zinin@amt.ru>
4123 "area range suppress" added.
4124 This command allows to instruct the router
4125 to be silent about specific ranges, i.e.,
4126 it is a method of route filtering on area
4129 1999-09-21 Alex Zinin <zinin@amt.ru>
4131 * ospfd.c VLs removed when "no network area" executed
4133 1999-09-20 Alex Zinin <zinin@amt.ru>
4135 * ospf_ase.c bug fix for not-zero fwd_addr
4136 and directly connected routes.
4138 1999-09-20 Yon Uriarte <yon@plannet.de>
4140 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4141 checking the length of OSPF packet exceeds MTU or not.
4143 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4146 1999-09-18 Alex Zinin <zinin@amt.ru>
4148 * ospf_lsa.c bug fix for ospf_network_lsa() to
4149 include itself into the RID list
4151 1999-09-10 Alex Zinin <zinin@amt.ru>
4153 * Alternative ABR behaviors IBM/Cisco/Shortcut
4156 1999-09-10 Alex Zinin <zinin@amt.ru>
4158 * router and network-LSA origination
4159 changed to honor MinLSInterval
4161 1999-09-08 Alex Zinin <zinin@amt.ru>
4163 * modified ABR behavior to honor VLs and transit
4166 1999-09-07 Alex Zinin <zinin@amt.ru>
4168 * completed VL functionality
4170 1999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4172 * ospf_asbr.c: New file.
4173 ospf_asbr.h: New file.
4175 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4178 1999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4180 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4181 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4183 1999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4185 * ospf_spf.c (ospf_spf_register): Change name from
4186 ospf_spf_route_add() to ospf_spf_register().
4187 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4189 1999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4191 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4192 lsa->data rather than install new one, when same id lsa is already
4195 1999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4197 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4198 (ospf_network_lsa_install): Likewise.
4199 (ospf_summary_lsa_install): Likewise.
4200 (ospf_summary_asbr_lsa_install): Likewise.
4201 (ospf_external_lsa_install): Likewise.
4203 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4206 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4208 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4211 1999-08-31 Toshiaki Takada <takada@zebra.org>
4213 * ospf_lsa.c (show_ip_ospf_database_summary),
4214 (show_ip_ospf_database_summary_asbr),
4215 (show_ip_ospf_database_external): New function added.
4216 `show ip ospf database summary',
4217 `show ip ospf database asbr-summary'
4218 `show ip ospf database external' command can be used.
4220 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4221 (show_ip_ospf_database_all): show nothing if a type of LSA
4224 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4226 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4227 the node is deleted.
4229 1999-08-31 Toshiaki Takada <takada@zebra.org>
4231 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4233 (ospf_ls_request_new), (ospf_ls_request_free),
4234 (ospf_ls_request_add), (ospf_ls_request_delete),
4235 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4238 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4240 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4242 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4245 1999-08-30 Alex Zinin <zinin@amt.ru>
4248 fix a bug with area range config write
4249 added "show ip ospf" command, it will be enhanced later on
4251 1999-08-30 Alex Zinin <zinin@amt.ru>
4254 updated ospf_router_lsa() to honor flags (B-bit)
4256 1999-08-30 Alex Zinin <zinin@amt.ru>
4259 wrote major functions implementing ABR activity
4261 1999-08-30 Alex Zinin <zinin@amt.ru>
4263 * ospf_ia.c ospf_route.c ospf_route.h
4264 fixed the bug with ospf_route.origin field.
4265 Now it holds pointer to lsa_header
4267 1999-08-30 Alex Zinin <zinin@amt.ru>
4269 * ospf_flood.c ospf_flood.h:
4270 transformed ospf_flood_if_select into ospf_flood_through_area()
4271 added new ospf_flood_if_select() and ospf_flood_through_as()
4273 1999-08-30 Toshiaki Takada <takada@zebra.org>
4275 * ospf_flood.[ch]: New file added.
4277 * ospf_packet.c (ospf_lsa_flooding),
4278 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4280 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4281 (ospf_remove_lsa_from_retransm_list),
4282 (ospf_nbr_remove_all_lsas_from_retransm_list),
4283 (ospf_lsa_remove_from_ls_retransmit):
4284 (ospf_lsa_retransmit): functions move to
4285 ospf_flood.c, and change function's name:
4287 ospf_put_lsa_on_retransm_list ()
4288 -> ospf_ls_retransmit_add ()
4289 ospf_remove_lsa_from_retransm_list ()
4290 -> ospf_ls_retransmit_delete ()
4291 ospf_nbr_remove_all_lsas_from_retransm_list ()
4292 -> ospf_ls_retransmit_clear ()
4293 ospf_lsa_remove_from_ls_retransmit ()
4294 -> ospf_ls_retransmit_delete_nbr_all ()
4295 ospf_lsa_retransmit ()
4296 -> ospf_ls_retransmit_add_nbr_all ()
4298 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4299 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4301 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4303 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4304 route_node_lookup() instead of route_node_get().
4306 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4308 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4310 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4313 1999-08-29 Alex Zinin <zinin@amt.ru>
4315 MaxAge LSA deletion functions added.
4317 1999-08-29 Alex Zinin <zinin@amt.ru>
4319 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4320 when function returns NULL if (rn->info == NULL)
4322 1999-08-29 Alex Zinin <zinin@amt.ru>
4324 added a hack for area range deletion
4326 1999-08-29 Alex Zinin <zinin@amt.ru>
4328 included lsdb field into struct ospf_lsa, to find
4329 LSDB easier when removing MaxAge LSAs.
4331 1999-08-29 Alex Zinin <zinin@amt.ru>
4332 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4333 ospf_packet.c changed to honor new retransmit list
4334 management functions
4336 1999-08-29 Alex Zinin <zinin@amt.ru>
4337 * ospf_neighbor.c , .h added new retransmit list functions.
4339 1999-08-29 Alex Zinin <zinin@amt.ru>
4341 added ospf_ase, ospf_abr, ospf_ia
4343 1999-08-29 Alex Zinin <zinin@amt.ru>
4345 - changed ospf_next_hop_calculation() to include interface
4346 and nexthop addr for directly connected routers---more informative
4347 and solves problem with route installation into the kernel
4348 - changed ospf_nexthop_out_if_addr() to support routers, not only
4350 - added ospf_process_stubs();
4352 1999-08-29 Alex Zinin <zinin@amt.ru>
4354 - changed ospf_router_lsa() to provide correct links
4355 for p-t-p interfaces;
4356 - changed ospf_summary_lsa_install() to support table
4357 of self-originated summary-LSAs;
4358 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4359 - changed ospf_lsa_install() accordingly
4360 - changed show_ip_ospf_database_router_links() to support p-t-p
4362 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4364 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4367 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4369 * ospf_packet.c (ospf_read): Add check of IP src address.
4371 1999-08-28 Alex Zinin <zinin@amt.ru>
4373 added ospf_nbr_lookup_by_routerid()
4375 1999-08-28 Alex Zinin <zinin@amt.ru>
4377 added ABR/ASBR flag definitions and fields;
4378 added iflist field to area structure;
4379 summary_lsa_self and summary_lsa_asbr_self are changed
4381 added ranges field---configured area ranges;
4382 A separate Routers RT added;
4383 area range config commands and config write added
4386 1999-08-28 Alex Zinin <zinin@amt.ru>
4388 ospf_route_free()--added code to free the list of paths;
4389 The following functions added:
4390 ospf_intra_add_router();
4391 ospf_intra_add_transit();
4392 ospf_intra_add_stub();
4393 the last function uses new ospf_int_lookup_by_prefix();
4394 show_ip_ospf_route_cmd()--changed to support new RT structure;
4395 added ospf_cmp_routes()--general route comparision function;
4396 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4397 they are used in ASE and IA routing;
4398 added ospf_subst_route() and ospf_add_route();
4400 1999-08-28 Alex Zinin <zinin@amt.ru>
4402 changed struct ospf_path to include output interface,
4403 changed struct ospf_route to support IA and ASE routing.
4404 added prototypes of the function used in IA and ASE modules.
4406 1999-08-28 Alex Zinin <zinin@amt.ru>
4407 * ospf_lsa.h ospf_lsa.c :
4408 added ospf_my_lsa(), an interface independent version of
4409 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4411 1999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4413 * ospf_interface.c (interface_config_write): Add check for
4416 1999-08-25 Toshiaki Takada <takada@zebra.org>
4418 * ospf_lsa.c (ospf_lsa_dup): New function added.
4420 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4421 interface in debug message.
4423 1999-08-25 Toshiaki Takada <takada@zebra.org>
4425 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4427 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4428 Delayed Link State Acknowledgment is scheduled by timer.
4430 1999-08-25 Alex Zinin <zinin@amt.ru>
4432 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4433 a stub network instead of link to a transit network into
4434 originated router-LSA, bug fixed.
4436 1999-08-24 Toshiaki Takada <takada@zebra.org>
4438 * ospfd.c (ospf_update_router_id): New function added.
4440 * ospf_network.c (ospf_write): Create new socket per transmission.
4441 And select outgoing interface whether dst is unicast or multicast.
4443 * ospf_packet.c: LSA flooding will work.
4445 1999-08-24 VOP <vop@unity.net>
4447 * ospf_route.c: Include "sockunion.h"
4449 1999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4451 * ospf_network.c (ospf_serv_sock_init): Enclose
4452 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4453 not have the definition.
4455 1999-08-23 Toshiaki Takada <takada@zebra.org>
4457 * ospf_packet.c: Fix bug of DD processing.
4459 1999-08-18 Toshiaki Takada <takada@zebra.org>
4461 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4463 1999-08-17 Toshiaki Takada <takada@zebra.org>
4465 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4466 corrected. The bug of `mes_lookup' is fixed.
4467 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4469 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4470 `ospf_add_router_lsa'.
4471 (ospf_network_lsa_install): The name is changed from
4472 `ospf_add_network_lsa'.
4474 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4476 * ospf_interface.c (ospf_if_is_enable): New function added.
4478 1999-08-16 Toshiaki Takada <takada@zebra.org>
4480 * ospf_lsa.h (struct lsa_header): The name is changed from
4482 (struct ospf_lsa): New struct added to control each LSA's aging
4485 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4487 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4488 (ospf_lsa_different), (ospf_lsa_install): New function added.
4490 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4492 1999-08-12 Toshiaki Takada <takada@zebra.org>
4494 * ospf_nsm.c (nsm_reset_nbr): New function added.
4495 KillNbr and LLDown neighbor event call this function.
4497 1999-08-10 Toshiaki Takada <takada@zebra.org>
4499 * ospf_packet.c (ospf_ls_retransmit)
4500 (ospf_ls_upd_timer): New function added.
4501 Set retransmission timer for Link State Update.
4503 1999-07-29 Toshiaki Takada <takada@zebra.org>
4505 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4507 1999-07-28 Toshiaki Takada <takada@zebra.org>
4509 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4510 with IPTOS_PREC_INTERNET_CONTROL.
4512 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4513 if NSM status change.
4515 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4516 Hello packet, when the neighbor goes down.
4518 1999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4520 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4522 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4525 1999-07-25 Toshiaki Takada <takada@zebra.org>
4527 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4530 1999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4532 * ospf_route.c (ospf_route_table_free): New function added.
4534 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4537 * ospfd.h (struct ospf): Add old_table.
4539 * ospf_main.c (sighup): Call of log_rotate () removed.
4541 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4542 area->lsa as self LSA. This should be area->lsa_self.
4544 1999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4546 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4547 (),ospf_zebra_delete () added.
4549 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4551 1999-07-24 Toshiaki Takada <takada@zebra.org>
4553 * ospf_lsa.c: Change LS sequence number treatment.
4554 (ospf_lsa_is_self_originated): New function added.
4555 (show_ip_ospf_database_self_originated): New DEFUN added.
4557 1999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4559 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4561 1999-07-22 Toshiaki Takada <takada@zebra.org>
4563 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4564 (ospf_nexthop_dup): function added.
4565 (ospf_nexthop_calculation): function changed.
4567 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4569 1999-07-21 Toshiaki Takada <takada@zebra.org>
4571 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4573 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4575 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4577 1999-07-21 Toshiaki Takada <takada@zebra.org>
4579 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4581 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4584 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4586 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4587 change behavior according to LSA type.
4588 (ospf_lsa_has_link): Link check function is added.
4590 1999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4592 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4593 SPF calcultion schedule addtition.
4594 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4596 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4598 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4599 header typo correction. Display of router LSA's #link added.
4601 1999-07-19 Toshiaki Takada <takada@zebra.org>
4603 * ospf_packet.c (ospf_check_network_mask): Added new function for
4604 receiving Raw IP packet on an appropriate interface.
4606 1999-07-16 Toshiaki Takada <takada@zebra.org>
4608 * ospfd.c (ospf_router_id): new DEFUN added.
4610 1999-07-15 Toshiaki Takada <takada@zebra.org>
4612 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4613 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4614 (ospf_spf_next_router), (ospf_spf_next_network),
4615 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4618 1999-07-13 Toshiaki Takada <takada@zebra.org>
4620 * ospf_ism.c: fix bug of DR Election.
4622 * ospf_nsm.c: fix bug of adjacency forming.
4624 1999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4626 * ospfd.c (ospf_init): Change to use install_default.
4628 1999-07-01 Rick Payne <rickp@rossfell.co.uk>
4630 * ospf_zebra.c (zebra_init): Install standard commands to
4633 1999-06-30 Toshiaki Takada <takada@zebra.org>
4635 * ospf_dump.c: Whole debug command is improved.
4636 (ISM|NSM) (events|status|timers) debug option added.
4637 (show_debugging_ospf): new DEFUN added.
4639 1999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4641 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4644 1999-06-29 Toshiaki Takada <takada@zebra.org>
4646 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4647 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4649 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4651 * ospf_ism.c (ospf_dr_election): fix DR Election.
4653 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4656 1999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4658 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4660 1999-06-28 Toshiaki Takada <takada@zebra.org>
4662 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4663 `show ip ospf database network' command output.
4665 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4666 Retransmission, Database Summary and Link State Request.
4668 * ospf_packet.c (ospf_ls_req_timer): New function added.
4669 Set Link State Request retransmission timer.
4671 1999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4673 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4676 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4677 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4679 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4680 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4682 1999-06-25 Toshiaki Takada <takada@zebra.org>
4684 * ospf_packet.c: fix bug of DD making.
4685 fix bug of LS-Update reading.
4687 1999-06-23 Toshiaki Takada <takada@zebra.org>
4689 * ospf_packet.c: All type of packets are changed to use
4690 fifo queue structure.
4691 (ospf_fill_header) function added.
4693 1999-06-22 Toshiaki Takada <takada@zebra.org>
4695 * ospf_packet.c (ospf_packet_new): New function added to handle
4696 sending ospf packet by fifo queue structure.
4697 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4698 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4699 (ospf_fifo_free): Likewise.
4701 1999-06-21 Toshiaki Takada <takada@zebra.org>
4703 * ospf_nsm.c (ospf_db_desc_timer): function added.
4704 (nsm_timer_set) function added.
4705 * ospf_dump.c (ospf_option_dump): function added.
4706 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4708 1999-06-20 Toshiaki Takada <takada@zebra.org>
4710 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4711 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4714 1999-06-19 Toshiaki Takada <takada@zebra.org>
4716 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4717 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4718 (if_ospf_hello_interval), (if_ospf_priority),
4719 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4720 argument changed from NUMBER to <range>.
4721 DEFUN (if_ospf_network_broadcast),
4722 DEFUN (if_ospf_network_non_broadcast),
4723 DEFUN (if_ospf_network_point_to_multipoint),
4724 DEFUN (if_ospf_network_point_to_point) functions are combined to
4725 DEFUN (if_ospf_network).
4727 1999-06-18 Toshiaki Takada <takada@zebra.org>
4729 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4730 ospf_lsa_lookup (), ospf_lsa_count () Added.
4732 1999-06-15 Toshiaki Takada <takada@zebra.org>
4734 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4735 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4736 `debug ospf ism' command shows debug message.
4737 `debuf ospf nsm' command shows debug message.
4739 1999-06-14 Toshiaki Takada <takada@zebra.org>
4741 * ospf_lsa.c: ospf_network_lsa () Added.
4742 ospf_lsa_checksum () Added.
4743 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4744 `debug ospf packet' command shows debug message.
4746 1999-06-13 Toshiaki Takada <takada@zebra.org>
4748 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4751 1999-06-11 Toshiaki Takada <takada@zebra.org>
4753 * ospf_dump.c: fix IP packet length treatment.
4755 1999-06-10 Toshiaki Takada <takada@zebra.org>
4757 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4758 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4760 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4761 ospf_make_hello (), ospf_make_db_desc () Added.
4762 ospf_db_desc_proc () Added.n
4764 * Database Description packet can be processed.
4766 1999-06-08 Toshiaki Takada <takada@zebra.org>
4768 * ospf_lsa.c: New file.
4770 1999-06-07 Toshiaki Takada <takada@zebra.org>
4772 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4774 1999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4776 * ospf_spf.[ch]: New file.
4778 1999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4780 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4782 * ospf_zebra.h (zebra_start): Remove struct zebra.
4784 1999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4786 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4787 ntohl for sprintf warning.
4789 1999-05-19 Toshiaki Takada <takada@zebra.org>
4791 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4792 if interface state changes to DR or BDR.
4794 1999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4796 * ospf_main.c (signal_init): SIGTERM call sigint.
4797 (sigint): Logging more better message.
4799 1999-05-12 Toshiaki Takada <takada@zebra.org>
4801 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4803 1999-05-11 Toshiaki Takada <takada@zebra.org>
4805 * ospf_neighbor.c: ospf_nbr_free () Added.
4807 1999-05-10 Toshiaki Takada <takada@zebra.org>
4809 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4810 * Fix bug of `no network' statement, it will work.
4812 1999-05-07 Toshiaki Takada <takada@zebra.org>
4814 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4815 updated by ospf_if_update ().
4817 1999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4819 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4821 1999-04-25 Toshiaki Takada <takada@zebra.org>
4823 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4824 DEFUN (no_if_ospf_dead_interval),
4825 DEFUN (no_if_ospf_hello_interval),
4826 DEFUN (no_if_ospf_priority),
4827 DEFUN (no_if_ospf_retransmit_interval),
4828 DEFUN (no_if_ospf_transmit_delay) Added.
4830 interface_config_write () suppress showing interface
4833 1999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4835 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4837 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4838 of ospf_network { }. So `router ospf' statement in ospfd.conf
4840 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4842 1999-04-25 Toshiaki Takada <takada@zebra.org>
4844 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4845 DEFUN (if_ospf_network_broadcast),
4846 DEFUN (if_ospf_network_non_broadcast),
4847 DEFUN (if_ospf_network_point_to_multipoint),
4848 DEFUN (if_ospf_network_point_to_point),
4849 DEFUN (no_if_ospf_network) Added.
4851 1999-04-23 Toshiaki Takada <takada@zebra.org>
4853 * ospfd.h: struct area { } changed to struct ospf_network { }.
4854 Add struct ospf_area { }.
4855 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4856 and ospf_network_free ().
4857 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4859 1999-04-22 Toshiaki Takada <takada@zebra.org>
4861 * ospf_lsa.h: New file.
4862 * ospf_packet.h: LSA related struct definition are moved to
4864 * ospf_packet.c: ospf_verify_header () Added.
4866 1999-04-21 Toshiaki Takada <takada@zebra.org>
4868 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4869 DR Election bug fixed.
4870 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4871 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4873 1999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4875 * ospf_main.c (main): access_list_init () is added for vty
4876 connection filtering.
4878 1999-04-16 Toshiaki Takada <takada@zebra.org>
4880 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4881 * ospf_neighbor.c: ospf_nbr_count () Added.
4883 1999-04-15 Toshiaki Takada <takada@zebra.org>
4885 * ospfd.h: struct ospf { } Changed.
4886 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4887 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4889 1999-04-14 Toshiaki Takada <takada@zebra.org>
4891 * ospf_ism.c: ospf_elect_dr () Added.
4892 * ospf_network.c: ospf_if_ipmulticast () Added.
4894 1999-04-11 Toshiaki Takada <takada@zebra.org>
4896 * ospf_interface.c: interface_config_write (),
4897 DEFUN (if_ip_ospf_cost),
4898 DEFUN (if_ip_ospf_dead_interval),
4899 DEFUN (if_ip_ospf_hello_interval),
4900 DEFUN (if_ip_ospf_priority),
4901 DEFUN (if_ip_ospf_retransmit_interval) and
4902 DEFUN (if_ip_ospf_transmit_delay) Added.
4904 1999-04-08 Toshiaki Takada <takada@zebra.org>
4906 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4907 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4908 * ospf_nsm.c: nsm_twoway_received () Added.
4910 1999-04-02 Toshiaki Takada <takada@zebra.org>
4912 * ospf_neighbor.c: New file.
4913 * ospf_neighbor.h: New file.
4914 * ospf_nsm.c: New file.
4915 * ospf_nsm.h: New file.
4916 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4917 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4919 1999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4921 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4923 1999-03-19 Toshiaki Takada <takada@zebra.org>
4925 * ospf_packet.c: New file.
4926 * ospf_packet.h: New file.
4927 * ospf_network.c: New file.
4928 * ospf_network.h: New file.
4929 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4931 1999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4933 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4936 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4937 for install ospfd.conf.sample as owner read only file.
4939 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4941 1999-03-15 Toshiaki Takada <takada@zebra.org>
4943 * ospf_ism.c: New file.
4944 * ospf_ism.h: New file.
4945 * ospf_dump.c: New file.
4946 * ospf_dump.h: New file.
4948 * ospfd.h: Add (struct ospf), (struct config_network),
4949 (struct message) structure.
4951 * ospf_interface.c: Add ospf_if_match_network ().
4952 * ospf_interface.h (struct ospf_interface): Change struct members.
4954 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4955 DEFUN (network_area): Added.
4957 * ospfd.conf.sample: Change sample configuration.
4959 1999-03-05 Toshiaki Takada <takada@zebra.org>
4961 * ospf_interface.c: New file.
4962 * ospf_interface.h: New file.
4963 * ospf_zebra.h: New file.
4964 * ospf_zebra.c: Add interface function for zebra daemon.
4965 * ospfd.c: New file.
4967 1999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4969 * Move IPv6 codes and files to ospf6d directory.
4971 1999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4973 * syslog support added
4975 1998-12-22 Toshiaki Takada <takada@zebra.org>
4977 * ospfd.h: New file.
4978 * ospf_lsa.h: New file.
4980 1998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4982 * Makefile.am: New file.
4983 * ospf_main.c: New file.