1 2007-08-21 Denis Ovsienko
3 * ospfd.h: Extend struct ospf with maxsndbuflen field and
4 define its default value.
5 * ospfd.c: (ospf_new) init maxsndbuflen
6 * ospf_interface.c: (ospf_if_up) Call ospf_adjust_sndbuflen()
7 for each regular interface being brought up.
8 * ospf_network.[ch]: (ospf_adjust_sndbuflen) New function
9 makes sure ospf socket sending buffer is large enough
10 to cover the biggest interface MTU we have seen ever.
11 * ospf_packet.c: (ospf_write) Use maxsndbuflen to decide on
12 the biggest amount of data we are going to send at once.
14 2007-08-07 Paul Jakma <paul.jakma@sun.com>
16 * ospf_spf.c: (ospf_spf_next) Finish off the explanatory
17 comment made in previous commit
19 2007-08-07 Atis Elsts <atis@mikrotik.com>
21 * ospf_spf.c: (ospf_spf_next) Sort heap in correct direction
22 after vertex cost is changed, thus fixing incorrect SPF
23 calculation on certain topologies.
25 2007-08-06 Paul Jakma <paul.jakma@sun.com>
27 * ospf_lsa.c: (router_lsa_flags) Bug #331, NSSA regression caused
28 caused ASBRs to not advertise E-bit into NSSA areas.
30 2007-05-09 Milan Kocian <milon@wq.cz>
32 * ospf_vty.c: Fix commands: 'ip ospf authentication A.B.C.D',
33 'no ip ospf authentication A.B.C.D', 'no ip ospf
34 authentication-key A.B.C.D'. Simply fix argv's indexes and
35 argc check in DEFUN functions.
37 2007-05-07 Paul Jakma <paul.jakma@sun.com>
39 * ospf_spf.c: (ospf_vertex_new) Dont init vertices to infinity,
40 just let 0 be a special case.
41 (ospf_spf_add_parent) 0 distance candidate vertex is special,
42 cost still to be initialised - asserting that new distance
43 is <= existing only makes sense where w already has a cost.
44 (ospf_spf_next) Infinite cost links should not be followed,
45 bar those of the root.
47 2007-04-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
49 * ospfd.c: (ospf_network_match_iface) Comment out
50 COMPATIBILITY_MODE. Going forward, the ospf "network" command
51 will use a simple test: does the network command prefix
52 contain the connected (destination) prefix of the interface?
54 2007-04-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
56 * ospf_interface.c: (ospf_if_set_multicast) Fix bug: was testing
57 interface passive status improperly in light of the recent
58 'passive-interface default' patch. Now need to test
59 OSPF_IF_PASSIVE_STATUS(oi) instead of
60 OSPF_IF_PARAM(oi, passive_interface).
62 2007-03-23 Paul Jakma <paul.jakma@sun.com>
64 * ospf_spf.c: (various) Add more debug statements.
65 (ospf_nexthop_calculation) Fix silly regression causing ospfd
66 to fail to calculate paths past networks not attached to root
67 vertex, introduced with bug #330 fixes.
69 2007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
71 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
72 map internal quagga neighbor states to SNMP standard values.
73 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
75 2007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
77 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
78 where inet_ntoa was used twice in the same debug message,
79 which doesn't work because there's a single shared buffer
80 for the returned string. The fix is to use inet_ntop.
82 2007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
84 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
85 actually running (e.g. the config file was empty). Fixes
86 bug where SIGTERM would not kill ospfd.
88 2007-02-26 Paul Jakma <paul.jakma@sun.com>
90 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
91 cost update added to ospf_spf_add_parent only handled PtP
92 case, differing from same functionality in higher-level
93 ospf_spf_next. Regression diagnosed by Anders Pedersen,
94 mailnews+router-quagga-dev@news.cohaesio.com.
95 (ospf_vertex_new) Initialise vertices to max-cost.
96 (ospf_spf_init) Root vertex always creates with 0 cost.
97 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
98 code, instead take the new distance as a parameter.
99 (ospf_nexthop_calculation) Take distance as parameter, so it
100 can be passed down to add_parent.
101 (ospf_spf_next) Dont initialise candiate vertex distance,
102 vertex_new does so already. Pass distance down to
103 nexthop_calculation (see above).
105 2007-01-24 Paul Jakma <paul.jakma@sun.com>
107 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
108 and it needs to indicate this result to SPF.
109 (ospf_spf_add_parent) Flush of parent list needs to be done here,
111 (ospf_nexthop_calculation) Caller needs to know whether
112 nexthop calculation succeeded. Every return statement must
113 correctly indicate such.
114 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
115 must take into account whether nexthop_calculation succeeded,
116 or SPF may fail to find best paths.
118 2006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
120 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
121 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
123 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
124 macro, both options collapse into the same code.
125 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
127 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
129 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
130 instead of testing the IFF_POINTOPOINT flag.
131 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
132 instead of testing with if_is_pointopoint. And add commented-out
133 code to implement alternative (in my opinion) more elegant behavior
134 that has no special-case treatment for PtP addresses.
135 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
137 2006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
139 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
140 Previously, after creating a single ospf_interface on a given
141 network interface, the code would skip to the next interface
142 without considering other connected addresses on the interface.
143 After removing the 'break', we now consider all connected addresses.
145 2006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
147 * ospf_zebra.c: (ospf_router_id_update_zebra,
148 ospf_interface_address_add, ospf_interface_address_delete)
149 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
150 add a debug message about what Zebra is telling us.
151 (ospf_zebra_add_discard) Add a debug message matching the one
152 already in ospf_zebra_delete_discard.
154 2006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
156 * ospf_vty.c: (ospf_passive_interface_default) Take additional
157 'newval' arg so we can update ospf->passive_interface_default inside
158 this function. More importantly, we now call ospf_if_set_multicast
159 on all ospf_interfaces.
160 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
161 for 'default' case, argv[0] is undefined, so we must test for
162 (argc == 0) before using argv[0]. And since
163 ospf_passive_interface_default now calls ospf_if_set_multicast as
164 needed, we can just return after calling
165 ospf_passive_interface_default.
167 2006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
169 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
170 a new value for ospf->default_originate was being ignored
171 if a previous 'default-information originate' command
172 had already been processed.
174 2006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
176 * (general) Add support for passive-interface default (with
177 minor edits by Paul Jakma).
178 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
179 at configured value, or the global 'default' value, as
181 * ospf_interface.c: (ospf_if_new_hook) Leave passive
182 unconfigured per default, allowing global 'default' to
183 take effect for unconfigured interfaces.
184 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
185 * ospf_vty.c: (ospf_passive_interface_default) new function,
186 unset passive from all interfaces if default is enabled, as
187 the per-iface settings become redundant.
188 (ospf_passive_interface_update) new func, update passive
189 setting taking global default into account.
190 ({no,}ospf_passive_interface_addr_cmd) Add support for
191 'default' variant of command.
192 (show_ip_ospf_interface_sub) Update to take global
193 default into account when printing passive status.
194 (ospf_config_write) ditto.
195 * ospfd.c: (ospf_new) set global passive-interface default.
196 * ospfd.h: (struct ospf) Add field for global
199 2006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
201 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
202 Fix zlog_warn messages to eliminate compiler warnings.
203 (ospf_hello) Improve warning messages to show why we
206 2006-08-28 Andy Gay <andy@andynet.net>
208 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
209 fixes does not hold up with addition of Ogier DB-Exchange
210 optimisation, which can empty the db-summary list in between
211 sent DD packets. Remove assert, update More-bit always when
214 2006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
216 * ospfd.c: (ospf_finish_final) default redistribute should be
217 unset too, fixes bug where reconfiguring ospfd completely
218 can no longer enable default redistribution.
220 2006-08-25 Paul Jakma <paul.jakma@sun.com>
222 * (general) Bug #134. Be more robust to backward time changes,
223 use the newly added libzebra time functions.
224 In most cases: recent_time -> recent_relative_time()
225 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
227 (ospf_make_md5_digest) time() call deliberately not changed.
228 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
229 tv_orig time was already set in ospf_lsa_new, called via
230 ospf_external_lsa_new.
232 2006-08-04 Paul Jakma <paul.jakma@sun.com>
234 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
235 exact same functionality replicated in other functions.
236 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
237 (ospf_lsdb_delete) ditto.
238 (ospf_lsdb_delete_all) ditto.
240 2006-08-03 Paul Jakma <paul.jakma@sun.com>
242 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
243 after constructing the packet, if appropriate.
244 (ospf_db_desc_proc) Speed up Exchange, slave should raise
245 ExchangeDone earlier, as RFC mandates, by forming its reply
246 before deciding whether both sides are done, avoids a
247 needless round of empty DD packet exchanges at the end of
248 Exchange, hence speeding up ExchangeDone.
249 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
250 (ospf_db_desc) use UNSET_FLAG macro.
252 2006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
254 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
255 selecting the router ID: if there is not a statically configured ID,
256 then stick to the most recent value to avoid disruptive changes.
257 This should fix bug #288.
259 2006-07-26 Paul Jakma <paul.jakma@sun.com>
261 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
262 to the LSA to be 'unlocked', so that, if the LSA is freed, the
263 callers pointer to the LSA can be NULLed out, allowing any further
264 use of that pointer to provoke a crash sooner rather than later.
265 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
266 previous. Try annotate 'locking' somewhat to show which 'locks'
267 are protecting what LSA reference, if not obvious.
268 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
269 goto, replace with return.
270 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
271 the dual-loop predated the delete-safe list-loop macro.
273 2006-07-25 Paul Jakma <paul.jakma@sun.com>
275 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
276 neighbour state statistics fields, timestamps for progressive
277 and regressive state changes, and pointer to event string
278 for the latter state change.
279 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
281 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
282 new per-neighbour state change stats.
284 2006-07-10 Paul Jakma <paul.jakma@sun.com>
286 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
287 adjacency losses, hence removing need for nsm_reset_nbr.
288 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
289 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
290 (ospf_nsm_event) Allow NSM function to be NULL, this along with
291 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
293 Remove some useless variables.
294 (nsm_ignore) now useless, remove.
295 (nsm_bad_ls_req) ditto
296 (nsm_seq_number_mismatch) "
297 (nsm_oneway_received) "
298 (nsm_inactivity_timer) "
300 (NSM) replace removed action functions with NULL.
301 (nsm_notice_state_changes) Move state change logging code to new
302 func to declutter nsm_change_state and ospf_nsm_event.
303 Log event with AdjChange, it's useful to know.
304 (nsm_change_state) move adjchange and snmp logging to previous.
305 (ospf_nsm_event) call nsm_notice_state_changes from here.
306 Move the debug message to entry of function, so it gets out
307 even if something goes wrong.
308 Record state change timestamp and event in nbr struct.
309 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
310 timestamp of last NSM change and event.
311 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
312 last state change timestamp and event, if available.
314 2006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
316 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
317 message to include interface name and conflicting prefix lengths.
319 2006-07-07 Paul Jakma <paul.jakma@sun.com>
321 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
322 state indicating the neighbour is to be deleted.
323 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
324 neighbours, thus allowing code to be slightly more obvious
326 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
328 (nsm_kill_nbr) No need for special case call to nsm_change_state
330 Make the assert and error-handling for same case more readable
332 Remove the call to ospf_nbr_delete, nsm_change_state can do
333 this generally now via NSM_Deleted.
334 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
335 that can lead to nsm_kill_nbr all now transition the NBR to
336 NSM_Deleted and the general change_state function can be left
338 (ospf_nsm_event) Special casing of events and early-return can
340 On transition into Deleted, delete the nbr.
341 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
343 2006-07-06 Paul Jakma <paul.jakma@sun.com>
345 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
346 being deleted, requires early-return too. Likely explains
347 some crash reports after interface events.
349 2006-07-04 Paul Jakma <paul.jakma@sun.com>
351 * ospf_nsm.c: (general) Various small cleanups from Andrew's
352 review of last set of patches.
353 (nsm_timer_set) Loading, Full and default can share
355 (nsm_should_adj) Can just be one big OR.
356 (nsm_twoway_received) Collapse into return statement.
358 2006-07-02 Paul Jakma <paul.jakma@sun.com>
360 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
361 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
362 (nsm_twoway_received/nsm_adj_ok) Use former.
363 (nsm_clear_adj) clear adjacency related state for a
364 neighbour, needed for some state changes from > ExStart down
365 to ExStart or less, which need not go through nsm_reset_nbr.
366 (nsm_reset_nbr) move code to former. Should be static.
367 (ospf_nsm_event) Don't allow action functions to change
368 next_state if the NSM tables do not indicate next_state is
369 conditional, log warning if one tries - existing code
371 Remove long dead code.
372 Use nsm_clear_adj for state changes that take down
373 adjacencies to TwoWay/ExStart.
374 (nsm_timer_set) ls_req timer should be OFF in early states.
375 Compact several identical sections.
376 Set inactivity timer to OFF for Down, for documentary
378 (nsm_kill_nbr) Oops, action function shouldn't try return
380 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
382 2006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
384 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
385 of that neighbor (since it may appear on multiple interfaces)
386 instead of bailing out after showing the first match.
388 2006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
390 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
391 change from state Init to ExStart, the test for whether the
392 neighboring router is DR or BDR should be against the
393 local router's notion of DR/BDR, not the neighbor's view.
395 2006-06-28 Erik Muller <erikm@internap.com>
397 * ospfd.h: Define 2 new struct ospf config flags:
398 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
399 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
401 * ospf_vty.c (ospf_log_adjacency_changes): New command function
402 to implement ospf subcommand "log-adjacency-changes [detail]".
403 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
404 (show_ip_ospf) Show whether adjacency changes are logged.
405 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
406 (ospf_vty_init) Add ospf_log_adjacency_changes and
407 no_ospf_log_adjacency_changes.
409 2006-06-26 Paul Jakma <paul.jakma@sun.com>
411 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
412 be ASBRs, or other routers may rightfully refuse to install
413 translated type-5s LSAs. reported by dendroot@gmail.com.
414 (ospf_abr_nssa_check_status) Detect change in translator
415 state when ABR, and inc/dec redistribute count as when we
416 leave/enter the disabled state - so that translate-enabled
417 ABR properly sets ASBR bit on non-NSSA areas.
418 Run the resulting function through indent to clean it up.
419 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
420 NSSA area is same as stub area.
422 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
424 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
425 info log message to indicate why the trap is being sent.
427 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
429 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
430 status properly (not ism status).
432 2006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
434 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
435 with a call to if_get_by_name -- if the interface does not exist
436 already, it should be created. And remove the obsolete warning
439 2006-06-15 Paul Jakma <paul.jakma@sun.com>
441 * ospf_interface.h: (struct ospf_if_info) Add reference counts
442 for multicast group memberships. Add various macros to help
443 manipulate/check membership state.
444 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
445 ospf_if_info reference counts, and only actually drop
446 memberships if it hits 0, to avoid losing membership when
447 OSPF is disabled on an interface with multiple active OSPF
449 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
451 multicast membership.
452 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
454 2006-05-31 Paul Jakma <paul.jakma@sun.com>
456 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
458 * ospf_lsa.c: (ospf_discard_from_db) ditto.
459 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
460 mitigation (but not solution) for bug #269.
462 2006-05-30 Paul Jakma <paul.jakma@sun.com>
464 * ospf_packet.c: (ospf_read) Debug message about packets
465 received on unenabled interfaces should be conditional on
468 2006-05-23 Paul Jakma <paul.jakma@sun.com>
470 * ospf_vty.c: (general) Replace in-place route redistribution
471 command and help strings with the new auto-generated defines
472 from lib/route_types.h
474 2006-05-13 Paul Jakma <paul.jakma@sun.com>
476 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
477 check to match the assert, small error in CID #13 fix.
479 2006-05-12 Paul Jakma <paul.jakma@sun.com>
481 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
482 call, which is not checked for NULL return, by stripping out
483 functionality which is never used, hence fixing Coverity CID
485 (struct lsa_action) remove unused member.
486 (ospf_translated_nssa_refresh) Add non-assert sanity check,
487 in case DEBUG isn't defined.
488 Debug message when no type7 exists should print the ID from
489 the type5, not the type7, fixes CID #13.
490 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
491 check on ospf_lookup, CID #27.
492 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
493 call by taking the struct ospf * as argument, which the
494 caller has, fixing CID #28.
495 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
496 * ospf_zebra.c: (ospf_redistribute_unset) update call to
497 ospf_redistribute_withdraw to match.
498 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
499 NULL when passed to ospf_find_asbr_route_through_area,
500 check for NULL first, CID #14.
501 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
502 useless, it's always valid. Only possibility where it
503 couldn't be is if there is a race between abr_task and
504 cleaning up oi's, in which case a NULL check here isn't going
505 to do anything. Fixes CID #15.
507 2006-05-11 Paul Jakma <paul.jakma@sun.com>
509 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
510 ensure check for NULL result, make vty messages consistent.
511 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
512 result, fixes Coverity CID #70.
513 (no_ospf_area_filter_list) Check NULL result from
514 ospf_area_lookup_by_area_id, fixes Coverity CID #69
515 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
516 NULL check by moving into check-protected block, fix CID #49.
517 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
518 range, should just lookup to see if one exists, the new range
519 is just leaked. Fixes CID #46.
520 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
521 take (struct ospf *) as thread argument, rather than (struct
522 ospf *)->default_originate, thus avoiding having to call
524 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
525 of ospf_default_originate_timer thread to match.
526 * ospfd.c: (ospf_router_id_update) ditto.
528 2006-04-24 Paul Jakma <paul.jakma@sun.com>
530 * (general) More Virtual-link fixes, again with much help in
531 testing / debug from Juergen Kammer. Primarily in SPF.
532 * ospf_spf.h: Add guard. ospf_interface.h will include this
534 * ospf_interface.h: Modify ospf_vl_lookup definition to take
535 struct ospf as argument, so as to allow for NULL area
537 (struct ospf_vl_data) Remove out_oi, instead add a struct
538 vertex_nexthop, to use as initial nexthop for backbone paths
540 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
541 NULL area to be passed to indicate "any" (first) area.
543 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
544 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
546 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
547 backbone, don't bother checking.
548 * ospf_spf.c: (static struct list vertex_list) Record vertices
549 that will need to be freed.
550 (cmp) Order network before router vertices, as required,
552 (vertex_nexthop_free) Mild additional robustness check.
553 (vertex_parent_free) Take void argument, as this function
554 is passed as list deconstructor for vertex parent list.
555 (ospf_vertex_new) More debug. Set deconstructor for parent
556 list. Track allocated vertices on the vertex_list.
557 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
558 vertices. Now frees only the given vertex.
559 (ospf_vertex_add_parent) Fix assert.
560 (ospf_nexthop_calculation) Fix calculation of nexthop for
561 VLink vertices, lookup the vl_data and use its previously
562 recorded nexthop information.
563 (ospf_spf_calculate) Vertices are freed simply by deleting
564 vertex_list nodes and letting ospf_vertex_free as deconstructor
566 (ospf_spf_calculate_timer) Trivial optimisation, leave
567 backbone SPF calculation till last to reduce SPF churn on
569 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
570 (no_ospf_area_vlink_cmd) ditto.
571 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
572 more interesting than the output interface.
574 2006-04-03 Paul Jakma <paul.jakma@sun.com>
576 * (general) Fix issues with handling of Vlinks and entries
577 in the nbrs route-table which were highlighted by the
578 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
579 Kammer for his help and efforts in testing out debug patches to
581 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
582 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
583 to create key in nbrs table for a given nbr.
584 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
585 document an expected state.
586 (ospf_nbr_add_self) Ditto.
587 (ospf_nbr_lookup_by_addr) Add an assert.
588 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
591 2006-03-27 Paul Jakma <paul.jakma@sun.com>
593 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
594 the ambiguities of ANSI and C99 C with respect to type
595 conversion. Detailed problem report and test case with
596 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
598 2006-03-25 Paul Jakma <paul.jakma@sun.com>
600 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
601 we can never ever receive packets on those. Should fix
602 case where CARP is run with address in same subnet as real
603 interface. Problem report and diagnosis thanks to:
604 Landon Fuller <landonf@opendarwin.org>.
605 However, ospf_read() still can't deal deterministically with
606 multiple interfaces in same subnet.
608 2006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
610 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
611 conversion of OSPF_MAX_SEQUENCE_NUMBER
613 2006-01-19 Paul Jakma <paul.jakma@sun.com>
615 * (general) various miscellaneous compiler warning fixes.
616 Remove redundant break statements from switch clauses
618 return from main, not exit, cause it annoys SOS.
619 Remove stray semi-colons which cause empty-statement
622 2006-01-18 Juergen Kammer <j.kammer@eurodata.de>
624 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
625 stream data until it is constructed, data reference is
626 volatile due to the potential resize in link_info_set
628 2006-01-18 Paul Jakma <paul.jakma@sun.com>
630 * ospf_lsa.c: (link_info_set) Resize the stream if required and
631 possible. Return number of links added.
632 (lsa_link_*_set) use return value from previous.
633 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
635 2006-01-17 Paul Jakma <paul.jakma@sun.com>
637 * ospf_packet.c: (ospf_verify_header) print out the types
638 involved if there's a mismatch.
639 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
641 2006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
643 * (general) Bug #234, see also [quagga-dev 3902].
644 Fix problem with nbr_self not being properly reinitialised
645 when an interface comes up, after having been down.
646 Some re-arrangement done by Paul Jakma, any bugs introduced
647 on top of Len's suggested changes are his.
648 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
649 initialisation of nbr_self parameters here.
650 * ospf_interface.c: (ospf_if_new) deleting initialisation of
651 parameters of nbr_self, just rely on call to
653 (ospf_if_cleanup) ditto.
654 * ospfd.c: (ospf_network_run) ditto.
656 2006-01-10 Juris Kalnins <juris@mt.lv>
658 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
659 struct connected in an error case.
660 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
661 undefined effect, assignment of an increment expression.
663 2006-01-10 Paul Jakma <paul.jakma@sun.com>
665 * ospfd.c: (ospf_network_run) checking to see if router-id
666 is set should be on ospf->router_id, not router_id_static.
667 This was causing ospfd to not start if router-id had not
668 been configured statically.
669 (ospf_if_update) ditto.
670 * ospf_vty.c: (config_write_ospf_distribute) trim down
673 2005-11-26 Paul Jakma <paul.jakma@sun.com>
675 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
676 array to C99 incomplete type array.
677 * (general) s/graceful/deferred/ in all files, the former term
678 is confusing wrt OSPF Graceful-Restart.
679 * ospfd.c: (ospf_deferred_shutdown_check) dont return
680 a function which returns void. SOS complains about this.
683 2005-11-20 Paul Jakma <paul.jakma@sun.com>
685 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
686 (struct ospf) remove the router_id timer thread.
687 remove export of ospf_router_id_update_timer.
688 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
689 poke interfaces into action after ID has been configured.
690 (ospf_router_id_update_timer) removed.
691 (ospf_finish_final) t_router_id_update timer is gone.
692 (ospf_network_run) router-id update timer gone.
693 call ospf_router_id_update directly if ID not configured.
694 In the per-iface loop, don't ospf_if_up interfaces if
695 ID is still not configured. The update function will call
696 ospf_if_update anyway.
697 (ospf_if_update) ID update timer is gone. Just return if no
699 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
701 * ospf_zebra.c: (ospf_router_id_update_zebra) call
702 ospf_router_id_update directly, not via timer.
703 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
704 returned LSA of ospf_summary_lsa_refresh and print warning if
706 (ospf_abr_announce_network_to_area) similar
707 (ospf_abr_announce_rtr_to_area) similar
708 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
709 (ospf_router_lsa_originate) similar
710 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
711 (ospf_summary_lsa_new) Check ID is valid.
712 (ospf_summary_lsa_originate) ditto, and check returned LSA from
713 previous function is !NULL.
714 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
716 (ospf_summary_asbr_lsa_new) ID valid check.
717 (ospf_summary_asbr_lsa_originate) similar.
719 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
721 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
722 for use with ospf_timer_dump and ospf_timeval_dump.
723 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
724 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
725 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
726 call to ospf_timer_dump.
728 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
730 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
731 in 'do {...} while(0)'.
733 2005-11-14 Paul Jakma <paul.jakma@sun.com>
735 * ospfd.c: (ospf_new) stub-shutdown should just default to
736 unconfigured, too strange otherwise.
737 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
738 preprocessor conditional on HAVE_OPAQUE_LSA.
739 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
740 no longer used, plus it wasn't in range that the command
742 * ospf_zebra.h: Depends on vty.h, include it.
744 2005-11-11 Paul Jakma <paul.jakma@sun.com>
746 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
747 the nexthops pointing to the root vertex. We may visit a
748 vertex twice or the vertex may have some inherited nexthops,
749 if we free other nexthops we could crash.
751 2005-11-04 Paul Jakma <paul.jakma@sun.com>
753 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
754 function rather than unportable timersub.
756 2005-11-03 Paul Jakma <paul.jakma@sun.com>
758 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
759 * ospf_packet.c: include checksum.h, remove the in_cksum extern
761 * ospf_te.h: Add braces, quell warning.
762 * ospf_packet.c: Change level of some warnings to
765 2005-10-29 Paul Jakma <paul.jakma@sun.com>
767 * (general) RFC3137 stub-router support
768 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
769 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
770 options, to allow shutdown to distinguish between complete
771 shutdown and shutdown of a subset of ospf instances.
773 Add stub_router_{startup,shutdown_}time, configuration of startup
774 and shutdown time for stub-router.
775 Add t_graceful_shutdown struct thread, timer for graceful
777 (struct ospf_area) Add stub_router_state - run time state of
778 stub-router for an area. Add flags for ADMIN, IS and WAS
780 Add t_stub_router, timer thread to resend router-lsa for an
782 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
783 either the given lnks cost or infinite cost if stub-router is
785 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
786 previous function for transit-links.
787 (ospf_stub_router_timer) timer thread for end of startup stub
788 router. Change state as required for the area and setup
789 re-origination of router-lsa.
790 (ospf_stub_router_check) Check/do whether stub-router should be
791 enabled, and whether it requires timer to be setup.
792 (ospf_router_lsa_new) call previous function at top.
793 (ospf_router_lsa_originate) no external callers, made static.
794 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
795 * ospf_main.c: (sigint) make static.
796 remove call to exit, as ospf_terminate now deals with
798 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
799 * ospf_vty.c: (show_ip_ospf_area) print out state of
800 stub-router, if active.
801 (show_ip_ospf) print out configuration of stub-router
802 support, and details of graceful-shutdown if the timer is
804 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
805 commands to (de-)?configure stub-router support.
806 (config_write_stub_router) write out config of stub-router.
807 (ospf_config_write) call previous.
808 (ospf_vty_init) install the new stub-router commands.
809 * ospfd.c: various functions made static.
810 (ospf_new) Set defaults for stub-router. Graceful shutdown
811 is made to default on, just to be adventerous.
812 (ospf_graceful_shutdown_finish) new function, final part of
814 (ospf_graceful_shutdown_timer) timer thread wrapper for
816 (ospf_graceful_shutdown_check) check whether to setup timer
817 for shutdown or proceed directly to final shutdown.
818 (ospf_terminate) moved here from ospf_route.c, call
819 ospf_finish for each instance.
820 (ospf_finish) renamed to ospf_finish_final and made static.
821 (ospf_finish) new function, exported wrapper around
822 ospf_graceful_shutdown_check.
823 (ospf_finish_final) complete shutdown of an instance.
824 Add missing TIMER_OFF's of two timer threads.
825 (ospf_area_free) opaque self lsa timer should be turned off.
827 2005-10-23 Paul Jakma <paul.jakma@sun.com>
829 * ospf_apiserver.c: (ospf_apiserver_term) This function should
830 not have side-effects (eg segv) if no apiserver instances are
831 active, ie be robust.
832 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
833 has not yet been run.
835 2005-10-21 Paul Jakma <paul.jakma@sun.com>
837 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
839 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
842 2005-10-21 Paul Jakma <paul.jakma@sun.com>
844 * (general) SPF millisecond resolution timer with adaptive,
845 linear back-off holdtime. Prettification of ospf_timer_dump.
846 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
847 ospf_timer_dump, but made to be more dynamic in printing out
848 the relative timeval, sliding the precision printed out
849 according to the value.
850 (ospf_timer_dump) guts moved to ospf_timeval_dump.
851 * ospf_dump.h: export ospf_timeval_dump.
852 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
853 the libzebra exported recent_time instead, as it's not
854 terribly critical to have time exactly right - the dropped
855 LSA will be retransmited to us if we don't ACK it.
856 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
857 not transmitting, just putting LSA back on update transmit list.
858 * ospfd.h: delay and holdtimes should be unsigned.
859 Add spf_max_holdtime and spf_hold_multiplier.
860 Update default defines for delay and hold time to be in msec.
861 (struct ospf) change the SPF timestamp to a struct timeval.
862 Remove ospf_timers_spf_(un)?set.
863 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
864 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
865 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
866 now, update with gettimeofday.
867 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
869 Make the holdtime be adaptive, with a linear increase in
870 holdtime ever consecutive SPF run which occurs within holdtime
871 of previous SPF, bounded by spf_max_holdtime.
872 * ospf_vty.c: Update spf timers commands.
873 (ospf_timers_spf_set) trivial helper.
874 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
875 initial hold and max hold times with millisecond resolution.
876 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
877 convert to msec, truncate to new limits.
878 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
879 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
880 (show_ip_ospf_cmd) Display SPF parameters and times.
881 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
883 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
884 the multiple spaces which were making the lines even longer.
885 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
886 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
887 widths for NBMA neighbours.
888 (show_ip_ospf_neighbor_int) Use header function.
889 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
891 (show_ip_ospf_neighbor_detail_sub) ditto
892 (ospf_vty_init) install the new SPF throttle timer commands.
894 2005-10-21 Paul Jakma <paul.jakma@sun.com>
896 * (general) OSPF fast, sub-second hello and 1s dead-interval
898 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
899 Callers typically specify a length of 9, so most see
900 millisecs unless they specify the additional length.
901 * ospf_interface.h: (struct ospf_interface) new interface param,
903 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
905 (ospf_new_if_params) Initialise fast_hello param.
906 (ospf_free_if_params) Check whether fast_hello is configured.
907 (ospf_if_new_hook) set fast_hello to default.
908 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
909 prevent funny side-effects from its if statement when this
910 macro is used conditionally by other macros.
911 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
912 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
913 to whether fast_hello is set.
914 * ospf_ism.c: Update all setting of the hello timer to use
915 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
916 former is used when hello is to be sent immediately.
918 * ospf_packet.c: (ospf_hello) hello-interval is not checked
919 for mismatch if fast_hello is set.
920 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
921 rather than a warning, as it can be perfectly normal to
922 receive packets when logical subnets are used.
923 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
925 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
926 nit, don't vty_out if this command is given, it gets tired
928 (show_ip_ospf_interface_sub) Print the hello-interval
929 according to whether fast-hello is set or not.
930 Print the extra 5 millisec characters from (ospf_timer_dump)
931 if fast-hello is configured.
932 (ospf_vty_dead_interval_set) new function, common to all
933 forms of dead-interval command, to set dead-interval and
934 fast-hello correctly. If a dead-interval is given, unset
935 fast-hello, else if a hello-multiplier is set, set
936 dead-interval to 1 and fast-hello to given multiplier.
937 (ip_ospf_dead_interval_addr_cmd) use
938 ospf_vty_dead_interval_set().
939 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
940 (no_ip_ospf_dead_interval) Unset fast-hello.
941 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
942 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
943 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
944 (config_write_interface) Write out fast-hello.
945 (ospf_config_write) Write a comment about
946 "auto-cost reference-bandwidth" having to be equal on all
947 routers. Hopefully just as noticeable as old practice of
948 writing to vty, but less annoying.
949 (ospf_vty_if_init) install the two new dead-interval
951 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
952 and OSPF_FAST_HELLO_DEFAULT.
954 2005-10-18 Paul Jakma <paul.jakma@sun.com>
956 * (general) SPF memory management cleanup and fix for rare
958 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
959 specific data, eg the backlink and the parent vertex pointer,
960 and point to the appropriate general struct vertex_nexthop.
961 (struct vertex_nexthop) remove parent vertex pointer, so
962 this struct can be shared across vertices.
963 (struct vertex) rename list child to list children. Remove
964 list of nexthops, replace with list of vertex_parents.
965 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
966 (vertex_nexthop_new) remove init of parent - field is gone
967 from struct vertex_nexthop.
968 (ospf_canonical_nexthops_free) Remove the canonical
969 vertex_nexthop memory objects. These are the vertex_nexthops
970 attached to the first level of router vertices from the root.
971 (vertex_parent_new) new function, create a vertex_parent.
972 (vertex_parent_free) ditto, but free it.
973 (ospf_vertex_new) Update to match changes to struct vertex.
974 (ospf_vertex_free) Recursively free a struct vertex and its
975 children. The parent list is used as a reference count.
976 vertex_nexthops must be free seperately, if required.
977 (ospf_vertex_dump) update to match struct vertex changes.
978 Print out backlink of parents too.
979 (ospf_vertex_add_parent) ditto.
980 (ospf_lsa_has_link) update comment.
981 (ospf_nexthop_add_unique) removed, not needed anymore.
982 (ospf_nexthop_merge) ditto.
983 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
984 Simplified to just create vertex_parent and add it.
985 (ospf_spf_flush_parents) new function, flush out the parent
987 (ospf_nexthop_calculation) Take the relevant route_lsa_link
988 as an argument, which simplifies things and removes the need
989 for the hack in ospf_nexthop_add_unique - ospf_spf_next
990 already knew exactly which link the cost calculated was for.
991 Update to match struct vertex changes too.
992 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
993 it's there's a vertex already created for W, use it, and
994 hence there's no need to free it either.
995 Update some manipulation/comparisons of distance to match.
996 Flush the parent list if a lower cost path is found.
997 (ospf_spf_route_free) unused, removed.
998 (ospf_spf_dump) match the struct vertex changes, and dump the
1000 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
1001 and call ospf_vertex_free on the root vertex to free the
1003 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
1005 * ospf_route.c: (ospf_intra_route_add) ditto
1006 (ospf_route_copy_nexthops_from_vertex) ditto
1008 2005-10-11 Paul Jakma <paul.jakma@sun.com>
1010 * ospf_api.c: sign warnings.
1011 * ospf_apiserver.c: sign warning and convert all the struct
1012 in_addr initialisations so as not to make assumptions about
1013 how this struct is organised, initialise the s_addr member
1015 * ospf_packet.c: Add const qualifier to auth_key.
1017 2005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
1019 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
1020 which now allows snmpwalk to work with ospfIfTable and
1021 also with ospfIfMetricTable
1023 2005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1025 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
1026 (ospf_redist_string) New function implemented using new library
1027 function zebra_route_string(). Note that there are a few differences
1028 in the output that will result: the new function returns strings
1029 that are lower-case, whereas the old table was mixed case. Also,
1030 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
1031 new function returns "ospf6".
1032 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
1033 and add extern const char *ospf_redist_string(u_int route_type)
1035 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
1036 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
1037 * ospf_vty.c: Remove local hard-coded table distribute_str.
1038 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
1039 new library function zebra_route_string() instead of distribute_str[].
1040 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
1041 ospf_redistribute_default_set,ospf_redistribute_check)
1042 In debug messages, use ospf_redist_string() instead of
1043 LOOKUP(ospf_redistributed_proto).
1045 2005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
1047 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
1050 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1052 * ospf_ism.c: generate SNMP traps on Interface state change
1053 * ospf_nsm.c: generate SNMP traps on Neighbour state change
1054 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
1056 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1058 * ospf_vty.c: forece default route LSA to be re_issued whenever
1059 cost is changed ( [no] ip ospf area XXX default-cost YYY)
1060 Support ignore-mtu option
1061 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1062 * ospf_packet.c: support ignore-mtu option
1063 * ospf_interface.h: field added for skipping MTU check
1064 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1065 Set mtu_ignore field to default value
1066 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1067 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1069 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1070 convert OSPFIFSTATE internal status into SNMP values
1072 2005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1074 * ospf_packet.c: use new md5 API
1076 2005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1078 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1079 (nexthop) since it is not used in the function (except inside
1080 some commented-out code).
1081 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1082 Comment out the 5th argument to ospf_external_lsa_flush.
1083 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1084 to ospf_external_lsa_flush.
1085 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1086 uninitialized nexthop arg to ospf_external_lsa_flush.
1087 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1088 to ospf_external_lsa_flush.
1089 * ospfd.c: (ospf_network_set) Comment out 5th arg
1090 to ospf_external_lsa_flush.
1092 2005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1095 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1096 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1098 2005-08-21 Hasso Tepper <hasso at quagga.net>
1100 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1101 Interface should be specified by name now.
1103 2005-08-17 Hasso Tepper <hasso at quagga.net>
1105 * ospf_vty.c: Check carefully if interface exists before trying to
1106 print info about it.
1108 2005-08-05 Hasso Tepper <hasso at quagga.net>
1110 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1111 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1112 for default-information.
1114 2005-07-26 Paul Jakma <paul.jakma@sun.com>
1116 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1117 should be on lsa not old, which may be freed for one thing,
1120 2005-07-12 Paul Jakma <paul.jakma@sun.com>
1122 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1123 OSPF_ABR_CISCO be the default ABR type.
1124 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1125 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1126 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1127 (ospf_config_write) test whether default abr_type against
1128 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1130 2005-06-20 Hasso Tepper <hasso at quagga.net>
1132 * ospf_nsm.c: Make database exchange for NSSA database work.
1134 2005-06-13 Paul Jakma <paul.jakma@sun.com>
1136 * ospf_spf.c: Try get more information on a SEGV under
1137 ospf_spf_vertex_add_parent.
1138 (ospf_vertex_free) NULL out the child and nexthop lists
1139 (ospf_vertex_add_parent) nexthop and child can not be NULL
1140 vertex_nexthop's parent->child list can not be NULL
1141 (ospf_spf_next) w and cw are per-loop iteration variables, move
1142 declarations into loop body.
1144 2005-06-07 Hasso Tepper <hasso at quagga.net>
1146 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1147 changes - oi->ifp->status doesn't give to us info about ISM,
1150 2005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1152 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1154 2005-05-26 Paul Jakma <paul.jakma@sun.com>
1156 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1157 had been fixed long ago by Sowmini.
1159 2005-05-19 Paul Jakma <paul.jakma@sun.com>
1161 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1163 1: this function is supposed to lookup
1164 entries in the oifs ospf_interface route_table and return either
1165 an existing oi or NULL to indicate not found, its caller depends
1166 on this, yet this function uses route_node_get which /always/
1167 returns a route_node - one is created if none exists. Use
1168 route_node_lookup instead. This should fix root cause of the
1169 reports of the (ospf_add_to_if) assert being hit.
1170 2: oi's are inserted into this table with prefixlength set to
1171 /32 (indeed, it should be a hash table, not a route_table),
1172 however prefixlength to lookup was not changed, if no valid entry
1173 can be inserted other than /32, then nothng but /32 should be
1174 looked up. This possibly only worked by fluke..
1175 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1176 backport candidate once it has been incubated in HEAD for a while.
1177 Thanks to Patrick Friedel and Ivan Warren for testing.
1179 2005-05-11 Paul Jakma <paul.jakma@sun.com>
1181 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1182 with much debugging done by by scott collins <scollins@agile.tv>.
1183 * ospf_lsa.c: (ospf_discard_from_db) dont call
1184 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1185 never registered with ase in the first place.
1186 * ospf_packet.c: (general) Disabuse opaque related code of its
1187 tendency to try gather up things into temporary lists.
1188 (ospf_ls_upd) remove the temporary lists opaque uses, call
1189 opaque functions inline, just like all other types.
1190 (ospf_ls_ack) ditto.
1191 (ospf_recv_packet) fixup sign warning.
1192 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1193 untwist some of the logic.
1194 (ospf_opaque_self_originated_lsa_received) take a single LSA
1195 as argument, not a list of them. Remove the list loop. Logic
1196 otherwise unchanged.
1197 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1198 move the actions up into the switch block, remove the goto's and
1199 sanitise the logic near the end a bit.
1200 * ospf_opaque.h: Adjust definitions of aforementioned functions
1201 in ospf_opaque.c to match.
1203 2005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1205 * ospf_network.c: Log ifindex on multicast membership leave/join
1208 2005-05-06 Paul Jakma <paul.jakma@sun.com>
1210 * (general) extern and static qualifiers added.
1211 unspecified arguments in definitions fixed, typically they should
1213 function casts added for callbacks.
1214 Guards added to headers which lacked them.
1215 Proper headers included rather than relying on incomplete
1217 gcc noreturn function attribute where appropriate.
1218 * ospf_opaque.c: remove the private definition of ospf_lsa's
1219 ospf_lsa_refresh_delay.
1220 * ospf_lsa.h: export ospf_lsa_refresh_delay
1221 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1222 correct thing to do - removes need for the casts later.
1223 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1224 home-brewed versions, shuts up several warnings.
1225 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1226 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1227 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1228 overloading of the THREAD_ARG pointer should at least use
1231 2005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1233 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1234 to approve LSAs for the case where metric has changed, lsa gets
1235 flushed otherwise. (backport candidate).
1237 2005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1239 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1242 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1244 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1245 function that does not exist.
1247 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1249 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1250 if_lookup_by_name_len.
1252 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1254 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1256 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1258 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1259 flags to help with debugging.
1260 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1261 to IFINDEX_INTERNAL.
1262 (zebra_interface_if_lookup) Make function static. Tighten up code.
1264 2005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1266 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1269 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1271 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1272 interface changes, print a debug message and call ospf_if_reset()
1273 to simulate down/up on the interface.
1274 * ospf_interface.h: Declare new function ospf_if_reset().
1275 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1276 and ospf_if_up for all ospf interfaces attached to an interface.
1278 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1280 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1281 show MTU. Also make function static.
1282 (ospf_write) Enhance error message to show interface name and MTU.
1283 Also make function static.
1285 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1287 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1288 bandwidth; this is useful for debugging problems. Also, the function
1291 2005-03-27 Hasso Tepper <hasso at quagga.net>
1293 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1296 2005-03-25 Hasso Tepper <hasso at quagga.net>
1298 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1300 2005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1302 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1303 backward, then current time may be less than
1304 ospf->lsa_refresher_started. This was causing invalid values
1305 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1306 Problem fixed by casting the expression to unsigned before taking
1309 2005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1311 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1312 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1313 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1314 (ospf_finish) Call stream_free(ospf->ibuf.
1315 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1316 pass it to ospf_recv_packet for use in receiving the packet
1317 (instead of allocating a new stream for each packet received).
1318 Eliminate all calls to stream_free(ibuf).
1319 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1320 an argument. No need to use recvfrom to peek at the packet
1321 header (to see how big it is), just use ospf->ibuf which is
1322 always large enough (this eliminates a system call to recvfrom).
1323 Therefore, no need to allocate a stream just for this packet,
1324 and no need to free it when done.
1326 2005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1328 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1329 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1330 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1331 * ospf_spf.c: New functions cmp() and update_stat() to manage
1332 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1333 ospf_install_candidate() and ospf_spf_register() functions not needed
1334 any more. Update ospf_vertex_new(), ospf_spf_next() and
1335 ospf_spf_calculate() functions to use pqueue instead of linked list.
1337 2005-02-21 Hasso Tepper <hasso at quagga.net>
1339 * ospf_ase.c: Don't show messages related to the ase calculations if
1340 we are not debugging.
1342 2005-02-19 Hasso Tepper <hasso at quagga.net>
1344 * ospf_api.h: char isn't always signed, but it has to be it here.
1346 2005-02-19 Paul Jakma <paul.jakma@sun.com>
1348 * ospf_packet.c: (ospf_stream_copy) remove
1349 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1351 2005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1353 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1354 packet in the queue, it must be discarded. Improve warning messages.
1355 Fix scope to static.
1356 (ospf_read) Fix bug: should reset the read thread in all cases
1357 to make sure we continue to get incoming messages.
1359 2005-02-15 Paul Jakma <paul.jakma@sun.com>
1361 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1362 ibuf. Thanks Andrew.
1364 2005-02-14 Paul Jakma <paul.jakma@sun.com>
1366 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1368 2005-02-11 Hasso Tepper <hasso at quagga.net>
1370 * ospf_lsdb.c: Fix sum of checksums calculation.
1372 2005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1374 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1377 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1379 * ospf_interface.h: Reduce structure padding by putting new u_char
1380 field multicast_memberships in a better spot (grouped with
1381 other u_char fields type and state).
1383 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1385 * ospf_interface.h: Improve passive_interface comment. Add new
1386 multicast_memberships bitmask to struct ospf_interface to track
1387 active multicast subscriptions. Declare new function
1388 ospf_if_set_multicast.
1389 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1390 multicast memberships properly based on the current
1391 multicast_memberships status and the current values of the
1392 ospf_interface state, type, and passive_interface status.
1393 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1394 now handled by ism_change_state's call to ospf_if_set_multicast).
1395 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1396 handled by ism_change_state).
1397 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1398 the DRouters multicast group (now handled by ism_change_state's call
1399 to ospf_if_set_multicast).
1400 (ism_change_state) Add call to ospf_if_set_multicast to change
1401 multicast memberships as necessary to reflect the new interface state.
1402 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1403 passive interface: 1. Increase the severity of the error message
1404 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1405 message (packet destination address and interface address);
1406 and 3. If the packet was sent to ospf-all-routers, then try
1407 to fix the multicast group memberships.
1408 (ospf_read) When a packet is received on an interface whose state
1409 is ISM_Down, enhance the warning message to show the packet
1410 destination address, and try to update/fix the multicast group
1411 memberships if the packet was sent to a multicast address.
1412 When a packet is received for ospf-designated-routers, but the
1413 current interface state is not DR or BDR, then increase the
1414 severity level of the error message from LOG_INFO to LOG_WARNING,
1415 and try to fix the multicast group memberships.
1416 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1417 any ospf interface that may have changed from active to passive.
1418 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1419 any ospf interface that may have changed from passive to active.
1420 (show_ip_ospf_interface_sub) Show multicast group memberships.
1422 2005-02-08 Paul Jakma <paul@dishone.st>
1424 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1426 2005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1428 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1429 not for event ISM_InterfaceDown. And improve the message by
1430 adding the interface flags.
1432 2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1434 * ospf_network.c: (ospf_sock_init) Save errno before calling
1437 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1439 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1440 an error message and return.
1441 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1442 a warning message and ignore the packet.
1444 2005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1446 * ospf_packet.h: Remove commented out definition of
1447 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1449 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1450 when deciding if an update will fit.
1451 (ospf_packet_authspace): Factor out calculation of size required
1453 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1454 Don't confuse readers that there is a macro.
1456 2004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1458 * ospf_network.c: Improve all setsockopt error messages to give detailed
1459 information on the arguments.
1461 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1463 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1464 messages from LOG_WARNING to LOG_INFO, since this seems to be
1467 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1469 * ospf_packet.c: (ospf_read) Always look up the interface if
1470 ospf_recv_packet returns NULL ifp, since some platforms such
1471 as Solaris 8 appear to support ifindex retrieval but don't.
1473 2004-12-22 Hasso Tepper <hasso at quagga.net>
1475 * ospf_dump.c: Show debug configuration in vtysh.
1476 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1477 any case if it's configured as "translate-never".
1478 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1479 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1480 number of all LSAs with AS scope, this includes opaque as LSAs as
1481 well, show this number separately. Show numbers and sums of
1482 checksums for each type of LSAs.
1483 * ospf_lsa.c: Calculate checksum before putting LSA into database.
1485 2004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1487 * ospf_interface.h: Declare new function ospf_default_iftype.
1488 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1489 this logic in one place.
1490 * ospf_zebra.c: (ospf_interface_add) Use new function
1491 ospf_default_iftype.
1492 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1493 by using new function ospf_default_iftype.
1495 2004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1497 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1498 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1499 messages to include identifying information (e.g. router id).
1500 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1501 router id and state names.
1503 2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1505 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1506 ospf_apiserver * from listnode. Remove unused variables. Follows
1507 suggestion from Jay Fenlason.
1509 2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1511 * *.c: Change level of debug messages to LOG_DEBUG.
1513 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1515 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1517 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1519 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1520 from LOG_NOTICE to LOG_DEBUG.
1522 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1524 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1525 (main) Issue a startup announcement using zlog_notice.
1527 2004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1529 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1530 message and in comment.
1531 (ospf_db_desc) Warning message that a packet is being discarded
1532 should give the router id of the packet source. Fix spelling
1533 of packet in two warning messages.
1534 (ospf_ls_req) Warning message that a link state request is being
1535 discarded should give the router id of the neighbor that sent it.
1537 2004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1539 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1540 lib/debug.h has now been deleted).
1542 2004-11-25 Hasso Tepper <hasso at quagga.net>
1544 * ospf_main.c: Make group to run as configurable.
1546 2004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1548 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1549 and works (lib/zebra.h provides if OS doesn't).
1551 2004-11-15 Paul Jakma <paul@dishone.st>
1553 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1555 2004-11-12 Paul Jakma <paul@dishone.st>
1557 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1558 ignore stub area summary default. Even so it seems a strange
1559 check, add a comment to that effect.
1561 2004-11-04 Paul Jakma <paul@dishone.st>
1563 * ospfd.c: (ospf_network_match_iface) revert to previous network
1564 statement match behaviour.
1566 2004-11-02 Paul Jakma <paul@dishone.st>
1568 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1569 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1570 fixing the unfortunate borkenness introduced in moving of this code
1572 (ospf_write) remove iovp and fix up call to previous.
1573 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1574 glibc's size_t format modifier is not portable.
1576 2004-10-31 Paul Jakma <paul@dishone.st>
1578 * ospf_packet.c: (ospf_write_frags) Add debug output
1579 (ospf_write) set type early, so we can pass it to
1581 (ospf_ls_upd_packet_new) print size in debug output when too large
1582 packet is encountered.
1583 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1584 THREAD_ARG to store an integer, but it should at least use same
1585 same type to retrieve the value. Assert value is sane.
1587 2004-10-22 Paul Jakma <paul@dishone.st>
1589 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1591 * ospf_packet.c: (ospf_read) manually look up ifindex
1592 if system could not have returned one, eg openbsd, thanks to Rivo
1593 Nurges for highlighting problem and fix.
1594 Change setsockopt_pktinfo to setsockopt_ifindex.
1596 2004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1598 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1599 with dedicated subnets properly.
1600 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1601 * ospfd.c: (ospf_network_match_iface) ditto.
1602 (ospf_network_run) ditto.
1603 * ospf_interface.c: (ospf_if_is_configured) ditto.
1604 (ospf_if_lookup_by_prefix) ditto.
1605 (ospf_if_lookup_recv_if) ditto.
1606 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1607 broadcast address if present.
1609 2004-10-13 Hasso Tepper <hasso at quagga.net>
1611 * ospf_main.c: Unbreak compilation with ospfapi disabled.
1612 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1613 snmpd. Connection is initialized only if smux peer is configured.
1615 2004-10-12 Hasso Tepper <hasso at quagga.net>
1617 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1618 static variable from ospf_main.c into ospf_opaque.c.
1620 2004-10-11 Hasso Tepper <hasso at quagga.net>
1622 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1623 command line switch to enable it.
1625 2004-10-11 Paul Jakma <paul@dishone.st>
1627 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1628 remove ntohs that should have dissappeared. Take struct ip
1629 as argument, caller has to know there's an IP header at start of
1631 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1632 * ospf_packet.c: (ospf_write) correct call to
1633 sockopt_iphdrincl_swab_htosys which was munging the header.
1634 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1635 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1637 * (global) Const char update and signed/unsigned fixes.
1638 * (various headers) size defines should be unsigned.
1639 * ospf_interface.h: remove duplicated defines, include the
1640 authoritative header - though, these defines should probably
1641 be moved to a dedicated header, or ospfd.h.
1642 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1643 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
1645 2004-10-08 Hasso Tepper <hasso at quagga.net>
1647 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1648 unsigned, remove unused variables etc.
1650 2004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1652 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1653 use of variable names 'node' and 'nextnode' to avoid possible
1654 conflict with list macros. Move variable declaration inside for
1655 loop after a statement to top of function.
1657 2004-10-07 Paul Jakma <paul@dishone.st>
1659 * ospf_snmp.c: Missed list typedef update
1660 * ospf_dump.c: Include sockopt.h for header swab functions.
1662 2004-10-05 Paul Jakma <paul@dishone.st>
1664 * ospf_packet.c: replace ospf_swap_iph_to... with
1665 sockopt_iphdrincl_swab_...
1667 2004-10-03 James R. Leu <jleu at mindspring.com>
1669 * ospf_zebra.c: Read router id related messages from zebra daemon.
1670 Schedule router-id update thread if it's changed.
1671 * ospfd.c: Remove own router-id selection function. Use router id from
1672 zebra daemon if it isn't manually overriden in configuration.
1674 2004-09-27 Paul Jakma <paul@dishone.st>
1676 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1677 Apply to offset too. Print ip_cksum, lets not worry about
1678 possible 2.0.37 compile problems.
1679 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1680 HAVE_IP_HDRINCL_BSD_ORDER.
1681 (ospf_recv_packet) ditto.
1682 (ospf_write) Fixup iov argument to ospf_write_frags.
1683 (struct msghdr).msg_name is caddr_t on most platforms.
1684 (ospf_recv_packet) ditto. And msg_flags is not always there
1685 memset struct then set fields we care about rather than
1686 initialise all fields individually.
1688 2004-09-26 Hasso Tepper <hasso at quagga.net>
1690 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1691 ospf_zebra.c: Fix compiler warnings.
1693 2004-09-24 Paul Jakma <paul@dishone.st>
1695 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1696 update some list loops to LIST_LOOP. some miscellaneous indent
1698 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1699 referenced node in loop.
1700 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1701 deletes referenced nodes from apiserver_list, fixed.
1702 * ospf_interface.h: lists typedef removal cleanup.
1703 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1704 loops to LIST_LOOP. miscellaneous style and indent fixups.
1705 * ospf_te.{c,h}: ditto
1706 * ospf_packet.c: lists typedef removal cleanup.
1707 (ospf_write) ifdef fragmentation support. move actual
1708 fragmentation out to a new, similarly ifdefed, function.
1709 (ospf_write_frags) fragmented write support, moved from previous.
1711 2004-09-23 Hasso Tepper <hasso at quagga.net>
1713 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1715 2004-09-12 Paul Jakma <paul@dishone.st>
1717 * ospf_packet.c: Fix bugzilla #107
1718 (ospf_packet_max) get rid of the magic 88 constant
1719 (ospf_swab_iph_ton) new function. set ip header to network order,
1720 taking BSDisms into account.
1721 (ospf_swab_iph_toh) the inverse.
1722 (ospf_write) Add support for IP fragmentation, will only work on
1723 linux though, other kernels make it impossible. get rid of the
1725 (ospf_make_ls_upd) Bound check to end of stream, not to
1727 (ospf_ls_upd_packet_new) New function, allocate upd packet
1728 taking oversized LSAs into account.
1729 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1730 rather than statically allocating mtu sized packet buffer, which
1731 actually was wrong - it didnt take ip header into account, which
1732 should not be included in packet buffer.
1733 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1736 2004-08-31 David Wiggins <dwiggins@bbn.com>
1738 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1739 print statements. New function ospf_vertex_dump used in debugging.
1741 2004-08-31 David Wiggins <dwiggins@bbn.com>
1743 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1745 2004-08-31 David Wiggins <dwiggins@bbn.com>
1747 * ospf_route.c: When finding an alternate route, log cost as well.
1749 2004-08-31 David Wiggins <dwiggins@bbn.com>
1751 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1752 struct prefix allocated on stack.
1754 2004-08-31 David Wiggins <dwiggins@bbn.com>
1756 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1757 acks to AllSPFRouters, rather than All-DR.
1759 2004-08-27 Hasso Tepper <hasso at quagga.net>
1761 * ospf_vty.c: Don't print ospf network type under interface only
1762 if interface is in broadcast mode and interface type really is
1763 broadcast. Fixes Bugzilla #108.
1765 2004-08-27 David Wiggins <dwiggins@bbn.com>
1767 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1768 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1771 2004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1773 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
1774 buffer used to get interface index so that it compiles on other
1775 than Linux and includes the required alignment space. Probably
1776 this was only working on sparc/sparc64 because most of
1777 sockaddr_dl was not being written.
1779 2004-08-19 Paul Jakma <paul@dishone.st>
1781 * ospf_packet.c: update to match sockopt renames.
1783 2004-08-04 Paul Jakma <paul@dishone.st>
1785 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1786 Compare only against list head - all nexthops must be same cost
1787 anyway, fixes a reference-listnode-after-delete bug noted by
1789 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1790 candidates attached to root.
1792 2004-07-27 Paul Jakma <paul@dishone.st>
1794 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1795 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1796 ospf_ls_upd_queue_send() - guaranteed segfault.
1798 2004-07-27 Paul Jakma <paul@dishone.st>
1800 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1801 the LSA as then free_opaque_info_per_id() can never unlock (and
1802 free) the LSA. Reported by Gunnar Stigen.
1804 2004-07-23 Paul Jakma <paul@dishone.st>
1806 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1808 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1809 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1811 2004-07-14 Paul Jakma <paul@dishone.st>
1813 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1814 problem reported by Peter Frost amongst others, where function
1815 will spin indefinitely if update list contains LSAs greater than
1816 MTU-headers or other condition leading to update list never being
1817 cleared. Problem of what to do with these LSAs remains.
1818 (ospf_make_ls_upd) add comment about large LSA problem,
1819 indentation cleanup.
1821 2004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1823 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1825 2004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1827 * Makefile.am: Add shlib support.
1829 2004-06-10 Hasso Tepper <hasso@estpak.ee>
1831 * *: Removed ifdefs HAVE_NSSA.
1833 2004-06-06 Paul Jakma <paul@dishone.st>
1835 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1836 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1838 2004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1840 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1841 index is out of range.
1842 ospf_flood.c: endianness fix
1843 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1846 2004-05-10 Hasso Tepper <hasso@estpak.ee>
1848 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1849 to ospf_zebra.c from ospfd.c and add redistribution updates if
1850 route-map is used in redistribution.
1851 * ospf_main.c: Remove now useless call to ospf_init().
1853 2004-05-08 Paul Jakma <paul@dishone.st>
1855 * ospf_zebra.c: Sync with lib/zclient changes
1857 2004-05-05 Paul Jakma <paul@dishone.st>
1859 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1860 defined. Warn at compile and runtime. Use
1861 IPTOS_PREC_INTERNETCONTROL otherwise.
1862 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1863 some of the checks up to ospf_read, return either a
1864 virtual link oi, or NULL.
1865 (ospf_read) Cleanup, make it responsible for checks. Remove
1866 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1867 lookups to use new wrappers exported by ospf_neighbor.
1868 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1869 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1870 neighbour table by router-id for virtual-link ospf_interfaces,
1871 not by peer_addr (which breaks for asymmetric vlinks)
1872 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1874 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1875 address for either end of a virtual-link, and hence potential cost
1878 2004-04-22 Hasso Tepper <hasso@estpak.ee>
1880 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1881 to "summarize" routes in ASBR at the moment.
1883 2004-04-20 Hasso Tepper <hasso@estpak.ee>
1885 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1886 Fixes UNH OSPF_NSSA.1.2a comment.
1887 * ospf_abr.c: Originate default into stub/nssa area even if
1888 summaries are disabled.
1889 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1891 2004-04-19 Hasso Tepper <hasso@estpak.ee>
1893 * ospf_vty.c: Don't warn that export- and import-list can't be
1894 configured to backbone area if they are applied and are working
1897 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1899 * ospf_packet.c: Don't drop packets in Solaris x86.
1902 2004-03-18 Amir Guindehi <amir@datacore.ch>
1904 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1905 Quagga's ospfd in the special situation that a node's opaque
1906 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1908 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1910 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1911 should be configured with the highest cost path within the range,
1914 2004-02-17 Paul Jakma <paul@dishone.st>
1916 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1917 params, nor the interface structure, if an interface delete
1918 message is received from zebra.
1919 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1920 params and interface, ie that which was previously removed in
1921 (ospf_interface_delete) above.
1923 2004-02-11 Hasso Tepper <hasso@estpak.ee>
1924 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1925 if oi doesn't exist any more.
1927 2004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1928 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1929 LSA if it was originated with older router-id ([zebra 14710] #6).
1931 2003-12-08 Mattias Amnefelt <mattiasa@kth.se>
1933 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1936 2003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1938 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1939 while trying not to change semantics. Add ifdefed-out code to
1940 avoid matching ppp interfaces whose destination address does not
1941 also match the prefix under consideration, to help out people with
1942 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1945 2003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1947 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1948 node in body of the loop to avoid chance that route node
1949 is unlocked and deleted before the next iteration tries to
1950 get next route node.
1952 2003-05-24 Kenji Yabuuchi
1954 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1955 match for interface lookup.
1957 2003-05-18 Hasso Tepper <hasso@estpak.ee>
1959 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1962 2003-05-16 Hasso Tepper <hasso@estpak.ee>
1964 * ospf_lsa.c: Fix handling of NSSA
1966 2003-04-23 Hasso Tepper <hasso@estpak.ee>
1968 * ospf_vty.c: fix "router xxx" node commands in vtysh
1970 2003-04-19 Hasso Tepper <hasso@estpak.ee>
1972 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1973 * ospf_routemap.c: sync daemon's route-map commands to have same
1976 2003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1978 * ospf_packet.c: Add missing param to zlog
1979 * ospf_flood.c: remove unused vars
1981 2003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1983 * ospf_interface.c: fix incorrect memset
1985 2003-04-10 Amir Guindehi <amir@datacore.ch>
1987 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1989 2003-04-03 David Watson <dwatson@eecs.umich.edu>
1991 * ospf_lsa.c: byte order fix
1993 2002-03-17 Amir Guindehi <amir@datacore.ch>
1995 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1996 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1997 * ospfclient: OSPFAPI demonstration client.
1999 2003-01-23 Masahiko Endo <endo@suri.co.jp>
2001 * ospf_ism.c: NSM event schedule bug fix.
2003 2002-10-30 Greg Troxel <gdt@ir.bbn.com>
2005 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
2007 2002-10-23 endo@suri.co.jp (Masahiko Endo)
2009 * ospf_opaque.c: Update Opaque LSA patch.
2011 2002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
2013 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
2015 2002-10-23 Juris Kalnins <juris@mt.lv>
2017 * ospf_interface.c (ospf_if_stream_unset): When write queue
2018 becomes empty stop write timer.
2020 2002-10-10 Greg Troxel <gdt@ir.bbn.com>
2022 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
2025 2002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2027 * zebra-0.93 released.
2029 2002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2031 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
2032 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
2033 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
2034 Paul Jakma <paulj@alphyra.ie>.
2036 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
2039 2002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2041 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
2043 2001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2045 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
2046 OSPF interface information.
2047 (ospf_delete_from_if): Likewise.
2049 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
2051 2001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2053 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
2054 is OSPF, do not unset redistribute flag.
2056 2001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2058 * zebra-0.92a released.
2060 2001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2062 * zebra-0.92 released.
2064 2001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2066 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2067 configuration display.
2069 2001-07-24 David Watson <dwatson@eecs.umich.edu>
2071 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2072 check for an existing link before connecting the parent and child.
2073 ospf_nexthop_calculation is also modified to check for duplicate
2074 entries when copying from the parent. Finally, ospf_spf_next
2075 removes duplicates when it merges two equal cost candidates.
2077 2001-07-23 itojun@iijlab.net
2079 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2082 2001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2084 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2087 2001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2089 * ospf_zebra.c (config_write_ospf_default_metric): Display
2090 default-metric configuration.
2092 2001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2094 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2096 2001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2098 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2100 (ospfIfMetricEntry): Likewise.
2102 2001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2104 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2105 Lin'Kova" <jen@stack.net>.
2107 2001-03-15 Gleb Natapov <gleb@nbase.co.il>
2109 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2110 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2112 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2114 2001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2116 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2117 (iph.ip_hl << 2) to iph.ip_len.
2119 2001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2121 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2122 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2124 * ospf_zebra.c (zebra_init): Remove zebra node.
2126 * ospfd.c (ospf_area_range_set): Function name is changed from
2128 (ospf_area_range_unset): New function which separated from DEFUN.
2129 New commands are added:
2130 "no area A.B.C.D range A.B.C.D/M advertise"
2131 "no area <0-4294967295> range A.B.C.D/M advertise"
2132 "no area A.B.C.D range A.B.C.D/M not-advertise"
2133 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2135 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2137 2001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2139 * ospf_network.c (ospf_if_add_allspfrouters): Use
2140 setsockopt_multicast_ipv4.
2141 (ospf_if_drop_allspfrouters): Likewise.
2143 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2144 (ospf_network_lsa_install): Likewise.
2145 (ospf_summary_lsa_install): Likewise.
2146 (ospf_summary_asbr_lsa_install): Likewise.
2147 (ospf_external_lsa_install): Likewise.
2148 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2151 2001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2153 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2154 structure when ospfd receive interface delete message to support
2157 2001-02-01 Dick Glasspool <dick@ipinfusion.com>
2159 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2160 command to "not-advertise".
2162 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2165 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2166 updating the area-range, the lowest cost is now saved.
2168 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2169 numbers rather than creating overflow during calculation.
2171 2001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2173 * zebra-0.91 is released.
2175 2001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2177 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2178 NSM_SeqNumberMismatch is scheduled.
2179 (ospf_ls_req): Free ls_upd when return from this function.
2180 (ospf_ls_upd_timer): When update list is empty do not call
2181 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2184 2001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2186 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2187 MaxAge. RFC2328 Section 14.
2188 (ospf_maxage_lsa_remover): Call above function during removing
2191 2001-01-26 Dick Glasspool <dick@ipinfusion.com>
2193 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2194 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2196 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2198 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2200 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2202 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2204 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2206 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2209 * ospfd.c (data_injection): Function to inject LSA. This is
2212 2001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2214 * ospf_route.c (ospf_route_match_same): Remove function.
2215 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2217 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2218 oi->address. Suggested by Matthew Grant
2219 <grantma@anathoth.gen.nz>.
2220 (ospf_zebra_add): Remove function.
2221 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2223 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2225 * ospf_zebra.c: Likewise.
2227 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2229 * ospf_ase.c: Remove OLD_RIB part.
2231 * ospf_route.c: Likewise.
2233 * zebra-0.90 is released.
2235 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2238 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2240 * ospf_route.c (ospf_route_delete): Use
2241 ospf_zebra_delete_multipath.
2243 2001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2245 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2246 from ospf_if_free(). Rewrite whole procudure to support primary
2249 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2250 address deletion process.
2252 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2254 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2255 treatment like FreeBSD.
2257 2001-01-09 endo@suri.co.jp (Masahiko Endo)
2259 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2260 strips IP header size from receiving IP Packet. So we adjust
2261 ip_len to whole IP packet size by adding IP header size.
2263 2001-01-08 endo@suri.co.jp (Masahiko Endo)
2265 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2267 (ospf_serv_sock): Close socket when it is not used.
2269 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2271 (ospf_write): When bind is fined, close sock.
2273 2001-01-07 Gleb Natapov <gleb@nbase.co.il>
2275 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2276 appears when you try to configure bandwidth on the ppp interface
2277 that is not yet configured in ospfd.
2279 2001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2281 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2282 will print nexthops for AS-external routes.
2284 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2285 ASE route under multipath environment.
2286 (ospf_ase_compare_tables): Likewise.
2288 2001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2290 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2292 2000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2294 * ospf_route.c (ospf_route_install): Install multipath information
2297 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2298 multipath information to zebra daemon.
2300 2000-12-25 Dick Glasspool <dick@ipinfusion.com>
2302 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2304 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2307 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2308 leave Type-7 LSA at Lock Count = 2.
2310 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2311 NSSA no P-bit off during Area flooding, but P-bit is turned off
2312 for mulitple NSSA AS flooding.
2314 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2317 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2318 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2321 2000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2323 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2324 found LSA and if the LSA is MAXAGE we should call refresh instead
2327 2000-12-18 Dick Glasspool <dick@ipinfusion.com>
2329 * ospf_abr.c: Removed redundant "...flood" in
2330 announce_network_to_area(). Repaired nssa Unlock by using
2333 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2335 * ospfd.c: Free up all data bases including NSSA.
2337 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2338 discard_callback. Added routine to get ip addr from within the
2341 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2343 * ospf_lsa.h: Added prototype for the below. struct in_addr
2344 ospf_get_ip_from_ifp (struct interface *ifp).
2346 2000-12-14 Gleb Natapov <gleb@nbase.co.il>
2348 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2349 Now maximum packet length may be 65535 bytes (maximum IP packet
2352 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2354 * ospfd.c (config_write_network_area): Remove unnecessary area
2357 2000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2359 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2361 2000-12-13 Gleb Natapov <gleb@nbase.co.il>
2363 * ospfd.c (config_write_network_area): Fix bug in
2364 config_write_network_area function.
2366 2000-12-12 Gleb Natapov <gleb@nbase.co.il>
2368 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2369 LSA's origination and refreshment as same as other type of LSA.
2371 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2373 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2375 2000-12-08 Dick Glasspool <dick@ipinfusion.com>
2377 The bulk of NSSA changes are contained herein; This version will
2378 require manual setting of "always" for NSSA Translator, and will
2379 not perform aggregation yet.
2381 * ospf_dump.c: "debug ospf nssa" is added.
2383 * ospf_dump.h: Likewise.
2385 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2387 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2388 'never, candidate, always'. Change "suppress" to "not-advertise".
2390 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2393 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2396 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2399 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2400 NSSA translator, then do it. Approve the global list, and flush
2403 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2404 Type-5 resulted from a Local Type-7 translation; not used for
2405 flooding, but used for flushing.
2407 * ospf_flood.c: New NSSA flooding.
2409 2000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2411 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2413 (ospf_vl_set_security): Virtual link configuration with
2415 (ospf_vl_set_timers): Set timers for virtual link.
2417 * New commands are added.
2418 "area A.B.C.D virtual-link A.B.C.D"
2419 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2420 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2421 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2422 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2423 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2425 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2426 cryptographic sequence number treatment.
2427 (ospf_check_auth): OSPF input buffer is added to argument.
2428 (ospf_read): Save neighbor's cryptographic sequence number.
2430 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2431 number when neighbor status is changed to NSM down.
2433 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2435 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2436 sequence number to neighbor structure.
2438 2000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2440 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2441 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2443 2000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2445 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2447 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2448 of the OSPF interface.
2449 (no_router_ospf): 'no router ospf' unregister redistribution
2450 requests from zebra.
2452 2000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2454 * ospf_ism.c (ism_change_status): Increment status change number.
2456 * ospf_interface.h (struct ospf_interface): Add new member for
2457 status change statistics.
2459 * Makefile.am: Update dependencies.
2461 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2462 (ospf_interface_delete): OSPF SNMP interface delete.
2464 * ospf_snmp.h: New file is added.
2466 2000-11-23 Dick Glasspool <dick@ipinfusion.com>
2468 * ospfd.h: Add new ospf_area structure member for
2469 NSSATranslatorRole and NSSATranslator state.
2471 * ospfd.c: Provided for eventual commands to specify NSSA
2472 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2473 decimal integer version of area-suppress.
2475 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2477 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2478 translator, advertise Nt bit.
2480 * ospf_route.c: 1st version of "sh ip os border-routers".
2482 2000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2484 * ospfd.c (area_vlink): Virtual link can not configured in stub
2487 2000-11-23 Gleb Natapov <gleb@nbase.co.il>
2489 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2490 slave must resend its last Database Description packet in response
2491 to duplicate Database Description packets received from the
2492 master. For this reason the slave must wait RouterDeadInterval
2493 seconds before freeing the last Database Description packet.
2494 Reception of a Database Description packet from the master after
2495 this interval will generate a SeqNumberMismatch neighbor
2496 event. RFC2328 Section 10.8
2497 (ospf_make_db_desc): DD Master flag treatment.
2499 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2500 nsm_change_status().
2501 (nsm_bad_ls_req): Likewise.
2502 (nsm_adj_ok): Likewise.
2503 (nsm_seq_number_mismatch): Likewise.
2504 (nsm_oneway_received): Likewise.
2506 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2507 last_send_ts for timestemp when last Database Description packet
2510 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2511 there. Call ospf_db_desc_resend() in any case.
2513 2000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2515 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2516 network (suppose you have only one router with interface priority
2517 0). It's router LSA does not contain the link information about
2520 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2521 interface from/to 0 ISM_NeighborChange event should be scheduled
2522 in order to elect new DR/BDR on the network.
2524 * ospf_interface.c (ip_ospf_priority): Likewise.
2526 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2527 retransmit list we need to check whether the present old LSA in
2528 retransmit list is not more recent than the new
2531 2000-11-09 Dick Glasspool <dick@ipinfusion.com>
2533 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2534 area. Any that exit the NSSA area are translated to type-5 LSA's.
2535 The instantiated image is restored after translation.
2536 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2537 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2539 (ospf_ls_ack_send): Likewise.
2541 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2542 local area. Otherwise they are allowed out the area to be
2543 translated by ospf_packet.c.
2545 * ospf_lsa.c: Undo some previous changes for NSSA.
2547 * ospf_lsdb.h: New access for type 7.
2549 2000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2551 * ospf_route.c (ospf_path_exist): New function to check nexthop
2552 and interface are in current OSPF path or not.
2553 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2554 when it is not there. Reported by Michael Rozhavsky
2555 <mrozhavsky@opticalaccess.com>
2557 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2559 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2560 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2563 2000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2565 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2567 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2569 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2572 2000-11-06 Dick Glasspool <dick@ipinfusion.com>
2574 * ospfd.h: Add ait_ntoa function prototype.
2576 * ospfd.c (ait_ntoa): New function for displaying area ID and
2578 (show_ip_ospf_interface_sub): Use ait_ntoa.
2579 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2580 (show_ip_ospf_neighbor_detail_sub): Likewise.
2582 * ospf_route.c (ospf_intra_route_add): Set external routing type
2584 (ospf_intra_add_router): Likewise.
2585 (ospf_intra_add_transit): Likewise.
2586 (ospf_intra_add_stub): Likewise.
2587 (ospf_add_discard_route): Likewise.
2588 (show_ip_ospf_route_network): Use ait_ntoa.
2589 (show_ip_ospf_route_network): Likewise.
2590 (show_ip_ospf_route_router): Likewise.
2592 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2593 (show_lsa_detail_adv_router): Likewise.
2594 (show_ip_ospf_database_summary): Likewise.
2596 * ospf_route.h (struct route_standard): Add new member
2599 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2601 (ospf_update_network_route): Likewise.
2602 (ospf_update_router_route): Likewise.
2604 2000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2606 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2607 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2609 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2611 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2612 Please specify "debug ospf event" for enable logging.
2614 * ospf_ism.c: Do not extern debug flag varible. It is done by
2616 * ospf_asbr.c: Likewise.
2617 * ospf_lsa.c: Likewise.
2618 * ospf_nsm.c: Likewise.
2619 * ospf_zebra.c: Likewise.
2621 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2624 * ospfd.c (router_ospf): Change logging from vty_out() to
2626 (ospf_area_stub_cmd): Likewise.
2628 * ospf_dump.h: Extern term_debug flags.
2629 (OSPF_DEBUG_EVENT): Add new flag.
2630 (IS_DEBUG_OSPF_EVENT): Add new macro.
2632 2000-11-03 Dick Glasspool <dick@ipinfusion.com>
2634 * ospf_flood.c (ospf_process_self_originated_lsa):
2635 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2636 (ospf_flood): Type-5's have no change. Type-7's can be received,
2637 and will Flood the AS as Type-5's They will also flood the local
2638 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2639 during re-fresh will be converted back to Type-7's (if within an
2641 (ospf_flood_through): Incoming Type-7's were allowed here if our
2642 neighbor was an NSSA. So Flood our area with the Type-7 and also
2643 if we are an ABR, flood thru AS as Type-5.
2645 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2646 area and other area.
2648 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2649 exists in DD packet, make it sure that this area is not stub.
2650 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2652 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2653 then discard the lsa. If the LSA is NSSA LSA and the area is not
2654 NSSA then discard the lsa.
2656 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2658 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2659 is not properly set when interface comes up.
2661 2000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2663 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2665 2000-11-01 Dick Glasspool <dick@ipinfusion.com>
2667 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2668 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2670 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2673 2000-10-31 Dick Glasspool <dick@ipinfusion.com>
2675 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2677 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2678 function is added. ALIASES which have "show ip ospf database
2679 nssa-external" is added.
2680 (show_ip_ospf_border_routers): New command "show ip ospf
2681 border-routers" is added.
2683 2000-10-30 Dick Glasspool <dick@ipinfusion.com>
2685 * ospfd.c (router_ospf): NSSA Enabled message is added for
2687 (ospf_area_type_set): Are type set for NSSA area.
2688 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2689 and summary information. If NSSA is enabled pass the information
2690 to ospf_area_type_set().
2691 (area_nssa): New commands are added:
2693 "area <0-4294967295> nssa"
2694 "area A.B.C.D nssa no-summary"
2695 "area <0-4294967295> nssa no-summary"
2696 (ospf_no_area_stub_cmd): Special translation of no_summary into
2697 NSSA and summary information. If external_routing is
2698 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2700 (show_ip_ospf_area): Display NSSA status.
2701 (config_write_ospf_area): Show NSSA configuration.
2703 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2706 2000-10-26 Gleb Natapov <gleb@nbase.co.il>
2708 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2709 those routers that are fully adjacent to the Designated Router;
2710 each fully adjacent router is identified by its OSPF Router ID.
2711 The Designated Router includes itself in this list. RFC2328,
2714 2000-10-23 Jochen Friedrich <jochen@scram.de>
2716 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2717 it is registered. So those variables must be static.
2719 2000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2721 * ospfd.c: Add area_default_cost_decimal_cmd and
2722 no_area_default_cost_decimal_cmd alias.
2724 2000-10-05 Gleb Natapov <gleb@nbase.co.il>
2726 * ospfd.c (ospf_network_new): Fix setting area format.
2727 (no_router_ospf): Check area existance when calling
2728 ospf_interface_down().
2730 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2733 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2735 * zebra-0.89 is released.
2737 2000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2739 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2741 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2744 2000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2746 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2748 2000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2750 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2753 2000-09-25 Toshiaki Takada <takada@zebra.org>
2755 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2756 Add CISCO compatible command.
2758 2000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2760 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2761 area range lookup in OSPF-MIB.
2762 (ospf_area_range_lookup_next): Likewise.
2764 2000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2766 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2769 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2770 EXTERNAL_INFO(type).
2772 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2773 ospf_vl_data_free().
2775 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2776 when ospf_vl_shutdown is called.
2777 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2780 2000-09-21 Gleb Natapov <gleb@nbase.co.il>
2782 * ospf_lsa.c: New implementation of OSPF refresh.
2784 2000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2786 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2788 2000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2790 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2792 2000-09-18 Gleb Natapov <gleb@nbase.co.il>
2794 * ospf_route.h (route_standard): Change member from `struct area'
2797 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2798 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2799 (ospf_abr_process_router_rt):
2800 * ospf_ase.c (ospf_find_asbr_route),
2801 (ospf_find_asbr_router_through_area),
2802 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2803 (process_summary_lsa), (ospf_update_network_route),
2804 (ospf_update_router_route):
2805 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2806 (ospf_intra_add_transit), (ospf_intra_add_stub),
2807 (ospf_route_table_dump), (show_ip_ospf_route_network),
2808 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2809 (ospf_prune_unreachable_routers):
2810 * ospf_spf.c (ospf_rtrs_print):
2811 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2813 2000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2815 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2818 2000-09-13 Gleb Natapov <gleb@nbase.co.il>
2820 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2822 * ospf_network.c (ospf_serv_sock_init): Add socket option
2823 SO_BINDTODEVICE on read socket.
2825 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2828 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2829 (ospf_area_add_if): New function added.
2831 2000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2833 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2836 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2837 starting SPF calculation.
2839 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2841 2000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2843 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2846 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2847 lsa_originate_count.
2848 (ospf_network_lsa_originate): Likewise.
2849 (ospf_summary_lsa_originate): Likewise.
2850 (ospf_summary_asbr_lsa_originate): Likewise.
2851 (ospf_external_lsa_originate): Likewise.
2853 2000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2855 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2856 syntax is IpAddress.
2857 (ospf_admin_stat): New function for OSPF administrative status
2860 2000-09-10 Jochen Friedrich <jochen@scram.de>
2862 * ospf_snmp.c: Implement OSPF MIB skeleton.
2864 2000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2866 * ospf_snmp.c: New file is added.
2868 2000-09-07 David Lipovkov <davidl@nbase.co.il>
2870 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2873 * ospf_interface.c (interface_config_write): Likewise.
2875 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2877 * zebra-0.88 is released.
2879 2000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2881 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2882 when Area is removed.
2884 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2886 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2887 (ZEBRA_ROUTE_CONNECT).
2888 (no_network_area): Likewise.
2890 2000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2892 * ospfd.h (struct ospf): Add distance_table and
2893 distance_{all,intra,inter,external}.
2895 * ospf_zebra.c: Add OSPF distance related functions.
2897 2000-08-15 Gleb Natapov <gleb@nbase.co.il>
2899 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2901 * ospf_lsa.c (ospf_default_external_info),
2902 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2906 (ospf_default_information_originate_metric_type_routemap),
2907 (ospf_default_information_originate_always_metric_type_routemap):
2908 Change name and add route-map function.
2909 (ospf_default_information_originate_metric_routemap),
2910 (ospf_default_information_originate_routemap),
2911 (ospf_default_information_originate_type_metric_routemap):
2914 2000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2916 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2917 restore size from two octet to four.
2919 2000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2921 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2922 AS-external-LSA in 16.6 of RFC2328.
2924 2000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2926 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2927 calculation algorithm.
2929 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2931 2000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2933 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2936 2000-08-10 Toshiaki Takada <takada@zebra.org>
2938 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2939 `auto-cost reference-bandwidth' OSPF router command added.
2941 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2943 * ospf_routemap.c (ospf_route_map_update): New function added.
2944 Add route-map event hook.
2946 2000-08-08 Toshiaki Takada <takada@zebra.org>
2948 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2949 prefix is connected route on OSPF enabled interface, suppress to
2952 2000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2954 * ospf_interface.c (ospf_if_get_output_cost):
2955 New function added. Handle bandwidth parameter for cost
2958 2000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2960 * ospf_interface.c (interface_config_write): Show interface
2961 configuration regardless interface is down.
2963 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2964 route calculate function.
2966 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2968 * ospf_routemap.c: New file added.
2970 * ospf_asbr.c (ospf_reset_route_map_set_values),
2971 (ospf_route_map_set_compare): New function added.
2973 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2974 with AS-external-LSA.
2976 2000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2978 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2979 ospf_zebra_add as metric.
2980 (ospf_ase_calculate_route_add): Likewise.
2982 * ospf_route.c (ospf_route_install): Pass or->cost to
2983 ospf_zebra_add as metric.
2985 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2986 (ospf_zebra_delete): Likewise.
2988 2000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2990 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2991 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2994 2000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2996 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2999 * ospf_interface.c (ospf_if_free): Fix bug of crash with
3000 Point-to-Point interface.
3002 2000-07-27 Michael Rozhavsky <mike@nbase.co.il>
3004 * ospf_flood.c (ospf_process_self_originated_lsa):
3005 Make sure to clear LSA->param (redistributed external information)
3008 2000-07-27 Gleb Natapov <gleb@nbase.co.il>
3010 * ospfd.c (refresh_group_limit), (refresh_per_slice),
3011 (refresh_age_diff): New defun added. Refresher related parameter
3012 can be configurable.
3014 2000-07-27 Akihiro Mizutani <mizutani@dml.com>
3016 * ospf_interface.c (interface_config_write): Print `description'
3017 config directive to work.
3019 2000-07-24 Akihiro Mizutani <mizutani@dml.com>
3021 * ospf_interface.c (ospf_if_init): Use install_default for
3024 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
3026 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
3027 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
3028 This make sending always as many LS update/Ack combined in one ospf
3031 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
3033 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
3034 LSA is AS-external-LSA.
3036 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
3038 2000-07-21 Toshiaki Takada <takada@zebra.org>
3040 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
3041 `default-information originate'. Fix some default originate
3044 2000-07-12 Toshiaki Takada <takada@zebra.org>
3046 * ospf_lsa.c (stream_put_ospf_metric): New function added.
3048 2000-07-12 Toshiaki Takada <takada@zebra.org>
3050 * ospf_lsa.c (show_ip_ospf_database_router),
3051 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
3052 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
3053 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
3054 (show_any_lsa_self): Functions removed.
3056 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
3057 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
3058 New functions added. Replace above functions.
3060 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3062 (show_ip_ospf_database_summary): New functions added. Replace
3065 (show_ip_ospf_database_cmd): DEFUN rearranged.
3066 (show_ip_ospf_database_type_id_cmd),
3067 (show_ip_ospf_database_type_id_adv_router_cmd),
3068 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3069 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3070 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3072 2000-07-11 Toshiaki Takada <takada@zebra.org>
3074 * ospf_asbr.c (ospf_external_info_new),
3075 (ospf_external_info_free): New functions added.
3077 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3078 origination parameter for external-LSA.
3079 Remove member `redistribute'.
3081 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3082 command executed, metric and metric-type values are overridden.
3083 If one of those is changed refresh AS-external-LSAs for appropriate
3086 2000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3088 * ospf_lsa.c (ospf_summary_lsa_refresh),
3089 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3091 * ospf_abr.c (set_metric): New function added.
3093 2000-07-07 Toshiaki Takada <takada@zebra.org>
3095 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3096 (ospf_default_information_originate_type_metric): New defun added.
3097 Metic and Metric type can be set to default route.
3098 (ospf_default_information_originate_always_metric_type):
3099 (ospf_default_information_originate_always_type_metric):
3100 New defun added. Metric and Metric type can be set to default
3103 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3106 2000-07-06 Gleb Natapov <gleb@nbase.co.il>
3108 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3109 on the same interface the LSA was received from.
3111 2000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3113 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3114 command with `write mem'.
3116 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3118 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3119 zebra interface delete event.
3121 2000-07-06 Toshiaki Takada <takada@zebra.org>
3123 * ospf_zebra.c (ospf_default_information_originate),
3124 (ospf_default_information_originate_always): New DEFUN added.
3126 2000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3128 * ospf_route.c (ospf_terminate): Make sure to remove external route
3129 when SIGINT received.
3131 2000-07-03 Gleb Natapov <gleb@nbase.co.il>
3133 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3134 many structure with `no router ospf'.
3136 2000-06-30 Gleb Natapov <gleb@nbase.co.il>
3138 * ospf_neighbor.c (ospf_nbr_new),
3139 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3140 when neighbor enters Exchange state.
3142 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
3144 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3145 ospf_packet.c (ospf_db_desc_proc):
3146 Do not cancel DD retransmit timer when Master.
3148 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
3150 * ospf_abr.c (ospf_abr_announce_network_to_area),
3151 (ospf_abr_announce_rtr_to_area)
3152 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3153 ospf_flood.c (ospf_process_self_originated_lsa),
3154 (ospf_flood_through_area), (ospf_ls_request_delete),
3155 ospf_interface.c (ospf_if_free),
3156 ospf_ism.c (ism_change_status),
3157 ospf_lsa.c (ospf_router_lsa_update_timer),
3158 (ospf_router_lsa_install), (ospf_network_lsa_install),
3159 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3160 (ospf_schedule_lsa_flood_area),
3161 ospf_nsm.c (nsm_change_status),
3162 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3163 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3165 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3167 * ospf_lsa.c (ospf_discard_from_db): New function added.
3169 2000-06-26 Toshiaki Takada <takada@zebra.org>
3171 * ospfd.h (ospf): struct member `external_lsa' name changed to
3174 2000-06-26 Toshiaki Takada <takada@zebra.org>
3176 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3177 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3178 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3179 Functions re-arranged.
3181 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3183 2000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3185 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3186 verification of LS type.
3188 2000-06-20 Gleb Natapov <gleb@nbase.co.il>
3190 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3191 whether rn->info is NULL.
3193 2000-06-20 Toshiaki Takada <takada@zebra.org>
3195 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3196 DR and Backup correctly with `show ip ospf interface' command.
3198 2000-06-20 Toshiaki Takada <takada@zebra.org>
3200 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3201 (ospf_lsa_discard): These functions are used for avoiding
3202 unexpected reference to freed LSAs.
3204 2000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3206 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3209 2000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3211 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3213 2000-06-12 Toshiaki Takada <takada@zebra.org>
3215 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3216 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3219 2000-06-10 Toshiaki Takada <takada@zebra.org>
3221 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3222 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3223 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3224 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3225 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3226 removed for migration to new_lsdb.
3228 * ospf_lsa.c (ospf_summary_lsa_install),
3229 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3230 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3231 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3232 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3233 (ospf_get_free_id_for_prefix): Funcitions removed.
3235 2000-06-09 Gleb Natapov <gleb@nbase.co.il>
3237 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3239 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3240 (ospf_hello): Always copy router-ID when hello is received.
3242 2000-06-08 Gleb Natapov <gleb@nbase.co.il>
3244 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3247 2000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3249 * ospf_ase.c (ospf_asbr_route_same): New function added.
3250 This function makes sure external route calculation more
3253 2000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3255 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3256 network-LSA deletion instead of using ospf_lsdb_delete.
3257 Also cancel network-LSA origination timer.
3259 2000-06-07 Levi Harper <lharper@kennedytech.com>
3261 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3264 2000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3266 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3267 avoid ambiguous else.
3269 * ospf_flood.c (ospf_external_info_check): Likewise.
3271 2000-06-05 Toshiaki Takada <takada@zebra.org>
3273 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3275 2000-06-04 Toshiaki Takada <takada@zebra.org>
3277 * ospf_zebra.c (ospf_default_information_originate),
3278 (no_ospf_default_information_originate): New DEFUN added.
3280 2000-06-03 Toshiaki Takada <takada@zebra.org>
3282 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3283 ospf_lsa.h to ospf_asbr.h.
3285 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3286 (ospf_external_info_delete): Function moved from ospf_lsa.c
3289 2000-06-03 Toshiaki Takada <takada@zebra.org>
3291 * ospf_flood.c (ospf_external_info_check): New function added.
3292 (ospf_process_self_orignated_lsa): Make sure to flush
3293 self-originated AS-external-LSA, when router reboot and no longer
3294 originate those AS-external-LSA.
3296 2000-06-02 Toshiaki Takada <takada@zebra.org>
3298 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3301 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3302 unicast destination packets.
3304 2000-06-02 Toshiaki Takada <takada@zebra.org>
3306 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3307 specified LSA matches.
3309 2000-06-02 Gleb Natapov <gleb@nbase.co.il>
3311 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3314 2000-06-01 Akihiro Mizutani <mizutani@dml.com>
3316 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3317 Replace string `OSPF information\n' with OSPF_STR.
3319 2000-06-01 Toshiaki Takada <takada@zebra.org>
3321 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3324 2000-06-01 Toshiaki Takada <takada@zebra.org>
3326 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3327 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3328 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3329 (term_debug_ospf_packet), (term_debug_ospf_event),
3330 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3331 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3332 variable to use for debug option flags.
3334 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3335 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3336 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3339 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3340 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3341 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3342 (IS_CONF_DEBUG_OSPF): New Macro added.
3344 2000-05-31 Toshiaki Takada <takada@zebra.org>
3346 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3347 Currently this command is used for only debugging.
3349 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3350 for network-LSA when DR has no full neighbors.
3352 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3354 2000-05-30 Toshiaki Takada <takada@zebra.org>
3356 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3357 maxage_lsa_remover when LSA is replaced.
3359 2000-05-25 Gleb Natapov <gleb@nbase.co.il>
3361 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3362 `struct ospf_area' to remove LSA from Link State retransmission list
3363 of neighbor from only one Area.
3365 2000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3367 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3368 overriting old LSA with new LSA.
3370 2000-05-24 Gleb Natapov <gleb@nbase.co.il>
3372 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3375 2000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3377 * ospf_route.c (ospf_intra_add_stub):
3378 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3379 value instead of u_int16_t.
3381 2000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3383 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3384 equal cost path calculation.
3386 2000-05-21 Toshiaki Takada <takada@zebra.org>
3388 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3389 Make sure, when rotuer route is deleted, related external routes
3392 2000-05-20 Toshiaki Takada <takada@zebra.org>
3394 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3397 2000-05-16 Toshiaki Takada <takada@zebra.org>
3399 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3402 * ospfd.h (EXTERNAL_INFO): Macro added.
3403 Substitute `ospf_top->external_info[type]' with it.
3405 2000-05-16 Toshiaki Takada <takada@zebra.org>
3407 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3409 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
3411 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3412 * ospf_lsdb.c (new_lsdb_insert)
3413 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3415 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
3417 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3418 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3420 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3422 2000-05-13 Toshiaki Takada <takada@zebra.org>
3424 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3425 time_t to struct timeval.
3426 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3427 (tv_sub), (tv_cmp): timeval utillity functions added.
3429 2000-05-12 Toshiaki Takada <takada@zebra.org>
3431 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3432 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3434 router-LSA refresh timer related stuff is re-organized.
3436 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
3438 * ospf_interface.c (ospf_vl_set_params):
3439 * ospf_packet.c (ospf_check_network_mask):
3440 * ospf_spf.[ch] (ospf_spf_next):
3441 Remove field address from `struct vertex', and search for peer
3442 address of virtual link in function `ospf_vl_set_params' instead.
3444 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
3446 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3448 2000-05-08 Thomas Molkenbur <tmo@datus.com>
3450 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3451 with ospf_stream_dup() to fix memory leak.
3453 2000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3455 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3456 LSA update without DROther.
3458 2000-05-04 Gleb Natapov <gleb@nbase.co.il>
3460 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3462 2000-05-03 Toshiaki Takada <takada@zebra.org>
3464 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3465 instead linked-list.
3466 (ospf_db_summary_count), (ospf_db_summary_isempty):
3469 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3471 2000-05-02 Gleb Natapov <gleb@nbase.co.il>
3473 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3474 not needed any more, then free them.
3476 2000-05-02 Toshiaki Takada <takada@zebra.org>
3478 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3479 SPF calculation timers related stuff is rearranged.
3481 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3482 SPF timer is scheduled by SPF calculation delay and holdtime
3483 configuration variable.
3485 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3486 forwarding address when nexthop learned by other protocols is
3489 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3490 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3493 2000-05-01 Toshiaki Takada <takada@zebra.org>
3495 * ospf_flood.c (ospf_ls_retransmit_count),
3496 (ospf_ls_retransmit_isempty): New function added.
3498 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3499 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3500 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3501 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3504 2000-04-29 Toshiaki Takada <takada@zebra.org>
3506 * ospfd.c (no_network_area): Add check Area-ID whether specified
3507 Area-ID with prefix matches config.
3509 2000-04-27 Toshiaki Takada <takada@zebra.org>
3511 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3512 remaining withdrawn routes on zebra.
3514 2000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3516 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3517 (ospf_nsm_event): Fix network-LSA re-origination problem.
3519 2000-04-24 Toshiaki Takada <takada@zebra.org>
3521 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3522 with DD retransmission.
3524 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3525 a neighbor disappears.
3527 2000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3529 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3530 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3531 flag to new LSA. when summary-LSA is reoriginatd.
3533 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3534 procedure. Change the condition of interface selection.
3536 2000-04-21 Toshiaki Takada <takada@zebra.org>
3538 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3541 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3542 `show ip ospf neighbor' related commands are re-arranged.
3544 2000-04-20 Toshiaki Takada <takada@zebra.org>
3546 * ospf_dump.c (debug_ospf_zebra): New defun added.
3547 Suppress zebra related debug information.
3549 2000-04-19 Toshiaki Takada <takada@zebra.org>
3551 * ospf_zebra.c (ospf_distribute_list_update_timer),
3552 (ospf_distribute_list_update), (ospf_filter_update):
3553 New function added. Re-organize `distribute-list' router ospf
3556 2000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3558 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3560 2000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3562 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3563 interface transmit_delay.
3565 2000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3567 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3568 Add to schedule router_lsa origination when the interface cost changes.
3570 2000-04-12 Toshiaki Takada <takada@zebra.org>
3572 * ospf_lsa.c (ospf_refresher_register_lsa),
3573 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3575 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3577 2000-03-29 Toshiaki Takada <takada@zebra.org>
3579 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3581 2000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3583 * ospf_lsa.c (ospf_network_lsa):
3584 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3587 2000-03-28 Toshiaki Takada <takada@zebra.org>
3589 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3590 (nsm_oneway_received): Fix bug of NSM state flapping between
3591 ExStart and Exchange.
3593 2000-03-28 Toshiaki Takada <takada@zebra.org>
3595 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3596 change u_int8_t to u_char.
3598 2000-03-27 Toshiaki Takada <takada@zebra.org>
3600 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3602 2000-03-27 Toshiaki Takada <takada@zebra.org>
3604 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3606 2000-03-26 Love <lha@s3.kth.se>
3608 * ospf_packet.c (ospf_write): Chack result of sendto().
3610 2000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3612 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3614 2000-03-23 Libor Pechacek <farco@clnet.cz>
3616 * ospf_lsa.c (ospf_network_lsa)
3617 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3620 2000-03-23 Toshiaki Takada <takada@zebra.org>
3622 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3623 `area A.B.C.D authentication'.
3625 2000-03-22 Toshiaki Takada <takada@zebra.org>
3627 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3628 Suppress all zlog related to LSAs with this config option.
3630 2000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3632 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3634 2000-03-21 Toshiaki Takada <takada@zebra.org>
3636 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3637 Fix bug of memory leak about linklist.
3639 * ospf_flood.c (ospf_flood_through_area): Likewise.
3641 2000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3643 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3644 to identify LSA uniquely. This fix routes lost.
3646 2000-03-18 Toshiaki Takada <takada@zebra.org>
3648 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3651 2000-03-17 Alex Zinin <zinin@amt.ru>
3653 * ospf_spf.[ch]: Bug fix.
3654 The 2nd stage of Dijkstra could consider one vertex
3655 more than once if there is more than one link
3656 between the routers, thus adding extra CPU overhead
3657 and extra next-hops.
3660 2000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3662 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3664 2000-03-14 Toshiaki Takada <takada@zebra.org>
3666 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3667 ospf_path. Actually ignore merging ospf_route with completely same
3670 2000-03-12 Toshiaki Takada <takada@zebra.org>
3672 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3673 external route tag byte order.
3675 2000-03-11 Toshiaki Takada <takada@zebra.org>
3677 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3679 2000-03-09 Toshiaki Takada <takada@zebra.org>
3681 * ospf_lsa.c (ospf_external_lsa_install),
3682 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3683 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3684 LSDB of AS-external-LSAs instead of ospf_lsdb.
3686 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3687 Use for assigning Unique Link State ID instead of
3688 ospf_get_free_id_for_prefix().
3690 2000-03-09 Toshiaki Takada <takada@zebra.org>
3692 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3693 fault reported by George Bonser <george@siteROCK.com>.
3695 2000-03-07 Libor Pechacek <farco@clnet.cz>
3697 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3699 2000-03-06 Toshiaki Takada <takada@zebra.org>
3701 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3703 2000-03-02 Alex Zinin <zinin@amt.ru>
3704 * ospfd.h, ospf_ia.h
3705 New Shortcut ABR code. Now area's flag can be configured
3706 with Default, Enable, and Disable values.
3707 More info will be in the new ver of I-D soon (see IETF web).
3709 2000-02-25 Toshiaki Takada <takada@zebra.org>
3711 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3712 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3713 (ospf_external_lsa_originate_from_queue): New function added.
3714 (ospf_external_lsa): Function removed.
3716 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3717 when listen a route from Zebra, instead creating external route.
3719 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3720 (ospf_asbr_route_add_queue_lsa),
3721 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3724 * ospf_ase.c (process_ase_lsa): Function will not be used.
3725 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3726 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3727 process_ase_lsa () is separated to these functions.
3729 OSPF AS-external-LSA origination is whole re-organized.
3731 2000-02-18 Toshiaki Takada <takada@zebra.org>
3733 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3735 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3736 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3739 2000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3741 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3742 checksum after change Advertised Router field.
3744 2000-02-09 Toshiaki Takada <takada@zebra.org>
3746 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3748 2000-02-08 Toshiaki Takada <takada@zebra.org>
3750 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3751 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3752 Router ID is chosen from all of eligible interface addresses even if
3753 it is not enable to OSPF.
3755 2000-02-08 Toshiaki Takada <takada@zebra.org>
3757 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3758 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3759 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3760 waited to install to LSDB.
3761 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3763 2000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3765 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3766 in the ACK before deleting.
3768 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3769 and no shutdown of the interface.
3771 2000-01-31 Toshiaki Takada <takada@zebra.org>
3773 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3774 packets respond to a Link State Request packet.
3776 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3778 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3779 is not configured and set virtual-link to no-backbone area,
3782 2000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3784 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3787 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3788 treatment. That should be done in OSPF flooding procedure.
3790 * ospf_flood.c (ospf_flood_through_area): Enclose
3791 ospf_check_nbr_loding inside if-else close.
3793 2000-01-31 Toshiaki Takada <takada@zebra.org>
3795 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3797 2000-01-29 Toshiaki Takada <takada@zebra.org>
3799 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3801 2000-01-28 Toshiaki Takada <takada@zebra.org>
3803 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3805 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3807 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3808 removing LSA from nbr->db_summary.
3810 2000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3812 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3813 destination when the link is point-to-point.
3814 (ospf_ls_ack_send_delayed): Likewise.
3816 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3818 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3819 pointer lookup after the node is freed.
3821 2000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3823 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3824 external route, use ospf_top->external_self.
3826 2000-01-27 Toshiaki Takada <takada@zebra.org>
3828 * ospf_lsa.c (ospf_forward_address_get): New function added.
3830 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3831 only when it should be replaced.
3833 2000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3835 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3837 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3840 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3841 change. Self originated LSA is freed but not deleted from lsdb.
3843 2000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3845 * ospf_ism.c (ism_interface_down): Don't use router_id for
3846 detecting self neighbor structure. Instead of that compare
3849 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3851 (ospf_nbr_free): Free last send packet.
3853 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3854 Instead of that src is introduced.
3856 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3858 2000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3860 * ospfd.c: Change part of passive interface implementation. For
3861 passive interface just disabling sending/receiving Hello on the
3864 2000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3866 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3867 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3868 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3869 * ospfd.c (passive_interface): New command passive-interface is
3871 (ospf_config_write): Print passive interface.
3873 2000-01-15 Toshiaki Takada <takada@zebra.org>
3875 * ospf_interface.h (crypt_key): New struct added to store
3876 multiple cryptographic autheitication keys.
3877 (ospf_interface): struct changed.
3879 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3880 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3882 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3883 multiple cryptographic authentication keys.
3885 2000-01-14 Toshiaki Takada <takada@zebra.org>
3887 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3889 Old notation `ospf *' still remains backward compatibility.
3891 1999-12-29 Alex Zinin <zinin@amt.ru>
3892 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3893 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3894 int goes down, also check DD flags correctly (bug fix)
3896 1999-12-28 Alex Zinin <zinin@amt.ru>
3897 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3899 1999-12-23 Alex Zinin <zinin@amt.ru>
3900 * added RFC1583Compatibility flag
3901 * added dynamic interface up/down functionality
3903 1999-11-19 Toshiaki Takada <takada@zebra.org>
3905 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3906 for NSM state change statistics.
3908 1999-11-19 Toshiaki Takada <takada@zebra.org>
3910 * ospfd.c (show_ip_ospf_neighbor_detail),
3911 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3913 1999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3915 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3918 1999-11-11 Toshiaki Takada <takada@zebra.org>
3920 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3921 This macro is expanded to ospf_examine_summaries ()
3922 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3923 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3924 This macro is expanded to ospf_examine_transit_summaries ()
3925 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3927 1999-11-11 Toshiaki Takada <takada@zebra.org>
3929 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3930 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3931 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3932 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3933 (ospf_find_self_external_lsa_by_prefix): Changed to
3934 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3936 1999-11-11 Toshiaki Takada <takada@zebra.org>
3938 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3939 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3941 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3942 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3945 1999-11-10 Toshiaki Takada <takada@zebra.org>
3947 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3948 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3950 1999-11-01 Alex Zinin <zinin@amt.ru>
3952 some correction to LSU processing
3954 * ospf_lsa.c ospfd.h
3955 randomize initial LSA refreshment interval
3956 and limit the size of LSA-group to 10
3957 to let randomization work more effectively.
3959 1999-10-31 Alex Zinin <zinin@amt.ru>
3961 cancel t_network_lsa_self
3962 when freeing int structure
3964 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3965 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3967 Summary and ASE LSA refreshment functions
3968 added---LSA refreshment is paced to 70 LSAs
3969 per sec to avoid link overflow. Refreshment events
3970 are further randomized within a 10 sec interval
3973 Also the sigfault of memcmp() in ospf_lsa_is_different()
3976 1999-10-30 Alex Zinin <zinin@amt.ru>
3978 Fix the bug where MAX_AGE LSAs
3979 are included into the DB summary.
3982 allocate 2*MTU input buffer instead of just MTU
3983 for the cases when the other router mistakenly
3984 sends larger packets thus causing fragmentation, etc.
3987 in nsm_reset_nbr() lists should be freed
3988 not when they are empty.
3990 1999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3992 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3993 check inside of if (ospf_top).
3995 1999-10-29 Alex Zinin <zinin@amt.ru>
3996 * ospf_lsa.c ospf_lsdb.c :
3997 add assertion in lsa and lsa->data alloc functions,
3998 as well as in lsdb_add for new->data
4000 * ospf_lsdb.c: free hash table correctly
4002 1999-10-28 John Capo <jc@irbs.com>
4004 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
4007 1999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4009 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
4011 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
4013 1999-10-27 Alex Zinin <zinin@amt.ru>
4014 * ospfd, ospf_zebra, ospf_abr
4015 "area import-list" command is added.
4016 This command allows to filter the inter-area routes
4017 injected into an area. Access list hook function
4018 extended to invalidate area exp/imp lists.
4020 1999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
4022 * ospfd.c (ospf_interface_run): Enable to detect P2P network
4023 on an OSPF interface.
4025 1999-10-19 Jordan Mendelson <jordy@wserv.com>
4027 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
4028 in ospf_ls_retransmit_lookup ().
4030 1999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
4032 * ospf_route.c: Workaround about installation of OSPF routes into
4033 the zebra daemon. Add checking of existance routes. Free
4034 ospf_top->old_table if it exists.
4036 1999-10-15 Jordan Mendelson <jordy@wserv.com>
4038 * Add support for MD5 authentication.
4040 1999-10-12 Alex Zinin <zinin@amt.ru>
4041 * ospfd.c, ospfd.h, ospf_abr.c:
4042 a new command "area export-list" was added, it allows
4043 the admin. to control which intra-area routes are
4044 announced to other areas by the ABR
4046 1999-10-12 Alex Zinin <zinin@amt.ru>
4047 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
4048 when "no redistribute" is used after a distribute list
4049 denying some networks was used
4051 1999-10-05 Toshiaki Takada <takada@zebra.org>
4053 * ospf_route.c (ospf_path_dup): New function added.
4055 1999-10-05 Toshiaki Takada <takada@zebra.org>
4057 * ospf_interface.[ch]: Some of VL related funciton name changed.
4059 1999-09-27 Alex Zinin <zinin@amt.ru>
4061 * ospf_zebra.c: Distribute-list functionality added
4063 1999-09-27 Toshiaki Takada <takada@zebra.org>
4065 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4068 1999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4070 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4071 instead of node->next. Reported by Hiroki Ishibashi
4072 <ishibasi@dcd.abk.nec.co.jp>.
4074 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4077 1999-09-23 Alex Zinin <zinin@amt.ru>
4079 * stub area support added
4081 1999-09-23 Alex Zinin <zinin@amt.ru>
4083 * fwd_addr in ASE-LSAs is now set correctly
4084 * ASE routing changed to check the fwd_addr
4085 and skip the route if the addr points to one
4086 of our interfaces to avoid loops.
4088 1999-09-22 Alex Zinin <zinin@amt.ru>
4091 ospf_vls_in_area() added, it returns
4092 the number of VLs configured through the area
4094 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4095 honor correct mem alloc
4097 1999-09-22 Alex Zinin <zinin@amt.ru>
4100 Some OSPF mem types added,
4101 plus more info in "show mem"
4103 1999-09-21 Alex Zinin <zinin@amt.ru>
4106 "area range substitute" added.
4107 It can be used on NAT-enabled (IP-masquarade)
4108 routers to announce private networks
4109 from an area as public ones into the outside
4110 world (not in the RFC, btw :)
4112 1999-09-21 Alex Zinin <zinin@amt.ru>
4115 "area range suppress" added.
4116 This command allows to instruct the router
4117 to be silent about specific ranges, i.e.,
4118 it is a method of route filtering on area
4121 1999-09-21 Alex Zinin <zinin@amt.ru>
4123 * ospfd.c VLs removed when "no network area" executed
4125 1999-09-20 Alex Zinin <zinin@amt.ru>
4127 * ospf_ase.c bug fix for not-zero fwd_addr
4128 and directly connected routes.
4130 1999-09-20 Yon Uriarte <yon@plannet.de>
4132 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4133 checking the length of OSPF packet exceeds MTU or not.
4135 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4138 1999-09-18 Alex Zinin <zinin@amt.ru>
4140 * ospf_lsa.c bug fix for ospf_network_lsa() to
4141 include itself into the RID list
4143 1999-09-10 Alex Zinin <zinin@amt.ru>
4145 * Alternative ABR behaviors IBM/Cisco/Shortcut
4148 1999-09-10 Alex Zinin <zinin@amt.ru>
4150 * router and network-LSA origination
4151 changed to honor MinLSInterval
4153 1999-09-08 Alex Zinin <zinin@amt.ru>
4155 * modified ABR behavior to honor VLs and transit
4158 1999-09-07 Alex Zinin <zinin@amt.ru>
4160 * completed VL functionality
4162 1999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4164 * ospf_asbr.c: New file.
4165 ospf_asbr.h: New file.
4167 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4170 1999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4172 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4173 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4175 1999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4177 * ospf_spf.c (ospf_spf_register): Change name from
4178 ospf_spf_route_add() to ospf_spf_register().
4179 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4181 1999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4183 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4184 lsa->data rather than install new one, when same id lsa is already
4187 1999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4189 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4190 (ospf_network_lsa_install): Likewise.
4191 (ospf_summary_lsa_install): Likewise.
4192 (ospf_summary_asbr_lsa_install): Likewise.
4193 (ospf_external_lsa_install): Likewise.
4195 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4198 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4200 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4203 1999-08-31 Toshiaki Takada <takada@zebra.org>
4205 * ospf_lsa.c (show_ip_ospf_database_summary),
4206 (show_ip_ospf_database_summary_asbr),
4207 (show_ip_ospf_database_external): New function added.
4208 `show ip ospf database summary',
4209 `show ip ospf database asbr-summary'
4210 `show ip ospf database external' command can be used.
4212 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4213 (show_ip_ospf_database_all): show nothing if a type of LSA
4216 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4218 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4219 the node is deleted.
4221 1999-08-31 Toshiaki Takada <takada@zebra.org>
4223 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4225 (ospf_ls_request_new), (ospf_ls_request_free),
4226 (ospf_ls_request_add), (ospf_ls_request_delete),
4227 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4230 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4232 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4234 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4237 1999-08-30 Alex Zinin <zinin@amt.ru>
4240 fix a bug with area range config write
4241 added "show ip ospf" command, it will be enhanced later on
4243 1999-08-30 Alex Zinin <zinin@amt.ru>
4246 updated ospf_router_lsa() to honor flags (B-bit)
4248 1999-08-30 Alex Zinin <zinin@amt.ru>
4251 wrote major functions implementing ABR activity
4253 1999-08-30 Alex Zinin <zinin@amt.ru>
4255 * ospf_ia.c ospf_route.c ospf_route.h
4256 fixed the bug with ospf_route.origin field.
4257 Now it holds pointer to lsa_header
4259 1999-08-30 Alex Zinin <zinin@amt.ru>
4261 * ospf_flood.c ospf_flood.h:
4262 transformed ospf_flood_if_select into ospf_flood_through_area()
4263 added new ospf_flood_if_select() and ospf_flood_through_as()
4265 1999-08-30 Toshiaki Takada <takada@zebra.org>
4267 * ospf_flood.[ch]: New file added.
4269 * ospf_packet.c (ospf_lsa_flooding),
4270 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4272 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4273 (ospf_remove_lsa_from_retransm_list),
4274 (ospf_nbr_remove_all_lsas_from_retransm_list),
4275 (ospf_lsa_remove_from_ls_retransmit):
4276 (ospf_lsa_retransmit): functions move to
4277 ospf_flood.c, and change function's name:
4279 ospf_put_lsa_on_retransm_list ()
4280 -> ospf_ls_retransmit_add ()
4281 ospf_remove_lsa_from_retransm_list ()
4282 -> ospf_ls_retransmit_delete ()
4283 ospf_nbr_remove_all_lsas_from_retransm_list ()
4284 -> ospf_ls_retransmit_clear ()
4285 ospf_lsa_remove_from_ls_retransmit ()
4286 -> ospf_ls_retransmit_delete_nbr_all ()
4287 ospf_lsa_retransmit ()
4288 -> ospf_ls_retransmit_add_nbr_all ()
4290 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4291 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4293 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4295 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4296 route_node_lookup() instead of route_node_get().
4298 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4300 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4302 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4305 1999-08-29 Alex Zinin <zinin@amt.ru>
4307 MaxAge LSA deletion functions added.
4309 1999-08-29 Alex Zinin <zinin@amt.ru>
4311 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4312 when function returns NULL if (rn->info == NULL)
4314 1999-08-29 Alex Zinin <zinin@amt.ru>
4316 added a hack for area range deletion
4318 1999-08-29 Alex Zinin <zinin@amt.ru>
4320 included lsdb field into struct ospf_lsa, to find
4321 LSDB easier when removing MaxAge LSAs.
4323 1999-08-29 Alex Zinin <zinin@amt.ru>
4324 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4325 ospf_packet.c changed to honor new retransmit list
4326 management functions
4328 1999-08-29 Alex Zinin <zinin@amt.ru>
4329 * ospf_neighbor.c , .h added new retransmit list functions.
4331 1999-08-29 Alex Zinin <zinin@amt.ru>
4333 added ospf_ase, ospf_abr, ospf_ia
4335 1999-08-29 Alex Zinin <zinin@amt.ru>
4337 - changed ospf_next_hop_calculation() to include interface
4338 and nexthop addr for directly connected routers---more informative
4339 and solves problem with route installation into the kernel
4340 - changed ospf_nexthop_out_if_addr() to support routers, not only
4342 - added ospf_process_stubs();
4344 1999-08-29 Alex Zinin <zinin@amt.ru>
4346 - changed ospf_router_lsa() to provide correct links
4347 for p-t-p interfaces;
4348 - changed ospf_summary_lsa_install() to support table
4349 of self-originated summary-LSAs;
4350 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4351 - changed ospf_lsa_install() accordingly
4352 - changed show_ip_ospf_database_router_links() to support p-t-p
4354 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4356 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4359 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4361 * ospf_packet.c (ospf_read): Add check of IP src address.
4363 1999-08-28 Alex Zinin <zinin@amt.ru>
4365 added ospf_nbr_lookup_by_routerid()
4367 1999-08-28 Alex Zinin <zinin@amt.ru>
4369 added ABR/ASBR flag definitions and fields;
4370 added iflist field to area structure;
4371 summary_lsa_self and summary_lsa_asbr_self are changed
4373 added ranges field---configured area ranges;
4374 A separate Routers RT added;
4375 area range config commands and config write added
4378 1999-08-28 Alex Zinin <zinin@amt.ru>
4380 ospf_route_free()--added code to free the list of paths;
4381 The following functions added:
4382 ospf_intra_add_router();
4383 ospf_intra_add_transit();
4384 ospf_intra_add_stub();
4385 the last function uses new ospf_int_lookup_by_prefix();
4386 show_ip_ospf_route_cmd()--changed to support new RT structure;
4387 added ospf_cmp_routes()--general route comparision function;
4388 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4389 they are used in ASE and IA routing;
4390 added ospf_subst_route() and ospf_add_route();
4392 1999-08-28 Alex Zinin <zinin@amt.ru>
4394 changed struct ospf_path to include output interface,
4395 changed struct ospf_route to support IA and ASE routing.
4396 added prototypes of the function used in IA and ASE modules.
4398 1999-08-28 Alex Zinin <zinin@amt.ru>
4399 * ospf_lsa.h ospf_lsa.c :
4400 added ospf_my_lsa(), an interface independent version of
4401 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4403 1999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4405 * ospf_interface.c (interface_config_write): Add check for
4408 1999-08-25 Toshiaki Takada <takada@zebra.org>
4410 * ospf_lsa.c (ospf_lsa_dup): New function added.
4412 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4413 interface in debug message.
4415 1999-08-25 Toshiaki Takada <takada@zebra.org>
4417 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4419 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4420 Delayed Link State Acknowledgment is scheduled by timer.
4422 1999-08-25 Alex Zinin <zinin@amt.ru>
4424 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4425 a stub network instead of link to a transit network into
4426 originated router-LSA, bug fixed.
4428 1999-08-24 Toshiaki Takada <takada@zebra.org>
4430 * ospfd.c (ospf_update_router_id): New function added.
4432 * ospf_network.c (ospf_write): Create new socket per transmission.
4433 And select outgoing interface whether dst is unicast or multicast.
4435 * ospf_packet.c: LSA flooding will work.
4437 1999-08-24 VOP <vop@unity.net>
4439 * ospf_route.c: Include "sockunion.h"
4441 1999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4443 * ospf_network.c (ospf_serv_sock_init): Enclose
4444 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4445 not have the definition.
4447 1999-08-23 Toshiaki Takada <takada@zebra.org>
4449 * ospf_packet.c: Fix bug of DD processing.
4451 1999-08-18 Toshiaki Takada <takada@zebra.org>
4453 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4455 1999-08-17 Toshiaki Takada <takada@zebra.org>
4457 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4458 corrected. The bug of `mes_lookup' is fixed.
4459 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4461 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4462 `ospf_add_router_lsa'.
4463 (ospf_network_lsa_install): The name is changed from
4464 `ospf_add_network_lsa'.
4466 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4468 * ospf_interface.c (ospf_if_is_enable): New function added.
4470 1999-08-16 Toshiaki Takada <takada@zebra.org>
4472 * ospf_lsa.h (struct lsa_header): The name is changed from
4474 (struct ospf_lsa): New struct added to control each LSA's aging
4477 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4479 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4480 (ospf_lsa_different), (ospf_lsa_install): New function added.
4482 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4484 1999-08-12 Toshiaki Takada <takada@zebra.org>
4486 * ospf_nsm.c (nsm_reset_nbr): New function added.
4487 KillNbr and LLDown neighbor event call this function.
4489 1999-08-10 Toshiaki Takada <takada@zebra.org>
4491 * ospf_packet.c (ospf_ls_retransmit)
4492 (ospf_ls_upd_timer): New function added.
4493 Set retransmission timer for Link State Update.
4495 1999-07-29 Toshiaki Takada <takada@zebra.org>
4497 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4499 1999-07-28 Toshiaki Takada <takada@zebra.org>
4501 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4502 with IPTOS_PREC_INTERNET_CONTROL.
4504 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4505 if NSM status change.
4507 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4508 Hello packet, when the neighbor goes down.
4510 1999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4512 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4514 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4517 1999-07-25 Toshiaki Takada <takada@zebra.org>
4519 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4522 1999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4524 * ospf_route.c (ospf_route_table_free): New function added.
4526 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4529 * ospfd.h (struct ospf): Add old_table.
4531 * ospf_main.c (sighup): Call of log_rotate () removed.
4533 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4534 area->lsa as self LSA. This should be area->lsa_self.
4536 1999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4538 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4539 (),ospf_zebra_delete () added.
4541 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4543 1999-07-24 Toshiaki Takada <takada@zebra.org>
4545 * ospf_lsa.c: Change LS sequence number treatment.
4546 (ospf_lsa_is_self_originated): New function added.
4547 (show_ip_ospf_database_self_originated): New DEFUN added.
4549 1999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4551 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4553 1999-07-22 Toshiaki Takada <takada@zebra.org>
4555 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4556 (ospf_nexthop_dup): function added.
4557 (ospf_nexthop_calculation): function changed.
4559 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4561 1999-07-21 Toshiaki Takada <takada@zebra.org>
4563 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4565 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4567 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4569 1999-07-21 Toshiaki Takada <takada@zebra.org>
4571 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4573 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4576 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4578 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4579 change behavior according to LSA type.
4580 (ospf_lsa_has_link): Link check function is added.
4582 1999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4584 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4585 SPF calcultion schedule addtition.
4586 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4588 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4590 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4591 header typo correction. Display of router LSA's #link added.
4593 1999-07-19 Toshiaki Takada <takada@zebra.org>
4595 * ospf_packet.c (ospf_check_network_mask): Added new function for
4596 receiving Raw IP packet on an appropriate interface.
4598 1999-07-16 Toshiaki Takada <takada@zebra.org>
4600 * ospfd.c (ospf_router_id): new DEFUN added.
4602 1999-07-15 Toshiaki Takada <takada@zebra.org>
4604 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4605 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4606 (ospf_spf_next_router), (ospf_spf_next_network),
4607 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4610 1999-07-13 Toshiaki Takada <takada@zebra.org>
4612 * ospf_ism.c: fix bug of DR Election.
4614 * ospf_nsm.c: fix bug of adjacency forming.
4616 1999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4618 * ospfd.c (ospf_init): Change to use install_default.
4620 1999-07-01 Rick Payne <rickp@rossfell.co.uk>
4622 * ospf_zebra.c (zebra_init): Install standard commands to
4625 1999-06-30 Toshiaki Takada <takada@zebra.org>
4627 * ospf_dump.c: Whole debug command is improved.
4628 (ISM|NSM) (events|status|timers) debug option added.
4629 (show_debugging_ospf): new DEFUN added.
4631 1999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4633 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4636 1999-06-29 Toshiaki Takada <takada@zebra.org>
4638 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4639 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4641 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4643 * ospf_ism.c (ospf_dr_election): fix DR Election.
4645 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4648 1999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4650 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4652 1999-06-28 Toshiaki Takada <takada@zebra.org>
4654 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4655 `show ip ospf database network' command output.
4657 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4658 Retransmission, Database Summary and Link State Request.
4660 * ospf_packet.c (ospf_ls_req_timer): New function added.
4661 Set Link State Request retransmission timer.
4663 1999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4665 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4668 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4669 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4671 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4672 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4674 1999-06-25 Toshiaki Takada <takada@zebra.org>
4676 * ospf_packet.c: fix bug of DD making.
4677 fix bug of LS-Update reading.
4679 1999-06-23 Toshiaki Takada <takada@zebra.org>
4681 * ospf_packet.c: All type of packets are changed to use
4682 fifo queue structure.
4683 (ospf_fill_header) function added.
4685 1999-06-22 Toshiaki Takada <takada@zebra.org>
4687 * ospf_packet.c (ospf_packet_new): New function added to handle
4688 sending ospf packet by fifo queue structure.
4689 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4690 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4691 (ospf_fifo_free): Likewise.
4693 1999-06-21 Toshiaki Takada <takada@zebra.org>
4695 * ospf_nsm.c (ospf_db_desc_timer): function added.
4696 (nsm_timer_set) function added.
4697 * ospf_dump.c (ospf_option_dump): function added.
4698 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4700 1999-06-20 Toshiaki Takada <takada@zebra.org>
4702 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4703 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4706 1999-06-19 Toshiaki Takada <takada@zebra.org>
4708 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4709 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4710 (if_ospf_hello_interval), (if_ospf_priority),
4711 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4712 argument changed from NUMBER to <range>.
4713 DEFUN (if_ospf_network_broadcast),
4714 DEFUN (if_ospf_network_non_broadcast),
4715 DEFUN (if_ospf_network_point_to_multipoint),
4716 DEFUN (if_ospf_network_point_to_point) functions are combined to
4717 DEFUN (if_ospf_network).
4719 1999-06-18 Toshiaki Takada <takada@zebra.org>
4721 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4722 ospf_lsa_lookup (), ospf_lsa_count () Added.
4724 1999-06-15 Toshiaki Takada <takada@zebra.org>
4726 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4727 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4728 `debug ospf ism' command shows debug message.
4729 `debuf ospf nsm' command shows debug message.
4731 1999-06-14 Toshiaki Takada <takada@zebra.org>
4733 * ospf_lsa.c: ospf_network_lsa () Added.
4734 ospf_lsa_checksum () Added.
4735 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4736 `debug ospf packet' command shows debug message.
4738 1999-06-13 Toshiaki Takada <takada@zebra.org>
4740 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4743 1999-06-11 Toshiaki Takada <takada@zebra.org>
4745 * ospf_dump.c: fix IP packet length treatment.
4747 1999-06-10 Toshiaki Takada <takada@zebra.org>
4749 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4750 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4752 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4753 ospf_make_hello (), ospf_make_db_desc () Added.
4754 ospf_db_desc_proc () Added.n
4756 * Database Description packet can be processed.
4758 1999-06-08 Toshiaki Takada <takada@zebra.org>
4760 * ospf_lsa.c: New file.
4762 1999-06-07 Toshiaki Takada <takada@zebra.org>
4764 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4766 1999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4768 * ospf_spf.[ch]: New file.
4770 1999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4772 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4774 * ospf_zebra.h (zebra_start): Remove struct zebra.
4776 1999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4778 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4779 ntohl for sprintf warning.
4781 1999-05-19 Toshiaki Takada <takada@zebra.org>
4783 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4784 if interface state changes to DR or BDR.
4786 1999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4788 * ospf_main.c (signal_init): SIGTERM call sigint.
4789 (sigint): Logging more better message.
4791 1999-05-12 Toshiaki Takada <takada@zebra.org>
4793 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4795 1999-05-11 Toshiaki Takada <takada@zebra.org>
4797 * ospf_neighbor.c: ospf_nbr_free () Added.
4799 1999-05-10 Toshiaki Takada <takada@zebra.org>
4801 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4802 * Fix bug of `no network' statement, it will work.
4804 1999-05-07 Toshiaki Takada <takada@zebra.org>
4806 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4807 updated by ospf_if_update ().
4809 1999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4811 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4813 1999-04-25 Toshiaki Takada <takada@zebra.org>
4815 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4816 DEFUN (no_if_ospf_dead_interval),
4817 DEFUN (no_if_ospf_hello_interval),
4818 DEFUN (no_if_ospf_priority),
4819 DEFUN (no_if_ospf_retransmit_interval),
4820 DEFUN (no_if_ospf_transmit_delay) Added.
4822 interface_config_write () suppress showing interface
4825 1999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4827 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4829 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4830 of ospf_network { }. So `router ospf' statement in ospfd.conf
4832 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4834 1999-04-25 Toshiaki Takada <takada@zebra.org>
4836 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4837 DEFUN (if_ospf_network_broadcast),
4838 DEFUN (if_ospf_network_non_broadcast),
4839 DEFUN (if_ospf_network_point_to_multipoint),
4840 DEFUN (if_ospf_network_point_to_point),
4841 DEFUN (no_if_ospf_network) Added.
4843 1999-04-23 Toshiaki Takada <takada@zebra.org>
4845 * ospfd.h: struct area { } changed to struct ospf_network { }.
4846 Add struct ospf_area { }.
4847 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4848 and ospf_network_free ().
4849 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4851 1999-04-22 Toshiaki Takada <takada@zebra.org>
4853 * ospf_lsa.h: New file.
4854 * ospf_packet.h: LSA related struct definition are moved to
4856 * ospf_packet.c: ospf_verify_header () Added.
4858 1999-04-21 Toshiaki Takada <takada@zebra.org>
4860 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4861 DR Election bug fixed.
4862 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4863 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4865 1999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4867 * ospf_main.c (main): access_list_init () is added for vty
4868 connection filtering.
4870 1999-04-16 Toshiaki Takada <takada@zebra.org>
4872 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4873 * ospf_neighbor.c: ospf_nbr_count () Added.
4875 1999-04-15 Toshiaki Takada <takada@zebra.org>
4877 * ospfd.h: struct ospf { } Changed.
4878 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4879 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4881 1999-04-14 Toshiaki Takada <takada@zebra.org>
4883 * ospf_ism.c: ospf_elect_dr () Added.
4884 * ospf_network.c: ospf_if_ipmulticast () Added.
4886 1999-04-11 Toshiaki Takada <takada@zebra.org>
4888 * ospf_interface.c: interface_config_write (),
4889 DEFUN (if_ip_ospf_cost),
4890 DEFUN (if_ip_ospf_dead_interval),
4891 DEFUN (if_ip_ospf_hello_interval),
4892 DEFUN (if_ip_ospf_priority),
4893 DEFUN (if_ip_ospf_retransmit_interval) and
4894 DEFUN (if_ip_ospf_transmit_delay) Added.
4896 1999-04-08 Toshiaki Takada <takada@zebra.org>
4898 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4899 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4900 * ospf_nsm.c: nsm_twoway_received () Added.
4902 1999-04-02 Toshiaki Takada <takada@zebra.org>
4904 * ospf_neighbor.c: New file.
4905 * ospf_neighbor.h: New file.
4906 * ospf_nsm.c: New file.
4907 * ospf_nsm.h: New file.
4908 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4909 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4911 1999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4913 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4915 1999-03-19 Toshiaki Takada <takada@zebra.org>
4917 * ospf_packet.c: New file.
4918 * ospf_packet.h: New file.
4919 * ospf_network.c: New file.
4920 * ospf_network.h: New file.
4921 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4923 1999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4925 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4928 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4929 for install ospfd.conf.sample as owner read only file.
4931 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4933 1999-03-15 Toshiaki Takada <takada@zebra.org>
4935 * ospf_ism.c: New file.
4936 * ospf_ism.h: New file.
4937 * ospf_dump.c: New file.
4938 * ospf_dump.h: New file.
4940 * ospfd.h: Add (struct ospf), (struct config_network),
4941 (struct message) structure.
4943 * ospf_interface.c: Add ospf_if_match_network ().
4944 * ospf_interface.h (struct ospf_interface): Change struct members.
4946 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4947 DEFUN (network_area): Added.
4949 * ospfd.conf.sample: Change sample configuration.
4951 1999-03-05 Toshiaki Takada <takada@zebra.org>
4953 * ospf_interface.c: New file.
4954 * ospf_interface.h: New file.
4955 * ospf_zebra.h: New file.
4956 * ospf_zebra.c: Add interface function for zebra daemon.
4957 * ospfd.c: New file.
4959 1999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4961 * Move IPv6 codes and files to ospf6d directory.
4963 1999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4965 * syslog support added
4967 1998-12-22 Toshiaki Takada <takada@zebra.org>
4969 * ospfd.h: New file.
4970 * ospf_lsa.h: New file.
4972 1998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4974 * Makefile.am: New file.
4975 * ospf_main.c: New file.