drivers/usb/host/ohci-pxa27x.c: add missing clk_put
commit7febe2be36035e5c75128e8cc3baeb1f30fa2bc4
authorJulia Lawall <julia@diku.dk>
Wed, 1 Jun 2011 17:10:06 +0000 (1 19:10 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 7 Jun 2011 16:07:47 +0000 (7 09:07 -0700)
treebe07b9ecfc6de82b12f07d293eade844fbd0659f
parent97b2f900335befbf6c4323ea6fd560ea5df4d154
drivers/usb/host/ohci-pxa27x.c: add missing clk_put

Add a label before the call to clk_put and jump to that in the error
handling code that occurs after the call to clk_get has succeeded.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ohci-pxa27x.c