3 * Copyright(c) 2004-2005 Intel Corporation. All rights reserved.
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License as published by the
7 * Free Software Foundation; either version 2 of the License, or
8 * (at your option) any later version.
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
12 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
15 * You should have received a copy of the GNU General Public License along
16 * with this program; if not, write to the Free Software Foundation, Inc.,
17 * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
19 * The full GNU General Public License is included in this distribution in the
20 * file called LICENSE.
23 #include <linux/kernel.h>
24 #include <linux/module.h>
25 #include <linux/device.h>
26 #include <linux/sysdev.h>
28 #include <linux/types.h>
29 #include <linux/string.h>
30 #include <linux/netdevice.h>
31 #include <linux/inetdevice.h>
33 #include <linux/sysfs.h>
34 #include <linux/ctype.h>
35 #include <linux/inet.h>
36 #include <linux/rtnetlink.h>
37 #include <net/net_namespace.h>
41 #define to_dev(obj) container_of(obj,struct device,kobj)
42 #define to_bond(cd) ((struct bonding *)(netdev_priv(to_net_dev(cd))))
44 /*---------------------------- Declarations -------------------------------*/
46 static int expected_refcount
= -1;
47 /*--------------------------- Data Structures -----------------------------*/
49 /* Bonding sysfs lock. Why can't we just use the subsystem lock?
50 * Because kobject_register tries to acquire the subsystem lock. If
51 * we already hold the lock (which we would if the user was creating
52 * a new bond through the sysfs interface), we deadlock.
53 * This lock is only needed when deleting a bond - we need to make sure
54 * that we don't collide with an ongoing ioctl.
57 struct rw_semaphore bonding_rwsem
;
62 /*------------------------------ Functions --------------------------------*/
65 * "show" function for the bond_masters attribute.
66 * The class parameter is ignored.
68 static ssize_t
bonding_show_bonds(struct class *cls
, char *buf
)
73 down_read(&(bonding_rwsem
));
75 list_for_each_entry(bond
, &bond_dev_list
, bond_list
) {
76 if (res
> (PAGE_SIZE
- IFNAMSIZ
)) {
77 /* not enough space for another interface name */
78 if ((PAGE_SIZE
- res
) > 10)
80 res
+= sprintf(buf
+ res
, "++more++ ");
83 res
+= sprintf(buf
+ res
, "%s ", bond
->dev
->name
);
86 buf
[res
-1] = '\n'; /* eat the leftover space */
87 up_read(&(bonding_rwsem
));
92 * "store" function for the bond_masters attribute. This is what
93 * creates and deletes entire bonds.
95 * The class parameter is ignored.
99 static ssize_t
bonding_store_bonds(struct class *cls
, const char *buffer
, size_t count
)
101 char command
[IFNAMSIZ
+ 1] = {0, };
104 struct bonding
*bond
;
106 sscanf(buffer
, "%16s", command
); /* IFNAMSIZ*/
107 ifname
= command
+ 1;
108 if ((strlen(command
) <= 1) ||
109 !dev_valid_name(ifname
))
112 if (command
[0] == '+') {
113 printk(KERN_INFO DRV_NAME
114 ": %s is being created...\n", ifname
);
115 rv
= bond_create(ifname
, &bonding_defaults
);
117 printk(KERN_INFO DRV_NAME
": Bond creation failed.\n");
123 if (command
[0] == '-') {
125 down_write(&bonding_rwsem
);
127 list_for_each_entry(bond
, &bond_dev_list
, bond_list
)
128 if (strnicmp(bond
->dev
->name
, ifname
, IFNAMSIZ
) == 0) {
129 /* check the ref count on the bond's kobject.
130 * If it's > expected, then there's a file open,
131 * and we have to fail.
133 if (atomic_read(&bond
->dev
->dev
.kobj
.kref
.refcount
)
134 > expected_refcount
){
135 printk(KERN_INFO DRV_NAME
136 ": Unable remove bond %s due to open references.\n",
141 printk(KERN_INFO DRV_NAME
142 ": %s is being deleted...\n",
148 printk(KERN_ERR DRV_NAME
149 ": unable to delete non-existent bond %s\n", ifname
);
155 printk(KERN_ERR DRV_NAME
156 ": no command found in bonding_masters. Use +ifname or -ifname.\n");
160 up_write(&bonding_rwsem
);
163 /* Always return either count or an error. If you return 0, you'll
164 * get called forever, which is bad.
169 /* class attribute for bond_masters file. This ends up in /sys/class/net */
170 static CLASS_ATTR(bonding_masters
, S_IWUSR
| S_IRUGO
,
171 bonding_show_bonds
, bonding_store_bonds
);
173 int bond_create_slave_symlinks(struct net_device
*master
, struct net_device
*slave
)
175 char linkname
[IFNAMSIZ
+7];
178 /* first, create a link from the slave back to the master */
179 ret
= sysfs_create_link(&(slave
->dev
.kobj
), &(master
->dev
.kobj
),
183 /* next, create a link from the master to the slave */
184 sprintf(linkname
,"slave_%s",slave
->name
);
185 ret
= sysfs_create_link(&(master
->dev
.kobj
), &(slave
->dev
.kobj
),
191 void bond_destroy_slave_symlinks(struct net_device
*master
, struct net_device
*slave
)
193 char linkname
[IFNAMSIZ
+7];
195 sysfs_remove_link(&(slave
->dev
.kobj
), "master");
196 sprintf(linkname
,"slave_%s",slave
->name
);
197 sysfs_remove_link(&(master
->dev
.kobj
), linkname
);
202 * Show the slaves in the current bond.
204 static ssize_t
bonding_show_slaves(struct device
*d
,
205 struct device_attribute
*attr
, char *buf
)
209 struct bonding
*bond
= to_bond(d
);
211 read_lock(&bond
->lock
);
212 bond_for_each_slave(bond
, slave
, i
) {
213 if (res
> (PAGE_SIZE
- IFNAMSIZ
)) {
214 /* not enough space for another interface name */
215 if ((PAGE_SIZE
- res
) > 10)
216 res
= PAGE_SIZE
- 10;
217 res
+= sprintf(buf
+ res
, "++more++ ");
220 res
+= sprintf(buf
+ res
, "%s ", slave
->dev
->name
);
222 read_unlock(&bond
->lock
);
224 buf
[res
-1] = '\n'; /* eat the leftover space */
229 * Set the slaves in the current bond. The bond interface must be
230 * up for this to succeed.
231 * This function is largely the same flow as bonding_update_bonds().
233 static ssize_t
bonding_store_slaves(struct device
*d
,
234 struct device_attribute
*attr
,
235 const char *buffer
, size_t count
)
237 char command
[IFNAMSIZ
+ 1] = { 0, };
239 int i
, res
, found
, ret
= count
;
242 struct net_device
*dev
= NULL
;
243 struct bonding
*bond
= to_bond(d
);
245 /* Quick sanity check -- is the bond interface up? */
246 if (!(bond
->dev
->flags
& IFF_UP
)) {
247 printk(KERN_WARNING DRV_NAME
248 ": %s: doing slave updates when interface is down.\n",
252 /* Note: We can't hold bond->lock here, as bond_create grabs it. */
255 down_write(&(bonding_rwsem
));
257 sscanf(buffer
, "%16s", command
); /* IFNAMSIZ*/
258 ifname
= command
+ 1;
259 if ((strlen(command
) <= 1) ||
260 !dev_valid_name(ifname
))
263 if (command
[0] == '+') {
265 /* Got a slave name in ifname. Is it already in the list? */
267 read_lock(&bond
->lock
);
268 bond_for_each_slave(bond
, slave
, i
)
269 if (strnicmp(slave
->dev
->name
, ifname
, IFNAMSIZ
) == 0) {
270 printk(KERN_ERR DRV_NAME
271 ": %s: Interface %s is already enslaved!\n",
272 bond
->dev
->name
, ifname
);
274 read_unlock(&bond
->lock
);
278 read_unlock(&bond
->lock
);
279 printk(KERN_INFO DRV_NAME
": %s: Adding slave %s.\n",
280 bond
->dev
->name
, ifname
);
281 dev
= dev_get_by_name(&init_net
, ifname
);
283 printk(KERN_INFO DRV_NAME
284 ": %s: Interface %s does not exist!\n",
285 bond
->dev
->name
, ifname
);
292 if (dev
->flags
& IFF_UP
) {
293 printk(KERN_ERR DRV_NAME
294 ": %s: Error: Unable to enslave %s "
295 "because it is already up.\n",
296 bond
->dev
->name
, dev
->name
);
300 /* If this is the first slave, then we need to set
301 the master's hardware address to be the same as the
303 if (!(*((u32
*) & (bond
->dev
->dev_addr
[0])))) {
304 memcpy(bond
->dev
->dev_addr
, dev
->dev_addr
,
308 /* Set the slave's MTU to match the bond */
309 original_mtu
= dev
->mtu
;
310 res
= dev_set_mtu(dev
, bond
->dev
->mtu
);
316 res
= bond_enslave(bond
->dev
, dev
);
317 bond_for_each_slave(bond
, slave
, i
)
318 if (strnicmp(slave
->dev
->name
, ifname
, IFNAMSIZ
) == 0)
319 slave
->original_mtu
= original_mtu
;
326 if (command
[0] == '-') {
329 bond_for_each_slave(bond
, slave
, i
)
330 if (strnicmp(slave
->dev
->name
, ifname
, IFNAMSIZ
) == 0) {
332 original_mtu
= slave
->original_mtu
;
336 printk(KERN_INFO DRV_NAME
": %s: Removing slave %s\n",
337 bond
->dev
->name
, dev
->name
);
338 res
= bond_release(bond
->dev
, dev
);
343 /* set the slave MTU to the default */
344 dev_set_mtu(dev
, original_mtu
);
347 printk(KERN_ERR DRV_NAME
": unable to remove non-existent slave %s for bond %s.\n",
348 ifname
, bond
->dev
->name
);
355 printk(KERN_ERR DRV_NAME
": no command found in slaves file for bond %s. Use +ifname or -ifname.\n", bond
->dev
->name
);
359 up_write(&(bonding_rwsem
));
364 static DEVICE_ATTR(slaves
, S_IRUGO
| S_IWUSR
, bonding_show_slaves
, bonding_store_slaves
);
367 * Show and set the bonding mode. The bond interface must be down to
370 static ssize_t
bonding_show_mode(struct device
*d
,
371 struct device_attribute
*attr
, char *buf
)
373 struct bonding
*bond
= to_bond(d
);
375 return sprintf(buf
, "%s %d\n",
376 bond_mode_tbl
[bond
->params
.mode
].modename
,
380 static ssize_t
bonding_store_mode(struct device
*d
,
381 struct device_attribute
*attr
,
382 const char *buf
, size_t count
)
384 int new_value
, ret
= count
;
385 struct bonding
*bond
= to_bond(d
);
387 if (bond
->dev
->flags
& IFF_UP
) {
388 printk(KERN_ERR DRV_NAME
389 ": unable to update mode of %s because interface is up.\n",
395 new_value
= bond_parse_parm(buf
, bond_mode_tbl
);
397 printk(KERN_ERR DRV_NAME
398 ": %s: Ignoring invalid mode value %.*s.\n",
400 (int)strlen(buf
) - 1, buf
);
404 if (bond
->params
.mode
== BOND_MODE_8023AD
)
405 bond_unset_master_3ad_flags(bond
);
407 if (bond
->params
.mode
== BOND_MODE_ALB
)
408 bond_unset_master_alb_flags(bond
);
410 bond
->params
.mode
= new_value
;
411 bond_set_mode_ops(bond
, bond
->params
.mode
);
412 printk(KERN_INFO DRV_NAME
": %s: setting mode to %s (%d).\n",
413 bond
->dev
->name
, bond_mode_tbl
[new_value
].modename
, new_value
);
418 static DEVICE_ATTR(mode
, S_IRUGO
| S_IWUSR
, bonding_show_mode
, bonding_store_mode
);
421 * Show and set the bonding transmit hash method. The bond interface must be down to
422 * change the xmit hash policy.
424 static ssize_t
bonding_show_xmit_hash(struct device
*d
,
425 struct device_attribute
*attr
,
428 struct bonding
*bond
= to_bond(d
);
430 return sprintf(buf
, "%s %d\n",
431 xmit_hashtype_tbl
[bond
->params
.xmit_policy
].modename
,
432 bond
->params
.xmit_policy
);
435 static ssize_t
bonding_store_xmit_hash(struct device
*d
,
436 struct device_attribute
*attr
,
437 const char *buf
, size_t count
)
439 int new_value
, ret
= count
;
440 struct bonding
*bond
= to_bond(d
);
442 if (bond
->dev
->flags
& IFF_UP
) {
443 printk(KERN_ERR DRV_NAME
444 "%s: Interface is up. Unable to update xmit policy.\n",
450 new_value
= bond_parse_parm(buf
, xmit_hashtype_tbl
);
452 printk(KERN_ERR DRV_NAME
453 ": %s: Ignoring invalid xmit hash policy value %.*s.\n",
455 (int)strlen(buf
) - 1, buf
);
459 bond
->params
.xmit_policy
= new_value
;
460 bond_set_mode_ops(bond
, bond
->params
.mode
);
461 printk(KERN_INFO DRV_NAME
": %s: setting xmit hash policy to %s (%d).\n",
462 bond
->dev
->name
, xmit_hashtype_tbl
[new_value
].modename
, new_value
);
467 static DEVICE_ATTR(xmit_hash_policy
, S_IRUGO
| S_IWUSR
, bonding_show_xmit_hash
, bonding_store_xmit_hash
);
470 * Show and set arp_validate.
472 static ssize_t
bonding_show_arp_validate(struct device
*d
,
473 struct device_attribute
*attr
,
476 struct bonding
*bond
= to_bond(d
);
478 return sprintf(buf
, "%s %d\n",
479 arp_validate_tbl
[bond
->params
.arp_validate
].modename
,
480 bond
->params
.arp_validate
);
483 static ssize_t
bonding_store_arp_validate(struct device
*d
,
484 struct device_attribute
*attr
,
485 const char *buf
, size_t count
)
488 struct bonding
*bond
= to_bond(d
);
490 new_value
= bond_parse_parm(buf
, arp_validate_tbl
);
492 printk(KERN_ERR DRV_NAME
493 ": %s: Ignoring invalid arp_validate value %s\n",
494 bond
->dev
->name
, buf
);
497 if (new_value
&& (bond
->params
.mode
!= BOND_MODE_ACTIVEBACKUP
)) {
498 printk(KERN_ERR DRV_NAME
499 ": %s: arp_validate only supported in active-backup mode.\n",
503 printk(KERN_INFO DRV_NAME
": %s: setting arp_validate to %s (%d).\n",
504 bond
->dev
->name
, arp_validate_tbl
[new_value
].modename
,
507 if (!bond
->params
.arp_validate
&& new_value
) {
508 bond_register_arp(bond
);
509 } else if (bond
->params
.arp_validate
&& !new_value
) {
510 bond_unregister_arp(bond
);
513 bond
->params
.arp_validate
= new_value
;
518 static DEVICE_ATTR(arp_validate
, S_IRUGO
| S_IWUSR
, bonding_show_arp_validate
, bonding_store_arp_validate
);
521 * Show and store fail_over_mac. User only allowed to change the
522 * value when there are no slaves.
524 static ssize_t
bonding_show_fail_over_mac(struct device
*d
, struct device_attribute
*attr
, char *buf
)
526 struct bonding
*bond
= to_bond(d
);
528 return sprintf(buf
, "%s %d\n",
529 fail_over_mac_tbl
[bond
->params
.fail_over_mac
].modename
,
530 bond
->params
.fail_over_mac
);
533 static ssize_t
bonding_store_fail_over_mac(struct device
*d
, struct device_attribute
*attr
, const char *buf
, size_t count
)
536 struct bonding
*bond
= to_bond(d
);
538 if (bond
->slave_cnt
!= 0) {
539 printk(KERN_ERR DRV_NAME
540 ": %s: Can't alter fail_over_mac with slaves in bond.\n",
545 new_value
= bond_parse_parm(buf
, fail_over_mac_tbl
);
547 printk(KERN_ERR DRV_NAME
548 ": %s: Ignoring invalid fail_over_mac value %s.\n",
549 bond
->dev
->name
, buf
);
553 bond
->params
.fail_over_mac
= new_value
;
554 printk(KERN_INFO DRV_NAME
": %s: Setting fail_over_mac to %s (%d).\n",
555 bond
->dev
->name
, fail_over_mac_tbl
[new_value
].modename
,
561 static DEVICE_ATTR(fail_over_mac
, S_IRUGO
| S_IWUSR
, bonding_show_fail_over_mac
, bonding_store_fail_over_mac
);
564 * Show and set the arp timer interval. There are two tricky bits
565 * here. First, if ARP monitoring is activated, then we must disable
566 * MII monitoring. Second, if the ARP timer isn't running, we must
569 static ssize_t
bonding_show_arp_interval(struct device
*d
,
570 struct device_attribute
*attr
,
573 struct bonding
*bond
= to_bond(d
);
575 return sprintf(buf
, "%d\n", bond
->params
.arp_interval
);
578 static ssize_t
bonding_store_arp_interval(struct device
*d
,
579 struct device_attribute
*attr
,
580 const char *buf
, size_t count
)
582 int new_value
, ret
= count
;
583 struct bonding
*bond
= to_bond(d
);
585 if (sscanf(buf
, "%d", &new_value
) != 1) {
586 printk(KERN_ERR DRV_NAME
587 ": %s: no arp_interval value specified.\n",
593 printk(KERN_ERR DRV_NAME
594 ": %s: Invalid arp_interval value %d not in range 1-%d; rejected.\n",
595 bond
->dev
->name
, new_value
, INT_MAX
);
600 printk(KERN_INFO DRV_NAME
601 ": %s: Setting ARP monitoring interval to %d.\n",
602 bond
->dev
->name
, new_value
);
603 bond
->params
.arp_interval
= new_value
;
604 if (bond
->params
.arp_interval
)
605 bond
->dev
->priv_flags
|= IFF_MASTER_ARPMON
;
606 if (bond
->params
.miimon
) {
607 printk(KERN_INFO DRV_NAME
608 ": %s: ARP monitoring cannot be used with MII monitoring. "
609 "%s Disabling MII monitoring.\n",
610 bond
->dev
->name
, bond
->dev
->name
);
611 bond
->params
.miimon
= 0;
612 if (delayed_work_pending(&bond
->mii_work
)) {
613 cancel_delayed_work(&bond
->mii_work
);
614 flush_workqueue(bond
->wq
);
617 if (!bond
->params
.arp_targets
[0]) {
618 printk(KERN_INFO DRV_NAME
619 ": %s: ARP monitoring has been set up, "
620 "but no ARP targets have been specified.\n",
623 if (bond
->dev
->flags
& IFF_UP
) {
624 /* If the interface is up, we may need to fire off
625 * the ARP timer. If the interface is down, the
626 * timer will get fired off when the open function
629 if (!delayed_work_pending(&bond
->arp_work
)) {
630 if (bond
->params
.mode
== BOND_MODE_ACTIVEBACKUP
)
631 INIT_DELAYED_WORK(&bond
->arp_work
,
632 bond_activebackup_arp_mon
);
634 INIT_DELAYED_WORK(&bond
->arp_work
,
635 bond_loadbalance_arp_mon
);
637 queue_delayed_work(bond
->wq
, &bond
->arp_work
, 0);
644 static DEVICE_ATTR(arp_interval
, S_IRUGO
| S_IWUSR
, bonding_show_arp_interval
, bonding_store_arp_interval
);
647 * Show and set the arp targets.
649 static ssize_t
bonding_show_arp_targets(struct device
*d
,
650 struct device_attribute
*attr
,
654 struct bonding
*bond
= to_bond(d
);
656 for (i
= 0; i
< BOND_MAX_ARP_TARGETS
; i
++) {
657 if (bond
->params
.arp_targets
[i
])
658 res
+= sprintf(buf
+ res
, "%pI4 ",
659 &bond
->params
.arp_targets
[i
]);
662 buf
[res
-1] = '\n'; /* eat the leftover space */
666 static ssize_t
bonding_store_arp_targets(struct device
*d
,
667 struct device_attribute
*attr
,
668 const char *buf
, size_t count
)
671 int i
= 0, done
= 0, ret
= count
;
672 struct bonding
*bond
= to_bond(d
);
675 targets
= bond
->params
.arp_targets
;
676 newtarget
= in_aton(buf
+ 1);
679 if ((newtarget
== 0) || (newtarget
== htonl(INADDR_BROADCAST
))) {
680 printk(KERN_ERR DRV_NAME
681 ": %s: invalid ARP target %pI4 specified for addition\n",
682 bond
->dev
->name
, &newtarget
);
686 /* look for an empty slot to put the target in, and check for dupes */
687 for (i
= 0; (i
< BOND_MAX_ARP_TARGETS
) && !done
; i
++) {
688 if (targets
[i
] == newtarget
) { /* duplicate */
689 printk(KERN_ERR DRV_NAME
690 ": %s: ARP target %pI4 is already present\n",
691 bond
->dev
->name
, &newtarget
);
695 if (targets
[i
] == 0) {
696 printk(KERN_INFO DRV_NAME
697 ": %s: adding ARP target %pI4.\n",
698 bond
->dev
->name
, &newtarget
);
700 targets
[i
] = newtarget
;
704 printk(KERN_ERR DRV_NAME
705 ": %s: ARP target table is full!\n",
712 else if (buf
[0] == '-') {
713 if ((newtarget
== 0) || (newtarget
== htonl(INADDR_BROADCAST
))) {
714 printk(KERN_ERR DRV_NAME
715 ": %s: invalid ARP target %pI4 specified for removal\n",
716 bond
->dev
->name
, &newtarget
);
721 for (i
= 0; (i
< BOND_MAX_ARP_TARGETS
) && !done
; i
++) {
722 if (targets
[i
] == newtarget
) {
724 printk(KERN_INFO DRV_NAME
725 ": %s: removing ARP target %pI4.\n",
726 bond
->dev
->name
, &newtarget
);
727 for (j
= i
; (j
< (BOND_MAX_ARP_TARGETS
-1)) && targets
[j
+1]; j
++)
728 targets
[j
] = targets
[j
+1];
735 printk(KERN_INFO DRV_NAME
736 ": %s: unable to remove nonexistent ARP target %pI4.\n",
737 bond
->dev
->name
, &newtarget
);
743 printk(KERN_ERR DRV_NAME
": no command found in arp_ip_targets file for bond %s. Use +<addr> or -<addr>.\n",
752 static DEVICE_ATTR(arp_ip_target
, S_IRUGO
| S_IWUSR
, bonding_show_arp_targets
, bonding_store_arp_targets
);
755 * Show and set the up and down delays. These must be multiples of the
756 * MII monitoring value, and are stored internally as the multiplier.
757 * Thus, we must translate to MS for the real world.
759 static ssize_t
bonding_show_downdelay(struct device
*d
,
760 struct device_attribute
*attr
,
763 struct bonding
*bond
= to_bond(d
);
765 return sprintf(buf
, "%d\n", bond
->params
.downdelay
* bond
->params
.miimon
);
768 static ssize_t
bonding_store_downdelay(struct device
*d
,
769 struct device_attribute
*attr
,
770 const char *buf
, size_t count
)
772 int new_value
, ret
= count
;
773 struct bonding
*bond
= to_bond(d
);
775 if (!(bond
->params
.miimon
)) {
776 printk(KERN_ERR DRV_NAME
777 ": %s: Unable to set down delay as MII monitoring is disabled\n",
783 if (sscanf(buf
, "%d", &new_value
) != 1) {
784 printk(KERN_ERR DRV_NAME
785 ": %s: no down delay value specified.\n",
791 printk(KERN_ERR DRV_NAME
792 ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
793 bond
->dev
->name
, new_value
, 1, INT_MAX
);
797 if ((new_value
% bond
->params
.miimon
) != 0) {
798 printk(KERN_WARNING DRV_NAME
799 ": %s: Warning: down delay (%d) is not a multiple "
800 "of miimon (%d), delay rounded to %d ms\n",
801 bond
->dev
->name
, new_value
, bond
->params
.miimon
,
802 (new_value
/ bond
->params
.miimon
) *
803 bond
->params
.miimon
);
805 bond
->params
.downdelay
= new_value
/ bond
->params
.miimon
;
806 printk(KERN_INFO DRV_NAME
": %s: Setting down delay to %d.\n",
807 bond
->dev
->name
, bond
->params
.downdelay
* bond
->params
.miimon
);
814 static DEVICE_ATTR(downdelay
, S_IRUGO
| S_IWUSR
, bonding_show_downdelay
, bonding_store_downdelay
);
816 static ssize_t
bonding_show_updelay(struct device
*d
,
817 struct device_attribute
*attr
,
820 struct bonding
*bond
= to_bond(d
);
822 return sprintf(buf
, "%d\n", bond
->params
.updelay
* bond
->params
.miimon
);
826 static ssize_t
bonding_store_updelay(struct device
*d
,
827 struct device_attribute
*attr
,
828 const char *buf
, size_t count
)
830 int new_value
, ret
= count
;
831 struct bonding
*bond
= to_bond(d
);
833 if (!(bond
->params
.miimon
)) {
834 printk(KERN_ERR DRV_NAME
835 ": %s: Unable to set up delay as MII monitoring is disabled\n",
841 if (sscanf(buf
, "%d", &new_value
) != 1) {
842 printk(KERN_ERR DRV_NAME
843 ": %s: no up delay value specified.\n",
849 printk(KERN_ERR DRV_NAME
850 ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
851 bond
->dev
->name
, new_value
, 1, INT_MAX
);
855 if ((new_value
% bond
->params
.miimon
) != 0) {
856 printk(KERN_WARNING DRV_NAME
857 ": %s: Warning: up delay (%d) is not a multiple "
858 "of miimon (%d), updelay rounded to %d ms\n",
859 bond
->dev
->name
, new_value
, bond
->params
.miimon
,
860 (new_value
/ bond
->params
.miimon
) *
861 bond
->params
.miimon
);
863 bond
->params
.updelay
= new_value
/ bond
->params
.miimon
;
864 printk(KERN_INFO DRV_NAME
": %s: Setting up delay to %d.\n",
865 bond
->dev
->name
, bond
->params
.updelay
* bond
->params
.miimon
);
872 static DEVICE_ATTR(updelay
, S_IRUGO
| S_IWUSR
, bonding_show_updelay
, bonding_store_updelay
);
875 * Show and set the LACP interval. Interface must be down, and the mode
876 * must be set to 802.3ad mode.
878 static ssize_t
bonding_show_lacp(struct device
*d
,
879 struct device_attribute
*attr
,
882 struct bonding
*bond
= to_bond(d
);
884 return sprintf(buf
, "%s %d\n",
885 bond_lacp_tbl
[bond
->params
.lacp_fast
].modename
,
886 bond
->params
.lacp_fast
);
889 static ssize_t
bonding_store_lacp(struct device
*d
,
890 struct device_attribute
*attr
,
891 const char *buf
, size_t count
)
893 int new_value
, ret
= count
;
894 struct bonding
*bond
= to_bond(d
);
896 if (bond
->dev
->flags
& IFF_UP
) {
897 printk(KERN_ERR DRV_NAME
898 ": %s: Unable to update LACP rate because interface is up.\n",
904 if (bond
->params
.mode
!= BOND_MODE_8023AD
) {
905 printk(KERN_ERR DRV_NAME
906 ": %s: Unable to update LACP rate because bond is not in 802.3ad mode.\n",
912 new_value
= bond_parse_parm(buf
, bond_lacp_tbl
);
914 if ((new_value
== 1) || (new_value
== 0)) {
915 bond
->params
.lacp_fast
= new_value
;
916 printk(KERN_INFO DRV_NAME
917 ": %s: Setting LACP rate to %s (%d).\n",
918 bond
->dev
->name
, bond_lacp_tbl
[new_value
].modename
, new_value
);
920 printk(KERN_ERR DRV_NAME
921 ": %s: Ignoring invalid LACP rate value %.*s.\n",
922 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
928 static DEVICE_ATTR(lacp_rate
, S_IRUGO
| S_IWUSR
, bonding_show_lacp
, bonding_store_lacp
);
930 static ssize_t
bonding_show_ad_select(struct device
*d
,
931 struct device_attribute
*attr
,
934 struct bonding
*bond
= to_bond(d
);
936 return sprintf(buf
, "%s %d\n",
937 ad_select_tbl
[bond
->params
.ad_select
].modename
,
938 bond
->params
.ad_select
);
942 static ssize_t
bonding_store_ad_select(struct device
*d
,
943 struct device_attribute
*attr
,
944 const char *buf
, size_t count
)
946 int new_value
, ret
= count
;
947 struct bonding
*bond
= to_bond(d
);
949 if (bond
->dev
->flags
& IFF_UP
) {
950 printk(KERN_ERR DRV_NAME
951 ": %s: Unable to update ad_select because interface "
952 "is up.\n", bond
->dev
->name
);
957 new_value
= bond_parse_parm(buf
, ad_select_tbl
);
959 if (new_value
!= -1) {
960 bond
->params
.ad_select
= new_value
;
961 printk(KERN_INFO DRV_NAME
962 ": %s: Setting ad_select to %s (%d).\n",
963 bond
->dev
->name
, ad_select_tbl
[new_value
].modename
,
966 printk(KERN_ERR DRV_NAME
967 ": %s: Ignoring invalid ad_select value %.*s.\n",
968 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
975 static DEVICE_ATTR(ad_select
, S_IRUGO
| S_IWUSR
, bonding_show_ad_select
, bonding_store_ad_select
);
978 * Show and set the number of grat ARP to send after a failover event.
980 static ssize_t
bonding_show_n_grat_arp(struct device
*d
,
981 struct device_attribute
*attr
,
984 struct bonding
*bond
= to_bond(d
);
986 return sprintf(buf
, "%d\n", bond
->params
.num_grat_arp
);
989 static ssize_t
bonding_store_n_grat_arp(struct device
*d
,
990 struct device_attribute
*attr
,
991 const char *buf
, size_t count
)
993 int new_value
, ret
= count
;
994 struct bonding
*bond
= to_bond(d
);
996 if (sscanf(buf
, "%d", &new_value
) != 1) {
997 printk(KERN_ERR DRV_NAME
998 ": %s: no num_grat_arp value specified.\n",
1003 if (new_value
< 0 || new_value
> 255) {
1004 printk(KERN_ERR DRV_NAME
1005 ": %s: Invalid num_grat_arp value %d not in range 0-255; rejected.\n",
1006 bond
->dev
->name
, new_value
);
1010 bond
->params
.num_grat_arp
= new_value
;
1015 static DEVICE_ATTR(num_grat_arp
, S_IRUGO
| S_IWUSR
, bonding_show_n_grat_arp
, bonding_store_n_grat_arp
);
1018 * Show and set the number of unsolicted NA's to send after a failover event.
1020 static ssize_t
bonding_show_n_unsol_na(struct device
*d
,
1021 struct device_attribute
*attr
,
1024 struct bonding
*bond
= to_bond(d
);
1026 return sprintf(buf
, "%d\n", bond
->params
.num_unsol_na
);
1029 static ssize_t
bonding_store_n_unsol_na(struct device
*d
,
1030 struct device_attribute
*attr
,
1031 const char *buf
, size_t count
)
1033 int new_value
, ret
= count
;
1034 struct bonding
*bond
= to_bond(d
);
1036 if (sscanf(buf
, "%d", &new_value
) != 1) {
1037 printk(KERN_ERR DRV_NAME
1038 ": %s: no num_unsol_na value specified.\n",
1043 if (new_value
< 0 || new_value
> 255) {
1044 printk(KERN_ERR DRV_NAME
1045 ": %s: Invalid num_unsol_na value %d not in range 0-255; rejected.\n",
1046 bond
->dev
->name
, new_value
);
1050 bond
->params
.num_unsol_na
= new_value
;
1055 static DEVICE_ATTR(num_unsol_na
, S_IRUGO
| S_IWUSR
, bonding_show_n_unsol_na
, bonding_store_n_unsol_na
);
1058 * Show and set the MII monitor interval. There are two tricky bits
1059 * here. First, if MII monitoring is activated, then we must disable
1060 * ARP monitoring. Second, if the timer isn't running, we must
1063 static ssize_t
bonding_show_miimon(struct device
*d
,
1064 struct device_attribute
*attr
,
1067 struct bonding
*bond
= to_bond(d
);
1069 return sprintf(buf
, "%d\n", bond
->params
.miimon
);
1072 static ssize_t
bonding_store_miimon(struct device
*d
,
1073 struct device_attribute
*attr
,
1074 const char *buf
, size_t count
)
1076 int new_value
, ret
= count
;
1077 struct bonding
*bond
= to_bond(d
);
1079 if (sscanf(buf
, "%d", &new_value
) != 1) {
1080 printk(KERN_ERR DRV_NAME
1081 ": %s: no miimon value specified.\n",
1086 if (new_value
< 0) {
1087 printk(KERN_ERR DRV_NAME
1088 ": %s: Invalid miimon value %d not in range %d-%d; rejected.\n",
1089 bond
->dev
->name
, new_value
, 1, INT_MAX
);
1093 printk(KERN_INFO DRV_NAME
1094 ": %s: Setting MII monitoring interval to %d.\n",
1095 bond
->dev
->name
, new_value
);
1096 bond
->params
.miimon
= new_value
;
1097 if(bond
->params
.updelay
)
1098 printk(KERN_INFO DRV_NAME
1099 ": %s: Note: Updating updelay (to %d) "
1100 "since it is a multiple of the miimon value.\n",
1102 bond
->params
.updelay
* bond
->params
.miimon
);
1103 if(bond
->params
.downdelay
)
1104 printk(KERN_INFO DRV_NAME
1105 ": %s: Note: Updating downdelay (to %d) "
1106 "since it is a multiple of the miimon value.\n",
1108 bond
->params
.downdelay
* bond
->params
.miimon
);
1109 if (bond
->params
.arp_interval
) {
1110 printk(KERN_INFO DRV_NAME
1111 ": %s: MII monitoring cannot be used with "
1112 "ARP monitoring. Disabling ARP monitoring...\n",
1114 bond
->params
.arp_interval
= 0;
1115 bond
->dev
->priv_flags
&= ~IFF_MASTER_ARPMON
;
1116 if (bond
->params
.arp_validate
) {
1117 bond_unregister_arp(bond
);
1118 bond
->params
.arp_validate
=
1119 BOND_ARP_VALIDATE_NONE
;
1121 if (delayed_work_pending(&bond
->arp_work
)) {
1122 cancel_delayed_work(&bond
->arp_work
);
1123 flush_workqueue(bond
->wq
);
1127 if (bond
->dev
->flags
& IFF_UP
) {
1128 /* If the interface is up, we may need to fire off
1129 * the MII timer. If the interface is down, the
1130 * timer will get fired off when the open function
1133 if (!delayed_work_pending(&bond
->mii_work
)) {
1134 INIT_DELAYED_WORK(&bond
->mii_work
,
1136 queue_delayed_work(bond
->wq
,
1137 &bond
->mii_work
, 0);
1144 static DEVICE_ATTR(miimon
, S_IRUGO
| S_IWUSR
, bonding_show_miimon
, bonding_store_miimon
);
1147 * Show and set the primary slave. The store function is much
1148 * simpler than bonding_store_slaves function because it only needs to
1149 * handle one interface name.
1150 * The bond must be a mode that supports a primary for this be
1153 static ssize_t
bonding_show_primary(struct device
*d
,
1154 struct device_attribute
*attr
,
1158 struct bonding
*bond
= to_bond(d
);
1160 if (bond
->primary_slave
)
1161 count
= sprintf(buf
, "%s\n", bond
->primary_slave
->dev
->name
);
1166 static ssize_t
bonding_store_primary(struct device
*d
,
1167 struct device_attribute
*attr
,
1168 const char *buf
, size_t count
)
1171 struct slave
*slave
;
1172 struct bonding
*bond
= to_bond(d
);
1175 read_lock(&bond
->lock
);
1176 write_lock_bh(&bond
->curr_slave_lock
);
1178 if (!USES_PRIMARY(bond
->params
.mode
)) {
1179 printk(KERN_INFO DRV_NAME
1180 ": %s: Unable to set primary slave; %s is in mode %d\n",
1181 bond
->dev
->name
, bond
->dev
->name
, bond
->params
.mode
);
1183 bond_for_each_slave(bond
, slave
, i
) {
1185 (slave
->dev
->name
, buf
,
1186 strlen(slave
->dev
->name
)) == 0) {
1187 printk(KERN_INFO DRV_NAME
1188 ": %s: Setting %s as primary slave.\n",
1189 bond
->dev
->name
, slave
->dev
->name
);
1190 bond
->primary_slave
= slave
;
1191 bond_select_active_slave(bond
);
1196 /* if we got here, then we didn't match the name of any slave */
1198 if (strlen(buf
) == 0 || buf
[0] == '\n') {
1199 printk(KERN_INFO DRV_NAME
1200 ": %s: Setting primary slave to None.\n",
1202 bond
->primary_slave
= NULL
;
1203 bond_select_active_slave(bond
);
1205 printk(KERN_INFO DRV_NAME
1206 ": %s: Unable to set %.*s as primary slave as it is not a slave.\n",
1207 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
1211 write_unlock_bh(&bond
->curr_slave_lock
);
1212 read_unlock(&bond
->lock
);
1217 static DEVICE_ATTR(primary
, S_IRUGO
| S_IWUSR
, bonding_show_primary
, bonding_store_primary
);
1220 * Show and set the use_carrier flag.
1222 static ssize_t
bonding_show_carrier(struct device
*d
,
1223 struct device_attribute
*attr
,
1226 struct bonding
*bond
= to_bond(d
);
1228 return sprintf(buf
, "%d\n", bond
->params
.use_carrier
);
1231 static ssize_t
bonding_store_carrier(struct device
*d
,
1232 struct device_attribute
*attr
,
1233 const char *buf
, size_t count
)
1235 int new_value
, ret
= count
;
1236 struct bonding
*bond
= to_bond(d
);
1239 if (sscanf(buf
, "%d", &new_value
) != 1) {
1240 printk(KERN_ERR DRV_NAME
1241 ": %s: no use_carrier value specified.\n",
1246 if ((new_value
== 0) || (new_value
== 1)) {
1247 bond
->params
.use_carrier
= new_value
;
1248 printk(KERN_INFO DRV_NAME
": %s: Setting use_carrier to %d.\n",
1249 bond
->dev
->name
, new_value
);
1251 printk(KERN_INFO DRV_NAME
1252 ": %s: Ignoring invalid use_carrier value %d.\n",
1253 bond
->dev
->name
, new_value
);
1258 static DEVICE_ATTR(use_carrier
, S_IRUGO
| S_IWUSR
, bonding_show_carrier
, bonding_store_carrier
);
1262 * Show and set currently active_slave.
1264 static ssize_t
bonding_show_active_slave(struct device
*d
,
1265 struct device_attribute
*attr
,
1269 struct bonding
*bond
= to_bond(d
);
1272 read_lock(&bond
->curr_slave_lock
);
1273 curr
= bond
->curr_active_slave
;
1274 read_unlock(&bond
->curr_slave_lock
);
1276 if (USES_PRIMARY(bond
->params
.mode
) && curr
)
1277 count
= sprintf(buf
, "%s\n", curr
->dev
->name
);
1281 static ssize_t
bonding_store_active_slave(struct device
*d
,
1282 struct device_attribute
*attr
,
1283 const char *buf
, size_t count
)
1286 struct slave
*slave
;
1287 struct slave
*old_active
= NULL
;
1288 struct slave
*new_active
= NULL
;
1289 struct bonding
*bond
= to_bond(d
);
1292 read_lock(&bond
->lock
);
1293 write_lock_bh(&bond
->curr_slave_lock
);
1295 if (!USES_PRIMARY(bond
->params
.mode
)) {
1296 printk(KERN_INFO DRV_NAME
1297 ": %s: Unable to change active slave; %s is in mode %d\n",
1298 bond
->dev
->name
, bond
->dev
->name
, bond
->params
.mode
);
1300 bond_for_each_slave(bond
, slave
, i
) {
1302 (slave
->dev
->name
, buf
,
1303 strlen(slave
->dev
->name
)) == 0) {
1304 old_active
= bond
->curr_active_slave
;
1306 if (new_active
== old_active
) {
1308 printk(KERN_INFO DRV_NAME
1309 ": %s: %s is already the current active slave.\n",
1310 bond
->dev
->name
, slave
->dev
->name
);
1316 (new_active
->link
== BOND_LINK_UP
) &&
1317 IS_UP(new_active
->dev
)) {
1318 printk(KERN_INFO DRV_NAME
1319 ": %s: Setting %s as active slave.\n",
1320 bond
->dev
->name
, slave
->dev
->name
);
1321 bond_change_active_slave(bond
, new_active
);
1324 printk(KERN_INFO DRV_NAME
1325 ": %s: Could not set %s as active slave; "
1326 "either %s is down or the link is down.\n",
1327 bond
->dev
->name
, slave
->dev
->name
,
1335 /* if we got here, then we didn't match the name of any slave */
1337 if (strlen(buf
) == 0 || buf
[0] == '\n') {
1338 printk(KERN_INFO DRV_NAME
1339 ": %s: Setting active slave to None.\n",
1341 bond
->primary_slave
= NULL
;
1342 bond_select_active_slave(bond
);
1344 printk(KERN_INFO DRV_NAME
1345 ": %s: Unable to set %.*s as active slave as it is not a slave.\n",
1346 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
1350 write_unlock_bh(&bond
->curr_slave_lock
);
1351 read_unlock(&bond
->lock
);
1357 static DEVICE_ATTR(active_slave
, S_IRUGO
| S_IWUSR
, bonding_show_active_slave
, bonding_store_active_slave
);
1361 * Show link status of the bond interface.
1363 static ssize_t
bonding_show_mii_status(struct device
*d
,
1364 struct device_attribute
*attr
,
1368 struct bonding
*bond
= to_bond(d
);
1370 read_lock(&bond
->curr_slave_lock
);
1371 curr
= bond
->curr_active_slave
;
1372 read_unlock(&bond
->curr_slave_lock
);
1374 return sprintf(buf
, "%s\n", (curr
) ? "up" : "down");
1376 static DEVICE_ATTR(mii_status
, S_IRUGO
, bonding_show_mii_status
, NULL
);
1380 * Show current 802.3ad aggregator ID.
1382 static ssize_t
bonding_show_ad_aggregator(struct device
*d
,
1383 struct device_attribute
*attr
,
1387 struct bonding
*bond
= to_bond(d
);
1389 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1390 struct ad_info ad_info
;
1391 count
= sprintf(buf
, "%d\n", (bond_3ad_get_active_agg_info(bond
, &ad_info
)) ? 0 : ad_info
.aggregator_id
);
1396 static DEVICE_ATTR(ad_aggregator
, S_IRUGO
, bonding_show_ad_aggregator
, NULL
);
1400 * Show number of active 802.3ad ports.
1402 static ssize_t
bonding_show_ad_num_ports(struct device
*d
,
1403 struct device_attribute
*attr
,
1407 struct bonding
*bond
= to_bond(d
);
1409 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1410 struct ad_info ad_info
;
1411 count
= sprintf(buf
, "%d\n", (bond_3ad_get_active_agg_info(bond
, &ad_info
)) ? 0: ad_info
.ports
);
1416 static DEVICE_ATTR(ad_num_ports
, S_IRUGO
, bonding_show_ad_num_ports
, NULL
);
1420 * Show current 802.3ad actor key.
1422 static ssize_t
bonding_show_ad_actor_key(struct device
*d
,
1423 struct device_attribute
*attr
,
1427 struct bonding
*bond
= to_bond(d
);
1429 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1430 struct ad_info ad_info
;
1431 count
= sprintf(buf
, "%d\n", (bond_3ad_get_active_agg_info(bond
, &ad_info
)) ? 0 : ad_info
.actor_key
);
1436 static DEVICE_ATTR(ad_actor_key
, S_IRUGO
, bonding_show_ad_actor_key
, NULL
);
1440 * Show current 802.3ad partner key.
1442 static ssize_t
bonding_show_ad_partner_key(struct device
*d
,
1443 struct device_attribute
*attr
,
1447 struct bonding
*bond
= to_bond(d
);
1449 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1450 struct ad_info ad_info
;
1451 count
= sprintf(buf
, "%d\n", (bond_3ad_get_active_agg_info(bond
, &ad_info
)) ? 0 : ad_info
.partner_key
);
1456 static DEVICE_ATTR(ad_partner_key
, S_IRUGO
, bonding_show_ad_partner_key
, NULL
);
1460 * Show current 802.3ad partner mac.
1462 static ssize_t
bonding_show_ad_partner_mac(struct device
*d
,
1463 struct device_attribute
*attr
,
1467 struct bonding
*bond
= to_bond(d
);
1469 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1470 struct ad_info ad_info
;
1471 if (!bond_3ad_get_active_agg_info(bond
, &ad_info
)) {
1472 count
= sprintf(buf
, "%pM\n", ad_info
.partner_system
);
1478 static DEVICE_ATTR(ad_partner_mac
, S_IRUGO
, bonding_show_ad_partner_mac
, NULL
);
1482 static struct attribute
*per_bond_attrs
[] = {
1483 &dev_attr_slaves
.attr
,
1484 &dev_attr_mode
.attr
,
1485 &dev_attr_fail_over_mac
.attr
,
1486 &dev_attr_arp_validate
.attr
,
1487 &dev_attr_arp_interval
.attr
,
1488 &dev_attr_arp_ip_target
.attr
,
1489 &dev_attr_downdelay
.attr
,
1490 &dev_attr_updelay
.attr
,
1491 &dev_attr_lacp_rate
.attr
,
1492 &dev_attr_ad_select
.attr
,
1493 &dev_attr_xmit_hash_policy
.attr
,
1494 &dev_attr_num_grat_arp
.attr
,
1495 &dev_attr_num_unsol_na
.attr
,
1496 &dev_attr_miimon
.attr
,
1497 &dev_attr_primary
.attr
,
1498 &dev_attr_use_carrier
.attr
,
1499 &dev_attr_active_slave
.attr
,
1500 &dev_attr_mii_status
.attr
,
1501 &dev_attr_ad_aggregator
.attr
,
1502 &dev_attr_ad_num_ports
.attr
,
1503 &dev_attr_ad_actor_key
.attr
,
1504 &dev_attr_ad_partner_key
.attr
,
1505 &dev_attr_ad_partner_mac
.attr
,
1509 static struct attribute_group bonding_group
= {
1511 .attrs
= per_bond_attrs
,
1515 * Initialize sysfs. This sets up the bonding_masters file in
1518 int bond_create_sysfs(void)
1522 ret
= netdev_class_create_file(&class_attr_bonding_masters
);
1524 * Permit multiple loads of the module by ignoring failures to
1525 * create the bonding_masters sysfs file. Bonding devices
1526 * created by second or subsequent loads of the module will
1527 * not be listed in, or controllable by, bonding_masters, but
1528 * will have the usual "bonding" sysfs directory.
1530 * This is done to preserve backwards compatibility for
1531 * initscripts/sysconfig, which load bonding multiple times to
1532 * configure multiple bonding devices.
1534 if (ret
== -EEXIST
) {
1535 /* Is someone being kinky and naming a device bonding_master? */
1536 if (__dev_get_by_name(&init_net
,
1537 class_attr_bonding_masters
.attr
.name
))
1539 "network device named %s already exists in sysfs",
1540 class_attr_bonding_masters
.attr
.name
);
1549 * Remove /sys/class/net/bonding_masters.
1551 void bond_destroy_sysfs(void)
1553 netdev_class_remove_file(&class_attr_bonding_masters
);
1557 * Initialize sysfs for each bond. This sets up and registers
1558 * the 'bondctl' directory for each individual bond under /sys/class/net.
1560 int bond_create_sysfs_entry(struct bonding
*bond
)
1562 struct net_device
*dev
= bond
->dev
;
1565 err
= sysfs_create_group(&(dev
->dev
.kobj
), &bonding_group
);
1567 printk(KERN_EMERG
"eek! didn't create group!\n");
1570 if (expected_refcount
< 1)
1571 expected_refcount
= atomic_read(&bond
->dev
->dev
.kobj
.kref
.refcount
);
1576 * Remove sysfs entries for each bond.
1578 void bond_destroy_sysfs_entry(struct bonding
*bond
)
1580 struct net_device
*dev
= bond
->dev
;
1582 sysfs_remove_group(&(dev
->dev
.kobj
), &bonding_group
);