| blob | d12435992dea9d9910a007ec0bfd48e0230a26cd |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
58 Options:
63 --emacs emacs compile window format
64 --terse one line per report
78 is all off)
80 literally
83 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
84 with potential errors corrected to the preferred
85 checkpatch style
90 runtime errors.
94 EOM
97 }
119 }
120 }
123 }
125 GetOptions(
164 }
165 }
170 }
186 }
187 }
196 }
198 }
199 }
209 ## no critic
212 }
219 }
225 }
232 }
233 }
238 }
239 }
249 __user|
250 __kernel|
251 __force|
252 __iomem|
253 __must_check|
254 __init_refok|
255 __kprobes|
256 __ref|
257 __rcu
265 # Notes to $Attribute:
266 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
268 const|
269 __percpu|
270 __nocast|
271 __safe|
272 __bitwise__|
273 __packed__|
274 __packed2__|
275 __naked|
276 __maybe_unused|
277 __always_unused|
278 __noreturn|
279 __used|
280 __cold|
281 __pure|
282 __noclone|
283 __deprecated|
284 __read_mostly|
285 __kprobes|
287 ____cacheline_aligned|
288 ____cacheline_aligned_in_smp|
289 ____cacheline_internodealigned_in_smp|
290 __weak
312 <=|>=|==|!=|
313 =>|->|<<|>>|<|>|!|~|
345 )};
349 atomic_t
350 )};
354 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
356 panic|
359 )};
368 To:|
369 Cc:
370 )};
389 );
412 );
417 );
421 );
427 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
430 );
432 #Create a search pattern for all these functions to speed up a loop below
437 }
440 irq|
441 memory|
443 reboot
444 )};
445 # memory.h: ARM has a custom one
447 # Load common spelling mistakes and build regular expression list.
466 }
471 }
486 )
493 )
503 )
507 $NonptrType
512 $NonptrTypeMisordered
518 }
519 build_types();
523 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
524 # requires at least perl version v5.10.0
525 # Any use must be runtime checked with $^V
535 )};
544 }
549 }
573 }
574 }
575 }
599 }
601 }
609 }
613 }
618 }
622 }
630 }
632 }
633 }
647 # Maybe one day convert this block of bash into something that returns
648 # all matching commit ids, but it's very slow...
649 #
650 # echo "checking commits $1..."
651 # git rev-list --remotes | grep -i "^$1" |
652 # while read line ; do
653 # git log --format='%H %s' -1 $line |
654 # echo "commit $(cut -c 1-12,41-)"
655 # done
656 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
660 }
663 }
685 }
690 }
694 }
698 }
705 }
716 );
721 }
722 }
724 }
747 # If there's a name left after stripping spaces and
748 # leading quotes, and the address doesn't have both
749 # leading and trailing angle brackets, the address
750 # is invalid. ie:
751 # "joe smith joe@smith.com" bad
752 # "joe smith <joe@smith.com" bad
757 }
758 }
768 }
771 }
785 }
791 }
794 }
802 }
803 }
806 }
814 }
815 }
818 }
831 }
833 }
836 }
839 }
843 }
848 # Drop the diff line leader and expand tabs
852 # Pick the indent from the front of the line.
856 }
867 }
868 }
879 # Always copy over the diff marker.
885 # Comments we are wacking completly including the begin
886 # and end, all to $;.
893 }
899 }
906 }
908 # A \ in a string means ignore the next character.
914 }
915 # Regular quotes.
924 }
925 }
927 #print "c<$c> SQ<$sanitise_quote>\n";
936 }
937 }
941 }
943 # The pathname on a #include may be surrounded by '<' and '>'.
948 # The whole of a #error is a string.
952 }
955 }
962 }
985 #warn "CSB: blk<$blk> remain<$remain>\n";
986 # If we are about to drop off the end, pull in more
987 # context.
998 }
999 # Bail if there is no further context.
1000 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
1003 }
1007 }
1008 }
1013 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1015 # Handle nested #if/#else.
1022 }
1024 # Statement ends at the ';' or a close '}' at the
1025 # outermost level.
1028 }
1030 # An else is really a conditional as long as its not else if
1037 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1038 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1039 }
1044 }
1052 #warn "CSB: mark coff<$coff>\n";
1053 }
1054 }
1058 }
1066 }
1068 }
1069 }
1070 # Preprocessor commands end at the newline unless escaped.
1076 }
1078 }
1079 # We are truly at the end, so shuffle to the next line.
1084 }
1089 #warn "STATEMENT<$statement>\n";
1090 #warn "CONDITION<$condition>\n";
1092 #print "coff<$coff> soff<$off> loff<$loff>\n";
1096 }
1101 # Strip the diff line prefixes and rip blank lines at start and end.
1109 }
1117 }
1138 }
1139 }
1147 # Grab the first conditional/block pair.
1150 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1154 }
1156 # Pull in the following conditional/block pairs and see if they
1157 # could continue the statement.
1161 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1163 #print "C: push\n";
1165 }
1168 }
1187 # Handle nested #if/#else.
1194 }
1197 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1201 }
1208 }
1209 }
1213 }
1216 }
1219 }
1225 }
1231 }
1237 }
1242 }
1247 }
1252 # Catch a comment on the end of the line itself.
1256 # Look through the context and try and figure out if there is a
1257 # comment.
1262 #warn " $line\n";
1265 }
1268 }
1271 }
1275 }
1276 }
1280 }
1285 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1286 ##print "CMMT: $cmt\n";
1289 }
1302 }
1305 }
1317 }
1318 }
1322 }
1334 }
1354 }
1375 }
1404 # Assume all arms of the conditional end as this
1405 # one does, and continue as if the #endif was not here.
1422 }
1453 }
1465 }
1498 }
1513 }
1522 }
1526 }
1530 }
1531 }
1534 }
1543 DEFINE_\S+
1544 )$|
1548 case|
1552 \#|
1553 \#\#|
1559 # Check for modifiers.
1570 }
1571 }
1576 }
1577 build_types();
1580 }
1581 }
1591 }
1599 }
1605 }
1611 }
1615 }
1626 }
1627 }
1654 }
1660 }
1667 }
1672 }
1675 }
1678 }
1686 };
1688 }
1696 };
1699 }
1708 }
1710 }
1718 }
1720 }
1728 }
1730 }
1736 ##print "absolute<$absolute>\n";
1738 # See if any suffix of this path is a path within the tree.
1741 ##print "file<$file>\n";
1743 }
1744 }
1747 }
1749 # It is, so see if the prefix is acceptable.
1753 ##print "prefix<$prefix>\n";
1757 }
1758 }
1766 }
1774 }
1782 }
1790 }
1799 #convert leading spaces to tabs
1801 #Remove spaces before a tab
1805 }
1819 }
1831 }
1832 }
1835 }
1869 # Trace the real file/line as we go.
1881 # suppression flags
1889 # Pre-scan the patch sanitizing the lines.
1890 # Pre-scan the patch looking for any __setup documentation.
1891 #
1897 sanitise_line_reset();
1909 }
1910 #next;
1911 }
1918 }
1921 # Guestimate if this is a continuing comment. Run
1922 # the context looking for a comment "edge". If this
1923 # edge is a close comment then we must be in a comment
1924 # at context start.
1931 #print "RAW<$rawlines[$ln - 1]>\n";
1937 }
1938 }
1941 }
1943 # Guestimate if this is a continuing comment. If this
1944 # is the start of a diff block and this line starts
1945 # ' *' then it is very likely a comment.
1948 {
1950 }
1952 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1956 # Standardise the strings and chars within the input to
1957 # simplify matching -- only bother with positive lines.
1959 }
1966 }
1968 #print "==>$rawline\n";
1969 #print "-->$line\n";
1973 }
1974 }
1989 #extract the line range in the file after the patch is applied
1998 }
1999 annotate_reset();
2008 # track the line number as we move through the hunk, note that
2009 # new versions of GNU diff omit the leading space on completely
2010 # blank context lines so we need to count that too.
2015 # Measure the line length and indent.
2018 # Track the previous line.
2023 #warn "line<$line>\n";
2027 }
2031 #make up the handle for any error we report on this line
2039 # extract the filename as it passes
2055 }
2059 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2060 }
2062 }
2069 }
2071 }
2081 # Check for incorrect file permissions
2088 }
2089 }
2091 # Check the patch for a signoff:
2095 }
2097 # Check if MAINTAINERS is being updated. If so, there's probably no need to
2098 # emit the "does MAINTAINERS need updating?" message on file add/move/delete
2101 }
2103 # Check signature styles
2115 }
2122 }
2123 }
2130 }
2132 }
2139 }
2140 }
2151 # Don't force email to have quotes
2152 # Allow just an angle bracketed address
2158 }
2159 }
2161 # Check for duplicate signatures
2170 }
2171 }
2173 # Check email subject for common tools that don't need to be mentioned
2178 }
2180 # Check for old stable address
2184 }
2186 # Check for unwanted Gerrit info
2190 }
2192 # Check for git id commit length and improperly formed commit descriptions
2226 }
2233 "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herecurr);
2234 }
2235 }
2237 # Check for added, moved or deleted files
2246 }
2248 # Check for wrappage within a valid hunk of the file
2253 }
2255 # Check for absolute kernel paths.
2262 #
2265 }
2266 }
2267 }
2269 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2280 }
2282 # Check if it's the start of a commit log
2283 # (not a header line and we haven't seen the patch filename)
2289 }
2291 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2292 # declined it, i.e defined some charset where it is missing.
2297 }
2303 }
2305 # Check for various typo / spelling mistakes
2318 }
2319 }
2320 }
2322 # ignore non-hunk lines and lines being removed
2325 #trailing whitespace
2332 }
2339 }
2342 }
2344 # Check for FSF mailing addresses.
2352 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2353 }
2355 # check for Kconfig help text having a real description
2356 # Only applies when adding the entry originally, after that we do not have
2357 # sufficient context to determine whether it is indeed long enough.
2378 }
2387 }
2389 }
2393 }
2394 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2395 }
2397 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2401 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2402 }
2404 # discourage the use of boolean for type definition attributes of Kconfig options
2409 }
2419 };
2422 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2423 }
2425 # check for DT compatible documentation
2444 }
2451 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2452 }
2453 }
2454 }
2456 # check we are in a valid source file if not then ignore this hunk
2459 #line length limit
2462 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
2465 {
2468 }
2470 # check for adding lines without a newline.
2471 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2474 }
2476 # Blackfin: use hi/lo macros
2482 }
2487 }
2488 }
2490 # check we are in a valid source file C or perl if not then ignore this hunk
2493 # at the beginning of a line any tabs must come first and anything
2494 # more than 8 must use tabs.
2503 }
2504 }
2506 # check for space before tabs.
2516 }
2517 }
2519 # check for && or || at the start of a line
2523 }
2525 # check multi-line statement indentation matches previous line
2527 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2550 }
2551 }
2552 }
2553 }
2555 if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;:\?\(\{\}\[\<\>]|&&|\|\||\\$)/ &&
2562 }
2563 }
2571 }
2580 }
2589 }
2591 # check for missing blank lines after struct/union declarations
2592 # with exceptions for various attributes and macros
2607 }
2608 }
2610 # check for multiple consecutive blank lines
2618 }
2621 }
2623 # check for missing blank lines after declarations
2625 # actual declarations
2627 # function pointer declarations
2629 # foo bar; where foo is some local typedef or #define
2631 # known declaration macros
2633 # for "else if" which can look like "$Ident $Ident"
2635 # other possible extensions of declaration lines
2637 # not starting a section or a macro "\" extended line
2639 # looks like a declaration
2641 # function pointer declarations
2643 # foo bar; where foo is some local typedef or #define
2645 # known declaration macros
2647 # start of struct or union or enum
2649 # start or end of block or continuation of declaration
2651 # bitfield continuation
2653 # other possible extensions of declaration lines
2655 # indentation of previous and current line are the same
2661 }
2662 }
2664 # check for spaces at the beginning of a line.
2665 # Exceptions:
2666 # 1) within comments
2667 # 2) indented preprocessor commands
2668 # 3) hanging labels
2675 }
2676 }
2678 # check we are in a valid C source file if not then ignore this hunk
2681 # check indentation of any line with a bare else
2682 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
2683 # if the previous line is a break or return and is indented 1 tab more...
2692 }
2693 }
2695 # check indentation of a line with a break;
2696 # if the previous line is a goto or return and is indented the same # of tabs
2702 }
2703 }
2705 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2708 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2709 }
2711 # check for RCS/CVS revision markers
2715 }
2717 # Blackfin: don't use __builtin_bfin_[cs]sync
2722 }
2727 }
2729 # check for old HOTPLUG __dev<foo> section markings
2733 }
2735 # Check for potential 'bare' types
2738 #print "LINE<$line>\n";
2746 #print "linenr<$linenr> <$stat>\n";
2747 # If this statement has no statement boundaries within
2748 # it there is no point in retrying a statement scan
2749 # until we hit end of it.
2752 #print "skip<$line_nr_next>\n";
2754 }
2756 # Find the real next line.
2762 }
2767 # Ignore goto labels.
2770 # Ignore functions being called
2775 # declarations always start with types
2776 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2781 # definitions in global scope can only start with types
2784 }
2786 # any (foo ... *) is a pointer cast, and foo is a type
2789 }
2791 # Check for any sort of function declaration.
2792 # int foo(something bar, other baz);
2793 # void (*store_gdt)(x86_descr_ptr *);
2794 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2802 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2805 }
2806 }
2807 }
2809 }
2811 #
2812 # Checks which may be anchored in the context.
2813 #
2815 # Check for switch () and associated case and default
2816 # statements should be at the same indent.
2830 }
2831 }
2835 }
2836 }
2838 # if/while/etc brace do not go on next line, unless defining a do while loop,
2839 # or if that brace on the next line is for something else
2840 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2848 }
2859 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2862 }
2864 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2865 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2871 }
2875 {
2881 }
2882 }
2883 }
2885 # Check relative indent for conditionals and blocks.
2886 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2894 # Make sure we remove the line prefixes as we have
2895 # none on the first line, and are going to readd them
2896 # where necessary.
2899 # Find out how long the conditional actually is.
2903 # We want to check the first line inside the block
2904 # starting at the end of the conditional, so remove:
2905 # 1) any blank line termination
2906 # 2) any opening brace { on end of the line
2907 # 3) any do (...) {
2914 }
2918 }
2920 # Also ignore a loop construct at the end of a
2921 # preprocessor statement.
2925 }
2932 # If we see an #else/#elif then the code
2933 # is not linear.
2936 }
2938 # Ignore:
2939 # 1) blank lines, they should be at 0,
2940 # 2) preprocessor lines, and
2941 # 3) labels.
2949 }
2950 }
2951 }
2956 # Check if either of these lines are modified, else
2957 # this is not this patch's fault.
2961 }
2964 }
2966 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2971 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2972 }
2973 }
2975 # Track the 'values' across context and added lines.
2985 }
2988 #ignore lines not being added
2991 # TEST: allow direct testing of the type matcher.
2999 }
3001 }
3002 # TEST: allow direct testing of the attribute matcher.
3010 }
3012 }
3014 # check for initialisation to aggregates open brace on the next line
3028 }
3029 }
3031 #
3032 # Checks which are anchored on the added line.
3033 #
3035 # check for malformed paths in #include statements (uses RAW line)
3041 }
3045 }
3046 }
3048 # no C99 // comments
3057 }
3058 }
3059 }
3060 # Remove C99 comments.
3064 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
3065 # the whole statement.
3066 #print "APW <$lines[$realline_next - 1]>\n";
3072 # Handle definitions which produce identifiers with
3073 # a prefix:
3074 # XXX(foo);
3075 # EXPORT_SYMBOL(something_foo);
3079 #print "FOO C name<$name>\n";
3090 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
3094 }
3095 }
3100 #print "FOO B <$lines[$linenr - 1]>\n";
3102 }
3107 }
3109 # check for global initialisers.
3116 }
3117 }
3118 # check for static initialisers.
3125 }
3126 }
3128 # check for misordered declarations of char/short/int/long with signed/unsigned
3132 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
3133 }
3135 # check for static const char * arrays.
3140 }
3142 # check for static char foo[] = "bar" declarations.
3147 }
3149 # check for non-global char *foo[] = {"bar", ...} declarations.
3154 }
3156 # check for function declarations without arguments like "int foo()"
3162 }
3163 }
3165 # check for uses of DEFINE_PCI_DEVICE_TABLE
3170 $fixed[$fixlinenr] =~ s/\b(?:static\s+|)DEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=\s*/static const struct pci_device_id $1\[\] = /;
3171 }
3172 }
3174 # check for new typedefs, only function parameters and sparse annotations
3175 # make sense.
3184 }
3186 # * goes on variable not on type
3187 # (char*[ const])
3189 #print "AA<$1>\n";
3192 # Should start with a space.
3194 # Should not end with a space.
3196 # '*'s should not have spaces between.
3198 }
3200 ## print "1: from<$from> to<$to> ident<$ident>\n";
3210 }
3211 }
3212 }
3214 #print "BB<$1>\n";
3217 # Should start with a space.
3219 # Should not end with a space.
3221 # '*'s should not have spaces between.
3223 }
3224 # Modifiers should have spaces.
3227 ## print "2: from<$from> to<$to> ident<$ident>\n";
3238 }
3239 }
3240 }
3242 # # no BUG() or BUG_ON()
3243 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
3244 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
3245 # print "$herecurr";
3246 # $clean = 0;
3247 # }
3251 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
3252 }
3254 # check for uses of printk_ratelimit
3258 }
3260 # printk should use KERN_* levels. Note that follow on printk's on the
3261 # same line do not need a level, so we use the current block context
3262 # to try and find and validate the current printk. In summary the current
3263 # printk includes all preceding printk's which have no newline on the end.
3264 # we assume the first bad printk is the one to report.
3268 #print "CHECK<$lines[$ln - 1]\n";
3269 # we have a preceding printk if it ends
3270 # with "\n" ignore it, else it is to blame
3274 }
3276 }
3277 }
3281 }
3282 }
3291 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
3292 }
3300 }
3301 }
3310 }
3312 # function brace can't be on same line, except for #defines of do while,
3313 # or if closed on same line
3328 }
3329 }
3330 }
3332 # open braces for enum, union and struct go on the same line.
3346 }
3347 }
3348 }
3350 # missing space after union, struct or enum definition
3357 }
3358 }
3360 # Function pointer declarations
3361 # check spacing between type, funcptr, and args
3362 # canonical declaration is "type (*funcptr)(args...)"
3371 # the $Declare variable will capture all spaces after the type
3372 # so check it for a missing trailing missing space but pointer return types
3373 # don't need a space so don't warn for those.
3378 }
3383 }
3385 # unnecessary space "type (*funcptr)(args...)"
3386 # This test is not currently implemented because these declarations are
3387 # equivalent to
3388 # int foo(int bar, ...)
3389 # and this is form shouldn't/doesn't generate a checkpatch warning.
3390 #
3391 # elsif ($declare =~ /\s{2,}$/) {
3392 # WARN("SPACING",
3393 # "Multiple spaces after return type\n" . $herecurr);
3394 # }
3396 # unnecessary space "type ( *funcptr)(args...)"
3401 }
3403 # unnecessary space "type (* funcptr)(args...)"
3408 }
3410 # unnecessary space "type (*funcptr )(args...)"
3415 }
3417 # unnecessary space "type (*funcptr) (args...)"
3422 }
3426 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3427 }
3428 }
3430 # check for spacing round square brackets; allowed:
3431 # 1. with a type on the left -- int [] a;
3432 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3433 # 3. inside a curly brace -- = { [0...10] = 5 }
3444 }
3445 }
3446 }
3448 # check for spaces between functions and their parentheses.
3454 # Ignore those directives where spaces _are_ permitted.
3460 {
3461 # cpp #define statements have non-optional spaces, ie
3462 # if there is a space between the name and the open
3463 # parenthesis it is simply not a parameter group.
3466 # cpp #elif statement condition may start with a (
3469 # If this whole things ends with a type its most
3470 # likely a typedef for a function.
3479 }
3480 }
3481 }
3483 # Check operator spacing.
3489 <<=|>>=|<=|>=|==|!=|
3491 =>|->|<<|>>|<|>|=|!|~|
3497 ## print("element count: <" . $#elements . ">\n");
3498 ## foreach my $el (@elements) {
3499 ## print("el: <$el>\n");
3500 ## }
3508 }
3519 ## print("n: <$n> good: <$good>\n");
3523 # Pick up the preceding and succeeding characters.
3528 }
3551 }
3560 # Pull out the value of this operator.
3563 # Get the full operator variant.
3566 # Ignore operators passed as parameters.
3570 # # Ignore comments
3571 # } elsif ($op =~ /^$;+$/) {
3573 # ; should have either the end of line or a space or \ after it
3581 }
3582 }
3584 # // is a comment
3587 # : when part of a bitfield
3589 # skip the bitfield test for now
3591 # No spaces for:
3592 # ->
3600 }
3602 }
3603 }
3605 # , must not have a space before and must have a space on the right.
3614 }
3615 }
3622 }
3623 }
3629 }
3632 }
3633 }
3635 # '*' as part of a type definition -- reported already.
3637 #warn "'*' is part of type\n";
3639 # unary operators should have a space before and
3640 # none after. May be left adjacent to another
3641 # unary operator, or a cast
3651 }
3652 }
3653 }
3655 # A unary '*' may be const
3663 }
3665 }
3666 }
3668 # unary ++ and unary -- are allowed no space on one side.
3675 }
3676 }
3683 }
3684 }
3691 }
3693 }
3694 }
3696 # << and >> may either have or not have spaces both sides
3702 {
3710 }
3716 }
3717 }
3724 }
3726 }
3727 }
3729 # A colon needs no spaces before when it is
3730 # terminating a case value or a label.
3737 }
3738 }
3740 # All the others need spaces both sides.
3744 # Ignore email addresses <foo@bar>
3749 {
3751 }
3753 # messages are ERROR, but ?: are CHK
3763 }
3765 }
3766 }
3767 }
3770 ## print("n: <$n> GOOD: <$good>\n");
3773 }
3777 }
3781 }
3784 }
3786 # check for whitespace before a non-naked semicolon
3793 }
3794 }
3796 # check for multiple assignments
3800 }
3802 ## # check for multiple declarations, allowing for a function declaration
3803 ## # continuation.
3804 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
3805 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
3806 ##
3807 ## # Remove any bracketed sections to ensure we do not
3808 ## # falsly report the parameters of functions.
3809 ## my $ln = $line;
3810 ## while ($ln =~ s/\([^\(\)]*\)//g) {
3811 ## }
3812 ## if ($ln =~ /,/) {
3813 ## WARN("MULTIPLE_DECLARATION",
3814 ## "declaring multiple variables together should be avoided\n" . $herecurr);
3815 ## }
3816 ## }
3818 #need space before brace following if, while, etc
3825 }
3826 }
3828 ## # check for blank lines before declarations
3829 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
3830 ## $prevrawline =~ /^.\s*$/) {
3831 ## WARN("SPACING",
3832 ## "No blank lines before declarations\n" . $hereprev);
3833 ## }
3834 ##
3836 # closing brace should have a space following it when it has anything
3837 # on the line
3844 }
3845 }
3847 # check spacing on square brackets
3854 }
3855 }
3862 }
3863 }
3865 # check spacing on parentheses
3873 }
3874 }
3883 }
3884 }
3886 # check unnecessary parentheses around addressof/dereference single $Lvals
3887 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
3895 }
3896 }
3898 # check for unnecessary parentheses around function pointer uses
3899 # ie: (foo->bar)(); should be foo->bar();
3900 # but not "if (foo->bar) (" to avoid some false positives
3909 }
3910 }
3912 #goto labels aren't indented, allow a single space however
3920 }
3921 }
3923 # return is not a function
3933 }
3937 }
3938 }
3940 # unnecessary return in a void function
3941 # at end-of-function, with the previous line a single leading tab, then return;
3942 # and the line before that not a goto label target like "out:"
3950 }
3952 # if statements using unnecessary parentheses - ie: if ((foo == bar))
3958 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
3963 }
3964 }
3966 # Return of what appears to be an errno should normally be -'ve
3972 }
3973 }
3975 # Need a space before open parenthesis after if, while etc
3982 }
3983 }
3985 # Check for illegal assignment in if conditional -- and check for trailing
3986 # statements after the conditional.
3994 ##print "stat<$stat> stat_next<$stat_next>\n";
3997 # If the statement carries leading newlines,
3998 # then count those as offsets.
4006 }
4007 }
4016 }
4018 # Find out what is on the end of the line after the
4019 # conditional.
4025 {
4026 # Find out how long the conditional actually is.
4035 }
4039 }
4040 }
4042 # Check for bitwise tests written as boolean
4048 |
4053 {
4056 }
4058 # if and else should not have general statements after it
4065 }
4066 }
4067 # if should not continue a brace
4072 }
4073 # case and default should not have general statements after them
4079 {
4082 }
4084 # Check for }<nl>else {, these must be at the same
4085 # indent level to be relevant to each other.
4097 }
4101 }
4102 }
4108 # Find out what is on the end of the line after the
4109 # conditional.
4125 }
4126 }
4127 }
4129 #Specific variable tests
4133 #gcc binary extension
4141 }
4142 }
4144 #CamelCase
4147 #Ignore Page<foo> variants
4149 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
4151 #Ignore some three character SI units explicitly, like MiB and KHz
4157 seed_camelcase_includes();
4161 }
4162 }
4167 }
4168 }
4169 }
4170 }
4172 #no spaces allowed after \ in define
4178 }
4179 }
4181 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
4188 {
4195 }
4196 }
4197 }
4199 # multi-statement macros should be enclosed in a do while loop, grab the
4200 # first statement and ensure its the whole macro if its not enclosed
4201 # in a known good container
4213 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
4214 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
4225 # Flatten any parentheses and braces
4229 {
4230 }
4232 # Flatten any obvious string concatentation.
4235 {
4236 }
4240 module_param_named|
4241 MODULE_PARM_DESC|
4242 DECLARE_PER_CPU|
4243 DEFINE_PER_CPU|
4244 __typeof__\(|
4245 union|
4246 struct|
4250 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
4254 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
4259 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
4265 {
4272 }
4280 }
4281 }
4283 # check for macros with flow control, but without ## concatenation
4284 # ## concatenation is commonly a macro that defines a function so ignore those
4291 }
4294 }
4296 # check for line continuations outside of #defines, preprocessor #, and asm
4305 }
4306 }
4308 # do {} while (0) macro tests:
4309 # single-statement macros do not need to be enclosed in do while (0) loop,
4310 # macro should not end with a semicolon
4325 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
4335 }
4341 }
4345 }
4353 }
4357 }
4358 }
4360 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
4361 # all assignments may have only one of the following with an assignment:
4362 # .
4363 # ALIGN(...)
4364 # VMLINUX_SYMBOL(...)
4368 }
4370 # check for redundant bracing round if etc
4374 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
4375 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
4385 # If the condition carries leading newlines, then count those as offsets.
4390 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
4392 # We have looked at and allowed this specific line.
4402 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
4404 #print "APW: ALLOWED: cond<$cond>\n";
4406 }
4408 #print "APW: ALLOWED: block<$block>\n";
4410 }
4412 #print "APW: ALLOWED: lines block<$block>\n";
4414 }
4416 }
4421 }
4429 }
4430 }
4431 }
4432 }
4437 # Check the pre-context.
4439 #print "APW: ALLOWED: pre<$1>\n";
4441 }
4446 # Check the condition.
4448 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
4451 }
4453 #print "APW: ALLOWED: cond<$cond>\n";
4455 }
4457 #print "APW: ALLOWED: block<$block>\n";
4459 }
4461 #print "APW: ALLOWED: lines block<$block>\n";
4463 }
4464 # Check the post-context.
4469 }
4471 #print "APW: ALLOWED: chunk-1 block<$block>\n";
4473 }
4474 }
4481 }
4485 }
4486 }
4488 # check for unnecessary blank lines around braces
4494 }
4495 }
4501 }
4502 }
4504 # no volatiles please
4508 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
4509 }
4511 # Check for user-visible strings broken across lines, which breaks the ability
4512 # to grep for the string. Make exceptions when the previous string ends in a
4513 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
4514 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
4527 }
4539 }
4541 }
4542 }
4544 # check for missing a space in a string concatenation
4548 }
4550 # check for spaces before a quoted newline
4556 }
4558 }
4560 # concatenated string without spaces between elements
4564 }
4566 # uncoalesced string fragments
4570 }
4572 # check for %L{u,d,i} in strings
4581 }
4582 }
4584 # check for line continuations in quoted strings with odd counts of "
4588 }
4590 # warn about #if 0
4595 }
4597 # check for needless "if (<foo>) fn(<foo>)" uses
4603 }
4604 }
4606 # check for unnecessary "Out of Memory" messages
4615 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
4617 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
4620 }
4621 }
4623 # check for logging functions with KERN_<LEVEL>
4631 }
4632 }
4634 # check for mask then right shift without a parentheses
4640 }
4642 # check for pointer comparisons to NULL
4652 }
4653 }
4654 }
4656 # check for bad placement of section $InitAttribute (e.g.: __initdata)
4659 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
4669 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
4670 }
4671 }
4672 }
4674 # check for $InitAttributeData (ie: __initdata) with const
4685 }
4686 }
4688 # check for $InitAttributeConst (ie: __initconst) without const
4700 }
4701 }
4703 # don't use __constant_<foo> functions outside of include/uapi/
4705 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
4713 }
4714 }
4716 # prefer usleep_range over udelay
4719 # ignore udelay's < 10, however
4722 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4723 }
4727 }
4728 }
4730 # warn about unexpectedly long msleep's
4734 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4735 }
4736 }
4738 # check for comparisons of jiffies
4741 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
4742 }
4744 # check for comparisons of get_jiffies_64()
4747 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
4748 }
4750 # warn about #ifdefs in C files
4751 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
4752 # print "#ifdef in C files should be avoided\n";
4753 # print "$herecurr";
4754 # $clean = 0;
4755 # }
4757 # warn about spacing in #ifdefs
4764 }
4766 }
4768 # check for spinlock_t definitions without a comment.
4775 }
4776 }
4777 # check for memory barriers without a comment.
4778 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
4782 }
4783 }
4784 # check of hardware specific defines
4785 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
4788 }
4790 # Check that the storage class is at the beginning of a declaration
4794 }
4796 # check the location of the inline attribute, that it is between
4797 # storage class and type.
4802 }
4804 # Check for __inline__ and __inline, prefer inline
4812 }
4813 }
4815 # Check for __attribute__ packed, prefer __packed
4820 }
4822 # Check for __attribute__ aligned, prefer __aligned
4827 }
4829 # Check for __attribute__ format(printf, prefer __printf
4833 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
4835 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
4837 }
4838 }
4840 # Check for __attribute__ format(scanf, prefer __scanf
4844 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
4846 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
4847 }
4848 }
4850 # Check for __attribute__ weak, or __weak declarations (may have link issues)
4852 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
4857 }
4859 # check for sizeof(&)
4863 }
4865 # check for sizeof without parenthesis
4870 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
4871 }
4872 }
4874 # check for struct spinlock declarations
4878 }
4880 # check for seq_printf uses that could be seq_puts
4889 }
4890 }
4891 }
4893 # Check for misused memsets
4908 }
4909 }
4911 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
4915 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . $herecurr) &&
4917 $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
4918 }
4919 }
4921 # typecasts on min/max could be min_t/max_t
4939 }
4942 }
4943 }
4945 # check usleep_range arguments
4953 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4957 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4958 }
4959 }
4961 # check for naked sscanf
4973 }
4976 }
4978 # check for simple sscanf that should be kstrto<foo>
4987 }
4995 }
4996 }
4997 }
4999 # check for new externs in .h files.
5006 }
5007 }
5009 # check for new externs in .c files.
5012 {
5019 }
5022 {
5025 }
5030 }
5034 {
5037 }
5039 # checks for new __setup's
5046 }
5047 }
5049 # check for pointless casting of kmalloc return
5052 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
5053 }
5055 # alloc style
5056 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
5058 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
5061 }
5063 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
5065 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
5076 }
5082 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
5084 }
5085 }
5086 }
5088 # check for krealloc arg reuse
5093 }
5095 # check for alloc argument mismatch
5099 }
5101 # check for multiple semicolons
5107 }
5108 }
5110 # check for #defines like: 1 << <digit> that could be BIT(digit)
5118 }
5119 }
5121 # check for case / default statements not preceded by break/fallthrough/switch
5139 }
5143 }
5144 }
5146 # check for switch/default statements without a break;
5155 }
5158 }
5160 # check for gcc specific __FUNCTION__
5166 }
5167 }
5169 # check for uses of __DATE__, __TIME__, __TIMESTAMP__
5173 }
5175 # check for use of yield()
5179 }
5181 # check for comparisons against true and false
5197 }
5202 ## maybe suggesting a correct construct would better
5203 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
5205 }
5206 }
5208 # check for semaphores initialized locked
5212 }
5214 # recommend kstrto* over simple_strto* and strict_strto*
5218 }
5220 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
5223 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
5224 }
5226 # check for various structs that are normally const (ops, kgdb, device_tree)
5228 acpi_dock_ops|
5229 address_space_operations|
5230 backlight_ops|
5231 block_device_operations|
5232 dentry_operations|
5233 dev_pm_ops|
5234 dma_map_ops|
5235 extent_io_ops|
5236 file_lock_operations|
5237 file_operations|
5238 hv_ops|
5239 ide_dma_ops|
5240 intel_dvo_dev_ops|
5241 item_operations|
5242 iwl_ops|
5243 kgdb_arch|
5244 kgdb_io|
5245 kset_uevent_ops|
5246 lock_manager_operations|
5247 microcode_ops|
5248 mtrr_ops|
5249 neigh_ops|
5250 nlmsvc_binding|
5251 of_device_id|
5252 pci_raw_ops|
5253 pipe_buf_operations|
5254 platform_hibernation_ops|
5255 platform_suspend_ops|
5256 proto_ops|
5257 rpc_pipe_ops|
5258 seq_operations|
5259 snd_ac97_build_ops|
5260 soc_pcmcia_socket_ops|
5261 stacktrace_ops|
5262 sysfs_ops|
5263 tty_operations|
5264 usb_mon_operations|
5271 }
5273 # use of NR_CPUS is usually wrong
5274 # ignore definitions of NR_CPUS and usage to define arrays as likely right
5281 {
5283 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
5284 }
5286 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
5290 }
5292 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
5297 }
5299 # whine mightly about in_atomic
5307 }
5308 }
5310 # check for lockdep_set_novalidate_class
5318 }
5319 }
5324 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5325 }
5327 # Mode permission misuses where it seems decimal should be octal
5328 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
5339 }
5352 "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5353 }
5354 }
5355 }
5356 }
5357 }
5359 # If we have no input at all, then there is nothing to report on
5360 # so just keep quiet.
5363 }
5365 # In mailback mode only produce a report in the negative, for
5366 # things that appear to be patches.
5369 }
5371 # This is not a patch, and we are are in 'no-patch' mode so
5372 # just keep quiet.
5375 }
5380 }
5384 }
5393 }
5400 }
5402 # If there were whitespace errors which cleanpatch can fix
5403 # then suggest that.
5408 }
5409 }
5432 }
5435 }
5436 }
5443 Do _NOT_ trust the results written to this file.
5446 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
5449 EOM
5450 }
5451 }
5455 }
5460 If any of these errors are false positives, please report
5462 EOM
5463 }
5466 }