1 // SPDX-License-Identifier: GPL-2.0
3 * Greybus manifest parsing
5 * Copyright 2014-2015 Google Inc.
6 * Copyright 2014-2015 Linaro Ltd.
11 static const char *get_descriptor_type_string(u8 type
)
14 case GREYBUS_TYPE_INVALID
:
16 case GREYBUS_TYPE_STRING
:
18 case GREYBUS_TYPE_INTERFACE
:
20 case GREYBUS_TYPE_CPORT
:
22 case GREYBUS_TYPE_BUNDLE
:
31 * We scan the manifest once to identify where all the descriptors
32 * are. The result is a list of these manifest_desc structures. We
33 * then pick through them for what we're looking for (starting with
34 * the interface descriptor). As each is processed we remove it from
35 * the list. When we're done the list should (probably) be empty.
37 struct manifest_desc
{
38 struct list_head links
;
42 enum greybus_descriptor_type type
;
45 static void release_manifest_descriptor(struct manifest_desc
*descriptor
)
47 list_del(&descriptor
->links
);
51 static void release_manifest_descriptors(struct gb_interface
*intf
)
53 struct manifest_desc
*descriptor
;
54 struct manifest_desc
*next
;
56 list_for_each_entry_safe(descriptor
, next
, &intf
->manifest_descs
, links
)
57 release_manifest_descriptor(descriptor
);
60 static void release_cport_descriptors(struct list_head
*head
, u8 bundle_id
)
62 struct manifest_desc
*desc
, *tmp
;
63 struct greybus_descriptor_cport
*desc_cport
;
65 list_for_each_entry_safe(desc
, tmp
, head
, links
) {
66 desc_cport
= desc
->data
;
68 if (desc
->type
!= GREYBUS_TYPE_CPORT
)
71 if (desc_cport
->bundle
== bundle_id
)
72 release_manifest_descriptor(desc
);
76 static struct manifest_desc
*get_next_bundle_desc(struct gb_interface
*intf
)
78 struct manifest_desc
*descriptor
;
79 struct manifest_desc
*next
;
81 list_for_each_entry_safe(descriptor
, next
, &intf
->manifest_descs
, links
)
82 if (descriptor
->type
== GREYBUS_TYPE_BUNDLE
)
89 * Validate the given descriptor. Its reported size must fit within
90 * the number of bytes remaining, and it must have a recognized
91 * type. Check that the reported size is at least as big as what
92 * we expect to see. (It could be bigger, perhaps for a new version
95 * Returns the (non-zero) number of bytes consumed by the descriptor,
96 * or a negative errno.
98 static int identify_descriptor(struct gb_interface
*intf
,
99 struct greybus_descriptor
*desc
, size_t size
)
101 struct greybus_descriptor_header
*desc_header
= &desc
->header
;
102 struct manifest_desc
*descriptor
;
104 size_t expected_size
;
106 if (size
< sizeof(*desc_header
)) {
107 dev_err(&intf
->dev
, "manifest too small (%zu < %zu)\n",
108 size
, sizeof(*desc_header
));
109 return -EINVAL
; /* Must at least have header */
112 desc_size
= le16_to_cpu(desc_header
->size
);
113 if (desc_size
> size
) {
114 dev_err(&intf
->dev
, "descriptor too big (%zu > %zu)\n",
119 /* Descriptor needs to at least have a header */
120 expected_size
= sizeof(*desc_header
);
122 switch (desc_header
->type
) {
123 case GREYBUS_TYPE_STRING
:
124 expected_size
+= sizeof(struct greybus_descriptor_string
);
125 expected_size
+= desc
->string
.length
;
127 /* String descriptors are padded to 4 byte boundaries */
128 expected_size
= ALIGN(expected_size
, 4);
130 case GREYBUS_TYPE_INTERFACE
:
131 expected_size
+= sizeof(struct greybus_descriptor_interface
);
133 case GREYBUS_TYPE_BUNDLE
:
134 expected_size
+= sizeof(struct greybus_descriptor_bundle
);
136 case GREYBUS_TYPE_CPORT
:
137 expected_size
+= sizeof(struct greybus_descriptor_cport
);
139 case GREYBUS_TYPE_INVALID
:
141 dev_err(&intf
->dev
, "invalid descriptor type (%u)\n",
146 if (desc_size
< expected_size
) {
147 dev_err(&intf
->dev
, "%s descriptor too small (%zu < %zu)\n",
148 get_descriptor_type_string(desc_header
->type
),
149 desc_size
, expected_size
);
153 /* Descriptor bigger than what we expect */
154 if (desc_size
> expected_size
) {
155 dev_warn(&intf
->dev
, "%s descriptor size mismatch (want %zu got %zu)\n",
156 get_descriptor_type_string(desc_header
->type
),
157 expected_size
, desc_size
);
160 descriptor
= kzalloc(sizeof(*descriptor
), GFP_KERNEL
);
164 descriptor
->size
= desc_size
;
165 descriptor
->data
= (char *)desc
+ sizeof(*desc_header
);
166 descriptor
->type
= desc_header
->type
;
167 list_add_tail(&descriptor
->links
, &intf
->manifest_descs
);
169 /* desc_size is positive and is known to fit in a signed int */
175 * Find the string descriptor having the given id, validate it, and
176 * allocate a duplicate copy of it. The duplicate has an extra byte
177 * which guarantees the returned string is NUL-terminated.
179 * String index 0 is valid (it represents "no string"), and for
180 * that a null pointer is returned.
182 * Otherwise returns a pointer to a newly-allocated copy of the
183 * descriptor string, or an error-coded pointer on failure.
185 static char *gb_string_get(struct gb_interface
*intf
, u8 string_id
)
187 struct greybus_descriptor_string
*desc_string
;
188 struct manifest_desc
*descriptor
;
192 /* A zero string id means no string (but no error) */
196 list_for_each_entry(descriptor
, &intf
->manifest_descs
, links
) {
197 if (descriptor
->type
!= GREYBUS_TYPE_STRING
)
200 desc_string
= descriptor
->data
;
201 if (desc_string
->id
== string_id
) {
207 return ERR_PTR(-ENOENT
);
209 /* Allocate an extra byte so we can guarantee it's NUL-terminated */
210 string
= kmemdup(&desc_string
->string
, desc_string
->length
+ 1,
213 return ERR_PTR(-ENOMEM
);
214 string
[desc_string
->length
] = '\0';
216 /* Ok we've used this string, so we're done with it */
217 release_manifest_descriptor(descriptor
);
223 * Find cport descriptors in the manifest associated with the given
224 * bundle, and set up data structures for the functions that use
225 * them. Returns the number of cports set up for the bundle, or 0
226 * if there is an error.
228 static u32
gb_manifest_parse_cports(struct gb_bundle
*bundle
)
230 struct gb_interface
*intf
= bundle
->intf
;
231 struct greybus_descriptor_cport
*desc_cport
;
232 struct manifest_desc
*desc
, *next
, *tmp
;
234 u8 bundle_id
= bundle
->id
;
239 /* Set up all cport descriptors associated with this bundle */
240 list_for_each_entry_safe(desc
, next
, &intf
->manifest_descs
, links
) {
241 if (desc
->type
!= GREYBUS_TYPE_CPORT
)
244 desc_cport
= desc
->data
;
245 if (desc_cport
->bundle
!= bundle_id
)
248 cport_id
= le16_to_cpu(desc_cport
->id
);
249 if (cport_id
> CPORT_ID_MAX
)
252 /* Nothing else should have its cport_id as control cport id */
253 if (cport_id
== GB_CONTROL_CPORT_ID
) {
254 dev_err(&bundle
->dev
, "invalid cport id found (%02u)\n",
260 * Found one, move it to our temporary list after checking for
263 list_for_each_entry(tmp
, &list
, links
) {
264 desc_cport
= tmp
->data
;
265 if (cport_id
== le16_to_cpu(desc_cport
->id
)) {
266 dev_err(&bundle
->dev
,
267 "duplicate CPort %u found\n",
272 list_move_tail(&desc
->links
, &list
);
279 bundle
->cport_desc
= kcalloc(count
, sizeof(*bundle
->cport_desc
),
281 if (!bundle
->cport_desc
)
284 bundle
->num_cports
= count
;
287 list_for_each_entry_safe(desc
, next
, &list
, links
) {
288 desc_cport
= desc
->data
;
289 memcpy(&bundle
->cport_desc
[i
++], desc_cport
,
290 sizeof(*desc_cport
));
292 /* Release the cport descriptor */
293 release_manifest_descriptor(desc
);
298 release_cport_descriptors(&list
, bundle_id
);
300 * Free all cports for this bundle to avoid 'excess descriptors'
303 release_cport_descriptors(&intf
->manifest_descs
, bundle_id
);
305 return 0; /* Error; count should also be 0 */
309 * Find bundle descriptors in the manifest and set up their data
310 * structures. Returns the number of bundles set up for the
313 static u32
gb_manifest_parse_bundles(struct gb_interface
*intf
)
315 struct manifest_desc
*desc
;
316 struct gb_bundle
*bundle
;
317 struct gb_bundle
*bundle_next
;
322 while ((desc
= get_next_bundle_desc(intf
))) {
323 struct greybus_descriptor_bundle
*desc_bundle
;
325 /* Found one. Set up its bundle structure*/
326 desc_bundle
= desc
->data
;
327 bundle_id
= desc_bundle
->id
;
328 class = desc_bundle
->class;
330 /* Done with this bundle descriptor */
331 release_manifest_descriptor(desc
);
333 /* Ignore any legacy control bundles */
334 if (bundle_id
== GB_CONTROL_BUNDLE_ID
) {
335 dev_dbg(&intf
->dev
, "%s - ignoring control bundle\n",
337 release_cport_descriptors(&intf
->manifest_descs
,
342 /* Nothing else should have its class set to control class */
343 if (class == GREYBUS_CLASS_CONTROL
) {
345 "bundle %u cannot use control class\n",
350 bundle
= gb_bundle_create(intf
, bundle_id
, class);
355 * Now go set up this bundle's functions and cports.
357 * A 'bundle' represents a device in greybus. It may require
358 * multiple cports for its functioning. If we fail to setup any
359 * cport of a bundle, we better reject the complete bundle as
360 * the device may not be able to function properly then.
362 * But, failing to setup a cport of bundle X doesn't mean that
363 * the device corresponding to bundle Y will not work properly.
364 * Bundles should be treated as separate independent devices.
366 * While parsing manifest for an interface, treat bundles as
367 * separate entities and don't reject entire interface and its
368 * bundles on failing to initialize a cport. But make sure the
369 * bundle which needs the cport, gets destroyed properly.
371 if (!gb_manifest_parse_cports(bundle
)) {
372 gb_bundle_destroy(bundle
);
381 /* An error occurred; undo any changes we've made */
382 list_for_each_entry_safe(bundle
, bundle_next
, &intf
->bundles
, links
) {
383 gb_bundle_destroy(bundle
);
386 return 0; /* Error; count should also be 0 */
389 static bool gb_manifest_parse_interface(struct gb_interface
*intf
,
390 struct manifest_desc
*interface_desc
)
392 struct greybus_descriptor_interface
*desc_intf
= interface_desc
->data
;
393 struct gb_control
*control
= intf
->control
;
396 /* Handle the strings first--they can fail */
397 str
= gb_string_get(intf
, desc_intf
->vendor_stringid
);
400 control
->vendor_string
= str
;
402 str
= gb_string_get(intf
, desc_intf
->product_stringid
);
404 goto out_free_vendor_string
;
405 control
->product_string
= str
;
407 /* Assign feature flags communicated via manifest */
408 intf
->features
= desc_intf
->features
;
410 /* Release the interface descriptor, now that we're done with it */
411 release_manifest_descriptor(interface_desc
);
413 /* An interface must have at least one bundle descriptor */
414 if (!gb_manifest_parse_bundles(intf
)) {
415 dev_err(&intf
->dev
, "manifest bundle descriptors not valid\n");
421 kfree(control
->product_string
);
422 control
->product_string
= NULL
;
423 out_free_vendor_string
:
424 kfree(control
->vendor_string
);
425 control
->vendor_string
= NULL
;
431 * Parse a buffer containing an interface manifest.
433 * If we find anything wrong with the content/format of the buffer
436 * The first requirement is that the manifest's version is
439 * We make an initial pass through the buffer and identify all of
440 * the descriptors it contains, keeping track for each its type
441 * and the location size of its data in the buffer.
443 * Next we scan the descriptors, looking for an interface descriptor;
444 * there must be exactly one of those. When found, we record the
445 * information it contains, and then remove that descriptor (and any
446 * string descriptors it refers to) from further consideration.
448 * After that we look for the interface's bundles--there must be at
449 * least one of those.
451 * Returns true if parsing was successful, false otherwise.
453 bool gb_manifest_parse(struct gb_interface
*intf
, void *data
, size_t size
)
455 struct greybus_manifest
*manifest
;
456 struct greybus_manifest_header
*header
;
457 struct greybus_descriptor
*desc
;
458 struct manifest_desc
*descriptor
;
459 struct manifest_desc
*interface_desc
= NULL
;
464 /* Manifest descriptor list should be empty here */
465 if (WARN_ON(!list_empty(&intf
->manifest_descs
)))
468 /* we have to have at _least_ the manifest header */
469 if (size
< sizeof(*header
)) {
470 dev_err(&intf
->dev
, "short manifest (%zu < %zu)\n",
471 size
, sizeof(*header
));
475 /* Make sure the size is right */
477 header
= &manifest
->header
;
478 manifest_size
= le16_to_cpu(header
->size
);
479 if (manifest_size
!= size
) {
480 dev_err(&intf
->dev
, "manifest size mismatch (%zu != %u)\n",
481 size
, manifest_size
);
485 /* Validate major/minor number */
486 if (header
->version_major
> GREYBUS_VERSION_MAJOR
) {
487 dev_err(&intf
->dev
, "manifest version too new (%u.%u > %u.%u)\n",
488 header
->version_major
, header
->version_minor
,
489 GREYBUS_VERSION_MAJOR
, GREYBUS_VERSION_MINOR
);
493 /* OK, find all the descriptors */
494 desc
= manifest
->descriptors
;
495 size
-= sizeof(*header
);
499 desc_size
= identify_descriptor(intf
, desc
, size
);
504 desc
= (struct greybus_descriptor
*)((char *)desc
+ desc_size
);
508 /* There must be a single interface descriptor */
509 list_for_each_entry(descriptor
, &intf
->manifest_descs
, links
) {
510 if (descriptor
->type
== GREYBUS_TYPE_INTERFACE
)
512 interface_desc
= descriptor
;
515 dev_err(&intf
->dev
, "manifest must have 1 interface descriptor (%u found)\n",
521 /* Parse the manifest, starting with the interface descriptor */
522 result
= gb_manifest_parse_interface(intf
, interface_desc
);
525 * We really should have no remaining descriptors, but we
526 * don't know what newer format manifests might leave.
528 if (result
&& !list_empty(&intf
->manifest_descs
))
529 dev_info(&intf
->dev
, "excess descriptors in interface manifest\n");
531 release_manifest_descriptors(intf
);