2 * Copyright (C) 2016 CNEX Labs
3 * Initial release: Javier Gonzalez <javier@cnexlabs.com>
4 * Matias Bjorling <matias@cnexlabs.com>
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License version
8 * 2 as published by the Free Software Foundation.
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * General Public License for more details.
15 * Implementation of a physical block-device target for Open-channel SSDs.
17 * pblk-sysfs.c - pblk's sysfs
23 static ssize_t
pblk_sysfs_luns_show(struct pblk
*pblk
, char *page
)
25 struct nvm_tgt_dev
*dev
= pblk
->dev
;
26 struct nvm_geo
*geo
= &dev
->geo
;
27 struct pblk_lun
*rlun
;
31 for (i
= 0; i
< geo
->all_luns
; i
++) {
34 rlun
= &pblk
->luns
[i
];
35 if (!down_trylock(&rlun
->wr_sem
)) {
39 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
40 "pblk: pos:%d, ch:%d, lun:%d - %d\n",
50 static ssize_t
pblk_sysfs_rate_limiter(struct pblk
*pblk
, char *page
)
52 int free_blocks
, free_user_blocks
, total_blocks
;
53 int rb_user_max
, rb_user_cnt
;
54 int rb_gc_max
, rb_gc_cnt
, rb_budget
, rb_state
;
56 free_blocks
= pblk_rl_nr_free_blks(&pblk
->rl
);
57 free_user_blocks
= pblk_rl_nr_user_free_blks(&pblk
->rl
);
58 rb_user_max
= pblk
->rl
.rb_user_max
;
59 rb_user_cnt
= atomic_read(&pblk
->rl
.rb_user_cnt
);
60 rb_gc_max
= pblk
->rl
.rb_gc_max
;
61 rb_gc_cnt
= atomic_read(&pblk
->rl
.rb_gc_cnt
);
62 rb_budget
= pblk
->rl
.rb_budget
;
63 rb_state
= pblk
->rl
.rb_state
;
65 total_blocks
= pblk
->rl
.total_blocks
;
67 return snprintf(page
, PAGE_SIZE
,
68 "u:%u/%u,gc:%u/%u(%u)(stop:<%u,full:>%u,free:%d/%d/%d)-%d\n",
79 READ_ONCE(pblk
->rl
.rb_user_active
));
82 static ssize_t
pblk_sysfs_gc_state_show(struct pblk
*pblk
, char *page
)
84 int gc_enabled
, gc_active
;
86 pblk_gc_sysfs_state_show(pblk
, &gc_enabled
, &gc_active
);
87 return snprintf(page
, PAGE_SIZE
, "gc_enabled=%d, gc_active=%d\n",
88 gc_enabled
, gc_active
);
91 static ssize_t
pblk_sysfs_stats(struct pblk
*pblk
, char *page
)
95 sz
= snprintf(page
, PAGE_SIZE
,
96 "read_failed=%lu, read_high_ecc=%lu, read_empty=%lu, read_failed_gc=%lu, write_failed=%lu, erase_failed=%lu\n",
97 atomic_long_read(&pblk
->read_failed
),
98 atomic_long_read(&pblk
->read_high_ecc
),
99 atomic_long_read(&pblk
->read_empty
),
100 atomic_long_read(&pblk
->read_failed_gc
),
101 atomic_long_read(&pblk
->write_failed
),
102 atomic_long_read(&pblk
->erase_failed
));
107 static ssize_t
pblk_sysfs_write_buffer(struct pblk
*pblk
, char *page
)
109 return pblk_rb_sysfs(&pblk
->rwb
, page
);
112 static ssize_t
pblk_sysfs_ppaf(struct pblk
*pblk
, char *page
)
114 struct nvm_tgt_dev
*dev
= pblk
->dev
;
115 struct nvm_geo
*geo
= &dev
->geo
;
118 if (geo
->version
== NVM_OCSSD_SPEC_12
) {
119 struct nvm_addrf_12
*ppaf
= (struct nvm_addrf_12
*)&pblk
->addrf
;
120 struct nvm_addrf_12
*gppaf
= (struct nvm_addrf_12
*)&geo
->addrf
;
122 sz
= snprintf(page
, PAGE_SIZE
,
123 "g:(b:%d)blk:%d/%d,pg:%d/%d,lun:%d/%d,ch:%d/%d,pl:%d/%d,sec:%d/%d\n",
125 ppaf
->blk_offset
, ppaf
->blk_len
,
126 ppaf
->pg_offset
, ppaf
->pg_len
,
127 ppaf
->lun_offset
, ppaf
->lun_len
,
128 ppaf
->ch_offset
, ppaf
->ch_len
,
129 ppaf
->pln_offset
, ppaf
->pln_len
,
130 ppaf
->sec_offset
, ppaf
->sec_len
);
132 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
133 "d:blk:%d/%d,pg:%d/%d,lun:%d/%d,ch:%d/%d,pl:%d/%d,sec:%d/%d\n",
134 gppaf
->blk_offset
, gppaf
->blk_len
,
135 gppaf
->pg_offset
, gppaf
->pg_len
,
136 gppaf
->lun_offset
, gppaf
->lun_len
,
137 gppaf
->ch_offset
, gppaf
->ch_len
,
138 gppaf
->pln_offset
, gppaf
->pln_len
,
139 gppaf
->sec_offset
, gppaf
->sec_len
);
141 struct nvm_addrf
*ppaf
= &pblk
->addrf
;
142 struct nvm_addrf
*gppaf
= &geo
->addrf
;
144 sz
= snprintf(page
, PAGE_SIZE
,
145 "pblk:(s:%d)ch:%d/%d,lun:%d/%d,chk:%d/%d/sec:%d/%d\n",
147 ppaf
->ch_offset
, ppaf
->ch_len
,
148 ppaf
->lun_offset
, ppaf
->lun_len
,
149 ppaf
->chk_offset
, ppaf
->chk_len
,
150 ppaf
->sec_offset
, ppaf
->sec_len
);
152 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
153 "device:ch:%d/%d,lun:%d/%d,chk:%d/%d,sec:%d/%d\n",
154 gppaf
->ch_offset
, gppaf
->ch_len
,
155 gppaf
->lun_offset
, gppaf
->lun_len
,
156 gppaf
->chk_offset
, gppaf
->chk_len
,
157 gppaf
->sec_offset
, gppaf
->sec_len
);
163 static ssize_t
pblk_sysfs_lines(struct pblk
*pblk
, char *page
)
165 struct nvm_tgt_dev
*dev
= pblk
->dev
;
166 struct nvm_geo
*geo
= &dev
->geo
;
167 struct pblk_line_meta
*lm
= &pblk
->lm
;
168 struct pblk_line_mgmt
*l_mg
= &pblk
->l_mg
;
169 struct pblk_line
*line
;
172 int cur_data
, cur_log
;
173 int free_line_cnt
= 0, closed_line_cnt
= 0, emeta_line_cnt
= 0;
174 int d_line_cnt
= 0, l_line_cnt
= 0;
175 int gc_full
= 0, gc_high
= 0, gc_mid
= 0, gc_low
= 0, gc_empty
= 0;
178 int bad
= 0, cor
= 0;
179 int msecs
= 0, cur_sec
= 0, vsc
= 0, sec_in_line
= 0;
180 int map_weight
= 0, meta_weight
= 0;
182 spin_lock(&l_mg
->free_lock
);
183 cur_data
= (l_mg
->data_line
) ? l_mg
->data_line
->id
: -1;
184 cur_log
= (l_mg
->log_line
) ? l_mg
->log_line
->id
: -1;
185 nr_free_lines
= l_mg
->nr_free_lines
;
187 list_for_each_entry(line
, &l_mg
->free_list
, list
)
189 spin_unlock(&l_mg
->free_lock
);
191 spin_lock(&l_mg
->close_lock
);
192 list_for_each_entry(line
, &l_mg
->emeta_list
, list
)
194 spin_unlock(&l_mg
->close_lock
);
196 spin_lock(&l_mg
->gc_lock
);
197 list_for_each_entry(line
, &l_mg
->gc_full_list
, list
) {
198 if (line
->type
== PBLK_LINETYPE_DATA
)
200 else if (line
->type
== PBLK_LINETYPE_LOG
)
206 list_for_each_entry(line
, &l_mg
->gc_high_list
, list
) {
207 if (line
->type
== PBLK_LINETYPE_DATA
)
209 else if (line
->type
== PBLK_LINETYPE_LOG
)
215 list_for_each_entry(line
, &l_mg
->gc_mid_list
, list
) {
216 if (line
->type
== PBLK_LINETYPE_DATA
)
218 else if (line
->type
== PBLK_LINETYPE_LOG
)
224 list_for_each_entry(line
, &l_mg
->gc_low_list
, list
) {
225 if (line
->type
== PBLK_LINETYPE_DATA
)
227 else if (line
->type
== PBLK_LINETYPE_LOG
)
233 list_for_each_entry(line
, &l_mg
->gc_empty_list
, list
) {
234 if (line
->type
== PBLK_LINETYPE_DATA
)
236 else if (line
->type
== PBLK_LINETYPE_LOG
)
242 list_for_each_entry(line
, &l_mg
->gc_werr_list
, list
) {
243 if (line
->type
== PBLK_LINETYPE_DATA
)
245 else if (line
->type
== PBLK_LINETYPE_LOG
)
251 list_for_each_entry(line
, &l_mg
->bad_list
, list
)
253 list_for_each_entry(line
, &l_mg
->corrupt_list
, list
)
255 spin_unlock(&l_mg
->gc_lock
);
257 spin_lock(&l_mg
->free_lock
);
258 if (l_mg
->data_line
) {
259 cur_sec
= l_mg
->data_line
->cur_sec
;
260 msecs
= l_mg
->data_line
->left_msecs
;
261 vsc
= le32_to_cpu(*l_mg
->data_line
->vsc
);
262 sec_in_line
= l_mg
->data_line
->sec_in_line
;
263 meta_weight
= bitmap_weight(&l_mg
->meta_bitmap
,
266 spin_lock(&l_mg
->data_line
->lock
);
267 if (l_mg
->data_line
->map_bitmap
)
268 map_weight
= bitmap_weight(l_mg
->data_line
->map_bitmap
,
272 spin_unlock(&l_mg
->data_line
->lock
);
274 spin_unlock(&l_mg
->free_lock
);
276 if (nr_free_lines
!= free_line_cnt
)
277 pblk_err(pblk
, "corrupted free line list:%d/%d\n",
278 nr_free_lines
, free_line_cnt
);
280 sz
= snprintf(page
, PAGE_SIZE
- sz
,
281 "line: nluns:%d, nblks:%d, nsecs:%d\n",
282 geo
->all_luns
, lm
->blk_per_line
, lm
->sec_per_line
);
284 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
285 "lines:d:%d,l:%d-f:%d,m:%d/%d,c:%d,b:%d,co:%d(d:%d,l:%d)t:%d\n",
288 emeta_line_cnt
, meta_weight
,
291 d_line_cnt
, l_line_cnt
,
294 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
295 "GC: full:%d, high:%d, mid:%d, low:%d, empty:%d, werr: %d, queue:%d\n",
296 gc_full
, gc_high
, gc_mid
, gc_low
, gc_empty
, gc_werr
,
297 atomic_read(&pblk
->gc
.read_inflight_gc
));
299 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
300 "data (%d) cur:%d, left:%d, vsc:%d, s:%d, map:%d/%d (%d)\n",
301 cur_data
, cur_sec
, msecs
, vsc
, sec_in_line
,
302 map_weight
, lm
->sec_per_line
,
303 atomic_read(&pblk
->inflight_io
));
308 static ssize_t
pblk_sysfs_lines_info(struct pblk
*pblk
, char *page
)
310 struct nvm_tgt_dev
*dev
= pblk
->dev
;
311 struct nvm_geo
*geo
= &dev
->geo
;
312 struct pblk_line_meta
*lm
= &pblk
->lm
;
315 sz
= snprintf(page
, PAGE_SIZE
- sz
,
316 "smeta - len:%d, secs:%d\n",
317 lm
->smeta_len
, lm
->smeta_sec
);
318 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
319 "emeta - len:%d, sec:%d, bb_start:%d\n",
320 lm
->emeta_len
[0], lm
->emeta_sec
[0],
322 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
323 "bitmap lengths: sec:%d, blk:%d, lun:%d\n",
327 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
328 "blk_line:%d, sec_line:%d, sec_blk:%d\n",
336 static ssize_t
pblk_sysfs_get_sec_per_write(struct pblk
*pblk
, char *page
)
338 return snprintf(page
, PAGE_SIZE
, "%d\n", pblk
->sec_per_write
);
341 static ssize_t
pblk_get_write_amp(u64 user
, u64 gc
, u64 pad
,
347 sz
= snprintf(page
, PAGE_SIZE
,
348 "user:%lld gc:%lld pad:%lld WA:",
352 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "NaN\n");
357 wa_int
= (user
+ gc
+ pad
) * 100000;
358 wa_int
= div_u64(wa_int
, user
);
359 wa_int
= div_u64_rem(wa_int
, 100000, &wa_frac
);
361 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "%llu.%05u\n",
368 static ssize_t
pblk_sysfs_get_write_amp_mileage(struct pblk
*pblk
, char *page
)
370 return pblk_get_write_amp(atomic64_read(&pblk
->user_wa
),
371 atomic64_read(&pblk
->gc_wa
), atomic64_read(&pblk
->pad_wa
),
375 static ssize_t
pblk_sysfs_get_write_amp_trip(struct pblk
*pblk
, char *page
)
377 return pblk_get_write_amp(
378 atomic64_read(&pblk
->user_wa
) - pblk
->user_rst_wa
,
379 atomic64_read(&pblk
->gc_wa
) - pblk
->gc_rst_wa
,
380 atomic64_read(&pblk
->pad_wa
) - pblk
->pad_rst_wa
, page
);
383 static long long bucket_percentage(unsigned long long bucket
,
384 unsigned long long total
)
386 int p
= bucket
* 100;
388 p
= div_u64(p
, total
);
393 static ssize_t
pblk_sysfs_get_padding_dist(struct pblk
*pblk
, char *page
)
396 unsigned long long total
;
397 unsigned long long total_buckets
= 0;
398 int buckets
= pblk
->min_write_pgs
- 1;
401 total
= atomic64_read(&pblk
->nr_flush
) - pblk
->nr_flush_rst
;
403 for (i
= 0; i
< (buckets
+ 1); i
++)
404 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
,
406 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "\n");
411 for (i
= 0; i
< buckets
; i
++)
412 total_buckets
+= atomic64_read(&pblk
->pad_dist
[i
]);
414 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "0:%lld%% ",
415 bucket_percentage(total
- total_buckets
, total
));
417 for (i
= 0; i
< buckets
; i
++) {
418 unsigned long long p
;
420 p
= bucket_percentage(atomic64_read(&pblk
->pad_dist
[i
]),
422 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "%d:%lld%% ",
425 sz
+= snprintf(page
+ sz
, PAGE_SIZE
- sz
, "\n");
430 #ifdef CONFIG_NVM_PBLK_DEBUG
431 static ssize_t
pblk_sysfs_stats_debug(struct pblk
*pblk
, char *page
)
433 return snprintf(page
, PAGE_SIZE
,
434 "%lu\t%lu\t%ld\t%llu\t%ld\t%lu\t%lu\t%lu\t%lu\t%lu\t%lu\t%lu\t%lu\n",
435 atomic_long_read(&pblk
->inflight_writes
),
436 atomic_long_read(&pblk
->inflight_reads
),
437 atomic_long_read(&pblk
->req_writes
),
438 (u64
)atomic64_read(&pblk
->nr_flush
),
439 atomic_long_read(&pblk
->padded_writes
),
440 atomic_long_read(&pblk
->padded_wb
),
441 atomic_long_read(&pblk
->sub_writes
),
442 atomic_long_read(&pblk
->sync_writes
),
443 atomic_long_read(&pblk
->recov_writes
),
444 atomic_long_read(&pblk
->recov_gc_writes
),
445 atomic_long_read(&pblk
->recov_gc_reads
),
446 atomic_long_read(&pblk
->cache_reads
),
447 atomic_long_read(&pblk
->sync_reads
));
451 static ssize_t
pblk_sysfs_gc_force(struct pblk
*pblk
, const char *page
,
457 c_len
= strcspn(page
, "\n");
461 if (kstrtouint(page
, 0, &force
))
464 pblk_gc_sysfs_force(pblk
, force
);
469 static ssize_t
pblk_sysfs_set_sec_per_write(struct pblk
*pblk
,
470 const char *page
, size_t len
)
475 c_len
= strcspn(page
, "\n");
479 if (kstrtouint(page
, 0, &sec_per_write
))
482 if (sec_per_write
< pblk
->min_write_pgs
483 || sec_per_write
> pblk
->max_write_pgs
484 || sec_per_write
% pblk
->min_write_pgs
!= 0)
487 pblk_set_sec_per_write(pblk
, sec_per_write
);
492 static ssize_t
pblk_sysfs_set_write_amp_trip(struct pblk
*pblk
,
493 const char *page
, size_t len
)
498 c_len
= strcspn(page
, "\n");
502 if (kstrtouint(page
, 0, &reset_value
))
505 if (reset_value
!= 0)
508 pblk
->user_rst_wa
= atomic64_read(&pblk
->user_wa
);
509 pblk
->pad_rst_wa
= atomic64_read(&pblk
->pad_wa
);
510 pblk
->gc_rst_wa
= atomic64_read(&pblk
->gc_wa
);
516 static ssize_t
pblk_sysfs_set_padding_dist(struct pblk
*pblk
,
517 const char *page
, size_t len
)
521 int buckets
= pblk
->min_write_pgs
- 1;
524 c_len
= strcspn(page
, "\n");
528 if (kstrtouint(page
, 0, &reset_value
))
531 if (reset_value
!= 0)
534 for (i
= 0; i
< buckets
; i
++)
535 atomic64_set(&pblk
->pad_dist
[i
], 0);
537 pblk
->nr_flush_rst
= atomic64_read(&pblk
->nr_flush
);
542 static struct attribute sys_write_luns
= {
543 .name
= "write_luns",
547 static struct attribute sys_rate_limiter_attr
= {
548 .name
= "rate_limiter",
552 static struct attribute sys_gc_state
= {
557 static struct attribute sys_errors_attr
= {
562 static struct attribute sys_rb_attr
= {
563 .name
= "write_buffer",
567 static struct attribute sys_stats_ppaf_attr
= {
568 .name
= "ppa_format",
572 static struct attribute sys_lines_attr
= {
577 static struct attribute sys_lines_info_attr
= {
578 .name
= "lines_info",
582 static struct attribute sys_gc_force
= {
587 static struct attribute sys_max_sec_per_write
= {
588 .name
= "max_sec_per_write",
592 static struct attribute sys_write_amp_mileage
= {
593 .name
= "write_amp_mileage",
597 static struct attribute sys_write_amp_trip
= {
598 .name
= "write_amp_trip",
602 static struct attribute sys_padding_dist
= {
603 .name
= "padding_dist",
607 #ifdef CONFIG_NVM_PBLK_DEBUG
608 static struct attribute sys_stats_debug_attr
= {
614 static struct attribute
*pblk_attrs
[] = {
616 &sys_rate_limiter_attr
,
620 &sys_max_sec_per_write
,
622 &sys_stats_ppaf_attr
,
624 &sys_lines_info_attr
,
625 &sys_write_amp_mileage
,
628 #ifdef CONFIG_NVM_PBLK_DEBUG
629 &sys_stats_debug_attr
,
634 static ssize_t
pblk_sysfs_show(struct kobject
*kobj
, struct attribute
*attr
,
637 struct pblk
*pblk
= container_of(kobj
, struct pblk
, kobj
);
639 if (strcmp(attr
->name
, "rate_limiter") == 0)
640 return pblk_sysfs_rate_limiter(pblk
, buf
);
641 else if (strcmp(attr
->name
, "write_luns") == 0)
642 return pblk_sysfs_luns_show(pblk
, buf
);
643 else if (strcmp(attr
->name
, "gc_state") == 0)
644 return pblk_sysfs_gc_state_show(pblk
, buf
);
645 else if (strcmp(attr
->name
, "errors") == 0)
646 return pblk_sysfs_stats(pblk
, buf
);
647 else if (strcmp(attr
->name
, "write_buffer") == 0)
648 return pblk_sysfs_write_buffer(pblk
, buf
);
649 else if (strcmp(attr
->name
, "ppa_format") == 0)
650 return pblk_sysfs_ppaf(pblk
, buf
);
651 else if (strcmp(attr
->name
, "lines") == 0)
652 return pblk_sysfs_lines(pblk
, buf
);
653 else if (strcmp(attr
->name
, "lines_info") == 0)
654 return pblk_sysfs_lines_info(pblk
, buf
);
655 else if (strcmp(attr
->name
, "max_sec_per_write") == 0)
656 return pblk_sysfs_get_sec_per_write(pblk
, buf
);
657 else if (strcmp(attr
->name
, "write_amp_mileage") == 0)
658 return pblk_sysfs_get_write_amp_mileage(pblk
, buf
);
659 else if (strcmp(attr
->name
, "write_amp_trip") == 0)
660 return pblk_sysfs_get_write_amp_trip(pblk
, buf
);
661 else if (strcmp(attr
->name
, "padding_dist") == 0)
662 return pblk_sysfs_get_padding_dist(pblk
, buf
);
663 #ifdef CONFIG_NVM_PBLK_DEBUG
664 else if (strcmp(attr
->name
, "stats") == 0)
665 return pblk_sysfs_stats_debug(pblk
, buf
);
670 static ssize_t
pblk_sysfs_store(struct kobject
*kobj
, struct attribute
*attr
,
671 const char *buf
, size_t len
)
673 struct pblk
*pblk
= container_of(kobj
, struct pblk
, kobj
);
675 if (strcmp(attr
->name
, "gc_force") == 0)
676 return pblk_sysfs_gc_force(pblk
, buf
, len
);
677 else if (strcmp(attr
->name
, "max_sec_per_write") == 0)
678 return pblk_sysfs_set_sec_per_write(pblk
, buf
, len
);
679 else if (strcmp(attr
->name
, "write_amp_trip") == 0)
680 return pblk_sysfs_set_write_amp_trip(pblk
, buf
, len
);
681 else if (strcmp(attr
->name
, "padding_dist") == 0)
682 return pblk_sysfs_set_padding_dist(pblk
, buf
, len
);
686 static const struct sysfs_ops pblk_sysfs_ops
= {
687 .show
= pblk_sysfs_show
,
688 .store
= pblk_sysfs_store
,
691 static struct kobj_type pblk_ktype
= {
692 .sysfs_ops
= &pblk_sysfs_ops
,
693 .default_attrs
= pblk_attrs
,
696 int pblk_sysfs_init(struct gendisk
*tdisk
)
698 struct pblk
*pblk
= tdisk
->private_data
;
699 struct device
*parent_dev
= disk_to_dev(pblk
->disk
);
702 ret
= kobject_init_and_add(&pblk
->kobj
, &pblk_ktype
,
703 kobject_get(&parent_dev
->kobj
),
706 pblk_err(pblk
, "could not register\n");
710 kobject_uevent(&pblk
->kobj
, KOBJ_ADD
);
714 void pblk_sysfs_exit(struct gendisk
*tdisk
)
716 struct pblk
*pblk
= tdisk
->private_data
;
718 kobject_uevent(&pblk
->kobj
, KOBJ_REMOVE
);
719 kobject_del(&pblk
->kobj
);
720 kobject_put(&pblk
->kobj
);