treewide: remove redundant IS_ERR() before error code check
[linux/fpc-iii.git] / drivers / gpu / drm / armada / armada_crtc.c
blobc2b92acd1e9ad23985a0365327a749c2078b8d4a
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3 * Copyright (C) 2012 Russell King
4 * Rewritten from the dovefb driver, and Armada510 manuals.
5 */
7 #include <linux/clk.h>
8 #include <linux/component.h>
9 #include <linux/module.h>
10 #include <linux/of_device.h>
11 #include <linux/platform_device.h>
13 #include <drm/drm_atomic.h>
14 #include <drm/drm_atomic_helper.h>
15 #include <drm/drm_plane_helper.h>
16 #include <drm/drm_probe_helper.h>
17 #include <drm/drm_vblank.h>
19 #include "armada_crtc.h"
20 #include "armada_drm.h"
21 #include "armada_fb.h"
22 #include "armada_gem.h"
23 #include "armada_hw.h"
24 #include "armada_plane.h"
25 #include "armada_trace.h"
28 * A note about interlacing. Let's consider HDMI 1920x1080i.
29 * The timing parameters we have from X are:
30 * Hact HsyA HsyI Htot Vact VsyA VsyI Vtot
31 * 1920 2448 2492 2640 1080 1084 1094 1125
32 * Which get translated to:
33 * Hact HsyA HsyI Htot Vact VsyA VsyI Vtot
34 * 1920 2448 2492 2640 540 542 547 562
36 * This is how it is defined by CEA-861-D - line and pixel numbers are
37 * referenced to the rising edge of VSYNC and HSYNC. Total clocks per
38 * line: 2640. The odd frame, the first active line is at line 21, and
39 * the even frame, the first active line is 584.
41 * LN: 560 561 562 563 567 568 569
42 * DE: ~~~|____________________________//__________________________
43 * HSYNC: ____|~|_____|~|_____|~|_____|~|_//__|~|_____|~|_____|~|_____
44 * VSYNC: _________________________|~~~~~~//~~~~~~~~~~~~~~~|__________
45 * 22 blanking lines. VSYNC at 1320 (referenced to the HSYNC rising edge).
47 * LN: 1123 1124 1125 1 5 6 7
48 * DE: ~~~|____________________________//__________________________
49 * HSYNC: ____|~|_____|~|_____|~|_____|~|_//__|~|_____|~|_____|~|_____
50 * VSYNC: ____________________|~~~~~~~~~~~//~~~~~~~~~~|_______________
51 * 23 blanking lines
53 * The Armada LCD Controller line and pixel numbers are, like X timings,
54 * referenced to the top left of the active frame.
56 * So, translating these to our LCD controller:
57 * Odd frame, 563 total lines, VSYNC at line 543-548, pixel 1128.
58 * Even frame, 562 total lines, VSYNC at line 542-547, pixel 2448.
59 * Note: Vsync front porch remains constant!
61 * if (odd_frame) {
62 * vtotal = mode->crtc_vtotal + 1;
63 * vbackporch = mode->crtc_vsync_start - mode->crtc_vdisplay + 1;
64 * vhorizpos = mode->crtc_hsync_start - mode->crtc_htotal / 2
65 * } else {
66 * vtotal = mode->crtc_vtotal;
67 * vbackporch = mode->crtc_vsync_start - mode->crtc_vdisplay;
68 * vhorizpos = mode->crtc_hsync_start;
69 * }
70 * vfrontporch = mode->crtc_vtotal - mode->crtc_vsync_end;
72 * So, we need to reprogram these registers on each vsync event:
73 * LCD_SPU_V_PORCH, LCD_SPU_ADV_REG, LCD_SPUT_V_H_TOTAL
75 * Note: we do not use the frame done interrupts because these appear
76 * to happen too early, and lead to jitter on the display (presumably
77 * they occur at the end of the last active line, before the vsync back
78 * porch, which we're reprogramming.)
81 void
82 armada_drm_crtc_update_regs(struct armada_crtc *dcrtc, struct armada_regs *regs)
84 while (regs->offset != ~0) {
85 void __iomem *reg = dcrtc->base + regs->offset;
86 uint32_t val;
88 val = regs->mask;
89 if (val != 0)
90 val &= readl_relaxed(reg);
91 writel_relaxed(val | regs->val, reg);
92 ++regs;
96 static void armada_drm_crtc_update(struct armada_crtc *dcrtc, bool enable)
98 uint32_t dumb_ctrl;
100 dumb_ctrl = dcrtc->cfg_dumb_ctrl;
102 if (enable)
103 dumb_ctrl |= CFG_DUMB_ENA;
106 * When the dumb interface isn't in DUMB24_RGB888_0 mode, it might
107 * be using SPI or GPIO. If we set this to DUMB_BLANK, we will
108 * force LCD_D[23:0] to output blank color, overriding the GPIO or
109 * SPI usage. So leave it as-is unless in DUMB24_RGB888_0 mode.
111 if (!enable && (dumb_ctrl & DUMB_MASK) == DUMB24_RGB888_0) {
112 dumb_ctrl &= ~DUMB_MASK;
113 dumb_ctrl |= DUMB_BLANK;
116 armada_updatel(dumb_ctrl,
117 ~(CFG_INV_CSYNC | CFG_INV_HSYNC | CFG_INV_VSYNC),
118 dcrtc->base + LCD_SPU_DUMB_CTRL);
121 static void armada_drm_crtc_queue_state_event(struct drm_crtc *crtc)
123 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
124 struct drm_pending_vblank_event *event;
126 /* If we have an event, we need vblank events enabled */
127 event = xchg(&crtc->state->event, NULL);
128 if (event) {
129 WARN_ON(drm_crtc_vblank_get(crtc) != 0);
130 dcrtc->event = event;
134 static void armada_drm_update_gamma(struct drm_crtc *crtc)
136 struct drm_property_blob *blob = crtc->state->gamma_lut;
137 void __iomem *base = drm_to_armada_crtc(crtc)->base;
138 int i;
140 if (blob) {
141 struct drm_color_lut *lut = blob->data;
143 armada_updatel(CFG_CSB_256x8, CFG_CSB_256x8 | CFG_PDWN256x8,
144 base + LCD_SPU_SRAM_PARA1);
146 for (i = 0; i < 256; i++) {
147 writel_relaxed(drm_color_lut_extract(lut[i].red, 8),
148 base + LCD_SPU_SRAM_WRDAT);
149 writel_relaxed(i | SRAM_WRITE | SRAM_GAMMA_YR,
150 base + LCD_SPU_SRAM_CTRL);
151 readl_relaxed(base + LCD_SPU_HWC_OVSA_HPXL_VLN);
152 writel_relaxed(drm_color_lut_extract(lut[i].green, 8),
153 base + LCD_SPU_SRAM_WRDAT);
154 writel_relaxed(i | SRAM_WRITE | SRAM_GAMMA_UG,
155 base + LCD_SPU_SRAM_CTRL);
156 readl_relaxed(base + LCD_SPU_HWC_OVSA_HPXL_VLN);
157 writel_relaxed(drm_color_lut_extract(lut[i].blue, 8),
158 base + LCD_SPU_SRAM_WRDAT);
159 writel_relaxed(i | SRAM_WRITE | SRAM_GAMMA_VB,
160 base + LCD_SPU_SRAM_CTRL);
161 readl_relaxed(base + LCD_SPU_HWC_OVSA_HPXL_VLN);
163 armada_updatel(CFG_GAMMA_ENA, CFG_GAMMA_ENA,
164 base + LCD_SPU_DMA_CTRL0);
165 } else {
166 armada_updatel(0, CFG_GAMMA_ENA, base + LCD_SPU_DMA_CTRL0);
167 armada_updatel(CFG_PDWN256x8, CFG_CSB_256x8 | CFG_PDWN256x8,
168 base + LCD_SPU_SRAM_PARA1);
172 static enum drm_mode_status armada_drm_crtc_mode_valid(struct drm_crtc *crtc,
173 const struct drm_display_mode *mode)
175 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
177 if (mode->vscan > 1)
178 return MODE_NO_VSCAN;
180 if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
181 return MODE_NO_DBLESCAN;
183 if (mode->flags & DRM_MODE_FLAG_HSKEW)
184 return MODE_H_ILLEGAL;
186 /* We can't do interlaced modes if we don't have the SPU_ADV_REG */
187 if (!dcrtc->variant->has_spu_adv_reg &&
188 mode->flags & DRM_MODE_FLAG_INTERLACE)
189 return MODE_NO_INTERLACE;
191 if (mode->flags & (DRM_MODE_FLAG_BCAST | DRM_MODE_FLAG_PIXMUX |
192 DRM_MODE_FLAG_CLKDIV2))
193 return MODE_BAD;
195 return MODE_OK;
198 /* The mode_config.mutex will be held for this call */
199 static bool armada_drm_crtc_mode_fixup(struct drm_crtc *crtc,
200 const struct drm_display_mode *mode, struct drm_display_mode *adj)
202 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
203 int ret;
206 * Set CRTC modesetting parameters for the adjusted mode. This is
207 * applied after the connectors, bridges, and encoders have fixed up
208 * this mode, as described above drm_atomic_helper_check_modeset().
210 drm_mode_set_crtcinfo(adj, CRTC_INTERLACE_HALVE_V);
213 * Validate the adjusted mode in case an encoder/bridge has set
214 * something we don't support.
216 if (armada_drm_crtc_mode_valid(crtc, adj) != MODE_OK)
217 return false;
219 /* Check whether the display mode is possible */
220 ret = dcrtc->variant->compute_clock(dcrtc, adj, NULL);
221 if (ret)
222 return false;
224 return true;
227 /* These are locked by dev->vbl_lock */
228 static void armada_drm_crtc_disable_irq(struct armada_crtc *dcrtc, u32 mask)
230 if (dcrtc->irq_ena & mask) {
231 dcrtc->irq_ena &= ~mask;
232 writel(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
236 static void armada_drm_crtc_enable_irq(struct armada_crtc *dcrtc, u32 mask)
238 if ((dcrtc->irq_ena & mask) != mask) {
239 dcrtc->irq_ena |= mask;
240 writel(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
241 if (readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR) & mask)
242 writel(0, dcrtc->base + LCD_SPU_IRQ_ISR);
246 static void armada_drm_crtc_irq(struct armada_crtc *dcrtc, u32 stat)
248 struct drm_pending_vblank_event *event;
249 void __iomem *base = dcrtc->base;
251 if (stat & DMA_FF_UNDERFLOW)
252 DRM_ERROR("video underflow on crtc %u\n", dcrtc->num);
253 if (stat & GRA_FF_UNDERFLOW)
254 DRM_ERROR("graphics underflow on crtc %u\n", dcrtc->num);
256 if (stat & VSYNC_IRQ)
257 drm_crtc_handle_vblank(&dcrtc->crtc);
259 spin_lock(&dcrtc->irq_lock);
260 if (stat & GRA_FRAME_IRQ && dcrtc->interlaced) {
261 int i = stat & GRA_FRAME_IRQ0 ? 0 : 1;
262 uint32_t val;
264 writel_relaxed(dcrtc->v[i].spu_v_porch, base + LCD_SPU_V_PORCH);
265 writel_relaxed(dcrtc->v[i].spu_v_h_total,
266 base + LCD_SPUT_V_H_TOTAL);
268 val = readl_relaxed(base + LCD_SPU_ADV_REG);
269 val &= ~(ADV_VSYNC_L_OFF | ADV_VSYNC_H_OFF | ADV_VSYNCOFFEN);
270 val |= dcrtc->v[i].spu_adv_reg;
271 writel_relaxed(val, base + LCD_SPU_ADV_REG);
274 if (stat & dcrtc->irq_ena & DUMB_FRAMEDONE) {
275 if (dcrtc->update_pending) {
276 armada_drm_crtc_update_regs(dcrtc, dcrtc->regs);
277 dcrtc->update_pending = false;
279 if (dcrtc->cursor_update) {
280 writel_relaxed(dcrtc->cursor_hw_pos,
281 base + LCD_SPU_HWC_OVSA_HPXL_VLN);
282 writel_relaxed(dcrtc->cursor_hw_sz,
283 base + LCD_SPU_HWC_HPXL_VLN);
284 armada_updatel(CFG_HWC_ENA,
285 CFG_HWC_ENA | CFG_HWC_1BITMOD |
286 CFG_HWC_1BITENA,
287 base + LCD_SPU_DMA_CTRL0);
288 dcrtc->cursor_update = false;
290 armada_drm_crtc_disable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
292 spin_unlock(&dcrtc->irq_lock);
294 if (stat & VSYNC_IRQ && !dcrtc->update_pending) {
295 event = xchg(&dcrtc->event, NULL);
296 if (event) {
297 spin_lock(&dcrtc->crtc.dev->event_lock);
298 drm_crtc_send_vblank_event(&dcrtc->crtc, event);
299 spin_unlock(&dcrtc->crtc.dev->event_lock);
300 drm_crtc_vblank_put(&dcrtc->crtc);
305 static irqreturn_t armada_drm_irq(int irq, void *arg)
307 struct armada_crtc *dcrtc = arg;
308 u32 v, stat = readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR);
311 * Reading the ISR appears to clear bits provided CLEAN_SPU_IRQ_ISR
312 * is set. Writing has some other effect to acknowledge the IRQ -
313 * without this, we only get a single IRQ.
315 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ISR);
317 trace_armada_drm_irq(&dcrtc->crtc, stat);
319 /* Mask out those interrupts we haven't enabled */
320 v = stat & dcrtc->irq_ena;
322 if (v & (VSYNC_IRQ|GRA_FRAME_IRQ|DUMB_FRAMEDONE)) {
323 armada_drm_crtc_irq(dcrtc, stat);
324 return IRQ_HANDLED;
326 return IRQ_NONE;
329 /* The mode_config.mutex will be held for this call */
330 static void armada_drm_crtc_mode_set_nofb(struct drm_crtc *crtc)
332 struct drm_display_mode *adj = &crtc->state->adjusted_mode;
333 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
334 struct armada_regs regs[17];
335 uint32_t lm, rm, tm, bm, val, sclk;
336 unsigned long flags;
337 unsigned i;
338 bool interlaced = !!(adj->flags & DRM_MODE_FLAG_INTERLACE);
340 i = 0;
341 rm = adj->crtc_hsync_start - adj->crtc_hdisplay;
342 lm = adj->crtc_htotal - adj->crtc_hsync_end;
343 bm = adj->crtc_vsync_start - adj->crtc_vdisplay;
344 tm = adj->crtc_vtotal - adj->crtc_vsync_end;
346 DRM_DEBUG_KMS("[CRTC:%d:%s] mode " DRM_MODE_FMT "\n",
347 crtc->base.id, crtc->name, DRM_MODE_ARG(adj));
348 DRM_DEBUG_KMS("lm %d rm %d tm %d bm %d\n", lm, rm, tm, bm);
350 /* Now compute the divider for real */
351 dcrtc->variant->compute_clock(dcrtc, adj, &sclk);
353 armada_reg_queue_set(regs, i, sclk, LCD_CFG_SCLK_DIV);
355 spin_lock_irqsave(&dcrtc->irq_lock, flags);
357 dcrtc->interlaced = interlaced;
358 /* Even interlaced/progressive frame */
359 dcrtc->v[1].spu_v_h_total = adj->crtc_vtotal << 16 |
360 adj->crtc_htotal;
361 dcrtc->v[1].spu_v_porch = tm << 16 | bm;
362 val = adj->crtc_hsync_start;
363 dcrtc->v[1].spu_adv_reg = val << 20 | val | ADV_VSYNCOFFEN;
365 if (interlaced) {
366 /* Odd interlaced frame */
367 val -= adj->crtc_htotal / 2;
368 dcrtc->v[0].spu_adv_reg = val << 20 | val | ADV_VSYNCOFFEN;
369 dcrtc->v[0].spu_v_h_total = dcrtc->v[1].spu_v_h_total +
370 (1 << 16);
371 dcrtc->v[0].spu_v_porch = dcrtc->v[1].spu_v_porch + 1;
372 } else {
373 dcrtc->v[0] = dcrtc->v[1];
376 val = adj->crtc_vdisplay << 16 | adj->crtc_hdisplay;
378 armada_reg_queue_set(regs, i, val, LCD_SPU_V_H_ACTIVE);
379 armada_reg_queue_set(regs, i, (lm << 16) | rm, LCD_SPU_H_PORCH);
380 armada_reg_queue_set(regs, i, dcrtc->v[0].spu_v_porch, LCD_SPU_V_PORCH);
381 armada_reg_queue_set(regs, i, dcrtc->v[0].spu_v_h_total,
382 LCD_SPUT_V_H_TOTAL);
384 if (dcrtc->variant->has_spu_adv_reg)
385 armada_reg_queue_mod(regs, i, dcrtc->v[0].spu_adv_reg,
386 ADV_VSYNC_L_OFF | ADV_VSYNC_H_OFF |
387 ADV_VSYNCOFFEN, LCD_SPU_ADV_REG);
389 val = adj->flags & DRM_MODE_FLAG_NVSYNC ? CFG_VSYNC_INV : 0;
390 armada_reg_queue_mod(regs, i, val, CFG_VSYNC_INV, LCD_SPU_DMA_CTRL1);
393 * The documentation doesn't indicate what the normal state of
394 * the sync signals are. Sebastian Hesselbart kindly probed
395 * these signals on his board to determine their state.
397 * The non-inverted state of the sync signals is active high.
398 * Setting these bits makes the appropriate signal active low.
400 val = 0;
401 if (adj->flags & DRM_MODE_FLAG_NCSYNC)
402 val |= CFG_INV_CSYNC;
403 if (adj->flags & DRM_MODE_FLAG_NHSYNC)
404 val |= CFG_INV_HSYNC;
405 if (adj->flags & DRM_MODE_FLAG_NVSYNC)
406 val |= CFG_INV_VSYNC;
407 armada_reg_queue_mod(regs, i, val, CFG_INV_CSYNC | CFG_INV_HSYNC |
408 CFG_INV_VSYNC, LCD_SPU_DUMB_CTRL);
409 armada_reg_queue_end(regs, i);
411 armada_drm_crtc_update_regs(dcrtc, regs);
412 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
415 static int armada_drm_crtc_atomic_check(struct drm_crtc *crtc,
416 struct drm_crtc_state *state)
418 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
420 if (state->gamma_lut && drm_color_lut_size(state->gamma_lut) != 256)
421 return -EINVAL;
423 if (state->color_mgmt_changed)
424 state->planes_changed = true;
426 return 0;
429 static void armada_drm_crtc_atomic_begin(struct drm_crtc *crtc,
430 struct drm_crtc_state *old_crtc_state)
432 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
434 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
436 if (crtc->state->color_mgmt_changed)
437 armada_drm_update_gamma(crtc);
439 dcrtc->regs_idx = 0;
440 dcrtc->regs = dcrtc->atomic_regs;
443 static void armada_drm_crtc_atomic_flush(struct drm_crtc *crtc,
444 struct drm_crtc_state *old_crtc_state)
446 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
448 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
450 armada_reg_queue_end(dcrtc->regs, dcrtc->regs_idx);
453 * If we aren't doing a full modeset, then we need to queue
454 * the event here.
456 if (!drm_atomic_crtc_needs_modeset(crtc->state)) {
457 dcrtc->update_pending = true;
458 armada_drm_crtc_queue_state_event(crtc);
459 spin_lock_irq(&dcrtc->irq_lock);
460 armada_drm_crtc_enable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
461 spin_unlock_irq(&dcrtc->irq_lock);
462 } else {
463 spin_lock_irq(&dcrtc->irq_lock);
464 armada_drm_crtc_update_regs(dcrtc, dcrtc->regs);
465 spin_unlock_irq(&dcrtc->irq_lock);
469 static void armada_drm_crtc_atomic_disable(struct drm_crtc *crtc,
470 struct drm_crtc_state *old_state)
472 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
473 struct drm_pending_vblank_event *event;
475 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
477 if (old_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE)
478 drm_crtc_vblank_put(crtc);
480 drm_crtc_vblank_off(crtc);
481 armada_drm_crtc_update(dcrtc, false);
483 if (!crtc->state->active) {
485 * This modeset will be leaving the CRTC disabled, so
486 * call the backend to disable upstream clocks etc.
488 if (dcrtc->variant->disable)
489 dcrtc->variant->disable(dcrtc);
492 * We will not receive any further vblank events.
493 * Send the flip_done event manually.
495 event = crtc->state->event;
496 crtc->state->event = NULL;
497 if (event) {
498 spin_lock_irq(&crtc->dev->event_lock);
499 drm_crtc_send_vblank_event(crtc, event);
500 spin_unlock_irq(&crtc->dev->event_lock);
505 static void armada_drm_crtc_atomic_enable(struct drm_crtc *crtc,
506 struct drm_crtc_state *old_state)
508 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
510 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
512 if (!old_state->active) {
514 * This modeset is enabling the CRTC after it having
515 * been disabled. Reverse the call to ->disable in
516 * the atomic_disable().
518 if (dcrtc->variant->enable)
519 dcrtc->variant->enable(dcrtc, &crtc->state->adjusted_mode);
521 armada_drm_crtc_update(dcrtc, true);
522 drm_crtc_vblank_on(crtc);
524 if (crtc->state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE)
525 WARN_ON(drm_crtc_vblank_get(crtc));
527 armada_drm_crtc_queue_state_event(crtc);
530 static const struct drm_crtc_helper_funcs armada_crtc_helper_funcs = {
531 .mode_valid = armada_drm_crtc_mode_valid,
532 .mode_fixup = armada_drm_crtc_mode_fixup,
533 .mode_set_nofb = armada_drm_crtc_mode_set_nofb,
534 .atomic_check = armada_drm_crtc_atomic_check,
535 .atomic_begin = armada_drm_crtc_atomic_begin,
536 .atomic_flush = armada_drm_crtc_atomic_flush,
537 .atomic_disable = armada_drm_crtc_atomic_disable,
538 .atomic_enable = armada_drm_crtc_atomic_enable,
541 static void armada_load_cursor_argb(void __iomem *base, uint32_t *pix,
542 unsigned stride, unsigned width, unsigned height)
544 uint32_t addr;
545 unsigned y;
547 addr = SRAM_HWC32_RAM1;
548 for (y = 0; y < height; y++) {
549 uint32_t *p = &pix[y * stride];
550 unsigned x;
552 for (x = 0; x < width; x++, p++) {
553 uint32_t val = *p;
556 * In "ARGB888" (HWC32) mode, writing to the SRAM
557 * requires these bits to contain:
558 * 31:24 = alpha 23:16 = blue 15:8 = green 7:0 = red
559 * So, it's actually ABGR8888. This is independent
560 * of the SWAPRB bits in DMA control register 0.
562 val = (val & 0xff00ff00) |
563 (val & 0x000000ff) << 16 |
564 (val & 0x00ff0000) >> 16;
566 writel_relaxed(val,
567 base + LCD_SPU_SRAM_WRDAT);
568 writel_relaxed(addr | SRAM_WRITE,
569 base + LCD_SPU_SRAM_CTRL);
570 readl_relaxed(base + LCD_SPU_HWC_OVSA_HPXL_VLN);
571 addr += 1;
572 if ((addr & 0x00ff) == 0)
573 addr += 0xf00;
574 if ((addr & 0x30ff) == 0)
575 addr = SRAM_HWC32_RAM2;
580 static void armada_drm_crtc_cursor_tran(void __iomem *base)
582 unsigned addr;
584 for (addr = 0; addr < 256; addr++) {
585 /* write the default value */
586 writel_relaxed(0x55555555, base + LCD_SPU_SRAM_WRDAT);
587 writel_relaxed(addr | SRAM_WRITE | SRAM_HWC32_TRAN,
588 base + LCD_SPU_SRAM_CTRL);
592 static int armada_drm_crtc_cursor_update(struct armada_crtc *dcrtc, bool reload)
594 uint32_t xoff, xscr, w = dcrtc->cursor_w, s;
595 uint32_t yoff, yscr, h = dcrtc->cursor_h;
596 uint32_t para1;
599 * Calculate the visible width and height of the cursor,
600 * screen position, and the position in the cursor bitmap.
602 if (dcrtc->cursor_x < 0) {
603 xoff = -dcrtc->cursor_x;
604 xscr = 0;
605 w -= min(xoff, w);
606 } else if (dcrtc->cursor_x + w > dcrtc->crtc.mode.hdisplay) {
607 xoff = 0;
608 xscr = dcrtc->cursor_x;
609 w = max_t(int, dcrtc->crtc.mode.hdisplay - dcrtc->cursor_x, 0);
610 } else {
611 xoff = 0;
612 xscr = dcrtc->cursor_x;
615 if (dcrtc->cursor_y < 0) {
616 yoff = -dcrtc->cursor_y;
617 yscr = 0;
618 h -= min(yoff, h);
619 } else if (dcrtc->cursor_y + h > dcrtc->crtc.mode.vdisplay) {
620 yoff = 0;
621 yscr = dcrtc->cursor_y;
622 h = max_t(int, dcrtc->crtc.mode.vdisplay - dcrtc->cursor_y, 0);
623 } else {
624 yoff = 0;
625 yscr = dcrtc->cursor_y;
628 /* On interlaced modes, the vertical cursor size must be halved */
629 s = dcrtc->cursor_w;
630 if (dcrtc->interlaced) {
631 s *= 2;
632 yscr /= 2;
633 h /= 2;
636 if (!dcrtc->cursor_obj || !h || !w) {
637 spin_lock_irq(&dcrtc->irq_lock);
638 dcrtc->cursor_update = false;
639 armada_updatel(0, CFG_HWC_ENA, dcrtc->base + LCD_SPU_DMA_CTRL0);
640 spin_unlock_irq(&dcrtc->irq_lock);
641 return 0;
644 spin_lock_irq(&dcrtc->irq_lock);
645 para1 = readl_relaxed(dcrtc->base + LCD_SPU_SRAM_PARA1);
646 armada_updatel(CFG_CSB_256x32, CFG_CSB_256x32 | CFG_PDWN256x32,
647 dcrtc->base + LCD_SPU_SRAM_PARA1);
648 spin_unlock_irq(&dcrtc->irq_lock);
651 * Initialize the transparency if the SRAM was powered down.
652 * We must also reload the cursor data as well.
654 if (!(para1 & CFG_CSB_256x32)) {
655 armada_drm_crtc_cursor_tran(dcrtc->base);
656 reload = true;
659 if (dcrtc->cursor_hw_sz != (h << 16 | w)) {
660 spin_lock_irq(&dcrtc->irq_lock);
661 dcrtc->cursor_update = false;
662 armada_updatel(0, CFG_HWC_ENA, dcrtc->base + LCD_SPU_DMA_CTRL0);
663 spin_unlock_irq(&dcrtc->irq_lock);
664 reload = true;
666 if (reload) {
667 struct armada_gem_object *obj = dcrtc->cursor_obj;
668 uint32_t *pix;
669 /* Set the top-left corner of the cursor image */
670 pix = obj->addr;
671 pix += yoff * s + xoff;
672 armada_load_cursor_argb(dcrtc->base, pix, s, w, h);
675 /* Reload the cursor position, size and enable in the IRQ handler */
676 spin_lock_irq(&dcrtc->irq_lock);
677 dcrtc->cursor_hw_pos = yscr << 16 | xscr;
678 dcrtc->cursor_hw_sz = h << 16 | w;
679 dcrtc->cursor_update = true;
680 armada_drm_crtc_enable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
681 spin_unlock_irq(&dcrtc->irq_lock);
683 return 0;
686 static void cursor_update(void *data)
688 armada_drm_crtc_cursor_update(data, true);
691 static int armada_drm_crtc_cursor_set(struct drm_crtc *crtc,
692 struct drm_file *file, uint32_t handle, uint32_t w, uint32_t h)
694 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
695 struct armada_gem_object *obj = NULL;
696 int ret;
698 /* If no cursor support, replicate drm's return value */
699 if (!dcrtc->variant->has_spu_adv_reg)
700 return -ENXIO;
702 if (handle && w > 0 && h > 0) {
703 /* maximum size is 64x32 or 32x64 */
704 if (w > 64 || h > 64 || (w > 32 && h > 32))
705 return -ENOMEM;
707 obj = armada_gem_object_lookup(file, handle);
708 if (!obj)
709 return -ENOENT;
711 /* Must be a kernel-mapped object */
712 if (!obj->addr) {
713 drm_gem_object_put_unlocked(&obj->obj);
714 return -EINVAL;
717 if (obj->obj.size < w * h * 4) {
718 DRM_ERROR("buffer is too small\n");
719 drm_gem_object_put_unlocked(&obj->obj);
720 return -ENOMEM;
724 if (dcrtc->cursor_obj) {
725 dcrtc->cursor_obj->update = NULL;
726 dcrtc->cursor_obj->update_data = NULL;
727 drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj);
729 dcrtc->cursor_obj = obj;
730 dcrtc->cursor_w = w;
731 dcrtc->cursor_h = h;
732 ret = armada_drm_crtc_cursor_update(dcrtc, true);
733 if (obj) {
734 obj->update_data = dcrtc;
735 obj->update = cursor_update;
738 return ret;
741 static int armada_drm_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
743 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
744 int ret;
746 /* If no cursor support, replicate drm's return value */
747 if (!dcrtc->variant->has_spu_adv_reg)
748 return -EFAULT;
750 dcrtc->cursor_x = x;
751 dcrtc->cursor_y = y;
752 ret = armada_drm_crtc_cursor_update(dcrtc, false);
754 return ret;
757 static void armada_drm_crtc_destroy(struct drm_crtc *crtc)
759 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
760 struct armada_private *priv = crtc->dev->dev_private;
762 if (dcrtc->cursor_obj)
763 drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj);
765 priv->dcrtc[dcrtc->num] = NULL;
766 drm_crtc_cleanup(&dcrtc->crtc);
768 if (dcrtc->variant->disable)
769 dcrtc->variant->disable(dcrtc);
771 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ENA);
773 of_node_put(dcrtc->crtc.port);
775 kfree(dcrtc);
778 static int armada_drm_crtc_late_register(struct drm_crtc *crtc)
780 if (IS_ENABLED(CONFIG_DEBUG_FS))
781 armada_drm_crtc_debugfs_init(drm_to_armada_crtc(crtc));
783 return 0;
786 /* These are called under the vbl_lock. */
787 static int armada_drm_crtc_enable_vblank(struct drm_crtc *crtc)
789 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
790 unsigned long flags;
792 spin_lock_irqsave(&dcrtc->irq_lock, flags);
793 armada_drm_crtc_enable_irq(dcrtc, VSYNC_IRQ_ENA);
794 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
795 return 0;
798 static void armada_drm_crtc_disable_vblank(struct drm_crtc *crtc)
800 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
801 unsigned long flags;
803 spin_lock_irqsave(&dcrtc->irq_lock, flags);
804 armada_drm_crtc_disable_irq(dcrtc, VSYNC_IRQ_ENA);
805 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
808 static const struct drm_crtc_funcs armada_crtc_funcs = {
809 .reset = drm_atomic_helper_crtc_reset,
810 .cursor_set = armada_drm_crtc_cursor_set,
811 .cursor_move = armada_drm_crtc_cursor_move,
812 .destroy = armada_drm_crtc_destroy,
813 .gamma_set = drm_atomic_helper_legacy_gamma_set,
814 .set_config = drm_atomic_helper_set_config,
815 .page_flip = drm_atomic_helper_page_flip,
816 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
817 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
818 .late_register = armada_drm_crtc_late_register,
819 .enable_vblank = armada_drm_crtc_enable_vblank,
820 .disable_vblank = armada_drm_crtc_disable_vblank,
823 int armada_crtc_select_clock(struct armada_crtc *dcrtc,
824 struct armada_clk_result *res,
825 const struct armada_clocking_params *params,
826 struct clk *clks[], size_t num_clks,
827 unsigned long desired_khz)
829 unsigned long desired_hz = desired_khz * 1000;
830 unsigned long desired_clk_hz; // requested clk input
831 unsigned long real_clk_hz; // actual clk input
832 unsigned long real_hz; // actual pixel clk
833 unsigned long permillage;
834 struct clk *clk;
835 u32 div;
836 int i;
838 DRM_DEBUG_KMS("[CRTC:%u:%s] desired clock=%luHz\n",
839 dcrtc->crtc.base.id, dcrtc->crtc.name, desired_hz);
841 for (i = 0; i < num_clks; i++) {
842 clk = clks[i];
843 if (!clk)
844 continue;
846 if (params->settable & BIT(i)) {
847 real_clk_hz = clk_round_rate(clk, desired_hz);
848 desired_clk_hz = desired_hz;
849 } else {
850 real_clk_hz = clk_get_rate(clk);
851 desired_clk_hz = real_clk_hz;
854 /* If the clock can do exactly the desired rate, we're done */
855 if (real_clk_hz == desired_hz) {
856 real_hz = real_clk_hz;
857 div = 1;
858 goto found;
861 /* Calculate the divider - if invalid, we can't do this rate */
862 div = DIV_ROUND_CLOSEST(real_clk_hz, desired_hz);
863 if (div == 0 || div > params->div_max)
864 continue;
866 /* Calculate the actual rate - HDMI requires -0.6%..+0.5% */
867 real_hz = DIV_ROUND_CLOSEST(real_clk_hz, div);
869 DRM_DEBUG_KMS("[CRTC:%u:%s] clk=%u %luHz div=%u real=%luHz\n",
870 dcrtc->crtc.base.id, dcrtc->crtc.name,
871 i, real_clk_hz, div, real_hz);
873 /* Avoid repeated division */
874 if (real_hz < desired_hz) {
875 permillage = real_hz / desired_khz;
876 if (permillage < params->permillage_min)
877 continue;
878 } else {
879 permillage = DIV_ROUND_UP(real_hz, desired_khz);
880 if (permillage > params->permillage_max)
881 continue;
883 goto found;
886 return -ERANGE;
888 found:
889 DRM_DEBUG_KMS("[CRTC:%u:%s] selected clk=%u %luHz div=%u real=%luHz\n",
890 dcrtc->crtc.base.id, dcrtc->crtc.name,
891 i, real_clk_hz, div, real_hz);
893 res->desired_clk_hz = desired_clk_hz;
894 res->clk = clk;
895 res->div = div;
897 return i;
900 static int armada_drm_crtc_create(struct drm_device *drm, struct device *dev,
901 struct resource *res, int irq, const struct armada_variant *variant,
902 struct device_node *port)
904 struct armada_private *priv = drm->dev_private;
905 struct armada_crtc *dcrtc;
906 struct drm_plane *primary;
907 void __iomem *base;
908 int ret;
910 base = devm_ioremap_resource(dev, res);
911 if (IS_ERR(base))
912 return PTR_ERR(base);
914 dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL);
915 if (!dcrtc) {
916 DRM_ERROR("failed to allocate Armada crtc\n");
917 return -ENOMEM;
920 if (dev != drm->dev)
921 dev_set_drvdata(dev, dcrtc);
923 dcrtc->variant = variant;
924 dcrtc->base = base;
925 dcrtc->num = drm->mode_config.num_crtc;
926 dcrtc->cfg_dumb_ctrl = DUMB24_RGB888_0;
927 dcrtc->spu_iopad_ctrl = CFG_VSCALE_LN_EN | CFG_IOPAD_DUMB24;
928 spin_lock_init(&dcrtc->irq_lock);
929 dcrtc->irq_ena = CLEAN_SPU_IRQ_ISR;
931 /* Initialize some registers which we don't otherwise set */
932 writel_relaxed(0x00000001, dcrtc->base + LCD_CFG_SCLK_DIV);
933 writel_relaxed(0x00000000, dcrtc->base + LCD_SPU_BLANKCOLOR);
934 writel_relaxed(dcrtc->spu_iopad_ctrl,
935 dcrtc->base + LCD_SPU_IOPAD_CONTROL);
936 writel_relaxed(0x00000000, dcrtc->base + LCD_SPU_SRAM_PARA0);
937 writel_relaxed(CFG_PDWN256x32 | CFG_PDWN256x24 | CFG_PDWN256x8 |
938 CFG_PDWN32x32 | CFG_PDWN16x66 | CFG_PDWN32x66 |
939 CFG_PDWN64x66, dcrtc->base + LCD_SPU_SRAM_PARA1);
940 writel_relaxed(0x2032ff81, dcrtc->base + LCD_SPU_DMA_CTRL1);
941 writel_relaxed(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
942 readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR);
943 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ISR);
945 ret = devm_request_irq(dev, irq, armada_drm_irq, 0, "armada_drm_crtc",
946 dcrtc);
947 if (ret < 0)
948 goto err_crtc;
950 if (dcrtc->variant->init) {
951 ret = dcrtc->variant->init(dcrtc, dev);
952 if (ret)
953 goto err_crtc;
956 /* Ensure AXI pipeline is enabled */
957 armada_updatel(CFG_ARBFAST_ENA, 0, dcrtc->base + LCD_SPU_DMA_CTRL0);
959 priv->dcrtc[dcrtc->num] = dcrtc;
961 dcrtc->crtc.port = port;
963 primary = kzalloc(sizeof(*primary), GFP_KERNEL);
964 if (!primary) {
965 ret = -ENOMEM;
966 goto err_crtc;
969 ret = armada_drm_primary_plane_init(drm, primary);
970 if (ret) {
971 kfree(primary);
972 goto err_crtc;
975 ret = drm_crtc_init_with_planes(drm, &dcrtc->crtc, primary, NULL,
976 &armada_crtc_funcs, NULL);
977 if (ret)
978 goto err_crtc_init;
980 drm_crtc_helper_add(&dcrtc->crtc, &armada_crtc_helper_funcs);
982 ret = drm_mode_crtc_set_gamma_size(&dcrtc->crtc, 256);
983 if (ret)
984 return ret;
986 drm_crtc_enable_color_mgmt(&dcrtc->crtc, 0, false, 256);
988 return armada_overlay_plane_create(drm, 1 << dcrtc->num);
990 err_crtc_init:
991 primary->funcs->destroy(primary);
992 err_crtc:
993 kfree(dcrtc);
995 return ret;
998 static int
999 armada_lcd_bind(struct device *dev, struct device *master, void *data)
1001 struct platform_device *pdev = to_platform_device(dev);
1002 struct drm_device *drm = data;
1003 struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1004 int irq = platform_get_irq(pdev, 0);
1005 const struct armada_variant *variant;
1006 struct device_node *port = NULL;
1008 if (irq < 0)
1009 return irq;
1011 if (!dev->of_node) {
1012 const struct platform_device_id *id;
1014 id = platform_get_device_id(pdev);
1015 if (!id)
1016 return -ENXIO;
1018 variant = (const struct armada_variant *)id->driver_data;
1019 } else {
1020 const struct of_device_id *match;
1021 struct device_node *np, *parent = dev->of_node;
1023 match = of_match_device(dev->driver->of_match_table, dev);
1024 if (!match)
1025 return -ENXIO;
1027 np = of_get_child_by_name(parent, "ports");
1028 if (np)
1029 parent = np;
1030 port = of_get_child_by_name(parent, "port");
1031 of_node_put(np);
1032 if (!port) {
1033 dev_err(dev, "no port node found in %pOF\n", parent);
1034 return -ENXIO;
1037 variant = match->data;
1040 return armada_drm_crtc_create(drm, dev, res, irq, variant, port);
1043 static void
1044 armada_lcd_unbind(struct device *dev, struct device *master, void *data)
1046 struct armada_crtc *dcrtc = dev_get_drvdata(dev);
1048 armada_drm_crtc_destroy(&dcrtc->crtc);
1051 static const struct component_ops armada_lcd_ops = {
1052 .bind = armada_lcd_bind,
1053 .unbind = armada_lcd_unbind,
1056 static int armada_lcd_probe(struct platform_device *pdev)
1058 return component_add(&pdev->dev, &armada_lcd_ops);
1061 static int armada_lcd_remove(struct platform_device *pdev)
1063 component_del(&pdev->dev, &armada_lcd_ops);
1064 return 0;
1067 static const struct of_device_id armada_lcd_of_match[] = {
1069 .compatible = "marvell,dove-lcd",
1070 .data = &armada510_ops,
1074 MODULE_DEVICE_TABLE(of, armada_lcd_of_match);
1076 static const struct platform_device_id armada_lcd_platform_ids[] = {
1078 .name = "armada-lcd",
1079 .driver_data = (unsigned long)&armada510_ops,
1080 }, {
1081 .name = "armada-510-lcd",
1082 .driver_data = (unsigned long)&armada510_ops,
1084 { },
1086 MODULE_DEVICE_TABLE(platform, armada_lcd_platform_ids);
1088 struct platform_driver armada_lcd_platform_driver = {
1089 .probe = armada_lcd_probe,
1090 .remove = armada_lcd_remove,
1091 .driver = {
1092 .name = "armada-lcd",
1093 .owner = THIS_MODULE,
1094 .of_match_table = armada_lcd_of_match,
1096 .id_table = armada_lcd_platform_ids,