treewide: remove redundant IS_ERR() before error code check
[linux/fpc-iii.git] / drivers / iio / accel / cros_ec_accel_legacy.c
blob65f85faf6f31d3d7f6d02a93dc8469a19b700f91
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3 * Driver for older Chrome OS EC accelerometer
5 * Copyright 2017 Google, Inc
7 * This driver uses the memory mapper cros-ec interface to communicate
8 * with the Chrome OS EC about accelerometer data or older commands.
9 * Accelerometer access is presented through iio sysfs.
12 #include <linux/delay.h>
13 #include <linux/device.h>
14 #include <linux/iio/buffer.h>
15 #include <linux/iio/common/cros_ec_sensors_core.h>
16 #include <linux/iio/iio.h>
17 #include <linux/iio/kfifo_buf.h>
18 #include <linux/iio/trigger_consumer.h>
19 #include <linux/iio/triggered_buffer.h>
20 #include <linux/kernel.h>
21 #include <linux/mfd/cros_ec.h>
22 #include <linux/module.h>
23 #include <linux/slab.h>
24 #include <linux/platform_data/cros_ec_commands.h>
25 #include <linux/platform_data/cros_ec_proto.h>
26 #include <linux/platform_device.h>
28 #define DRV_NAME "cros-ec-accel-legacy"
30 #define CROS_EC_SENSOR_LEGACY_NUM 2
32 * Sensor scale hard coded at 10 bits per g, computed as:
33 * g / (2^10 - 1) = 0.009586168; with g = 9.80665 m.s^-2
35 #define ACCEL_LEGACY_NSCALE 9586168
37 static int cros_ec_accel_legacy_read_cmd(struct iio_dev *indio_dev,
38 unsigned long scan_mask, s16 *data)
40 struct cros_ec_sensors_core_state *st = iio_priv(indio_dev);
41 int ret;
42 unsigned int i;
43 u8 sensor_num;
46 * Read all sensor data through a command.
47 * Save sensor_num, it is assumed to stay.
49 sensor_num = st->param.info.sensor_num;
50 st->param.cmd = MOTIONSENSE_CMD_DUMP;
51 st->param.dump.max_sensor_count = CROS_EC_SENSOR_LEGACY_NUM;
52 ret = cros_ec_motion_send_host_cmd(st,
53 sizeof(st->resp->dump) + CROS_EC_SENSOR_LEGACY_NUM *
54 sizeof(struct ec_response_motion_sensor_data));
55 st->param.info.sensor_num = sensor_num;
56 if (ret != 0) {
57 dev_warn(&indio_dev->dev, "Unable to read sensor data\n");
58 return ret;
61 for_each_set_bit(i, &scan_mask, indio_dev->masklength) {
62 *data = st->resp->dump.sensor[sensor_num].data[i] *
63 st->sign[i];
64 data++;
67 return 0;
70 static int cros_ec_accel_legacy_read(struct iio_dev *indio_dev,
71 struct iio_chan_spec const *chan,
72 int *val, int *val2, long mask)
74 struct cros_ec_sensors_core_state *st = iio_priv(indio_dev);
75 s16 data = 0;
76 int ret;
77 int idx = chan->scan_index;
79 mutex_lock(&st->cmd_lock);
81 switch (mask) {
82 case IIO_CHAN_INFO_RAW:
83 ret = st->read_ec_sensors_data(indio_dev, 1 << idx, &data);
84 if (ret < 0)
85 break;
86 ret = IIO_VAL_INT;
87 *val = data;
88 break;
89 case IIO_CHAN_INFO_SCALE:
90 WARN_ON(st->type != MOTIONSENSE_TYPE_ACCEL);
91 *val = 0;
92 *val2 = ACCEL_LEGACY_NSCALE;
93 ret = IIO_VAL_INT_PLUS_NANO;
94 break;
95 case IIO_CHAN_INFO_CALIBBIAS:
96 /* Calibration not supported. */
97 *val = 0;
98 ret = IIO_VAL_INT;
99 break;
100 default:
101 ret = cros_ec_sensors_core_read(st, chan, val, val2,
102 mask);
103 break;
105 mutex_unlock(&st->cmd_lock);
107 return ret;
110 static int cros_ec_accel_legacy_write(struct iio_dev *indio_dev,
111 struct iio_chan_spec const *chan,
112 int val, int val2, long mask)
115 * Do nothing but don't return an error code to allow calibration
116 * script to work.
118 if (mask == IIO_CHAN_INFO_CALIBBIAS)
119 return 0;
121 return -EINVAL;
124 static const struct iio_info cros_ec_accel_legacy_info = {
125 .read_raw = &cros_ec_accel_legacy_read,
126 .write_raw = &cros_ec_accel_legacy_write,
130 * Present the channel using HTML5 standard:
131 * need to invert X and Y and invert some lid axis.
133 #define CROS_EC_ACCEL_ROTATE_AXIS(_axis) \
134 ((_axis) == CROS_EC_SENSOR_Z ? CROS_EC_SENSOR_Z : \
135 ((_axis) == CROS_EC_SENSOR_X ? CROS_EC_SENSOR_Y : \
136 CROS_EC_SENSOR_X))
138 #define CROS_EC_ACCEL_LEGACY_CHAN(_axis) \
140 .type = IIO_ACCEL, \
141 .channel2 = IIO_MOD_X + (_axis), \
142 .modified = 1, \
143 .info_mask_separate = \
144 BIT(IIO_CHAN_INFO_RAW) | \
145 BIT(IIO_CHAN_INFO_CALIBBIAS), \
146 .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SCALE), \
147 .ext_info = cros_ec_sensors_ext_info, \
148 .scan_type = { \
149 .sign = 's', \
150 .realbits = CROS_EC_SENSOR_BITS, \
151 .storagebits = CROS_EC_SENSOR_BITS, \
152 }, \
153 .scan_index = CROS_EC_ACCEL_ROTATE_AXIS(_axis), \
156 static const struct iio_chan_spec cros_ec_accel_legacy_channels[] = {
157 CROS_EC_ACCEL_LEGACY_CHAN(CROS_EC_SENSOR_X),
158 CROS_EC_ACCEL_LEGACY_CHAN(CROS_EC_SENSOR_Y),
159 CROS_EC_ACCEL_LEGACY_CHAN(CROS_EC_SENSOR_Z),
160 IIO_CHAN_SOFT_TIMESTAMP(CROS_EC_SENSOR_MAX_AXIS)
163 static int cros_ec_accel_legacy_probe(struct platform_device *pdev)
165 struct device *dev = &pdev->dev;
166 struct iio_dev *indio_dev;
167 struct cros_ec_sensors_core_state *state;
168 int ret;
170 indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*state));
171 if (!indio_dev)
172 return -ENOMEM;
174 ret = cros_ec_sensors_core_init(pdev, indio_dev, true);
175 if (ret)
176 return ret;
178 indio_dev->info = &cros_ec_accel_legacy_info;
179 state = iio_priv(indio_dev);
181 if (state->ec->cmd_readmem != NULL)
182 state->read_ec_sensors_data = cros_ec_sensors_read_lpc;
183 else
184 state->read_ec_sensors_data = cros_ec_accel_legacy_read_cmd;
186 indio_dev->channels = cros_ec_accel_legacy_channels;
187 indio_dev->num_channels = ARRAY_SIZE(cros_ec_accel_legacy_channels);
188 /* The lid sensor needs to be presented inverted. */
189 if (state->loc == MOTIONSENSE_LOC_LID) {
190 state->sign[CROS_EC_SENSOR_X] = -1;
191 state->sign[CROS_EC_SENSOR_Z] = -1;
194 ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
195 cros_ec_sensors_capture, NULL);
196 if (ret)
197 return ret;
199 return devm_iio_device_register(dev, indio_dev);
202 static struct platform_driver cros_ec_accel_platform_driver = {
203 .driver = {
204 .name = DRV_NAME,
206 .probe = cros_ec_accel_legacy_probe,
208 module_platform_driver(cros_ec_accel_platform_driver);
210 MODULE_DESCRIPTION("ChromeOS EC legacy accelerometer driver");
211 MODULE_AUTHOR("Gwendal Grignou <gwendal@chromium.org>");
212 MODULE_LICENSE("GPL v2");
213 MODULE_ALIAS("platform:" DRV_NAME);