treewide: remove redundant IS_ERR() before error code check
[linux/fpc-iii.git] / drivers / memory / da8xx-ddrctl.c
blobe8f9b3f461f5b151f971525665ec57254cc56b81
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3 * TI da8xx DDR2/mDDR controller driver
5 * Copyright (C) 2016 BayLibre SAS
7 * Author:
8 * Bartosz Golaszewski <bgolaszewski@baylibre.com>
9 */
11 #include <linux/module.h>
12 #include <linux/of.h>
13 #include <linux/of_device.h>
14 #include <linux/platform_device.h>
15 #include <linux/io.h>
18 * REVISIT: Linux doesn't have a good framework for the kind of performance
19 * knobs this driver controls. We can't use device tree properties as it deals
20 * with hardware configuration rather than description. We also don't want to
21 * commit to maintaining some random sysfs attributes.
23 * For now we just hardcode the register values for the boards that need
24 * some changes (as is the case for the LCD controller on da850-lcdk - the
25 * first board we support here). When linux gets an appropriate framework,
26 * we'll easily convert the driver to it.
29 struct da8xx_ddrctl_config_knob {
30 const char *name;
31 u32 reg;
32 u32 mask;
33 u32 shift;
36 static const struct da8xx_ddrctl_config_knob da8xx_ddrctl_knobs[] = {
38 .name = "da850-pbbpr",
39 .reg = 0x20,
40 .mask = 0xffffff00,
41 .shift = 0,
45 struct da8xx_ddrctl_setting {
46 const char *name;
47 u32 val;
50 struct da8xx_ddrctl_board_settings {
51 const char *board;
52 const struct da8xx_ddrctl_setting *settings;
55 static const struct da8xx_ddrctl_setting da850_lcdk_ddrctl_settings[] = {
57 .name = "da850-pbbpr",
58 .val = 0x20,
60 { }
63 static const struct da8xx_ddrctl_board_settings da8xx_ddrctl_board_confs[] = {
65 .board = "ti,da850-lcdk",
66 .settings = da850_lcdk_ddrctl_settings,
70 static const struct da8xx_ddrctl_config_knob *
71 da8xx_ddrctl_match_knob(const struct da8xx_ddrctl_setting *setting)
73 const struct da8xx_ddrctl_config_knob *knob;
74 int i;
76 for (i = 0; i < ARRAY_SIZE(da8xx_ddrctl_knobs); i++) {
77 knob = &da8xx_ddrctl_knobs[i];
79 if (strcmp(knob->name, setting->name) == 0)
80 return knob;
83 return NULL;
86 static const struct da8xx_ddrctl_setting *da8xx_ddrctl_get_board_settings(void)
88 const struct da8xx_ddrctl_board_settings *board_settings;
89 int i;
91 for (i = 0; i < ARRAY_SIZE(da8xx_ddrctl_board_confs); i++) {
92 board_settings = &da8xx_ddrctl_board_confs[i];
94 if (of_machine_is_compatible(board_settings->board))
95 return board_settings->settings;
98 return NULL;
101 static int da8xx_ddrctl_probe(struct platform_device *pdev)
103 const struct da8xx_ddrctl_config_knob *knob;
104 const struct da8xx_ddrctl_setting *setting;
105 struct device_node *node;
106 struct resource *res;
107 void __iomem *ddrctl;
108 struct device *dev;
109 u32 reg;
111 dev = &pdev->dev;
112 node = dev->of_node;
114 setting = da8xx_ddrctl_get_board_settings();
115 if (!setting) {
116 dev_err(dev, "no settings defined for this board\n");
117 return -EINVAL;
120 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
121 ddrctl = devm_ioremap_resource(dev, res);
122 if (IS_ERR(ddrctl)) {
123 dev_err(dev, "unable to map memory controller registers\n");
124 return PTR_ERR(ddrctl);
127 for (; setting->name; setting++) {
128 knob = da8xx_ddrctl_match_knob(setting);
129 if (!knob) {
130 dev_warn(dev,
131 "no such config option: %s\n", setting->name);
132 continue;
135 if (knob->reg + sizeof(u32) > resource_size(res)) {
136 dev_warn(dev,
137 "register offset of '%s' exceeds mapped memory size\n",
138 knob->name);
139 continue;
142 reg = readl(ddrctl + knob->reg);
143 reg &= knob->mask;
144 reg |= setting->val << knob->shift;
146 dev_dbg(dev, "writing 0x%08x to %s\n", reg, setting->name);
148 writel(reg, ddrctl + knob->reg);
151 return 0;
154 static const struct of_device_id da8xx_ddrctl_of_match[] = {
155 { .compatible = "ti,da850-ddr-controller", },
156 { },
159 static struct platform_driver da8xx_ddrctl_driver = {
160 .probe = da8xx_ddrctl_probe,
161 .driver = {
162 .name = "da850-ddr-controller",
163 .of_match_table = da8xx_ddrctl_of_match,
166 module_platform_driver(da8xx_ddrctl_driver);
168 MODULE_AUTHOR("Bartosz Golaszewski <bgolaszewski@baylibre.com>");
169 MODULE_DESCRIPTION("TI da8xx DDR2/mDDR controller driver");
170 MODULE_LICENSE("GPL v2");