2 * file for managing the edac_device subsystem of devices for EDAC
4 * (C) 2007 SoftwareBitMaker
6 * This file may be distributed under the terms of the
7 * GNU General Public License.
9 * Written Doug Thompson <norsk5@xmission.com>
13 #include <linux/ctype.h>
14 #include <linux/module.h>
15 #include <linux/slab.h>
16 #include <linux/edac.h>
18 #include "edac_device.h"
19 #include "edac_module.h"
21 #define EDAC_DEVICE_SYMLINK "device"
23 #define to_edacdev(k) container_of(k, struct edac_device_ctl_info, kobj)
24 #define to_edacdev_attr(a) container_of(a, struct edacdev_attribute, attr)
28 * Set of edac_device_ctl_info attribute store/show functions
32 static ssize_t
edac_device_ctl_log_ue_show(struct edac_device_ctl_info
33 *ctl_info
, char *data
)
35 return sprintf(data
, "%u\n", ctl_info
->log_ue
);
38 static ssize_t
edac_device_ctl_log_ue_store(struct edac_device_ctl_info
39 *ctl_info
, const char *data
,
42 /* if parameter is zero, turn off flag, if non-zero turn on flag */
43 ctl_info
->log_ue
= (simple_strtoul(data
, NULL
, 0) != 0);
49 static ssize_t
edac_device_ctl_log_ce_show(struct edac_device_ctl_info
50 *ctl_info
, char *data
)
52 return sprintf(data
, "%u\n", ctl_info
->log_ce
);
55 static ssize_t
edac_device_ctl_log_ce_store(struct edac_device_ctl_info
56 *ctl_info
, const char *data
,
59 /* if parameter is zero, turn off flag, if non-zero turn on flag */
60 ctl_info
->log_ce
= (simple_strtoul(data
, NULL
, 0) != 0);
66 static ssize_t
edac_device_ctl_panic_on_ue_show(struct edac_device_ctl_info
67 *ctl_info
, char *data
)
69 return sprintf(data
, "%u\n", ctl_info
->panic_on_ue
);
72 static ssize_t
edac_device_ctl_panic_on_ue_store(struct edac_device_ctl_info
73 *ctl_info
, const char *data
,
76 /* if parameter is zero, turn off flag, if non-zero turn on flag */
77 ctl_info
->panic_on_ue
= (simple_strtoul(data
, NULL
, 0) != 0);
82 /* 'poll_msec' show and store functions*/
83 static ssize_t
edac_device_ctl_poll_msec_show(struct edac_device_ctl_info
84 *ctl_info
, char *data
)
86 return sprintf(data
, "%u\n", ctl_info
->poll_msec
);
89 static ssize_t
edac_device_ctl_poll_msec_store(struct edac_device_ctl_info
90 *ctl_info
, const char *data
,
95 /* get the value and enforce that it is non-zero, must be at least
96 * one millisecond for the delay period, between scans
97 * Then cancel last outstanding delay for the work request
100 value
= simple_strtoul(data
, NULL
, 0);
101 edac_device_reset_delay_period(ctl_info
, value
);
106 /* edac_device_ctl_info specific attribute structure */
107 struct ctl_info_attribute
{
108 struct attribute attr
;
109 ssize_t(*show
) (struct edac_device_ctl_info
*, char *);
110 ssize_t(*store
) (struct edac_device_ctl_info
*, const char *, size_t);
113 #define to_ctl_info(k) container_of(k, struct edac_device_ctl_info, kobj)
114 #define to_ctl_info_attr(a) container_of(a,struct ctl_info_attribute,attr)
116 /* Function to 'show' fields from the edac_dev 'ctl_info' structure */
117 static ssize_t
edac_dev_ctl_info_show(struct kobject
*kobj
,
118 struct attribute
*attr
, char *buffer
)
120 struct edac_device_ctl_info
*edac_dev
= to_ctl_info(kobj
);
121 struct ctl_info_attribute
*ctl_info_attr
= to_ctl_info_attr(attr
);
123 if (ctl_info_attr
->show
)
124 return ctl_info_attr
->show(edac_dev
, buffer
);
128 /* Function to 'store' fields into the edac_dev 'ctl_info' structure */
129 static ssize_t
edac_dev_ctl_info_store(struct kobject
*kobj
,
130 struct attribute
*attr
,
131 const char *buffer
, size_t count
)
133 struct edac_device_ctl_info
*edac_dev
= to_ctl_info(kobj
);
134 struct ctl_info_attribute
*ctl_info_attr
= to_ctl_info_attr(attr
);
136 if (ctl_info_attr
->store
)
137 return ctl_info_attr
->store(edac_dev
, buffer
, count
);
141 /* edac_dev file operations for an 'ctl_info' */
142 static const struct sysfs_ops device_ctl_info_ops
= {
143 .show
= edac_dev_ctl_info_show
,
144 .store
= edac_dev_ctl_info_store
147 #define CTL_INFO_ATTR(_name,_mode,_show,_store) \
148 static struct ctl_info_attribute attr_ctl_info_##_name = { \
149 .attr = {.name = __stringify(_name), .mode = _mode }, \
154 /* Declare the various ctl_info attributes here and their respective ops */
155 CTL_INFO_ATTR(log_ue
, S_IRUGO
| S_IWUSR
,
156 edac_device_ctl_log_ue_show
, edac_device_ctl_log_ue_store
);
157 CTL_INFO_ATTR(log_ce
, S_IRUGO
| S_IWUSR
,
158 edac_device_ctl_log_ce_show
, edac_device_ctl_log_ce_store
);
159 CTL_INFO_ATTR(panic_on_ue
, S_IRUGO
| S_IWUSR
,
160 edac_device_ctl_panic_on_ue_show
,
161 edac_device_ctl_panic_on_ue_store
);
162 CTL_INFO_ATTR(poll_msec
, S_IRUGO
| S_IWUSR
,
163 edac_device_ctl_poll_msec_show
, edac_device_ctl_poll_msec_store
);
165 /* Base Attributes of the EDAC_DEVICE ECC object */
166 static struct ctl_info_attribute
*device_ctrl_attr
[] = {
167 &attr_ctl_info_panic_on_ue
,
168 &attr_ctl_info_log_ue
,
169 &attr_ctl_info_log_ce
,
170 &attr_ctl_info_poll_msec
,
175 * edac_device_ctrl_master_release
177 * called when the reference count for the 'main' kobj
178 * for a edac_device control struct reaches zero
180 * Reference count model:
181 * One 'main' kobject for each control structure allocated.
182 * That main kobj is initially set to one AND
183 * the reference count for the EDAC 'core' module is
184 * bumped by one, thus added 'keep in memory' dependency.
186 * Each new internal kobj (in instances and blocks) then
187 * bumps the 'main' kobject.
189 * When they are released their release functions decrement
192 * When the main kobj reaches zero (0) then THIS function
193 * is called which then decrements the EDAC 'core' module.
194 * When the module reference count reaches zero then the
195 * module no longer has dependency on keeping the release
196 * function code in memory and module can be unloaded.
198 * This will support several control objects as well, each
199 * with its own 'main' kobj.
201 static void edac_device_ctrl_master_release(struct kobject
*kobj
)
203 struct edac_device_ctl_info
*edac_dev
= to_edacdev(kobj
);
205 edac_dbg(4, "control index=%d\n", edac_dev
->dev_idx
);
207 /* decrement the EDAC CORE module ref count */
208 module_put(edac_dev
->owner
);
210 /* free the control struct containing the 'main' kobj
211 * passed in to this routine
216 /* ktype for the main (master) kobject */
217 static struct kobj_type ktype_device_ctrl
= {
218 .release
= edac_device_ctrl_master_release
,
219 .sysfs_ops
= &device_ctl_info_ops
,
220 .default_attrs
= (struct attribute
**)device_ctrl_attr
,
224 * edac_device_register_sysfs_main_kobj
226 * perform the high level setup for the new edac_device instance
231 int edac_device_register_sysfs_main_kobj(struct edac_device_ctl_info
*edac_dev
)
233 struct bus_type
*edac_subsys
;
238 /* get the /sys/devices/system/edac reference */
239 edac_subsys
= edac_get_sysfs_subsys();
241 /* Point to the 'edac_subsys' this instance 'reports' to */
242 edac_dev
->edac_subsys
= edac_subsys
;
244 /* Init the devices's kobject */
245 memset(&edac_dev
->kobj
, 0, sizeof(struct kobject
));
247 /* Record which module 'owns' this control structure
248 * and bump the ref count of the module
250 edac_dev
->owner
= THIS_MODULE
;
252 if (!try_module_get(edac_dev
->owner
)) {
258 err
= kobject_init_and_add(&edac_dev
->kobj
, &ktype_device_ctrl
,
259 &edac_subsys
->dev_root
->kobj
,
260 "%s", edac_dev
->name
);
262 edac_dbg(1, "Failed to register '.../edac/%s'\n",
266 kobject_uevent(&edac_dev
->kobj
, KOBJ_ADD
);
268 /* At this point, to 'free' the control struct,
269 * edac_device_unregister_sysfs_main_kobj() must be used
272 edac_dbg(4, "Registered '.../edac/%s' kobject\n", edac_dev
->name
);
276 /* Error exit stack */
278 module_put(edac_dev
->owner
);
285 * edac_device_unregister_sysfs_main_kobj:
286 * the '..../edac/<name>' kobject
288 void edac_device_unregister_sysfs_main_kobj(struct edac_device_ctl_info
*dev
)
291 edac_dbg(4, "name of kobject is: %s\n", kobject_name(&dev
->kobj
));
294 * Unregister the edac device's kobject and
295 * allow for reference count to reach 0 at which point
296 * the callback will be called to:
297 * a) module_put() this module
298 * b) 'kfree' the memory
300 kobject_put(&dev
->kobj
);
303 /* edac_dev -> instance information */
306 * Set of low-level instance attribute show functions
308 static ssize_t
instance_ue_count_show(struct edac_device_instance
*instance
,
311 return sprintf(data
, "%u\n", instance
->counters
.ue_count
);
314 static ssize_t
instance_ce_count_show(struct edac_device_instance
*instance
,
317 return sprintf(data
, "%u\n", instance
->counters
.ce_count
);
320 #define to_instance(k) container_of(k, struct edac_device_instance, kobj)
321 #define to_instance_attr(a) container_of(a,struct instance_attribute,attr)
323 /* DEVICE instance kobject release() function */
324 static void edac_device_ctrl_instance_release(struct kobject
*kobj
)
326 struct edac_device_instance
*instance
;
330 /* map from this kobj to the main control struct
331 * and then dec the main kobj count
333 instance
= to_instance(kobj
);
334 kobject_put(&instance
->ctl
->kobj
);
337 /* instance specific attribute structure */
338 struct instance_attribute
{
339 struct attribute attr
;
340 ssize_t(*show
) (struct edac_device_instance
*, char *);
341 ssize_t(*store
) (struct edac_device_instance
*, const char *, size_t);
344 /* Function to 'show' fields from the edac_dev 'instance' structure */
345 static ssize_t
edac_dev_instance_show(struct kobject
*kobj
,
346 struct attribute
*attr
, char *buffer
)
348 struct edac_device_instance
*instance
= to_instance(kobj
);
349 struct instance_attribute
*instance_attr
= to_instance_attr(attr
);
351 if (instance_attr
->show
)
352 return instance_attr
->show(instance
, buffer
);
356 /* Function to 'store' fields into the edac_dev 'instance' structure */
357 static ssize_t
edac_dev_instance_store(struct kobject
*kobj
,
358 struct attribute
*attr
,
359 const char *buffer
, size_t count
)
361 struct edac_device_instance
*instance
= to_instance(kobj
);
362 struct instance_attribute
*instance_attr
= to_instance_attr(attr
);
364 if (instance_attr
->store
)
365 return instance_attr
->store(instance
, buffer
, count
);
369 /* edac_dev file operations for an 'instance' */
370 static const struct sysfs_ops device_instance_ops
= {
371 .show
= edac_dev_instance_show
,
372 .store
= edac_dev_instance_store
375 #define INSTANCE_ATTR(_name,_mode,_show,_store) \
376 static struct instance_attribute attr_instance_##_name = { \
377 .attr = {.name = __stringify(_name), .mode = _mode }, \
383 * Define attributes visible for the edac_device instance object
384 * Each contains a pointer to a show and an optional set
385 * function pointer that does the low level output/input
387 INSTANCE_ATTR(ce_count
, S_IRUGO
, instance_ce_count_show
, NULL
);
388 INSTANCE_ATTR(ue_count
, S_IRUGO
, instance_ue_count_show
, NULL
);
390 /* list of edac_dev 'instance' attributes */
391 static struct instance_attribute
*device_instance_attr
[] = {
392 &attr_instance_ce_count
,
393 &attr_instance_ue_count
,
397 /* The 'ktype' for each edac_dev 'instance' */
398 static struct kobj_type ktype_instance_ctrl
= {
399 .release
= edac_device_ctrl_instance_release
,
400 .sysfs_ops
= &device_instance_ops
,
401 .default_attrs
= (struct attribute
**)device_instance_attr
,
404 /* edac_dev -> instance -> block information */
406 #define to_block(k) container_of(k, struct edac_device_block, kobj)
407 #define to_block_attr(a) \
408 container_of(a, struct edac_dev_sysfs_block_attribute, attr)
411 * Set of low-level block attribute show functions
413 static ssize_t
block_ue_count_show(struct kobject
*kobj
,
414 struct attribute
*attr
, char *data
)
416 struct edac_device_block
*block
= to_block(kobj
);
418 return sprintf(data
, "%u\n", block
->counters
.ue_count
);
421 static ssize_t
block_ce_count_show(struct kobject
*kobj
,
422 struct attribute
*attr
, char *data
)
424 struct edac_device_block
*block
= to_block(kobj
);
426 return sprintf(data
, "%u\n", block
->counters
.ce_count
);
429 /* DEVICE block kobject release() function */
430 static void edac_device_ctrl_block_release(struct kobject
*kobj
)
432 struct edac_device_block
*block
;
436 /* get the container of the kobj */
437 block
= to_block(kobj
);
439 /* map from 'block kobj' to 'block->instance->controller->main_kobj'
440 * now 'release' the block kobject
442 kobject_put(&block
->instance
->ctl
->kobj
);
446 /* Function to 'show' fields from the edac_dev 'block' structure */
447 static ssize_t
edac_dev_block_show(struct kobject
*kobj
,
448 struct attribute
*attr
, char *buffer
)
450 struct edac_dev_sysfs_block_attribute
*block_attr
=
453 if (block_attr
->show
)
454 return block_attr
->show(kobj
, attr
, buffer
);
458 /* Function to 'store' fields into the edac_dev 'block' structure */
459 static ssize_t
edac_dev_block_store(struct kobject
*kobj
,
460 struct attribute
*attr
,
461 const char *buffer
, size_t count
)
463 struct edac_dev_sysfs_block_attribute
*block_attr
;
465 block_attr
= to_block_attr(attr
);
467 if (block_attr
->store
)
468 return block_attr
->store(kobj
, attr
, buffer
, count
);
472 /* edac_dev file operations for a 'block' */
473 static const struct sysfs_ops device_block_ops
= {
474 .show
= edac_dev_block_show
,
475 .store
= edac_dev_block_store
478 #define BLOCK_ATTR(_name,_mode,_show,_store) \
479 static struct edac_dev_sysfs_block_attribute attr_block_##_name = { \
480 .attr = {.name = __stringify(_name), .mode = _mode }, \
485 BLOCK_ATTR(ce_count
, S_IRUGO
, block_ce_count_show
, NULL
);
486 BLOCK_ATTR(ue_count
, S_IRUGO
, block_ue_count_show
, NULL
);
488 /* list of edac_dev 'block' attributes */
489 static struct edac_dev_sysfs_block_attribute
*device_block_attr
[] = {
490 &attr_block_ce_count
,
491 &attr_block_ue_count
,
495 /* The 'ktype' for each edac_dev 'block' */
496 static struct kobj_type ktype_block_ctrl
= {
497 .release
= edac_device_ctrl_block_release
,
498 .sysfs_ops
= &device_block_ops
,
499 .default_attrs
= (struct attribute
**)device_block_attr
,
502 /* block ctor/dtor code */
505 * edac_device_create_block
507 static int edac_device_create_block(struct edac_device_ctl_info
*edac_dev
,
508 struct edac_device_instance
*instance
,
509 struct edac_device_block
*block
)
513 struct edac_dev_sysfs_block_attribute
*sysfs_attrib
;
514 struct kobject
*main_kobj
;
516 edac_dbg(4, "Instance '%s' inst_p=%p block '%s' block_p=%p\n",
517 instance
->name
, instance
, block
->name
, block
);
518 edac_dbg(4, "block kobj=%p block kobj->parent=%p\n",
519 &block
->kobj
, &block
->kobj
.parent
);
521 /* init this block's kobject */
522 memset(&block
->kobj
, 0, sizeof(struct kobject
));
524 /* bump the main kobject's reference count for this controller
525 * and this instance is dependent on the main
527 main_kobj
= kobject_get(&edac_dev
->kobj
);
533 /* Add this block's kobject */
534 err
= kobject_init_and_add(&block
->kobj
, &ktype_block_ctrl
,
538 edac_dbg(1, "Failed to register instance '%s'\n", block
->name
);
539 kobject_put(main_kobj
);
544 /* If there are driver level block attributes, then added them
545 * to the block kobject
547 sysfs_attrib
= block
->block_attributes
;
548 if (sysfs_attrib
&& block
->nr_attribs
) {
549 for (i
= 0; i
< block
->nr_attribs
; i
++, sysfs_attrib
++) {
551 edac_dbg(4, "creating block attrib='%s' attrib->%p to kobj=%p\n",
552 sysfs_attrib
->attr
.name
,
553 sysfs_attrib
, &block
->kobj
);
555 /* Create each block_attribute file */
556 err
= sysfs_create_file(&block
->kobj
,
557 &sysfs_attrib
->attr
);
562 kobject_uevent(&block
->kobj
, KOBJ_ADD
);
566 /* Error unwind stack */
568 kobject_put(&block
->kobj
);
575 * edac_device_delete_block(edac_dev,block);
577 static void edac_device_delete_block(struct edac_device_ctl_info
*edac_dev
,
578 struct edac_device_block
*block
)
580 struct edac_dev_sysfs_block_attribute
*sysfs_attrib
;
583 /* if this block has 'attributes' then we need to iterate over the list
584 * and 'remove' the attributes on this block
586 sysfs_attrib
= block
->block_attributes
;
587 if (sysfs_attrib
&& block
->nr_attribs
) {
588 for (i
= 0; i
< block
->nr_attribs
; i
++, sysfs_attrib
++) {
590 /* remove each block_attrib file */
591 sysfs_remove_file(&block
->kobj
,
592 (struct attribute
*) sysfs_attrib
);
596 /* unregister this block's kobject, SEE:
597 * edac_device_ctrl_block_release() callback operation
599 kobject_put(&block
->kobj
);
602 /* instance ctor/dtor code */
605 * edac_device_create_instance
606 * create just one instance of an edac_device 'instance'
608 static int edac_device_create_instance(struct edac_device_ctl_info
*edac_dev
,
613 struct edac_device_instance
*instance
;
614 struct kobject
*main_kobj
;
616 instance
= &edac_dev
->instances
[idx
];
618 /* Init the instance's kobject */
619 memset(&instance
->kobj
, 0, sizeof(struct kobject
));
621 instance
->ctl
= edac_dev
;
623 /* bump the main kobject's reference count for this controller
624 * and this instance is dependent on the main
626 main_kobj
= kobject_get(&edac_dev
->kobj
);
632 /* Formally register this instance's kobject under the edac_device */
633 err
= kobject_init_and_add(&instance
->kobj
, &ktype_instance_ctrl
,
634 &edac_dev
->kobj
, "%s", instance
->name
);
636 edac_dbg(2, "Failed to register instance '%s'\n",
638 kobject_put(main_kobj
);
642 edac_dbg(4, "now register '%d' blocks for instance %d\n",
643 instance
->nr_blocks
, idx
);
645 /* register all blocks of this instance */
646 for (i
= 0; i
< instance
->nr_blocks
; i
++) {
647 err
= edac_device_create_block(edac_dev
, instance
,
648 &instance
->blocks
[i
]);
650 /* If any fail, remove all previous ones */
651 for (j
= 0; j
< i
; j
++)
652 edac_device_delete_block(edac_dev
,
653 &instance
->blocks
[j
]);
654 goto err_release_instance_kobj
;
657 kobject_uevent(&instance
->kobj
, KOBJ_ADD
);
659 edac_dbg(4, "Registered instance %d '%s' kobject\n",
660 idx
, instance
->name
);
664 /* error unwind stack */
665 err_release_instance_kobj
:
666 kobject_put(&instance
->kobj
);
673 * edac_device_remove_instance
674 * remove an edac_device instance
676 static void edac_device_delete_instance(struct edac_device_ctl_info
*edac_dev
,
679 struct edac_device_instance
*instance
;
682 instance
= &edac_dev
->instances
[idx
];
684 /* unregister all blocks in this instance */
685 for (i
= 0; i
< instance
->nr_blocks
; i
++)
686 edac_device_delete_block(edac_dev
, &instance
->blocks
[i
]);
688 /* unregister this instance's kobject, SEE:
689 * edac_device_ctrl_instance_release() for callback operation
691 kobject_put(&instance
->kobj
);
695 * edac_device_create_instances
696 * create the first level of 'instances' for this device
697 * (ie 'cache' might have 'cache0', 'cache1', 'cache2', etc
699 static int edac_device_create_instances(struct edac_device_ctl_info
*edac_dev
)
706 /* iterate over creation of the instances */
707 for (i
= 0; i
< edac_dev
->nr_instances
; i
++) {
708 err
= edac_device_create_instance(edac_dev
, i
);
710 /* unwind previous instances on error */
711 for (j
= 0; j
< i
; j
++)
712 edac_device_delete_instance(edac_dev
, j
);
721 * edac_device_delete_instances(edac_dev);
722 * unregister all the kobjects of the instances
724 static void edac_device_delete_instances(struct edac_device_ctl_info
*edac_dev
)
728 /* iterate over creation of the instances */
729 for (i
= 0; i
< edac_dev
->nr_instances
; i
++)
730 edac_device_delete_instance(edac_dev
, i
);
733 /* edac_dev sysfs ctor/dtor code */
736 * edac_device_add_main_sysfs_attributes
737 * add some attributes to this instance's main kobject
739 static int edac_device_add_main_sysfs_attributes(
740 struct edac_device_ctl_info
*edac_dev
)
742 struct edac_dev_sysfs_attribute
*sysfs_attrib
;
745 sysfs_attrib
= edac_dev
->sysfs_attributes
;
747 /* iterate over the array and create an attribute for each
750 while (sysfs_attrib
->attr
.name
!= NULL
) {
751 err
= sysfs_create_file(&edac_dev
->kobj
,
752 (struct attribute
*) sysfs_attrib
);
765 * edac_device_remove_main_sysfs_attributes
766 * remove any attributes to this instance's main kobject
768 static void edac_device_remove_main_sysfs_attributes(
769 struct edac_device_ctl_info
*edac_dev
)
771 struct edac_dev_sysfs_attribute
*sysfs_attrib
;
773 /* if there are main attributes, defined, remove them. First,
774 * point to the start of the array and iterate over it
775 * removing each attribute listed from this device's instance's kobject
777 sysfs_attrib
= edac_dev
->sysfs_attributes
;
779 while (sysfs_attrib
->attr
.name
!= NULL
) {
780 sysfs_remove_file(&edac_dev
->kobj
,
781 (struct attribute
*) sysfs_attrib
);
788 * edac_device_create_sysfs() Constructor
790 * accept a created edac_device control structure
791 * and 'export' it to sysfs. The 'main' kobj should already have been
792 * created. 'instance' and 'block' kobjects should be registered
793 * along with any 'block' attributes from the low driver. In addition,
794 * the main attributes (if any) are connected to the main kobject of
795 * the control structure.
801 int edac_device_create_sysfs(struct edac_device_ctl_info
*edac_dev
)
804 struct kobject
*edac_kobj
= &edac_dev
->kobj
;
806 edac_dbg(0, "idx=%d\n", edac_dev
->dev_idx
);
808 /* go create any main attributes callers wants */
809 err
= edac_device_add_main_sysfs_attributes(edac_dev
);
811 edac_dbg(0, "failed to add sysfs attribs\n");
815 /* create a symlink from the edac device
816 * to the platform 'device' being used for this
818 err
= sysfs_create_link(edac_kobj
,
819 &edac_dev
->dev
->kobj
, EDAC_DEVICE_SYMLINK
);
821 edac_dbg(0, "sysfs_create_link() returned err= %d\n", err
);
822 goto err_remove_main_attribs
;
825 /* Create the first level instance directories
826 * In turn, the nested blocks beneath the instances will
827 * be registered as well
829 err
= edac_device_create_instances(edac_dev
);
831 edac_dbg(0, "edac_device_create_instances() returned err= %d\n",
833 goto err_remove_link
;
837 edac_dbg(4, "create-instances done, idx=%d\n", edac_dev
->dev_idx
);
841 /* Error unwind stack */
843 /* remove the sym link */
844 sysfs_remove_link(&edac_dev
->kobj
, EDAC_DEVICE_SYMLINK
);
846 err_remove_main_attribs
:
847 edac_device_remove_main_sysfs_attributes(edac_dev
);
854 * edac_device_remove_sysfs() destructor
856 * given an edac_device struct, tear down the kobject resources
858 void edac_device_remove_sysfs(struct edac_device_ctl_info
*edac_dev
)
862 /* remove any main attributes for this device */
863 edac_device_remove_main_sysfs_attributes(edac_dev
);
865 /* remove the device sym link */
866 sysfs_remove_link(&edac_dev
->kobj
, EDAC_DEVICE_SYMLINK
);
868 /* walk the instance/block kobject tree, deconstructing it */
869 edac_device_delete_instances(edac_dev
);