2 * Copyright © 2013 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24 * Brad Volkin <bradley.d.volkin@intel.com>
29 #include "intel_ringbuffer.h"
32 * DOC: batch buffer command parser
35 * Certain OpenGL features (e.g. transform feedback, performance monitoring)
36 * require userspace code to submit batches containing commands such as
37 * MI_LOAD_REGISTER_IMM to access various registers. Unfortunately, some
38 * generations of the hardware will noop these commands in "unsecure" batches
39 * (which includes all userspace batches submitted via i915) even though the
40 * commands may be safe and represent the intended programming model of the
43 * The software command parser is similar in operation to the command parsing
44 * done in hardware for unsecure batches. However, the software parser allows
45 * some operations that would be noop'd by hardware, if the parser determines
46 * the operation is safe, and submits the batch as "secure" to prevent hardware
50 * At a high level, the hardware (and software) checks attempt to prevent
51 * granting userspace undue privileges. There are three categories of privilege.
53 * First, commands which are explicitly defined as privileged or which should
54 * only be used by the kernel driver. The parser generally rejects such
55 * commands, though it may allow some from the drm master process.
57 * Second, commands which access registers. To support correct/enhanced
58 * userspace functionality, particularly certain OpenGL extensions, the parser
59 * provides a whitelist of registers which userspace may safely access (for both
60 * normal and drm master processes).
62 * Third, commands which access privileged memory (i.e. GGTT, HWS page, etc).
63 * The parser always rejects such commands.
65 * The majority of the problematic commands fall in the MI_* range, with only a
66 * few specific commands on each engine (e.g. PIPE_CONTROL and MI_FLUSH_DW).
69 * Each engine maintains tables of commands and registers which the parser
70 * uses in scanning batch buffers submitted to that engine.
72 * Since the set of commands that the parser must check for is significantly
73 * smaller than the number of commands supported, the parser tables contain only
74 * those commands required by the parser. This generally works because command
75 * opcode ranges have standard command length encodings. So for commands that
76 * the parser does not need to check, it can easily skip them. This is
77 * implemented via a per-engine length decoding vfunc.
79 * Unfortunately, there are a number of commands that do not follow the standard
80 * length encoding for their opcode range, primarily amongst the MI_* commands.
81 * To handle this, the parser provides a way to define explicit "skip" entries
82 * in the per-engine command tables.
84 * Other command table entries map fairly directly to high level categories
85 * mentioned above: rejected, master-only, register whitelist. The parser
86 * implements a number of checks, including the privileged memory checks, via a
87 * general bitmasking mechanism.
91 * A command that requires special handling by the command parser.
93 struct drm_i915_cmd_descriptor
{
95 * Flags describing how the command parser processes the command.
97 * CMD_DESC_FIXED: The command has a fixed length if this is set,
98 * a length mask if not set
99 * CMD_DESC_SKIP: The command is allowed but does not follow the
100 * standard length encoding for the opcode range in
102 * CMD_DESC_REJECT: The command is never allowed
103 * CMD_DESC_REGISTER: The command should be checked against the
104 * register whitelist for the appropriate ring
105 * CMD_DESC_MASTER: The command is allowed if the submitting process
109 #define CMD_DESC_FIXED (1<<0)
110 #define CMD_DESC_SKIP (1<<1)
111 #define CMD_DESC_REJECT (1<<2)
112 #define CMD_DESC_REGISTER (1<<3)
113 #define CMD_DESC_BITMASK (1<<4)
114 #define CMD_DESC_MASTER (1<<5)
117 * The command's unique identification bits and the bitmask to get them.
118 * This isn't strictly the opcode field as defined in the spec and may
119 * also include type, subtype, and/or subop fields.
127 * The command's length. The command is either fixed length (i.e. does
128 * not include a length field) or has a length field mask. The flag
129 * CMD_DESC_FIXED indicates a fixed length. Otherwise, the command has
130 * a length mask. All command entries in a command table must include
131 * length information.
139 * Describes where to find a register address in the command to check
140 * against the ring's register whitelist. Only valid if flags has the
141 * CMD_DESC_REGISTER bit set.
143 * A non-zero step value implies that the command may access multiple
144 * registers in sequence (e.g. LRI), in that case step gives the
145 * distance in dwords between individual offset fields.
153 #define MAX_CMD_DESC_BITMASKS 3
155 * Describes command checks where a particular dword is masked and
156 * compared against an expected value. If the command does not match
157 * the expected value, the parser rejects it. Only valid if flags has
158 * the CMD_DESC_BITMASK bit set. Only entries where mask is non-zero
161 * If the check specifies a non-zero condition_mask then the parser
162 * only performs the check when the bits specified by condition_mask
169 u32 condition_offset
;
171 } bits
[MAX_CMD_DESC_BITMASKS
];
175 * A table of commands requiring special handling by the command parser.
177 * Each engine has an array of tables. Each table consists of an array of
178 * command descriptors, which must be sorted with command opcodes in
181 struct drm_i915_cmd_table
{
182 const struct drm_i915_cmd_descriptor
*table
;
186 #define STD_MI_OPCODE_SHIFT (32 - 9)
187 #define STD_3D_OPCODE_SHIFT (32 - 16)
188 #define STD_2D_OPCODE_SHIFT (32 - 10)
189 #define STD_MFX_OPCODE_SHIFT (32 - 16)
190 #define MIN_OPCODE_SHIFT 16
192 #define CMD(op, opm, f, lm, fl, ...) \
194 .flags = (fl) | ((f) ? CMD_DESC_FIXED : 0), \
195 .cmd = { (op), ~0u << (opm) }, \
196 .length = { (lm) }, \
200 /* Convenience macros to compress the tables */
201 #define SMI STD_MI_OPCODE_SHIFT
202 #define S3D STD_3D_OPCODE_SHIFT
203 #define S2D STD_2D_OPCODE_SHIFT
204 #define SMFX STD_MFX_OPCODE_SHIFT
206 #define S CMD_DESC_SKIP
207 #define R CMD_DESC_REJECT
208 #define W CMD_DESC_REGISTER
209 #define B CMD_DESC_BITMASK
210 #define M CMD_DESC_MASTER
212 /* Command Mask Fixed Len Action
213 ---------------------------------------------------------- */
214 static const struct drm_i915_cmd_descriptor common_cmds
[] = {
215 CMD( MI_NOOP
, SMI
, F
, 1, S
),
216 CMD( MI_USER_INTERRUPT
, SMI
, F
, 1, R
),
217 CMD( MI_WAIT_FOR_EVENT
, SMI
, F
, 1, M
),
218 CMD( MI_ARB_CHECK
, SMI
, F
, 1, S
),
219 CMD( MI_REPORT_HEAD
, SMI
, F
, 1, S
),
220 CMD( MI_SUSPEND_FLUSH
, SMI
, F
, 1, S
),
221 CMD( MI_SEMAPHORE_MBOX
, SMI
, !F
, 0xFF, R
),
222 CMD( MI_STORE_DWORD_INDEX
, SMI
, !F
, 0xFF, R
),
223 CMD( MI_LOAD_REGISTER_IMM(1), SMI
, !F
, 0xFF, W
,
224 .reg
= { .offset
= 1, .mask
= 0x007FFFFC, .step
= 2 } ),
225 CMD( MI_STORE_REGISTER_MEM
, SMI
, F
, 3, W
| B
,
226 .reg
= { .offset
= 1, .mask
= 0x007FFFFC },
229 .mask
= MI_GLOBAL_GTT
,
232 CMD( MI_LOAD_REGISTER_MEM
, SMI
, F
, 3, W
| B
,
233 .reg
= { .offset
= 1, .mask
= 0x007FFFFC },
236 .mask
= MI_GLOBAL_GTT
,
240 * MI_BATCH_BUFFER_START requires some special handling. It's not
241 * really a 'skip' action but it doesn't seem like it's worth adding
242 * a new action. See i915_parse_cmds().
244 CMD( MI_BATCH_BUFFER_START
, SMI
, !F
, 0xFF, S
),
247 static const struct drm_i915_cmd_descriptor render_cmds
[] = {
248 CMD( MI_FLUSH
, SMI
, F
, 1, S
),
249 CMD( MI_ARB_ON_OFF
, SMI
, F
, 1, R
),
250 CMD( MI_PREDICATE
, SMI
, F
, 1, S
),
251 CMD( MI_TOPOLOGY_FILTER
, SMI
, F
, 1, S
),
252 CMD( MI_SET_APPID
, SMI
, F
, 1, S
),
253 CMD( MI_DISPLAY_FLIP
, SMI
, !F
, 0xFF, R
),
254 CMD( MI_SET_CONTEXT
, SMI
, !F
, 0xFF, R
),
255 CMD( MI_URB_CLEAR
, SMI
, !F
, 0xFF, S
),
256 CMD( MI_STORE_DWORD_IMM
, SMI
, !F
, 0x3F, B
,
259 .mask
= MI_GLOBAL_GTT
,
262 CMD( MI_UPDATE_GTT
, SMI
, !F
, 0xFF, R
),
263 CMD( MI_CLFLUSH
, SMI
, !F
, 0x3FF, B
,
266 .mask
= MI_GLOBAL_GTT
,
269 CMD( MI_REPORT_PERF_COUNT
, SMI
, !F
, 0x3F, B
,
272 .mask
= MI_REPORT_PERF_COUNT_GGTT
,
275 CMD( MI_CONDITIONAL_BATCH_BUFFER_END
, SMI
, !F
, 0xFF, B
,
278 .mask
= MI_GLOBAL_GTT
,
281 CMD( GFX_OP_3DSTATE_VF_STATISTICS
, S3D
, F
, 1, S
),
282 CMD( PIPELINE_SELECT
, S3D
, F
, 1, S
),
283 CMD( MEDIA_VFE_STATE
, S3D
, !F
, 0xFFFF, B
,
286 .mask
= MEDIA_VFE_STATE_MMIO_ACCESS_MASK
,
289 CMD( GPGPU_OBJECT
, S3D
, !F
, 0xFF, S
),
290 CMD( GPGPU_WALKER
, S3D
, !F
, 0xFF, S
),
291 CMD( GFX_OP_3DSTATE_SO_DECL_LIST
, S3D
, !F
, 0x1FF, S
),
292 CMD( GFX_OP_PIPE_CONTROL(5), S3D
, !F
, 0xFF, B
,
295 .mask
= (PIPE_CONTROL_MMIO_WRITE
| PIPE_CONTROL_NOTIFY
),
300 .mask
= (PIPE_CONTROL_GLOBAL_GTT_IVB
|
301 PIPE_CONTROL_STORE_DATA_INDEX
),
303 .condition_offset
= 1,
304 .condition_mask
= PIPE_CONTROL_POST_SYNC_OP_MASK
,
308 static const struct drm_i915_cmd_descriptor hsw_render_cmds
[] = {
309 CMD( MI_SET_PREDICATE
, SMI
, F
, 1, S
),
310 CMD( MI_RS_CONTROL
, SMI
, F
, 1, S
),
311 CMD( MI_URB_ATOMIC_ALLOC
, SMI
, F
, 1, S
),
312 CMD( MI_SET_APPID
, SMI
, F
, 1, S
),
313 CMD( MI_RS_CONTEXT
, SMI
, F
, 1, S
),
314 CMD( MI_LOAD_SCAN_LINES_INCL
, SMI
, !F
, 0x3F, M
),
315 CMD( MI_LOAD_SCAN_LINES_EXCL
, SMI
, !F
, 0x3F, R
),
316 CMD( MI_LOAD_REGISTER_REG
, SMI
, !F
, 0xFF, W
,
317 .reg
= { .offset
= 1, .mask
= 0x007FFFFC, .step
= 1 } ),
318 CMD( MI_RS_STORE_DATA_IMM
, SMI
, !F
, 0xFF, S
),
319 CMD( MI_LOAD_URB_MEM
, SMI
, !F
, 0xFF, S
),
320 CMD( MI_STORE_URB_MEM
, SMI
, !F
, 0xFF, S
),
321 CMD( GFX_OP_3DSTATE_DX9_CONSTANTF_VS
, S3D
, !F
, 0x7FF, S
),
322 CMD( GFX_OP_3DSTATE_DX9_CONSTANTF_PS
, S3D
, !F
, 0x7FF, S
),
324 CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_VS
, S3D
, !F
, 0x1FF, S
),
325 CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_GS
, S3D
, !F
, 0x1FF, S
),
326 CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_HS
, S3D
, !F
, 0x1FF, S
),
327 CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_DS
, S3D
, !F
, 0x1FF, S
),
328 CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_PS
, S3D
, !F
, 0x1FF, S
),
331 static const struct drm_i915_cmd_descriptor video_cmds
[] = {
332 CMD( MI_ARB_ON_OFF
, SMI
, F
, 1, R
),
333 CMD( MI_SET_APPID
, SMI
, F
, 1, S
),
334 CMD( MI_STORE_DWORD_IMM
, SMI
, !F
, 0xFF, B
,
337 .mask
= MI_GLOBAL_GTT
,
340 CMD( MI_UPDATE_GTT
, SMI
, !F
, 0x3F, R
),
341 CMD( MI_FLUSH_DW
, SMI
, !F
, 0x3F, B
,
344 .mask
= MI_FLUSH_DW_NOTIFY
,
349 .mask
= MI_FLUSH_DW_USE_GTT
,
351 .condition_offset
= 0,
352 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
356 .mask
= MI_FLUSH_DW_STORE_INDEX
,
358 .condition_offset
= 0,
359 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
361 CMD( MI_CONDITIONAL_BATCH_BUFFER_END
, SMI
, !F
, 0xFF, B
,
364 .mask
= MI_GLOBAL_GTT
,
368 * MFX_WAIT doesn't fit the way we handle length for most commands.
369 * It has a length field but it uses a non-standard length bias.
370 * It is always 1 dword though, so just treat it as fixed length.
372 CMD( MFX_WAIT
, SMFX
, F
, 1, S
),
375 static const struct drm_i915_cmd_descriptor vecs_cmds
[] = {
376 CMD( MI_ARB_ON_OFF
, SMI
, F
, 1, R
),
377 CMD( MI_SET_APPID
, SMI
, F
, 1, S
),
378 CMD( MI_STORE_DWORD_IMM
, SMI
, !F
, 0xFF, B
,
381 .mask
= MI_GLOBAL_GTT
,
384 CMD( MI_UPDATE_GTT
, SMI
, !F
, 0x3F, R
),
385 CMD( MI_FLUSH_DW
, SMI
, !F
, 0x3F, B
,
388 .mask
= MI_FLUSH_DW_NOTIFY
,
393 .mask
= MI_FLUSH_DW_USE_GTT
,
395 .condition_offset
= 0,
396 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
400 .mask
= MI_FLUSH_DW_STORE_INDEX
,
402 .condition_offset
= 0,
403 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
405 CMD( MI_CONDITIONAL_BATCH_BUFFER_END
, SMI
, !F
, 0xFF, B
,
408 .mask
= MI_GLOBAL_GTT
,
413 static const struct drm_i915_cmd_descriptor blt_cmds
[] = {
414 CMD( MI_DISPLAY_FLIP
, SMI
, !F
, 0xFF, R
),
415 CMD( MI_STORE_DWORD_IMM
, SMI
, !F
, 0x3FF, B
,
418 .mask
= MI_GLOBAL_GTT
,
421 CMD( MI_UPDATE_GTT
, SMI
, !F
, 0x3F, R
),
422 CMD( MI_FLUSH_DW
, SMI
, !F
, 0x3F, B
,
425 .mask
= MI_FLUSH_DW_NOTIFY
,
430 .mask
= MI_FLUSH_DW_USE_GTT
,
432 .condition_offset
= 0,
433 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
437 .mask
= MI_FLUSH_DW_STORE_INDEX
,
439 .condition_offset
= 0,
440 .condition_mask
= MI_FLUSH_DW_OP_MASK
,
442 CMD( COLOR_BLT
, S2D
, !F
, 0x3F, S
),
443 CMD( SRC_COPY_BLT
, S2D
, !F
, 0x3F, S
),
446 static const struct drm_i915_cmd_descriptor hsw_blt_cmds
[] = {
447 CMD( MI_LOAD_SCAN_LINES_INCL
, SMI
, !F
, 0x3F, M
),
448 CMD( MI_LOAD_SCAN_LINES_EXCL
, SMI
, !F
, 0x3F, R
),
451 static const struct drm_i915_cmd_descriptor noop_desc
=
452 CMD(MI_NOOP
, SMI
, F
, 1, S
);
466 static const struct drm_i915_cmd_table gen7_render_cmds
[] = {
467 { common_cmds
, ARRAY_SIZE(common_cmds
) },
468 { render_cmds
, ARRAY_SIZE(render_cmds
) },
471 static const struct drm_i915_cmd_table hsw_render_ring_cmds
[] = {
472 { common_cmds
, ARRAY_SIZE(common_cmds
) },
473 { render_cmds
, ARRAY_SIZE(render_cmds
) },
474 { hsw_render_cmds
, ARRAY_SIZE(hsw_render_cmds
) },
477 static const struct drm_i915_cmd_table gen7_video_cmds
[] = {
478 { common_cmds
, ARRAY_SIZE(common_cmds
) },
479 { video_cmds
, ARRAY_SIZE(video_cmds
) },
482 static const struct drm_i915_cmd_table hsw_vebox_cmds
[] = {
483 { common_cmds
, ARRAY_SIZE(common_cmds
) },
484 { vecs_cmds
, ARRAY_SIZE(vecs_cmds
) },
487 static const struct drm_i915_cmd_table gen7_blt_cmds
[] = {
488 { common_cmds
, ARRAY_SIZE(common_cmds
) },
489 { blt_cmds
, ARRAY_SIZE(blt_cmds
) },
492 static const struct drm_i915_cmd_table hsw_blt_ring_cmds
[] = {
493 { common_cmds
, ARRAY_SIZE(common_cmds
) },
494 { blt_cmds
, ARRAY_SIZE(blt_cmds
) },
495 { hsw_blt_cmds
, ARRAY_SIZE(hsw_blt_cmds
) },
499 * Register whitelists, sorted by increasing register offset.
503 * An individual whitelist entry granting access to register addr. If
504 * mask is non-zero the argument of immediate register writes will be
505 * AND-ed with mask, and the command will be rejected if the result
506 * doesn't match value.
508 * Registers with non-zero mask are only allowed to be written using
511 struct drm_i915_reg_descriptor
{
517 /* Convenience macro for adding 32-bit registers. */
518 #define REG32(_reg, ...) \
519 { .addr = (_reg), __VA_ARGS__ }
522 * Convenience macro for adding 64-bit registers.
524 * Some registers that userspace accesses are 64 bits. The register
525 * access commands only allow 32-bit accesses. Hence, we have to include
526 * entries for both halves of the 64-bit registers.
528 #define REG64(_reg) \
530 { .addr = _reg ## _UDW }
532 #define REG64_IDX(_reg, idx) \
533 { .addr = _reg(idx) }, \
534 { .addr = _reg ## _UDW(idx) }
536 static const struct drm_i915_reg_descriptor gen7_render_regs
[] = {
537 REG64(GPGPU_THREADS_DISPATCHED
),
538 REG64(HS_INVOCATION_COUNT
),
539 REG64(DS_INVOCATION_COUNT
),
540 REG64(IA_VERTICES_COUNT
),
541 REG64(IA_PRIMITIVES_COUNT
),
542 REG64(VS_INVOCATION_COUNT
),
543 REG64(GS_INVOCATION_COUNT
),
544 REG64(GS_PRIMITIVES_COUNT
),
545 REG64(CL_INVOCATION_COUNT
),
546 REG64(CL_PRIMITIVES_COUNT
),
547 REG64(PS_INVOCATION_COUNT
),
548 REG64(PS_DEPTH_COUNT
),
549 REG64_IDX(RING_TIMESTAMP
, RENDER_RING_BASE
),
550 REG64(MI_PREDICATE_SRC0
),
551 REG64(MI_PREDICATE_SRC1
),
552 REG32(GEN7_3DPRIM_END_OFFSET
),
553 REG32(GEN7_3DPRIM_START_VERTEX
),
554 REG32(GEN7_3DPRIM_VERTEX_COUNT
),
555 REG32(GEN7_3DPRIM_INSTANCE_COUNT
),
556 REG32(GEN7_3DPRIM_START_INSTANCE
),
557 REG32(GEN7_3DPRIM_BASE_VERTEX
),
558 REG32(GEN7_GPGPU_DISPATCHDIMX
),
559 REG32(GEN7_GPGPU_DISPATCHDIMY
),
560 REG32(GEN7_GPGPU_DISPATCHDIMZ
),
561 REG64_IDX(RING_TIMESTAMP
, BSD_RING_BASE
),
562 REG64_IDX(GEN7_SO_NUM_PRIMS_WRITTEN
, 0),
563 REG64_IDX(GEN7_SO_NUM_PRIMS_WRITTEN
, 1),
564 REG64_IDX(GEN7_SO_NUM_PRIMS_WRITTEN
, 2),
565 REG64_IDX(GEN7_SO_NUM_PRIMS_WRITTEN
, 3),
566 REG64_IDX(GEN7_SO_PRIM_STORAGE_NEEDED
, 0),
567 REG64_IDX(GEN7_SO_PRIM_STORAGE_NEEDED
, 1),
568 REG64_IDX(GEN7_SO_PRIM_STORAGE_NEEDED
, 2),
569 REG64_IDX(GEN7_SO_PRIM_STORAGE_NEEDED
, 3),
570 REG32(GEN7_SO_WRITE_OFFSET(0)),
571 REG32(GEN7_SO_WRITE_OFFSET(1)),
572 REG32(GEN7_SO_WRITE_OFFSET(2)),
573 REG32(GEN7_SO_WRITE_OFFSET(3)),
574 REG32(GEN7_L3SQCREG1
),
575 REG32(GEN7_L3CNTLREG2
),
576 REG32(GEN7_L3CNTLREG3
),
577 REG64_IDX(RING_TIMESTAMP
, BLT_RING_BASE
),
580 static const struct drm_i915_reg_descriptor hsw_render_regs
[] = {
581 REG64_IDX(HSW_CS_GPR
, 0),
582 REG64_IDX(HSW_CS_GPR
, 1),
583 REG64_IDX(HSW_CS_GPR
, 2),
584 REG64_IDX(HSW_CS_GPR
, 3),
585 REG64_IDX(HSW_CS_GPR
, 4),
586 REG64_IDX(HSW_CS_GPR
, 5),
587 REG64_IDX(HSW_CS_GPR
, 6),
588 REG64_IDX(HSW_CS_GPR
, 7),
589 REG64_IDX(HSW_CS_GPR
, 8),
590 REG64_IDX(HSW_CS_GPR
, 9),
591 REG64_IDX(HSW_CS_GPR
, 10),
592 REG64_IDX(HSW_CS_GPR
, 11),
593 REG64_IDX(HSW_CS_GPR
, 12),
594 REG64_IDX(HSW_CS_GPR
, 13),
595 REG64_IDX(HSW_CS_GPR
, 14),
596 REG64_IDX(HSW_CS_GPR
, 15),
598 .mask
= ~HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE
,
600 REG32(HSW_ROW_CHICKEN3
,
601 .mask
= ~(HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE
<< 16 |
602 HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE
),
606 static const struct drm_i915_reg_descriptor gen7_blt_regs
[] = {
607 REG64_IDX(RING_TIMESTAMP
, RENDER_RING_BASE
),
608 REG64_IDX(RING_TIMESTAMP
, BSD_RING_BASE
),
610 REG64_IDX(RING_TIMESTAMP
, BLT_RING_BASE
),
613 static const struct drm_i915_reg_descriptor ivb_master_regs
[] = {
616 REG32(GEN7_PIPE_DE_LOAD_SL(PIPE_A
)),
617 REG32(GEN7_PIPE_DE_LOAD_SL(PIPE_B
)),
618 REG32(GEN7_PIPE_DE_LOAD_SL(PIPE_C
)),
621 static const struct drm_i915_reg_descriptor hsw_master_regs
[] = {
629 struct drm_i915_reg_table
{
630 const struct drm_i915_reg_descriptor
*regs
;
635 static const struct drm_i915_reg_table ivb_render_reg_tables
[] = {
636 { gen7_render_regs
, ARRAY_SIZE(gen7_render_regs
), false },
637 { ivb_master_regs
, ARRAY_SIZE(ivb_master_regs
), true },
640 static const struct drm_i915_reg_table ivb_blt_reg_tables
[] = {
641 { gen7_blt_regs
, ARRAY_SIZE(gen7_blt_regs
), false },
642 { ivb_master_regs
, ARRAY_SIZE(ivb_master_regs
), true },
645 static const struct drm_i915_reg_table hsw_render_reg_tables
[] = {
646 { gen7_render_regs
, ARRAY_SIZE(gen7_render_regs
), false },
647 { hsw_render_regs
, ARRAY_SIZE(hsw_render_regs
), false },
648 { hsw_master_regs
, ARRAY_SIZE(hsw_master_regs
), true },
651 static const struct drm_i915_reg_table hsw_blt_reg_tables
[] = {
652 { gen7_blt_regs
, ARRAY_SIZE(gen7_blt_regs
), false },
653 { hsw_master_regs
, ARRAY_SIZE(hsw_master_regs
), true },
656 static u32
gen7_render_get_cmd_length_mask(u32 cmd_header
)
658 u32 client
= cmd_header
>> INSTR_CLIENT_SHIFT
;
660 (cmd_header
& INSTR_SUBCLIENT_MASK
) >> INSTR_SUBCLIENT_SHIFT
;
662 if (client
== INSTR_MI_CLIENT
)
664 else if (client
== INSTR_RC_CLIENT
) {
665 if (subclient
== INSTR_MEDIA_SUBCLIENT
)
671 DRM_DEBUG_DRIVER("CMD: Abnormal rcs cmd length! 0x%08X\n", cmd_header
);
675 static u32
gen7_bsd_get_cmd_length_mask(u32 cmd_header
)
677 u32 client
= cmd_header
>> INSTR_CLIENT_SHIFT
;
679 (cmd_header
& INSTR_SUBCLIENT_MASK
) >> INSTR_SUBCLIENT_SHIFT
;
680 u32 op
= (cmd_header
& INSTR_26_TO_24_MASK
) >> INSTR_26_TO_24_SHIFT
;
682 if (client
== INSTR_MI_CLIENT
)
684 else if (client
== INSTR_RC_CLIENT
) {
685 if (subclient
== INSTR_MEDIA_SUBCLIENT
) {
694 DRM_DEBUG_DRIVER("CMD: Abnormal bsd cmd length! 0x%08X\n", cmd_header
);
698 static u32
gen7_blt_get_cmd_length_mask(u32 cmd_header
)
700 u32 client
= cmd_header
>> INSTR_CLIENT_SHIFT
;
702 if (client
== INSTR_MI_CLIENT
)
704 else if (client
== INSTR_BC_CLIENT
)
707 DRM_DEBUG_DRIVER("CMD: Abnormal blt cmd length! 0x%08X\n", cmd_header
);
711 static bool validate_cmds_sorted(const struct intel_engine_cs
*engine
,
712 const struct drm_i915_cmd_table
*cmd_tables
,
718 if (!cmd_tables
|| cmd_table_count
== 0)
721 for (i
= 0; i
< cmd_table_count
; i
++) {
722 const struct drm_i915_cmd_table
*table
= &cmd_tables
[i
];
726 for (j
= 0; j
< table
->count
; j
++) {
727 const struct drm_i915_cmd_descriptor
*desc
=
729 u32 curr
= desc
->cmd
.value
& desc
->cmd
.mask
;
731 if (curr
< previous
) {
732 DRM_ERROR("CMD: %s [%d] command table not sorted: "
733 "table=%d entry=%d cmd=0x%08X prev=0x%08X\n",
734 engine
->name
, engine
->id
,
735 i
, j
, curr
, previous
);
746 static bool check_sorted(const struct intel_engine_cs
*engine
,
747 const struct drm_i915_reg_descriptor
*reg_table
,
754 for (i
= 0; i
< reg_count
; i
++) {
755 u32 curr
= i915_mmio_reg_offset(reg_table
[i
].addr
);
757 if (curr
< previous
) {
758 DRM_ERROR("CMD: %s [%d] register table not sorted: "
759 "entry=%d reg=0x%08X prev=0x%08X\n",
760 engine
->name
, engine
->id
,
771 static bool validate_regs_sorted(struct intel_engine_cs
*engine
)
774 const struct drm_i915_reg_table
*table
;
776 for (i
= 0; i
< engine
->reg_table_count
; i
++) {
777 table
= &engine
->reg_tables
[i
];
778 if (!check_sorted(engine
, table
->regs
, table
->num_regs
))
786 const struct drm_i915_cmd_descriptor
*desc
;
787 struct hlist_node node
;
791 * Different command ranges have different numbers of bits for the opcode. For
792 * example, MI commands use bits 31:23 while 3D commands use bits 31:16. The
793 * problem is that, for example, MI commands use bits 22:16 for other fields
794 * such as GGTT vs PPGTT bits. If we include those bits in the mask then when
795 * we mask a command from a batch it could hash to the wrong bucket due to
796 * non-opcode bits being set. But if we don't include those bits, some 3D
797 * commands may hash to the same bucket due to not including opcode bits that
798 * make the command unique. For now, we will risk hashing to the same bucket.
800 static inline u32
cmd_header_key(u32 x
)
802 switch (x
>> INSTR_CLIENT_SHIFT
) {
804 case INSTR_MI_CLIENT
:
805 return x
>> STD_MI_OPCODE_SHIFT
;
806 case INSTR_RC_CLIENT
:
807 return x
>> STD_3D_OPCODE_SHIFT
;
808 case INSTR_BC_CLIENT
:
809 return x
>> STD_2D_OPCODE_SHIFT
;
813 static int init_hash_table(struct intel_engine_cs
*engine
,
814 const struct drm_i915_cmd_table
*cmd_tables
,
819 hash_init(engine
->cmd_hash
);
821 for (i
= 0; i
< cmd_table_count
; i
++) {
822 const struct drm_i915_cmd_table
*table
= &cmd_tables
[i
];
824 for (j
= 0; j
< table
->count
; j
++) {
825 const struct drm_i915_cmd_descriptor
*desc
=
827 struct cmd_node
*desc_node
=
828 kmalloc(sizeof(*desc_node
), GFP_KERNEL
);
833 desc_node
->desc
= desc
;
834 hash_add(engine
->cmd_hash
, &desc_node
->node
,
835 cmd_header_key(desc
->cmd
.value
));
842 static void fini_hash_table(struct intel_engine_cs
*engine
)
844 struct hlist_node
*tmp
;
845 struct cmd_node
*desc_node
;
848 hash_for_each_safe(engine
->cmd_hash
, i
, tmp
, desc_node
, node
) {
849 hash_del(&desc_node
->node
);
855 * intel_engine_init_cmd_parser() - set cmd parser related fields for an engine
856 * @engine: the engine to initialize
858 * Optionally initializes fields related to batch buffer command parsing in the
859 * struct intel_engine_cs based on whether the platform requires software
862 void intel_engine_init_cmd_parser(struct intel_engine_cs
*engine
)
864 const struct drm_i915_cmd_table
*cmd_tables
;
868 if (!IS_GEN7(engine
->i915
))
871 switch (engine
->id
) {
873 if (IS_HASWELL(engine
->i915
)) {
874 cmd_tables
= hsw_render_ring_cmds
;
876 ARRAY_SIZE(hsw_render_ring_cmds
);
878 cmd_tables
= gen7_render_cmds
;
879 cmd_table_count
= ARRAY_SIZE(gen7_render_cmds
);
882 if (IS_HASWELL(engine
->i915
)) {
883 engine
->reg_tables
= hsw_render_reg_tables
;
884 engine
->reg_table_count
= ARRAY_SIZE(hsw_render_reg_tables
);
886 engine
->reg_tables
= ivb_render_reg_tables
;
887 engine
->reg_table_count
= ARRAY_SIZE(ivb_render_reg_tables
);
890 engine
->get_cmd_length_mask
= gen7_render_get_cmd_length_mask
;
893 cmd_tables
= gen7_video_cmds
;
894 cmd_table_count
= ARRAY_SIZE(gen7_video_cmds
);
895 engine
->get_cmd_length_mask
= gen7_bsd_get_cmd_length_mask
;
898 if (IS_HASWELL(engine
->i915
)) {
899 cmd_tables
= hsw_blt_ring_cmds
;
900 cmd_table_count
= ARRAY_SIZE(hsw_blt_ring_cmds
);
902 cmd_tables
= gen7_blt_cmds
;
903 cmd_table_count
= ARRAY_SIZE(gen7_blt_cmds
);
906 if (IS_HASWELL(engine
->i915
)) {
907 engine
->reg_tables
= hsw_blt_reg_tables
;
908 engine
->reg_table_count
= ARRAY_SIZE(hsw_blt_reg_tables
);
910 engine
->reg_tables
= ivb_blt_reg_tables
;
911 engine
->reg_table_count
= ARRAY_SIZE(ivb_blt_reg_tables
);
914 engine
->get_cmd_length_mask
= gen7_blt_get_cmd_length_mask
;
917 cmd_tables
= hsw_vebox_cmds
;
918 cmd_table_count
= ARRAY_SIZE(hsw_vebox_cmds
);
919 /* VECS can use the same length_mask function as VCS */
920 engine
->get_cmd_length_mask
= gen7_bsd_get_cmd_length_mask
;
923 MISSING_CASE(engine
->id
);
927 if (!validate_cmds_sorted(engine
, cmd_tables
, cmd_table_count
)) {
928 DRM_ERROR("%s: command descriptions are not sorted\n",
932 if (!validate_regs_sorted(engine
)) {
933 DRM_ERROR("%s: registers are not sorted\n", engine
->name
);
937 ret
= init_hash_table(engine
, cmd_tables
, cmd_table_count
);
939 DRM_ERROR("%s: initialised failed!\n", engine
->name
);
940 fini_hash_table(engine
);
944 engine
->flags
|= I915_ENGINE_NEEDS_CMD_PARSER
;
948 * intel_engine_cleanup_cmd_parser() - clean up cmd parser related fields
949 * @engine: the engine to clean up
951 * Releases any resources related to command parsing that may have been
952 * initialized for the specified engine.
954 void intel_engine_cleanup_cmd_parser(struct intel_engine_cs
*engine
)
956 if (!intel_engine_needs_cmd_parser(engine
))
959 fini_hash_table(engine
);
962 static const struct drm_i915_cmd_descriptor
*
963 find_cmd_in_table(struct intel_engine_cs
*engine
,
966 struct cmd_node
*desc_node
;
968 hash_for_each_possible(engine
->cmd_hash
, desc_node
, node
,
969 cmd_header_key(cmd_header
)) {
970 const struct drm_i915_cmd_descriptor
*desc
= desc_node
->desc
;
971 if (((cmd_header
^ desc
->cmd
.value
) & desc
->cmd
.mask
) == 0)
979 * Returns a pointer to a descriptor for the command specified by cmd_header.
981 * The caller must supply space for a default descriptor via the default_desc
982 * parameter. If no descriptor for the specified command exists in the engine's
983 * command parser tables, this function fills in default_desc based on the
984 * engine's default length encoding and returns default_desc.
986 static const struct drm_i915_cmd_descriptor
*
987 find_cmd(struct intel_engine_cs
*engine
,
989 const struct drm_i915_cmd_descriptor
*desc
,
990 struct drm_i915_cmd_descriptor
*default_desc
)
994 if (((cmd_header
^ desc
->cmd
.value
) & desc
->cmd
.mask
) == 0)
997 desc
= find_cmd_in_table(engine
, cmd_header
);
1001 mask
= engine
->get_cmd_length_mask(cmd_header
);
1005 default_desc
->cmd
.value
= cmd_header
;
1006 default_desc
->cmd
.mask
= ~0u << MIN_OPCODE_SHIFT
;
1007 default_desc
->length
.mask
= mask
;
1008 default_desc
->flags
= CMD_DESC_SKIP
;
1009 return default_desc
;
1012 static const struct drm_i915_reg_descriptor
*
1013 __find_reg(const struct drm_i915_reg_descriptor
*table
, int count
, u32 addr
)
1015 int start
= 0, end
= count
;
1016 while (start
< end
) {
1017 int mid
= start
+ (end
- start
) / 2;
1018 int ret
= addr
- i915_mmio_reg_offset(table
[mid
].addr
);
1029 static const struct drm_i915_reg_descriptor
*
1030 find_reg(const struct intel_engine_cs
*engine
, bool is_master
, u32 addr
)
1032 const struct drm_i915_reg_table
*table
= engine
->reg_tables
;
1033 int count
= engine
->reg_table_count
;
1035 for (; count
> 0; ++table
, --count
) {
1036 if (!table
->master
|| is_master
) {
1037 const struct drm_i915_reg_descriptor
*reg
;
1039 reg
= __find_reg(table
->regs
, table
->num_regs
, addr
);
1048 /* Returns a vmap'd pointer to dst_obj, which the caller must unmap */
1049 static u32
*copy_batch(struct drm_i915_gem_object
*dst_obj
,
1050 struct drm_i915_gem_object
*src_obj
,
1051 u32 batch_start_offset
,
1053 bool *needs_clflush_after
)
1055 unsigned int src_needs_clflush
;
1056 unsigned int dst_needs_clflush
;
1060 ret
= i915_gem_obj_prepare_shmem_read(src_obj
, &src_needs_clflush
);
1062 return ERR_PTR(ret
);
1064 ret
= i915_gem_obj_prepare_shmem_write(dst_obj
, &dst_needs_clflush
);
1070 dst
= i915_gem_object_pin_map(dst_obj
, I915_MAP_FORCE_WB
);
1074 src
= ERR_PTR(-ENODEV
);
1075 if (src_needs_clflush
&&
1076 i915_can_memcpy_from_wc(NULL
, batch_start_offset
, 0)) {
1077 src
= i915_gem_object_pin_map(src_obj
, I915_MAP_WC
);
1079 i915_memcpy_from_wc(dst
,
1080 src
+ batch_start_offset
,
1081 ALIGN(batch_len
, 16));
1082 i915_gem_object_unpin_map(src_obj
);
1089 offset
= offset_in_page(batch_start_offset
);
1091 /* We can avoid clflushing partial cachelines before the write
1092 * if we only every write full cache-lines. Since we know that
1093 * both the source and destination are in multiples of
1094 * PAGE_SIZE, we can simply round up to the next cacheline.
1095 * We don't care about copying too much here as we only
1096 * validate up to the end of the batch.
1098 if (dst_needs_clflush
& CLFLUSH_BEFORE
)
1099 batch_len
= roundup(batch_len
,
1100 boot_cpu_data
.x86_clflush_size
);
1103 for (n
= batch_start_offset
>> PAGE_SHIFT
; batch_len
; n
++) {
1104 int len
= min_t(int, batch_len
, PAGE_SIZE
- offset
);
1106 src
= kmap_atomic(i915_gem_object_get_page(src_obj
, n
));
1107 if (src_needs_clflush
)
1108 drm_clflush_virt_range(src
+ offset
, len
);
1109 memcpy(ptr
, src
+ offset
, len
);
1118 /* dst_obj is returned with vmap pinned */
1119 *needs_clflush_after
= dst_needs_clflush
& CLFLUSH_AFTER
;
1122 i915_gem_obj_finish_shmem_access(dst_obj
);
1124 i915_gem_obj_finish_shmem_access(src_obj
);
1128 static bool check_cmd(const struct intel_engine_cs
*engine
,
1129 const struct drm_i915_cmd_descriptor
*desc
,
1130 const u32
*cmd
, u32 length
,
1131 const bool is_master
)
1133 if (desc
->flags
& CMD_DESC_SKIP
)
1136 if (desc
->flags
& CMD_DESC_REJECT
) {
1137 DRM_DEBUG_DRIVER("CMD: Rejected command: 0x%08X\n", *cmd
);
1141 if ((desc
->flags
& CMD_DESC_MASTER
) && !is_master
) {
1142 DRM_DEBUG_DRIVER("CMD: Rejected master-only command: 0x%08X\n",
1147 if (desc
->flags
& CMD_DESC_REGISTER
) {
1149 * Get the distance between individual register offset
1150 * fields if the command can perform more than one
1153 const u32 step
= desc
->reg
.step
? desc
->reg
.step
: length
;
1156 for (offset
= desc
->reg
.offset
; offset
< length
;
1158 const u32 reg_addr
= cmd
[offset
] & desc
->reg
.mask
;
1159 const struct drm_i915_reg_descriptor
*reg
=
1160 find_reg(engine
, is_master
, reg_addr
);
1163 DRM_DEBUG_DRIVER("CMD: Rejected register 0x%08X in command: 0x%08X (%s)\n",
1164 reg_addr
, *cmd
, engine
->name
);
1169 * Check the value written to the register against the
1170 * allowed mask/value pair given in the whitelist entry.
1173 if (desc
->cmd
.value
== MI_LOAD_REGISTER_MEM
) {
1174 DRM_DEBUG_DRIVER("CMD: Rejected LRM to masked register 0x%08X\n",
1179 if (desc
->cmd
.value
== MI_LOAD_REGISTER_REG
) {
1180 DRM_DEBUG_DRIVER("CMD: Rejected LRR to masked register 0x%08X\n",
1185 if (desc
->cmd
.value
== MI_LOAD_REGISTER_IMM(1) &&
1186 (offset
+ 2 > length
||
1187 (cmd
[offset
+ 1] & reg
->mask
) != reg
->value
)) {
1188 DRM_DEBUG_DRIVER("CMD: Rejected LRI to masked register 0x%08X\n",
1196 if (desc
->flags
& CMD_DESC_BITMASK
) {
1199 for (i
= 0; i
< MAX_CMD_DESC_BITMASKS
; i
++) {
1202 if (desc
->bits
[i
].mask
== 0)
1205 if (desc
->bits
[i
].condition_mask
!= 0) {
1207 desc
->bits
[i
].condition_offset
;
1208 u32 condition
= cmd
[offset
] &
1209 desc
->bits
[i
].condition_mask
;
1215 if (desc
->bits
[i
].offset
>= length
) {
1216 DRM_DEBUG_DRIVER("CMD: Rejected command 0x%08X, too short to check bitmask (%s)\n",
1217 *cmd
, engine
->name
);
1221 dword
= cmd
[desc
->bits
[i
].offset
] &
1224 if (dword
!= desc
->bits
[i
].expected
) {
1225 DRM_DEBUG_DRIVER("CMD: Rejected command 0x%08X for bitmask 0x%08X (exp=0x%08X act=0x%08X) (%s)\n",
1228 desc
->bits
[i
].expected
,
1229 dword
, engine
->name
);
1238 #define LENGTH_BIAS 2
1241 * i915_parse_cmds() - parse a submitted batch buffer for privilege violations
1242 * @engine: the engine on which the batch is to execute
1243 * @batch_obj: the batch buffer in question
1244 * @shadow_batch_obj: copy of the batch buffer in question
1245 * @batch_start_offset: byte offset in the batch at which execution starts
1246 * @batch_len: length of the commands in batch_obj
1247 * @is_master: is the submitting process the drm master?
1249 * Parses the specified batch buffer looking for privilege violations as
1250 * described in the overview.
1252 * Return: non-zero if the parser finds violations or otherwise fails; -EACCES
1253 * if the batch appears legal but should use hardware parsing
1255 int intel_engine_cmd_parser(struct intel_engine_cs
*engine
,
1256 struct drm_i915_gem_object
*batch_obj
,
1257 struct drm_i915_gem_object
*shadow_batch_obj
,
1258 u32 batch_start_offset
,
1262 u32
*cmd
, *batch_end
;
1263 struct drm_i915_cmd_descriptor default_desc
= noop_desc
;
1264 const struct drm_i915_cmd_descriptor
*desc
= &default_desc
;
1265 bool needs_clflush_after
= false;
1268 cmd
= copy_batch(shadow_batch_obj
, batch_obj
,
1269 batch_start_offset
, batch_len
,
1270 &needs_clflush_after
);
1272 DRM_DEBUG_DRIVER("CMD: Failed to copy batch\n");
1273 return PTR_ERR(cmd
);
1277 * We use the batch length as size because the shadow object is as
1278 * large or larger and copy_batch() will write MI_NOPs to the extra
1279 * space. Parsing should be faster in some cases this way.
1281 batch_end
= cmd
+ (batch_len
/ sizeof(*batch_end
));
1285 if (*cmd
== MI_BATCH_BUFFER_END
) {
1286 if (needs_clflush_after
) {
1287 void *ptr
= page_mask_bits(shadow_batch_obj
->mm
.mapping
);
1288 drm_clflush_virt_range(ptr
,
1289 (void *)(cmd
+ 1) - ptr
);
1294 desc
= find_cmd(engine
, *cmd
, desc
, &default_desc
);
1296 DRM_DEBUG_DRIVER("CMD: Unrecognized command: 0x%08X\n",
1303 * If the batch buffer contains a chained batch, return an
1304 * error that tells the caller to abort and dispatch the
1305 * workload as a non-secure batch.
1307 if (desc
->cmd
.value
== MI_BATCH_BUFFER_START
) {
1312 if (desc
->flags
& CMD_DESC_FIXED
)
1313 length
= desc
->length
.fixed
;
1315 length
= ((*cmd
& desc
->length
.mask
) + LENGTH_BIAS
);
1317 if ((batch_end
- cmd
) < length
) {
1318 DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n",
1326 if (!check_cmd(engine
, desc
, cmd
, length
, is_master
)) {
1332 if (cmd
>= batch_end
) {
1333 DRM_DEBUG_DRIVER("CMD: Got to the end of the buffer w/o a BBE cmd!\n");
1339 i915_gem_object_unpin_map(shadow_batch_obj
);
1344 * i915_cmd_parser_get_version() - get the cmd parser version number
1345 * @dev_priv: i915 device private
1347 * The cmd parser maintains a simple increasing integer version number suitable
1348 * for passing to userspace clients to determine what operations are permitted.
1350 * Return: the current version number of the cmd parser
1352 int i915_cmd_parser_get_version(struct drm_i915_private
*dev_priv
)
1354 struct intel_engine_cs
*engine
;
1355 enum intel_engine_id id
;
1356 bool active
= false;
1358 /* If the command parser is not enabled, report 0 - unsupported */
1359 for_each_engine(engine
, dev_priv
, id
) {
1360 if (intel_engine_needs_cmd_parser(engine
)) {
1369 * Command parser version history
1371 * 1. Initial version. Checks batches and reports violations, but leaves
1372 * hardware parsing enabled (so does not allow new use cases).
1373 * 2. Allow access to the MI_PREDICATE_SRC0 and
1374 * MI_PREDICATE_SRC1 registers.
1375 * 3. Allow access to the GPGPU_THREADS_DISPATCHED register.
1376 * 4. L3 atomic chicken bits of HSW_SCRATCH1 and HSW_ROW_CHICKEN3.
1377 * 5. GPGPU dispatch compute indirect registers.
1378 * 6. TIMESTAMP register and Haswell CS GPR registers
1379 * 7. Allow MI_LOAD_REGISTER_REG between whitelisted registers.
1380 * 8. Don't report cmd_check() failures as EINVAL errors to userspace;
1381 * rely on the HW to NOOP disallowed commands as it would without
1382 * the parser enabled.
1383 * 9. Don't whitelist or handle oacontrol specially, as ownership
1384 * for oacontrol state is moving to i915-perf.