2 * Copyright (C) 2015 Josh Poimboeuf <jpoimboe@redhat.com>
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, see <http://www.gnu.org/licenses/>.
21 * This command analyzes every .o file and ensures the validity of its stack
22 * trace metadata. It enforces a set of rules on asm code and C inline
23 * assembly code so that stack traces can be reliable.
25 * For more information, see tools/objtool/Documentation/stack-validation.txt.
30 #include <subcmd/parse-options.h>
38 #include <linux/hashtable.h>
40 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
42 #define STATE_FP_SAVED 0x1
43 #define STATE_FP_SETUP 0x2
44 #define STATE_FENTRY 0x4
47 struct list_head list
;
48 struct hlist_node hash
;
51 unsigned int len
, state
;
53 unsigned long immediate
;
54 bool alt_group
, visited
;
55 struct symbol
*call_dest
;
56 struct instruction
*jump_dest
;
57 struct list_head alts
;
62 struct list_head list
;
63 struct instruction
*insn
;
68 struct list_head insn_list
;
69 DECLARE_HASHTABLE(insn_hash
, 16);
70 struct section
*rodata
, *whitelist
;
71 bool ignore_unreachables
, c_file
;
77 static struct instruction
*find_insn(struct objtool_file
*file
,
78 struct section
*sec
, unsigned long offset
)
80 struct instruction
*insn
;
82 hash_for_each_possible(file
->insn_hash
, insn
, hash
, offset
)
83 if (insn
->sec
== sec
&& insn
->offset
== offset
)
89 static struct instruction
*next_insn_same_sec(struct objtool_file
*file
,
90 struct instruction
*insn
)
92 struct instruction
*next
= list_next_entry(insn
, list
);
94 if (&next
->list
== &file
->insn_list
|| next
->sec
!= insn
->sec
)
100 static bool gcov_enabled(struct objtool_file
*file
)
105 list_for_each_entry(sec
, &file
->elf
->sections
, list
)
106 list_for_each_entry(sym
, &sec
->symbol_list
, list
)
107 if (!strncmp(sym
->name
, "__gcov_.", 8))
113 #define for_each_insn(file, insn) \
114 list_for_each_entry(insn, &file->insn_list, list)
116 #define func_for_each_insn(file, func, insn) \
117 for (insn = find_insn(file, func->sec, func->offset); \
118 insn && &insn->list != &file->insn_list && \
119 insn->sec == func->sec && \
120 insn->offset < func->offset + func->len; \
121 insn = list_next_entry(insn, list))
123 #define func_for_each_insn_continue_reverse(file, func, insn) \
124 for (insn = list_prev_entry(insn, list); \
125 &insn->list != &file->insn_list && \
126 insn->sec == func->sec && insn->offset >= func->offset; \
127 insn = list_prev_entry(insn, list))
129 #define sec_for_each_insn_from(file, insn) \
130 for (; insn; insn = next_insn_same_sec(file, insn))
134 * Check if the function has been manually whitelisted with the
135 * STACK_FRAME_NON_STANDARD macro, or if it should be automatically whitelisted
136 * due to its use of a context switching instruction.
138 static bool ignore_func(struct objtool_file
*file
, struct symbol
*func
)
141 struct instruction
*insn
;
143 /* check for STACK_FRAME_NON_STANDARD */
144 if (file
->whitelist
&& file
->whitelist
->rela
)
145 list_for_each_entry(rela
, &file
->whitelist
->rela
->rela_list
, list
) {
146 if (rela
->sym
->type
== STT_SECTION
&&
147 rela
->sym
->sec
== func
->sec
&&
148 rela
->addend
== func
->offset
)
150 if (rela
->sym
->type
== STT_FUNC
&& rela
->sym
== func
)
154 /* check if it has a context switching instruction */
155 func_for_each_insn(file
, func
, insn
)
156 if (insn
->type
== INSN_CONTEXT_SWITCH
)
163 * This checks to see if the given function is a "noreturn" function.
165 * For global functions which are outside the scope of this object file, we
166 * have to keep a manual list of them.
168 * For local functions, we have to detect them manually by simply looking for
169 * the lack of a return instruction.
176 static int __dead_end_function(struct objtool_file
*file
, struct symbol
*func
,
180 struct instruction
*insn
;
184 * Unfortunately these have to be hard coded because the noreturn
185 * attribute isn't provided in ELF data.
187 static const char * const global_noreturns
[] = {
192 "__module_put_and_exit",
194 "kvm_spurious_fault",
199 if (func
->bind
== STB_WEAK
)
202 if (func
->bind
== STB_GLOBAL
)
203 for (i
= 0; i
< ARRAY_SIZE(global_noreturns
); i
++)
204 if (!strcmp(func
->name
, global_noreturns
[i
]))
210 func_for_each_insn(file
, func
, insn
) {
213 if (insn
->type
== INSN_RETURN
)
221 * A function can have a sibling call instead of a return. In that
222 * case, the function's dead-end status depends on whether the target
223 * of the sibling call returns.
225 func_for_each_insn(file
, func
, insn
) {
226 if (insn
->sec
!= func
->sec
||
227 insn
->offset
>= func
->offset
+ func
->len
)
230 if (insn
->type
== INSN_JUMP_UNCONDITIONAL
) {
231 struct instruction
*dest
= insn
->jump_dest
;
232 struct symbol
*dest_func
;
235 /* sibling call to another file */
238 if (dest
->sec
!= func
->sec
||
239 dest
->offset
< func
->offset
||
240 dest
->offset
>= func
->offset
+ func
->len
) {
241 /* local sibling call */
242 dest_func
= find_symbol_by_offset(dest
->sec
,
247 if (recursion
== 5) {
248 WARN_FUNC("infinite recursion (objtool bug!)",
249 dest
->sec
, dest
->offset
);
253 return __dead_end_function(file
, dest_func
,
258 if (insn
->type
== INSN_JUMP_DYNAMIC
&& list_empty(&insn
->alts
))
266 static int dead_end_function(struct objtool_file
*file
, struct symbol
*func
)
268 return __dead_end_function(file
, func
, 0);
272 * Call the arch-specific instruction decoder for all the instructions and add
273 * them to the global instruction list.
275 static int decode_instructions(struct objtool_file
*file
)
279 unsigned long offset
;
280 struct instruction
*insn
;
283 list_for_each_entry(sec
, &file
->elf
->sections
, list
) {
285 if (!(sec
->sh
.sh_flags
& SHF_EXECINSTR
))
288 for (offset
= 0; offset
< sec
->len
; offset
+= insn
->len
) {
289 insn
= malloc(sizeof(*insn
));
290 memset(insn
, 0, sizeof(*insn
));
292 INIT_LIST_HEAD(&insn
->alts
);
294 insn
->offset
= offset
;
296 ret
= arch_decode_instruction(file
->elf
, sec
, offset
,
298 &insn
->len
, &insn
->type
,
303 if (!insn
->type
|| insn
->type
> INSN_LAST
) {
304 WARN_FUNC("invalid instruction type %d",
305 insn
->sec
, insn
->offset
, insn
->type
);
309 hash_add(file
->insn_hash
, &insn
->hash
, insn
->offset
);
310 list_add_tail(&insn
->list
, &file
->insn_list
);
313 list_for_each_entry(func
, &sec
->symbol_list
, list
) {
314 if (func
->type
!= STT_FUNC
)
317 if (!find_insn(file
, sec
, func
->offset
)) {
318 WARN("%s(): can't find starting instruction",
323 func_for_each_insn(file
, func
, insn
)
333 * Warnings shouldn't be reported for ignored functions.
335 static void add_ignores(struct objtool_file
*file
)
337 struct instruction
*insn
;
341 list_for_each_entry(sec
, &file
->elf
->sections
, list
) {
342 list_for_each_entry(func
, &sec
->symbol_list
, list
) {
343 if (func
->type
!= STT_FUNC
)
346 if (!ignore_func(file
, func
))
349 func_for_each_insn(file
, func
, insn
)
350 insn
->visited
= true;
356 * Find the destination instructions for all jumps.
358 static int add_jump_destinations(struct objtool_file
*file
)
360 struct instruction
*insn
;
362 struct section
*dest_sec
;
363 unsigned long dest_off
;
365 for_each_insn(file
, insn
) {
366 if (insn
->type
!= INSN_JUMP_CONDITIONAL
&&
367 insn
->type
!= INSN_JUMP_UNCONDITIONAL
)
374 rela
= find_rela_by_dest_range(insn
->sec
, insn
->offset
,
377 dest_sec
= insn
->sec
;
378 dest_off
= insn
->offset
+ insn
->len
+ insn
->immediate
;
379 } else if (rela
->sym
->type
== STT_SECTION
) {
380 dest_sec
= rela
->sym
->sec
;
381 dest_off
= rela
->addend
+ 4;
382 } else if (rela
->sym
->sec
->idx
) {
383 dest_sec
= rela
->sym
->sec
;
384 dest_off
= rela
->sym
->sym
.st_value
+ rela
->addend
+ 4;
391 insn
->jump_dest
= find_insn(file
, dest_sec
, dest_off
);
392 if (!insn
->jump_dest
) {
395 * This is a special case where an alt instruction
396 * jumps past the end of the section. These are
397 * handled later in handle_group_alt().
399 if (!strcmp(insn
->sec
->name
, ".altinstr_replacement"))
402 WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
403 insn
->sec
, insn
->offset
, dest_sec
->name
,
413 * Find the destination instructions for all calls.
415 static int add_call_destinations(struct objtool_file
*file
)
417 struct instruction
*insn
;
418 unsigned long dest_off
;
421 for_each_insn(file
, insn
) {
422 if (insn
->type
!= INSN_CALL
)
425 rela
= find_rela_by_dest_range(insn
->sec
, insn
->offset
,
428 dest_off
= insn
->offset
+ insn
->len
+ insn
->immediate
;
429 insn
->call_dest
= find_symbol_by_offset(insn
->sec
,
431 if (!insn
->call_dest
) {
432 WARN_FUNC("can't find call dest symbol at offset 0x%lx",
433 insn
->sec
, insn
->offset
, dest_off
);
436 } else if (rela
->sym
->type
== STT_SECTION
) {
437 insn
->call_dest
= find_symbol_by_offset(rela
->sym
->sec
,
439 if (!insn
->call_dest
||
440 insn
->call_dest
->type
!= STT_FUNC
) {
441 WARN_FUNC("can't find call dest symbol at %s+0x%x",
442 insn
->sec
, insn
->offset
,
443 rela
->sym
->sec
->name
,
448 insn
->call_dest
= rela
->sym
;
455 * The .alternatives section requires some extra special care, over and above
456 * what other special sections require:
458 * 1. Because alternatives are patched in-place, we need to insert a fake jump
459 * instruction at the end so that validate_branch() skips all the original
460 * replaced instructions when validating the new instruction path.
462 * 2. An added wrinkle is that the new instruction length might be zero. In
463 * that case the old instructions are replaced with noops. We simulate that
464 * by creating a fake jump as the only new instruction.
466 * 3. In some cases, the alternative section includes an instruction which
467 * conditionally jumps to the _end_ of the entry. We have to modify these
468 * jumps' destinations to point back to .text rather than the end of the
469 * entry in .altinstr_replacement.
471 * 4. It has been requested that we don't validate the !POPCNT feature path
472 * which is a "very very small percentage of machines".
474 static int handle_group_alt(struct objtool_file
*file
,
475 struct special_alt
*special_alt
,
476 struct instruction
*orig_insn
,
477 struct instruction
**new_insn
)
479 struct instruction
*last_orig_insn
, *last_new_insn
, *insn
, *fake_jump
;
480 unsigned long dest_off
;
482 last_orig_insn
= NULL
;
484 sec_for_each_insn_from(file
, insn
) {
485 if (insn
->offset
>= special_alt
->orig_off
+ special_alt
->orig_len
)
488 if (special_alt
->skip_orig
)
489 insn
->type
= INSN_NOP
;
491 insn
->alt_group
= true;
492 last_orig_insn
= insn
;
495 if (!next_insn_same_sec(file
, last_orig_insn
)) {
496 WARN("%s: don't know how to handle alternatives at end of section",
497 special_alt
->orig_sec
->name
);
501 fake_jump
= malloc(sizeof(*fake_jump
));
503 WARN("malloc failed");
506 memset(fake_jump
, 0, sizeof(*fake_jump
));
507 INIT_LIST_HEAD(&fake_jump
->alts
);
508 fake_jump
->sec
= special_alt
->new_sec
;
509 fake_jump
->offset
= -1;
510 fake_jump
->type
= INSN_JUMP_UNCONDITIONAL
;
511 fake_jump
->jump_dest
= list_next_entry(last_orig_insn
, list
);
513 if (!special_alt
->new_len
) {
514 *new_insn
= fake_jump
;
518 last_new_insn
= NULL
;
520 sec_for_each_insn_from(file
, insn
) {
521 if (insn
->offset
>= special_alt
->new_off
+ special_alt
->new_len
)
524 last_new_insn
= insn
;
526 if (insn
->type
!= INSN_JUMP_CONDITIONAL
&&
527 insn
->type
!= INSN_JUMP_UNCONDITIONAL
)
530 if (!insn
->immediate
)
533 dest_off
= insn
->offset
+ insn
->len
+ insn
->immediate
;
534 if (dest_off
== special_alt
->new_off
+ special_alt
->new_len
)
535 insn
->jump_dest
= fake_jump
;
537 if (!insn
->jump_dest
) {
538 WARN_FUNC("can't find alternative jump destination",
539 insn
->sec
, insn
->offset
);
544 if (!last_new_insn
) {
545 WARN_FUNC("can't find last new alternative instruction",
546 special_alt
->new_sec
, special_alt
->new_off
);
550 list_add(&fake_jump
->list
, &last_new_insn
->list
);
556 * A jump table entry can either convert a nop to a jump or a jump to a nop.
557 * If the original instruction is a jump, make the alt entry an effective nop
558 * by just skipping the original instruction.
560 static int handle_jump_alt(struct objtool_file
*file
,
561 struct special_alt
*special_alt
,
562 struct instruction
*orig_insn
,
563 struct instruction
**new_insn
)
565 if (orig_insn
->type
== INSN_NOP
)
568 if (orig_insn
->type
!= INSN_JUMP_UNCONDITIONAL
) {
569 WARN_FUNC("unsupported instruction at jump label",
570 orig_insn
->sec
, orig_insn
->offset
);
574 *new_insn
= list_next_entry(orig_insn
, list
);
579 * Read all the special sections which have alternate instructions which can be
580 * patched in or redirected to at runtime. Each instruction having alternate
581 * instruction(s) has them added to its insn->alts list, which will be
582 * traversed in validate_branch().
584 static int add_special_section_alts(struct objtool_file
*file
)
586 struct list_head special_alts
;
587 struct instruction
*orig_insn
, *new_insn
;
588 struct special_alt
*special_alt
, *tmp
;
589 struct alternative
*alt
;
592 ret
= special_get_alts(file
->elf
, &special_alts
);
596 list_for_each_entry_safe(special_alt
, tmp
, &special_alts
, list
) {
597 alt
= malloc(sizeof(*alt
));
599 WARN("malloc failed");
604 orig_insn
= find_insn(file
, special_alt
->orig_sec
,
605 special_alt
->orig_off
);
607 WARN_FUNC("special: can't find orig instruction",
608 special_alt
->orig_sec
, special_alt
->orig_off
);
614 if (!special_alt
->group
|| special_alt
->new_len
) {
615 new_insn
= find_insn(file
, special_alt
->new_sec
,
616 special_alt
->new_off
);
618 WARN_FUNC("special: can't find new instruction",
619 special_alt
->new_sec
,
620 special_alt
->new_off
);
626 if (special_alt
->group
) {
627 ret
= handle_group_alt(file
, special_alt
, orig_insn
,
631 } else if (special_alt
->jump_or_nop
) {
632 ret
= handle_jump_alt(file
, special_alt
, orig_insn
,
638 alt
->insn
= new_insn
;
639 list_add_tail(&alt
->list
, &orig_insn
->alts
);
641 list_del(&special_alt
->list
);
649 static int add_switch_table(struct objtool_file
*file
, struct symbol
*func
,
650 struct instruction
*insn
, struct rela
*table
,
651 struct rela
*next_table
)
653 struct rela
*rela
= table
;
654 struct instruction
*alt_insn
;
655 struct alternative
*alt
;
657 list_for_each_entry_from(rela
, &file
->rodata
->rela
->rela_list
, list
) {
658 if (rela
== next_table
)
661 if (rela
->sym
->sec
!= insn
->sec
||
662 rela
->addend
<= func
->offset
||
663 rela
->addend
>= func
->offset
+ func
->len
)
666 alt_insn
= find_insn(file
, insn
->sec
, rela
->addend
);
668 WARN("%s: can't find instruction at %s+0x%x",
669 file
->rodata
->rela
->name
, insn
->sec
->name
,
674 alt
= malloc(sizeof(*alt
));
676 WARN("malloc failed");
680 alt
->insn
= alt_insn
;
681 list_add_tail(&alt
->list
, &insn
->alts
);
688 * find_switch_table() - Given a dynamic jump, find the switch jump table in
689 * .rodata associated with it.
691 * There are 3 basic patterns:
693 * 1. jmpq *[rodata addr](,%reg,8)
695 * This is the most common case by far. It jumps to an address in a simple
696 * jump table which is stored in .rodata.
698 * 2. jmpq *[rodata addr](%rip)
700 * This is caused by a rare GCC quirk, currently only seen in three driver
701 * functions in the kernel, only with certain obscure non-distro configs.
703 * As part of an optimization, GCC makes a copy of an existing switch jump
704 * table, modifies it, and then hard-codes the jump (albeit with an indirect
705 * jump) to use a single entry in the table. The rest of the jump table and
706 * some of its jump targets remain as dead code.
708 * In such a case we can just crudely ignore all unreachable instruction
709 * warnings for the entire object file. Ideally we would just ignore them
710 * for the function, but that would require redesigning the code quite a
711 * bit. And honestly that's just not worth doing: unreachable instruction
712 * warnings are of questionable value anyway, and this is such a rare issue.
714 * 3. mov [rodata addr],%reg1
715 * ... some instructions ...
716 * jmpq *(%reg1,%reg2,8)
718 * This is a fairly uncommon pattern which is new for GCC 6. As of this
719 * writing, there are 11 occurrences of it in the allmodconfig kernel.
721 * TODO: Once we have DWARF CFI and smarter instruction decoding logic,
722 * ensure the same register is used in the mov and jump instructions.
724 static struct rela
*find_switch_table(struct objtool_file
*file
,
726 struct instruction
*insn
)
728 struct rela
*text_rela
, *rodata_rela
;
729 struct instruction
*orig_insn
= insn
;
731 text_rela
= find_rela_by_dest_range(insn
->sec
, insn
->offset
, insn
->len
);
732 if (text_rela
&& text_rela
->sym
== file
->rodata
->sym
) {
734 rodata_rela
= find_rela_by_dest(file
->rodata
,
740 rodata_rela
= find_rela_by_dest(file
->rodata
,
741 text_rela
->addend
+ 4);
744 file
->ignore_unreachables
= true;
749 func_for_each_insn_continue_reverse(file
, func
, insn
) {
750 if (insn
->type
== INSN_JUMP_DYNAMIC
)
753 /* allow small jumps within the range */
754 if (insn
->type
== INSN_JUMP_UNCONDITIONAL
&&
756 (insn
->jump_dest
->offset
<= insn
->offset
||
757 insn
->jump_dest
->offset
> orig_insn
->offset
))
760 text_rela
= find_rela_by_dest_range(insn
->sec
, insn
->offset
,
762 if (text_rela
&& text_rela
->sym
== file
->rodata
->sym
)
763 return find_rela_by_dest(file
->rodata
,
770 static int add_func_switch_tables(struct objtool_file
*file
,
773 struct instruction
*insn
, *prev_jump
= NULL
;
774 struct rela
*rela
, *prev_rela
= NULL
;
777 func_for_each_insn(file
, func
, insn
) {
778 if (insn
->type
!= INSN_JUMP_DYNAMIC
)
781 rela
= find_switch_table(file
, func
, insn
);
786 * We found a switch table, but we don't know yet how big it
787 * is. Don't add it until we reach the end of the function or
788 * the beginning of another switch table in the same function.
791 ret
= add_switch_table(file
, func
, prev_jump
, prev_rela
,
802 ret
= add_switch_table(file
, func
, prev_jump
, prev_rela
, NULL
);
811 * For some switch statements, gcc generates a jump table in the .rodata
812 * section which contains a list of addresses within the function to jump to.
813 * This finds these jump tables and adds them to the insn->alts lists.
815 static int add_switch_table_alts(struct objtool_file
*file
)
821 if (!file
->rodata
|| !file
->rodata
->rela
)
824 list_for_each_entry(sec
, &file
->elf
->sections
, list
) {
825 list_for_each_entry(func
, &sec
->symbol_list
, list
) {
826 if (func
->type
!= STT_FUNC
)
829 ret
= add_func_switch_tables(file
, func
);
838 static int decode_sections(struct objtool_file
*file
)
842 ret
= decode_instructions(file
);
848 ret
= add_jump_destinations(file
);
852 ret
= add_call_destinations(file
);
856 ret
= add_special_section_alts(file
);
860 ret
= add_switch_table_alts(file
);
867 static bool is_fentry_call(struct instruction
*insn
)
869 if (insn
->type
== INSN_CALL
&&
870 insn
->call_dest
->type
== STT_NOTYPE
&&
871 !strcmp(insn
->call_dest
->name
, "__fentry__"))
877 static bool has_modified_stack_frame(struct instruction
*insn
)
879 return (insn
->state
& STATE_FP_SAVED
) ||
880 (insn
->state
& STATE_FP_SETUP
);
883 static bool has_valid_stack_frame(struct instruction
*insn
)
885 return (insn
->state
& STATE_FP_SAVED
) &&
886 (insn
->state
& STATE_FP_SETUP
);
889 static unsigned int frame_state(unsigned long state
)
891 return (state
& (STATE_FP_SAVED
| STATE_FP_SETUP
));
895 * Follow the branch starting at the given instruction, and recursively follow
896 * any other branches (jumps). Meanwhile, track the frame pointer state at
897 * each instruction and validate all the rules described in
898 * tools/objtool/Documentation/stack-validation.txt.
900 static int validate_branch(struct objtool_file
*file
,
901 struct instruction
*first
, unsigned char first_state
)
903 struct alternative
*alt
;
904 struct instruction
*insn
;
906 struct symbol
*func
= NULL
;
914 if (insn
->alt_group
&& list_empty(&insn
->alts
)) {
915 WARN_FUNC("don't know how to handle branch to middle of alternative instruction group",
921 if (file
->c_file
&& insn
->func
) {
922 if (func
&& func
!= insn
->func
) {
923 WARN("%s() falls through to next function %s()",
924 func
->name
, insn
->func
->name
);
932 if (frame_state(insn
->state
) != frame_state(state
)) {
933 WARN_FUNC("frame pointer state mismatch",
941 insn
->visited
= true;
944 list_for_each_entry(alt
, &insn
->alts
, list
) {
945 ret
= validate_branch(file
, alt
->insn
, state
);
950 switch (insn
->type
) {
954 if (state
& STATE_FP_SAVED
) {
955 WARN_FUNC("duplicate frame pointer save",
959 state
|= STATE_FP_SAVED
;
965 if (state
& STATE_FP_SETUP
) {
966 WARN_FUNC("duplicate frame pointer setup",
970 state
|= STATE_FP_SETUP
;
974 case INSN_FP_RESTORE
:
976 if (has_valid_stack_frame(insn
))
977 state
&= ~STATE_FP_SETUP
;
979 state
&= ~STATE_FP_SAVED
;
984 if (!nofp
&& has_modified_stack_frame(insn
)) {
985 WARN_FUNC("return without frame pointer restore",
992 if (is_fentry_call(insn
)) {
993 state
|= STATE_FENTRY
;
997 ret
= dead_end_function(file
, insn
->call_dest
);
1004 case INSN_CALL_DYNAMIC
:
1005 if (!nofp
&& !has_valid_stack_frame(insn
)) {
1006 WARN_FUNC("call without frame pointer save/setup",
1012 case INSN_JUMP_CONDITIONAL
:
1013 case INSN_JUMP_UNCONDITIONAL
:
1014 if (insn
->jump_dest
) {
1015 ret
= validate_branch(file
, insn
->jump_dest
,
1019 } else if (has_modified_stack_frame(insn
)) {
1020 WARN_FUNC("sibling call from callable instruction with changed frame pointer",
1023 } /* else it's a sibling call */
1025 if (insn
->type
== INSN_JUMP_UNCONDITIONAL
)
1030 case INSN_JUMP_DYNAMIC
:
1031 if (list_empty(&insn
->alts
) &&
1032 has_modified_stack_frame(insn
)) {
1033 WARN_FUNC("sibling call from callable instruction with changed frame pointer",
1047 insn
= next_insn_same_sec(file
, insn
);
1049 WARN("%s: unexpected end of section", sec
->name
);
1057 static bool is_kasan_insn(struct instruction
*insn
)
1059 return (insn
->type
== INSN_CALL
&&
1060 !strcmp(insn
->call_dest
->name
, "__asan_handle_no_return"));
1063 static bool is_ubsan_insn(struct instruction
*insn
)
1065 return (insn
->type
== INSN_CALL
&&
1066 !strcmp(insn
->call_dest
->name
,
1067 "__ubsan_handle_builtin_unreachable"));
1070 static bool ignore_unreachable_insn(struct symbol
*func
,
1071 struct instruction
*insn
)
1075 if (insn
->type
== INSN_NOP
)
1079 * Check if this (or a subsequent) instruction is related to
1080 * CONFIG_UBSAN or CONFIG_KASAN.
1082 * End the search at 5 instructions to avoid going into the weeds.
1084 for (i
= 0; i
< 5; i
++) {
1086 if (is_kasan_insn(insn
) || is_ubsan_insn(insn
))
1089 if (insn
->type
== INSN_JUMP_UNCONDITIONAL
&& insn
->jump_dest
) {
1090 insn
= insn
->jump_dest
;
1094 if (insn
->offset
+ insn
->len
>= func
->offset
+ func
->len
)
1096 insn
= list_next_entry(insn
, list
);
1102 static int validate_functions(struct objtool_file
*file
)
1104 struct section
*sec
;
1105 struct symbol
*func
;
1106 struct instruction
*insn
;
1107 int ret
, warnings
= 0;
1109 list_for_each_entry(sec
, &file
->elf
->sections
, list
) {
1110 list_for_each_entry(func
, &sec
->symbol_list
, list
) {
1111 if (func
->type
!= STT_FUNC
)
1114 insn
= find_insn(file
, sec
, func
->offset
);
1118 ret
= validate_branch(file
, insn
, 0);
1123 list_for_each_entry(sec
, &file
->elf
->sections
, list
) {
1124 list_for_each_entry(func
, &sec
->symbol_list
, list
) {
1125 if (func
->type
!= STT_FUNC
)
1128 func_for_each_insn(file
, func
, insn
) {
1132 insn
->visited
= true;
1134 if (file
->ignore_unreachables
|| warnings
||
1135 ignore_unreachable_insn(func
, insn
))
1139 * gcov produces a lot of unreachable
1140 * instructions. If we get an unreachable
1141 * warning and the file has gcov enabled, just
1142 * ignore it, and all other such warnings for
1145 if (!file
->ignore_unreachables
&&
1146 gcov_enabled(file
)) {
1147 file
->ignore_unreachables
= true;
1151 WARN_FUNC("function has unreachable instruction", insn
->sec
, insn
->offset
);
1160 static int validate_uncallable_instructions(struct objtool_file
*file
)
1162 struct instruction
*insn
;
1165 for_each_insn(file
, insn
) {
1166 if (!insn
->visited
&& insn
->type
== INSN_RETURN
) {
1167 WARN_FUNC("return instruction outside of a callable function",
1168 insn
->sec
, insn
->offset
);
1176 static void cleanup(struct objtool_file
*file
)
1178 struct instruction
*insn
, *tmpinsn
;
1179 struct alternative
*alt
, *tmpalt
;
1181 list_for_each_entry_safe(insn
, tmpinsn
, &file
->insn_list
, list
) {
1182 list_for_each_entry_safe(alt
, tmpalt
, &insn
->alts
, list
) {
1183 list_del(&alt
->list
);
1186 list_del(&insn
->list
);
1187 hash_del(&insn
->hash
);
1190 elf_close(file
->elf
);
1193 const char * const check_usage
[] = {
1194 "objtool check [<options>] file.o",
1198 int cmd_check(int argc
, const char **argv
)
1200 struct objtool_file file
;
1201 int ret
, warnings
= 0;
1203 const struct option options
[] = {
1204 OPT_BOOLEAN('f', "no-fp", &nofp
, "Skip frame pointer validation"),
1208 argc
= parse_options(argc
, argv
, options
, check_usage
, 0);
1211 usage_with_options(check_usage
, options
);
1215 file
.elf
= elf_open(objname
);
1217 fprintf(stderr
, "error reading elf file %s\n", objname
);
1221 INIT_LIST_HEAD(&file
.insn_list
);
1222 hash_init(file
.insn_hash
);
1223 file
.whitelist
= find_section_by_name(file
.elf
, "__func_stack_frame_non_standard");
1224 file
.rodata
= find_section_by_name(file
.elf
, ".rodata");
1225 file
.ignore_unreachables
= false;
1226 file
.c_file
= find_section_by_name(file
.elf
, ".comment");
1228 ret
= decode_sections(&file
);
1233 ret
= validate_functions(&file
);
1238 ret
= validate_uncallable_instructions(&file
);
1246 /* ignore warnings for now until we get all the code cleaned up */
1247 if (ret
|| warnings
)