| blob | c5ec977b9c3786097b214e1c835efd8fa337c173 |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
60 Options:
65 --emacs emacs compile window format
66 --terse one line per report
80 is all off)
82 literally
85 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
86 with potential errors corrected to the preferred
87 checkpatch style
92 runtime errors.
95 --codespellfile Use this codespell dictionary
99 EOM
102 }
124 }
125 }
128 }
130 GetOptions(
171 }
172 }
177 }
193 }
194 }
203 }
205 }
206 }
216 ## no critic
219 }
226 }
232 }
239 }
240 }
245 }
246 }
256 __user|
257 __kernel|
258 __force|
259 __iomem|
260 __must_check|
261 __init_refok|
262 __kprobes|
263 __ref|
264 __rcu
272 # Notes to $Attribute:
273 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
275 const|
276 __percpu|
277 __nocast|
278 __safe|
279 __bitwise__|
280 __packed__|
281 __packed2__|
282 __naked|
283 __maybe_unused|
284 __always_unused|
285 __noreturn|
286 __used|
287 __cold|
288 __pure|
289 __noclone|
290 __deprecated|
291 __read_mostly|
292 __kprobes|
294 ____cacheline_aligned|
295 ____cacheline_aligned_in_smp|
296 ____cacheline_internodealigned_in_smp|
297 __weak
319 <=|>=|==|!=|
320 =>|->|<<|>>|<|>|!|~|
353 )};
357 atomic_t
358 )};
362 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
364 panic|
367 )};
376 To:|
377 Cc:
378 )};
397 );
420 );
425 );
429 );
435 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
438 );
440 #Create a search pattern for all these functions to speed up a loop below
445 }
448 S_IWUGO |
449 S_IWOTH |
450 S_IRWXUGO |
451 S_IALLUGO |
456 irq|
457 memory|
459 reboot
460 )};
461 # memory.h: ARM has a custom one
463 # Load common spelling mistakes and build regular expression list.
480 }
484 }
503 }
507 }
508 }
530 )
537 )
547 )
551 $NonptrType
556 $NonptrTypeMisordered
562 }
563 build_types();
567 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
568 # requires at least perl version v5.10.0
569 # Any use must be runtime checked with $^V
579 )};
588 }
593 }
617 }
618 }
619 }
643 }
645 }
653 }
657 }
662 }
666 }
674 }
676 }
677 }
691 # Maybe one day convert this block of bash into something that returns
692 # all matching commit ids, but it's very slow...
693 #
694 # echo "checking commits $1..."
695 # git rev-list --remotes | grep -i "^$1" |
696 # while read line ; do
697 # git log --format='%H %s' -1 $line |
698 # echo "commit $(cut -c 1-12,41-)"
699 # done
700 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
704 }
707 }
729 }
734 }
738 }
742 }
749 }
760 );
765 }
766 }
768 }
791 # If there's a name left after stripping spaces and
792 # leading quotes, and the address doesn't have both
793 # leading and trailing angle brackets, the address
794 # is invalid. ie:
795 # "joe smith joe@smith.com" bad
796 # "joe smith <joe@smith.com" bad
801 }
802 }
812 }
815 }
829 }
835 }
838 }
846 }
847 }
850 }
858 }
859 }
862 }
875 }
877 }
880 }
883 }
887 }
892 # Drop the diff line leader and expand tabs
896 # Pick the indent from the front of the line.
900 }
911 }
912 }
923 # Always copy over the diff marker.
929 # Comments we are wacking completly including the begin
930 # and end, all to $;.
937 }
943 }
950 }
952 # A \ in a string means ignore the next character.
958 }
959 # Regular quotes.
968 }
969 }
971 #print "c<$c> SQ<$sanitise_quote>\n";
980 }
981 }
985 }
987 # The pathname on a #include may be surrounded by '<' and '>'.
992 # The whole of a #error is a string.
996 }
999 }
1006 }
1029 #warn "CSB: blk<$blk> remain<$remain>\n";
1030 # If we are about to drop off the end, pull in more
1031 # context.
1042 }
1043 # Bail if there is no further context.
1044 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
1047 }
1051 }
1052 }
1057 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1059 # Handle nested #if/#else.
1066 }
1068 # Statement ends at the ';' or a close '}' at the
1069 # outermost level.
1072 }
1074 # An else is really a conditional as long as its not else if
1081 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1082 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1083 }
1088 }
1096 #warn "CSB: mark coff<$coff>\n";
1097 }
1098 }
1102 }
1110 }
1112 }
1113 }
1114 # Preprocessor commands end at the newline unless escaped.
1120 }
1122 }
1123 # We are truly at the end, so shuffle to the next line.
1128 }
1133 #warn "STATEMENT<$statement>\n";
1134 #warn "CONDITION<$condition>\n";
1136 #print "coff<$coff> soff<$off> loff<$loff>\n";
1140 }
1145 # Strip the diff line prefixes and rip blank lines at start and end.
1153 }
1161 }
1182 }
1183 }
1191 # Grab the first conditional/block pair.
1194 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1198 }
1200 # Pull in the following conditional/block pairs and see if they
1201 # could continue the statement.
1205 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1207 #print "C: push\n";
1209 }
1212 }
1231 # Handle nested #if/#else.
1238 }
1241 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1245 }
1252 }
1253 }
1257 }
1260 }
1263 }
1269 }
1275 }
1281 }
1286 }
1291 }
1296 # Catch a comment on the end of the line itself.
1300 # Look through the context and try and figure out if there is a
1301 # comment.
1306 #warn " $line\n";
1309 }
1312 }
1315 }
1319 }
1320 }
1324 }
1329 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1330 ##print "CMMT: $cmt\n";
1333 }
1346 }
1349 }
1361 }
1362 }
1366 }
1378 }
1398 }
1419 }
1448 # Assume all arms of the conditional end as this
1449 # one does, and continue as if the #endif was not here.
1466 }
1497 }
1509 }
1542 }
1557 }
1566 }
1570 }
1574 }
1575 }
1578 }
1587 DEFINE_\S+
1588 )$|
1592 case|
1596 \#|
1597 \#\#|
1603 # Check for modifiers.
1614 }
1615 }
1620 }
1621 build_types();
1624 }
1625 }
1635 }
1643 }
1649 }
1655 }
1659 }
1670 }
1671 }
1698 }
1704 }
1711 }
1716 }
1719 }
1722 }
1730 };
1732 }
1740 };
1743 }
1752 }
1754 }
1762 }
1764 }
1772 }
1774 }
1780 ##print "absolute<$absolute>\n";
1782 # See if any suffix of this path is a path within the tree.
1785 ##print "file<$file>\n";
1787 }
1788 }
1791 }
1793 # It is, so see if the prefix is acceptable.
1797 ##print "prefix<$prefix>\n";
1801 }
1802 }
1810 }
1818 }
1826 }
1834 }
1843 #convert leading spaces to tabs
1845 #Remove spaces before a tab
1849 }
1863 }
1875 }
1876 }
1879 }
1914 # Trace the real file/line as we go.
1926 # suppression flags
1934 # Pre-scan the patch sanitizing the lines.
1935 # Pre-scan the patch looking for any __setup documentation.
1936 #
1942 sanitise_line_reset();
1954 }
1955 #next;
1956 }
1963 }
1966 # Guestimate if this is a continuing comment. Run
1967 # the context looking for a comment "edge". If this
1968 # edge is a close comment then we must be in a comment
1969 # at context start.
1976 #print "RAW<$rawlines[$ln - 1]>\n";
1982 }
1983 }
1986 }
1988 # Guestimate if this is a continuing comment. If this
1989 # is the start of a diff block and this line starts
1990 # ' *' then it is very likely a comment.
1993 {
1995 }
1997 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
2001 # Standardise the strings and chars within the input to
2002 # simplify matching -- only bother with positive lines.
2004 }
2011 }
2013 #print "==>$rawline\n";
2014 #print "-->$line\n";
2018 }
2019 }
2034 #extract the line range in the file after the patch is applied
2043 }
2044 annotate_reset();
2053 # track the line number as we move through the hunk, note that
2054 # new versions of GNU diff omit the leading space on completely
2055 # blank context lines so we need to count that too.
2060 # Measure the line length and indent.
2063 # Track the previous line.
2068 #warn "line<$line>\n";
2072 }
2076 #make up the handle for any error we report on this line
2084 # extract the filename as it passes
2100 }
2104 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2105 }
2107 }
2114 }
2116 }
2126 # Check for incorrect file permissions
2133 }
2134 }
2136 # Check the patch for a signoff:
2140 }
2142 # Check if MAINTAINERS is being updated. If so, there's probably no need to
2143 # emit the "does MAINTAINERS need updating?" message on file add/move/delete
2146 }
2148 # Check signature styles
2160 }
2167 }
2168 }
2175 }
2177 }
2184 }
2185 }
2196 # Don't force email to have quotes
2197 # Allow just an angle bracketed address
2203 }
2204 }
2206 # Check for duplicate signatures
2215 }
2216 }
2218 # Check email subject for common tools that don't need to be mentioned
2223 }
2225 # Check for old stable address
2229 }
2231 # Check for unwanted Gerrit info
2235 }
2237 # Check for line lengths > 75 in commit log, warn once
2243 }
2245 # Check for git id commit length and improperly formed commit descriptions
2279 }
2286 "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herecurr);
2287 }
2288 }
2290 # Check for added, moved or deleted files
2299 }
2301 # Check for wrappage within a valid hunk of the file
2306 }
2308 # Check for absolute kernel paths.
2315 #
2318 }
2319 }
2320 }
2322 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2333 }
2335 # Check if it's the start of a commit log
2336 # (not a header line and we haven't seen the patch filename)
2342 }
2344 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2345 # declined it, i.e defined some charset where it is missing.
2350 }
2356 }
2358 # Check for various typo / spelling mistakes
2372 }
2373 }
2374 }
2376 # ignore non-hunk lines and lines being removed
2379 #trailing whitespace
2386 }
2393 }
2396 }
2398 # Check for FSF mailing addresses.
2406 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2407 }
2409 # check for Kconfig help text having a real description
2410 # Only applies when adding the entry originally, after that we do not have
2411 # sufficient context to determine whether it is indeed long enough.
2432 }
2441 }
2443 }
2447 }
2448 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2449 }
2451 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2455 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2456 }
2458 # discourage the use of boolean for type definition attributes of Kconfig options
2463 }
2473 };
2476 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2477 }
2479 # check for DT compatible documentation
2498 }
2505 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2506 }
2507 }
2508 }
2510 # check we are in a valid source file if not then ignore this hunk
2513 #line length limit
2520 {
2523 }
2525 # check for adding lines without a newline.
2526 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2529 }
2531 # Blackfin: use hi/lo macros
2537 }
2542 }
2543 }
2545 # check we are in a valid source file C or perl if not then ignore this hunk
2548 # at the beginning of a line any tabs must come first and anything
2549 # more than 8 must use tabs.
2558 }
2559 }
2561 # check for space before tabs.
2571 }
2572 }
2574 # check for && or || at the start of a line
2578 }
2580 # check multi-line statement indentation matches previous line
2582 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2605 }
2606 }
2607 }
2608 }
2610 # check for space after cast like "(int) foo" or "(struct foo) bar"
2611 # avoid checking a few false positives:
2612 # "sizeof(<type>)" or "__alignof__(<type>)"
2613 # function pointer declarations like "(*foo)(int) = bar;"
2614 # structure definitions like "(struct foo) { 0 };"
2615 # multiline macros that define functions
2616 # known attributes or the __attribute__ keyword
2624 }
2625 }
2633 }
2642 }
2651 }
2653 # check for missing blank lines after struct/union declarations
2654 # with exceptions for various attributes and macros
2669 }
2670 }
2672 # check for multiple consecutive blank lines
2680 }
2683 }
2685 # check for missing blank lines after declarations
2687 # actual declarations
2689 # function pointer declarations
2691 # foo bar; where foo is some local typedef or #define
2693 # known declaration macros
2695 # for "else if" which can look like "$Ident $Ident"
2697 # other possible extensions of declaration lines
2699 # not starting a section or a macro "\" extended line
2701 # looks like a declaration
2703 # function pointer declarations
2705 # foo bar; where foo is some local typedef or #define
2707 # known declaration macros
2709 # start of struct or union or enum
2711 # start or end of block or continuation of declaration
2713 # bitfield continuation
2715 # other possible extensions of declaration lines
2717 # indentation of previous and current line are the same
2723 }
2724 }
2726 # check for spaces at the beginning of a line.
2727 # Exceptions:
2728 # 1) within comments
2729 # 2) indented preprocessor commands
2730 # 3) hanging labels
2737 }
2738 }
2740 # check we are in a valid C source file if not then ignore this hunk
2743 # check indentation of any line with a bare else
2744 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
2745 # if the previous line is a break or return and is indented 1 tab more...
2754 }
2755 }
2757 # check indentation of a line with a break;
2758 # if the previous line is a goto or return and is indented the same # of tabs
2764 }
2765 }
2767 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2770 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2771 }
2773 # check for RCS/CVS revision markers
2777 }
2779 # Blackfin: don't use __builtin_bfin_[cs]sync
2784 }
2789 }
2791 # check for old HOTPLUG __dev<foo> section markings
2795 }
2797 # Check for potential 'bare' types
2800 #print "LINE<$line>\n";
2808 #print "linenr<$linenr> <$stat>\n";
2809 # If this statement has no statement boundaries within
2810 # it there is no point in retrying a statement scan
2811 # until we hit end of it.
2814 #print "skip<$line_nr_next>\n";
2816 }
2818 # Find the real next line.
2824 }
2829 # Ignore goto labels.
2832 # Ignore functions being called
2837 # declarations always start with types
2838 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2843 # definitions in global scope can only start with types
2846 }
2848 # any (foo ... *) is a pointer cast, and foo is a type
2851 }
2853 # Check for any sort of function declaration.
2854 # int foo(something bar, other baz);
2855 # void (*store_gdt)(x86_descr_ptr *);
2856 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2864 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2867 }
2868 }
2869 }
2871 }
2873 #
2874 # Checks which may be anchored in the context.
2875 #
2877 # Check for switch () and associated case and default
2878 # statements should be at the same indent.
2892 }
2893 }
2897 }
2898 }
2900 # if/while/etc brace do not go on next line, unless defining a do while loop,
2901 # or if that brace on the next line is for something else
2902 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2910 }
2921 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2924 }
2926 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2927 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2933 }
2937 {
2943 }
2944 }
2945 }
2947 # Check relative indent for conditionals and blocks.
2948 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2956 # Make sure we remove the line prefixes as we have
2957 # none on the first line, and are going to readd them
2958 # where necessary.
2961 # Find out how long the conditional actually is.
2965 # We want to check the first line inside the block
2966 # starting at the end of the conditional, so remove:
2967 # 1) any blank line termination
2968 # 2) any opening brace { on end of the line
2969 # 3) any do (...) {
2976 }
2980 }
2982 # Also ignore a loop construct at the end of a
2983 # preprocessor statement.
2987 }
2994 # If we see an #else/#elif then the code
2995 # is not linear.
2998 }
3000 # Ignore:
3001 # 1) blank lines, they should be at 0,
3002 # 2) preprocessor lines, and
3003 # 3) labels.
3011 }
3012 }
3013 }
3018 # Check if either of these lines are modified, else
3019 # this is not this patch's fault.
3023 }
3026 }
3028 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
3033 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
3034 }
3035 }
3037 # Track the 'values' across context and added lines.
3047 }
3050 #ignore lines not being added
3053 # TEST: allow direct testing of the type matcher.
3061 }
3063 }
3064 # TEST: allow direct testing of the attribute matcher.
3072 }
3074 }
3076 # check for initialisation to aggregates open brace on the next line
3090 }
3091 }
3093 #
3094 # Checks which are anchored on the added line.
3095 #
3097 # check for malformed paths in #include statements (uses RAW line)
3103 }
3107 }
3108 }
3110 # no C99 // comments
3119 }
3120 }
3121 }
3122 # Remove C99 comments.
3126 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
3127 # the whole statement.
3128 #print "APW <$lines[$realline_next - 1]>\n";
3134 # Handle definitions which produce identifiers with
3135 # a prefix:
3136 # XXX(foo);
3137 # EXPORT_SYMBOL(something_foo);
3141 #print "FOO C name<$name>\n";
3152 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
3156 }
3157 }
3162 #print "FOO B <$lines[$linenr - 1]>\n";
3164 }
3169 }
3171 # check for global initialisers.
3178 }
3179 }
3180 # check for static initialisers.
3187 }
3188 }
3190 # check for misordered declarations of char/short/int/long with signed/unsigned
3194 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
3195 }
3197 # check for static const char * arrays.
3202 }
3204 # check for static char foo[] = "bar" declarations.
3209 }
3211 # check for const <foo> const where <foo> is not a pointer or array type
3220 }
3221 }
3223 # check for non-global char *foo[] = {"bar", ...} declarations.
3228 }
3230 # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
3233 if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {
3239 }
3240 }
3241 }
3243 # check for function declarations without arguments like "int foo()"
3249 }
3250 }
3252 # check for uses of DEFINE_PCI_DEVICE_TABLE
3257 $fixed[$fixlinenr] =~ s/\b(?:static\s+|)DEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=\s*/static const struct pci_device_id $1\[\] = /;
3258 }
3259 }
3261 # check for new typedefs, only function parameters and sparse annotations
3262 # make sense.
3271 }
3273 # * goes on variable not on type
3274 # (char*[ const])
3276 #print "AA<$1>\n";
3279 # Should start with a space.
3281 # Should not end with a space.
3283 # '*'s should not have spaces between.
3285 }
3287 ## print "1: from<$from> to<$to> ident<$ident>\n";
3297 }
3298 }
3299 }
3301 #print "BB<$1>\n";
3304 # Should start with a space.
3306 # Should not end with a space.
3308 # '*'s should not have spaces between.
3310 }
3311 # Modifiers should have spaces.
3314 ## print "2: from<$from> to<$to> ident<$ident>\n";
3325 }
3326 }
3327 }
3329 # # no BUG() or BUG_ON()
3330 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
3331 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
3332 # print "$herecurr";
3333 # $clean = 0;
3334 # }
3338 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
3339 }
3341 # check for uses of printk_ratelimit
3345 }
3347 # printk should use KERN_* levels. Note that follow on printk's on the
3348 # same line do not need a level, so we use the current block context
3349 # to try and find and validate the current printk. In summary the current
3350 # printk includes all preceding printk's which have no newline on the end.
3351 # we assume the first bad printk is the one to report.
3355 #print "CHECK<$lines[$ln - 1]\n";
3356 # we have a preceding printk if it ends
3357 # with "\n" ignore it, else it is to blame
3361 }
3363 }
3364 }
3368 }
3369 }
3378 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
3379 }
3387 }
3388 }
3397 }
3399 # ENOSYS means "bad syscall nr" and nothing else. This will have a small
3400 # number of false positives, but assembly files are not checked, so at
3401 # least the arch entry code will not trigger this warning.
3405 }
3407 # function brace can't be on same line, except for #defines of do while,
3408 # or if closed on same line
3423 }
3424 }
3425 }
3427 # open braces for enum, union and struct go on the same line.
3441 }
3442 }
3443 }
3445 # missing space after union, struct or enum definition
3452 }
3453 }
3455 # Function pointer declarations
3456 # check spacing between type, funcptr, and args
3457 # canonical declaration is "type (*funcptr)(args...)"
3466 # the $Declare variable will capture all spaces after the type
3467 # so check it for a missing trailing missing space but pointer return types
3468 # don't need a space so don't warn for those.
3473 }
3478 }
3480 # unnecessary space "type (*funcptr)(args...)"
3481 # This test is not currently implemented because these declarations are
3482 # equivalent to
3483 # int foo(int bar, ...)
3484 # and this is form shouldn't/doesn't generate a checkpatch warning.
3485 #
3486 # elsif ($declare =~ /\s{2,}$/) {
3487 # WARN("SPACING",
3488 # "Multiple spaces after return type\n" . $herecurr);
3489 # }
3491 # unnecessary space "type ( *funcptr)(args...)"
3496 }
3498 # unnecessary space "type (* funcptr)(args...)"
3503 }
3505 # unnecessary space "type (*funcptr )(args...)"
3510 }
3512 # unnecessary space "type (*funcptr) (args...)"
3517 }
3521 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3522 }
3523 }
3525 # check for spacing round square brackets; allowed:
3526 # 1. with a type on the left -- int [] a;
3527 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3528 # 3. inside a curly brace -- = { [0...10] = 5 }
3539 }
3540 }
3541 }
3543 # check for spaces between functions and their parentheses.
3549 # Ignore those directives where spaces _are_ permitted.
3555 {
3556 # cpp #define statements have non-optional spaces, ie
3557 # if there is a space between the name and the open
3558 # parenthesis it is simply not a parameter group.
3561 # cpp #elif statement condition may start with a (
3564 # If this whole things ends with a type its most
3565 # likely a typedef for a function.
3574 }
3575 }
3576 }
3578 # Check operator spacing.
3584 <<=|>>=|<=|>=|==|!=|
3586 =>|->|<<|>>|<|>|=|!|~|
3592 ## print("element count: <" . $#elements . ">\n");
3593 ## foreach my $el (@elements) {
3594 ## print("el: <$el>\n");
3595 ## }
3603 }
3614 ## print("n: <$n> good: <$good>\n");
3618 # Pick up the preceding and succeeding characters.
3623 }
3646 }
3655 # Pull out the value of this operator.
3658 # Get the full operator variant.
3661 # Ignore operators passed as parameters.
3665 # # Ignore comments
3666 # } elsif ($op =~ /^$;+$/) {
3668 # ; should have either the end of line or a space or \ after it
3676 }
3677 }
3679 # // is a comment
3682 # : when part of a bitfield
3684 # skip the bitfield test for now
3686 # No spaces for:
3687 # ->
3695 }
3697 }
3698 }
3700 # , must not have a space before and must have a space on the right.
3709 }
3710 }
3717 }
3718 }
3724 }
3727 }
3728 }
3730 # '*' as part of a type definition -- reported already.
3732 #warn "'*' is part of type\n";
3734 # unary operators should have a space before and
3735 # none after. May be left adjacent to another
3736 # unary operator, or a cast
3746 }
3747 }
3748 }
3750 # A unary '*' may be const
3758 }
3760 }
3761 }
3763 # unary ++ and unary -- are allowed no space on one side.
3770 }
3771 }
3778 }
3779 }
3786 }
3788 }
3789 }
3791 # << and >> may either have or not have spaces both sides
3797 {
3805 }
3811 }
3812 }
3819 }
3821 }
3822 }
3824 # A colon needs no spaces before when it is
3825 # terminating a case value or a label.
3832 }
3833 }
3835 # All the others need spaces both sides.
3839 # Ignore email addresses <foo@bar>
3844 {
3846 }
3848 # for asm volatile statements
3849 # ignore a colon with another
3850 # colon immediately before or after
3854 }
3856 # messages are ERROR, but ?: are CHK
3866 }
3868 }
3869 }
3870 }
3873 ## print("n: <$n> GOOD: <$good>\n");
3876 }
3880 }
3884 }
3887 }
3889 # check for whitespace before a non-naked semicolon
3896 }
3897 }
3899 # check for multiple assignments
3903 }
3905 ## # check for multiple declarations, allowing for a function declaration
3906 ## # continuation.
3907 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
3908 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
3909 ##
3910 ## # Remove any bracketed sections to ensure we do not
3911 ## # falsly report the parameters of functions.
3912 ## my $ln = $line;
3913 ## while ($ln =~ s/\([^\(\)]*\)//g) {
3914 ## }
3915 ## if ($ln =~ /,/) {
3916 ## WARN("MULTIPLE_DECLARATION",
3917 ## "declaring multiple variables together should be avoided\n" . $herecurr);
3918 ## }
3919 ## }
3921 #need space before brace following if, while, etc
3928 }
3929 }
3931 ## # check for blank lines before declarations
3932 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
3933 ## $prevrawline =~ /^.\s*$/) {
3934 ## WARN("SPACING",
3935 ## "No blank lines before declarations\n" . $hereprev);
3936 ## }
3937 ##
3939 # closing brace should have a space following it when it has anything
3940 # on the line
3947 }
3948 }
3950 # check spacing on square brackets
3957 }
3958 }
3965 }
3966 }
3968 # check spacing on parentheses
3976 }
3977 }
3986 }
3987 }
3989 # check unnecessary parentheses around addressof/dereference single $Lvals
3990 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
3998 }
3999 }
4001 # check for unnecessary parentheses around function pointer uses
4002 # ie: (foo->bar)(); should be foo->bar();
4003 # but not "if (foo->bar) (" to avoid some false positives
4012 }
4013 }
4015 #goto labels aren't indented, allow a single space however
4023 }
4024 }
4026 # return is not a function
4036 }
4040 }
4041 }
4043 # unnecessary return in a void function
4044 # at end-of-function, with the previous line a single leading tab, then return;
4045 # and the line before that not a goto label target like "out:"
4053 }
4055 # if statements using unnecessary parentheses - ie: if ((foo == bar))
4061 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
4066 }
4067 }
4069 # Return of what appears to be an errno should normally be negative
4075 }
4076 }
4078 # Need a space before open parenthesis after if, while etc
4085 }
4086 }
4088 # Check for illegal assignment in if conditional -- and check for trailing
4089 # statements after the conditional.
4097 ##print "stat<$stat> stat_next<$stat_next>\n";
4100 # If the statement carries leading newlines,
4101 # then count those as offsets.
4109 }
4110 }
4119 }
4121 # Find out what is on the end of the line after the
4122 # conditional.
4128 {
4129 # Find out how long the conditional actually is.
4138 }
4142 }
4143 }
4145 # Check for bitwise tests written as boolean
4151 |
4156 {
4159 }
4161 # if and else should not have general statements after it
4168 }
4169 }
4170 # if should not continue a brace
4175 }
4176 # case and default should not have general statements after them
4182 {
4185 }
4187 # Check for }<nl>else {, these must be at the same
4188 # indent level to be relevant to each other.
4200 }
4204 }
4205 }
4211 # Find out what is on the end of the line after the
4212 # conditional.
4228 }
4229 }
4230 }
4232 #Specific variable tests
4236 #gcc binary extension
4244 }
4245 }
4247 #CamelCase
4250 #Ignore Page<foo> variants
4252 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
4254 #Ignore some three character SI units explicitly, like MiB and KHz
4260 seed_camelcase_includes();
4264 }
4265 }
4270 }
4271 }
4272 }
4273 }
4275 #no spaces allowed after \ in define
4281 }
4282 }
4284 # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
4285 # itself <asm/foo.h> (uses RAW line)
4292 {
4301 }
4302 }
4303 }
4304 }
4306 # multi-statement macros should be enclosed in a do while loop, grab the
4307 # first statement and ensure its the whole macro if its not enclosed
4308 # in a known good container
4320 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
4321 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
4332 # Flatten any parentheses and braces
4336 {
4337 }
4339 # Flatten any obvious string concatentation.
4342 {
4343 }
4347 module_param_named|
4348 MODULE_PARM_DESC|
4349 DECLARE_PER_CPU|
4350 DEFINE_PER_CPU|
4351 __typeof__\(|
4352 union|
4353 struct|
4357 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
4361 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
4366 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
4372 {
4379 }
4387 }
4388 }
4390 # check for macros with flow control, but without ## concatenation
4391 # ## concatenation is commonly a macro that defines a function so ignore those
4398 }
4401 }
4403 # check for line continuations outside of #defines, preprocessor #, and asm
4412 }
4413 }
4415 # do {} while (0) macro tests:
4416 # single-statement macros do not need to be enclosed in do while (0) loop,
4417 # macro should not end with a semicolon
4432 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
4442 }
4448 }
4452 }
4460 }
4464 }
4465 }
4467 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
4468 # all assignments may have only one of the following with an assignment:
4469 # .
4470 # ALIGN(...)
4471 # VMLINUX_SYMBOL(...)
4475 }
4477 # check for redundant bracing round if etc
4481 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
4482 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
4492 # If the condition carries leading newlines, then count those as offsets.
4497 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
4499 # We have looked at and allowed this specific line.
4509 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
4511 #print "APW: ALLOWED: cond<$cond>\n";
4513 }
4515 #print "APW: ALLOWED: block<$block>\n";
4517 }
4519 #print "APW: ALLOWED: lines block<$block>\n";
4521 }
4523 }
4528 }
4536 }
4537 }
4538 }
4539 }
4544 # Check the pre-context.
4546 #print "APW: ALLOWED: pre<$1>\n";
4548 }
4553 # Check the condition.
4555 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
4558 }
4560 #print "APW: ALLOWED: cond<$cond>\n";
4562 }
4564 #print "APW: ALLOWED: block<$block>\n";
4566 }
4568 #print "APW: ALLOWED: lines block<$block>\n";
4570 }
4571 # Check the post-context.
4576 }
4578 #print "APW: ALLOWED: chunk-1 block<$block>\n";
4580 }
4581 }
4588 }
4592 }
4593 }
4595 # check for unnecessary blank lines around braces
4601 }
4602 }
4608 }
4609 }
4611 # no volatiles please
4615 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
4616 }
4618 # Check for user-visible strings broken across lines, which breaks the ability
4619 # to grep for the string. Make exceptions when the previous string ends in a
4620 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
4621 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
4634 }
4646 }
4648 }
4649 }
4651 # check for missing a space in a string concatenation
4655 }
4657 # check for spaces before a quoted newline
4663 }
4665 }
4667 # concatenated string without spaces between elements
4671 }
4673 # uncoalesced string fragments
4677 }
4679 # check for %L{u,d,i} in strings
4688 }
4689 }
4691 # check for line continuations in quoted strings with odd counts of "
4695 }
4697 # warn about #if 0
4702 }
4704 # check for needless "if (<foo>) fn(<foo>)" uses
4710 }
4711 }
4713 # check for unnecessary "Out of Memory" messages
4722 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
4724 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
4727 }
4728 }
4730 # check for logging functions with KERN_<LEVEL>
4738 }
4739 }
4741 # check for mask then right shift without a parentheses
4747 }
4749 # check for pointer comparisons to NULL
4759 }
4760 }
4761 }
4763 # check for bad placement of section $InitAttribute (e.g.: __initdata)
4766 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
4776 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
4777 }
4778 }
4779 }
4781 # check for $InitAttributeData (ie: __initdata) with const
4792 }
4793 }
4795 # check for $InitAttributeConst (ie: __initconst) without const
4807 }
4808 }
4810 # check for __read_mostly with const non-pointer (should just be const)
4817 }
4818 }
4820 # don't use __constant_<foo> functions outside of include/uapi/
4822 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
4830 }
4831 }
4833 # prefer usleep_range over udelay
4836 # ignore udelay's < 10, however
4839 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4840 }
4844 }
4845 }
4847 # warn about unexpectedly long msleep's
4851 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4852 }
4853 }
4855 # check for comparisons of jiffies
4858 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
4859 }
4861 # check for comparisons of get_jiffies_64()
4864 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
4865 }
4867 # warn about #ifdefs in C files
4868 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
4869 # print "#ifdef in C files should be avoided\n";
4870 # print "$herecurr";
4871 # $clean = 0;
4872 # }
4874 # warn about spacing in #ifdefs
4881 }
4883 }
4885 # check for spinlock_t definitions without a comment.
4892 }
4893 }
4894 # check for memory barriers without a comment.
4895 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
4899 }
4900 }
4901 # check of hardware specific defines
4902 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
4905 }
4907 # Check that the storage class is at the beginning of a declaration
4911 }
4913 # check the location of the inline attribute, that it is between
4914 # storage class and type.
4919 }
4921 # Check for __inline__ and __inline, prefer inline
4929 }
4930 }
4932 # Check for __attribute__ packed, prefer __packed
4937 }
4939 # Check for __attribute__ aligned, prefer __aligned
4944 }
4946 # Check for __attribute__ format(printf, prefer __printf
4950 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
4952 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
4954 }
4955 }
4957 # Check for __attribute__ format(scanf, prefer __scanf
4961 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
4963 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
4964 }
4965 }
4967 # Check for __attribute__ weak, or __weak declarations (may have link issues)
4969 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
4974 }
4976 # check for sizeof(&)
4980 }
4982 # check for sizeof without parenthesis
4987 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
4988 }
4989 }
4991 # check for struct spinlock declarations
4995 }
4997 # check for seq_printf uses that could be seq_puts
5006 }
5007 }
5008 }
5010 # Check for misused memsets
5025 }
5026 }
5028 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
5032 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . $herecurr) &&
5034 $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
5035 }
5036 }
5038 # typecasts on min/max could be min_t/max_t
5056 }
5059 }
5060 }
5062 # check usleep_range arguments
5070 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5074 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5075 }
5076 }
5078 # check for naked sscanf
5090 }
5093 }
5095 # check for simple sscanf that should be kstrto<foo>
5104 }
5112 }
5113 }
5114 }
5116 # check for new externs in .h files.
5123 }
5124 }
5126 # check for new externs in .c files.
5129 {
5136 }
5139 {
5142 }
5147 }
5151 {
5154 }
5156 # checks for new __setup's
5163 }
5164 }
5166 # check for pointless casting of kmalloc return
5169 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
5170 }
5172 # alloc style
5173 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
5175 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
5178 }
5180 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
5182 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
5193 }
5199 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
5201 }
5202 }
5203 }
5205 # check for krealloc arg reuse
5210 }
5212 # check for alloc argument mismatch
5216 }
5218 # check for multiple semicolons
5224 }
5225 }
5227 # check for #defines like: 1 << <digit> that could be BIT(digit)
5235 }
5236 }
5238 # check for case / default statements not preceded by break/fallthrough/switch
5256 }
5260 }
5261 }
5263 # check for switch/default statements without a break;
5272 }
5275 }
5277 # check for gcc specific __FUNCTION__
5283 }
5284 }
5286 # check for uses of __DATE__, __TIME__, __TIMESTAMP__
5290 }
5292 # check for use of yield()
5296 }
5298 # check for comparisons against true and false
5314 }
5319 ## maybe suggesting a correct construct would better
5320 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
5322 }
5323 }
5325 # check for semaphores initialized locked
5329 }
5331 # recommend kstrto* over simple_strto* and strict_strto*
5335 }
5337 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
5340 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
5341 }
5343 # check for various structs that are normally const (ops, kgdb, device_tree)
5345 acpi_dock_ops|
5346 address_space_operations|
5347 backlight_ops|
5348 block_device_operations|
5349 dentry_operations|
5350 dev_pm_ops|
5351 dma_map_ops|
5352 extent_io_ops|
5353 file_lock_operations|
5354 file_operations|
5355 hv_ops|
5356 ide_dma_ops|
5357 intel_dvo_dev_ops|
5358 item_operations|
5359 iwl_ops|
5360 kgdb_arch|
5361 kgdb_io|
5362 kset_uevent_ops|
5363 lock_manager_operations|
5364 microcode_ops|
5365 mtrr_ops|
5366 neigh_ops|
5367 nlmsvc_binding|
5368 of_device_id|
5369 pci_raw_ops|
5370 pipe_buf_operations|
5371 platform_hibernation_ops|
5372 platform_suspend_ops|
5373 proto_ops|
5374 rpc_pipe_ops|
5375 seq_operations|
5376 snd_ac97_build_ops|
5377 soc_pcmcia_socket_ops|
5378 stacktrace_ops|
5379 sysfs_ops|
5380 tty_operations|
5381 uart_ops|
5382 usb_mon_operations|
5389 }
5391 # use of NR_CPUS is usually wrong
5392 # ignore definitions of NR_CPUS and usage to define arrays as likely right
5399 {
5401 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
5402 }
5404 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
5408 }
5410 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
5415 }
5417 # whine mightly about in_atomic
5425 }
5426 }
5428 # check for lockdep_set_novalidate_class
5436 }
5437 }
5442 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5443 }
5445 # Mode permission misuses where it seems decimal should be octal
5446 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
5457 }
5470 "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5471 }
5472 }
5473 }
5474 }
5475 }
5477 # If we have no input at all, then there is nothing to report on
5478 # so just keep quiet.
5481 }
5483 # In mailback mode only produce a report in the negative, for
5484 # things that appear to be patches.
5487 }
5489 # This is not a patch, and we are are in 'no-patch' mode so
5490 # just keep quiet.
5493 }
5498 }
5502 }
5511 }
5518 }
5520 # If there were whitespace errors which cleanpatch can fix
5521 # then suggest that.
5526 }
5527 }
5550 }
5553 }
5554 }
5561 Do _NOT_ trust the results written to this file.
5564 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
5567 EOM
5568 }
5569 }
5573 }
5578 If any of these errors are false positives, please report
5580 EOM
5581 }
5584 }