| blob | d574d13ba96395ffa0c3a73b9ce669ba42e6a5a3 |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
63 Options:
68 --emacs emacs compile window format
69 --terse one line per report
84 is all off)
86 literally
89 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
90 with potential errors corrected to the preferred
91 checkpatch style
96 runtime errors.
99 --codespellfile Use this codespell dictionary
104 EOM
107 }
129 }
130 }
133 }
135 GetOptions(
178 }
179 }
184 }
200 }
201 }
210 }
212 }
213 }
223 ## no critic
226 }
233 }
239 }
246 }
247 }
252 }
253 }
263 __user|
264 __kernel|
265 __force|
266 __iomem|
267 __pmem|
268 __must_check|
269 __init_refok|
270 __kprobes|
271 __ref|
272 __rcu|
273 __private
281 # Notes to $Attribute:
282 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
284 const|
285 __percpu|
286 __nocast|
287 __safe|
288 __bitwise__|
289 __packed__|
290 __packed2__|
291 __naked|
292 __maybe_unused|
293 __always_unused|
294 __noreturn|
295 __used|
296 __cold|
297 __pure|
298 __noclone|
299 __deprecated|
300 __read_mostly|
301 __kprobes|
303 ____cacheline_aligned|
304 ____cacheline_aligned_in_smp|
305 ____cacheline_internodealigned_in_smp|
306 __weak
328 <=|>=|==|!=|
329 =>|->|<<|>>|<|>|!|~|
363 )};
366 atomic_t
367 )};
372 )};
378 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
380 panic|
383 )};
392 To:|
393 Cc:
394 )};
413 );
436 );
457 )};
464 );
468 );
475 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
478 );
480 #Create a search pattern for all these functions to speed up a loop below
485 }
488 S_IWUGO |
489 S_IWOTH |
490 S_IRWXUGO |
491 S_IALLUGO |
496 irq|
497 memory|
499 reboot
500 )};
501 # memory.h: ARM has a custom one
503 # Load common spelling mistakes and build regular expression list.
520 }
524 }
543 }
547 }
548 }
568 )
575 )
584 )
588 $NonptrType
593 $NonptrTypeMisordered
599 }
600 build_types();
604 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
605 # requires at least perl version v5.10.0
606 # Any use must be runtime checked with $^V
616 )};
625 }
630 }
654 }
655 }
656 }
680 }
682 }
690 }
694 }
699 }
703 }
711 }
713 }
714 }
728 # Maybe one day convert this block of bash into something that returns
729 # all matching commit ids, but it's very slow...
730 #
731 # echo "checking commits $1..."
732 # git rev-list --remotes | grep -i "^$1" |
733 # while read line ; do
734 # git log --format='%H %s' -1 $line |
735 # echo "commit $(cut -c 1-12,41-)"
736 # done
737 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
741 }
744 }
766 }
771 }
775 }
782 }
786 }
795 build_types();
796 }
807 EOM
808 }
814 EOM
815 }
816 }
827 );
832 }
833 }
835 }
858 # If there's a name left after stripping spaces and
859 # leading quotes, and the address doesn't have both
860 # leading and trailing angle brackets, the address
861 # is invalid. ie:
862 # "joe smith joe@smith.com" bad
863 # "joe smith <joe@smith.com" bad
868 }
869 }
879 }
882 }
896 }
902 }
905 }
913 }
914 }
917 }
925 }
926 }
929 }
942 }
944 }
947 }
950 }
954 }
959 # Drop the diff line leader and expand tabs
963 # Pick the indent from the front of the line.
967 }
978 }
979 }
990 # Always copy over the diff marker.
996 # Comments we are wacking completly including the begin
997 # and end, all to $;.
1004 }
1010 }
1017 }
1019 # A \ in a string means ignore the next character.
1025 }
1026 # Regular quotes.
1035 }
1036 }
1038 #print "c<$c> SQ<$sanitise_quote>\n";
1047 }
1048 }
1052 }
1054 # The pathname on a #include may be surrounded by '<' and '>'.
1059 # The whole of a #error is a string.
1063 }
1066 }
1073 }
1096 #warn "CSB: blk<$blk> remain<$remain>\n";
1097 # If we are about to drop off the end, pull in more
1098 # context.
1109 }
1110 # Bail if there is no further context.
1111 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
1114 }
1118 }
1119 }
1124 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1126 # Handle nested #if/#else.
1133 }
1135 # Statement ends at the ';' or a close '}' at the
1136 # outermost level.
1139 }
1141 # An else is really a conditional as long as its not else if
1148 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1149 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1150 }
1155 }
1163 #warn "CSB: mark coff<$coff>\n";
1164 }
1165 }
1169 }
1177 }
1179 }
1180 }
1181 # Preprocessor commands end at the newline unless escaped.
1187 }
1189 }
1190 # We are truly at the end, so shuffle to the next line.
1195 }
1200 #warn "STATEMENT<$statement>\n";
1201 #warn "CONDITION<$condition>\n";
1203 #print "coff<$coff> soff<$off> loff<$loff>\n";
1207 }
1212 # Strip the diff line prefixes and rip blank lines at start and end.
1220 }
1228 }
1249 }
1250 }
1258 # Grab the first conditional/block pair.
1261 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1265 }
1267 # Pull in the following conditional/block pairs and see if they
1268 # could continue the statement.
1272 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1274 #print "C: push\n";
1276 }
1279 }
1298 # Handle nested #if/#else.
1305 }
1308 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1312 }
1319 }
1320 }
1324 }
1327 }
1330 }
1336 }
1342 }
1348 }
1353 }
1358 }
1363 # Catch a comment on the end of the line itself.
1367 # Look through the context and try and figure out if there is a
1368 # comment.
1373 #warn " $line\n";
1376 }
1379 }
1382 }
1386 }
1387 }
1391 }
1396 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1397 ##print "CMMT: $cmt\n";
1400 }
1413 }
1416 }
1428 }
1429 }
1433 }
1445 }
1465 }
1486 }
1515 # Assume all arms of the conditional end as this
1516 # one does, and continue as if the #endif was not here.
1533 }
1564 }
1576 }
1609 }
1624 }
1633 }
1637 }
1641 }
1642 }
1645 }
1654 DEFINE_\S+
1655 )$|
1659 case|
1663 \#|
1664 \#\#|
1670 # Check for modifiers.
1681 }
1682 }
1687 }
1688 build_types();
1691 }
1692 }
1702 }
1710 }
1719 }
1720 }
1725 }
1733 }
1739 }
1743 }
1754 }
1755 }
1782 }
1788 }
1795 }
1800 }
1803 }
1806 }
1814 };
1816 }
1824 };
1827 }
1836 }
1838 }
1846 }
1848 }
1856 }
1858 }
1864 ##print "absolute<$absolute>\n";
1866 # See if any suffix of this path is a path within the tree.
1869 ##print "file<$file>\n";
1871 }
1872 }
1875 }
1877 # It is, so see if the prefix is acceptable.
1881 ##print "prefix<$prefix>\n";
1885 }
1886 }
1894 }
1902 }
1910 }
1918 }
1927 #convert leading spaces to tabs
1929 #Remove spaces before a tab
1933 }
1947 }
1959 }
1960 }
1963 }
1999 # Trace the real file/line as we go.
2011 # suppression flags
2019 # Pre-scan the patch sanitizing the lines.
2020 # Pre-scan the patch looking for any __setup documentation.
2021 #
2027 sanitise_line_reset();
2039 }
2040 #next;
2041 }
2048 }
2051 # Guestimate if this is a continuing comment. Run
2052 # the context looking for a comment "edge". If this
2053 # edge is a close comment then we must be in a comment
2054 # at context start.
2061 #print "RAW<$rawlines[$ln - 1]>\n";
2067 }
2068 }
2071 }
2073 # Guestimate if this is a continuing comment. If this
2074 # is the start of a diff block and this line starts
2075 # ' *' then it is very likely a comment.
2078 {
2080 }
2082 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
2086 # Standardise the strings and chars within the input to
2087 # simplify matching -- only bother with positive lines.
2089 }
2096 }
2098 #print "==>$rawline\n";
2099 #print "-->$line\n";
2103 }
2104 }
2119 #extract the line range in the file after the patch is applied
2129 }
2130 annotate_reset();
2139 # track the line number as we move through the hunk, note that
2140 # new versions of GNU diff omit the leading space on completely
2141 # blank context lines so we need to count that too.
2146 # Measure the line length and indent.
2149 # Track the previous line.
2154 #warn "line<$line>\n";
2158 }
2166 # extract the filename as it passes
2182 }
2186 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2187 }
2189 }
2191 #make up the handle for any error we report on this line
2199 }
2200 }
2207 }
2209 }
2219 # Check if the commit log has what seems like a diff which can confuse patch
2228 }
2230 # Check for incorrect file permissions
2237 }
2238 }
2240 # Check the patch for a signoff:
2244 }
2246 # Check if MAINTAINERS is being updated. If so, there's probably no need to
2247 # emit the "does MAINTAINERS need updating?" message on file add/move/delete
2250 }
2252 # Check signature styles
2264 }
2271 }
2272 }
2279 }
2281 }
2288 }
2289 }
2300 # Don't force email to have quotes
2301 # Allow just an angle bracketed address
2307 }
2308 }
2310 # Check for duplicate signatures
2319 }
2320 }
2322 # Check email subject for common tools that don't need to be mentioned
2327 }
2329 # Check for old stable address
2333 }
2335 # Check for unwanted Gerrit info
2339 }
2341 # Check if the commit log is in a possible stack dump
2345 # timestamp
2347 # stack dump address
2349 }
2351 # Check for line lengths > 75 in commit log, warn once
2355 # file delta changes
2357 # filename then :
2359 # A Fixes: or Link: line
2364 }
2366 # Reset possible stack dump if a blank line is found
2370 }
2372 # Check for git id commit length and improperly formed commit descriptions
2395 }
2417 }
2424 "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herecurr);
2425 }
2426 }
2428 # Check for added, moved or deleted files
2437 }
2439 # Check for wrappage within a valid hunk of the file
2444 }
2446 # Check for absolute kernel paths.
2453 #
2456 }
2457 }
2458 }
2460 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2471 }
2473 # Check if it's the start of a commit log
2474 # (not a header line and we haven't seen the patch filename)
2480 }
2482 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2483 # declined it, i.e defined some charset where it is missing.
2488 }
2494 }
2496 # Check for various typo / spelling mistakes
2510 }
2511 }
2512 }
2514 # ignore non-hunk lines and lines being removed
2517 #trailing whitespace
2524 }
2531 }
2534 }
2536 # Check for FSF mailing addresses.
2544 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2545 }
2547 # check for Kconfig help text having a real description
2548 # Only applies when adding the entry originally, after that we do not have
2549 # sufficient context to determine whether it is indeed long enough.
2570 }
2579 }
2581 }
2585 }
2586 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2587 }
2589 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2593 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2594 }
2596 # discourage the use of boolean for type definition attributes of Kconfig options
2601 }
2611 };
2614 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2615 }
2617 # check for DT compatible documentation
2636 }
2643 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2644 }
2645 }
2646 }
2648 # check we are in a valid source file if not then ignore this hunk
2651 # line length limit (with some exclusions)
2652 #
2653 # There are a few types of lines that may extend beyond $max_line_length:
2654 # logging functions like pr_info that end in a string
2655 # lines with a single string
2656 # #defines that are a single string
2657 #
2658 # There are 3 different line length message types:
2659 # LONG_LINE_COMMENT a comment starts before but extends beyond $max_linelength
2660 # LONG_LINE_STRING a string starts before but extends beyond $max_line_length
2661 # LONG_LINE all other lines longer than $max_line_length
2662 #
2663 # if LONG_LINE is ignored, the other 2 types are also ignored
2664 #
2669 # Check the allowed long line types first
2671 # logging functions that end in a string that starts
2672 # before $max_line_length
2673 if ($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(?:KERN_\S+\s*|[^"]*))?($String\s*(?:|,|\)\s*;)\s*)$/ &&
2677 # lines with only strings (w/ possible termination)
2678 # #defines with only strings
2683 # Otherwise set the alternate message types
2685 # a comment starts before $max_line_length
2690 # a quoted string starts before $max_line_length
2694 }
2700 }
2701 }
2703 # check for adding lines without a newline.
2704 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2707 }
2709 # Blackfin: use hi/lo macros
2715 }
2720 }
2721 }
2723 # check we are in a valid source file C or perl if not then ignore this hunk
2726 # at the beginning of a line any tabs must come first and anything
2727 # more than 8 must use tabs.
2736 }
2737 }
2739 # check for space before tabs.
2749 }
2750 }
2752 # check for && or || at the start of a line
2756 }
2758 # check multi-line statement indentation matches previous line
2760 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2783 }
2784 }
2785 }
2786 }
2788 # check for space after cast like "(int) foo" or "(struct foo) bar"
2789 # avoid checking a few false positives:
2790 # "sizeof(<type>)" or "__alignof__(<type>)"
2791 # function pointer declarations like "(*foo)(int) = bar;"
2792 # structure definitions like "(struct foo) { 0 };"
2793 # multiline macros that define functions
2794 # known attributes or the __attribute__ keyword
2802 }
2803 }
2805 # Block comment styles
2806 # Networking with an initial /*
2813 }
2815 # Block comments use * on subsequent lines
2823 }
2825 # Block comments use */ on trailing lines
2832 }
2834 # check for missing blank lines after struct/union declarations
2835 # with exceptions for various attributes and macros
2850 }
2851 }
2853 # check for multiple consecutive blank lines
2861 }
2864 }
2866 # check for missing blank lines after declarations
2868 # actual declarations
2870 # function pointer declarations
2872 # foo bar; where foo is some local typedef or #define
2874 # known declaration macros
2876 # for "else if" which can look like "$Ident $Ident"
2878 # other possible extensions of declaration lines
2880 # not starting a section or a macro "\" extended line
2882 # looks like a declaration
2884 # function pointer declarations
2886 # foo bar; where foo is some local typedef or #define
2888 # known declaration macros
2890 # start of struct or union or enum
2892 # start or end of block or continuation of declaration
2894 # bitfield continuation
2896 # other possible extensions of declaration lines
2898 # indentation of previous and current line are the same
2904 }
2905 }
2907 # check for spaces at the beginning of a line.
2908 # Exceptions:
2909 # 1) within comments
2910 # 2) indented preprocessor commands
2911 # 3) hanging labels
2918 }
2919 }
2921 # check we are in a valid C source file if not then ignore this hunk
2924 # check indentation of any line with a bare else
2925 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
2926 # if the previous line is a break or return and is indented 1 tab more...
2935 }
2936 }
2938 # check indentation of a line with a break;
2939 # if the previous line is a goto or return and is indented the same # of tabs
2945 }
2946 }
2948 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2951 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2952 }
2954 # check for RCS/CVS revision markers
2958 }
2960 # Blackfin: don't use __builtin_bfin_[cs]sync
2965 }
2970 }
2972 # check for old HOTPLUG __dev<foo> section markings
2976 }
2978 # Check for potential 'bare' types
2981 #print "LINE<$line>\n";
2989 #print "linenr<$linenr> <$stat>\n";
2990 # If this statement has no statement boundaries within
2991 # it there is no point in retrying a statement scan
2992 # until we hit end of it.
2995 #print "skip<$line_nr_next>\n";
2997 }
2999 # Find the real next line.
3005 }
3010 # Ignore goto labels.
3013 # Ignore functions being called
3018 # declarations always start with types
3019 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
3024 # definitions in global scope can only start with types
3027 }
3029 # any (foo ... *) is a pointer cast, and foo is a type
3032 }
3034 # Check for any sort of function declaration.
3035 # int foo(something bar, other baz);
3036 # void (*store_gdt)(x86_descr_ptr *);
3037 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
3045 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
3048 }
3049 }
3050 }
3052 }
3054 #
3055 # Checks which may be anchored in the context.
3056 #
3058 # Check for switch () and associated case and default
3059 # statements should be at the same indent.
3073 }
3074 }
3078 }
3079 }
3081 # if/while/etc brace do not go on next line, unless defining a do while loop,
3082 # or if that brace on the next line is for something else
3083 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
3091 }
3102 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
3105 }
3107 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
3108 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
3114 }
3118 {
3124 }
3125 }
3126 }
3128 # Check relative indent for conditionals and blocks.
3129 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
3137 # remove inline comments
3141 # Find out how long the conditional actually is.
3145 # Make sure we remove the line prefixes as we have
3146 # none on the first line, and are going to readd them
3147 # where necessary.
3151 }
3153 # We want to check the first line inside the block
3154 # starting at the end of the conditional, so remove:
3155 # 1) any blank line termination
3156 # 2) any opening brace { on end of the line
3157 # 3) any do (...) {
3164 }
3168 }
3170 # Also ignore a loop construct at the end of a
3171 # preprocessor statement.
3175 }
3182 # If we see an #else/#elif then the code
3183 # is not linear.
3186 }
3188 # Ignore:
3189 # 1) blank lines, they should be at 0,
3190 # 2) preprocessor lines, and
3191 # 3) labels.
3199 }
3200 }
3201 }
3206 # Check if either of these lines are modified, else
3207 # this is not this patch's fault.
3211 }
3214 }
3216 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
3223 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
3224 }
3225 }
3227 # Track the 'values' across context and added lines.
3237 }
3240 #ignore lines not being added
3243 # check for declarations of signed or unsigned without int
3255 "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
3263 }
3264 }
3265 }
3267 # TEST: allow direct testing of the type matcher.
3275 }
3277 }
3278 # TEST: allow direct testing of the attribute matcher.
3286 }
3288 }
3290 # check for initialisation to aggregates open brace on the next line
3304 }
3305 }
3307 #
3308 # Checks which are anchored on the added line.
3309 #
3311 # check for malformed paths in #include statements (uses RAW line)
3317 }
3321 }
3322 }
3324 # no C99 // comments
3333 }
3334 }
3335 }
3336 # Remove C99 comments.
3340 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
3341 # the whole statement.
3342 #print "APW <$lines[$realline_next - 1]>\n";
3348 # Handle definitions which produce identifiers with
3349 # a prefix:
3350 # XXX(foo);
3351 # EXPORT_SYMBOL(something_foo);
3355 #print "FOO C name<$name>\n";
3366 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
3370 }
3371 }
3376 #print "FOO B <$lines[$linenr - 1]>\n";
3378 }
3383 }
3385 # check for global initialisers.
3391 }
3392 }
3393 # check for static initialisers.
3400 }
3401 }
3403 # check for misordered declarations of char/short/int/long with signed/unsigned
3407 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
3408 }
3410 # check for static const char * arrays.
3415 }
3417 # check for static char foo[] = "bar" declarations.
3422 }
3424 # check for const <foo> const where <foo> is not a pointer or array type
3433 }
3434 }
3436 # check for non-global char *foo[] = {"bar", ...} declarations.
3441 }
3443 # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
3446 if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {
3452 }
3453 }
3454 }
3456 # check for function declarations without arguments like "int foo()"
3462 }
3463 }
3465 # check for uses of DEFINE_PCI_DEVICE_TABLE
3470 $fixed[$fixlinenr] =~ s/\b(?:static\s+|)DEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=\s*/static const struct pci_device_id $1\[\] = /;
3471 }
3472 }
3474 # check for new typedefs, only function parameters and sparse annotations
3475 # make sense.
3483 }
3485 # * goes on variable not on type
3486 # (char*[ const])
3488 #print "AA<$1>\n";
3491 # Should start with a space.
3493 # Should not end with a space.
3495 # '*'s should not have spaces between.
3497 }
3499 ## print "1: from<$from> to<$to> ident<$ident>\n";
3509 }
3510 }
3511 }
3513 #print "BB<$1>\n";
3516 # Should start with a space.
3518 # Should not end with a space.
3520 # '*'s should not have spaces between.
3522 }
3523 # Modifiers should have spaces.
3526 ## print "2: from<$from> to<$to> ident<$ident>\n";
3537 }
3538 }
3539 }
3541 # avoid BUG() or BUG_ON()
3546 "Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . $herecurr);
3547 }
3549 # avoid LINUX_VERSION_CODE
3552 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
3553 }
3555 # check for uses of printk_ratelimit
3559 }
3561 # printk should use KERN_* levels. Note that follow on printk's on the
3562 # same line do not need a level, so we use the current block context
3563 # to try and find and validate the current printk. In summary the current
3564 # printk includes all preceding printk's which have no newline on the end.
3565 # we assume the first bad printk is the one to report.
3569 #print "CHECK<$lines[$ln - 1]\n";
3570 # we have a preceding printk if it ends
3571 # with "\n" ignore it, else it is to blame
3575 }
3577 }
3578 }
3582 }
3583 }
3592 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
3593 }
3601 }
3602 }
3611 }
3613 # ENOSYS means "bad syscall nr" and nothing else. This will have a small
3614 # number of false positives, but assembly files are not checked, so at
3615 # least the arch entry code will not trigger this warning.
3619 }
3621 # function brace can't be on same line, except for #defines of do while,
3622 # or if closed on same line
3637 }
3638 }
3639 }
3641 # open braces for enum, union and struct go on the same line.
3655 }
3656 }
3657 }
3659 # missing space after union, struct or enum definition
3666 }
3667 }
3669 # Function pointer declarations
3670 # check spacing between type, funcptr, and args
3671 # canonical declaration is "type (*funcptr)(args...)"
3680 # the $Declare variable will capture all spaces after the type
3681 # so check it for a missing trailing missing space but pointer return types
3682 # don't need a space so don't warn for those.
3687 }
3692 }
3694 # unnecessary space "type (*funcptr)(args...)"
3695 # This test is not currently implemented because these declarations are
3696 # equivalent to
3697 # int foo(int bar, ...)
3698 # and this is form shouldn't/doesn't generate a checkpatch warning.
3699 #
3700 # elsif ($declare =~ /\s{2,}$/) {
3701 # WARN("SPACING",
3702 # "Multiple spaces after return type\n" . $herecurr);
3703 # }
3705 # unnecessary space "type ( *funcptr)(args...)"
3710 }
3712 # unnecessary space "type (* funcptr)(args...)"
3717 }
3719 # unnecessary space "type (*funcptr )(args...)"
3724 }
3726 # unnecessary space "type (*funcptr) (args...)"
3731 }
3735 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3736 }
3737 }
3739 # check for spacing round square brackets; allowed:
3740 # 1. with a type on the left -- int [] a;
3741 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3742 # 3. inside a curly brace -- = { [0...10] = 5 }
3753 }
3754 }
3755 }
3757 # check for spaces between functions and their parentheses.
3763 # Ignore those directives where spaces _are_ permitted.
3769 {
3770 # cpp #define statements have non-optional spaces, ie
3771 # if there is a space between the name and the open
3772 # parenthesis it is simply not a parameter group.
3775 # cpp #elif statement condition may start with a (
3778 # If this whole things ends with a type its most
3779 # likely a typedef for a function.
3788 }
3789 }
3790 }
3792 # Check operator spacing.
3798 <<=|>>=|<=|>=|==|!=|
3800 =>|->|<<|>>|<|>|=|!|~|
3806 ## print("element count: <" . $#elements . ">\n");
3807 ## foreach my $el (@elements) {
3808 ## print("el: <$el>\n");
3809 ## }
3817 }
3828 ## print("n: <$n> good: <$good>\n");
3832 # Pick up the preceding and succeeding characters.
3837 }
3860 }
3869 # Pull out the value of this operator.
3872 # Get the full operator variant.
3875 # Ignore operators passed as parameters.
3879 # # Ignore comments
3880 # } elsif ($op =~ /^$;+$/) {
3882 # ; should have either the end of line or a space or \ after it
3890 }
3891 }
3893 # // is a comment
3896 # : when part of a bitfield
3898 # skip the bitfield test for now
3900 # No spaces for:
3901 # ->
3909 }
3911 }
3912 }
3914 # , must not have a space before and must have a space on the right.
3923 }
3924 }
3931 }
3932 }
3938 }
3941 }
3942 }
3944 # '*' as part of a type definition -- reported already.
3946 #warn "'*' is part of type\n";
3948 # unary operators should have a space before and
3949 # none after. May be left adjacent to another
3950 # unary operator, or a cast
3960 }
3961 }
3962 }
3964 # A unary '*' may be const
3972 }
3974 }
3975 }
3977 # unary ++ and unary -- are allowed no space on one side.
3984 }
3985 }
3992 }
3993 }
4000 }
4002 }
4003 }
4005 # << and >> may either have or not have spaces both sides
4011 {
4019 }
4025 }
4026 }
4033 }
4035 }
4036 }
4038 # A colon needs no spaces before when it is
4039 # terminating a case value or a label.
4046 }
4047 }
4049 # All the others need spaces both sides.
4053 # Ignore email addresses <foo@bar>
4058 {
4060 }
4062 # for asm volatile statements
4063 # ignore a colon with another
4064 # colon immediately before or after
4068 }
4070 # messages are ERROR, but ?: are CHK
4080 }
4082 }
4083 }
4084 }
4087 ## print("n: <$n> GOOD: <$good>\n");
4090 }
4094 }
4098 }
4101 }
4103 # check for whitespace before a non-naked semicolon
4110 }
4111 }
4113 # check for multiple assignments
4117 }
4119 ## # check for multiple declarations, allowing for a function declaration
4120 ## # continuation.
4121 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
4122 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
4123 ##
4124 ## # Remove any bracketed sections to ensure we do not
4125 ## # falsly report the parameters of functions.
4126 ## my $ln = $line;
4127 ## while ($ln =~ s/\([^\(\)]*\)//g) {
4128 ## }
4129 ## if ($ln =~ /,/) {
4130 ## WARN("MULTIPLE_DECLARATION",
4131 ## "declaring multiple variables together should be avoided\n" . $herecurr);
4132 ## }
4133 ## }
4135 #need space before brace following if, while, etc
4142 }
4143 }
4145 ## # check for blank lines before declarations
4146 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
4147 ## $prevrawline =~ /^.\s*$/) {
4148 ## WARN("SPACING",
4149 ## "No blank lines before declarations\n" . $hereprev);
4150 ## }
4151 ##
4153 # closing brace should have a space following it when it has anything
4154 # on the line
4161 }
4162 }
4164 # check spacing on square brackets
4171 }
4172 }
4179 }
4180 }
4182 # check spacing on parentheses
4190 }
4191 }
4200 }
4201 }
4203 # check unnecessary parentheses around addressof/dereference single $Lvals
4204 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
4212 }
4213 }
4215 # check for unnecessary parentheses around function pointer uses
4216 # ie: (foo->bar)(); should be foo->bar();
4217 # but not "if (foo->bar) (" to avoid some false positives
4226 }
4227 }
4229 #goto labels aren't indented, allow a single space however
4237 }
4238 }
4240 # return is not a function
4250 }
4254 }
4255 }
4257 # unnecessary return in a void function
4258 # at end-of-function, with the previous line a single leading tab, then return;
4259 # and the line before that not a goto label target like "out:"
4267 }
4269 # if statements using unnecessary parentheses - ie: if ((foo == bar))
4275 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
4280 }
4281 }
4283 # comparisons with a constant or upper case identifier on the left
4284 # avoid cases like "foo + BAR < baz"
4285 # only fix matches surrounded by parentheses to avoid incorrect
4286 # conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
4307 }
4309 }
4310 }
4312 # Return of what appears to be an errno should normally be negative
4318 }
4319 }
4321 # Need a space before open parenthesis after if, while etc
4328 }
4329 }
4331 # Check for illegal assignment in if conditional -- and check for trailing
4332 # statements after the conditional.
4340 ##print "stat<$stat> stat_next<$stat_next>\n";
4343 # If the statement carries leading newlines,
4344 # then count those as offsets.
4352 }
4353 }
4362 }
4364 # Find out what is on the end of the line after the
4365 # conditional.
4371 {
4372 # Find out how long the conditional actually is.
4381 }
4385 }
4386 }
4388 # Check for bitwise tests written as boolean
4394 |
4399 {
4402 }
4404 # if and else should not have general statements after it
4411 }
4412 }
4413 # if should not continue a brace
4418 }
4419 # case and default should not have general statements after them
4425 {
4428 }
4430 # Check for }<nl>else {, these must be at the same
4431 # indent level to be relevant to each other.
4443 }
4447 }
4448 }
4454 # Find out what is on the end of the line after the
4455 # conditional.
4471 }
4472 }
4473 }
4475 #Specific variable tests
4479 #gcc binary extension
4487 }
4488 }
4490 #CamelCase
4493 #Ignore Page<foo> variants
4495 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
4497 #Ignore some three character SI units explicitly, like MiB and KHz
4503 seed_camelcase_includes();
4507 }
4508 }
4513 }
4514 }
4515 }
4516 }
4518 #no spaces allowed after \ in define
4524 }
4525 }
4527 # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
4528 # itself <asm/foo.h> (uses RAW line)
4535 {
4544 }
4545 }
4546 }
4547 }
4549 # multi-statement macros should be enclosed in a do while loop, grab the
4550 # first statement and ensure its the whole macro if its not enclosed
4551 # in a known good container
4563 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
4564 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
4575 # Flatten any parentheses and braces
4579 {
4580 }
4582 # Flatten any obvious string concatentation.
4585 {
4586 }
4588 # Make asm volatile uses seem like a generic function
4593 module_param_named|
4594 MODULE_PARM_DESC|
4595 DECLARE_PER_CPU|
4596 DEFINE_PER_CPU|
4597 __typeof__\(|
4598 union|
4599 struct|
4604 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
4608 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
4613 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
4619 {
4626 }
4634 }
4635 }
4637 # check for macros with flow control, but without ## concatenation
4638 # ## concatenation is commonly a macro that defines a function so ignore those
4645 }
4648 }
4650 # check for line continuations outside of #defines, preprocessor #, and asm
4659 }
4660 }
4662 # do {} while (0) macro tests:
4663 # single-statement macros do not need to be enclosed in do while (0) loop,
4664 # macro should not end with a semicolon
4679 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
4689 }
4695 }
4699 }
4707 }
4711 }
4712 }
4714 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
4715 # all assignments may have only one of the following with an assignment:
4716 # .
4717 # ALIGN(...)
4718 # VMLINUX_SYMBOL(...)
4722 }
4724 # check for redundant bracing round if etc
4728 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
4729 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
4739 # If the condition carries leading newlines, then count those as offsets.
4744 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
4746 # We have looked at and allowed this specific line.
4756 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
4758 #print "APW: ALLOWED: cond<$cond>\n";
4760 }
4762 #print "APW: ALLOWED: block<$block>\n";
4764 }
4766 #print "APW: ALLOWED: lines block<$block>\n";
4768 }
4770 }
4775 }
4783 }
4784 }
4785 }
4786 }
4791 # Check the pre-context.
4793 #print "APW: ALLOWED: pre<$1>\n";
4795 }
4800 # Check the condition.
4802 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
4805 }
4807 #print "APW: ALLOWED: cond<$cond>\n";
4809 }
4811 #print "APW: ALLOWED: block<$block>\n";
4813 }
4815 #print "APW: ALLOWED: lines block<$block>\n";
4817 }
4818 # Check the post-context.
4823 }
4825 #print "APW: ALLOWED: chunk-1 block<$block>\n";
4827 }
4828 }
4835 }
4839 }
4840 }
4842 # check for unnecessary blank lines around braces
4848 }
4849 }
4855 }
4856 }
4858 # no volatiles please
4862 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
4863 }
4865 # Check for user-visible strings broken across lines, which breaks the ability
4866 # to grep for the string. Make exceptions when the previous string ends in a
4867 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
4868 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
4881 }
4893 }
4895 }
4896 }
4898 # check for missing a space in a string concatenation
4902 }
4904 # check for spaces before a quoted newline
4910 }
4912 }
4914 # concatenated string without spaces between elements
4918 }
4920 # uncoalesced string fragments
4924 }
4926 # check for %L{u,d,i} and 0x%[udi] in strings
4935 }
4939 }
4940 }
4942 # check for line continuations in quoted strings with odd counts of "
4946 }
4948 # warn about #if 0
4953 }
4955 # check for needless "if (<foo>) fn(<foo>)" uses
4959 if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?|(?:kmem_cache|mempool|dma_pool)_destroy)$expr/) {
4971 }
4976 }
4979 }
4983 }
4984 }
4985 }
4986 }
4988 # check for unnecessary "Out of Memory" messages
4997 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
4999 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
5002 }
5003 }
5005 # check for logging functions with KERN_<LEVEL>
5013 }
5014 }
5016 # check for mask then right shift without a parentheses
5022 }
5024 # check for pointer comparisons to NULL
5034 }
5035 }
5036 }
5038 # check for bad placement of section $InitAttribute (e.g.: __initdata)
5041 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
5051 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
5052 }
5053 }
5054 }
5056 # check for $InitAttributeData (ie: __initdata) with const
5067 }
5068 }
5070 # check for $InitAttributeConst (ie: __initconst) without const
5082 }
5083 }
5085 # check for __read_mostly with const non-pointer (should just be const)
5092 }
5093 }
5095 # don't use __constant_<foo> functions outside of include/uapi/
5097 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
5105 }
5106 }
5108 # prefer usleep_range over udelay
5111 # ignore udelay's < 10, however
5114 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
5115 }
5119 }
5120 }
5122 # warn about unexpectedly long msleep's
5126 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
5127 }
5128 }
5130 # check for comparisons of jiffies
5133 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
5134 }
5136 # check for comparisons of get_jiffies_64()
5139 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
5140 }
5142 # warn about #ifdefs in C files
5143 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
5144 # print "#ifdef in C files should be avoided\n";
5145 # print "$herecurr";
5146 # $clean = 0;
5147 # }
5149 # warn about spacing in #ifdefs
5156 }
5158 }
5160 # check for spinlock_t definitions without a comment.
5167 }
5168 }
5169 # check for memory barriers without a comment.
5172 mb|
5173 rmb|
5174 wmb|
5175 read_barrier_depends
5178 mb__before_atomic|
5179 mb__after_atomic|
5180 store_release|
5181 load_acquire|
5182 store_mb|
5195 }
5196 }
5206 }
5208 # check for waitqueue_active without a comment.
5213 }
5214 }
5216 # Check for expedited grace periods that interrupt non-idle non-nohz
5217 # online CPUs. These expedited can therefore degrade real-time response
5218 # if used carelessly, and should be avoided where not absolutely
5219 # needed. It is always OK to use synchronize_rcu_expedited() and
5220 # synchronize_sched_expedited() at boot time (before real-time applications
5221 # start) and in error situations where real-time response is compromised in
5222 # any case. Note that synchronize_srcu_expedited() does -not- interrupt
5223 # other CPUs, so don't warn on uses of synchronize_srcu_expedited().
5224 # Of course, nothing comes for free, and srcu_read_lock() and
5225 # srcu_read_unlock() do contain full memory barriers in payment for
5226 # synchronize_srcu_expedited() non-interruption properties.
5229 "expedited RCU grace periods should be avoided where they can degrade real-time response\n" . $herecurr);
5231 }
5233 # check of hardware specific defines
5234 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
5237 }
5239 # Check that the storage class is at the beginning of a declaration
5243 }
5245 # check the location of the inline attribute, that it is between
5246 # storage class and type.
5251 }
5253 # Check for __inline__ and __inline, prefer inline
5261 }
5262 }
5264 # Check for __attribute__ packed, prefer __packed
5269 }
5271 # Check for __attribute__ aligned, prefer __aligned
5276 }
5278 # Check for __attribute__ format(printf, prefer __printf
5282 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
5284 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
5286 }
5287 }
5289 # Check for __attribute__ format(scanf, prefer __scanf
5293 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
5295 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
5296 }
5297 }
5299 # Check for __attribute__ weak, or __weak declarations (may have link issues)
5301 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
5306 }
5308 # check for c99 types like uint8_t used outside of uapi/
5322 }
5323 }
5324 }
5326 # check for cast of C90 native int or longer types constants
5341 }
5343 }
5344 }
5346 # check for sizeof(&)
5350 }
5352 # check for sizeof without parenthesis
5357 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
5358 }
5359 }
5361 # check for struct spinlock declarations
5365 }
5367 # check for seq_printf uses that could be seq_puts
5376 }
5377 }
5378 }
5380 # Check for misused memsets
5395 }
5396 }
5398 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
5403 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") &&
5405 $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
5406 }
5407 }
5409 # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)
5414 "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n")
5415 }
5417 # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
5418 # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
5429 $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;
5430 }
5435 $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;
5436 }
5437 }
5438 }
5440 # typecasts on min/max could be min_t/max_t
5458 }
5461 }
5462 }
5464 # check usleep_range arguments
5472 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5476 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5477 }
5478 }
5480 # check for naked sscanf
5492 }
5495 }
5497 # check for simple sscanf that should be kstrto<foo>
5506 }
5514 }
5515 }
5516 }
5518 # check for new externs in .h files.
5525 }
5526 }
5528 # check for new externs in .c files.
5531 {
5538 }
5541 {
5544 }
5549 }
5553 {
5556 }
5558 # checks for new __setup's
5565 }
5566 }
5568 # check for pointless casting of kmalloc return
5571 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
5572 }
5574 # alloc style
5575 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
5577 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
5580 }
5582 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
5584 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
5595 }
5601 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
5603 }
5604 }
5605 }
5607 # check for krealloc arg reuse
5612 }
5614 # check for alloc argument mismatch
5618 }
5620 # check for multiple semicolons
5626 }
5627 }
5629 # check for #defines like: 1 << <digit> that could be BIT(digit)
5637 }
5638 }
5640 # check for case / default statements not preceded by break/fallthrough/switch
5658 }
5662 }
5663 }
5665 # check for switch/default statements without a break;
5674 }
5677 }
5679 # check for gcc specific __FUNCTION__
5685 }
5686 }
5688 # check for uses of __DATE__, __TIME__, __TIMESTAMP__
5692 }
5694 # check for use of yield()
5698 }
5700 # check for comparisons against true and false
5716 }
5721 ## maybe suggesting a correct construct would better
5722 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
5724 }
5725 }
5727 # check for semaphores initialized locked
5731 }
5733 # recommend kstrto* over simple_strto* and strict_strto*
5737 }
5739 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
5742 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
5743 }
5745 # check for various structs that are normally const (ops, kgdb, device_tree)
5747 acpi_dock_ops|
5748 address_space_operations|
5749 backlight_ops|
5750 block_device_operations|
5751 dentry_operations|
5752 dev_pm_ops|
5753 dma_map_ops|
5754 extent_io_ops|
5755 file_lock_operations|
5756 file_operations|
5757 hv_ops|
5758 ide_dma_ops|
5759 intel_dvo_dev_ops|
5760 item_operations|
5761 iwl_ops|
5762 kgdb_arch|
5763 kgdb_io|
5764 kset_uevent_ops|
5765 lock_manager_operations|
5766 microcode_ops|
5767 mtrr_ops|
5768 neigh_ops|
5769 nlmsvc_binding|
5770 of_device_id|
5771 pci_raw_ops|
5772 pipe_buf_operations|
5773 platform_hibernation_ops|
5774 platform_suspend_ops|
5775 proto_ops|
5776 rpc_pipe_ops|
5777 seq_operations|
5778 snd_ac97_build_ops|
5779 soc_pcmcia_socket_ops|
5780 stacktrace_ops|
5781 sysfs_ops|
5782 tty_operations|
5783 uart_ops|
5784 usb_mon_operations|
5791 }
5793 # use of NR_CPUS is usually wrong
5794 # ignore definitions of NR_CPUS and usage to define arrays as likely right
5801 {
5803 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
5804 }
5806 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
5810 }
5812 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
5817 }
5819 # whine mightly about in_atomic
5827 }
5828 }
5830 # check for lockdep_set_novalidate_class
5838 }
5839 }
5844 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5845 }
5847 # Mode permission misuses where it seems decimal should be octal
5848 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
5859 }
5872 "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5873 }
5874 }
5875 }
5876 }
5878 # validate content of MODULE_LICENSE against list from include/linux/module.h
5882 GPL|
5883 GPL\ v2|
5888 Proprietary
5893 }
5894 }
5895 }
5897 # If we have no input at all, then there is nothing to report on
5898 # so just keep quiet.
5901 }
5903 # In mailback mode only produce a report in the negative, for
5904 # things that appear to be patches.
5907 }
5909 # This is not a patch, and we are are in 'no-patch' mode so
5910 # just keep quiet.
5913 }
5918 }
5922 }
5930 }
5933 # If there were whitespace errors which cleanpatch can fix
5934 # then suggest that.
5941 EOM
5942 }
5943 }
5963 }
5966 }
5967 }
5975 Do _NOT_ trust the results written to this file.
5978 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
5980 EOM
5981 }
5982 }
5990 }
5991 }
5993 }