mfd: wm8350-i2c: Make sure the i2c regmap functions are compiled
[linux/fpc-iii.git] / drivers / video / omap2 / displays-new / panel-sony-acx565akm.c
blobd94f35dbd5369e83a50265c78b421aac2ab300c7
1 /*
2 * Sony ACX565AKM LCD Panel driver
4 * Copyright (C) 2010 Nokia Corporation
6 * Original Driver Author: Imre Deak <imre.deak@nokia.com>
7 * Based on panel-generic.c by Tomi Valkeinen <tomi.valkeinen@nokia.com>
8 * Adapted to new DSS2 framework: Roger Quadros <roger.quadros@nokia.com>
10 * This program is free software; you can redistribute it and/or modify it
11 * under the terms of the GNU General Public License version 2 as published by
12 * the Free Software Foundation.
14 * This program is distributed in the hope that it will be useful, but WITHOUT
15 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
16 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
17 * more details.
19 * You should have received a copy of the GNU General Public License along with
20 * this program. If not, see <http://www.gnu.org/licenses/>.
23 #include <linux/kernel.h>
24 #include <linux/module.h>
25 #include <linux/platform_device.h>
26 #include <linux/delay.h>
27 #include <linux/spi/spi.h>
28 #include <linux/jiffies.h>
29 #include <linux/sched.h>
30 #include <linux/backlight.h>
31 #include <linux/fb.h>
32 #include <linux/gpio.h>
34 #include <video/omapdss.h>
35 #include <video/omap-panel-data.h>
37 #define MIPID_CMD_READ_DISP_ID 0x04
38 #define MIPID_CMD_READ_RED 0x06
39 #define MIPID_CMD_READ_GREEN 0x07
40 #define MIPID_CMD_READ_BLUE 0x08
41 #define MIPID_CMD_READ_DISP_STATUS 0x09
42 #define MIPID_CMD_RDDSDR 0x0F
43 #define MIPID_CMD_SLEEP_IN 0x10
44 #define MIPID_CMD_SLEEP_OUT 0x11
45 #define MIPID_CMD_DISP_OFF 0x28
46 #define MIPID_CMD_DISP_ON 0x29
47 #define MIPID_CMD_WRITE_DISP_BRIGHTNESS 0x51
48 #define MIPID_CMD_READ_DISP_BRIGHTNESS 0x52
49 #define MIPID_CMD_WRITE_CTRL_DISP 0x53
51 #define CTRL_DISP_BRIGHTNESS_CTRL_ON (1 << 5)
52 #define CTRL_DISP_AMBIENT_LIGHT_CTRL_ON (1 << 4)
53 #define CTRL_DISP_BACKLIGHT_ON (1 << 2)
54 #define CTRL_DISP_AUTO_BRIGHTNESS_ON (1 << 1)
56 #define MIPID_CMD_READ_CTRL_DISP 0x54
57 #define MIPID_CMD_WRITE_CABC 0x55
58 #define MIPID_CMD_READ_CABC 0x56
60 #define MIPID_VER_LPH8923 3
61 #define MIPID_VER_LS041Y3 4
62 #define MIPID_VER_L4F00311 8
63 #define MIPID_VER_ACX565AKM 9
65 struct panel_drv_data {
66 struct omap_dss_device dssdev;
67 struct omap_dss_device *in;
69 int reset_gpio;
70 int datapairs;
72 struct omap_video_timings videomode;
74 char *name;
75 int enabled;
76 int model;
77 int revision;
78 u8 display_id[3];
79 unsigned has_bc:1;
80 unsigned has_cabc:1;
81 unsigned cabc_mode;
82 unsigned long hw_guard_end; /* next value of jiffies
83 when we can issue the
84 next sleep in/out command */
85 unsigned long hw_guard_wait; /* max guard time in jiffies */
87 struct spi_device *spi;
88 struct mutex mutex;
90 struct backlight_device *bl_dev;
93 static const struct omap_video_timings acx565akm_panel_timings = {
94 .x_res = 800,
95 .y_res = 480,
96 .pixel_clock = 24000,
97 .hfp = 28,
98 .hsw = 4,
99 .hbp = 24,
100 .vfp = 3,
101 .vsw = 3,
102 .vbp = 4,
104 .vsync_level = OMAPDSS_SIG_ACTIVE_LOW,
105 .hsync_level = OMAPDSS_SIG_ACTIVE_LOW,
107 .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
108 .de_level = OMAPDSS_SIG_ACTIVE_HIGH,
109 .sync_pclk_edge = OMAPDSS_DRIVE_SIG_OPPOSITE_EDGES,
112 #define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
114 static void acx565akm_transfer(struct panel_drv_data *ddata, int cmd,
115 const u8 *wbuf, int wlen, u8 *rbuf, int rlen)
117 struct spi_message m;
118 struct spi_transfer *x, xfer[5];
119 int r;
121 BUG_ON(ddata->spi == NULL);
123 spi_message_init(&m);
125 memset(xfer, 0, sizeof(xfer));
126 x = &xfer[0];
128 cmd &= 0xff;
129 x->tx_buf = &cmd;
130 x->bits_per_word = 9;
131 x->len = 2;
133 if (rlen > 1 && wlen == 0) {
135 * Between the command and the response data there is a
136 * dummy clock cycle. Add an extra bit after the command
137 * word to account for this.
139 x->bits_per_word = 10;
140 cmd <<= 1;
142 spi_message_add_tail(x, &m);
144 if (wlen) {
145 x++;
146 x->tx_buf = wbuf;
147 x->len = wlen;
148 x->bits_per_word = 9;
149 spi_message_add_tail(x, &m);
152 if (rlen) {
153 x++;
154 x->rx_buf = rbuf;
155 x->len = rlen;
156 spi_message_add_tail(x, &m);
159 r = spi_sync(ddata->spi, &m);
160 if (r < 0)
161 dev_dbg(&ddata->spi->dev, "spi_sync %d\n", r);
164 static inline void acx565akm_cmd(struct panel_drv_data *ddata, int cmd)
166 acx565akm_transfer(ddata, cmd, NULL, 0, NULL, 0);
169 static inline void acx565akm_write(struct panel_drv_data *ddata,
170 int reg, const u8 *buf, int len)
172 acx565akm_transfer(ddata, reg, buf, len, NULL, 0);
175 static inline void acx565akm_read(struct panel_drv_data *ddata,
176 int reg, u8 *buf, int len)
178 acx565akm_transfer(ddata, reg, NULL, 0, buf, len);
181 static void hw_guard_start(struct panel_drv_data *ddata, int guard_msec)
183 ddata->hw_guard_wait = msecs_to_jiffies(guard_msec);
184 ddata->hw_guard_end = jiffies + ddata->hw_guard_wait;
187 static void hw_guard_wait(struct panel_drv_data *ddata)
189 unsigned long wait = ddata->hw_guard_end - jiffies;
191 if ((long)wait > 0 && wait <= ddata->hw_guard_wait) {
192 set_current_state(TASK_UNINTERRUPTIBLE);
193 schedule_timeout(wait);
197 static void set_sleep_mode(struct panel_drv_data *ddata, int on)
199 int cmd;
201 if (on)
202 cmd = MIPID_CMD_SLEEP_IN;
203 else
204 cmd = MIPID_CMD_SLEEP_OUT;
206 * We have to keep 120msec between sleep in/out commands.
207 * (8.2.15, 8.2.16).
209 hw_guard_wait(ddata);
210 acx565akm_cmd(ddata, cmd);
211 hw_guard_start(ddata, 120);
214 static void set_display_state(struct panel_drv_data *ddata, int enabled)
216 int cmd = enabled ? MIPID_CMD_DISP_ON : MIPID_CMD_DISP_OFF;
218 acx565akm_cmd(ddata, cmd);
221 static int panel_enabled(struct panel_drv_data *ddata)
223 u32 disp_status;
224 int enabled;
226 acx565akm_read(ddata, MIPID_CMD_READ_DISP_STATUS,
227 (u8 *)&disp_status, 4);
228 disp_status = __be32_to_cpu(disp_status);
229 enabled = (disp_status & (1 << 17)) && (disp_status & (1 << 10));
230 dev_dbg(&ddata->spi->dev,
231 "LCD panel %senabled by bootloader (status 0x%04x)\n",
232 enabled ? "" : "not ", disp_status);
233 return enabled;
236 static int panel_detect(struct panel_drv_data *ddata)
238 acx565akm_read(ddata, MIPID_CMD_READ_DISP_ID, ddata->display_id, 3);
239 dev_dbg(&ddata->spi->dev, "MIPI display ID: %02x%02x%02x\n",
240 ddata->display_id[0],
241 ddata->display_id[1],
242 ddata->display_id[2]);
244 switch (ddata->display_id[0]) {
245 case 0x10:
246 ddata->model = MIPID_VER_ACX565AKM;
247 ddata->name = "acx565akm";
248 ddata->has_bc = 1;
249 ddata->has_cabc = 1;
250 break;
251 case 0x29:
252 ddata->model = MIPID_VER_L4F00311;
253 ddata->name = "l4f00311";
254 break;
255 case 0x45:
256 ddata->model = MIPID_VER_LPH8923;
257 ddata->name = "lph8923";
258 break;
259 case 0x83:
260 ddata->model = MIPID_VER_LS041Y3;
261 ddata->name = "ls041y3";
262 break;
263 default:
264 ddata->name = "unknown";
265 dev_err(&ddata->spi->dev, "invalid display ID\n");
266 return -ENODEV;
269 ddata->revision = ddata->display_id[1];
271 dev_info(&ddata->spi->dev, "omapfb: %s rev %02x LCD detected\n",
272 ddata->name, ddata->revision);
274 return 0;
277 /*----------------------Backlight Control-------------------------*/
279 static void enable_backlight_ctrl(struct panel_drv_data *ddata, int enable)
281 u16 ctrl;
283 acx565akm_read(ddata, MIPID_CMD_READ_CTRL_DISP, (u8 *)&ctrl, 1);
284 if (enable) {
285 ctrl |= CTRL_DISP_BRIGHTNESS_CTRL_ON |
286 CTRL_DISP_BACKLIGHT_ON;
287 } else {
288 ctrl &= ~(CTRL_DISP_BRIGHTNESS_CTRL_ON |
289 CTRL_DISP_BACKLIGHT_ON);
292 ctrl |= 1 << 8;
293 acx565akm_write(ddata, MIPID_CMD_WRITE_CTRL_DISP, (u8 *)&ctrl, 2);
296 static void set_cabc_mode(struct panel_drv_data *ddata, unsigned mode)
298 u16 cabc_ctrl;
300 ddata->cabc_mode = mode;
301 if (!ddata->enabled)
302 return;
303 cabc_ctrl = 0;
304 acx565akm_read(ddata, MIPID_CMD_READ_CABC, (u8 *)&cabc_ctrl, 1);
305 cabc_ctrl &= ~3;
306 cabc_ctrl |= (1 << 8) | (mode & 3);
307 acx565akm_write(ddata, MIPID_CMD_WRITE_CABC, (u8 *)&cabc_ctrl, 2);
310 static unsigned get_cabc_mode(struct panel_drv_data *ddata)
312 return ddata->cabc_mode;
315 static unsigned get_hw_cabc_mode(struct panel_drv_data *ddata)
317 u8 cabc_ctrl;
319 acx565akm_read(ddata, MIPID_CMD_READ_CABC, &cabc_ctrl, 1);
320 return cabc_ctrl & 3;
323 static void acx565akm_set_brightness(struct panel_drv_data *ddata, int level)
325 int bv;
327 bv = level | (1 << 8);
328 acx565akm_write(ddata, MIPID_CMD_WRITE_DISP_BRIGHTNESS, (u8 *)&bv, 2);
330 if (level)
331 enable_backlight_ctrl(ddata, 1);
332 else
333 enable_backlight_ctrl(ddata, 0);
336 static int acx565akm_get_actual_brightness(struct panel_drv_data *ddata)
338 u8 bv;
340 acx565akm_read(ddata, MIPID_CMD_READ_DISP_BRIGHTNESS, &bv, 1);
342 return bv;
346 static int acx565akm_bl_update_status(struct backlight_device *dev)
348 struct panel_drv_data *ddata = dev_get_drvdata(&dev->dev);
349 int r;
350 int level;
352 dev_dbg(&ddata->spi->dev, "%s\n", __func__);
354 mutex_lock(&ddata->mutex);
356 if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
357 dev->props.power == FB_BLANK_UNBLANK)
358 level = dev->props.brightness;
359 else
360 level = 0;
362 r = 0;
363 if (ddata->has_bc)
364 acx565akm_set_brightness(ddata, level);
365 else
366 r = -ENODEV;
368 mutex_unlock(&ddata->mutex);
370 return r;
373 static int acx565akm_bl_get_intensity(struct backlight_device *dev)
375 struct panel_drv_data *ddata = dev_get_drvdata(&dev->dev);
377 dev_dbg(&dev->dev, "%s\n", __func__);
379 if (!ddata->has_bc)
380 return -ENODEV;
382 if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
383 dev->props.power == FB_BLANK_UNBLANK) {
384 if (ddata->has_bc)
385 return acx565akm_get_actual_brightness(ddata);
386 else
387 return dev->props.brightness;
390 return 0;
393 static const struct backlight_ops acx565akm_bl_ops = {
394 .get_brightness = acx565akm_bl_get_intensity,
395 .update_status = acx565akm_bl_update_status,
398 /*--------------------Auto Brightness control via Sysfs---------------------*/
400 static const char * const cabc_modes[] = {
401 "off", /* always used when CABC is not supported */
402 "ui",
403 "still-image",
404 "moving-image",
407 static ssize_t show_cabc_mode(struct device *dev,
408 struct device_attribute *attr,
409 char *buf)
411 struct panel_drv_data *ddata = dev_get_drvdata(dev);
412 const char *mode_str;
413 int mode;
414 int len;
416 if (!ddata->has_cabc)
417 mode = 0;
418 else
419 mode = get_cabc_mode(ddata);
420 mode_str = "unknown";
421 if (mode >= 0 && mode < ARRAY_SIZE(cabc_modes))
422 mode_str = cabc_modes[mode];
423 len = snprintf(buf, PAGE_SIZE, "%s\n", mode_str);
425 return len < PAGE_SIZE - 1 ? len : PAGE_SIZE - 1;
428 static ssize_t store_cabc_mode(struct device *dev,
429 struct device_attribute *attr,
430 const char *buf, size_t count)
432 struct panel_drv_data *ddata = dev_get_drvdata(dev);
433 int i;
435 for (i = 0; i < ARRAY_SIZE(cabc_modes); i++) {
436 const char *mode_str = cabc_modes[i];
437 int cmp_len = strlen(mode_str);
439 if (count > 0 && buf[count - 1] == '\n')
440 count--;
441 if (count != cmp_len)
442 continue;
444 if (strncmp(buf, mode_str, cmp_len) == 0)
445 break;
448 if (i == ARRAY_SIZE(cabc_modes))
449 return -EINVAL;
451 if (!ddata->has_cabc && i != 0)
452 return -EINVAL;
454 mutex_lock(&ddata->mutex);
455 set_cabc_mode(ddata, i);
456 mutex_unlock(&ddata->mutex);
458 return count;
461 static ssize_t show_cabc_available_modes(struct device *dev,
462 struct device_attribute *attr,
463 char *buf)
465 struct panel_drv_data *ddata = dev_get_drvdata(dev);
466 int len;
467 int i;
469 if (!ddata->has_cabc)
470 return snprintf(buf, PAGE_SIZE, "%s\n", cabc_modes[0]);
472 for (i = 0, len = 0;
473 len < PAGE_SIZE && i < ARRAY_SIZE(cabc_modes); i++)
474 len += snprintf(&buf[len], PAGE_SIZE - len, "%s%s%s",
475 i ? " " : "", cabc_modes[i],
476 i == ARRAY_SIZE(cabc_modes) - 1 ? "\n" : "");
478 return len < PAGE_SIZE ? len : PAGE_SIZE - 1;
481 static DEVICE_ATTR(cabc_mode, S_IRUGO | S_IWUSR,
482 show_cabc_mode, store_cabc_mode);
483 static DEVICE_ATTR(cabc_available_modes, S_IRUGO,
484 show_cabc_available_modes, NULL);
486 static struct attribute *bldev_attrs[] = {
487 &dev_attr_cabc_mode.attr,
488 &dev_attr_cabc_available_modes.attr,
489 NULL,
492 static struct attribute_group bldev_attr_group = {
493 .attrs = bldev_attrs,
496 static int acx565akm_connect(struct omap_dss_device *dssdev)
498 struct panel_drv_data *ddata = to_panel_data(dssdev);
499 struct omap_dss_device *in = ddata->in;
500 int r;
502 if (omapdss_device_is_connected(dssdev))
503 return 0;
505 r = in->ops.sdi->connect(in, dssdev);
506 if (r)
507 return r;
509 return 0;
512 static void acx565akm_disconnect(struct omap_dss_device *dssdev)
514 struct panel_drv_data *ddata = to_panel_data(dssdev);
515 struct omap_dss_device *in = ddata->in;
517 if (!omapdss_device_is_connected(dssdev))
518 return;
520 in->ops.sdi->disconnect(in, dssdev);
523 static int acx565akm_panel_power_on(struct omap_dss_device *dssdev)
525 struct panel_drv_data *ddata = to_panel_data(dssdev);
526 struct omap_dss_device *in = ddata->in;
527 int r;
529 mutex_lock(&ddata->mutex);
531 dev_dbg(&ddata->spi->dev, "%s\n", __func__);
533 in->ops.sdi->set_timings(in, &ddata->videomode);
534 in->ops.sdi->set_datapairs(in, ddata->datapairs);
536 r = in->ops.sdi->enable(in);
537 if (r) {
538 pr_err("%s sdi enable failed\n", __func__);
539 return r;
542 /*FIXME tweak me */
543 msleep(50);
545 if (gpio_is_valid(ddata->reset_gpio))
546 gpio_set_value(ddata->reset_gpio, 1);
548 if (ddata->enabled) {
549 dev_dbg(&ddata->spi->dev, "panel already enabled\n");
550 return 0;
554 * We have to meet all the following delay requirements:
555 * 1. tRW: reset pulse width 10usec (7.12.1)
556 * 2. tRT: reset cancel time 5msec (7.12.1)
557 * 3. Providing PCLK,HS,VS signals for 2 frames = ~50msec worst
558 * case (7.6.2)
559 * 4. 120msec before the sleep out command (7.12.1)
561 msleep(120);
563 set_sleep_mode(ddata, 0);
564 ddata->enabled = 1;
566 /* 5msec between sleep out and the next command. (8.2.16) */
567 usleep_range(5000, 10000);
568 set_display_state(ddata, 1);
569 set_cabc_mode(ddata, ddata->cabc_mode);
571 mutex_unlock(&ddata->mutex);
573 return acx565akm_bl_update_status(ddata->bl_dev);
576 static void acx565akm_panel_power_off(struct omap_dss_device *dssdev)
578 struct panel_drv_data *ddata = to_panel_data(dssdev);
579 struct omap_dss_device *in = ddata->in;
581 dev_dbg(dssdev->dev, "%s\n", __func__);
583 if (!ddata->enabled)
584 return;
586 set_display_state(ddata, 0);
587 set_sleep_mode(ddata, 1);
588 ddata->enabled = 0;
590 * We have to provide PCLK,HS,VS signals for 2 frames (worst case
591 * ~50msec) after sending the sleep in command and asserting the
592 * reset signal. We probably could assert the reset w/o the delay
593 * but we still delay to avoid possible artifacts. (7.6.1)
595 msleep(50);
597 if (gpio_is_valid(ddata->reset_gpio))
598 gpio_set_value(ddata->reset_gpio, 0);
600 /* FIXME need to tweak this delay */
601 msleep(100);
603 in->ops.sdi->disable(in);
606 static int acx565akm_enable(struct omap_dss_device *dssdev)
608 struct panel_drv_data *ddata = to_panel_data(dssdev);
609 int r;
611 dev_dbg(dssdev->dev, "%s\n", __func__);
613 if (!omapdss_device_is_connected(dssdev))
614 return -ENODEV;
616 if (omapdss_device_is_enabled(dssdev))
617 return 0;
619 r = acx565akm_panel_power_on(dssdev);
620 if (r)
621 return r;
623 dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
625 return 0;
628 static void acx565akm_disable(struct omap_dss_device *dssdev)
630 struct panel_drv_data *ddata = to_panel_data(dssdev);
632 dev_dbg(dssdev->dev, "%s\n", __func__);
634 if (!omapdss_device_is_enabled(dssdev))
635 return;
637 mutex_lock(&ddata->mutex);
638 acx565akm_panel_power_off(dssdev);
639 mutex_unlock(&ddata->mutex);
641 dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
644 static void acx565akm_set_timings(struct omap_dss_device *dssdev,
645 struct omap_video_timings *timings)
647 struct panel_drv_data *ddata = to_panel_data(dssdev);
648 struct omap_dss_device *in = ddata->in;
650 ddata->videomode = *timings;
651 dssdev->panel.timings = *timings;
653 in->ops.sdi->set_timings(in, timings);
656 static void acx565akm_get_timings(struct omap_dss_device *dssdev,
657 struct omap_video_timings *timings)
659 struct panel_drv_data *ddata = to_panel_data(dssdev);
661 *timings = ddata->videomode;
664 static int acx565akm_check_timings(struct omap_dss_device *dssdev,
665 struct omap_video_timings *timings)
667 struct panel_drv_data *ddata = to_panel_data(dssdev);
668 struct omap_dss_device *in = ddata->in;
670 return in->ops.sdi->check_timings(in, timings);
673 static struct omap_dss_driver acx565akm_ops = {
674 .connect = acx565akm_connect,
675 .disconnect = acx565akm_disconnect,
677 .enable = acx565akm_enable,
678 .disable = acx565akm_disable,
680 .set_timings = acx565akm_set_timings,
681 .get_timings = acx565akm_get_timings,
682 .check_timings = acx565akm_check_timings,
684 .get_resolution = omapdss_default_get_resolution,
687 static int acx565akm_probe_pdata(struct spi_device *spi)
689 const struct panel_acx565akm_platform_data *pdata;
690 struct panel_drv_data *ddata = dev_get_drvdata(&spi->dev);
691 struct omap_dss_device *dssdev, *in;
693 pdata = dev_get_platdata(&spi->dev);
695 ddata->reset_gpio = pdata->reset_gpio;
697 in = omap_dss_find_output(pdata->source);
698 if (in == NULL) {
699 dev_err(&spi->dev, "failed to find video source '%s'\n",
700 pdata->source);
701 return -EPROBE_DEFER;
703 ddata->in = in;
705 ddata->datapairs = pdata->datapairs;
707 dssdev = &ddata->dssdev;
708 dssdev->name = pdata->name;
710 return 0;
713 static int acx565akm_probe(struct spi_device *spi)
715 struct panel_drv_data *ddata;
716 struct omap_dss_device *dssdev;
717 struct backlight_device *bldev;
718 int max_brightness, brightness;
719 struct backlight_properties props;
720 int r;
722 dev_dbg(&spi->dev, "%s\n", __func__);
724 spi->mode = SPI_MODE_3;
726 ddata = devm_kzalloc(&spi->dev, sizeof(*ddata), GFP_KERNEL);
727 if (ddata == NULL)
728 return -ENOMEM;
730 dev_set_drvdata(&spi->dev, ddata);
732 ddata->spi = spi;
734 mutex_init(&ddata->mutex);
736 if (dev_get_platdata(&spi->dev)) {
737 r = acx565akm_probe_pdata(spi);
738 if (r)
739 return r;
740 } else {
741 return -ENODEV;
744 if (gpio_is_valid(ddata->reset_gpio)) {
745 r = devm_gpio_request_one(&spi->dev, ddata->reset_gpio,
746 GPIOF_OUT_INIT_LOW, "lcd reset");
747 if (r)
748 goto err_gpio;
751 if (gpio_is_valid(ddata->reset_gpio))
752 gpio_set_value(ddata->reset_gpio, 1);
755 * After reset we have to wait 5 msec before the first
756 * command can be sent.
758 usleep_range(5000, 10000);
760 ddata->enabled = panel_enabled(ddata);
762 r = panel_detect(ddata);
764 if (!ddata->enabled && gpio_is_valid(ddata->reset_gpio))
765 gpio_set_value(ddata->reset_gpio, 0);
767 if (r) {
768 dev_err(&spi->dev, "%s panel detect error\n", __func__);
769 goto err_detect;
772 memset(&props, 0, sizeof(props));
773 props.fb_blank = FB_BLANK_UNBLANK;
774 props.power = FB_BLANK_UNBLANK;
775 props.type = BACKLIGHT_RAW;
777 bldev = backlight_device_register("acx565akm", &ddata->spi->dev,
778 ddata, &acx565akm_bl_ops, &props);
779 ddata->bl_dev = bldev;
780 if (ddata->has_cabc) {
781 r = sysfs_create_group(&bldev->dev.kobj, &bldev_attr_group);
782 if (r) {
783 dev_err(&bldev->dev,
784 "%s failed to create sysfs files\n", __func__);
785 goto err_sysfs;
787 ddata->cabc_mode = get_hw_cabc_mode(ddata);
790 max_brightness = 255;
792 if (ddata->has_bc)
793 brightness = acx565akm_get_actual_brightness(ddata);
794 else
795 brightness = 0;
797 bldev->props.max_brightness = max_brightness;
798 bldev->props.brightness = brightness;
800 acx565akm_bl_update_status(bldev);
803 ddata->videomode = acx565akm_panel_timings;
805 dssdev = &ddata->dssdev;
806 dssdev->dev = &spi->dev;
807 dssdev->driver = &acx565akm_ops;
808 dssdev->type = OMAP_DISPLAY_TYPE_SDI;
809 dssdev->owner = THIS_MODULE;
810 dssdev->panel.timings = ddata->videomode;
812 r = omapdss_register_display(dssdev);
813 if (r) {
814 dev_err(&spi->dev, "Failed to register panel\n");
815 goto err_reg;
818 return 0;
820 err_reg:
821 sysfs_remove_group(&bldev->dev.kobj, &bldev_attr_group);
822 err_sysfs:
823 backlight_device_unregister(bldev);
824 err_detect:
825 err_gpio:
826 omap_dss_put_device(ddata->in);
827 return r;
830 static int acx565akm_remove(struct spi_device *spi)
832 struct panel_drv_data *ddata = dev_get_drvdata(&spi->dev);
833 struct omap_dss_device *dssdev = &ddata->dssdev;
834 struct omap_dss_device *in = ddata->in;
836 dev_dbg(&ddata->spi->dev, "%s\n", __func__);
838 sysfs_remove_group(&ddata->bl_dev->dev.kobj, &bldev_attr_group);
839 backlight_device_unregister(ddata->bl_dev);
841 omapdss_unregister_display(dssdev);
843 acx565akm_disable(dssdev);
844 acx565akm_disconnect(dssdev);
846 omap_dss_put_device(in);
848 return 0;
851 static struct spi_driver acx565akm_driver = {
852 .driver = {
853 .name = "acx565akm",
854 .owner = THIS_MODULE,
856 .probe = acx565akm_probe,
857 .remove = acx565akm_remove,
860 module_spi_driver(acx565akm_driver);
862 MODULE_AUTHOR("Nokia Corporation");
863 MODULE_DESCRIPTION("acx565akm LCD Driver");
864 MODULE_LICENSE("GPL");