1 // SPDX-License-Identifier: GPL-2.0+
3 * Copyright (c) 2016 Allwinnertech Co., Ltd.
4 * Copyright (C) 2017-2018 Bootlin
6 * Maxime Ripard <maxime.ripard@bootlin.com>
10 #include <linux/component.h>
11 #include <linux/crc-ccitt.h>
12 #include <linux/module.h>
13 #include <linux/of_address.h>
14 #include <linux/phy/phy-mipi-dphy.h>
15 #include <linux/phy/phy.h>
16 #include <linux/platform_device.h>
17 #include <linux/regmap.h>
18 #include <linux/regulator/consumer.h>
19 #include <linux/reset.h>
20 #include <linux/slab.h>
22 #include <drm/drm_atomic_helper.h>
23 #include <drm/drm_mipi_dsi.h>
24 #include <drm/drm_panel.h>
25 #include <drm/drm_print.h>
26 #include <drm/drm_probe_helper.h>
27 #include <drm/drm_simple_kms_helper.h>
29 #include "sun4i_crtc.h"
30 #include "sun4i_tcon.h"
31 #include "sun6i_mipi_dsi.h"
33 #include <video/mipi_display.h>
35 #define SUN6I_DSI_CTL_REG 0x000
36 #define SUN6I_DSI_CTL_EN BIT(0)
38 #define SUN6I_DSI_BASIC_CTL_REG 0x00c
39 #define SUN6I_DSI_BASIC_CTL_TRAIL_INV(n) (((n) & 0xf) << 4)
40 #define SUN6I_DSI_BASIC_CTL_TRAIL_FILL BIT(3)
41 #define SUN6I_DSI_BASIC_CTL_HBP_DIS BIT(2)
42 #define SUN6I_DSI_BASIC_CTL_HSA_HSE_DIS BIT(1)
43 #define SUN6I_DSI_BASIC_CTL_VIDEO_BURST BIT(0)
45 #define SUN6I_DSI_BASIC_CTL0_REG 0x010
46 #define SUN6I_DSI_BASIC_CTL0_HS_EOTP_EN BIT(18)
47 #define SUN6I_DSI_BASIC_CTL0_CRC_EN BIT(17)
48 #define SUN6I_DSI_BASIC_CTL0_ECC_EN BIT(16)
49 #define SUN6I_DSI_BASIC_CTL0_INST_ST BIT(0)
51 #define SUN6I_DSI_BASIC_CTL1_REG 0x014
52 #define SUN6I_DSI_BASIC_CTL1_VIDEO_ST_DELAY(n) (((n) & 0x1fff) << 4)
53 #define SUN6I_DSI_BASIC_CTL1_VIDEO_FILL BIT(2)
54 #define SUN6I_DSI_BASIC_CTL1_VIDEO_PRECISION BIT(1)
55 #define SUN6I_DSI_BASIC_CTL1_VIDEO_MODE BIT(0)
57 #define SUN6I_DSI_BASIC_SIZE0_REG 0x018
58 #define SUN6I_DSI_BASIC_SIZE0_VBP(n) (((n) & 0xfff) << 16)
59 #define SUN6I_DSI_BASIC_SIZE0_VSA(n) ((n) & 0xfff)
61 #define SUN6I_DSI_BASIC_SIZE1_REG 0x01c
62 #define SUN6I_DSI_BASIC_SIZE1_VT(n) (((n) & 0xfff) << 16)
63 #define SUN6I_DSI_BASIC_SIZE1_VACT(n) ((n) & 0xfff)
65 #define SUN6I_DSI_INST_FUNC_REG(n) (0x020 + (n) * 0x04)
66 #define SUN6I_DSI_INST_FUNC_INST_MODE(n) (((n) & 0xf) << 28)
67 #define SUN6I_DSI_INST_FUNC_ESCAPE_ENTRY(n) (((n) & 0xf) << 24)
68 #define SUN6I_DSI_INST_FUNC_TRANS_PACKET(n) (((n) & 0xf) << 20)
69 #define SUN6I_DSI_INST_FUNC_LANE_CEN BIT(4)
70 #define SUN6I_DSI_INST_FUNC_LANE_DEN(n) ((n) & 0xf)
72 #define SUN6I_DSI_INST_LOOP_SEL_REG 0x040
74 #define SUN6I_DSI_INST_LOOP_NUM_REG(n) (0x044 + (n) * 0x10)
75 #define SUN6I_DSI_INST_LOOP_NUM_N1(n) (((n) & 0xfff) << 16)
76 #define SUN6I_DSI_INST_LOOP_NUM_N0(n) ((n) & 0xfff)
78 #define SUN6I_DSI_INST_JUMP_SEL_REG 0x048
80 #define SUN6I_DSI_INST_JUMP_CFG_REG(n) (0x04c + (n) * 0x04)
81 #define SUN6I_DSI_INST_JUMP_CFG_TO(n) (((n) & 0xf) << 20)
82 #define SUN6I_DSI_INST_JUMP_CFG_POINT(n) (((n) & 0xf) << 16)
83 #define SUN6I_DSI_INST_JUMP_CFG_NUM(n) ((n) & 0xffff)
85 #define SUN6I_DSI_TRANS_START_REG 0x060
87 #define SUN6I_DSI_TRANS_ZERO_REG 0x078
89 #define SUN6I_DSI_TCON_DRQ_REG 0x07c
90 #define SUN6I_DSI_TCON_DRQ_ENABLE_MODE BIT(28)
91 #define SUN6I_DSI_TCON_DRQ_SET(n) ((n) & 0x3ff)
93 #define SUN6I_DSI_PIXEL_CTL0_REG 0x080
94 #define SUN6I_DSI_PIXEL_CTL0_PD_PLUG_DISABLE BIT(16)
95 #define SUN6I_DSI_PIXEL_CTL0_FORMAT(n) ((n) & 0xf)
97 #define SUN6I_DSI_PIXEL_CTL1_REG 0x084
99 #define SUN6I_DSI_PIXEL_PH_REG 0x090
100 #define SUN6I_DSI_PIXEL_PH_ECC(n) (((n) & 0xff) << 24)
101 #define SUN6I_DSI_PIXEL_PH_WC(n) (((n) & 0xffff) << 8)
102 #define SUN6I_DSI_PIXEL_PH_VC(n) (((n) & 3) << 6)
103 #define SUN6I_DSI_PIXEL_PH_DT(n) ((n) & 0x3f)
105 #define SUN6I_DSI_PIXEL_PF0_REG 0x098
106 #define SUN6I_DSI_PIXEL_PF0_CRC_FORCE(n) ((n) & 0xffff)
108 #define SUN6I_DSI_PIXEL_PF1_REG 0x09c
109 #define SUN6I_DSI_PIXEL_PF1_CRC_INIT_LINEN(n) (((n) & 0xffff) << 16)
110 #define SUN6I_DSI_PIXEL_PF1_CRC_INIT_LINE0(n) ((n) & 0xffff)
112 #define SUN6I_DSI_SYNC_HSS_REG 0x0b0
114 #define SUN6I_DSI_SYNC_HSE_REG 0x0b4
116 #define SUN6I_DSI_SYNC_VSS_REG 0x0b8
118 #define SUN6I_DSI_SYNC_VSE_REG 0x0bc
120 #define SUN6I_DSI_BLK_HSA0_REG 0x0c0
122 #define SUN6I_DSI_BLK_HSA1_REG 0x0c4
123 #define SUN6I_DSI_BLK_PF(n) (((n) & 0xffff) << 16)
124 #define SUN6I_DSI_BLK_PD(n) ((n) & 0xff)
126 #define SUN6I_DSI_BLK_HBP0_REG 0x0c8
128 #define SUN6I_DSI_BLK_HBP1_REG 0x0cc
130 #define SUN6I_DSI_BLK_HFP0_REG 0x0d0
132 #define SUN6I_DSI_BLK_HFP1_REG 0x0d4
134 #define SUN6I_DSI_BLK_HBLK0_REG 0x0e0
136 #define SUN6I_DSI_BLK_HBLK1_REG 0x0e4
138 #define SUN6I_DSI_BLK_VBLK0_REG 0x0e8
140 #define SUN6I_DSI_BLK_VBLK1_REG 0x0ec
142 #define SUN6I_DSI_BURST_LINE_REG 0x0f0
143 #define SUN6I_DSI_BURST_LINE_SYNC_POINT(n) (((n) & 0xffff) << 16)
144 #define SUN6I_DSI_BURST_LINE_NUM(n) ((n) & 0xffff)
146 #define SUN6I_DSI_BURST_DRQ_REG 0x0f4
147 #define SUN6I_DSI_BURST_DRQ_EDGE1(n) (((n) & 0xffff) << 16)
148 #define SUN6I_DSI_BURST_DRQ_EDGE0(n) ((n) & 0xffff)
150 #define SUN6I_DSI_CMD_CTL_REG 0x200
151 #define SUN6I_DSI_CMD_CTL_RX_OVERFLOW BIT(26)
152 #define SUN6I_DSI_CMD_CTL_RX_FLAG BIT(25)
153 #define SUN6I_DSI_CMD_CTL_TX_FLAG BIT(9)
155 #define SUN6I_DSI_CMD_RX_REG(n) (0x240 + (n) * 0x04)
157 #define SUN6I_DSI_DEBUG_DATA_REG 0x2f8
159 #define SUN6I_DSI_CMD_TX_REG(n) (0x300 + (n) * 0x04)
161 #define SUN6I_DSI_SYNC_POINT 40
163 enum sun6i_dsi_start_inst
{
170 enum sun6i_dsi_inst_id
{
171 DSI_INST_ID_LP11
= 0,
179 DSI_INST_ID_END
= 15,
182 enum sun6i_dsi_inst_mode
{
183 DSI_INST_MODE_STOP
= 0,
186 DSI_INST_MODE_ESCAPE
,
187 DSI_INST_MODE_HSCEXIT
,
191 enum sun6i_dsi_inst_escape
{
192 DSI_INST_ESCA_LPDT
= 0,
202 enum sun6i_dsi_inst_packet
{
203 DSI_INST_PACK_PIXEL
= 0,
204 DSI_INST_PACK_COMMAND
,
207 static const u32 sun6i_dsi_ecc_array
[] = {
208 [0] = (BIT(0) | BIT(1) | BIT(2) | BIT(4) | BIT(5) | BIT(7) | BIT(10) |
209 BIT(11) | BIT(13) | BIT(16) | BIT(20) | BIT(21) | BIT(22) |
211 [1] = (BIT(0) | BIT(1) | BIT(3) | BIT(4) | BIT(6) | BIT(8) | BIT(10) |
212 BIT(12) | BIT(14) | BIT(17) | BIT(20) | BIT(21) | BIT(22) |
214 [2] = (BIT(0) | BIT(2) | BIT(3) | BIT(5) | BIT(6) | BIT(9) | BIT(11) |
215 BIT(12) | BIT(15) | BIT(18) | BIT(20) | BIT(21) | BIT(22)),
216 [3] = (BIT(1) | BIT(2) | BIT(3) | BIT(7) | BIT(8) | BIT(9) | BIT(13) |
217 BIT(14) | BIT(15) | BIT(19) | BIT(20) | BIT(21) | BIT(23)),
218 [4] = (BIT(4) | BIT(5) | BIT(6) | BIT(7) | BIT(8) | BIT(9) | BIT(16) |
219 BIT(17) | BIT(18) | BIT(19) | BIT(20) | BIT(22) | BIT(23)),
220 [5] = (BIT(10) | BIT(11) | BIT(12) | BIT(13) | BIT(14) | BIT(15) |
221 BIT(16) | BIT(17) | BIT(18) | BIT(19) | BIT(21) | BIT(22) |
225 static u32
sun6i_dsi_ecc_compute(unsigned int data
)
230 for (i
= 0; i
< ARRAY_SIZE(sun6i_dsi_ecc_array
); i
++) {
231 u32 field
= sun6i_dsi_ecc_array
[i
];
236 for (j
= 0; j
< 24; j
++) {
237 if (!(BIT(j
) & field
))
241 val
= (BIT(j
) & data
) ? 1 : 0;
244 val
^= (BIT(j
) & data
) ? 1 : 0;
254 static u16
sun6i_dsi_crc_compute(u8
const *buffer
, size_t len
)
256 return crc_ccitt(0xffff, buffer
, len
);
259 static u16
sun6i_dsi_crc_repeat(u8 pd
, u8
*buffer
, size_t len
)
261 memset(buffer
, pd
, len
);
263 return sun6i_dsi_crc_compute(buffer
, len
);
266 static u32
sun6i_dsi_build_sync_pkt(u8 dt
, u8 vc
, u8 d0
, u8 d1
)
270 val
|= (vc
& 3) << 6;
271 val
|= (d0
& 0xff) << 8;
272 val
|= (d1
& 0xff) << 16;
273 val
|= sun6i_dsi_ecc_compute(val
) << 24;
278 static u32
sun6i_dsi_build_blk0_pkt(u8 vc
, u16 wc
)
280 return sun6i_dsi_build_sync_pkt(MIPI_DSI_BLANKING_PACKET
, vc
,
284 static u32
sun6i_dsi_build_blk1_pkt(u16 pd
, u8
*buffer
, size_t len
)
286 u32 val
= SUN6I_DSI_BLK_PD(pd
);
288 return val
| SUN6I_DSI_BLK_PF(sun6i_dsi_crc_repeat(pd
, buffer
, len
));
291 static void sun6i_dsi_inst_abort(struct sun6i_dsi
*dsi
)
293 regmap_update_bits(dsi
->regs
, SUN6I_DSI_BASIC_CTL0_REG
,
294 SUN6I_DSI_BASIC_CTL0_INST_ST
, 0);
297 static void sun6i_dsi_inst_commit(struct sun6i_dsi
*dsi
)
299 regmap_update_bits(dsi
->regs
, SUN6I_DSI_BASIC_CTL0_REG
,
300 SUN6I_DSI_BASIC_CTL0_INST_ST
,
301 SUN6I_DSI_BASIC_CTL0_INST_ST
);
304 static int sun6i_dsi_inst_wait_for_completion(struct sun6i_dsi
*dsi
)
308 return regmap_read_poll_timeout(dsi
->regs
, SUN6I_DSI_BASIC_CTL0_REG
,
310 !(val
& SUN6I_DSI_BASIC_CTL0_INST_ST
),
314 static void sun6i_dsi_inst_setup(struct sun6i_dsi
*dsi
,
315 enum sun6i_dsi_inst_id id
,
316 enum sun6i_dsi_inst_mode mode
,
318 enum sun6i_dsi_inst_packet packet
,
319 enum sun6i_dsi_inst_escape escape
)
321 regmap_write(dsi
->regs
, SUN6I_DSI_INST_FUNC_REG(id
),
322 SUN6I_DSI_INST_FUNC_INST_MODE(mode
) |
323 SUN6I_DSI_INST_FUNC_ESCAPE_ENTRY(escape
) |
324 SUN6I_DSI_INST_FUNC_TRANS_PACKET(packet
) |
325 (clock
? SUN6I_DSI_INST_FUNC_LANE_CEN
: 0) |
326 SUN6I_DSI_INST_FUNC_LANE_DEN(data
));
329 static void sun6i_dsi_inst_init(struct sun6i_dsi
*dsi
,
330 struct mipi_dsi_device
*device
)
332 u8 lanes_mask
= GENMASK(device
->lanes
- 1, 0);
334 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_LP11
, DSI_INST_MODE_STOP
,
335 true, lanes_mask
, 0, 0);
337 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_TBA
, DSI_INST_MODE_TBA
,
340 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_HSC
, DSI_INST_MODE_HS
,
341 true, 0, DSI_INST_PACK_PIXEL
, 0);
343 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_HSD
, DSI_INST_MODE_HS
,
344 false, lanes_mask
, DSI_INST_PACK_PIXEL
, 0);
346 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_LPDT
, DSI_INST_MODE_ESCAPE
,
347 false, 1, DSI_INST_PACK_COMMAND
,
350 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_HSCEXIT
, DSI_INST_MODE_HSCEXIT
,
353 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_NOP
, DSI_INST_MODE_STOP
,
354 false, lanes_mask
, 0, 0);
356 sun6i_dsi_inst_setup(dsi
, DSI_INST_ID_DLY
, DSI_INST_MODE_NOP
,
357 true, lanes_mask
, 0, 0);
359 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_CFG_REG(0),
360 SUN6I_DSI_INST_JUMP_CFG_POINT(DSI_INST_ID_NOP
) |
361 SUN6I_DSI_INST_JUMP_CFG_TO(DSI_INST_ID_HSCEXIT
) |
362 SUN6I_DSI_INST_JUMP_CFG_NUM(1));
365 static u16
sun6i_dsi_get_video_start_delay(struct sun6i_dsi
*dsi
,
366 struct drm_display_mode
*mode
)
368 u16 delay
= mode
->vtotal
- (mode
->vsync_start
- mode
->vdisplay
) + 1;
370 if (delay
> mode
->vtotal
)
371 delay
= delay
% mode
->vtotal
;
373 return max_t(u16
, delay
, 1);
376 static u16
sun6i_dsi_get_line_num(struct sun6i_dsi
*dsi
,
377 struct drm_display_mode
*mode
)
379 struct mipi_dsi_device
*device
= dsi
->device
;
380 unsigned int Bpp
= mipi_dsi_pixel_format_to_bpp(device
->format
) / 8;
382 return mode
->htotal
* Bpp
/ device
->lanes
;
385 static u16
sun6i_dsi_get_drq_edge0(struct sun6i_dsi
*dsi
,
386 struct drm_display_mode
*mode
,
387 u16 line_num
, u16 edge1
)
391 edge0
+= (mode
->hdisplay
+ 40) * SUN6I_DSI_TCON_DIV
/ 8;
393 if (edge0
> line_num
)
394 return edge0
- line_num
;
399 static u16
sun6i_dsi_get_drq_edge1(struct sun6i_dsi
*dsi
,
400 struct drm_display_mode
*mode
,
403 struct mipi_dsi_device
*device
= dsi
->device
;
404 unsigned int Bpp
= mipi_dsi_pixel_format_to_bpp(device
->format
) / 8;
405 unsigned int hbp
= mode
->htotal
- mode
->hsync_end
;
408 edge1
= SUN6I_DSI_SYNC_POINT
;
409 edge1
+= (mode
->hdisplay
+ hbp
+ 20) * Bpp
/ device
->lanes
;
411 if (edge1
> line_num
)
417 static void sun6i_dsi_setup_burst(struct sun6i_dsi
*dsi
,
418 struct drm_display_mode
*mode
)
420 struct mipi_dsi_device
*device
= dsi
->device
;
423 if (device
->mode_flags
& MIPI_DSI_MODE_VIDEO_BURST
) {
424 u16 line_num
= sun6i_dsi_get_line_num(dsi
, mode
);
427 edge1
= sun6i_dsi_get_drq_edge1(dsi
, mode
, line_num
);
428 edge0
= sun6i_dsi_get_drq_edge0(dsi
, mode
, line_num
, edge1
);
430 regmap_write(dsi
->regs
, SUN6I_DSI_BURST_DRQ_REG
,
431 SUN6I_DSI_BURST_DRQ_EDGE0(edge0
) |
432 SUN6I_DSI_BURST_DRQ_EDGE1(edge1
));
434 regmap_write(dsi
->regs
, SUN6I_DSI_BURST_LINE_REG
,
435 SUN6I_DSI_BURST_LINE_NUM(line_num
) |
436 SUN6I_DSI_BURST_LINE_SYNC_POINT(SUN6I_DSI_SYNC_POINT
));
438 val
= SUN6I_DSI_TCON_DRQ_ENABLE_MODE
;
439 } else if ((mode
->hsync_start
- mode
->hdisplay
) > 20) {
441 u16 drq
= (mode
->hsync_start
- mode
->hdisplay
) - 20;
443 drq
*= mipi_dsi_pixel_format_to_bpp(device
->format
);
446 val
= (SUN6I_DSI_TCON_DRQ_ENABLE_MODE
|
447 SUN6I_DSI_TCON_DRQ_SET(drq
));
450 regmap_write(dsi
->regs
, SUN6I_DSI_TCON_DRQ_REG
, val
);
453 static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi
*dsi
,
454 struct drm_display_mode
*mode
)
456 struct mipi_dsi_device
*device
= dsi
->device
;
459 if (device
->mode_flags
& MIPI_DSI_MODE_VIDEO_BURST
) {
460 u32 hsync_porch
= (mode
->htotal
- mode
->hdisplay
) * 150;
462 delay
= (hsync_porch
/ ((mode
->clock
/ 1000) * 8));
466 regmap_write(dsi
->regs
, SUN6I_DSI_INST_LOOP_SEL_REG
,
467 2 << (4 * DSI_INST_ID_LP11
) |
468 3 << (4 * DSI_INST_ID_DLY
));
470 regmap_write(dsi
->regs
, SUN6I_DSI_INST_LOOP_NUM_REG(0),
471 SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) |
472 SUN6I_DSI_INST_LOOP_NUM_N1(delay
));
473 regmap_write(dsi
->regs
, SUN6I_DSI_INST_LOOP_NUM_REG(1),
474 SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) |
475 SUN6I_DSI_INST_LOOP_NUM_N1(delay
));
478 static void sun6i_dsi_setup_format(struct sun6i_dsi
*dsi
,
479 struct drm_display_mode
*mode
)
481 struct mipi_dsi_device
*device
= dsi
->device
;
482 u32 val
= SUN6I_DSI_PIXEL_PH_VC(device
->channel
);
487 * TODO: The format defines are only valid in video mode and
488 * change in command mode.
490 switch (device
->format
) {
491 case MIPI_DSI_FMT_RGB888
:
492 dt
= MIPI_DSI_PACKED_PIXEL_STREAM_24
;
495 case MIPI_DSI_FMT_RGB666
:
496 dt
= MIPI_DSI_PIXEL_STREAM_3BYTE_18
;
499 case MIPI_DSI_FMT_RGB666_PACKED
:
500 dt
= MIPI_DSI_PACKED_PIXEL_STREAM_18
;
503 case MIPI_DSI_FMT_RGB565
:
504 dt
= MIPI_DSI_PACKED_PIXEL_STREAM_16
;
510 val
|= SUN6I_DSI_PIXEL_PH_DT(dt
);
512 wc
= mode
->hdisplay
* mipi_dsi_pixel_format_to_bpp(device
->format
) / 8;
513 val
|= SUN6I_DSI_PIXEL_PH_WC(wc
);
514 val
|= SUN6I_DSI_PIXEL_PH_ECC(sun6i_dsi_ecc_compute(val
));
516 regmap_write(dsi
->regs
, SUN6I_DSI_PIXEL_PH_REG
, val
);
518 regmap_write(dsi
->regs
, SUN6I_DSI_PIXEL_PF0_REG
,
519 SUN6I_DSI_PIXEL_PF0_CRC_FORCE(0xffff));
521 regmap_write(dsi
->regs
, SUN6I_DSI_PIXEL_PF1_REG
,
522 SUN6I_DSI_PIXEL_PF1_CRC_INIT_LINE0(0xffff) |
523 SUN6I_DSI_PIXEL_PF1_CRC_INIT_LINEN(0xffff));
525 regmap_write(dsi
->regs
, SUN6I_DSI_PIXEL_CTL0_REG
,
526 SUN6I_DSI_PIXEL_CTL0_PD_PLUG_DISABLE
|
527 SUN6I_DSI_PIXEL_CTL0_FORMAT(fmt
));
530 static void sun6i_dsi_setup_timings(struct sun6i_dsi
*dsi
,
531 struct drm_display_mode
*mode
)
533 struct mipi_dsi_device
*device
= dsi
->device
;
534 unsigned int Bpp
= mipi_dsi_pixel_format_to_bpp(device
->format
) / 8;
535 u16 hbp
= 0, hfp
= 0, hsa
= 0, hblk
= 0, vblk
= 0;
540 /* Do all timing calculations up front to allocate buffer space */
542 if (device
->mode_flags
& MIPI_DSI_MODE_VIDEO_BURST
) {
543 hblk
= mode
->hdisplay
* Bpp
;
544 basic_ctl
= SUN6I_DSI_BASIC_CTL_VIDEO_BURST
|
545 SUN6I_DSI_BASIC_CTL_HSA_HSE_DIS
|
546 SUN6I_DSI_BASIC_CTL_HBP_DIS
;
548 if (device
->lanes
== 4)
549 basic_ctl
|= SUN6I_DSI_BASIC_CTL_TRAIL_FILL
|
550 SUN6I_DSI_BASIC_CTL_TRAIL_INV(0xc);
553 * A sync period is composed of a blanking packet (4
554 * bytes + payload + 2 bytes) and a sync event packet
555 * (4 bytes). Its minimal size is therefore 10 bytes
557 #define HSA_PACKET_OVERHEAD 10
558 hsa
= max((unsigned int)HSA_PACKET_OVERHEAD
,
559 (mode
->hsync_end
- mode
->hsync_start
) * Bpp
- HSA_PACKET_OVERHEAD
);
562 * The backporch is set using a blanking packet (4
563 * bytes + payload + 2 bytes). Its minimal size is
566 #define HBP_PACKET_OVERHEAD 6
567 hbp
= max((unsigned int)HBP_PACKET_OVERHEAD
,
568 (mode
->htotal
- mode
->hsync_end
) * Bpp
- HBP_PACKET_OVERHEAD
);
571 * The frontporch is set using a sync event (4 bytes)
572 * and two blanking packets (each one is 4 bytes +
573 * payload + 2 bytes). Its minimal size is therefore
576 #define HFP_PACKET_OVERHEAD 16
577 hfp
= max((unsigned int)HFP_PACKET_OVERHEAD
,
578 (mode
->hsync_start
- mode
->hdisplay
) * Bpp
- HFP_PACKET_OVERHEAD
);
581 * The blanking is set using a sync event (4 bytes)
582 * and a blanking packet (4 bytes + payload + 2
583 * bytes). Its minimal size is therefore 10 bytes.
585 #define HBLK_PACKET_OVERHEAD 10
586 hblk
= max((unsigned int)HBLK_PACKET_OVERHEAD
,
587 (mode
->htotal
- (mode
->hsync_end
- mode
->hsync_start
)) * Bpp
-
588 HBLK_PACKET_OVERHEAD
);
591 * And I'm not entirely sure what vblk is about. The driver in
592 * Allwinner BSP is using a rather convoluted calculation
593 * there only for 4 lanes. However, using 0 (the !4 lanes
594 * case) even with a 4 lanes screen seems to work...
599 /* How many bytes do we need to send all payloads? */
600 bytes
= max_t(size_t, max(max(hfp
, hblk
), max(hsa
, hbp
)), vblk
);
601 buffer
= kmalloc(bytes
, GFP_KERNEL
);
602 if (WARN_ON(!buffer
))
605 regmap_write(dsi
->regs
, SUN6I_DSI_BASIC_CTL_REG
, basic_ctl
);
607 regmap_write(dsi
->regs
, SUN6I_DSI_SYNC_HSS_REG
,
608 sun6i_dsi_build_sync_pkt(MIPI_DSI_H_SYNC_START
,
612 regmap_write(dsi
->regs
, SUN6I_DSI_SYNC_HSE_REG
,
613 sun6i_dsi_build_sync_pkt(MIPI_DSI_H_SYNC_END
,
617 regmap_write(dsi
->regs
, SUN6I_DSI_SYNC_VSS_REG
,
618 sun6i_dsi_build_sync_pkt(MIPI_DSI_V_SYNC_START
,
622 regmap_write(dsi
->regs
, SUN6I_DSI_SYNC_VSE_REG
,
623 sun6i_dsi_build_sync_pkt(MIPI_DSI_V_SYNC_END
,
627 regmap_write(dsi
->regs
, SUN6I_DSI_BASIC_SIZE0_REG
,
628 SUN6I_DSI_BASIC_SIZE0_VSA(mode
->vsync_end
-
630 SUN6I_DSI_BASIC_SIZE0_VBP(mode
->vtotal
-
633 regmap_write(dsi
->regs
, SUN6I_DSI_BASIC_SIZE1_REG
,
634 SUN6I_DSI_BASIC_SIZE1_VACT(mode
->vdisplay
) |
635 SUN6I_DSI_BASIC_SIZE1_VT(mode
->vtotal
));
638 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HSA0_REG
,
639 sun6i_dsi_build_blk0_pkt(device
->channel
, hsa
));
640 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HSA1_REG
,
641 sun6i_dsi_build_blk1_pkt(0, buffer
, hsa
));
644 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HBP0_REG
,
645 sun6i_dsi_build_blk0_pkt(device
->channel
, hbp
));
646 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HBP1_REG
,
647 sun6i_dsi_build_blk1_pkt(0, buffer
, hbp
));
650 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HFP0_REG
,
651 sun6i_dsi_build_blk0_pkt(device
->channel
, hfp
));
652 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HFP1_REG
,
653 sun6i_dsi_build_blk1_pkt(0, buffer
, hfp
));
656 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HBLK0_REG
,
657 sun6i_dsi_build_blk0_pkt(device
->channel
, hblk
));
658 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_HBLK1_REG
,
659 sun6i_dsi_build_blk1_pkt(0, buffer
, hblk
));
662 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_VBLK0_REG
,
663 sun6i_dsi_build_blk0_pkt(device
->channel
, vblk
));
664 regmap_write(dsi
->regs
, SUN6I_DSI_BLK_VBLK1_REG
,
665 sun6i_dsi_build_blk1_pkt(0, buffer
, vblk
));
670 static int sun6i_dsi_start(struct sun6i_dsi
*dsi
,
671 enum sun6i_dsi_start_inst func
)
675 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_SEL_REG
,
676 DSI_INST_ID_LPDT
<< (4 * DSI_INST_ID_LP11
) |
677 DSI_INST_ID_END
<< (4 * DSI_INST_ID_LPDT
));
680 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_SEL_REG
,
681 DSI_INST_ID_LPDT
<< (4 * DSI_INST_ID_LP11
) |
682 DSI_INST_ID_DLY
<< (4 * DSI_INST_ID_LPDT
) |
683 DSI_INST_ID_TBA
<< (4 * DSI_INST_ID_DLY
) |
684 DSI_INST_ID_END
<< (4 * DSI_INST_ID_TBA
));
687 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_SEL_REG
,
688 DSI_INST_ID_HSC
<< (4 * DSI_INST_ID_LP11
) |
689 DSI_INST_ID_END
<< (4 * DSI_INST_ID_HSC
));
692 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_SEL_REG
,
693 DSI_INST_ID_NOP
<< (4 * DSI_INST_ID_LP11
) |
694 DSI_INST_ID_HSD
<< (4 * DSI_INST_ID_NOP
) |
695 DSI_INST_ID_DLY
<< (4 * DSI_INST_ID_HSD
) |
696 DSI_INST_ID_NOP
<< (4 * DSI_INST_ID_DLY
) |
697 DSI_INST_ID_END
<< (4 * DSI_INST_ID_HSCEXIT
));
700 regmap_write(dsi
->regs
, SUN6I_DSI_INST_JUMP_SEL_REG
,
701 DSI_INST_ID_END
<< (4 * DSI_INST_ID_LP11
));
705 sun6i_dsi_inst_abort(dsi
);
706 sun6i_dsi_inst_commit(dsi
);
708 if (func
== DSI_START_HSC
)
709 regmap_write_bits(dsi
->regs
,
710 SUN6I_DSI_INST_FUNC_REG(DSI_INST_ID_LP11
),
711 SUN6I_DSI_INST_FUNC_LANE_CEN
, 0);
716 static void sun6i_dsi_encoder_enable(struct drm_encoder
*encoder
)
718 struct drm_display_mode
*mode
= &encoder
->crtc
->state
->adjusted_mode
;
719 struct sun6i_dsi
*dsi
= encoder_to_sun6i_dsi(encoder
);
720 struct mipi_dsi_device
*device
= dsi
->device
;
721 union phy_configure_opts opts
= { };
722 struct phy_configure_opts_mipi_dphy
*cfg
= &opts
.mipi_dphy
;
726 DRM_DEBUG_DRIVER("Enabling DSI output\n");
728 err
= regulator_enable(dsi
->regulator
);
730 dev_warn(dsi
->dev
, "failed to enable VCC-DSI supply: %d\n", err
);
732 reset_control_deassert(dsi
->reset
);
733 clk_prepare_enable(dsi
->mod_clk
);
736 * Enable the DSI block.
738 regmap_write(dsi
->regs
, SUN6I_DSI_CTL_REG
, SUN6I_DSI_CTL_EN
);
740 regmap_write(dsi
->regs
, SUN6I_DSI_BASIC_CTL0_REG
,
741 SUN6I_DSI_BASIC_CTL0_ECC_EN
| SUN6I_DSI_BASIC_CTL0_CRC_EN
);
743 regmap_write(dsi
->regs
, SUN6I_DSI_TRANS_START_REG
, 10);
744 regmap_write(dsi
->regs
, SUN6I_DSI_TRANS_ZERO_REG
, 0);
746 sun6i_dsi_inst_init(dsi
, dsi
->device
);
748 regmap_write(dsi
->regs
, SUN6I_DSI_DEBUG_DATA_REG
, 0xff);
750 delay
= sun6i_dsi_get_video_start_delay(dsi
, mode
);
751 regmap_write(dsi
->regs
, SUN6I_DSI_BASIC_CTL1_REG
,
752 SUN6I_DSI_BASIC_CTL1_VIDEO_ST_DELAY(delay
) |
753 SUN6I_DSI_BASIC_CTL1_VIDEO_FILL
|
754 SUN6I_DSI_BASIC_CTL1_VIDEO_PRECISION
|
755 SUN6I_DSI_BASIC_CTL1_VIDEO_MODE
);
757 sun6i_dsi_setup_burst(dsi
, mode
);
758 sun6i_dsi_setup_inst_loop(dsi
, mode
);
759 sun6i_dsi_setup_format(dsi
, mode
);
760 sun6i_dsi_setup_timings(dsi
, mode
);
764 phy_mipi_dphy_get_default_config(mode
->clock
* 1000,
765 mipi_dsi_pixel_format_to_bpp(device
->format
),
768 phy_set_mode(dsi
->dphy
, PHY_MODE_MIPI_DPHY
);
769 phy_configure(dsi
->dphy
, &opts
);
770 phy_power_on(dsi
->dphy
);
773 drm_panel_prepare(dsi
->panel
);
776 * FIXME: This should be moved after the switch to HS mode.
778 * Unfortunately, once in HS mode, it seems like we're not
779 * able to send DCS commands anymore, which would prevent any
780 * panel to send any DCS command as part as their enable
781 * method, which is quite common.
783 * I haven't seen any artifact due to that sub-optimal
784 * ordering on the panels I've tested it with, so I guess this
785 * will do for now, until that IP is better understood.
788 drm_panel_enable(dsi
->panel
);
790 sun6i_dsi_start(dsi
, DSI_START_HSC
);
794 sun6i_dsi_start(dsi
, DSI_START_HSD
);
797 static void sun6i_dsi_encoder_disable(struct drm_encoder
*encoder
)
799 struct sun6i_dsi
*dsi
= encoder_to_sun6i_dsi(encoder
);
801 DRM_DEBUG_DRIVER("Disabling DSI output\n");
804 drm_panel_disable(dsi
->panel
);
805 drm_panel_unprepare(dsi
->panel
);
808 phy_power_off(dsi
->dphy
);
811 clk_disable_unprepare(dsi
->mod_clk
);
812 reset_control_assert(dsi
->reset
);
813 regulator_disable(dsi
->regulator
);
816 static int sun6i_dsi_get_modes(struct drm_connector
*connector
)
818 struct sun6i_dsi
*dsi
= connector_to_sun6i_dsi(connector
);
820 return drm_panel_get_modes(dsi
->panel
, connector
);
823 static const struct drm_connector_helper_funcs sun6i_dsi_connector_helper_funcs
= {
824 .get_modes
= sun6i_dsi_get_modes
,
827 static enum drm_connector_status
828 sun6i_dsi_connector_detect(struct drm_connector
*connector
, bool force
)
830 struct sun6i_dsi
*dsi
= connector_to_sun6i_dsi(connector
);
832 return dsi
->panel
? connector_status_connected
:
833 connector_status_disconnected
;
836 static const struct drm_connector_funcs sun6i_dsi_connector_funcs
= {
837 .detect
= sun6i_dsi_connector_detect
,
838 .fill_modes
= drm_helper_probe_single_connector_modes
,
839 .destroy
= drm_connector_cleanup
,
840 .reset
= drm_atomic_helper_connector_reset
,
841 .atomic_duplicate_state
= drm_atomic_helper_connector_duplicate_state
,
842 .atomic_destroy_state
= drm_atomic_helper_connector_destroy_state
,
845 static const struct drm_encoder_helper_funcs sun6i_dsi_enc_helper_funcs
= {
846 .disable
= sun6i_dsi_encoder_disable
,
847 .enable
= sun6i_dsi_encoder_enable
,
850 static u32
sun6i_dsi_dcs_build_pkt_hdr(struct sun6i_dsi
*dsi
,
851 const struct mipi_dsi_msg
*msg
)
855 if (msg
->type
== MIPI_DSI_DCS_LONG_WRITE
) {
856 pkt
|= ((msg
->tx_len
) & 0xffff) << 8;
857 pkt
|= (((msg
->tx_len
) >> 8) & 0xffff) << 16;
859 pkt
|= (((u8
*)msg
->tx_buf
)[0] << 8);
861 pkt
|= (((u8
*)msg
->tx_buf
)[1] << 16);
864 pkt
|= sun6i_dsi_ecc_compute(pkt
) << 24;
869 static int sun6i_dsi_dcs_write_short(struct sun6i_dsi
*dsi
,
870 const struct mipi_dsi_msg
*msg
)
872 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_TX_REG(0),
873 sun6i_dsi_dcs_build_pkt_hdr(dsi
, msg
));
874 regmap_write_bits(dsi
->regs
, SUN6I_DSI_CMD_CTL_REG
,
877 sun6i_dsi_start(dsi
, DSI_START_LPTX
);
882 static int sun6i_dsi_dcs_write_long(struct sun6i_dsi
*dsi
,
883 const struct mipi_dsi_msg
*msg
)
889 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_TX_REG(0),
890 sun6i_dsi_dcs_build_pkt_hdr(dsi
, msg
));
892 bounce
= kzalloc(ALIGN(msg
->tx_len
+ sizeof(crc
), 4), GFP_KERNEL
);
896 memcpy(bounce
, msg
->tx_buf
, msg
->tx_len
);
899 crc
= sun6i_dsi_crc_compute(bounce
, msg
->tx_len
);
900 memcpy((u8
*)bounce
+ msg
->tx_len
, &crc
, sizeof(crc
));
903 regmap_bulk_write(dsi
->regs
, SUN6I_DSI_CMD_TX_REG(1), bounce
, DIV_ROUND_UP(len
, 4));
904 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_CTL_REG
, len
+ 4 - 1);
907 sun6i_dsi_start(dsi
, DSI_START_LPTX
);
909 ret
= sun6i_dsi_inst_wait_for_completion(dsi
);
911 sun6i_dsi_inst_abort(dsi
);
916 * TODO: There's some bits (reg 0x200, bits 8/9) that
917 * apparently can be used to check whether the data have been
918 * sent, but I couldn't get it to work reliably.
923 static int sun6i_dsi_dcs_read(struct sun6i_dsi
*dsi
,
924 const struct mipi_dsi_msg
*msg
)
930 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_TX_REG(0),
931 sun6i_dsi_dcs_build_pkt_hdr(dsi
, msg
));
932 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_CTL_REG
,
935 sun6i_dsi_start(dsi
, DSI_START_LPRX
);
937 ret
= sun6i_dsi_inst_wait_for_completion(dsi
);
939 sun6i_dsi_inst_abort(dsi
);
944 * TODO: There's some bits (reg 0x200, bits 24/25) that
945 * apparently can be used to check whether the data have been
946 * received, but I couldn't get it to work reliably.
948 regmap_read(dsi
->regs
, SUN6I_DSI_CMD_CTL_REG
, &val
);
949 if (val
& SUN6I_DSI_CMD_CTL_RX_OVERFLOW
)
952 regmap_read(dsi
->regs
, SUN6I_DSI_CMD_RX_REG(0), &val
);
954 if (byte0
== MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT
)
957 ((u8
*)msg
->rx_buf
)[0] = (val
>> 8);
962 static int sun6i_dsi_attach(struct mipi_dsi_host
*host
,
963 struct mipi_dsi_device
*device
)
965 struct sun6i_dsi
*dsi
= host_to_sun6i_dsi(host
);
966 struct drm_panel
*panel
= of_drm_find_panel(device
->dev
.of_node
);
969 return PTR_ERR(panel
);
970 if (!dsi
->drm
|| !dsi
->drm
->registered
)
971 return -EPROBE_DEFER
;
974 dsi
->device
= device
;
976 drm_kms_helper_hotplug_event(dsi
->drm
);
978 dev_info(host
->dev
, "Attached device %s\n", device
->name
);
983 static int sun6i_dsi_detach(struct mipi_dsi_host
*host
,
984 struct mipi_dsi_device
*device
)
986 struct sun6i_dsi
*dsi
= host_to_sun6i_dsi(host
);
991 drm_kms_helper_hotplug_event(dsi
->drm
);
996 static ssize_t
sun6i_dsi_transfer(struct mipi_dsi_host
*host
,
997 const struct mipi_dsi_msg
*msg
)
999 struct sun6i_dsi
*dsi
= host_to_sun6i_dsi(host
);
1002 ret
= sun6i_dsi_inst_wait_for_completion(dsi
);
1004 sun6i_dsi_inst_abort(dsi
);
1006 regmap_write(dsi
->regs
, SUN6I_DSI_CMD_CTL_REG
,
1007 SUN6I_DSI_CMD_CTL_RX_OVERFLOW
|
1008 SUN6I_DSI_CMD_CTL_RX_FLAG
|
1009 SUN6I_DSI_CMD_CTL_TX_FLAG
);
1011 switch (msg
->type
) {
1012 case MIPI_DSI_DCS_SHORT_WRITE
:
1013 case MIPI_DSI_DCS_SHORT_WRITE_PARAM
:
1014 case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM
:
1015 ret
= sun6i_dsi_dcs_write_short(dsi
, msg
);
1018 case MIPI_DSI_DCS_LONG_WRITE
:
1019 ret
= sun6i_dsi_dcs_write_long(dsi
, msg
);
1022 case MIPI_DSI_DCS_READ
:
1023 if (msg
->rx_len
== 1) {
1024 ret
= sun6i_dsi_dcs_read(dsi
, msg
);
1036 static const struct mipi_dsi_host_ops sun6i_dsi_host_ops
= {
1037 .attach
= sun6i_dsi_attach
,
1038 .detach
= sun6i_dsi_detach
,
1039 .transfer
= sun6i_dsi_transfer
,
1042 static const struct regmap_config sun6i_dsi_regmap_config
= {
1046 .max_register
= SUN6I_DSI_CMD_TX_REG(255),
1050 static int sun6i_dsi_bind(struct device
*dev
, struct device
*master
,
1053 struct drm_device
*drm
= data
;
1054 struct sun6i_dsi
*dsi
= dev_get_drvdata(dev
);
1057 drm_encoder_helper_add(&dsi
->encoder
,
1058 &sun6i_dsi_enc_helper_funcs
);
1059 ret
= drm_simple_encoder_init(drm
, &dsi
->encoder
,
1060 DRM_MODE_ENCODER_DSI
);
1062 dev_err(dsi
->dev
, "Couldn't initialise the DSI encoder\n");
1065 dsi
->encoder
.possible_crtcs
= BIT(0);
1067 drm_connector_helper_add(&dsi
->connector
,
1068 &sun6i_dsi_connector_helper_funcs
);
1069 ret
= drm_connector_init(drm
, &dsi
->connector
,
1070 &sun6i_dsi_connector_funcs
,
1071 DRM_MODE_CONNECTOR_DSI
);
1074 "Couldn't initialise the DSI connector\n");
1075 goto err_cleanup_connector
;
1078 drm_connector_attach_encoder(&dsi
->connector
, &dsi
->encoder
);
1084 err_cleanup_connector
:
1085 drm_encoder_cleanup(&dsi
->encoder
);
1089 static void sun6i_dsi_unbind(struct device
*dev
, struct device
*master
,
1092 struct sun6i_dsi
*dsi
= dev_get_drvdata(dev
);
1097 static const struct component_ops sun6i_dsi_ops
= {
1098 .bind
= sun6i_dsi_bind
,
1099 .unbind
= sun6i_dsi_unbind
,
1102 static int sun6i_dsi_probe(struct platform_device
*pdev
)
1104 struct device
*dev
= &pdev
->dev
;
1105 const char *bus_clk_name
= NULL
;
1106 struct sun6i_dsi
*dsi
;
1107 struct resource
*res
;
1111 dsi
= devm_kzalloc(dev
, sizeof(*dsi
), GFP_KERNEL
);
1114 dev_set_drvdata(dev
, dsi
);
1116 dsi
->host
.ops
= &sun6i_dsi_host_ops
;
1117 dsi
->host
.dev
= dev
;
1119 if (of_device_is_compatible(dev
->of_node
,
1120 "allwinner,sun6i-a31-mipi-dsi"))
1121 bus_clk_name
= "bus";
1123 res
= platform_get_resource(pdev
, IORESOURCE_MEM
, 0);
1124 base
= devm_ioremap_resource(dev
, res
);
1126 dev_err(dev
, "Couldn't map the DSI encoder registers\n");
1127 return PTR_ERR(base
);
1130 dsi
->regulator
= devm_regulator_get(dev
, "vcc-dsi");
1131 if (IS_ERR(dsi
->regulator
)) {
1132 dev_err(dev
, "Couldn't get VCC-DSI supply\n");
1133 return PTR_ERR(dsi
->regulator
);
1136 dsi
->reset
= devm_reset_control_get_shared(dev
, NULL
);
1137 if (IS_ERR(dsi
->reset
)) {
1138 dev_err(dev
, "Couldn't get our reset line\n");
1139 return PTR_ERR(dsi
->reset
);
1142 dsi
->regs
= devm_regmap_init_mmio(dev
, base
, &sun6i_dsi_regmap_config
);
1143 if (IS_ERR(dsi
->regs
)) {
1144 dev_err(dev
, "Couldn't init regmap\n");
1145 return PTR_ERR(dsi
->regs
);
1148 dsi
->bus_clk
= devm_clk_get(dev
, bus_clk_name
);
1149 if (IS_ERR(dsi
->bus_clk
)) {
1150 dev_err(dev
, "Couldn't get the DSI bus clock\n");
1151 return PTR_ERR(dsi
->bus_clk
);
1154 ret
= regmap_mmio_attach_clk(dsi
->regs
, dsi
->bus_clk
);
1158 if (of_device_is_compatible(dev
->of_node
,
1159 "allwinner,sun6i-a31-mipi-dsi")) {
1160 dsi
->mod_clk
= devm_clk_get(dev
, "mod");
1161 if (IS_ERR(dsi
->mod_clk
)) {
1162 dev_err(dev
, "Couldn't get the DSI mod clock\n");
1163 ret
= PTR_ERR(dsi
->mod_clk
);
1164 goto err_attach_clk
;
1169 * In order to operate properly, that clock seems to be always
1172 clk_set_rate_exclusive(dsi
->mod_clk
, 297000000);
1174 dsi
->dphy
= devm_phy_get(dev
, "dphy");
1175 if (IS_ERR(dsi
->dphy
)) {
1176 dev_err(dev
, "Couldn't get the MIPI D-PHY\n");
1177 ret
= PTR_ERR(dsi
->dphy
);
1178 goto err_unprotect_clk
;
1181 ret
= mipi_dsi_host_register(&dsi
->host
);
1183 dev_err(dev
, "Couldn't register MIPI-DSI host\n");
1184 goto err_unprotect_clk
;
1187 ret
= component_add(&pdev
->dev
, &sun6i_dsi_ops
);
1189 dev_err(dev
, "Couldn't register our component\n");
1190 goto err_remove_dsi_host
;
1195 err_remove_dsi_host
:
1196 mipi_dsi_host_unregister(&dsi
->host
);
1198 clk_rate_exclusive_put(dsi
->mod_clk
);
1200 if (!IS_ERR(dsi
->bus_clk
))
1201 regmap_mmio_detach_clk(dsi
->regs
);
1205 static int sun6i_dsi_remove(struct platform_device
*pdev
)
1207 struct device
*dev
= &pdev
->dev
;
1208 struct sun6i_dsi
*dsi
= dev_get_drvdata(dev
);
1210 component_del(&pdev
->dev
, &sun6i_dsi_ops
);
1211 mipi_dsi_host_unregister(&dsi
->host
);
1212 clk_rate_exclusive_put(dsi
->mod_clk
);
1214 if (!IS_ERR(dsi
->bus_clk
))
1215 regmap_mmio_detach_clk(dsi
->regs
);
1220 static const struct of_device_id sun6i_dsi_of_table
[] = {
1221 { .compatible
= "allwinner,sun6i-a31-mipi-dsi" },
1222 { .compatible
= "allwinner,sun50i-a64-mipi-dsi" },
1225 MODULE_DEVICE_TABLE(of
, sun6i_dsi_of_table
);
1227 static struct platform_driver sun6i_dsi_platform_driver
= {
1228 .probe
= sun6i_dsi_probe
,
1229 .remove
= sun6i_dsi_remove
,
1231 .name
= "sun6i-mipi-dsi",
1232 .of_match_table
= sun6i_dsi_of_table
,
1235 module_platform_driver(sun6i_dsi_platform_driver
);
1237 MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>");
1238 MODULE_DESCRIPTION("Allwinner A31 DSI Driver");
1239 MODULE_LICENSE("GPL");