| blob | baa3c7be04ad8897761f92abd2b5d428d24f8471 |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
68 Options:
73 --emacs emacs compile window format
74 --terse one line per report
77 single git commit with:
81 multiple git commits with:
85 git merges are ignored
100 is all off)
102 literally
105 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
106 with potential errors corrected to the preferred
107 checkpatch style
112 runtime errors.
115 --codespellfile Use this codespell dictionary
120 EOM
123 }
128 }
146 }
151 }
154 }
176 }
177 }
180 }
182 GetOptions(
229 }
230 }
232 #if no filenames are given, push '-' to read patch from stdin
235 }
251 }
252 }
261 }
263 }
264 }
274 ## no critic
277 }
284 }
290 }
297 }
298 }
303 }
304 }
314 __user|
315 __kernel|
316 __force|
317 __iomem|
318 __must_check|
319 __init_refok|
320 __kprobes|
321 __ref|
322 __rcu|
323 __private
331 # Notes to $Attribute:
332 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
334 const|
335 __percpu|
336 __nocast|
337 __safe|
338 __bitwise|
339 __packed__|
340 __packed2__|
341 __naked|
342 __maybe_unused|
343 __always_unused|
344 __noreturn|
345 __used|
346 __cold|
347 __pure|
348 __noclone|
349 __deprecated|
350 __read_mostly|
351 __kprobes|
353 ____cacheline_aligned|
354 ____cacheline_aligned_in_smp|
355 ____cacheline_internodealigned_in_smp|
356 __weak
378 <=|>=|==|!=|
379 =>|->|<<|>>|<|>|!|~|
413 )};
416 atomic_t
417 )};
422 )};
428 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
430 panic|
433 )};
442 To:|
443 Cc:
444 )};
463 );
486 );
507 )};
514 );
518 );
525 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
532 );
534 #Create a search pattern for all these functions to speed up a loop below
539 }
542 S_IWUGO |
543 S_IWOTH |
544 S_IRWXUGO |
545 S_IALLUGO |
566 );
568 #Create a search pattern for all these strings to speed up a loop below
573 }
576 irq|
577 memory|
579 reboot
580 )};
581 # memory.h: ARM has a custom one
583 # Load common spelling mistakes and build regular expression list.
600 }
604 }
623 }
627 }
628 }
645 }
649 }
653 }
671 )
678 )
687 )
691 $NonptrType
696 $NonptrTypeMisordered
702 }
703 build_types();
707 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
708 # requires at least perl version v5.10.0
709 # Any use must be runtime checked with $^V
719 )};
728 }
733 }
757 }
758 }
759 }
766 my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
769 }
793 }
795 }
803 }
807 }
812 }
816 }
824 }
826 }
827 }
841 # Maybe one day convert this block of bash into something that returns
842 # all matching commit ids, but it's very slow...
843 #
844 # echo "checking commits $1..."
845 # git rev-list --remotes | grep -i "^$1" |
846 # while read line ; do
847 # git log --format='%H %s' -1 $line |
848 # echo "commit $(cut -c 1-12,41-)"
849 # done
850 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
854 }
857 }
868 # If input is git commits, extract all commits from the commit expressions.
869 # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
882 }
891 }
892 }
895 }
911 }
918 }
922 }
929 }
933 }
942 build_types();
943 }
954 EOM
955 }
961 EOM
962 }
963 }
974 );
979 }
980 }
982 }
1005 # If there's a name left after stripping spaces and
1006 # leading quotes, and the address doesn't have both
1007 # leading and trailing angle brackets, the address
1008 # is invalid. ie:
1009 # "joe smith joe@smith.com" bad
1010 # "joe smith <joe@smith.com" bad
1015 }
1016 }
1026 }
1029 }
1043 }
1049 }
1052 }
1060 }
1061 }
1064 }
1072 }
1073 }
1076 }
1089 }
1091 }
1094 }
1097 }
1101 }
1106 # Drop the diff line leader and expand tabs
1110 # Pick the indent from the front of the line.
1114 }
1125 }
1126 }
1137 # Always copy over the diff marker.
1143 # Comments we are wacking completly including the begin
1144 # and end, all to $;.
1151 }
1157 }
1164 }
1166 # A \ in a string means ignore the next character.
1172 }
1173 # Regular quotes.
1182 }
1183 }
1185 #print "c<$c> SQ<$sanitise_quote>\n";
1194 }
1195 }
1199 }
1201 # The pathname on a #include may be surrounded by '<' and '>'.
1206 # The whole of a #error is a string.
1210 }
1215 }
1218 }
1225 }
1248 #warn "CSB: blk<$blk> remain<$remain>\n";
1249 # If we are about to drop off the end, pull in more
1250 # context.
1261 }
1262 # Bail if there is no further context.
1263 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
1266 }
1270 }
1271 }
1276 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1278 # Handle nested #if/#else.
1285 }
1287 # Statement ends at the ';' or a close '}' at the
1288 # outermost level.
1291 }
1293 # An else is really a conditional as long as its not else if
1300 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1301 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1302 }
1307 }
1315 #warn "CSB: mark coff<$coff>\n";
1316 }
1317 }
1321 }
1329 }
1331 }
1332 }
1333 # Preprocessor commands end at the newline unless escaped.
1339 }
1341 }
1342 # We are truly at the end, so shuffle to the next line.
1347 }
1352 #warn "STATEMENT<$statement>\n";
1353 #warn "CONDITION<$condition>\n";
1355 #print "coff<$coff> soff<$off> loff<$loff>\n";
1359 }
1364 # Strip the diff line prefixes and rip blank lines at start and end.
1372 }
1380 }
1401 }
1402 }
1410 # Grab the first conditional/block pair.
1413 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1417 }
1419 # Pull in the following conditional/block pairs and see if they
1420 # could continue the statement.
1424 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1426 #print "C: push\n";
1428 }
1431 }
1450 # Handle nested #if/#else.
1457 }
1460 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1464 }
1471 }
1472 }
1476 }
1479 }
1482 }
1488 }
1494 }
1500 }
1505 }
1510 }
1515 # Catch a comment on the end of the line itself.
1519 # Look through the context and try and figure out if there is a
1520 # comment.
1525 #warn " $line\n";
1528 }
1531 }
1534 }
1538 }
1539 }
1543 }
1548 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1549 ##print "CMMT: $cmt\n";
1552 }
1565 }
1568 }
1580 }
1581 }
1585 }
1597 }
1617 }
1638 }
1667 # Assume all arms of the conditional end as this
1668 # one does, and continue as if the #endif was not here.
1685 }
1716 }
1728 }
1761 }
1776 }
1785 }
1789 }
1793 }
1794 }
1797 }
1806 DEFINE_\S+
1807 )$|
1811 case|
1815 \#|
1816 \#\#|
1822 # Check for modifiers.
1833 }
1834 }
1839 }
1840 build_types();
1843 }
1844 }
1856 }
1864 }
1873 }
1874 }
1879 }
1887 }
1893 }
1897 }
1908 }
1909 }
1936 }
1942 }
1949 }
1954 }
1957 }
1960 }
1968 };
1970 }
1978 };
1981 }
1990 }
1992 }
2000 }
2002 }
2010 }
2012 }
2018 ##print "absolute<$absolute>\n";
2020 # See if any suffix of this path is a path within the tree.
2023 ##print "file<$file>\n";
2025 }
2026 }
2029 }
2031 # It is, so see if the prefix is acceptable.
2035 ##print "prefix<$prefix>\n";
2039 }
2040 }
2048 }
2056 }
2064 }
2072 }
2081 #convert leading spaces to tabs
2083 #Remove spaces before a tab
2087 }
2101 }
2113 }
2114 }
2117 }
2154 # Trace the real file/line as we go.
2167 # suppression flags
2175 # Pre-scan the patch sanitizing the lines.
2176 # Pre-scan the patch looking for any __setup documentation.
2177 #
2183 sanitise_line_reset();
2195 }
2196 #next;
2197 }
2205 }
2212 }
2214 # Guestimate if this is a continuing comment. Run
2215 # the context looking for a comment "edge". If this
2216 # edge is a close comment then we must be in a comment
2217 # at context start.
2224 #print "RAW<$rawlines[$ln - 1]>\n";
2230 }
2231 }
2234 }
2236 # Guestimate if this is a continuing comment. If this
2237 # is the start of a diff block and this line starts
2238 # ' *' then it is very likely a comment.
2241 {
2243 }
2245 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
2249 # Standardise the strings and chars within the input to
2250 # simplify matching -- only bother with positive lines.
2252 }
2259 }
2261 #print "==>$rawline\n";
2262 #print "-->$line\n";
2266 }
2267 }
2282 #extract the line range in the file after the patch is applied
2292 }
2293 annotate_reset();
2302 # track the line number as we move through the hunk, note that
2303 # new versions of GNU diff omit the leading space on completely
2304 # blank context lines so we need to count that too.
2309 # Measure the line length and indent.
2312 # Track the previous line.
2317 #warn "line<$line>\n";
2321 }
2329 # extract the filename as it passes
2345 }
2349 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2350 }
2352 }
2354 #make up the handle for any error we report on this line
2362 }
2363 }
2368 "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n");
2369 }
2374 }
2376 }
2386 # Check if the commit log has what seems like a diff which can confuse patch
2395 }
2397 # Check for incorrect file permissions
2404 }
2405 }
2407 # Check the patch for a signoff:
2411 }
2413 # Check if MAINTAINERS is being updated. If so, there's probably no need to
2414 # emit the "does MAINTAINERS need updating?" message on file add/move/delete
2417 }
2419 # Check signature styles
2431 }
2438 }
2439 }
2446 }
2448 }
2455 }
2456 }
2467 # Don't force email to have quotes
2468 # Allow just an angle bracketed address
2474 }
2475 }
2477 # Check for duplicate signatures
2486 }
2487 }
2489 # Check email subject for common tools that don't need to be mentioned
2494 }
2496 # Check for old stable address
2500 }
2502 # Check for unwanted Gerrit info
2506 }
2508 # Check if the commit log is in a possible stack dump
2512 # timestamp
2514 # stack dump address
2516 }
2518 # Check for line lengths > 75 in commit log, warn once
2522 # file delta changes
2524 # filename then :
2526 # A Fixes: or Link: line
2531 }
2533 # Reset possible stack dump if a blank line is found
2537 }
2539 # Check for git id commit length and improperly formed commit descriptions
2563 }
2585 }
2592 "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herecurr);
2593 }
2594 }
2596 # Check for added, moved or deleted files
2606 }
2608 # Check for wrappage within a valid hunk of the file
2613 }
2615 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2626 }
2628 # Check if it's the start of a commit log
2629 # (not a header line and we haven't seen the patch filename)
2636 }
2638 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2639 # declined it, i.e defined some charset where it is missing.
2644 }
2650 }
2652 # Check for absolute kernel paths in commit message
2659 #
2662 }
2663 }
2664 }
2666 # Check for various typo / spelling mistakes
2680 }
2681 }
2682 }
2684 # ignore non-hunk lines and lines being removed
2687 #trailing whitespace
2694 }
2701 }
2704 }
2706 # Check for FSF mailing addresses.
2715 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2716 }
2718 # check for Kconfig help text having a real description
2719 # Only applies when adding the entry originally, after that we do not have
2720 # sufficient context to determine whether it is indeed long enough.
2741 }
2750 }
2752 }
2756 }
2757 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2758 }
2760 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2764 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2765 }
2767 # discourage the use of boolean for type definition attributes of Kconfig options
2772 }
2782 };
2785 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2786 }
2788 # check for DT compatible documentation
2807 }
2814 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2815 }
2816 }
2817 }
2819 # check we are in a valid source file if not then ignore this hunk
2822 # line length limit (with some exclusions)
2823 #
2824 # There are a few types of lines that may extend beyond $max_line_length:
2825 # logging functions like pr_info that end in a string
2826 # lines with a single string
2827 # #defines that are a single string
2828 #
2829 # There are 3 different line length message types:
2830 # LONG_LINE_COMMENT a comment starts before but extends beyond $max_linelength
2831 # LONG_LINE_STRING a string starts before but extends beyond $max_line_length
2832 # LONG_LINE all other lines longer than $max_line_length
2833 #
2834 # if LONG_LINE is ignored, the other 2 types are also ignored
2835 #
2840 # Check the allowed long line types first
2842 # logging functions that end in a string that starts
2843 # before $max_line_length
2844 if ($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(?:KERN_\S+\s*|[^"]*))?($String\s*(?:|,|\)\s*;)\s*)$/ &&
2848 # lines with only strings (w/ possible termination)
2849 # #defines with only strings
2854 # EFI_GUID is another special case
2858 # Otherwise set the alternate message types
2860 # a comment starts before $max_line_length
2865 # a quoted string starts before $max_line_length
2869 }
2875 }
2876 }
2878 # check for adding lines without a newline.
2879 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2882 }
2884 # Blackfin: use hi/lo macros
2890 }
2895 }
2896 }
2898 # check we are in a valid source file C or perl if not then ignore this hunk
2901 # at the beginning of a line any tabs must come first and anything
2902 # more than 8 must use tabs.
2911 }
2912 }
2914 # check for space before tabs.
2924 }
2925 }
2927 # check for && or || at the start of a line
2931 }
2933 # check indentation starts on a tab stop
2942 }
2943 }
2944 }
2946 # check multi-line statement indentation matches previous line
2948 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2971 }
2972 }
2973 }
2974 }
2976 # check for space after cast like "(int) foo" or "(struct foo) bar"
2977 # avoid checking a few false positives:
2978 # "sizeof(<type>)" or "__alignof__(<type>)"
2979 # function pointer declarations like "(*foo)(int) = bar;"
2980 # structure definitions like "(struct foo) { 0 };"
2981 # multiline macros that define functions
2982 # known attributes or the __attribute__ keyword
2990 }
2991 }
2993 # Block comment styles
2994 # Networking with an initial /*
3001 }
3003 # Block comments use * on subsequent lines
3011 }
3013 # Block comments use */ on trailing lines
3020 }
3022 # Block comment * alignment
3036 }
3043 }
3044 }
3046 # check for missing blank lines after struct/union declarations
3047 # with exceptions for various attributes and macros
3062 }
3063 }
3065 # check for multiple consecutive blank lines
3073 }
3076 }
3078 # check for missing blank lines after declarations
3080 # actual declarations
3082 # function pointer declarations
3084 # foo bar; where foo is some local typedef or #define
3086 # known declaration macros
3088 # for "else if" which can look like "$Ident $Ident"
3090 # other possible extensions of declaration lines
3092 # not starting a section or a macro "\" extended line
3094 # looks like a declaration
3096 # function pointer declarations
3098 # foo bar; where foo is some local typedef or #define
3100 # known declaration macros
3102 # start of struct or union or enum
3104 # start or end of block or continuation of declaration
3106 # bitfield continuation
3108 # other possible extensions of declaration lines
3110 # indentation of previous and current line are the same
3116 }
3117 }
3119 # check for spaces at the beginning of a line.
3120 # Exceptions:
3121 # 1) within comments
3122 # 2) indented preprocessor commands
3123 # 3) hanging labels
3130 }
3131 }
3133 # check we are in a valid C source file if not then ignore this hunk
3136 # check indentation of any line with a bare else
3137 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
3138 # if the previous line is a break or return and is indented 1 tab more...
3147 }
3148 }
3150 # check indentation of a line with a break;
3151 # if the previous line is a goto or return and is indented the same # of tabs
3157 }
3158 }
3160 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
3163 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
3164 }
3166 # check for RCS/CVS revision markers
3170 }
3172 # Blackfin: don't use __builtin_bfin_[cs]sync
3177 }
3182 }
3184 # check for old HOTPLUG __dev<foo> section markings
3188 }
3190 # Check for potential 'bare' types
3193 #print "LINE<$line>\n";
3201 #print "linenr<$linenr> <$stat>\n";
3202 # If this statement has no statement boundaries within
3203 # it there is no point in retrying a statement scan
3204 # until we hit end of it.
3207 #print "skip<$line_nr_next>\n";
3209 }
3211 # Find the real next line.
3217 }
3222 # Ignore goto labels.
3225 # Ignore functions being called
3230 # declarations always start with types
3231 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
3236 # definitions in global scope can only start with types
3239 }
3241 # any (foo ... *) is a pointer cast, and foo is a type
3244 }
3246 # Check for any sort of function declaration.
3247 # int foo(something bar, other baz);
3248 # void (*store_gdt)(x86_descr_ptr *);
3249 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
3257 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
3260 }
3261 }
3262 }
3264 }
3266 #
3267 # Checks which may be anchored in the context.
3268 #
3270 # Check for switch () and associated case and default
3271 # statements should be at the same indent.
3285 }
3286 }
3290 }
3291 }
3293 # if/while/etc brace do not go on next line, unless defining a do while loop,
3294 # or if that brace on the next line is for something else
3295 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
3303 }
3314 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
3317 }
3319 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
3320 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
3326 }
3330 {
3336 }
3337 }
3338 }
3340 # Check relative indent for conditionals and blocks.
3341 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
3349 # remove inline comments
3353 # Find out how long the conditional actually is.
3357 # Make sure we remove the line prefixes as we have
3358 # none on the first line, and are going to readd them
3359 # where necessary.
3363 }
3365 # We want to check the first line inside the block
3366 # starting at the end of the conditional, so remove:
3367 # 1) any blank line termination
3368 # 2) any opening brace { on end of the line
3369 # 3) any do (...) {
3376 }
3380 }
3382 # Also ignore a loop construct at the end of a
3383 # preprocessor statement.
3387 }
3394 # If we see an #else/#elif then the code
3395 # is not linear.
3398 }
3400 # Ignore:
3401 # 1) blank lines, they should be at 0,
3402 # 2) preprocessor lines, and
3403 # 3) labels.
3411 }
3412 }
3413 }
3418 # Check if either of these lines are modified, else
3419 # this is not this patch's fault.
3423 }
3426 }
3428 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
3435 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
3436 }
3437 }
3439 # Track the 'values' across context and added lines.
3449 }
3452 #ignore lines not being added
3455 # check for dereferences that span multiple lines
3465 }
3467 # check for declarations of signed or unsigned without int
3468 while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
3479 "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
3487 }
3488 }
3489 }
3491 # TEST: allow direct testing of the type matcher.
3499 }
3501 }
3502 # TEST: allow direct testing of the attribute matcher.
3510 }
3512 }
3514 # check for initialisation to aggregates open brace on the next line
3528 }
3529 }
3531 #
3532 # Checks which are anchored on the added line.
3533 #
3535 # check for malformed paths in #include statements (uses RAW line)
3541 }
3545 }
3546 }
3548 # no C99 // comments
3557 }
3558 }
3559 }
3560 # Remove C99 comments.
3564 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
3565 # the whole statement.
3566 #print "APW <$lines[$realline_next - 1]>\n";
3572 # Handle definitions which produce identifiers with
3573 # a prefix:
3574 # XXX(foo);
3575 # EXPORT_SYMBOL(something_foo);
3579 #print "FOO C name<$name>\n";
3590 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
3594 }
3595 }
3600 #print "FOO B <$lines[$linenr - 1]>\n";
3602 }
3607 }
3609 # check for global initialisers.
3615 }
3616 }
3617 # check for static initialisers.
3624 }
3625 }
3627 # check for misordered declarations of char/short/int/long with signed/unsigned
3631 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
3632 }
3634 # check for static const char * arrays.
3639 }
3641 # check for static char foo[] = "bar" declarations.
3646 }
3648 # check for const <foo> const where <foo> is not a pointer or array type
3657 }
3658 }
3660 # check for non-global char *foo[] = {"bar", ...} declarations.
3665 }
3667 # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
3670 if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {
3676 }
3677 }
3678 }
3680 # check for function declarations without arguments like "int foo()"
3686 }
3687 }
3689 # check for new typedefs, only function parameters and sparse annotations
3690 # make sense.
3698 }
3700 # * goes on variable not on type
3701 # (char*[ const])
3703 #print "AA<$1>\n";
3706 # Should start with a space.
3708 # Should not end with a space.
3710 # '*'s should not have spaces between.
3712 }
3714 ## print "1: from<$from> to<$to> ident<$ident>\n";
3724 }
3725 }
3726 }
3728 #print "BB<$1>\n";
3731 # Should start with a space.
3733 # Should not end with a space.
3735 # '*'s should not have spaces between.
3737 }
3738 # Modifiers should have spaces.
3741 ## print "2: from<$from> to<$to> ident<$ident>\n";
3752 }
3753 }
3754 }
3756 # avoid BUG() or BUG_ON()
3761 "Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . $herecurr);
3762 }
3764 # avoid LINUX_VERSION_CODE
3767 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
3768 }
3770 # check for uses of printk_ratelimit
3774 }
3776 # printk should use KERN_* levels. Note that follow on printk's on the
3777 # same line do not need a level, so we use the current block context
3778 # to try and find and validate the current printk. In summary the current
3779 # printk includes all preceding printk's which have no newline on the end.
3780 # we assume the first bad printk is the one to report.
3784 #print "CHECK<$lines[$ln - 1]\n";
3785 # we have a preceding printk if it ends
3786 # with "\n" ignore it, else it is to blame
3790 }
3792 }
3793 }
3797 }
3798 }
3807 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
3808 }
3816 }
3817 }
3826 }
3828 # ENOSYS means "bad syscall nr" and nothing else. This will have a small
3829 # number of false positives, but assembly files are not checked, so at
3830 # least the arch entry code will not trigger this warning.
3834 }
3836 # function brace can't be on same line, except for #defines of do while,
3837 # or if closed on same line
3852 }
3853 }
3854 }
3856 # open braces for enum, union and struct go on the same line.
3870 }
3871 }
3872 }
3874 # missing space after union, struct or enum definition
3881 }
3882 }
3884 # Function pointer declarations
3885 # check spacing between type, funcptr, and args
3886 # canonical declaration is "type (*funcptr)(args...)"
3895 # the $Declare variable will capture all spaces after the type
3896 # so check it for a missing trailing missing space but pointer return types
3897 # don't need a space so don't warn for those.
3902 }
3907 }
3909 # unnecessary space "type (*funcptr)(args...)"
3910 # This test is not currently implemented because these declarations are
3911 # equivalent to
3912 # int foo(int bar, ...)
3913 # and this is form shouldn't/doesn't generate a checkpatch warning.
3914 #
3915 # elsif ($declare =~ /\s{2,}$/) {
3916 # WARN("SPACING",
3917 # "Multiple spaces after return type\n" . $herecurr);
3918 # }
3920 # unnecessary space "type ( *funcptr)(args...)"
3925 }
3927 # unnecessary space "type (* funcptr)(args...)"
3932 }
3934 # unnecessary space "type (*funcptr )(args...)"
3939 }
3941 # unnecessary space "type (*funcptr) (args...)"
3946 }
3950 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3951 }
3952 }
3954 # check for spacing round square brackets; allowed:
3955 # 1. with a type on the left -- int [] a;
3956 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3957 # 3. inside a curly brace -- = { [0...10] = 5 }
3968 }
3969 }
3970 }
3972 # check for spaces between functions and their parentheses.
3978 # Ignore those directives where spaces _are_ permitted.
3984 {
3985 # cpp #define statements have non-optional spaces, ie
3986 # if there is a space between the name and the open
3987 # parenthesis it is simply not a parameter group.
3990 # cpp #elif statement condition may start with a (
3993 # If this whole things ends with a type its most
3994 # likely a typedef for a function.
4003 }
4004 }
4005 }
4007 # Check operator spacing.
4013 <<=|>>=|<=|>=|==|!=|
4015 =>|->|<<|>>|<|>|=|!|~|
4021 ## print("element count: <" . $#elements . ">\n");
4022 ## foreach my $el (@elements) {
4023 ## print("el: <$el>\n");
4024 ## }
4032 }
4043 ## print("n: <$n> good: <$good>\n");
4047 # Pick up the preceding and succeeding characters.
4052 }
4075 }
4084 # Pull out the value of this operator.
4087 # Get the full operator variant.
4090 # Ignore operators passed as parameters.
4094 # # Ignore comments
4095 # } elsif ($op =~ /^$;+$/) {
4097 # ; should have either the end of line or a space or \ after it
4105 }
4106 }
4108 # // is a comment
4111 # : when part of a bitfield
4113 # skip the bitfield test for now
4115 # No spaces for:
4116 # ->
4124 }
4126 }
4127 }
4129 # , must not have a space before and must have a space on the right.
4138 }
4139 }
4146 }
4147 }
4153 }
4156 }
4157 }
4159 # '*' as part of a type definition -- reported already.
4161 #warn "'*' is part of type\n";
4163 # unary operators should have a space before and
4164 # none after. May be left adjacent to another
4165 # unary operator, or a cast
4175 }
4176 }
4177 }
4179 # A unary '*' may be const
4187 }
4189 }
4190 }
4192 # unary ++ and unary -- are allowed no space on one side.
4199 }
4200 }
4207 }
4208 }
4215 }
4217 }
4218 }
4220 # << and >> may either have or not have spaces both sides
4226 {
4234 }
4240 }
4241 }
4248 }
4250 }
4251 }
4253 # A colon needs no spaces before when it is
4254 # terminating a case value or a label.
4261 }
4262 }
4264 # All the others need spaces both sides.
4268 # Ignore email addresses <foo@bar>
4273 {
4275 }
4277 # for asm volatile statements
4278 # ignore a colon with another
4279 # colon immediately before or after
4283 }
4285 # messages are ERROR, but ?: are CHK
4295 }
4297 }
4298 }
4299 }
4302 ## print("n: <$n> GOOD: <$good>\n");
4305 }
4309 }
4313 }
4316 }
4318 # check for whitespace before a non-naked semicolon
4325 }
4326 }
4328 # check for multiple assignments
4332 }
4334 ## # check for multiple declarations, allowing for a function declaration
4335 ## # continuation.
4336 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
4337 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
4338 ##
4339 ## # Remove any bracketed sections to ensure we do not
4340 ## # falsly report the parameters of functions.
4341 ## my $ln = $line;
4342 ## while ($ln =~ s/\([^\(\)]*\)//g) {
4343 ## }
4344 ## if ($ln =~ /,/) {
4345 ## WARN("MULTIPLE_DECLARATION",
4346 ## "declaring multiple variables together should be avoided\n" . $herecurr);
4347 ## }
4348 ## }
4350 #need space before brace following if, while, etc
4357 }
4358 }
4360 ## # check for blank lines before declarations
4361 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
4362 ## $prevrawline =~ /^.\s*$/) {
4363 ## WARN("SPACING",
4364 ## "No blank lines before declarations\n" . $hereprev);
4365 ## }
4366 ##
4368 # closing brace should have a space following it when it has anything
4369 # on the line
4376 }
4377 }
4379 # check spacing on square brackets
4386 }
4387 }
4394 }
4395 }
4397 # check spacing on parentheses
4405 }
4406 }
4415 }
4416 }
4418 # check unnecessary parentheses around addressof/dereference single $Lvals
4419 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
4427 }
4428 }
4430 # check for unnecessary parentheses around function pointer uses
4431 # ie: (foo->bar)(); should be foo->bar();
4432 # but not "if (foo->bar) (" to avoid some false positives
4441 }
4442 }
4444 #goto labels aren't indented, allow a single space however
4452 }
4453 }
4455 # return is not a function
4465 }
4469 }
4470 }
4472 # unnecessary return in a void function
4473 # at end-of-function, with the previous line a single leading tab, then return;
4474 # and the line before that not a goto label target like "out:"
4482 }
4484 # if statements using unnecessary parentheses - ie: if ((foo == bar))
4490 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
4495 }
4496 }
4498 # comparisons with a constant or upper case identifier on the left
4499 # avoid cases like "foo + BAR < baz"
4500 # only fix matches surrounded by parentheses to avoid incorrect
4501 # conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
4522 }
4524 }
4525 }
4527 # Return of what appears to be an errno should normally be negative
4533 }
4534 }
4536 # Need a space before open parenthesis after if, while etc
4543 }
4544 }
4546 # Check for illegal assignment in if conditional -- and check for trailing
4547 # statements after the conditional.
4555 ##print "stat<$stat> stat_next<$stat_next>\n";
4558 # If the statement carries leading newlines,
4559 # then count those as offsets.
4567 }
4568 }
4577 }
4579 # Find out what is on the end of the line after the
4580 # conditional.
4586 {
4587 # Find out how long the conditional actually is.
4596 }
4600 }
4601 }
4603 # Check for bitwise tests written as boolean
4609 |
4614 {
4617 }
4619 # if and else should not have general statements after it
4626 }
4627 }
4628 # if should not continue a brace
4633 }
4634 # case and default should not have general statements after them
4640 {
4643 }
4645 # Check for }<nl>else {, these must be at the same
4646 # indent level to be relevant to each other.
4658 }
4662 }
4663 }
4669 # Find out what is on the end of the line after the
4670 # conditional.
4686 }
4687 }
4688 }
4690 #Specific variable tests
4694 #gcc binary extension
4702 }
4703 }
4705 #CamelCase
4708 #Ignore Page<foo> variants
4710 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
4712 #Ignore some three character SI units explicitly, like MiB and KHz
4718 seed_camelcase_includes();
4722 }
4723 }
4728 }
4729 }
4730 }
4731 }
4733 #no spaces allowed after \ in define
4739 }
4740 }
4742 # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
4743 # itself <asm/foo.h> (uses RAW line)
4750 {
4759 }
4760 }
4761 }
4762 }
4764 # multi-statement macros should be enclosed in a do while loop, grab the
4765 # first statement and ensure its the whole macro if its not enclosed
4766 # in a known good container
4778 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
4779 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
4793 }
4800 # Flatten any parentheses and braces
4804 {
4805 }
4807 # Flatten any obvious string concatentation.
4810 {
4811 }
4813 # Make asm volatile uses seem like a generic function
4818 module_param_named|
4819 MODULE_PARM_DESC|
4820 DECLARE_PER_CPU|
4821 DEFINE_PER_CPU|
4822 __typeof__\(|
4823 union|
4824 struct|
4829 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
4837 }
4842 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
4847 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
4853 {
4861 }
4863 }
4865 # Make $define_stmt single line, comment-free, etc
4876 }
4877 }
4882 # check if any macro arguments are reused (ignore '...' and 'type')
4887 $tmp =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;
4894 }
4895 # check if any macro arguments may have other precedence issues
4901 }
4902 }
4904 # check for macros with flow control, but without ## concatenation
4905 # ## concatenation is commonly a macro that defines a function so ignore those
4912 }
4915 }
4917 # check for line continuations outside of #defines, preprocessor #, and asm
4926 }
4927 }
4929 # do {} while (0) macro tests:
4930 # single-statement macros do not need to be enclosed in do while (0) loop,
4931 # macro should not end with a semicolon
4946 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
4956 }
4962 }
4966 }
4974 }
4978 }
4979 }
4981 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
4982 # all assignments may have only one of the following with an assignment:
4983 # .
4984 # ALIGN(...)
4985 # VMLINUX_SYMBOL(...)
4989 }
4991 # check for redundant bracing round if etc
4995 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
4996 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
5006 # If the condition carries leading newlines, then count those as offsets.
5011 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
5013 # We have looked at and allowed this specific line.
5023 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
5025 #print "APW: ALLOWED: cond<$cond>\n";
5027 }
5029 #print "APW: ALLOWED: block<$block>\n";
5031 }
5033 #print "APW: ALLOWED: lines block<$block>\n";
5035 }
5037 }
5042 }
5050 }
5051 }
5052 }
5053 }
5058 # Check the pre-context.
5060 #print "APW: ALLOWED: pre<$1>\n";
5062 }
5067 # Check the condition.
5069 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
5072 }
5074 #print "APW: ALLOWED: cond<$cond>\n";
5076 }
5078 #print "APW: ALLOWED: block<$block>\n";
5080 }
5082 #print "APW: ALLOWED: lines block<$block>\n";
5084 }
5085 # Check the post-context.
5090 }
5092 #print "APW: ALLOWED: chunk-1 block<$block>\n";
5094 }
5095 }
5102 }
5106 }
5107 }
5109 # check for single line unbalanced braces
5113 }
5115 # check for unnecessary blank lines around braces
5121 }
5122 }
5128 }
5129 }
5131 # no volatiles please
5135 "Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . $herecurr);
5136 }
5138 # Check for user-visible strings broken across lines, which breaks the ability
5139 # to grep for the string. Make exceptions when the previous string ends in a
5140 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
5141 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
5154 }
5166 }
5168 }
5169 }
5171 # check for missing a space in a string concatenation
5175 }
5177 #check for an embedded function name in a string when the function is known
5178 # as part of a diff. This does not work for -f --file checking as it
5179 #depends on patch context providing the function name
5185 }
5187 # check for spaces before a quoted newline
5193 }
5195 }
5197 # concatenated string without spaces between elements
5201 }
5203 # uncoalesced string fragments
5207 }
5209 # check for non-standard and hex prefixed decimal printf formats
5215 # check for %L
5220 }
5221 # check for %Z
5226 }
5227 # check for 0x<decimal>
5231 }
5232 }
5234 # check for line continuations in quoted strings with odd counts of "
5238 }
5240 # warn about #if 0
5245 }
5247 # check for needless "if (<foo>) fn(<foo>)" uses
5251 if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?|(?:kmem_cache|mempool|dma_pool)_destroy)$expr/) {
5263 }
5268 }
5271 }
5275 }
5276 }
5277 }
5278 }
5280 # check for unnecessary "Out of Memory" messages
5289 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
5291 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
5294 }
5295 }
5297 # check for logging functions with KERN_<LEVEL>
5305 }
5306 }
5308 # check for logging continuations
5312 }
5314 # check for mask then right shift without a parentheses
5320 }
5322 # check for pointer comparisons to NULL
5332 }
5333 }
5334 }
5336 # check for bad placement of section $InitAttribute (e.g.: __initdata)
5339 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
5349 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
5350 }
5351 }
5352 }
5354 # check for $InitAttributeData (ie: __initdata) with const
5365 }
5366 }
5368 # check for $InitAttributeConst (ie: __initconst) without const
5380 }
5381 }
5383 # check for __read_mostly with const non-pointer (should just be const)
5390 }
5391 }
5393 # don't use __constant_<foo> functions outside of include/uapi/
5395 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
5403 }
5404 }
5406 # prefer usleep_range over udelay
5409 # ignore udelay's < 10, however
5412 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
5413 }
5417 }
5418 }
5420 # warn about unexpectedly long msleep's
5424 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
5425 }
5426 }
5428 # check for comparisons of jiffies
5431 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
5432 }
5434 # check for comparisons of get_jiffies_64()
5437 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
5438 }
5440 # warn about #ifdefs in C files
5441 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
5442 # print "#ifdef in C files should be avoided\n";
5443 # print "$herecurr";
5444 # $clean = 0;
5445 # }
5447 # warn about spacing in #ifdefs
5454 }
5456 }
5458 # check for spinlock_t definitions without a comment.
5465 }
5466 }
5467 # check for memory barriers without a comment.
5470 mb|
5471 rmb|
5472 wmb|
5473 read_barrier_depends
5476 mb__before_atomic|
5477 mb__after_atomic|
5478 store_release|
5479 load_acquire|
5480 store_mb|
5493 }
5494 }
5504 }
5506 # check for waitqueue_active without a comment.
5511 }
5512 }
5514 # Check for expedited grace periods that interrupt non-idle non-nohz
5515 # online CPUs. These expedited can therefore degrade real-time response
5516 # if used carelessly, and should be avoided where not absolutely
5517 # needed. It is always OK to use synchronize_rcu_expedited() and
5518 # synchronize_sched_expedited() at boot time (before real-time applications
5519 # start) and in error situations where real-time response is compromised in
5520 # any case. Note that synchronize_srcu_expedited() does -not- interrupt
5521 # other CPUs, so don't warn on uses of synchronize_srcu_expedited().
5522 # Of course, nothing comes for free, and srcu_read_lock() and
5523 # srcu_read_unlock() do contain full memory barriers in payment for
5524 # synchronize_srcu_expedited() non-interruption properties.
5527 "expedited RCU grace periods should be avoided where they can degrade real-time response\n" . $herecurr);
5529 }
5531 # check of hardware specific defines
5532 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
5535 }
5537 # Check that the storage class is at the beginning of a declaration
5541 }
5543 # check the location of the inline attribute, that it is between
5544 # storage class and type.
5549 }
5551 # Check for __inline__ and __inline, prefer inline
5559 }
5560 }
5562 # Check for __attribute__ packed, prefer __packed
5567 }
5569 # Check for __attribute__ aligned, prefer __aligned
5574 }
5576 # Check for __attribute__ format(printf, prefer __printf
5580 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
5582 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
5584 }
5585 }
5587 # Check for __attribute__ format(scanf, prefer __scanf
5591 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
5593 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
5594 }
5595 }
5597 # Check for __attribute__ weak, or __weak declarations (may have link issues)
5599 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
5604 }
5606 # check for c99 types like uint8_t used outside of uapi/ and tools/
5621 }
5622 }
5623 }
5625 # check for cast of C90 native int or longer types constants
5640 }
5642 }
5643 }
5645 # check for sizeof(&)
5649 }
5651 # check for sizeof without parenthesis
5656 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
5657 }
5658 }
5660 # check for struct spinlock declarations
5664 }
5666 # check for seq_printf uses that could be seq_puts
5675 }
5676 }
5677 }
5679 # Check for misused memsets
5694 }
5695 }
5697 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
5698 # if ($^V && $^V ge 5.10.0 &&
5699 # defined $stat &&
5700 # $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
5701 # if (WARN("PREFER_ETHER_ADDR_COPY",
5702 # "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") &&
5703 # $fix) {
5704 # $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
5705 # }
5706 # }
5708 # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)
5709 # if ($^V && $^V ge 5.10.0 &&
5710 # defined $stat &&
5711 # $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
5712 # WARN("PREFER_ETHER_ADDR_EQUAL",
5713 # "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n")
5714 # }
5716 # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
5717 # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
5718 # if ($^V && $^V ge 5.10.0 &&
5719 # defined $stat &&
5720 # $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
5721 #
5722 # my $ms_val = $7;
5723 #
5724 # if ($ms_val =~ /^(?:0x|)0+$/i) {
5725 # if (WARN("PREFER_ETH_ZERO_ADDR",
5726 # "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") &&
5727 # $fix) {
5728 # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;
5729 # }
5730 # } elsif ($ms_val =~ /^(?:0xff|255)$/i) {
5731 # if (WARN("PREFER_ETH_BROADCAST_ADDR",
5732 # "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") &&
5733 # $fix) {
5734 # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;
5735 # }
5736 # }
5737 # }
5739 # typecasts on min/max could be min_t/max_t
5757 }
5760 }
5761 }
5763 # check usleep_range arguments
5771 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5775 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
5776 }
5777 }
5779 # check for naked sscanf
5791 }
5794 }
5796 # check for simple sscanf that should be kstrto<foo>
5805 }
5813 }
5814 }
5815 }
5817 # check for new externs in .h files.
5824 }
5825 }
5827 # check for new externs in .c files.
5830 {
5837 }
5840 {
5843 }
5848 }
5852 {
5855 }
5866 }
5867 }
5868 }
5870 # checks for new __setup's
5876 "__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.rst\n" . $herecurr);
5877 }
5878 }
5880 # check for pointless casting of kmalloc return
5883 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
5884 }
5886 # alloc style
5887 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
5889 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
5892 }
5894 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
5896 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
5907 }
5913 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
5915 }
5916 }
5917 }
5919 # check for krealloc arg reuse
5924 }
5926 # check for alloc argument mismatch
5930 }
5932 # check for multiple semicolons
5938 }
5939 }
5941 # check for #defines like: 1 << <digit> that could be BIT(digit), it is not exported to uapi
5950 }
5951 }
5953 # check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
5954 if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
5960 }
5961 }
5963 # check for case / default statements not preceded by break/fallthrough/switch
5981 }
5985 }
5986 }
5988 # check for switch/default statements without a break;
5997 }
6000 }
6002 # check for gcc specific __FUNCTION__
6008 }
6009 }
6011 # check for uses of __DATE__, __TIME__, __TIMESTAMP__
6015 }
6017 # check for use of yield()
6021 }
6023 # check for comparisons against true and false
6039 }
6044 ## maybe suggesting a correct construct would better
6045 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
6047 }
6048 }
6050 # check for semaphores initialized locked
6054 }
6056 # recommend kstrto* over simple_strto* and strict_strto*
6060 }
6062 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
6065 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
6066 }
6068 # check for various structs that are normally const (ops, kgdb, device_tree)
6074 }
6076 # use of NR_CPUS is usually wrong
6077 # ignore definitions of NR_CPUS and usage to define arrays as likely right
6084 {
6086 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
6087 }
6089 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
6093 }
6095 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
6100 }
6102 # whine mightly about in_atomic
6110 }
6111 }
6113 # whine about ACCESS_ONCE
6124 $fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)\s*$eq\s*\Q$fun\E/WRITE_ONCE($par, $fun)/;
6125 }
6131 }
6132 }
6133 }
6135 # check for mutex_trylock_recursive usage
6139 }
6141 # check for lockdep_set_novalidate_class
6149 }
6150 }
6155 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
6156 }
6158 # Mode permission misuses where it seems decimal should be octal
6159 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
6172 }
6178 }
6187 }
6190 "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . "$here\n" . $stat_real);
6191 }
6192 }
6193 }
6194 }
6196 # check for uses of S_<PERMS> that could be octal for readability
6213 }
6218 "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.\n" . $herecurr) &&
6221 }
6222 }
6224 # validate content of MODULE_LICENSE against list from include/linux/module.h
6228 GPL|
6229 GPL\ v2|
6234 Proprietary
6239 }
6240 }
6241 }
6243 # If we have no input at all, then there is nothing to report on
6244 # so just keep quiet.
6247 }
6249 # In mailback mode only produce a report in the negative, for
6250 # things that appear to be patches.
6253 }
6255 # This is not a patch, and we are are in 'no-patch' mode so
6256 # just keep quiet.
6259 }
6264 }
6268 }
6276 }
6279 # If there were any defects found and not already fixing them
6285 EOM
6286 }
6287 # If there were whitespace errors which cleanpatch can fix
6288 # then suggest that.
6295 EOM
6296 }
6297 }
6317 }
6320 }
6321 }
6329 Do _NOT_ trust the results written to this file.
6332 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
6334 EOM
6335 }
6336 }
6344 }
6345 }
6347 }