clang/test/Analysis/Checkers/WebKit/call-args-checked-const-member.cpp

   1 // RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncheckedCallArgsChecker -verify %s
   2
   3 #include "mock-types.h"
   4
   5 namespace call_args_const_checkedptr_member {
   6
   7 class Foo {
   8 public:
   9   Foo();
  10   void bar();
  11
  12 private:
  13   const CheckedPtr<CheckedObj> m_obj1;
  14   CheckedPtr<CheckedObj> m_obj2;
  15 };
  16
  17 void Foo::bar() {
  18   m_obj1->method();
  19   m_obj2->method();
  20   // expected-warning@-1{{Call argument for 'this' parameter is unchecked and unsafe}}
  21 }
  22
  23 } // namespace call_args_const_checkedptr_member
  24
  25 namespace call_args_const_checkedref_member {
  26
  27 class Foo {
  28 public:
  29   Foo();
  30   void bar();
  31
  32 private:
  33   const CheckedRef<CheckedObj> m_obj1;
  34   CheckedRef<CheckedObj> m_obj2;
  35 };
  36
  37 void Foo::bar() {
  38   m_obj1->method();
  39   m_obj2->method();
  40   // expected-warning@-1{{Call argument for 'this' parameter is unchecked and unsafe}}
  41 }
  42
  43 } // namespace call_args_const_checkedref_member
  44
  45 namespace call_args_const_unique_ptr {
  46
  47 class Foo {
  48 public:
  49   Foo();
  50   void bar();
  51
  52   CheckedObj& ensureObj3() {
  53     if (!m_obj3)
  54       const_cast<std::unique_ptr<CheckedObj>&>(m_obj3) = new CheckedObj;
  55     return *m_obj3;
  56   }
  57
  58   CheckedObj& badEnsureObj4() {
  59     if (!m_obj4)
  60       const_cast<std::unique_ptr<CheckedObj>&>(m_obj4) = new CheckedObj;
  61     if (auto* next = m_obj4->next())
  62       return *next;
  63     return *m_obj4;
  64   }
  65
  66   CheckedObj* ensureObj5() {
  67     if (!m_obj5)
  68       const_cast<std::unique_ptr<CheckedObj>&>(m_obj5) = new CheckedObj;
  69     if (m_obj5->next())
  70       return nullptr;
  71     return m_obj5.get();
  72   }
  73
  74 private:
  75   const std::unique_ptr<CheckedObj> m_obj1;
  76   std::unique_ptr<CheckedObj> m_obj2;
  77   const std::unique_ptr<CheckedObj> m_obj3;
  78   const std::unique_ptr<CheckedObj> m_obj4;
  79   const std::unique_ptr<CheckedObj> m_obj5;
  80 };
  81
  82 void Foo::bar() {
  83   m_obj1->method();
  84   m_obj2->method();
  85   // expected-warning@-1{{Call argument for 'this' parameter is unchecked and unsafe}}
  86   ensureObj3().method();
  87   badEnsureObj4().method();
  88   // expected-warning@-1{{Call argument for 'this' parameter is unchecked and unsafe}}
  89   ensureObj5()->method();
  90 }
  91
  92 } // namespace call_args_const_unique_ptr