1 //===--- TimeComparisonCheck.cpp - clang-tidy
2 //--------------------------------===//
4 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
5 // See https://llvm.org/LICENSE.txt for license information.
6 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
8 //===----------------------------------------------------------------------===//
10 #include "TimeComparisonCheck.h"
11 #include "DurationRewriter.h"
12 #include "clang/AST/ASTContext.h"
13 #include "clang/ASTMatchers/ASTMatchFinder.h"
14 #include "clang/Tooling/FixIt.h"
17 using namespace clang::ast_matchers
;
19 namespace clang::tidy::abseil
{
21 void TimeComparisonCheck::registerMatchers(MatchFinder
*Finder
) {
23 expr(comparisonOperatorWithCallee(functionDecl(
24 functionDecl(TimeConversionFunction()).bind("function_decl"))))
27 Finder
->addMatcher(Matcher
, this);
30 void TimeComparisonCheck::check(const MatchFinder::MatchResult
&Result
) {
31 const auto *Binop
= Result
.Nodes
.getNodeAs
<BinaryOperator
>("binop");
33 std::optional
<DurationScale
> Scale
= getScaleForTimeInverse(
34 Result
.Nodes
.getNodeAs
<FunctionDecl
>("function_decl")->getName());
38 if (isInMacro(Result
, Binop
->getLHS()) || isInMacro(Result
, Binop
->getRHS()))
41 // In most cases, we'll only need to rewrite one of the sides, but we also
42 // want to handle the case of rewriting both sides. This is much simpler if
43 // we unconditionally try and rewrite both, and let the rewriter determine
44 // if nothing needs to be done.
45 std::string LhsReplacement
=
46 rewriteExprFromNumberToTime(Result
, *Scale
, Binop
->getLHS());
47 std::string RhsReplacement
=
48 rewriteExprFromNumberToTime(Result
, *Scale
, Binop
->getRHS());
50 diag(Binop
->getBeginLoc(), "perform comparison in the time domain")
51 << FixItHint::CreateReplacement(Binop
->getSourceRange(),
52 (llvm::Twine(LhsReplacement
) + " " +
53 Binop
->getOpcodeStr() + " " +
58 } // namespace clang::tidy::abseil