| commit | df2b9a3e02ca3bd7b60af6c65571909a7d3ab317 | |
| author | Nabeel Omer <nabeel.omer@sony.com> | |
| Thu, 17 Dec 2020 16:06:45 +0000 (17 16:06 +0000) | ||
| committer | Jeremy Morse <jeremy.morse@sony.com> | |
| Thu, 17 Dec 2020 16:17:32 +0000 (17 16:17 +0000) | ||
| tree | fc5f0a12252b1b55985571963995cc7896af812d | treesnapshot (tar.gz zip) |
| parent | ab6cb31642fdc84301b7749fdeabba324e3dbc4a | commitdiff |
[DebugInfo] Avoid re-ordering assignments in LCSSA
The LCSSA pass makes use of a function insertDebugValuesForPHIs() to
propogate dbg.value() intrinsics to newly inserted PHI instructions. Faulty
behaviour occurs when the parent PHI of a newly inserted PHI is not the
most recent assignment to a source variable. insertDebugValuesForPHIs ends
up propagating a value that isn't the most recent assignemnt.
This change removes the call to insertDebugValuesForPHIs() from LCSSA,
preventing incorrect dbg.value intrinsics from being propagated.
Propagating variable locations between blocks will occur later, during
LiveDebugValues.
Differential Revision: https://reviews.llvm.org/D92576
The LCSSA pass makes use of a function insertDebugValuesForPHIs() to
propogate dbg.value() intrinsics to newly inserted PHI instructions. Faulty
behaviour occurs when the parent PHI of a newly inserted PHI is not the
most recent assignment to a source variable. insertDebugValuesForPHIs ends
up propagating a value that isn't the most recent assignemnt.
This change removes the call to insertDebugValuesForPHIs() from LCSSA,
preventing incorrect dbg.value intrinsics from being propagated.
Propagating variable locations between blocks will occur later, during
LiveDebugValues.
Differential Revision: https://reviews.llvm.org/D92576