3 * This program is free software; you can redistribute it and/or modify
4 * it under the terms of the GNU General Public License as published by
5 * the Free Software Foundation; either version 2 of the License, or
6 * (at your option) any later version.
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
13 * You should have received a copy of the GNU General Public License along
14 * with this program; if not, write to the Free Software Foundation, Inc.,
15 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 * http://www.gnu.org/copyleft/gpl.html
21 use MediaWiki\MainConfigNames
;
22 use MediaWiki\MediaWikiServices
;
23 use MediaWiki\Page\PageIdentity
;
24 use MediaWiki\Revision\RevisionRecord
;
25 use MediaWiki\Revision\RevisionStoreRecord
;
26 use MediaWiki\Title\Title
;
27 use Wikimedia\Rdbms\IDBAccessObject
;
28 use Wikimedia\Rdbms\LBFactory
;
29 use Wikimedia\Rdbms\RawSQLExpression
;
30 use Wikimedia\Rdbms\SelectQueryBuilder
;
33 * Job to add recent change entries mentioning category membership changes
35 * This allows users to easily scan categories for recent page membership changes
39 * - revTimestamp : timestamp of the triggering revision
41 * Category changes will be mentioned for revisions at/after the timestamp for this page
46 class CategoryMembershipChangeJob
extends Job
{
50 private const ENQUEUE_FUDGE_SEC
= 60;
53 * @param PageIdentity $page the page for which to update category membership.
54 * @param string $revisionTimestamp The timestamp of the new revision that triggered the job.
55 * @param bool $forImport Whether the new revision that triggered the import was imported
56 * @return JobSpecification
58 public static function newSpec( PageIdentity
$page, $revisionTimestamp, bool $forImport ) {
59 return new JobSpecification(
60 'categoryMembershipChange',
62 'pageId' => $page->getId(),
63 'revTimestamp' => $revisionTimestamp,
64 'forImport' => $forImport,
67 'removeDuplicates' => true,
68 'removeDuplicatesIgnoreParams' => [ 'revTimestamp' ]
75 * Constructor for use by the Job Queue infrastructure.
76 * @note Don't call this when queueing a new instance, use newSpec() instead.
77 * @param PageIdentity $page the categorized page.
78 * @param array $params Such latest revision instance of the categorized page.
80 public function __construct( PageIdentity
$page, array $params ) {
81 parent
::__construct( 'categoryMembershipChange', $page, $params );
82 // Only need one job per page. Note that ENQUEUE_FUDGE_SEC handles races where an
83 // older revision job gets inserted while the newer revision job is de-duplicated.
84 $this->removeDuplicates
= true;
87 public function run() {
88 $services = MediaWikiServices
::getInstance();
89 $lbFactory = $services->getDBLoadBalancerFactory();
90 $lb = $lbFactory->getMainLB();
91 $dbw = $lb->getConnection( DB_PRIMARY
);
93 $this->ticket
= $lbFactory->getEmptyTransactionTicket( __METHOD__
);
95 $page = $services->getWikiPageFactory()->newFromID( $this->params
['pageId'], IDBAccessObject
::READ_LATEST
);
97 $this->setLastError( "Could not find page #{$this->params['pageId']}" );
98 return false; // deleted?
101 // Cut down on the time spent in waitForPrimaryPos() in the critical section
102 $dbr = $lb->getConnection( DB_REPLICA
);
103 if ( !$lb->waitForPrimaryPos( $dbr ) ) {
104 $this->setLastError( "Timed out while pre-waiting for replica DB to catch up" );
108 // Use a named lock so that jobs for this page see each others' changes
109 $lockKey = "{$dbw->getDomainID()}:CategoryMembershipChange:{$page->getId()}"; // per-wiki
110 $scopedLock = $dbw->getScopedLockAndFlush( $lockKey, __METHOD__
, 3 );
111 if ( !$scopedLock ) {
112 $this->setLastError( "Could not acquire lock '$lockKey'" );
116 // Wait till replica DB is caught up so that jobs for this page see each others' changes
117 if ( !$lb->waitForPrimaryPos( $dbr ) ) {
118 $this->setLastError( "Timed out while waiting for replica DB to catch up" );
121 // Clear any stale REPEATABLE-READ snapshot
122 $dbr->flushSnapshot( __METHOD__
);
124 $cutoffUnix = wfTimestamp( TS_UNIX
, $this->params
['revTimestamp'] );
125 // Using ENQUEUE_FUDGE_SEC handles jobs inserted out of revision order due to the delay
126 // between COMMIT and actual enqueueing of the CategoryMembershipChangeJob job.
127 $cutoffUnix -= self
::ENQUEUE_FUDGE_SEC
;
129 // Get the newest page revision that has a SRC_CATEGORIZE row.
130 // Assume that category changes before it were already handled.
131 $subQuery = $dbr->newSelectQueryBuilder()
133 ->from( 'recentchanges' )
134 ->where( 'rc_this_oldid = rev_id' )
135 ->andWhere( [ 'rc_source' => RecentChange
::SRC_CATEGORIZE
] );
136 $row = $dbr->newSelectQueryBuilder()
137 ->select( [ 'rev_timestamp', 'rev_id' ] )
139 ->where( [ 'rev_page' => $page->getId() ] )
140 ->andWhere( $dbr->expr( 'rev_timestamp', '>=', $dbr->timestamp( $cutoffUnix ) ) )
141 ->andWhere( new RawSQLExpression( 'EXISTS (' . $subQuery->getSQL() . ')' ) )
142 ->orderBy( [ 'rev_timestamp', 'rev_id' ], SelectQueryBuilder
::SORT_DESC
)
143 ->caller( __METHOD__
)->fetchRow();
145 // Only consider revisions newer than any such revision
147 $cutoffUnix = wfTimestamp( TS_UNIX
, $row->rev_timestamp
);
148 $lastRevId = (int)$row->rev_id
;
153 // Find revisions to this page made around and after this revision which lack category
154 // notifications in recent changes. This lets jobs pick up were the last one left off.
155 $revisionStore = $services->getRevisionStore();
156 $res = $revisionStore->newSelectQueryBuilder( $dbr )
159 'rev_page' => $page->getId(),
160 $dbr->buildComparison( '>', [
161 'rev_timestamp' => $dbr->timestamp( $cutoffUnix ),
162 'rev_id' => $lastRevId,
165 ->orderBy( [ 'rev_timestamp', 'rev_id' ], SelectQueryBuilder
::SORT_ASC
)
166 ->caller( __METHOD__
)->fetchResultSet();
168 // Apply all category updates in revision timestamp order
169 foreach ( $res as $row ) {
170 $this->notifyUpdatesForRevision( $lbFactory, $page, $revisionStore->newRevisionFromRow( $row ) );
177 * @param LBFactory $lbFactory
178 * @param WikiPage $page
179 * @param RevisionRecord $newRev
181 protected function notifyUpdatesForRevision(
182 LBFactory
$lbFactory, WikiPage
$page, RevisionRecord
$newRev
184 $title = $page->getTitle();
186 // Get the new revision
187 if ( $newRev->isDeleted( RevisionRecord
::DELETED_TEXT
) ) {
191 $services = MediaWikiServices
::getInstance();
192 // Get the prior revision (the same for null edits)
193 if ( $newRev->getParentId() ) {
194 $oldRev = $services->getRevisionLookup()
195 ->getRevisionById( $newRev->getParentId(), IDBAccessObject
::READ_LATEST
);
196 if ( !$oldRev ||
$oldRev->isDeleted( RevisionRecord
::DELETED_TEXT
) ) {
203 // Parse the new revision and get the categories
204 $categoryChanges = $this->getExplicitCategoriesChanges( $page, $newRev, $oldRev );
205 [ $categoryInserts, $categoryDeletes ] = $categoryChanges;
206 if ( !$categoryInserts && !$categoryDeletes ) {
207 return; // nothing to do
210 $blc = $services->getBacklinkCacheFactory()->getBacklinkCache( $title );
211 $catMembChange = new CategoryMembershipChange( $title, $blc, $newRev, $this->params
['forImport'] ??
false );
212 $catMembChange->checkTemplateLinks();
214 $batchSize = $services->getMainConfig()->get( MainConfigNames
::UpdateRowsPerQuery
);
217 foreach ( $categoryInserts as $categoryName ) {
218 $categoryTitle = Title
::makeTitle( NS_CATEGORY
, $categoryName );
219 $catMembChange->triggerCategoryAddedNotification( $categoryTitle );
220 if ( $insertCount++
&& ( $insertCount %
$batchSize ) == 0 ) {
221 $lbFactory->commitAndWaitForReplication( __METHOD__
, $this->ticket
);
225 foreach ( $categoryDeletes as $categoryName ) {
226 $categoryTitle = Title
::makeTitle( NS_CATEGORY
, $categoryName );
227 $catMembChange->triggerCategoryRemovedNotification( $categoryTitle );
228 if ( $insertCount++
&& ( $insertCount++ %
$batchSize ) == 0 ) {
229 $lbFactory->commitAndWaitForReplication( __METHOD__
, $this->ticket
);
234 private function getExplicitCategoriesChanges(
235 WikiPage
$page, RevisionRecord
$newRev, ?RevisionRecord
$oldRev = null
237 // Inject the same timestamp for both revision parses to avoid seeing category changes
238 // due to time-based parser functions. Inject the same page title for the parses too.
239 // Note that REPEATABLE-READ makes template/file pages appear unchanged between parses.
240 $parseTimestamp = $newRev->getTimestamp();
241 // Parse the old rev and get the categories. Do not use link tables as that
242 // assumes these updates are perfectly FIFO and that link tables are always
243 // up to date, neither of which are true.
244 $oldCategories = $oldRev
245 ?
$this->getCategoriesAtRev( $page, $oldRev, $parseTimestamp )
247 // Parse the new revision and get the categories
248 $newCategories = $this->getCategoriesAtRev( $page, $newRev, $parseTimestamp );
250 $categoryInserts = array_values( array_diff( $newCategories, $oldCategories ) );
251 $categoryDeletes = array_values( array_diff( $oldCategories, $newCategories ) );
253 return [ $categoryInserts, $categoryDeletes ];
257 * @param WikiPage $page
258 * @param RevisionRecord $rev
259 * @param string $parseTimestamp TS_MW
261 * @return string[] category names
263 private function getCategoriesAtRev( WikiPage
$page, RevisionRecord
$rev, $parseTimestamp ) {
264 $services = MediaWikiServices
::getInstance();
265 $options = $page->makeParserOptions( 'canonical' );
266 $options->setTimestamp( $parseTimestamp );
267 $options->setRenderReason( 'CategoryMembershipChangeJob' );
269 $output = $rev instanceof RevisionStoreRecord
&& $rev->isCurrent()
270 ?
$services->getParserCache()->get( $page, $options )
273 if ( !$output ||
$output->getCacheRevisionId() !== $rev->getId() ) {
274 $output = $services->getRevisionRenderer()->getRenderedRevision( $rev, $options )
275 ->getRevisionParserOutput();
278 // array keys will cast numeric category names to ints;
279 // ::getCategoryNames() is careful to cast them back to strings
280 // to avoid breaking things!
281 return $output->getCategoryNames();
284 public function getDeduplicationInfo() {
285 $info = parent
::getDeduplicationInfo();
286 unset( $info['params']['revTimestamp'] ); // first job wins