tests/phpunit/includes/RevisionStorageTest.php

   1 <?php
   2
   3 /**
   4  * Test class for Revision storage.
   5  *
   6  * @group ContentHandler
   7  * @group Database
   8  * ^--- important, causes temporary tables to be used instead of the real database
   9  *
  10  * @group medium
  11  * ^--- important, causes tests not to fail with timeout
  12  */
  13 class RevisionStorageTest extends MediaWikiTestCase {
  14         /**
  15          * @var WikiPage $the_page
  16          */
  17         private $the_page;
  18
  19         function __construct( $name = null, array $data = [], $dataName = '' ) {
  20                 parent::__construct( $name, $data, $dataName );
  21
  22                 $this->tablesUsed = array_merge( $this->tablesUsed,
  23                         [ 'page',
  24                                 'revision',
  25                                 'text',
  26
  27                                 'recentchanges',
  28                                 'logging',
  29
  30                                 'page_props',
  31                                 'pagelinks',
  32                                 'categorylinks',
  33                                 'langlinks',
  34                                 'externallinks',
  35                                 'imagelinks',
  36                                 'templatelinks',
  37                                 'iwlinks' ] );
  38         }
  39
  40         protected function setUp() {
  41                 global $wgExtraNamespaces, $wgNamespaceContentModels, $wgContentHandlers, $wgContLang;
  42
  43                 parent::setUp();
  44
  45                 $wgExtraNamespaces[12312] = 'Dummy';
  46                 $wgExtraNamespaces[12313] = 'Dummy_talk';
  47
  48                 $wgNamespaceContentModels[12312] = 'DUMMY';
  49                 $wgContentHandlers['DUMMY'] = 'DummyContentHandlerForTesting';
  50
  51                 MWNamespace::getCanonicalNamespaces( true ); # reset namespace cache
  52                 $wgContLang->resetNamespaces(); # reset namespace cache
  53                 if ( !$this->the_page ) {
  54                         $this->the_page = $this->createPage(
  55                                 'RevisionStorageTest_the_page',
  56                                 "just a dummy page",
  57                                 CONTENT_MODEL_WIKITEXT
  58                         );
  59                 }
  60
  61                 $this->tablesUsed[] = 'archive';
  62         }
  63
  64         protected function tearDown() {
  65                 global $wgExtraNamespaces, $wgNamespaceContentModels, $wgContentHandlers, $wgContLang;
  66
  67                 parent::tearDown();
  68
  69                 unset( $wgExtraNamespaces[12312] );
  70                 unset( $wgExtraNamespaces[12313] );
  71
  72                 unset( $wgNamespaceContentModels[12312] );
  73                 unset( $wgContentHandlers['DUMMY'] );
  74
  75                 MWNamespace::getCanonicalNamespaces( true ); # reset namespace cache
  76                 $wgContLang->resetNamespaces(); # reset namespace cache
  77         }
  78
  79         protected function makeRevision( $props = null ) {
  80                 if ( $props === null ) {
  81                         $props = [];
  82                 }
  83
  84                 if ( !isset( $props['content'] ) && !isset( $props['text'] ) ) {
  85                         $props['text'] = 'Lorem Ipsum';
  86                 }
  87
  88                 if ( !isset( $props['comment'] ) ) {
  89                         $props['comment'] = 'just a test';
  90                 }
  91
  92                 if ( !isset( $props['page'] ) ) {
  93                         $props['page'] = $this->the_page->getId();
  94                 }
  95
  96                 $rev = new Revision( $props );
  97
  98                 $dbw = wfGetDB( DB_MASTER );
  99                 $rev->insertOn( $dbw );
 100
 101                 return $rev;
 102         }
 103
 104         protected function createPage( $page, $text, $model = null ) {
 105                 if ( is_string( $page ) ) {
 106                         if ( !preg_match( '/:/', $page ) &&
 107                                 ( $model === null || $model === CONTENT_MODEL_WIKITEXT )
 108                         ) {
 109                                 $ns = $this->getDefaultWikitextNS();
 110                                 $page = MWNamespace::getCanonicalName( $ns ) . ':' . $page;
 111                         }
 112
 113                         $page = Title::newFromText( $page );
 114                 }
 115
 116                 if ( $page instanceof Title ) {
 117                         $page = new WikiPage( $page );
 118                 }
 119
 120                 if ( $page->exists() ) {
 121                         $page->doDeleteArticle( "done" );
 122                 }
 123
 124                 $content = ContentHandler::makeContent( $text, $page->getTitle(), $model );
 125                 $page->doEditContent( $content, "testing", EDIT_NEW );
 126
 127                 return $page;
 128         }
 129
 130         protected function assertRevEquals( Revision $orig, Revision $rev = null ) {
 131                 $this->assertNotNull( $rev, 'missing revision' );
 132
 133                 $this->assertEquals( $orig->getId(), $rev->getId() );
 134                 $this->assertEquals( $orig->getPage(), $rev->getPage() );
 135                 $this->assertEquals( $orig->getTimestamp(), $rev->getTimestamp() );
 136                 $this->assertEquals( $orig->getUser(), $rev->getUser() );
 137                 $this->assertEquals( $orig->getContentModel(), $rev->getContentModel() );
 138                 $this->assertEquals( $orig->getContentFormat(), $rev->getContentFormat() );
 139                 $this->assertEquals( $orig->getSha1(), $rev->getSha1() );
 140         }
 141
 142         /**
 143          * @covers Revision::__construct
 144          */
 145         public function testConstructFromRow() {
 146                 $orig = $this->makeRevision();
 147
 148                 $dbr = wfGetDB( DB_SLAVE );
 149                 $res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
 150                 $this->assertTrue( is_object( $res ), 'query failed' );
 151
 152                 $row = $res->fetchObject();
 153                 $res->free();
 154
 155                 $rev = new Revision( $row );
 156
 157                 $this->assertRevEquals( $orig, $rev );
 158         }
 159
 160         /**
 161          * @covers Revision::newFromRow
 162          */
 163         public function testNewFromRow() {
 164                 $orig = $this->makeRevision();
 165
 166                 $dbr = wfGetDB( DB_SLAVE );
 167                 $res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
 168                 $this->assertTrue( is_object( $res ), 'query failed' );
 169
 170                 $row = $res->fetchObject();
 171                 $res->free();
 172
 173                 $rev = Revision::newFromRow( $row );
 174
 175                 $this->assertRevEquals( $orig, $rev );
 176         }
 177
 178         /**
 179          * @covers Revision::newFromArchiveRow
 180          */
 181         public function testNewFromArchiveRow() {
 182                 $page = $this->createPage(
 183                         'RevisionStorageTest_testNewFromArchiveRow',
 184                         'Lorem Ipsum',
 185                         CONTENT_MODEL_WIKITEXT
 186                 );
 187                 $orig = $page->getRevision();
 188                 $page->doDeleteArticle( 'test Revision::newFromArchiveRow' );
 189
 190                 $dbr = wfGetDB( DB_SLAVE );
 191                 $res = $dbr->select( 'archive', '*', [ 'ar_rev_id' => $orig->getId() ] );
 192                 $this->assertTrue( is_object( $res ), 'query failed' );
 193
 194                 $row = $res->fetchObject();
 195                 $res->free();
 196
 197                 $rev = Revision::newFromArchiveRow( $row );
 198
 199                 $this->assertRevEquals( $orig, $rev );
 200         }
 201
 202         /**
 203          * @covers Revision::newFromId
 204          */
 205         public function testNewFromId() {
 206                 $orig = $this->makeRevision();
 207
 208                 $rev = Revision::newFromId( $orig->getId() );
 209
 210                 $this->assertRevEquals( $orig, $rev );
 211         }
 212
 213         /**
 214          * @covers Revision::fetchRevision
 215          */
 216         public function testFetchRevision() {
 217                 $page = $this->createPage(
 218                         'RevisionStorageTest_testFetchRevision',
 219                         'one',
 220                         CONTENT_MODEL_WIKITEXT
 221                 );
 222
 223                 // Hidden process cache assertion below
 224                 $page->getRevision()->getId();
 225
 226                 $page->doEditContent( new WikitextContent( 'two' ), 'second rev' );
 227                 $id = $page->getRevision()->getId();
 228
 229                 $res = Revision::fetchRevision( $page->getTitle() );
 230
 231                 # note: order is unspecified
 232                 $rows = [];
 233                 while ( ( $row = $res->fetchObject() ) ) {
 234                         $rows[$row->rev_id] = $row;
 235                 }
 236
 237                 $this->assertEquals( 1, count( $rows ), 'expected exactly one revision' );
 238                 $this->assertArrayHasKey( $id, $rows, 'missing revision with id ' . $id );
 239         }
 240
 241         /**
 242          * @covers Revision::selectFields
 243          */
 244         public function testSelectFields() {
 245                 global $wgContentHandlerUseDB;
 246
 247                 $fields = Revision::selectFields();
 248
 249                 $this->assertTrue( in_array( 'rev_id', $fields ), 'missing rev_id in list of fields' );
 250                 $this->assertTrue( in_array( 'rev_page', $fields ), 'missing rev_page in list of fields' );
 251                 $this->assertTrue(
 252                         in_array( 'rev_timestamp', $fields ),
 253                         'missing rev_timestamp in list of fields'
 254                 );
 255                 $this->assertTrue( in_array( 'rev_user', $fields ), 'missing rev_user in list of fields' );
 256
 257                 if ( $wgContentHandlerUseDB ) {
 258                         $this->assertTrue( in_array( 'rev_content_model', $fields ),
 259                                 'missing rev_content_model in list of fields' );
 260                         $this->assertTrue( in_array( 'rev_content_format', $fields ),
 261                                 'missing rev_content_format in list of fields' );
 262                 }
 263         }
 264
 265         /**
 266          * @covers Revision::getPage
 267          */
 268         public function testGetPage() {
 269                 $page = $this->the_page;
 270
 271                 $orig = $this->makeRevision( [ 'page' => $page->getId() ] );
 272                 $rev = Revision::newFromId( $orig->getId() );
 273
 274                 $this->assertEquals( $page->getId(), $rev->getPage() );
 275         }
 276
 277         /**
 278          * @covers Revision::getText
 279          */
 280         public function testGetText() {
 281                 $this->hideDeprecated( 'Revision::getText' );
 282
 283                 $orig = $this->makeRevision( [ 'text' => 'hello hello.' ] );
 284                 $rev = Revision::newFromId( $orig->getId() );
 285
 286                 $this->assertEquals( 'hello hello.', $rev->getText() );
 287         }
 288
 289         /**
 290          * @covers Revision::getContent
 291          */
 292         public function testGetContent_failure() {
 293                 $rev = new Revision( [
 294                         'page' => $this->the_page->getId(),
 295                         'content_model' => $this->the_page->getContentModel(),
 296                         'text_id' => 123456789, // not in the test DB
 297                 ] );
 298
 299                 $this->assertNull( $rev->getContent(),
 300                         "getContent() should return null if the revision's text blob could not be loaded." );
 301
 302                 // NOTE: check this twice, once for lazy initialization, and once with the cached value.
 303                 $this->assertNull( $rev->getContent(),
 304                         "getContent() should return null if the revision's text blob could not be loaded." );
 305         }
 306
 307         /**
 308          * @covers Revision::getContent
 309          */
 310         public function testGetContent() {
 311                 $orig = $this->makeRevision( [ 'text' => 'hello hello.' ] );
 312                 $rev = Revision::newFromId( $orig->getId() );
 313
 314                 $this->assertEquals( 'hello hello.', $rev->getContent()->getNativeData() );
 315         }
 316
 317         /**
 318          * @covers Revision::getContentModel
 319          */
 320         public function testGetContentModel() {
 321                 global $wgContentHandlerUseDB;
 322
 323                 if ( !$wgContentHandlerUseDB ) {
 324                         $this->markTestSkipped( '$wgContentHandlerUseDB is disabled' );
 325                 }
 326
 327                 $orig = $this->makeRevision( [ 'text' => 'hello hello.',
 328                         'content_model' => CONTENT_MODEL_JAVASCRIPT ] );
 329                 $rev = Revision::newFromId( $orig->getId() );
 330
 331                 $this->assertEquals( CONTENT_MODEL_JAVASCRIPT, $rev->getContentModel() );
 332         }
 333
 334         /**
 335          * @covers Revision::getContentFormat
 336          */
 337         public function testGetContentFormat() {
 338                 global $wgContentHandlerUseDB;
 339
 340                 if ( !$wgContentHandlerUseDB ) {
 341                         $this->markTestSkipped( '$wgContentHandlerUseDB is disabled' );
 342                 }
 343
 344                 $orig = $this->makeRevision( [
 345                         'text' => 'hello hello.',
 346                         'content_model' => CONTENT_MODEL_JAVASCRIPT,
 347                         'content_format' => CONTENT_FORMAT_JAVASCRIPT
 348                 ] );
 349                 $rev = Revision::newFromId( $orig->getId() );
 350
 351                 $this->assertEquals( CONTENT_FORMAT_JAVASCRIPT, $rev->getContentFormat() );
 352         }
 353
 354         /**
 355          * @covers Revision::isCurrent
 356          */
 357         public function testIsCurrent() {
 358                 $page = $this->createPage(
 359                         'RevisionStorageTest_testIsCurrent',
 360                         'Lorem Ipsum',
 361                         CONTENT_MODEL_WIKITEXT
 362                 );
 363                 $rev1 = $page->getRevision();
 364
 365                 # @todo find out if this should be true
 366                 # $this->assertTrue( $rev1->isCurrent() );
 367
 368                 $rev1x = Revision::newFromId( $rev1->getId() );
 369                 $this->assertTrue( $rev1x->isCurrent() );
 370
 371                 $page->doEditContent(
 372                         ContentHandler::makeContent( 'Bla bla', $page->getTitle(), CONTENT_MODEL_WIKITEXT ),
 373                         'second rev'
 374                 );
 375                 $rev2 = $page->getRevision();
 376
 377                 # @todo find out if this should be true
 378                 # $this->assertTrue( $rev2->isCurrent() );
 379
 380                 $rev1x = Revision::newFromId( $rev1->getId() );
 381                 $this->assertFalse( $rev1x->isCurrent() );
 382
 383                 $rev2x = Revision::newFromId( $rev2->getId() );
 384                 $this->assertTrue( $rev2x->isCurrent() );
 385         }
 386
 387         /**
 388          * @covers Revision::getPrevious
 389          */
 390         public function testGetPrevious() {
 391                 $page = $this->createPage(
 392                         'RevisionStorageTest_testGetPrevious',
 393                         'Lorem Ipsum testGetPrevious',
 394                         CONTENT_MODEL_WIKITEXT
 395                 );
 396                 $rev1 = $page->getRevision();
 397
 398                 $this->assertNull( $rev1->getPrevious() );
 399
 400                 $page->doEditContent(
 401                         ContentHandler::makeContent( 'Bla bla', $page->getTitle(), CONTENT_MODEL_WIKITEXT ),
 402                         'second rev testGetPrevious' );
 403                 $rev2 = $page->getRevision();
 404
 405                 $this->assertNotNull( $rev2->getPrevious() );
 406                 $this->assertEquals( $rev1->getId(), $rev2->getPrevious()->getId() );
 407         }
 408
 409         /**
 410          * @covers Revision::getNext
 411          */
 412         public function testGetNext() {
 413                 $page = $this->createPage(
 414                         'RevisionStorageTest_testGetNext',
 415                         'Lorem Ipsum testGetNext',
 416                         CONTENT_MODEL_WIKITEXT
 417                 );
 418                 $rev1 = $page->getRevision();
 419
 420                 $this->assertNull( $rev1->getNext() );
 421
 422                 $page->doEditContent(
 423                         ContentHandler::makeContent( 'Bla bla', $page->getTitle(), CONTENT_MODEL_WIKITEXT ),
 424                         'second rev testGetNext'
 425                 );
 426                 $rev2 = $page->getRevision();
 427
 428                 $this->assertNotNull( $rev1->getNext() );
 429                 $this->assertEquals( $rev2->getId(), $rev1->getNext()->getId() );
 430         }
 431
 432         /**
 433          * @covers Revision::newNullRevision
 434          */
 435         public function testNewNullRevision() {
 436                 $page = $this->createPage(
 437                         'RevisionStorageTest_testNewNullRevision',
 438                         'some testing text',
 439                         CONTENT_MODEL_WIKITEXT
 440                 );
 441                 $orig = $page->getRevision();
 442
 443                 $dbw = wfGetDB( DB_MASTER );
 444                 $rev = Revision::newNullRevision( $dbw, $page->getId(), 'a null revision', false );
 445
 446                 $this->assertNotEquals( $orig->getId(), $rev->getId(),
 447                         'new null revision shold have a different id from the original revision' );
 448                 $this->assertEquals( $orig->getTextId(), $rev->getTextId(),
 449                         'new null revision shold have the same text id as the original revision' );
 450                 $this->assertEquals( 'some testing text', $rev->getContent()->getNativeData() );
 451         }
 452
 453         public static function provideUserWasLastToEdit() {
 454                 return [
 455                         [ # 0
 456                                 3, true, # actually the last edit
 457                         ],
 458                         [ # 1
 459                                 2, true, # not the current edit, but still by this user
 460                         ],
 461                         [ # 2
 462                                 1, false, # edit by another user
 463                         ],
 464                         [ # 3
 465                                 0, false, # first edit, by this user, but another user edited in the mean time
 466                         ],
 467                 ];
 468         }
 469
 470         /**
 471          * @dataProvider provideUserWasLastToEdit
 472          */
 473         public function testUserWasLastToEdit( $sinceIdx, $expectedLast ) {
 474                 $userA = User::newFromName( "RevisionStorageTest_userA" );
 475                 $userB = User::newFromName( "RevisionStorageTest_userB" );
 476
 477                 if ( $userA->getId() === 0 ) {
 478                         $userA = User::createNew( $userA->getName() );
 479                 }
 480
 481                 if ( $userB->getId() === 0 ) {
 482                         $userB = User::createNew( $userB->getName() );
 483                 }
 484
 485                 $ns = $this->getDefaultWikitextNS();
 486
 487                 $dbw = wfGetDB( DB_MASTER );
 488                 $revisions = [];
 489
 490                 // create revisions -----------------------------
 491                 $page = WikiPage::factory( Title::newFromText(
 492                         'RevisionStorageTest_testUserWasLastToEdit', $ns ) );
 493                 $page->insertOn( $dbw );
 494
 495                 # zero
 496                 $revisions[0] = new Revision( [
 497                         'page' => $page->getId(),
 498                         // we need the title to determine the page's default content model
 499                         'title' => $page->getTitle(),
 500                         'timestamp' => '20120101000000',
 501                         'user' => $userA->getId(),
 502                         'text' => 'zero',
 503                         'content_model' => CONTENT_MODEL_WIKITEXT,
 504                         'summary' => 'edit zero'
 505                 ] );
 506                 $revisions[0]->insertOn( $dbw );
 507
 508                 # one
 509                 $revisions[1] = new Revision( [
 510                         'page' => $page->getId(),
 511                         // still need the title, because $page->getId() is 0 (there's no entry in the page table)
 512                         'title' => $page->getTitle(),
 513                         'timestamp' => '20120101000100',
 514                         'user' => $userA->getId(),
 515                         'text' => 'one',
 516                         'content_model' => CONTENT_MODEL_WIKITEXT,
 517                         'summary' => 'edit one'
 518                 ] );
 519                 $revisions[1]->insertOn( $dbw );
 520
 521                 # two
 522                 $revisions[2] = new Revision( [
 523                         'page' => $page->getId(),
 524                         'title' => $page->getTitle(),
 525                         'timestamp' => '20120101000200',
 526                         'user' => $userB->getId(),
 527                         'text' => 'two',
 528                         'content_model' => CONTENT_MODEL_WIKITEXT,
 529                         'summary' => 'edit two'
 530                 ] );
 531                 $revisions[2]->insertOn( $dbw );
 532
 533                 # three
 534                 $revisions[3] = new Revision( [
 535                         'page' => $page->getId(),
 536                         'title' => $page->getTitle(),
 537                         'timestamp' => '20120101000300',
 538                         'user' => $userA->getId(),
 539                         'text' => 'three',
 540                         'content_model' => CONTENT_MODEL_WIKITEXT,
 541                         'summary' => 'edit three'
 542                 ] );
 543                 $revisions[3]->insertOn( $dbw );
 544
 545                 # four
 546                 $revisions[4] = new Revision( [
 547                         'page' => $page->getId(),
 548                         'title' => $page->getTitle(),
 549                         'timestamp' => '20120101000200',
 550                         'user' => $userA->getId(),
 551                         'text' => 'zero',
 552                         'content_model' => CONTENT_MODEL_WIKITEXT,
 553                         'summary' => 'edit four'
 554                 ] );
 555                 $revisions[4]->insertOn( $dbw );
 556
 557                 // test it ---------------------------------
 558                 $since = $revisions[$sinceIdx]->getTimestamp();
 559
 560                 $wasLast = Revision::userWasLastToEdit( $dbw, $page->getId(), $userA->getId(), $since );
 561
 562                 $this->assertEquals( $expectedLast, $wasLast );
 563         }
 564 }