1 /* $NetBSD: main.c,v 1.225 2013/09/14 15:09:34 matt Exp $ */
4 * Copyright (c) 1988, 1989, 1990, 1993
5 * The Regents of the University of California. All rights reserved.
7 * This code is derived from software contributed to Berkeley by
10 * Redistribution and use in source and binary forms, with or without
11 * modification, are permitted provided that the following conditions
13 * 1. Redistributions of source code must retain the above copyright
14 * notice, this list of conditions and the following disclaimer.
15 * 2. Redistributions in binary form must reproduce the above copyright
16 * notice, this list of conditions and the following disclaimer in the
17 * documentation and/or other materials provided with the distribution.
18 * 3. Neither the name of the University nor the names of its contributors
19 * may be used to endorse or promote products derived from this software
20 * without specific prior written permission.
22 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
23 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
24 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
25 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
26 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
27 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
28 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
29 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
30 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
31 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
36 * Copyright (c) 1989 by Berkeley Softworks
37 * All rights reserved.
39 * This code is derived from software contributed to Berkeley by
42 * Redistribution and use in source and binary forms, with or without
43 * modification, are permitted provided that the following conditions
45 * 1. Redistributions of source code must retain the above copyright
46 * notice, this list of conditions and the following disclaimer.
47 * 2. Redistributions in binary form must reproduce the above copyright
48 * notice, this list of conditions and the following disclaimer in the
49 * documentation and/or other materials provided with the distribution.
50 * 3. All advertising materials mentioning features or use of this software
51 * must display the following acknowledgement:
52 * This product includes software developed by the University of
53 * California, Berkeley and its contributors.
54 * 4. Neither the name of the University nor the names of its contributors
55 * may be used to endorse or promote products derived from this software
56 * without specific prior written permission.
58 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
59 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
60 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
61 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
62 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
63 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
64 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
65 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
66 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
67 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
72 static char rcsid
[] = "$NetBSD: main.c,v 1.225 2013/09/14 15:09:34 matt Exp $";
74 #include <sys/cdefs.h>
76 __COPYRIGHT("@(#) Copyright (c) 1988, 1989, 1990, 1993\
77 The Regents of the University of California. All rights reserved.");
82 static char sccsid
[] = "@(#)main.c 8.3 (Berkeley) 3/19/94";
84 __RCSID("$NetBSD: main.c,v 1.225 2013/09/14 15:09:34 matt Exp $");
91 * The main file for this entire program. Exit routines etc
94 * Utility functions defined in this file:
95 * Main_ParseArgLine Takes a line of arguments, breaks them and
96 * treats them as if they were given when first
97 * invoked. Used by the parse module to implement
100 * Error Print a tagged error message. The global
101 * MAKE variable must have been defined. This
102 * takes a format string and two optional
105 * Fatal Print an error message and exit. Also takes
106 * a format string and two arguments.
108 * Punt Aborts all jobs and exits with a message. Also
109 * takes a format string and two arguments.
111 * Finish Finish things up by printing the number of
112 * errors which occurred, as passed to it, and
116 #include <sys/types.h>
117 #include <sys/time.h>
118 #include <sys/param.h>
119 #include <sys/resource.h>
120 #include <sys/stat.h>
122 #include <sys/sysctl.h>
124 #include <sys/utsname.h>
125 #include <sys/wait.h>
140 #include "pathnames.h"
148 #define DEFMAXLOCAL DEFMAXJOBS
149 #endif /* DEFMAXLOCAL */
151 Lst create
; /* Targets to be made */
152 time_t now
; /* Time at start of make */
153 GNode
*DEFAULT
; /* .DEFAULT node */
154 Boolean allPrecious
; /* .PRECIOUS given on line by itself */
156 static Boolean noBuiltins
; /* -r flag */
157 static Lst makefiles
; /* ordered list of makefiles to read */
158 static Boolean printVars
; /* print value of one or more vars */
159 static Lst variables
; /* list of variables to print */
160 int maxJobs
; /* -j argument */
161 static int maxJobTokens
; /* -j argument */
162 Boolean compatMake
; /* -B argument */
163 int debug
; /* -d argument */
164 Boolean debugVflag
; /* -dV */
165 Boolean noExecute
; /* -n flag */
166 Boolean noRecursiveExecute
; /* -N flag */
167 Boolean keepgoing
; /* -k flag */
168 Boolean queryFlag
; /* -q flag */
169 Boolean touchFlag
; /* -t flag */
170 Boolean enterFlag
; /* -w flag */
171 Boolean ignoreErrors
; /* -i flag */
172 Boolean beSilent
; /* -s flag */
173 Boolean oldVars
; /* variable substitution style */
174 Boolean checkEnvFirst
; /* -e flag */
175 Boolean parseWarnFatal
; /* -W flag */
176 Boolean jobServer
; /* -J flag */
177 static int jp_0
= -1, jp_1
= -1; /* ends of parent job pipe */
178 Boolean varNoExportEnv
; /* -X flag */
179 Boolean doing_depend
; /* Set while reading .depend */
180 static Boolean jobsRunning
; /* TRUE if the jobs might be running */
181 static const char * tracefile
;
182 static void MainParseArgs(int, char **);
183 static int ReadMakefile(const void *, const void *);
184 static void usage(void) MAKE_ATTR_DEAD
;
186 static Boolean ignorePWD
; /* if we use -C, PWD is meaningless */
187 static char objdir
[MAXPATHLEN
+ 1]; /* where we chdir'ed to */
188 char curdir
[MAXPATHLEN
+ 1]; /* Startup directory */
189 char *progname
; /* the program name */
190 char *makeDependfile
;
194 Boolean forceJobs
= FALSE
;
196 extern Lst parseIncPath
;
199 * For compatibility with the POSIX version of MAKEFLAGS that includes
200 * all the options with out -, convert flags to -f -l -a -g -s.
203 explode(const char *flags
)
212 for (f
= flags
; *f
; f
++)
213 if (!isalpha((unsigned char)*f
))
217 return bmake_strdup(flags
);
220 st
= nf
= bmake_malloc(len
* 3 + 1);
231 parse_debug_options(const char *argvalue
)
238 for (modules
= argvalue
; *modules
; ++modules
) {
256 debug
|= DEBUG_ERROR
;
262 if (modules
[1] == '1') {
263 debug
|= DEBUG_GRAPH1
;
266 else if (modules
[1] == '2') {
267 debug
|= DEBUG_GRAPH2
;
270 else if (modules
[1] == '3') {
271 debug
|= DEBUG_GRAPH3
;
288 debug
|= DEBUG_SCRIPT
;
291 debug
|= DEBUG_PARSE
;
306 debug
|= DEBUG_SHELL
;
309 if (debug_file
!= stdout
&& debug_file
!= stderr
)
311 if (*++modules
== '+') {
316 if (strcmp(modules
, "stdout") == 0) {
320 if (strcmp(modules
, "stderr") == 0) {
324 len
= strlen(modules
);
325 fname
= malloc(len
+ 20);
326 memcpy(fname
, modules
, len
+ 1);
327 /* Let the filename be modified by the pid */
328 if (strcmp(fname
+ len
- 3, ".%d") == 0)
329 snprintf(fname
+ len
- 2, 20, "%d", getpid());
330 debug_file
= fopen(fname
, mode
);
332 fprintf(stderr
, "Cannot open debug file %s\n",
339 (void)fprintf(stderr
,
340 "%s: illegal argument to d option -- %c\n",
347 * Make the debug_file unbuffered, and make
348 * stdout line buffered (unless debugfile == stdout).
350 setvbuf(debug_file
, NULL
, _IONBF
, 0);
351 if (debug_file
!= stdout
) {
352 setvbuf(stdout
, NULL
, _IOLBF
, 0);
358 * Parse a given argument vector. Called from main() and from
359 * Main_ParseArgLine() when the .MAKEFLAGS target is used.
361 * XXX: Deal with command line overriding .MAKEFLAGS in makefile
367 * Various global and local flags will be set depending on the flags
371 MainParseArgs(int argc
, char **argv
)
377 const char *getopt_def
;
379 Boolean inOption
, dashDash
= FALSE
;
380 char found_path
[MAXPATHLEN
+ 1]; /* for searching for sys.mk */
382 #define OPTFLAGS "BC:D:I:J:NST:V:WXd:ef:ij:km:nqrstw"
383 /* Can't actually use getopt(3) because rescanning is not portable */
385 getopt_def
= OPTFLAGS
;
403 if (c
!= '-' || dashDash
)
408 /* '-' found at some earlier point */
409 getopt_spec
= strchr(getopt_def
, c
);
410 if(c
!= '\0' && getopt_spec
!= NULL
&& getopt_spec
[1] == ':') {
411 /* -<something> found, and <something> should have an arg */
415 if(*argvalue
== '\0') {
431 Var_Append(MAKEFLAGS
, "-B", VAR_GLOBAL
);
432 Var_Set(MAKE_MODE
, "compat", VAR_GLOBAL
, 0);
435 if (chdir(argvalue
) == -1) {
436 (void)fprintf(stderr
,
437 "%s: chdir %s: %s\n",
442 if (getcwd(curdir
, MAXPATHLEN
) == NULL
) {
443 (void)fprintf(stderr
, "%s: %s.\n", progname
, strerror(errno
));
449 if (argvalue
== NULL
|| argvalue
[0] == 0) goto noarg
;
450 Var_Set(argvalue
, "1", VAR_GLOBAL
, 0);
451 Var_Append(MAKEFLAGS
, "-D", VAR_GLOBAL
);
452 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
455 if (argvalue
== NULL
) goto noarg
;
456 Parse_AddIncludeDir(argvalue
);
457 Var_Append(MAKEFLAGS
, "-I", VAR_GLOBAL
);
458 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
461 if (argvalue
== NULL
) goto noarg
;
462 if (sscanf(argvalue
, "%d,%d", &jp_0
, &jp_1
) != 2) {
463 (void)fprintf(stderr
,
464 "%s: internal error -- J option malformed (%s)\n",
468 if ((fcntl(jp_0
, F_GETFD
, 0) < 0) ||
469 (fcntl(jp_1
, F_GETFD
, 0) < 0)) {
471 (void)fprintf(stderr
,
472 "%s: ###### warning -- J descriptors were closed!\n",
480 Var_Append(MAKEFLAGS
, "-J", VAR_GLOBAL
);
481 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
487 noRecursiveExecute
= TRUE
;
488 Var_Append(MAKEFLAGS
, "-N", VAR_GLOBAL
);
492 Var_Append(MAKEFLAGS
, "-S", VAR_GLOBAL
);
495 if (argvalue
== NULL
) goto noarg
;
496 tracefile
= bmake_strdup(argvalue
);
497 Var_Append(MAKEFLAGS
, "-T", VAR_GLOBAL
);
498 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
501 if (argvalue
== NULL
) goto noarg
;
503 (void)Lst_AtEnd(variables
, argvalue
);
504 Var_Append(MAKEFLAGS
, "-V", VAR_GLOBAL
);
505 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
508 parseWarnFatal
= TRUE
;
511 varNoExportEnv
= TRUE
;
512 Var_Append(MAKEFLAGS
, "-X", VAR_GLOBAL
);
515 if (argvalue
== NULL
) goto noarg
;
516 /* If '-d-opts' don't pass to children */
517 if (argvalue
[0] == '-')
520 Var_Append(MAKEFLAGS
, "-d", VAR_GLOBAL
);
521 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
523 parse_debug_options(argvalue
);
526 checkEnvFirst
= TRUE
;
527 Var_Append(MAKEFLAGS
, "-e", VAR_GLOBAL
);
530 if (argvalue
== NULL
) goto noarg
;
531 (void)Lst_AtEnd(makefiles
, argvalue
);
535 Var_Append(MAKEFLAGS
, "-i", VAR_GLOBAL
);
538 if (argvalue
== NULL
) goto noarg
;
540 maxJobs
= strtol(argvalue
, &p
, 0);
541 if (*p
!= '\0' || maxJobs
< 1) {
542 (void)fprintf(stderr
, "%s: illegal argument to -j -- must be positive integer!\n",
546 Var_Append(MAKEFLAGS
, "-j", VAR_GLOBAL
);
547 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
548 Var_Set(".MAKE.JOBS", argvalue
, VAR_GLOBAL
, 0);
549 maxJobTokens
= maxJobs
;
553 Var_Append(MAKEFLAGS
, "-k", VAR_GLOBAL
);
556 if (argvalue
== NULL
) goto noarg
;
557 /* look for magic parent directory search string */
558 if (strncmp(".../", argvalue
, 4) == 0) {
559 if (!Dir_FindHereOrAbove(curdir
, argvalue
+4,
560 found_path
, sizeof(found_path
)))
561 break; /* nothing doing */
562 (void)Dir_AddDir(sysIncPath
, found_path
);
564 (void)Dir_AddDir(sysIncPath
, argvalue
);
566 Var_Append(MAKEFLAGS
, "-m", VAR_GLOBAL
);
567 Var_Append(MAKEFLAGS
, argvalue
, VAR_GLOBAL
);
571 Var_Append(MAKEFLAGS
, "-n", VAR_GLOBAL
);
575 /* Kind of nonsensical, wot? */
576 Var_Append(MAKEFLAGS
, "-q", VAR_GLOBAL
);
580 Var_Append(MAKEFLAGS
, "-r", VAR_GLOBAL
);
584 Var_Append(MAKEFLAGS
, "-s", VAR_GLOBAL
);
588 Var_Append(MAKEFLAGS
, "-t", VAR_GLOBAL
);
592 Var_Append(MAKEFLAGS
, "-w", VAR_GLOBAL
);
608 * See if the rest of the arguments are variable assignments and
609 * perform them if so. Else take them to be targets and stuff them
610 * on the end of the "create" list.
612 for (; argc
> 1; ++argv
, --argc
)
613 if (Parse_IsVar(argv
[1])) {
614 Parse_DoVar(argv
[1], VAR_CMD
);
617 Punt("illegal (null) argument.");
618 if (*argv
[1] == '-' && !dashDash
)
620 (void)Lst_AtEnd(create
, bmake_strdup(argv
[1]));
625 (void)fprintf(stderr
, "%s: option requires an argument -- %c\n",
631 * Main_ParseArgLine --
632 * Used by the parse module when a .MFLAGS or .MAKEFLAGS target
633 * is encountered and by main() when reading the .MAKEFLAGS envariable.
634 * Takes a line of arguments and breaks it into its
635 * component words and passes those words and the number of them to the
636 * MainParseArgs function.
637 * The line should have all its leading whitespace removed.
640 * line Line to fracture
646 * Only those that come from the various arguments.
649 Main_ParseArgLine(const char *line
)
651 char **argv
; /* Manufactured argument vector */
652 int argc
; /* Number of arguments in argv */
653 char *args
; /* Space used by the args */
655 char *argv0
= Var_Value(".MAKE", VAR_GLOBAL
, &p1
);
660 for (; *line
== ' '; ++line
)
665 buf
= bmake_malloc(len
= strlen(line
) + strlen(argv0
) + 2);
666 (void)snprintf(buf
, len
, "%s %s", argv0
, line
);
670 argv
= brk_string(buf
, &argc
, TRUE
, &args
);
672 Error("Unterminated quoted string [%s]", buf
);
677 MainParseArgs(argc
, argv
);
684 Main_SetObjdir(const char *path
)
688 char buf
[MAXPATHLEN
+ 1];
691 /* expand variable substitutions */
692 if (strchr(path
, '$') != 0) {
693 snprintf(buf
, MAXPATHLEN
, "%s", path
);
694 path
= p
= Var_Subst(NULL
, buf
, VAR_GLOBAL
, 0);
697 if (path
[0] != '/') {
698 snprintf(buf
, MAXPATHLEN
, "%s/%s", curdir
, path
);
702 /* look for the directory and try to chdir there */
703 if (stat(path
, &sb
) == 0 && S_ISDIR(sb
.st_mode
)) {
705 (void)fprintf(stderr
, "make warning: %s: %s.\n",
706 path
, strerror(errno
));
708 strncpy(objdir
, path
, MAXPATHLEN
);
709 Var_Set(".OBJDIR", objdir
, VAR_GLOBAL
, 0);
710 setenv("PWD", objdir
, 1);
722 * ReadAllMakefiles --
723 * wrapper around ReadMakefile() to read all.
726 * TRUE if ok, FALSE on error
729 ReadAllMakefiles(const void *p
, const void *q
)
731 return (ReadMakefile(p
, q
) == 0);
735 str2Lst_Append(Lst lp
, char *str
, const char *sep
)
743 for (n
= 0, cp
= strtok(str
, sep
); cp
; cp
= strtok(NULL
, sep
)) {
744 (void)Lst_AtEnd(lp
, cp
);
753 siginfo(int signo MAKE_ATTR_UNUSED
)
755 char dir
[MAXPATHLEN
];
756 char str
[2 * MAXPATHLEN
];
758 if (getcwd(dir
, sizeof(dir
)) == NULL
)
760 len
= snprintf(str
, sizeof(str
), "%s: Working in: %s\n", progname
, dir
);
762 (void)write(STDERR_FILENO
, str
, (size_t)len
);
767 * Allow makefiles some control over the mode we run in.
770 MakeMode(const char *mode
)
775 mode
= mp
= Var_Subst(NULL
, "${" MAKE_MODE
":tl}", VAR_GLOBAL
, 0);
778 if (strstr(mode
, "compat")) {
783 if (strstr(mode
, "meta"))
784 meta_mode_init(mode
);
793 * The main function, for obvious reasons. Initializes variables
794 * and a few modules, then parses the arguments give it in the
795 * environment and on the command line. Reads the system makefile
796 * followed by either Makefile, makefile or the file given by the
797 * -f argument. Sets the .MAKEFLAGS PMake variable based on all the
798 * flags it has received by then uses either the Make or the Compat
799 * module to create the initial list of targets.
802 * If -q was given, exits -1 if anything was out-of-date. Else it exits
806 * The program exits when done. Targets are created. etc. etc. etc.
809 main(int argc
, char **argv
)
811 Lst targs
; /* target nodes to create -- passed to Make_Init */
812 Boolean outOfDate
= FALSE
; /* FALSE if all targets up to date */
815 char mdpath
[MAXPATHLEN
];
816 const char *machine
= getenv("MACHINE");
817 const char *machine_arch
= getenv("MACHINE_ARCH");
818 char *syspath
= getenv("MAKESYSPATH");
819 Lst sysMkPath
; /* Path of sys.mk */
820 char *cp
= NULL
, *start
;
821 /* avoid faults on read-only strings */
822 static char defsyspath
[] = _PATH_DEFSYSPATH
;
823 char found_path
[MAXPATHLEN
+ 1]; /* for searching for sys.mk */
824 struct timeval rightnow
; /* to initialize random seed */
825 struct utsname utsname
;
827 /* default to writing debug to stderr */
831 (void)bmake_signal(SIGINFO
, siginfo
);
834 * Set the seed to produce a different random sequence
835 * on each program execution.
837 gettimeofday(&rightnow
, NULL
);
838 srandom(rightnow
.tv_sec
+ rightnow
.tv_usec
);
840 if ((progname
= strrchr(argv
[0], '/')) != NULL
)
844 #if defined(MAKE_NATIVE) || (defined(HAVE_SETRLIMIT) && defined(RLIMIT_NOFILE))
846 * get rid of resource limit on file descriptors
850 if (getrlimit(RLIMIT_NOFILE
, &rl
) != -1 &&
851 rl
.rlim_cur
!= rl
.rlim_max
) {
852 rl
.rlim_cur
= rl
.rlim_max
;
853 (void)setrlimit(RLIMIT_NOFILE
, &rl
);
858 if (uname(&utsname
) == -1) {
859 (void)fprintf(stderr
, "%s: uname failed (%s).\n", progname
,
865 * Get the name of this type of MACHINE from utsname
866 * so we can share an executable for similar machines.
867 * (i.e. m68k: amiga hp300, mac68k, sun3, ...)
869 * Note that both MACHINE and MACHINE_ARCH are decided at
874 machine
= utsname
.machine
;
877 machine
= MAKE_MACHINE
;
885 #if defined(MAKE_NATIVE) && !defined(__minix)
886 static char machine_arch_buf
[sizeof(utsname
.machine
)];
887 const int mib
[2] = { CTL_HW
, HW_MACHINE_ARCH
};
888 size_t len
= sizeof(machine_arch_buf
);
890 if (sysctl(mib
, __arraycount(mib
), machine_arch_buf
,
891 &len
, NULL
, 0) < 0) {
892 (void)fprintf(stderr
, "%s: sysctl failed (%s).\n", progname
,
897 machine_arch
= machine_arch_buf
;
900 #ifdef MAKE_MACHINE_ARCH
901 machine_arch
= MAKE_MACHINE_ARCH
;
903 machine_arch
= "unknown";
906 machine_arch
= MACHINE_ARCH
;
911 myPid
= getpid(); /* remember this for vFork() */
914 * Just in case MAKEOBJDIR wants us to do something tricky.
916 Var_Init(); /* Initialize the lists of variables for
917 * parsing arguments */
918 Var_Set(".MAKE.OS", utsname
.sysname
, VAR_GLOBAL
, 0);
919 Var_Set("MACHINE", machine
, VAR_GLOBAL
, 0);
920 Var_Set("MACHINE_ARCH", machine_arch
, VAR_GLOBAL
, 0);
922 Var_Set("MAKE_VERSION", MAKE_VERSION
, VAR_GLOBAL
, 0);
924 Var_Set(".newline", "\n", VAR_GLOBAL
, 0); /* handy for :@ loops */
926 * This is the traditional preference for makefiles.
928 #ifndef MAKEFILE_PREFERENCE_LIST
929 # define MAKEFILE_PREFERENCE_LIST "makefile Makefile"
931 Var_Set(MAKEFILE_PREFERENCE
, MAKEFILE_PREFERENCE_LIST
,
933 Var_Set(MAKE_DEPENDFILE
, ".depend", VAR_GLOBAL
, 0);
935 create
= Lst_Init(FALSE
);
936 makefiles
= Lst_Init(FALSE
);
939 variables
= Lst_Init(FALSE
);
940 beSilent
= FALSE
; /* Print commands as executed */
941 ignoreErrors
= FALSE
; /* Pay attention to non-zero returns */
942 noExecute
= FALSE
; /* Execute all commands */
943 noRecursiveExecute
= FALSE
; /* Execute all .MAKE targets */
944 keepgoing
= FALSE
; /* Stop on error */
945 allPrecious
= FALSE
; /* Remove targets when interrupted */
946 queryFlag
= FALSE
; /* This is not just a check-run */
947 noBuiltins
= FALSE
; /* Read the built-in rules */
948 touchFlag
= FALSE
; /* Actually update targets */
949 debug
= 0; /* No debug verbosity, please. */
952 maxJobs
= DEFMAXLOCAL
; /* Set default local max concurrency */
953 maxJobTokens
= maxJobs
;
954 compatMake
= FALSE
; /* No compat mode */
958 * Initialize the parsing, directory and variable modules to prepare
959 * for the reading of inclusion paths and variable settings on the
964 * Initialize various variables.
965 * MAKE also gets this name, for compatibility
966 * .MAKEFLAGS gets set to the empty string just in case.
967 * MFLAGS also gets initialized empty, for compatibility.
970 if (argv
[0][0] == '/' || strchr(argv
[0], '/') == NULL
) {
972 * Leave alone if it is an absolute path, or if it does
973 * not contain a '/' in which case we need to find it in
974 * the path, like execvp(3) and the shells do.
979 * A relative path, canonicalize it.
981 p1
= realpath(argv
[0], mdpath
);
982 if (!p1
|| *p1
!= '/' || stat(p1
, &sb
) < 0) {
983 p1
= argv
[0]; /* realpath failed */
986 Var_Set("MAKE", p1
, VAR_GLOBAL
, 0);
987 Var_Set(".MAKE", p1
, VAR_GLOBAL
, 0);
988 Var_Set(MAKEFLAGS
, "", VAR_GLOBAL
, 0);
989 Var_Set(MAKEOVERRIDES
, "", VAR_GLOBAL
, 0);
990 Var_Set("MFLAGS", "", VAR_GLOBAL
, 0);
991 Var_Set(".ALLTARGETS", "", VAR_GLOBAL
, 0);
992 /* some makefiles need to know this */
993 Var_Set(MAKE_LEVEL
".ENV", MAKE_LEVEL_ENV
, VAR_CMD
, 0);
996 * Set some other useful macros
1001 makelevel
= ((ep
= getenv(MAKE_LEVEL_ENV
)) && *ep
) ? atoi(ep
) : 0;
1004 snprintf(tmp
, sizeof(tmp
), "%d", makelevel
);
1005 Var_Set(MAKE_LEVEL
, tmp
, VAR_GLOBAL
, 0);
1006 snprintf(tmp
, sizeof(tmp
), "%u", myPid
);
1007 Var_Set(".MAKE.PID", tmp
, VAR_GLOBAL
, 0);
1008 snprintf(tmp
, sizeof(tmp
), "%u", getppid());
1009 Var_Set(".MAKE.PPID", tmp
, VAR_GLOBAL
, 0);
1011 if (makelevel
> 0) {
1013 snprintf(pn
, sizeof(pn
), "%s[%d]", progname
, makelevel
);
1014 progname
= bmake_strdup(pn
);
1021 * First snag any flags out of the MAKE environment variable.
1022 * (Note this is *not* MAKEFLAGS since /bin/make uses that and it's
1023 * in a different format).
1026 p1
= explode(getenv("MAKEFLAGS"));
1027 Main_ParseArgLine(p1
);
1030 Main_ParseArgLine(getenv("MAKE"));
1034 * Find where we are (now).
1035 * We take care of PWD for the automounter below...
1037 if (getcwd(curdir
, MAXPATHLEN
) == NULL
) {
1038 (void)fprintf(stderr
, "%s: getcwd: %s.\n",
1039 progname
, strerror(errno
));
1043 MainParseArgs(argc
, argv
);
1046 printf("%s: Entering directory `%s'\n", progname
, curdir
);
1049 * Verify that cwd is sane.
1051 if (stat(curdir
, &sa
) == -1) {
1052 (void)fprintf(stderr
, "%s: %s: %s.\n",
1053 progname
, curdir
, strerror(errno
));
1058 * All this code is so that we know where we are when we start up
1059 * on a different machine with pmake.
1060 * Overriding getcwd() with $PWD totally breaks MAKEOBJDIRPREFIX
1061 * since the value of curdir can vary depending on how we got
1062 * here. Ie sitting at a shell prompt (shell that provides $PWD)
1063 * or via subdir.mk in which case its likely a shell which does
1065 * So, to stop it breaking this case only, we ignore PWD if
1066 * MAKEOBJDIRPREFIX is set or MAKEOBJDIR contains a transform.
1068 #ifndef NO_PWD_OVERRIDE
1072 if ((pwd
= getenv("PWD")) != NULL
&&
1073 getenv("MAKEOBJDIRPREFIX") == NULL
) {
1074 const char *makeobjdir
= getenv("MAKEOBJDIR");
1076 if (makeobjdir
== NULL
|| !strchr(makeobjdir
, '$')) {
1077 if (stat(pwd
, &sb
) == 0 &&
1078 sa
.st_ino
== sb
.st_ino
&&
1079 sa
.st_dev
== sb
.st_dev
)
1080 (void)strncpy(curdir
, pwd
, MAXPATHLEN
);
1085 Var_Set(".CURDIR", curdir
, VAR_GLOBAL
, 0);
1088 * Find the .OBJDIR. If MAKEOBJDIRPREFIX, or failing that,
1089 * MAKEOBJDIR is set in the environment, try only that value
1090 * and fall back to .CURDIR if it does not exist.
1092 * Otherwise, try _PATH_OBJDIR.MACHINE, _PATH_OBJDIR, and
1093 * finally _PATH_OBJDIRPREFIX`pwd`, in that order. If none
1094 * of these paths exist, just use .CURDIR.
1097 (void)Main_SetObjdir(curdir
);
1099 if ((path
= getenv("MAKEOBJDIRPREFIX")) != NULL
) {
1100 (void)snprintf(mdpath
, MAXPATHLEN
, "%s%s", path
, curdir
);
1101 (void)Main_SetObjdir(mdpath
);
1102 } else if ((path
= getenv("MAKEOBJDIR")) != NULL
) {
1103 (void)Main_SetObjdir(path
);
1105 (void)snprintf(mdpath
, MAXPATHLEN
, "%s.%s", _PATH_OBJDIR
, machine
);
1106 if (!Main_SetObjdir(mdpath
) && !Main_SetObjdir(_PATH_OBJDIR
)) {
1107 (void)snprintf(mdpath
, MAXPATHLEN
, "%s%s",
1108 _PATH_OBJDIRPREFIX
, curdir
);
1109 (void)Main_SetObjdir(mdpath
);
1114 * Be compatible if user did not specify -j and did not explicitly
1115 * turned compatibility on
1117 if (!compatMake
&& !forceJobs
) {
1122 * Initialize archive, target and suffix modules in preparation for
1123 * parsing the makefile(s)
1128 Trace_Init(tracefile
);
1133 Trace_Log(MAKESTART
, NULL
);
1136 * Set up the .TARGETS variable to contain the list of targets to be
1137 * created. If none specified, make the variable empty -- the parser
1138 * will fill the thing in with the default or .MAIN target.
1140 if (!Lst_IsEmpty(create
)) {
1143 for (ln
= Lst_First(create
); ln
!= NULL
;
1144 ln
= Lst_Succ(ln
)) {
1145 char *name
= (char *)Lst_Datum(ln
);
1147 Var_Append(".TARGETS", name
, VAR_GLOBAL
);
1150 Var_Set(".TARGETS", "", VAR_GLOBAL
, 0);
1154 * If no user-supplied system path was given (through the -m option)
1155 * add the directories from the DEFSYSPATH (more than one may be given
1156 * as dir1:...:dirn) to the system include path.
1158 if (syspath
== NULL
|| *syspath
== '\0')
1159 syspath
= defsyspath
;
1161 syspath
= bmake_strdup(syspath
);
1163 for (start
= syspath
; *start
!= '\0'; start
= cp
) {
1164 for (cp
= start
; *cp
!= '\0' && *cp
!= ':'; cp
++)
1169 /* look for magic parent directory search string */
1170 if (strncmp(".../", start
, 4) != 0) {
1171 (void)Dir_AddDir(defIncPath
, start
);
1173 if (Dir_FindHereOrAbove(curdir
, start
+4,
1174 found_path
, sizeof(found_path
))) {
1175 (void)Dir_AddDir(defIncPath
, found_path
);
1179 if (syspath
!= defsyspath
)
1183 * Read in the built-in rules first, followed by the specified
1184 * makefile, if it was (makefile != NULL), or the default
1185 * makefile and Makefile, in that order, if it wasn't.
1190 sysMkPath
= Lst_Init(FALSE
);
1191 Dir_Expand(_PATH_DEFSYSMK
,
1192 Lst_IsEmpty(sysIncPath
) ? defIncPath
: sysIncPath
,
1194 if (Lst_IsEmpty(sysMkPath
))
1195 Fatal("%s: no system rules (%s).", progname
,
1197 ln
= Lst_Find(sysMkPath
, NULL
, ReadMakefile
);
1199 Fatal("%s: cannot open %s.", progname
,
1200 (char *)Lst_Datum(ln
));
1203 if (!Lst_IsEmpty(makefiles
)) {
1206 ln
= Lst_Find(makefiles
, NULL
, ReadAllMakefiles
);
1208 Fatal("%s: cannot open %s.", progname
,
1209 (char *)Lst_Datum(ln
));
1211 p1
= Var_Subst(NULL
, "${" MAKEFILE_PREFERENCE
"}",
1214 (void)str2Lst_Append(makefiles
, p1
, NULL
);
1215 (void)Lst_Find(makefiles
, NULL
, ReadMakefile
);
1220 /* In particular suppress .depend for '-r -V .OBJDIR -f /dev/null' */
1221 if (!noBuiltins
|| !printVars
) {
1222 makeDependfile
= Var_Subst(NULL
, "${.MAKE.DEPENDFILE:T}",
1224 doing_depend
= TRUE
;
1225 (void)ReadMakefile(makeDependfile
, NULL
);
1226 doing_depend
= FALSE
;
1231 Var_Append("MFLAGS", Var_Value(MAKEFLAGS
, VAR_GLOBAL
, &p1
), VAR_GLOBAL
);
1236 Job_ServerStart(maxJobTokens
, jp_0
, jp_1
);
1238 fprintf(debug_file
, "job_pipe %d %d, maxjobs %d, tokens %d, compat %d\n",
1239 jp_0
, jp_1
, maxJobs
, maxJobTokens
, compatMake
);
1241 Main_ExportMAKEFLAGS(TRUE
); /* initial export */
1245 * For compatibility, look at the directories in the VPATH variable
1246 * and add them to the search path, if the variable is defined. The
1247 * variable's value is in the same format as the PATH envariable, i.e.
1248 * <directory>:<directory>:<directory>...
1250 if (Var_Exists("VPATH", VAR_CMD
)) {
1253 * GCC stores string constants in read-only memory, but
1254 * Var_Subst will want to write this thing, so store it
1257 static char VPATH
[] = "${VPATH}";
1259 vpath
= Var_Subst(NULL
, VPATH
, VAR_CMD
, FALSE
);
1262 /* skip to end of directory */
1263 for (cp
= path
; *cp
!= ':' && *cp
!= '\0'; cp
++)
1265 /* Save terminator character so know when to stop */
1268 /* Add directory to search path */
1269 (void)Dir_AddDir(dirSearchPath
, path
);
1272 } while (savec
== ':');
1277 * Now that all search paths have been read for suffixes et al, it's
1278 * time to add the default search path to their lists...
1283 * Propagate attributes through :: dependency lists.
1287 /* print the initial graph, if the user requested it */
1291 /* print the values of any variables requested by the user */
1299 expandVars
= getBoolean(".MAKE.EXPAND_VARIABLES", FALSE
);
1300 for (ln
= Lst_First(variables
); ln
!= NULL
;
1301 ln
= Lst_Succ(ln
)) {
1302 char *var
= (char *)Lst_Datum(ln
);
1305 if (strchr(var
, '$')) {
1306 value
= p1
= Var_Subst(NULL
, var
, VAR_GLOBAL
, 0);
1307 } else if (expandVars
) {
1310 if (snprintf(tmp
, sizeof(tmp
), "${%s}", var
) >= (int)(sizeof(tmp
)))
1311 Fatal("%s: variable name too big: %s",
1313 value
= p1
= Var_Subst(NULL
, tmp
, VAR_GLOBAL
, 0);
1315 value
= Var_Value(var
, VAR_GLOBAL
, &p1
);
1317 printf("%s\n", value
? value
: "");
1323 * Have now read the entire graph and need to make a list of
1324 * targets to create. If none was given on the command line,
1325 * we consult the parsing module to find the main target(s)
1328 if (Lst_IsEmpty(create
))
1329 targs
= Parse_MainName();
1331 targs
= Targ_FindList(create
, TARG_CREATE
);
1335 * Initialize job module before traversing the graph
1336 * now that any .BEGIN and .END targets have been read.
1337 * This is done only if the -q flag wasn't given
1338 * (to prevent the .BEGIN from being executed should
1346 /* Traverse the graph, checking on all the targets */
1347 outOfDate
= Make_Run(targs
);
1350 * Compat_Init will take care of creating all the
1351 * targets as well as initializing the module.
1358 Lst_Destroy(targs
, NULL
);
1359 Lst_Destroy(variables
, NULL
);
1360 Lst_Destroy(makefiles
, NULL
);
1361 Lst_Destroy(create
, (FreeProc
*)free
);
1364 /* print the graph now it's been processed if the user requested it */
1368 Trace_Log(MAKEEND
, 0);
1371 printf("%s: Leaving directory `%s'\n", progname
, curdir
);
1382 return outOfDate
? 1 : 0;
1387 * Open and parse the given makefile.
1390 * 0 if ok. -1 if couldn't open file.
1396 ReadMakefile(const void *p
, const void *q MAKE_ATTR_UNUSED
)
1398 const char *fname
= p
; /* makefile to read */
1400 size_t len
= MAXPATHLEN
;
1401 char *name
, *path
= bmake_malloc(len
);
1403 if (!strcmp(fname
, "-")) {
1404 Parse_File(NULL
/*stdin*/, -1);
1405 Var_Set("MAKEFILE", "", VAR_INTERNAL
, 0);
1407 /* if we've chdir'd, rebuild the path name */
1408 if (strcmp(curdir
, objdir
) && *fname
!= '/') {
1409 size_t plen
= strlen(curdir
) + strlen(fname
) + 2;
1411 path
= bmake_realloc(path
, len
= 2 * plen
);
1413 (void)snprintf(path
, len
, "%s/%s", curdir
, fname
);
1414 fd
= open(path
, O_RDONLY
);
1420 /* If curdir failed, try objdir (ala .depend) */
1421 plen
= strlen(objdir
) + strlen(fname
) + 2;
1423 path
= bmake_realloc(path
, len
= 2 * plen
);
1424 (void)snprintf(path
, len
, "%s/%s", objdir
, fname
);
1425 fd
= open(path
, O_RDONLY
);
1431 fd
= open(fname
, O_RDONLY
);
1435 /* look in -I and system include directories. */
1436 name
= Dir_FindFile(fname
, parseIncPath
);
1438 name
= Dir_FindFile(fname
,
1439 Lst_IsEmpty(sysIncPath
) ? defIncPath
: sysIncPath
);
1440 if (!name
|| (fd
= open(name
, O_RDONLY
)) == -1) {
1448 * set the MAKEFILE variable desired by System V fans -- the
1449 * placement of the setting here means it gets set to the last
1450 * makefile specified, as it is set by SysV make.
1454 Var_Set("MAKEFILE", fname
, VAR_INTERNAL
, 0);
1455 Parse_File(fname
, fd
);
1465 * Execute the command in cmd, and return the output of that command
1469 * A string containing the output of the command, or the empty string
1470 * If errnum is not NULL, it contains the reason for the command failure
1473 * The string must be freed by the caller.
1476 Cmd_Exec(const char *cmd
, const char **errnum
)
1478 const char *args
[4]; /* Args for invoking the shell */
1479 int fds
[2]; /* Pipe streams */
1480 int cpid
; /* Child PID */
1481 int pid
; /* PID from wait() */
1482 char *res
; /* result */
1483 int status
; /* command exit status */
1484 Buffer buf
; /* buffer to store the result */
1494 * Set up arguments for shell
1496 args
[0] = shellName
;
1502 * Open a pipe for fetching its output
1504 if (pipe(fds
) == -1) {
1505 *errnum
= "Couldn't create pipe for \"%s\"";
1512 switch (cpid
= vFork()) {
1515 * Close input side of pipe
1517 (void)close(fds
[0]);
1520 * Duplicate the output stream to the shell's output, then
1521 * shut the extra thing down. Note we don't fetch the error
1522 * stream...why not? Why?
1524 (void)dup2(fds
[1], 1);
1525 (void)close(fds
[1]);
1529 (void)execv(shellPath
, UNCONST(args
));
1534 *errnum
= "Couldn't exec \"%s\"";
1539 * No need for the writing half
1541 (void)close(fds
[1]);
1546 char result
[BUFSIZ
];
1547 cc
= read(fds
[0], result
, sizeof(result
));
1549 Buf_AddBytes(&buf
, cc
, result
);
1551 while (cc
> 0 || (cc
== -1 && errno
== EINTR
));
1554 * Close the input side of the pipe.
1556 (void)close(fds
[0]);
1559 * Wait for the process to exit.
1561 while(((pid
= waitpid(cpid
, &status
, 0)) != cpid
) && (pid
>= 0)) {
1562 JobReapChild(pid
, status
, FALSE
);
1565 cc
= Buf_Size(&buf
);
1566 res
= Buf_Destroy(&buf
, FALSE
);
1569 *errnum
= "Couldn't read shell's output for \"%s\"";
1571 if (WIFSIGNALED(status
))
1572 *errnum
= "\"%s\" exited on a signal";
1573 else if (WEXITSTATUS(status
) != 0)
1574 *errnum
= "\"%s\" returned non-zero status";
1577 * Null-terminate the result, convert newlines to spaces and
1578 * install it in the variable.
1583 if (cc
> 0 && *--cp
== '\n') {
1585 * A final newline is just stripped
1599 res
= bmake_malloc(1);
1606 * Print an error message given its format.
1612 * The message is printed.
1616 Error(const char *fmt
, ...)
1621 err_file
= debug_file
;
1622 if (err_file
== stdout
)
1624 (void)fflush(stdout
);
1627 fprintf(err_file
, "%s: ", progname
);
1628 (void)vfprintf(err_file
, fmt
, ap
);
1630 (void)fprintf(err_file
, "\n");
1631 (void)fflush(err_file
);
1632 if (err_file
== stderr
)
1640 * Produce a Fatal error message. If jobs are running, waits for them
1651 Fatal(const char *fmt
, ...)
1659 (void)fflush(stdout
);
1660 (void)vfprintf(stderr
, fmt
, ap
);
1662 (void)fprintf(stderr
, "\n");
1663 (void)fflush(stderr
);
1665 PrintOnError(NULL
, NULL
);
1667 if (DEBUG(GRAPH2
) || DEBUG(GRAPH3
))
1669 Trace_Log(MAKEERROR
, 0);
1670 exit(2); /* Not 1 so -q can distinguish error */
1675 * Major exception once jobs are being created. Kills all jobs, prints
1676 * a message and exits.
1682 * All children are killed indiscriminately and the program Lib_Exits
1686 Punt(const char *fmt
, ...)
1691 (void)fflush(stdout
);
1692 (void)fprintf(stderr
, "%s: ", progname
);
1693 (void)vfprintf(stderr
, fmt
, ap
);
1695 (void)fprintf(stderr
, "\n");
1696 (void)fflush(stderr
);
1698 PrintOnError(NULL
, NULL
);
1705 * Exit without giving a message.
1720 Trace_Log(MAKEERROR
, 0);
1721 exit(2); /* Not 1, so -q can distinguish error */
1726 * Called when aborting due to errors in child shell to signal
1737 /* number of errors encountered in Make_Make */
1739 Fatal("%d error%s", errors
, errors
== 1 ? "" : "s");
1744 * Remove a file carefully, avoiding directories.
1747 eunlink(const char *file
)
1751 if (lstat(file
, &st
) == -1)
1754 if (S_ISDIR(st
.st_mode
)) {
1758 return unlink(file
);
1763 * Print why exec failed, avoiding stdio.
1766 execError(const char *af
, const char *av
)
1770 struct iovec iov
[8];
1772 (void)(iov[i].iov_base = UNCONST(s), \
1773 iov[i].iov_len = strlen(iov[i].iov_base), \
1776 #define IOADD(void)write(2, s, strlen(s))
1784 IOADD(") failed (");
1785 IOADD(strerror(errno
));
1789 while (writev(2, iov
, 8) == -1 && errno
== EAGAIN
)
1796 * exit with usage message
1802 if ((p
= strchr(progname
, '[')) != NULL
)
1805 (void)fprintf(stderr
,
1806 "usage: %s [-BeikNnqrstWwX] \n\
1807 [-C directory] [-D variable] [-d flags] [-f makefile]\n\
1808 [-I directory] [-J private] [-j max_jobs] [-m directory] [-T file]\n\
1809 [-V variable] [variable=value] [target ...]\n", progname
);
1815 PrintAddr(void *a
, void *b
)
1817 printf("%lx ", (unsigned long) a
);
1824 PrintOnError(GNode
*gn
, const char *s
)
1826 static GNode
*en
= NULL
;
1833 printf("\n%s: stopped in %s\n", progname
, curdir
);
1836 return; /* we've been here! */
1839 * We can print this even if there is no .ERROR target.
1841 Var_Set(".ERROR_TARGET", gn
->name
, VAR_GLOBAL
, 0);
1843 strncpy(tmp
, "${MAKE_PRINT_VAR_ON_ERROR:@v@$v='${$v}'\n@}",
1845 cp
= Var_Subst(NULL
, tmp
, VAR_GLOBAL
, 0);
1852 * Finally, see if there is a .ERROR target, and run it if so.
1854 en
= Targ_FindNode(".ERROR", TARG_NOCREATE
);
1856 en
->type
|= OP_SPECIAL
;
1857 Compat_Make(en
, en
);
1862 Main_ExportMAKEFLAGS(Boolean first
)
1864 static int once
= 1;
1872 strncpy(tmp
, "${.MAKEFLAGS} ${.MAKEOVERRIDES:O:u:@v@$v=${$v:Q}@}",
1874 s
= Var_Subst(NULL
, tmp
, VAR_CMD
, 0);
1877 setenv("MAKEFLAGS", s
, 1);
1879 setenv("MAKE", s
, 1);
1887 static char *tmpdir
= NULL
;
1893 * Honor $TMPDIR but only if it is valid.
1894 * Ensure it ends with /.
1896 tmpdir
= Var_Subst(NULL
, "${TMPDIR:tA:U" _PATH_TMP
"}/", VAR_GLOBAL
, 0);
1897 if (stat(tmpdir
, &st
) < 0 || !S_ISDIR(st
.st_mode
)) {
1899 tmpdir
= bmake_strdup(_PATH_TMP
);
1906 * Create and open a temp file using "pattern".
1907 * If "fnamep" is provided set it to a copy of the filename created.
1908 * Otherwise unlink the file once open.
1911 mkTempFile(const char *pattern
, char **fnamep
)
1913 static char *tmpdir
= NULL
;
1914 char tfile
[MAXPATHLEN
];
1920 tmpdir
= getTmpdir();
1921 if (pattern
[0] == '/') {
1922 snprintf(tfile
, sizeof(tfile
), "%s", pattern
);
1924 snprintf(tfile
, sizeof(tfile
), "%s%s", tmpdir
, pattern
);
1926 if ((fd
= mkstemp(tfile
)) < 0)
1927 Punt("Could not create temporary file %s: %s", tfile
, strerror(errno
));
1929 *fnamep
= bmake_strdup(tfile
);
1931 unlink(tfile
); /* we just want the descriptor */
1938 * Return a Boolean based on setting of a knob.
1940 * If the knob is not set, the supplied default is the return value.
1941 * If set, anything that looks or smells like "No", "False", "Off", "0" etc,
1942 * is FALSE, otherwise TRUE.
1945 getBoolean(const char *name
, Boolean bf
)
1950 if (snprintf(tmp
, sizeof(tmp
), "${%s:tl}", name
) < (int)(sizeof(tmp
))) {
1951 cp
= Var_Subst(NULL
, tmp
, VAR_GLOBAL
, 0);
1955 case '\0': /* not set - the default wins */