components/multimedia/gst-plugins-good/patches/08-flxdec-bounds1.patch

   1 From af7f70e60e364b551c2589dee5fb458a83fa0e7e Mon Sep 17 00:00:00 2001
   2 From: Matthew Waters <matthew@centricular.com>
   3 Date: Tue, 22 Nov 2016 23:46:00 +1100
   4 Subject: flxdec: fix some warnings comparing unsigned < 0
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 bf43f44fcfada5ec4a3ce60cb374340486fe9fac was comparing an unsigned
  10 expression to be < 0 which was always false.
  11
  12 gstflxdec.c: In function ‘flx_decode_brun’:
  13 gstflxdec.c:322:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  14          if ((glong) row - count < 0) {
  15                                  ^
  16 gstflxdec.c:332:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  17          if ((glong) row - count < 0) {
  18                                  ^
  19
  20 https://bugzilla.gnome.org/show_bug.cgi?id=774834
  21
  22 Index: gst-plugins-good0.10-0.10.31/gst/flx/gstflxdec.c
  23 ===================================================================
  24 --- gst-plugins-good0.10-0.10.31.orig/gst/flx/gstflxdec.c       2016-11-22 08:53:19.577997632 -0500
  25 +++ gst-plugins-good0.10-0.10.31/gst/flx/gstflxdec.c    2016-11-22 08:53:19.569997540 -0500
  26 @@ -341,7 +341,7 @@
  27        if (count > 0x7f) {
  28          /* literal run */
  29          count = 0x100 - count;
  30 -        if ((glong) row - count < 0) {
  31 +        if ((glong) row - (glong) count < 0) {
  32            GST_ERROR_OBJECT (flxdec, "Invalid BRUN packet detected.");
  33            return FALSE;
  34          }
  35 @@ -351,7 +351,7 @@
  36            *dest++ = *data++;
  37
  38        } else {
  39 -        if ((glong) row - count < 0) {
  40 +        if ((glong) row - (glong) count < 0) {
  41            GST_ERROR_OBJECT (flxdec, "Invalid BRUN packet detected.");
  42            return FALSE;
  43          }