| commit | 5720a38cfe95b00ca4be5016dd0d2f3195f4fa04 | |
| author | epriestley <git@epriestley.com> | |
| Mon, 13 Nov 2023 18:53:58 +0000 (13 10:53 -0800) | ||
| committer | epriestley <git@epriestley.com> | |
| Mon, 13 Nov 2023 19:04:04 +0000 (13 11:04 -0800) | ||
| tree | 8119a2afe692f338b8e578bba4b6a165d70eb8ce | treesnapshot (tar.gz zip) |
| parent | 40b272fa51eadf9cfb5420b1ddc69c96818c3f90 | commitdiff |
Correct Aphlict websocket URI construction after PHP8 compatibility changes
Summary:
See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:
1. no "path" argument; and
2. "cluster.instance" not set.
Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.
Also fix a couple other string-null issues I caught locally.
Test Plan: Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.
Maniphest Tasks: T13700
Differential Revision: https://secure.phabricator.com/D21875
Summary:
See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:
1. no "path" argument; and
2. "cluster.instance" not set.
Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.
Also fix a couple other string-null issues I caught locally.
Test Plan: Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.
Maniphest Tasks: T13700
Differential Revision: https://secure.phabricator.com/D21875