1 From c0d732a6233af2f148c59f3b81f95f429ea235cb Mon Sep 17 00:00:00 2001
2 From: Prasad J Pandit <pjp@fedoraproject.org>
3 Date: Wed, 2 Mar 2016 17:29:58 +0530
4 Subject: [PATCH] net: check packet payload length
6 While computing IP checksum, 'net_checksum_calculate' reads
7 payload length from the packet. It could exceed the given 'data'
8 buffer size. Add a check to avoid it.
10 Reported-by: Liu Ling <liuling-it@360.cn>
11 Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
12 Signed-off-by: Jason Wang <jasowang@redhat.com>
14 net/checksum.c | 10 ++++++++--
15 1 file changed, 8 insertions(+), 2 deletions(-)
17 diff --git a/net/checksum.c b/net/checksum.c
18 index 14c0855..0942437 100644
21 @@ -59,6 +59,11 @@ void net_checksum_calculate(uint8_t *data, int length)
22 int hlen, plen, proto, csum_offset;
25 + /* Ensure data has complete L2 & L3 headers. */
26 + if (length < 14 + 20) {
30 if ((data[14] & 0xf0) != 0x40)
31 return; /* not IPv4 */
32 hlen = (data[14] & 0x0f) * 4;
33 @@ -76,8 +81,9 @@ void net_checksum_calculate(uint8_t *data, int length)
37 - if (plen < csum_offset+2)
39 + if (plen < csum_offset + 2 || 14 + hlen + plen > length) {
43 data[14+hlen+csum_offset] = 0;
44 data[14+hlen+csum_offset+1] = 0;